| jlvillal | lifeless: working on creating a bug.... This patch is taking a loooong time... :( | 00:00 |
|---|---|---|
| *** naohirot has joined #openstack-ironic | 00:02 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Update unittests and use NamedTemporaryFile https://review.openstack.org/162672 | 00:05 |
| jlvillal | lifeless: mrda: ^^^^^^^ | 00:06 |
| mrda | jlvillal: already looking at it :) | 00:07 |
| jlvillal | :) | 00:07 |
| *** penick has joined #openstack-ironic | 00:12 | |
| *** jmccrory has joined #openstack-ironic | 00:17 | |
| *** jmccrory has quit IRC | 00:17 | |
| mrda | jlvillal: Just some comments on that review. Feel free to poke me if you don't understand my babblings | 00:18 |
| jlvillal | mrda: Thanks! Will look now :) | 00:18 |
| *** jmccrory has joined #openstack-ironic | 00:20 | |
| *** jmccrory has quit IRC | 00:20 | |
| *** penick has quit IRC | 00:20 | |
| jlvillal | mrda: My brain is hurting trying to figure out how to test what you suggested :D | 00:25 |
| mrda | sorry | 00:25 |
| mrda | I think in your test helper method you could catch the exception raised, check the file disappreaed, before reraising | 00:26 |
| jlvillal | mrda: Yeah, I think that might work there. | 00:26 |
| jlvillal | mrda: The other ones seem more difficult, as I don't have that info. | 00:26 |
| mrda | otherwise we don't know it has disappeared on the exception case | 00:26 |
| jlvillal | mrda: I don't know the name of the file if the exception occurs on the write. | 00:27 |
| jlvillal | mrda: On the exception generated by NamedTemporaryFile, we don't need to check that as f will never be set because of the exception. | 00:27 |
| jlvillal | mrda: So it would leave the f.write() check. Unsure at the moment. | 00:28 |
| *** stendulker has joined #openstack-ironic | 00:28 | |
| mrda | some things aren't easy to test | 00:28 |
| mrda | :) | 00:28 |
| jlvillal | mrda: yeah. And it is almost testing that the underlying library is work. Which is somewhat out of scope of a unittest. I'm not sure that the 'del f' is really required as when the function exits that would get taken care of automatically. | 00:29 |
| jlvillal | lifeless: Could probably explain better the use case for the 'del f'. In my thinking it might not be needed, but maybe it covers some special corner case. | 00:30 |
| * jlvillal decides to go home for the day. | 00:30 | |
| *** spandhe has joined #openstack-ironic | 00:31 | |
| jlvillal | Good night, good bye Ironic :) | 00:31 |
| mrda | Night jlvillal | 00:31 |
| *** absubram has joined #openstack-ironic | 00:33 | |
| *** spandhe_ has joined #openstack-ironic | 00:34 | |
| *** spandhe has quit IRC | 00:35 | |
| *** spandhe_ is now known as spandhe | 00:35 | |
| devananda | mrda: comments on microversion spec | 00:35 |
| devananda | mrda: have a minute to chat? | 00:36 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 00:42 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 00:42 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 00:42 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 00:43 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 00:43 |
| *** Haomeng has joined #openstack-ironic | 00:45 | |
| *** jmccrory has joined #openstack-ironic | 00:47 | |
| *** mtanino has quit IRC | 00:47 | |
| *** Haomeng|2 has quit IRC | 00:48 | |
| *** jmccrory has quit IRC | 00:52 | |
| *** jmccrory has joined #openstack-ironic | 00:53 | |
| *** chlong has quit IRC | 00:55 | |
| *** chlong has joined #openstack-ironic | 00:55 | |
| mrda | sorry devananda, back now | 00:59 |
| mrda | happy to chat if you have time | 00:59 |
| mrda | devananda: ^^^ or is it too late now? | 01:03 |
| *** igordcard_ has quit IRC | 01:03 | |
| *** rwsu is now known as rwsu-afk | 01:04 | |
| devananda | mrda: sorry, nope. gotta run :( | 01:05 |
| mrda | no probs | 01:05 |
| lifeless | jlvillal: the del f? | 01:14 |
| lifeless | jlvillal: if there is an exception thrown from this frame | 01:15 |
| lifeless | jlvillal: we don't want the file leaked while the frame object is alive | 01:15 |
| lifeless | jlvillal: locals() holds a reference to f (because locals() is effectively a dict) | 01:16 |
| lifeless | jlvillal: so we can either depend on the frame eventually being cleared, which may or may not be before interpreter shutdown etc | 01:16 |
| lifeless | jlvillal: or we can be explicit that we care - which because this is an external resource, we do. | 01:16 |
| lifeless | jlvillal: another way of writing it would be a single try:finally:del f around the entire function body (after f=None) | 01:17 |
| lifeless | jlvillal: or even a separate context manager that will ensure deletes but not futz with exceptions | 01:17 |
| lifeless | jlvillal: a third way would be to get rid of our explicit exception entirely as unneeded and instead just do a trivial with NamedTempFile as f: f.write(); f.flush(); yield f.name | 01:18 |
| lifeless | jlvillal: since its only our except: statement in there at all that leads to incorrect exceptions being reported. | 01:18 |
| *** mtanino has joined #openstack-ironic | 01:21 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 01:25 |
| *** chenglch has joined #openstack-ironic | 01:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/163667 | 01:34 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 01:39 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement cleaning/zapping for the agent driver https://review.openstack.org/161453 | 01:43 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 01:47 |
| *** ijw has quit IRC | 02:14 | |
| *** jmccrory has quit IRC | 02:38 | |
| *** ramineni has joined #openstack-ironic | 02:39 | |
| *** achanda has quit IRC | 02:42 | |
| *** david-lyle is now known as david-lyle_afk | 02:45 | |
| *** stendulker has quit IRC | 02:45 | |
| *** Marga_ has quit IRC | 02:51 | |
| *** oomichi has joined #openstack-ironic | 02:52 | |
| openstackgerrit | jiangfei proposed openstack/python-ironicclient: Log token with sha1 https://review.openstack.org/162517 | 02:52 |
| *** jmccrory has joined #openstack-ironic | 02:53 | |
| *** jmccrory has quit IRC | 02:53 | |
| *** jmccrory has joined #openstack-ironic | 02:53 | |
| *** zz_jgrimm is now known as jgrimm | 03:03 | |
| *** mtanino has quit IRC | 03:24 | |
| *** rameshg87 has joined #openstack-ironic | 03:27 | |
| rameshg87 | good morning ironic | 03:28 |
| *** mdbooth has quit IRC | 03:28 | |
| *** mdbooth has joined #openstack-ironic | 03:34 | |
| *** ijw has joined #openstack-ironic | 03:36 | |
| *** ijw has quit IRC | 03:41 | |
| *** jmccrory has quit IRC | 03:47 | |
| *** Marga_ has joined #openstack-ironic | 03:53 | |
| *** penick has joined #openstack-ironic | 04:06 | |
| openstackgerrit | Michael Davies proposed openstack/ironic-specs: API Microversions https://review.openstack.org/161110 | 04:09 |
| mrda | morning rameshg87 | 04:09 |
| rameshg87 | good afternoon mrda :) | 04:09 |
| *** penick has quit IRC | 04:12 | |
| *** oomichi has quit IRC | 04:13 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Use labels for virtual media dev in agent ramdisk https://review.openstack.org/162392 | 04:15 |
| *** Marga_ has quit IRC | 04:15 | |
| *** Marga_ has joined #openstack-ironic | 04:16 | |
| jlvillal | mrda: rameshg87: When one of the cores get online, can you ask them to review https://review.openstack.org/163629 ? The gate for python-ironicclient is blocked. The change has gone into global-requirements. So just need it to go into python-ironicclient also. | 04:19 |
| jlvillal | Or if there is a core here that can look that would be great :) | 04:19 |
| rameshg87 | jlvillal: sure.. | 04:21 |
| mrda | jlvillal: we have rameshg87 who is a core right here :) | 04:21 |
| jlvillal | rameshg87: Thank you. Hopefully you get enabled soon! Congrats by the way. | 04:21 |
| rameshg87 | mrda: no, still haven't got those rights yet :) | 04:22 |
| jlvillal | mrda: Unfortunately I didn't see his name in the group list :( Hopefully he gets added soon! | 04:22 |
| mrda | oh, the status but not the power. The best of both worlds right now | 04:23 |
| mrda | (or is it the worst right now?) | 04:23 |
| mrda | :) | 04:23 |
| rameshg87 | yeah sort of inbetween both :) | 04:23 |
| jlvillal | rameshg87: Seems well deserved to me. You have given my patches some great feedback. you too mrda! | 04:23 |
| mrda | ironic is working well together :) | 04:23 |
| openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 04:24 |
| rameshg87 | :) | 04:24 |
| *** devlaps has quit IRC | 04:25 | |
| mrda | jlvillal: that change looks fine to me | 04:26 |
| mrda | (fwiw) | 04:26 |
| jlvillal | mrda: Thanks. yeah a new version of httpretty came out today. I don't think the infra guys like httpretty. | 04:26 |
| mrda | and shouldn't you be jlvillal_should_be_sleeping by now? | 04:26 |
| mrda | httpretty has had it's issues | 04:26 |
| jlvillal | mrda: West coaster here. So 21:27 at the moment | 04:26 |
| mrda | not too bad then | 04:27 |
| mrda | still too late to be working mind you | 04:27 |
| jlvillal | mrda: Yep. I guess there is an alternative. requests-mock, I think. | 04:27 |
| rameshg87 | yeah blacklisting more and more versions seem to be headache, right ? | 04:27 |
| rameshg87 | Haomeng: you around ? | 04:28 |
| rameshg87 | Haomeng: can you please have a look at https://review.openstack.org/#/c/163629/ if you got some time ... | 04:28 |
| *** gridinv_ has joined #openstack-ironic | 04:28 | |
| jlvillal | jiangfei: FYI: Your patch: https://review.openstack.org/#/c/162517/ is failing py34 tests because of httpretty issue. Hopefully fix gets merged relatively soon. | 04:28 |
| mrda | there's a few packages like that if you peruse global-requirements. Sphinx being another | 04:29 |
| *** ijw has joined #openstack-ironic | 04:31 | |
| *** achanda has joined #openstack-ironic | 04:31 | |
| jlvillal | rameshg87: mrda: should exception messages be translateable? | 04:34 |
| jlvillal | Wondering if the should be _("blahblah") or is "blahblah" enough. | 04:34 |
| jlvillal | s/the/they/ | 04:34 |
| rameshg87 | jlvillal: yes | 04:37 |
| mrda | yes use _() for the human bits of an exception | 04:37 |
| *** ijw has quit IRC | 04:37 | |
| rameshg87 | jlvillal: even logging messages except debug should be translateable | 04:37 |
| jlvillal | rameshg87: Thanks. On the down-side, it is your patch I'm reviewing ;) | 04:37 |
| rameshg87 | oh ! :) | 04:37 |
| rameshg87 | jlvillal: missed it then .. pleast post comment :) | 04:38 |
| mrda | jlvillal: don't translate the exception itself though :) Only the human-readable-and-supplied part | 04:38 |
| jlvillal | rameshg87: I just posted comment. | 04:38 |
| jlvillal | mrda: rameshg87: It was here: https://review.openstack.org/#/c/162392/3/ironic_python_agent/utils.py | 04:39 |
| *** killer_prince is now known as lazy_prince | 04:39 | |
| jlvillal | mrda: I think it is human-readable. But not exactly sure the distinction you mean. | 04:39 |
| rameshg87 | jlvillal: but that is agent ramdisk no | 04:39 |
| jlvillal | mrda: So maybe I'm not-understanding | 04:39 |
| mrda | "Unable to find virtual media device" should be translated with _() | 04:40 |
| rameshg87 | jlvillal: they still don't have i18n in place. (i guess because no human directly interacts with ramdisk) | 04:40 |
| jlvillal | rameshg87: Oh. So IPA doesn't have any I18N working? | 04:40 |
| rameshg87 | jlvillal: the exception messages coming out of ipa ramdisk are translated in ironic | 04:41 |
| rameshg87 | jlvillal: example https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/image.py#L67-L70 | 04:41 |
| mrda | oh | 04:41 |
| mrda | interesting | 04:42 |
| rameshg87 | jlvillal: the above is message is not translated in ipa ramdisk | 04:42 |
| jlvillal | rameshg87: Thanks for the info. I think it is going to take awhile before I feel like I know this stuff! | 04:42 |
| rameshg87 | jlvillal: the when ironic invokes it | 04:42 |
| rameshg87 | jlvillal: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_base_vendor.py#L365-L369 | 04:42 |
| rameshg87 | jlvillal: it translates the result['command_error'] | 04:43 |
| jlvillal | rameshg87: Thanks! | 04:43 |
| rameshg87 | jlvillal: i guess it makes sense because humans are not expected to directly talk to ramdisk ;-) | 04:43 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Use labels for virtual media dev in agent ramdisk https://review.openstack.org/162392 | 04:46 |
| rameshg87 | jlvillal: done with s/L/Liberty ^^^ | 04:46 |
| jlvillal | rameshg87: Thanks. Maybe at some point in the future there will be this big search for "Liberty" to fix those issues :) | 04:46 |
| * jlvillal now wonders if it should be a TODO .... | 04:47 | |
| rameshg87 | jlvillal: yeah i agree..it makes things a lot easier | 04:47 |
| jlvillal | rameshg87: mrda and the rest of Ironic: Have a great day. Time to go to sleep :) | 04:48 |
| mrda | :) | 04:48 |
| rameshg87 | jlvillal: good night ... | 04:49 |
| mrda | have a good rest | 04:49 |
| Haomeng | rameshg87: good morning:) | 04:49 |
| Haomeng | rameshg87: sure, let take look | 04:49 |
| rameshg87 | Haomeng: good morning :) | 04:49 |
| rameshg87 | Haomeng: thanks .. | 04:49 |
| Haomeng | rameshg87: :) | 04:49 |
| *** lazy_prince has quit IRC | 04:49 | |
| Haomeng | rameshg87: welcome, my pleasure:) | 04:49 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Inpects hardware to get some of the capabilities https://review.openstack.org/163572 | 04:50 |
| *** lazy_prince has joined #openstack-ironic | 04:51 | |
| *** lazy_prince is now known as killer_prince | 04:53 | |
| *** killer_prince is now known as lazy_prince | 04:58 | |
| *** achanda has quit IRC | 05:04 | |
| *** david-ly_ has joined #openstack-ironic | 05:04 | |
| *** omnibus7 has joined #openstack-ironic | 05:05 | |
| *** lazy_pri- has joined #openstack-ironic | 05:05 | |
| *** kevinbenton_ has joined #openstack-ironic | 05:05 | |
| *** ijw has joined #openstack-ironic | 05:06 | |
| *** devanand1 has joined #openstack-ironic | 05:07 | |
| *** GheRiver1 has joined #openstack-ironic | 05:07 | |
| *** richard_1aw has joined #openstack-ironic | 05:07 | |
| *** lazy_prince has quit IRC | 05:09 | |
| *** lazy_pri- is now known as lazy_prince | 05:09 | |
| *** david-lyle_afk has quit IRC | 05:09 | |
| *** mikal_ has joined #openstack-ironic | 05:09 | |
| *** devananda has quit IRC | 05:09 | |
| *** davidlenwell has quit IRC | 05:09 | |
| *** kevinbenton has quit IRC | 05:09 | |
| *** GheRivero has quit IRC | 05:09 | |
| *** richard_maw has quit IRC | 05:09 | |
| *** mikal has quit IRC | 05:09 | |
| *** rameshg87 is now known as rameshg87-brb | 05:11 | |
| *** ijw has quit IRC | 05:12 | |
| *** absubram has quit IRC | 05:15 | |
| openstackgerrit | Anusha Ramineni proposed openstack/ironic: Add Cleaning Operations for iLO drivers https://review.openstack.org/157715 | 05:18 |
| *** stendulker has joined #openstack-ironic | 05:23 | |
| *** gridinv_ has quit IRC | 05:25 | |
| *** pradipta has joined #openstack-ironic | 05:26 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 05:28 |
| *** achanda has joined #openstack-ironic | 05:28 | |
| *** yuanying has joined #openstack-ironic | 05:30 | |
| *** harlowja_ is now known as harlowja_away | 05:41 | |
| openstackgerrit | Anusha Ramineni proposed stackforge/proliantutils: IPA_HW_MANAGER: Add support to get_clean_steps https://review.openstack.org/162870 | 05:43 |
| ramineni | rameshg87: ^^^ | 05:43 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 05:44 |
| *** yog_ has joined #openstack-ironic | 05:45 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 05:46 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 05:46 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 05:46 |
| rameshg87-brb | ramineni: done..thanks :) | 05:47 |
| Haomeng | rameshg87-brb: +a for https://review.openstack.org/#/c/163629/, hope this can fix the ironicclient blocking issue | 05:52 |
| *** rameshg87-brb is now known as rameshg87 | 05:54 | |
| rameshg87 | Haomeng: thanks :) | 05:54 |
| Haomeng | rameshg87: :) | 05:54 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add whole disk image support in iscsi_ilo driver https://review.openstack.org/163589 | 05:54 |
| *** yog_ has quit IRC | 05:55 | |
| *** wuhg has joined #openstack-ironic | 05:56 | |
| rameshg87 | hey testing your change through ipa now | 05:58 |
| rameshg87 | i mean ramineni ^^ | 05:58 |
| rameshg87 | :) | 05:58 |
| jiangfei | jlvillal: ok, let me check it, thank you | 06:05 |
| *** ijw has joined #openstack-ironic | 06:06 | |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers using pxe_ucs driver https://review.openstack.org/159734 | 06:06 |
| openstackgerrit | Merged openstack/python-ironicclient: Avoid httpretty 0.8.8 as it can break unittests https://review.openstack.org/163629 | 06:08 |
| *** yog_ has joined #openstack-ironic | 06:11 | |
| *** ijw has quit IRC | 06:11 | |
| *** spandhe has quit IRC | 06:18 | |
| jiangfei | rameshg87: hi | 06:18 |
| *** kalpase has joined #openstack-ironic | 06:18 | |
| rameshg87 | jiangfei: hi | 06:19 |
| jiangfei | rameshg87: patch 'https://review.openstack.org/163629' can solved unittest. i just to do recheck? | 06:21 |
| rameshg87 | jiangfei: i didn't get. was that a question to me ? | 06:23 |
| *** yog_ has quit IRC | 06:24 | |
| Haomeng | jiangfei: you mean it works now, ok | 06:27 |
| Haomeng | jiangfei: ? | 06:27 |
| jiangfei | rameshg87: I thought about you and discuss with jlvillal about unittest failed. jlvillal should go to bed, so I ask if you are after as long as he merge the path, my patch is will ok | 06:28 |
| jiangfei | Haomeng: yes. | 06:29 |
| Haomeng | jiangfei: ok, thanks | 06:29 |
| rameshg87 | jiangfei: so did you have a patch that was waiting for https://review.openstack.org/#/c/163629/ to get merged ? | 06:30 |
| jiangfei | rameshg87: thank you. i have got it. have no question :) | 06:33 |
| rameshg87 | jiangfei: :) | 06:33 |
| *** lazy_prince is now known as killer_prince | 06:35 | |
| *** yog_ has joined #openstack-ironic | 06:36 | |
| *** killer_prince is now known as lazy_prince | 06:37 | |
| jiangfei | Haomeng: currently, ironic-api does support https? | 06:40 |
| Haomeng | jiangfei: did not test, dont think so:) | 06:40 |
| jiangfei | Haomeng: i report the bug about it, https://bugs.launchpad.net/ironic/+bug/1430213 | 06:41 |
| openstack | Launchpad bug 1430213 in Ironic "ironic-api support https" [Undecided,New] - Assigned to jiangfei (jiangfei0622) | 06:41 |
| Haomeng | jiangfei: ok, let me check | 06:45 |
| jiangfei | Haomeng: thank you | 06:45 |
| Haomeng | jiangfei: welcome | 06:45 |
| openstackgerrit | jiangfei proposed openstack/python-ironicclient: Log token with sha1 https://review.openstack.org/162517 | 06:58 |
| openstackgerrit | jiangfei proposed openstack/python-ironicclient: Log token with sha1 https://review.openstack.org/162517 | 07:00 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers using pxe_ucs driver https://review.openstack.org/159734 | 07:04 |
| *** ijw has joined #openstack-ironic | 07:06 | |
| *** Marga_ has quit IRC | 07:07 | |
| *** ukalifon1 has joined #openstack-ironic | 07:07 | |
| *** sdake has quit IRC | 07:08 | |
| *** achanda has quit IRC | 07:11 | |
| *** ijw has quit IRC | 07:11 | |
| *** lazy_prince has quit IRC | 07:15 | |
| *** lazy_prince has joined #openstack-ironic | 07:16 | |
| *** sdake has joined #openstack-ironic | 07:19 | |
| *** sdake has quit IRC | 07:19 | |
| *** sdake has joined #openstack-ironic | 07:19 | |
| *** pas-ha has joined #openstack-ironic | 07:20 | |
| *** saripurigopi has joined #openstack-ironic | 07:23 | |
| *** achanda has joined #openstack-ironic | 07:24 | |
| *** jcoufal has joined #openstack-ironic | 07:27 | |
| *** lazy_prince has quit IRC | 07:33 | |
| *** lazy_prince has joined #openstack-ironic | 07:34 | |
| *** lazy_prince is now known as killer_prince | 07:35 | |
| *** killer_prince is now known as lazy_prince | 07:39 | |
| *** achanda has quit IRC | 07:44 | |
| *** habuka036 has quit IRC | 07:48 | |
| *** sdake has quit IRC | 07:49 | |
| *** lazy_prince has quit IRC | 07:52 | |
| *** lazy_prince has joined #openstack-ironic | 07:53 | |
| *** lazy_prince is now known as killer_prince | 07:54 | |
| *** pas-ha has quit IRC | 07:55 | |
| *** kozhukalov has joined #openstack-ironic | 07:56 | |
| *** killer_prince is now known as lazy_prince | 07:57 | |
| *** jrist has quit IRC | 07:59 | |
| *** jrist has joined #openstack-ironic | 08:00 | |
| *** jistr has joined #openstack-ironic | 08:03 | |
| *** Haomeng has quit IRC | 08:03 | |
| *** Haomeng has joined #openstack-ironic | 08:04 | |
| *** ijw has joined #openstack-ironic | 08:06 | |
| *** chenglch|2 has joined #openstack-ironic | 08:09 | |
| *** chenglch has quit IRC | 08:09 | |
| *** athomas has joined #openstack-ironic | 08:11 | |
| *** ijw has quit IRC | 08:12 | |
| *** yuanying has quit IRC | 08:13 | |
| *** ifarkas has joined #openstack-ironic | 08:14 | |
| *** GheRiver1 is now known as GheRivero | 08:15 | |
| *** pradipta has quit IRC | 08:16 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 08:16 |
| openstackgerrit | Michael Davies proposed openstack/ironic: New field 'name' not supported in port REST API https://review.openstack.org/163730 | 08:20 |
| mrda | rloo ^^^ here's the Port API fix for logical name. Thanks for finding the bug! | 08:21 |
| *** sdake_ has joined #openstack-ironic | 08:25 | |
| *** sdake_ has quit IRC | 08:25 | |
| *** sdake_ has joined #openstack-ironic | 08:25 | |
| *** mrda is now known as mrda-away | 08:27 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 08:30 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 08:30 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers using pxe_ucs driver https://review.openstack.org/159734 | 08:30 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 08:30 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers using pxe_ucs driver https://review.openstack.org/159734 | 08:33 |
| openstackgerrit | jiangfei proposed openstack/ironic: ironic-api support https https://review.openstack.org/163735 | 08:45 |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: IPA_HW_MANAGER: Add support to get_clean_steps https://review.openstack.org/162870 | 08:46 |
| *** Nisha has joined #openstack-ironic | 08:59 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC Virtual Media Deploy module for iRMC Driver https://review.openstack.org/151958 | 08:59 |
| GheRivero | morning all | 09:01 |
| *** ijw has joined #openstack-ironic | 09:06 | |
| *** ijw has quit IRC | 09:11 | |
| openstackgerrit | IWAMOTO Toshihiro proposed openstack/ironic-python-agent: Add logs REST resource https://review.openstack.org/163737 | 09:13 |
| *** lazy_prince is now known as killer_prince | 09:15 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add localboot support for iscsi_irmc driver https://review.openstack.org/163738 | 09:19 |
| *** derekh has joined #openstack-ironic | 09:23 | |
| *** lucasagomes has joined #openstack-ironic | 09:26 | |
| *** tiagogomes_ has joined #openstack-ironic | 09:26 | |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers. https://review.openstack.org/159734 | 09:27 |
| *** yog_ has quit IRC | 09:30 | |
| *** subscope has joined #openstack-ironic | 09:30 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add uefi support in image extension https://review.openstack.org/163739 | 09:32 |
| *** yog_ has joined #openstack-ironic | 09:39 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_context package https://review.openstack.org/162499 | 09:56 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_policy package https://review.openstack.org/162501 | 09:58 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Sync from oslo.incubator https://review.openstack.org/162505 | 09:58 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_log lib https://review.openstack.org/157602 | 10:00 |
| *** naohirot has quit IRC | 10:00 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add uefi support in image extension https://review.openstack.org/163739 | 10:02 |
| *** ijw has joined #openstack-ironic | 10:06 | |
| *** richard_1aw is now known as richard_maw | 10:09 | |
| *** killer_prince is now known as lazy_prince | 10:09 | |
| *** chenglch|2 has quit IRC | 10:10 | |
| *** pas-ha has joined #openstack-ironic | 10:11 | |
| *** ijw has quit IRC | 10:11 | |
| rameshg87 | lucasagomes: hi | 10:12 |
| rameshg87 | lucasagomes: changed to use labels: https://review.openstack.org/#/c/160687/ | 10:12 |
| rameshg87 | lucasagomes: please check when you get some time | 10:13 |
| lucasagomes | rameshg87, hi there, will do. Finishing something up first and then I take a look | 10:14 |
| lucasagomes | thanks | 10:14 |
| *** athomas has quit IRC | 10:14 | |
| *** athomas has joined #openstack-ironic | 10:15 | |
| *** athomas has quit IRC | 10:15 | |
| Nisha | lucasagomes, hi | 10:17 |
| Nisha | rameshg87, hi | 10:18 |
| *** lazy_pri- has joined #openstack-ironic | 10:18 | |
| *** lazy_prince has quit IRC | 10:18 | |
| *** lazy_pri- is now known as lazy_prince | 10:18 | |
| lucasagomes | Nisha, hello there | 10:19 |
| rameshg87 | lucasagomes: thanks .. | 10:19 |
| rameshg87 | Nisha: hi | 10:19 |
| Nisha | need reviews on couple of reviews https://review.openstack.org/151596 , https://review.openstack.org/148804, https://review.openstack.org/155900, https://review.openstack.org/163572 | 10:19 |
| rameshg87 | Nisha: sure will review it today itself, into something right now ... :) | 10:20 |
| Nisha | lucasagomes, rameshg87 https://review.openstack.org/161861 this too | 10:20 |
| *** athomas has joined #openstack-ironic | 10:23 | |
| openstackgerrit | Aparna proposed stackforge/proliantutils: ILO: Support for configuring httpboot through RIS https://review.openstack.org/163325 | 10:24 |
| *** lazy_pri- has joined #openstack-ironic | 10:24 | |
| *** lazy_prince has quit IRC | 10:26 | |
| *** lazy_pri- is now known as lazy_prince | 10:26 | |
| *** andreykurilin_ has joined #openstack-ironic | 10:26 | |
| *** lazy_prince is now known as killer_prince | 10:27 | |
| *** killer_prince is now known as lazy_prince | 10:33 | |
| *** jistr has quit IRC | 10:36 | |
| *** MattMan has joined #openstack-ironic | 10:37 | |
| *** pelix has joined #openstack-ironic | 10:41 | |
| saripurigopi | which are all test I need to run before submitting for code review? I'm running pep8, py27 test suits. I'm seeing failures in the Jenkins check. | 10:43 |
| *** yog_ has quit IRC | 10:44 | |
| *** ndipanov has joined #openstack-ironic | 10:45 | |
| *** Nisha has quit IRC | 10:45 | |
| rameshg87 | saripurigopi: you can just run tox | 10:46 |
| rameshg87 | saripurigopi: it covers all the tests | 10:46 |
| saripurigopi | okay | 10:46 |
| *** subscope has quit IRC | 10:49 | |
| *** jistr has joined #openstack-ironic | 10:53 | |
| *** Haomeng|2 has joined #openstack-ironic | 10:56 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 10:57 |
| *** Haomeng has quit IRC | 10:59 | |
| *** yog_ has joined #openstack-ironic | 11:00 | |
| *** subscope has joined #openstack-ironic | 11:00 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 11:01 |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: ILO: Add support for GET_EMBEDDED_HEALTH https://review.openstack.org/158041 | 11:03 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers https://review.openstack.org/159734 | 11:03 |
| *** ijw has joined #openstack-ironic | 11:06 | |
| *** ramineni has quit IRC | 11:09 | |
| *** ijw has quit IRC | 11:11 | |
| *** andreykurilin_ has quit IRC | 11:18 | |
| *** yog_ has quit IRC | 11:21 | |
| *** yuanying has joined #openstack-ironic | 11:23 | |
| *** yuanying has quit IRC | 11:28 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 11:38 |
| *** stendulker has quit IRC | 11:56 | |
| *** ijw has joined #openstack-ironic | 12:06 | |
| *** albertoffb has joined #openstack-ironic | 12:08 | |
| *** ijw has quit IRC | 12:12 | |
| *** rameshg87 has left #openstack-ironic | 12:18 | |
| openstackgerrit | Aparna proposed stackforge/proliantutils: ILO: Support for configuring httpboot through RIS https://review.openstack.org/163325 | 12:20 |
| *** lazy_prince is now known as killer_prince | 12:24 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add validate for root device hints https://review.openstack.org/163794 | 12:25 |
| *** saripurigopi has quit IRC | 12:30 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add validations for root device hints https://review.openstack.org/163794 | 12:31 |
| *** dprince has joined #openstack-ironic | 12:37 | |
| *** Marga_ has joined #openstack-ironic | 12:40 | |
| albertoffb | Hello everyone, I'm new working with ironic bare metal nodes and I'm trying to understand better about the node's field but I couldn't find any documentation about it, so anyone knows what are "extra", "driver_info" and "driver_internal_info" - fields in a Ironic node - meant to be used for? | 12:40 |
| *** kalpase has left #openstack-ironic | 12:43 | |
| *** rloo has joined #openstack-ironic | 12:43 | |
| *** vipul has quit IRC | 12:48 | |
| *** vipul has joined #openstack-ironic | 12:48 | |
| lintan | hi albertoffb, simply saying driver_info is input from user for driver driver_internal_info is used by driver and should not touched by user | 12:48 |
| *** devanand1 has quit IRC | 12:49 | |
| *** devananda has joined #openstack-ironic | 12:50 | |
| albertoffb | lintan Ok, I understood now. Thank you very much for the help | 12:52 |
| lintan | albertoffb, :) | 12:53 |
| *** jjohnson2 has joined #openstack-ironic | 12:57 | |
| *** ijw has joined #openstack-ironic | 13:06 | |
| *** kkoski has joined #openstack-ironic | 13:08 | |
| jroll | albertoffb: and "extra" is for the operator to put arbitrary data. for example, we put serial numbers there. | 13:10 |
| jroll | morning ironic :) | 13:10 |
| lintan | morning jroll :) | 13:12 |
| *** ijw has quit IRC | 13:12 | |
| jroll | hiya lintan :) | 13:12 |
| albertoffb | jroll Ok, now I know all what I need, Thank you very much for help. And good morning :) | 13:16 |
| jroll | you're welcome, good morning :) | 13:17 |
| *** frontrunner has joined #openstack-ironic | 13:24 | |
| *** albertoffb has quit IRC | 13:28 | |
| *** rloo has quit IRC | 13:29 | |
| *** rloo has joined #openstack-ironic | 13:30 | |
| rloo | hi yuriyz. Hi! ;) wrt https://review.openstack.org/#/c/152858/, are you OK if it is approved? Wondering why you didn't do it. | 13:36 |
| yuriyz | hello rloo i'm ok | 13:36 |
| rloo | yuriyz: do you want to do the honours? | 13:37 |
| yuriyz | ok | 13:37 |
| yuriyz | will do now | 13:37 |
| rloo | yuriyz: thx! | 13:37 |
| lintan | Thanks yuriyz and rloo | 13:37 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Add AMT-PXE driver doc https://review.openstack.org/152859 | 13:43 |
| *** Marga_ has quit IRC | 13:49 | |
| *** Marga_ has joined #openstack-ironic | 13:50 | |
| NobodyCam | good morning Ironicers :) | 13:57 |
| sirushti | Hi rloo yuriyz, could you'll please take a look at https://review.openstack.org/#/c/150142/? I had to rebase it. | 13:58 |
| *** rameshg87 has joined #openstack-ironic | 14:02 | |
| *** r-daneel has joined #openstack-ironic | 14:03 | |
| lucasagomes | rloo, yuriyz NobodyCam sirushti rloo lintan morning | 14:03 |
| NobodyCam | morining lucasagomes :) | 14:03 |
| yuriyz | morning lucasagomes NobodyCam | 14:03 |
| rloo | hi lucasagomes, sirushti, NobodyCam, and everyone else. | 14:04 |
| rloo | sirushti: in the middle of reviewing a patch; will look at yours next | 14:04 |
| sirushti | morning all to everyone here :) | 14:04 |
| sirushti | rloo, thanks | 14:04 |
| NobodyCam | morining sirushti :) | 14:05 |
| NobodyCam | morning rloo | 14:05 |
| NobodyCam | morning yuriyz :) | 14:06 |
| *** ijw has joined #openstack-ironic | 14:06 | |
| *** Marga_ has quit IRC | 14:08 | |
| NobodyCam | yuriyz: got a second to chat about 160383? | 14:11 |
| yuriyz | yes | 14:11 |
| NobodyCam | :) | 14:11 |
| *** ijw has quit IRC | 14:12 | |
| NobodyCam | hey my goal with that patch is to test that the directory is usable at startup | 14:12 |
| NobodyCam | other wise the operator wont get an error until they attempt a deploy | 14:14 |
| NobodyCam | I do agree that the work jlvillal is doing is also much needed! and very nice wrok | 14:14 |
| yuriyz | NobodyCam IMO at least size check at startup does not make sense because free size can reduce after some time | 14:14 |
| NobodyCam | yuriyz: I had added that check in the early revs when I was calling from validaye | 14:15 |
| NobodyCam | valdate even :-p | 14:15 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor node capability methods to ironic/common https://review.openstack.org/162451 | 14:19 |
| yuriyz | ok, I want to see 'final' patch, remove -1 | 14:20 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add driver interface for RAID configuration https://review.openstack.org/155230 | 14:25 |
| *** BadCub_Away is now known as BadCub | 14:27 | |
| NobodyCam | yuriyz: Thank you :) | 14:27 |
| BadCub | Morning Iroinc | 14:29 |
| NobodyCam | good morning BadCub :) | 14:30 |
| *** viktors has joined #openstack-ironic | 14:32 | |
| openstackgerrit | Merged openstack/ironic: Add AMT-PXE-Driver Power&Management&Vendor Interface https://review.openstack.org/152858 | 14:34 |
| openstackgerrit | Merged openstack/python-ironicclient: Fix the final PEP8 errors https://review.openstack.org/163202 | 14:34 |
| *** achanda has joined #openstack-ironic | 14:36 | |
| *** stendulker has joined #openstack-ironic | 14:41 | |
| *** r-daneel has quit IRC | 14:42 | |
| *** achanda has quit IRC | 14:44 | |
| *** r-daneel has joined #openstack-ironic | 14:45 | |
| *** saripurigopi has joined #openstack-ironic | 14:45 | |
| BadCub | Morning Nobad | 14:49 |
| BadCub | NobodyCam: | 14:49 |
| NobodyCam | lol | 14:49 |
| NobodyCam | nobad! I loke it | 14:49 |
| NobodyCam | lol like even | 14:49 |
| BadCub | lol | 14:51 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add validations for root device hints https://review.openstack.org/163794 | 14:52 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: IPA: Add support for root device hints https://review.openstack.org/163857 | 14:52 |
| * BadCub seems functioning at low caffeine levels poorly lol | 14:52 | |
| lucasagomes | rloo, hey thanks much for the reviews on root device hints for IPA, I didn't catch that returning the first device thing | 14:52 |
| lucasagomes | (: | 14:53 |
| rloo | lucasagomes: yw. That's what a reviewer does ;). Although I feel like I'm starting to burn out. | 14:53 |
| lucasagomes | rloo, yeah, fair enough | 14:54 |
| saripurigopi | I've submitted pxe_ucs driver code for review, https://review.openstack.org/#/c/159734/. | 14:54 |
| rameshg87 | lucasagomes: just posted my few comments | 14:55 |
| rameshg87 | lucasagomes: one quick question | 14:55 |
| rameshg87 | lucasagomes: https://review.openstack.org/#/c/163794/3/ironic/drivers/modules/iscsi_deploy.py | 14:55 |
| rameshg87 | lucasagomes: doesn't the contents in properties/capabilities be normalized for the same reasons as why we normalize in kernel cmdline arguments ? | 14:55 |
| saripurigopi | I'm seeing failures in check-tempest-dsvm-ironic-pxe_ssh-postgres, check-tempest-dsvm-ironic-parallel-nv. I didnot modify any code relevant to this area. Can some one help me resolving these errors. | 14:56 |
| *** penick has joined #openstack-ironic | 14:56 | |
| *** penick has quit IRC | 14:56 | |
| lucasagomes | rameshg87, not sure if I follow, we don't pass the capabilities via kernel cmdline | 14:57 |
| lucasagomes | problem is that in kernel cmdline we can't have spaces (or it's threated as a new kernel option) | 14:57 |
| rameshg87 | saripurigopi: i think it's an intermittent problem | 14:57 |
| lucasagomes | so I urlencode the root device hints | 14:57 |
| lucasagomes | saripurigopi, will take a look | 14:58 |
| rameshg87 | saripurigopi: i just gave recheck now, jenkins will rerun the tests | 14:58 |
| saripurigopi | rameshg87, okay, sure thank you. | 14:58 |
| rameshg87 | lucasagomes: oh but in capabilities we use commas | 14:58 |
| rameshg87 | lucasagomes: okay got it | 14:58 |
| rameshg87 | lucasagomes: for one moment i thought capabilities also had space .. my mistake :) | 14:59 |
| lucasagomes | :) | 14:59 |
| lucasagomes | yeah I use commas on the device hints too to separate each hint | 14:59 |
| lucasagomes | rameshg87, btw I would love to have capabilties as a dict in Ironic | 14:59 |
| saripurigopi | could you share the ironic jenkins tracking page link. | 14:59 |
| lucasagomes | we could maintain the string for backward compat | 14:59 |
| lucasagomes | but strings are just a pain in ... to edit, add a new capability, delete etc... | 15:00 |
| rameshg87 | lucasagomes: yeah, it is .. :) | 15:01 |
| rameshg87 | lucasagomes: but i am wondering where does root device hint belong | 15:02 |
| rameshg87 | lucasagomes: it's not property of hardware | 15:02 |
| rameshg87 | lucasagomes: niether some instance-specific data | 15:02 |
| rameshg87 | lucasagomes: may be a driver capability ? | 15:02 |
| rameshg87 | saripurigopi: http://status.openstack.org/zuul/ | 15:02 |
| rameshg87 | saripurigopi: you can type your review number 159734, it will show the progress of your tests | 15:03 |
| jlvillal | rloo: You sure do a lot of reviews! :) I could understand getting burnt out some... | 15:03 |
| saripurigopi | rameshg87, thank you. Will check that. | 15:03 |
| lucasagomes | rameshg87, well it describe some characterists of the hardware right? | 15:03 |
| lucasagomes | like disk_gb in properties describe the size of the disk | 15:04 |
| rloo | jlvillal: you're doing a good job yourself of reviewing ;) | 15:04 |
| rameshg87 | lucasagomes: hmm yeah | 15:04 |
| lucasagomes | root device hints is the same, but more granular, you can also describe serial numbers, size etc | 15:04 |
| lucasagomes | rameshg87, that's why I put it on properties | 15:04 |
| rameshg87 | lucasagomes: agreed, makes sense | 15:04 |
| rsFF | hi guys, can anyone tell me how to run IPA in standalone mode? | 15:05 |
| lucasagomes | and since the idea was to add support to all drivers, it's common across all deploy drivers | 15:05 |
| rameshg87 | lucasagomes: someday the properties needs to be turned to a dctionary then | 15:05 |
| lucasagomes | rsFF, what u mean? | 15:05 |
| lucasagomes | rameshg87, it is already | 15:05 |
| jlvillal | rloo: I like the small patches best ;) Those giant patches are intimidating. | 15:05 |
| rameshg87 | lucasagomes: i mean nested dictionaries | 15:05 |
| lucasagomes | node.properties[key] = value :) | 15:05 |
| rsFF | lucasagomes - i would like to test IPA, and would like to set up a env | 15:05 |
| lucasagomes | rameshg87, it's already too | 15:05 |
| lucasagomes | root device hints is a dict | 15:05 |
| rameshg87 | oh | 15:05 |
| rsFF | thing is there is a flag to run in "debug" | 15:05 |
| rsFF | standalone | 15:05 |
| lucasagomes | node.properties[roode_device] = {model: blah, foo: bar} | 15:05 |
| rloo | jlvillal: understandable. but someone (more than one) needs to review them... | 15:06 |
| rsFF | but it fails with requirements | 15:06 |
| *** ijw has joined #openstack-ironic | 15:06 | |
| lucasagomes | rameshg87, all json fields support nested dicts (lists too) | 15:06 |
| lucasagomes | cause they are json primitives | 15:06 |
| rsFF | lucasagomes - is the dockerfile that ships with it the correct way? | 15:06 |
| rameshg87 | lucasagomes: then why do we still have capabilities in an old way | 15:06 |
| lucasagomes | rsFF, hmm I haven't tried that | 15:07 |
| jroll | rsFF: how does it fail? how are you building it? | 15:07 |
| lucasagomes | rameshg87, backward compat | 15:07 |
| rameshg87 | lucasagomes: shouldn't we be converting them to json type dictionaries ? | 15:07 |
| lucasagomes | jroll, JayF ^ | 15:07 |
| rameshg87 | lucasagomes: hmm ... yeah | 15:07 |
| lucasagomes | rameshg87, yup, that's what I mean about it being a dict | 15:07 |
| rsFF | jroll - python agent.py ? | 15:07 |
| lucasagomes | we could support both and then later remove the string thing | 15:07 |
| lucasagomes | rameshg87, dicts are just way more easy to manipulate in python | 15:07 |
| lucasagomes | I think we have a bug open for that ^ | 15:08 |
| lucasagomes | wishlist or something | 15:08 |
| rameshg87 | lucasagomes: yeah, but conversion of string -> json dict can't be handled in db migration scripts | 15:08 |
| rameshg87 | ? | 15:08 |
| jroll | rsFF: to run it locally standalone... cd ironic-python-agent; pip install -r requirements.txt; pip install .; ironic-python-agent --standalone | 15:08 |
| jroll | rsFF: (off the top of my head, might not be perfect) | 15:08 |
| lucasagomes | rameshg87, hmm I was thinking about simple support both without converting it automagically | 15:08 |
| rsFF | jroll - oki doki | 15:09 |
| jroll | rsFF: you probably want to do this in a virtualenv, by the way | 15:09 |
| lucasagomes | like if the user puts a string we can test the type | 15:09 |
| rsFF | yeah... | 15:09 |
| lucasagomes | and simple parse it as a string (like it is today) | 15:09 |
| rsFF | jroll - what about the dockerfile? | 15:09 |
| rsFF | can i use it? | 15:09 |
| lucasagomes | if the type is dict then things are way easier and we just use it :) | 15:09 |
| rameshg87 | but lucasagomes now we do properties/capabilities="param1:value1,param2:value2" | 15:09 |
| lucasagomes | rameshg87, yes, we could do properties/capabilities={"param1": "value1, "param2" : "value2"} | 15:10 |
| rameshg87 | and will it work today ? | 15:10 |
| lucasagomes | and when parsing it we test whether it's a dict or string, and parse it accordingly | 15:10 |
| lucasagomes | rameshg87, yes it will | 15:10 |
| rameshg87 | oh | 15:10 |
| rameshg87 | awesome | 15:10 |
| * rameshg87 notes the point | 15:10 | |
| jroll | rsFF: sure, it totally works :) we typically use it as part of the build process, but it should just work. though with a normal "docker run" it won't have hardware access, see this for how we run it: https://github.com/openstack/ironic-python-agent/blob/master/imagebuild/coreos/oem/cloud-config.yml#L55-64 | 15:10 |
| lucasagomes | and we should LOG an exception saying strings are deprecated | 15:10 |
| jroll | rsFF: what's your end goal here? :) | 15:10 |
| rameshg87 | lucasagomes: but it can't be a mix of both | 15:10 |
| rsFF | jroll - just try to fix some bugs | 15:11 |
| rameshg87 | lucasagomes: right ? | 15:11 |
| lucasagomes | rameshg87, yea | 15:11 |
| rsFF | jroll - https://bugs.launchpad.net/ironic/+bug/1409169 | 15:11 |
| openstack | Launchpad bug 1409169 in Ironic "IPA LLDP lookups loop forever" [High,Triaged] - Assigned to Ricardo Ferreira (rsff) | 15:11 |
| rameshg87 | lucasagomes: then any code in ironic that manipulates properties/capabilities in ironic is in soup, right ? | 15:11 |
| *** ijw has quit IRC | 15:11 | |
| rameshg87 | lucasagomes: it has to first try converting to json | 15:11 |
| rameshg87 | lucasagomes: if it fails, then try assuming it is properties/capabilities="param1:value1,param2:value2" | 15:12 |
| rameshg87 | lucasagomes: and then error out | 15:12 |
| lucasagomes | rameshg87, for a while until we remove string support we should check for the type | 15:12 |
| jroll | rsFF: awesome, you may be able to get more info from JoshNang about that. not sure if/how lldp will work when running in a docker container, may want to run it directly on a system that has lldp :) | 15:12 |
| lucasagomes | rameshg87, yeah pretty much | 15:12 |
| lucasagomes | or just test isinstance() of that type | 15:12 |
| lucasagomes | str or dict | 15:12 |
| jroll | rsFF: JoshNang also did the standalone thing so he may be able to help you out with testing that | 15:12 |
| rameshg87 | lucasagomes: for example: https://github.com/openstack/ironic/blob/master/ironic/drivers/utils.py#L147-L198 | 15:13 |
| JoshNang | rsFF: umm, off the top of my head, you would need to run it with --net=host | 15:13 |
| rsFF | ok, I already had some initial chat with him. | 15:13 |
| rameshg87 | lucasagomes: it adds/removes a single capability | 15:13 |
| rameshg87 | lucasagomes: i assumes that it is of form properties/capabilities="param1:value1,param2:value2" | 15:13 |
| rsFF | JoshNang - thats an option for the IPA or the docker? | 15:13 |
| JoshNang | rsFF: docker | 15:13 |
| rsFF | okay | 15:14 |
| jroll | yeah, --net=host is the thing | 15:14 |
| lucasagomes | rameshg87, yea that all need to be worked out to check the type first | 15:14 |
| lucasagomes | and manipulate it accordingly | 15:14 |
| rameshg87 | oh | 15:14 |
| JoshNang | not completely sure that'll give you access to lldp packets though.. | 15:14 |
| lucasagomes | so there's work to do :) | 15:14 |
| JoshNang | it should | 15:14 |
| lucasagomes | but it would be nice just to be able to use a dict and not a string anymore | 15:14 |
| rameshg87 | lucasagomes: so first check for json dictionary, then string, then fail | 15:15 |
| lucasagomes | I think it worth the work (but I don't have time right now) | 15:15 |
| rameshg87 | yeah :) | 15:15 |
| lucasagomes | yes | 15:15 |
| rsFF | JoshNang - i will try, btw tcpdump flags? | 15:16 |
| rsFF | 'ether proto 0x88cc' | 15:16 |
| rsFF | will do the trick? | 15:16 |
| JoshNang | it should yeah | 15:16 |
| rsFF | okis | 15:16 |
| JoshNang | i'm pretty sure that's how we verified it on agents before i wrote the lldp stuff :) | 15:16 |
| rsFF | nice, :) | 15:16 |
| rameshg87 | lucasagomes: then i think we should file a bug and get it fixed | 15:17 |
| lucasagomes | rameshg87, I think there's one already | 15:17 |
| rameshg87 | lucasagomes: for my raid work, i had proposed to refactor these methods to ironic/common (to a higher place) | 15:17 |
| rameshg87 | https://review.openstack.org/#/c/162451/2 | 15:17 |
| rameshg87 | lucasagomes: may be i can get them fixed too .. :) | 15:18 |
| lucasagomes | rameshg87, https://bugs.launchpad.net/ironic/+bug/1421261 | 15:18 |
| openstack | Launchpad bug 1421261 in Ironic " node's properties['capabilities'] value should be a dictionary" [Wishlist,Triaged] | 15:18 |
| lucasagomes | rameshg87, :) that would be cool | 15:18 |
| rameshg87 | lucasagomes: the problem right now i see is | 15:18 |
| rameshg87 | lucasagomes: some features work on properties/capabilities="param1:value1,param2:value2" format | 15:18 |
| rameshg87 | lucasagomes: and some other features work on format of json dictionaries | 15:19 |
| rameshg87 | lucasagomes: so in short, we can't use these 2 features together :( | 15:19 |
| rameshg87 | for example uefi boot mode manipulates with the formal properties/capabilities="param1:value1,param2:value2" | 15:19 |
| rameshg87 | so uefi + root device hints = broken :( | 15:20 |
| rameshg87 | unless we get this fixed ... | 15:20 |
| lucasagomes | rameshg87, hmm being a string or a dict is just the struct that the data is in, should impact on what is supported or what is not supported. it should be the same data but parsed differently | 15:20 |
| lucasagomes | rameshg87, not sure if I follow... root device hints and capabilities are different things | 15:20 |
| lucasagomes | should not impact* | 15:21 |
| rameshg87 | lucasagomes: not sure .. give me a moment, i will be right back | 15:21 |
| *** rameshg87 is now known as rameshg87-brb | 15:21 | |
| lucasagomes | ack | 15:21 |
| *** david-ly_ is now known as david-lyle | 15:23 | |
| *** ChuckC has joined #openstack-ironic | 15:26 | |
| jlvillal | rloo: I think this: https://review.openstack.org/#/c/163667/ can be abandoned. | 15:27 |
| jroll | NobodyCam: http://i.imgur.com/fzSWzkD.gifv | 15:28 |
| rloo | jlvillal: I would think the 'system' is smart enough to figure out at some point, that there is some sort of merge conflict? (I didn't look at the change that you submitted directly to the client) | 15:29 |
| rameshg87-brb | jroll: :D | 15:29 |
| jlvillal | rloo: Okay. I don't know how "smart" the system is. | 15:29 |
| rloo | jlvillal: i'm curious... ;) | 15:29 |
| jroll | :) | 15:29 |
| jroll | jlvillal: rloo next round of requirements updates it will see that change | 15:30 |
| jroll | just leave it until the next patchset :) | 15:30 |
| jlvillal | jroll: Okay. And so it will automatically abandon that change? Or create a patchset 2? Or ignore it? | 15:31 |
| jroll | next time it has an update to make, it will make a new patchset | 15:31 |
| rloo | jlvillal: see, the bot doesn't need as much hand holding as people do :-) | 15:32 |
| BadCub | The cable guy is finally here to install real internets!!! | 15:32 |
| jlvillal | rloo: jroll: Thanks | 15:32 |
| jroll | np! | 15:32 |
| * rloo expects great things from BadCub after he has real internet :D | 15:32 | |
| jroll | ^ | 15:32 |
| jroll | grats BadCub! | 15:32 |
| *** rwsu-afk is now known as rwsu | 15:33 | |
| *** rameshg87-brb is now known as rameshg87 | 15:33 | |
| rameshg87 | lucasagomes: i am back .. let me know if you have some time | 15:33 |
| *** krotscheck has joined #openstack-ironic | 15:36 | |
| BadCub | rloo: great things? Wow, that is a lot of pressure. Can we settle for somewhat good things, most of the time? LOL | 15:37 |
| jlvillal | rloo: jroll: With my Intel hat on. This patch: https://review.openstack.org/#/c/152859/ has three +2 votes. Any idea what it needs to get a +A? | 15:37 |
| rloo | BadCub: well, sure, I forgot that you are bad. One good thing is probably acceptable ;) | 15:38 |
| rloo | jlvillal: yeah, i had approved that before. i'll reapprove. i think i was going to clean up the grammar etc afterwards anyway. | 15:39 |
| jlvillal | rloo: Oh, I see it used to depend on a different patch. Which is now merged. | 15:39 |
| jlvillal | rloo: And thanks | 15:40 |
| rloo | jlvillal: yw | 15:40 |
| NobodyCam | :) woo realz internets | 15:40 |
| lucasagomes | rameshg87, ack just addressing some commments | 15:40 |
| BadCub | rloo: LOL | 15:40 |
| jroll | lol | 15:41 |
| lucasagomes | jroll, hah cool dogs | 15:42 |
| jroll | lucasagomes: ikr? more cuteness: https://i.chzbgr.com/maxW500/7970323200/hF947A9FE/ | 15:43 |
| * jroll is in a channel that is on a gif train right now | 15:43 | |
| lucasagomes | jroll, (: awesome | 15:44 |
| NobodyCam | lol so cute! it hurts | 15:44 |
| lucasagomes | jroll, https://instagram.com/biddythehedgehog | 15:44 |
| jroll | oh my | 15:45 |
| NobodyCam | really a hedgehog has over 620K followers | 15:46 |
| lucasagomes | heh yeah | 15:46 |
| jroll | lol | 15:46 |
| NobodyCam | :-p | 15:46 |
| jroll | NobodyCam: clearly the only solution for your follower woes is to turn into a hedgehog. | 15:47 |
| NobodyCam | lol /me has only a seldome used twitter account, | 15:47 |
| NobodyCam | :-p | 15:47 |
| * lucasagomes doesn't have a twitter account | 15:48 | |
| lucasagomes | gotta make one | 15:48 |
| * BadCub has no idea how many followers he has now | 15:48 | |
| NobodyCam | you know who needs an account is Pixie! | 15:49 |
| lucasagomes | NobodyCam, that would be awesome to have a stuffed pixie toy | 15:49 |
| rloo | Pixie needs a new hairdo. Just Joking. not sure where that thought came from... | 15:49 |
| NobodyCam | humm | 15:49 |
| jroll | heh | 15:49 |
| lucasagomes | lol | 15:50 |
| * lucasagomes remembers he still needs to try to draw a drumset | 15:50 | |
| * BadCub is taking votes on what color his hair and beard should be for Vancouver LOL | 15:50 | |
| jroll | lol | 15:51 |
| * jlvillal sticks with salt and pepper for his own beard ;) | 15:51 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor node capability methods to ironic/common https://review.openstack.org/162451 | 15:51 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add driver interface for RAID configuration https://review.openstack.org/155230 | 15:52 |
| * NobodyCam is just going grey | 15:52 | |
| * jroll notices rameshg87 is the only one doing work here :P | 15:52 | |
| rameshg87 | jroll: :) | 15:52 |
| jroll | (that's completely ok with me, just pointing it out) | 15:52 |
| lucasagomes | hah | 15:52 |
| lucasagomes | lazy thursday | 15:52 |
| rameshg87 | jroll: i am still watching the instagrams and urls that you post here ... | 15:52 |
| jroll | hehehe | 15:53 |
| rloo | is rameshg87 a core reviewer yet? | 15:56 |
| jroll | no :( | 15:56 |
| rameshg87 | rloo: no :( | 15:56 |
| rloo | devananda: what are we waiting for? can we make rameshg87 a core reviewer? I want him to review and approve all the patches for k-3 :-) | 15:57 |
| * devananda fixes that | 15:58 | |
| jroll | there's only been 3 core +1's on the list :/ | 15:58 |
| jroll | oh, ok :P | 15:58 |
| devananda | rloo: so ^ is why I hadn't done it | 15:58 |
| devananda | rloo: you wanted public voting ... | 15:58 |
| rloo | devananda: yeah, 3 is enough? how many votes are needed? | 15:58 |
| devananda | and less than half have rsponded | 15:58 |
| rloo | devananda: ohhh. so we expect at least half? | 15:59 |
| devananda | following precedent, we'd all have to +1 on the ML | 15:59 |
| devananda | does anyone in this team feel that's necessary? | 15:59 |
| rloo | devananda: I didn't realize that. let's change the precedent. is half reasonable? | 15:59 |
| devananda | rloo: I'll just do it :) | 16:00 |
| * rameshg87 watches :) | 16:00 | |
| rloo | devananda: great. executive decisions are good sometimes ;) | 16:00 |
| lucasagomes | there's more votes: deva, me, rloo, shrews, jroll | 16:00 |
| devananda | NobodyCam: re: https://review.openstack.org/#/c/160383/12/ironic/tests/drivers/test_ipmitool.py,cm -- this should be mocked | 16:00 |
| jroll | oh right, I didn't count deva or myself | 16:00 |
| devananda | NobodyCam: the actual ipmitool system library does not need to be (and in fact is not going to be) installed in teh gate | 16:01 |
| lucasagomes | currently we have 9 cores, 5 votes so it's more than half already | 16:01 |
| rloo | yeah, so I think half +1 is good enough. Not sure what happens if we get a -1 but I guess we can cross that bridge if it ever happens. | 16:02 |
| jroll | rloo: we -2 the -1'er's patches. | 16:03 |
| jroll | ;D | 16:03 |
| *** killer_prince is now known as lazy_prince | 16:04 | |
| lucasagomes | so anyway, I think that just announcing the internal decision on the ML makes more sense | 16:05 |
| jlvillal | Congrats to rameshg87 :D | 16:05 |
| * rameshg87 sees +2 options in ironic for the first time :) | 16:05 | |
| devananda | rameshg87: done. you should re-log-in to gerrit | 16:05 |
| devananda | rameshg87: welcome to the team :) | 16:05 |
| lucasagomes | rameshg87, congrats u deserved! | 16:05 |
| rameshg87 | devananda: thanks :) | 16:06 |
| rameshg87 | lucasagomes: thanks :) | 16:06 |
| stendulker | rameshg87: Congrats !! | 16:06 |
| *** ijw has joined #openstack-ironic | 16:06 | |
| rloo | congrats rameshg87! although I sometimes wonder why it is such a big deal. must be this 'power' thing ;) | 16:06 |
| NobodyCam | congratz rameshg87 :) | 16:06 |
| BadCub | Gratz rameshg87 | 16:07 |
| rameshg87 | thanks stendulker rloo NobodyCam BadCub :) | 16:07 |
| NobodyCam | :) | 16:07 |
| jroll | grats rameshg87 :) | 16:07 |
| NobodyCam | rameshg87: you've done all the work :) thank you for all the help! | 16:08 |
| rameshg87 | thanks jroll :) | 16:08 |
| devananda | rameshg87: a couple things to note ... and others (lucas? Nobodycam?) please chime in if I forget something as it's been a little while | 16:08 |
| devananda | also - we should document these things | 16:08 |
| * rameshg87 listens | 16:09 | |
| devananda | rameshg87: a -2 is not overridable by any other core, so be very sparing with them. | 16:09 |
| devananda | rameshg87: it's a way to signal "this is so bad, i'm going to unlaterally veto it" | 16:09 |
| devananda | rameshg87: there are also process -2's, which you've seen, i'm sure. | 16:09 |
| rameshg87 | yeah i have | 16:09 |
| rameshg87 | specs not approved yet | 16:09 |
| devananda | rameshg87: i'm sur eyou know the 2 +2 rule ... no need to repeat it even | 16:09 |
| rameshg87 | yeah i know that too | 16:10 |
| NobodyCam | try and not +a your own patches whould be one too | 16:10 |
| devananda | rameshg87: but one that I dont think is documented -- we avoid too much reviewing of patches (particularly large features) from the same company | 16:10 |
| jroll | NobodyCam: shhhh, don't give away our secrets | 16:11 |
| devananda | rameshg87: we will definitely review them, but a patch that is approved only by members of the same company that proposed it is ... well ... suspicious | 16:11 |
| NobodyCam | lol ieek | 16:11 |
| lucasagomes | yeah it may be me but I don't usually approve patches (unless they are fairly simple) if they were just reviewed by prople from the company I work for | 16:11 |
| lucasagomes | yeah what devananda said in better words :) | 16:11 |
| devananda | lucasagomes: not just you :) | 16:11 |
| * jroll same | 16:11 | |
| devananda | rameshg87: the reason for that is to avoid the perception of impropriety | 16:11 |
| rameshg87 | got it | 16:11 |
| * jroll is glad other people are reviewing IPA things more | 16:11 | |
| stendulker | stendulker: Oh!! Who will review my secure boot feature :( | 16:12 |
| *** ijw has quit IRC | 16:12 | |
| * jlvillal thinks this would be great info to be documented somewhere | 16:12 | |
| devananda | even if the review is completely impartial, it *LOOKS* weird | 16:12 |
| *** ParsectiX has joined #openstack-ironic | 16:12 | |
| devananda | jlvillal: yes. it would. this is all stuff that has been institutional knowledge among openstack core teams for years, but not really widely documented - and it should be | 16:12 |
| jlvillal | devananda: As a new person to OpenStack a lot of this info was unknown to me. | 16:13 |
| * rameshg87 is noting them | 16:13 | |
| * BadCub goes away for a few minutes to switch to real internets | 16:13 | |
| *** ukalifon1 has quit IRC | 16:14 | |
| NobodyCam | brb | 16:14 |
| lucasagomes | rameshg87, one thing is that we try to maintain a minimal number of reviews we do per day, I think we now say 1 review per day at least | 16:14 |
| rameshg87 | devananda: so getting things. but in any case of doubt, i will ask and then only do for some days until i learn things around. | 16:15 |
| rameshg87 | lucasagomes: okay .. | 16:15 |
| devananda | lucasagomes: oh yah. # per day expectation. how about "get things done"? :) | 16:16 |
| jroll | ^ | 16:16 |
| devananda | nova at one point had a bar of 2/day. tripleo had 3/day 9but also much smaller patches on average) | 16:16 |
| devananda | we hvaen't had a hard cut-off of minimum # of patches | 16:17 |
| devananda | and honestly I dont think we should | 16:17 |
| rloo | +1, please no hard cut-off | 16:17 |
| devananda | we've had a fe cores become inactive -- it was really obvious to everyone | 16:17 |
| devananda | rameshg87: perhaps the biggest thing -- participate in IRC and meetings (you do) and do not hesitate to voice your views / concerns / feedback with respect to our processes, when you think something should be improved | 16:18 |
| rloo | devananda: are you ok if we update https://wiki.openstack.org/wiki/Ironic/CoreTeam with the +2 etc stuff mentioned here? (maybe some of that is in other wikis) | 16:18 |
| devananda | that ^ goes for any contributor, but doubly so for cores | 16:18 |
| devananda | rloo: please do :) | 16:18 |
| rameshg87 | devananda: okay .. | 16:19 |
| rloo | devananda: will do. | 16:19 |
| rloo | rameshg87: don't worry, it is really a lot of fun. I think. ha ha. | 16:19 |
| rameshg87 | rloo: hope so :) | 16:19 |
| rameshg87 | devananda: yeah i am trying to spend 2-3 hours around this time in irc now a days | 16:19 |
| rameshg87 | devananda: so that most of the people are in irc around this time | 16:20 |
| rameshg87 | devananda: will try to continue this, this isn't too late night for me :) | 16:20 |
| devananda | rameshg87: perfect. I know time zones are awkward, but you should also be able to overlap with Haomeng|2 for a bit in your mornings, and with the EU folks for mor etime | 16:20 |
| rameshg87 | devananda: and meetings too ... | 16:20 |
| rameshg87 | devananda: yeah ... exactly | 16:21 |
| openstackgerrit | Merged openstack/ironic: Add AMT-PXE driver doc https://review.openstack.org/152859 | 16:21 |
| *** ramineni has joined #openstack-ironic | 16:21 | |
| lucasagomes | devananda, https://wiki.openstack.org/wiki/Ironic/CoreTeam#Other_notes | 16:22 |
| * NobodyCam is on actual internets! | 16:22 | |
| lucasagomes | we can word it better later, just trying to put the points over there | 16:23 |
| lucasagomes | so we don't forget | 16:23 |
| devananda | ++ | 16:23 |
| rameshg87 | lucasagomes: great :) | 16:23 |
| * rameshg87 bookmarks :) | 16:23 | |
| JayF | congrats rameshg87 | 16:23 |
| devananda | I need to step away for about 2 hours ... back soon | 16:24 |
| rameshg87 | thanks JayF :) | 16:24 |
| rameshg87 | thanks a lot everyone for giving me this oppurtunity and responsibility | 16:25 |
| rameshg87 | i will try my level best to better ironic and myself with this :) | 16:26 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-python-agent: Add cleaning/zapping support to IPA https://review.openstack.org/161066 | 16:27 |
| jlvillal | rloo: On 'Try to avoid approving patches of people from the same company (particularly large features)' how about 'Try to avoid approving patches of people from your company (particularly large features), to avoid the appearance of a conflict of interest' | 16:27 |
| jlvillal | rloo: Or something like that. | 16:27 |
| lucasagomes | rameshg87, well thank you :) | 16:27 |
| lucasagomes | you did it not us | 16:27 |
| * devananda updated wiki | 16:27 | |
| * devananda really goes afk | 16:27 | |
| *** stendulker has quit IRC | 16:27 | |
| jlvillal | rloo: Never mind. devananda made changes :) | 16:27 |
| rloo | jlvillal: gad, he's fast ;) | 16:29 |
| jlvillal | rloo: jroll: Maybe the once a day suggestion could mention week-days :) | 16:29 |
| jlvillal | Unless you like reviewing patches on the weekends ;) | 16:29 |
| * rameshg87 goes for dinner | 16:30 | |
| *** rameshg87 is now known as rameshg87-away | 16:30 | |
| *** jmccrory has joined #openstack-ironic | 16:30 | |
| rloo | jlvillal: I added '(on average)'. I don't know what people's work week is like. | 16:33 |
| *** stendulker has joined #openstack-ironic | 16:33 | |
| rloo | jlvillal: any other suggestions? | 16:34 |
| *** absubram has joined #openstack-ironic | 16:37 | |
| stendulker | rloo: Have addressed your comments for this review https://review.openstack.org/#/c/155731/ - Ilo drivers sets capabilities:boot_mode in node | 16:39 |
| stendulker | rloo: Please have a look when you get time | 16:39 |
| rloo | stendulker: yeah, i'll try to get to it today. i have a few patches to re-review. | 16:40 |
| stendulker | rloo, jroll, lucasgomes: Can you please review secure boot implementation for iLO drivers https://review.openstack.org/#/c/153974/ | 16:40 |
| stendulker | rloo: Thank you. | 16:41 |
| rloo | stendulker: probably not 153974. at least not this week. not sure i have the time. will see. | 16:41 |
| *** saripurigopi has quit IRC | 16:42 | |
| stendulker | rloo: Ok. Please give a try, if possible. | 16:43 |
| *** jistr has quit IRC | 16:45 | |
| jlvillal | rloo: I'm good. Thanks. | 16:45 |
| * rameshg87-away leaves for the day for some enjoyment ;-) | 16:45 | |
| rameshg87-away | good night all | 16:45 |
| NobodyCam | night rameshg87-away | 16:45 |
| jlvillal | rameshg87-away: Ciao! | 16:45 |
| *** rameshg87-away has left #openstack-ironic | 16:46 | |
| *** Nisha has joined #openstack-ironic | 16:47 | |
| *** saripurigopi has joined #openstack-ironic | 16:48 | |
| *** Marga_ has joined #openstack-ironic | 16:52 | |
| *** saripurigopi has quit IRC | 16:52 | |
| *** ParsectiX has quit IRC | 16:54 | |
| *** ParsectiX has joined #openstack-ironic | 16:54 | |
| *** Marga__ has joined #openstack-ironic | 16:55 | |
| *** Marga_ has quit IRC | 16:57 | |
| *** saripurigopi has joined #openstack-ironic | 16:57 | |
| *** ifarkas has quit IRC | 16:57 | |
| *** Marga__ has quit IRC | 16:58 | |
| *** Marga_ has joined #openstack-ironic | 16:58 | |
| jlvillal | What is the 'ironic-lib' project for? Am I correct in that it is a new project? | 17:05 |
| *** harlowja_away is now known as harlowja_ | 17:06 | |
| jlvillal | Is it for future use? Or is it currently being used? | 17:06 |
| *** ijw has joined #openstack-ironic | 17:06 | |
| openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 17:07 |
| JayF | ironic-lib was born out of the idea that IPA and Ironic are going to be doing a lot of the same things | 17:10 |
| JayF | and why should we have two different codebases that know how to partition and deploy images | 17:10 |
| JayF | instead of one | 17:10 |
| JayF | at least that was the conversation over booze in Paris :) | 17:10 |
| jlvillal | JayF: Okay. So I assume it is for the future then. | 17:10 |
| lucasagomes | +1 | 17:10 |
| *** Nisha has quit IRC | 17:10 | |
| jlvillal | JayF: I noticed it recently and wasn't sure what it was. Thanks :) | 17:10 |
| *** Nisha has joined #openstack-ironic | 17:11 | |
| JayF | NP | 17:11 |
| *** ijw has quit IRC | 17:11 | |
| openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 17:12 |
| *** ramineni has quit IRC | 17:15 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_log lib https://review.openstack.org/157602 | 17:15 |
| clif_h | jroll: should I keep caching info in driver_info, or expose some other way to query for caching data :) | 17:24 |
| JayF | If it's driver_info and it needs to be seen externally, just use external driver info | 17:24 |
| JayF | aiui | 17:25 |
| JayF | rather than internal driver_info | 17:25 |
| jroll | I really don't know the best answer to that | 17:25 |
| jroll | but I tend to think jay is right | 17:25 |
| clif_h | JayF: you mean driver_info ? | 17:25 |
| JayF | If you do it my way you reflect existing patterns. Whether or not they're good is an exercise for the reader. hehe | 17:25 |
| JayF | clif_h: yup | 17:25 |
| jroll | driver_info is supposed to be for operators to configure drivers... so it's not "correct". but I think it's fine. | 17:25 |
| JayF | An external service caching an image is kinda like an operator configuring a thing | 17:26 |
| clif_h | I don't want to encourage doing things improperly | 17:26 |
| clif_h | that sounds... somewhat reasonable | 17:26 |
| *** devlaps has joined #openstack-ironic | 17:26 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Update unittests and use NamedTemporaryFile https://review.openstack.org/162672 | 17:28 |
| *** wuhg has quit IRC | 17:29 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 17:29 |
| *** achanda has joined #openstack-ironic | 17:32 | |
| *** andreykurilin_ has joined #openstack-ironic | 17:33 | |
| *** mtanino has joined #openstack-ironic | 17:34 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Update unittests and use NamedTemporaryFile https://review.openstack.org/162672 | 17:35 |
| jlvillal | lucasagomes: ^^^^ Hopefully I responded to your comments :) | 17:36 |
| lucasagomes | jlvillal, thanks | 17:36 |
| lucasagomes | :( http://www.bbc.com/news/entertainment-arts-31858156 | 17:36 |
| lucasagomes | tl;dr terry pratchett died | 17:37 |
| NobodyCam | ya :( | 17:38 |
| lucasagomes | hope his daughter will continue to write discworld | 17:41 |
| *** lazy_prince is now known as killer_prince | 17:41 | |
| lucasagomes | I plan to finish all books until the end of my life | 17:41 |
| *** andreykurilin_ has quit IRC | 17:41 | |
| lucasagomes | 31 more to go! | 17:41 |
| NobodyCam | :) awesome goal lucasagomes :) | 17:41 |
| NobodyCam | only aurthor I have read every thing from is dougless adams! | 17:42 |
| lucasagomes | heh oh yeah | 17:42 |
| lucasagomes | the thgtg rocks | 17:42 |
| NobodyCam | have you read the dirk gently's holistic detective agency | 17:43 |
| lucasagomes | no I haven't, lemme check it out | 17:46 |
| NobodyCam | :) | 17:46 |
| NobodyCam | worth the read | 17:46 |
| lucasagomes | :D thanks for the tip | 17:46 |
| lucasagomes | NobodyCam, another series that I really enjoyed was the bartimaeus one | 17:47 |
| lucasagomes | really worth reading if u r looking for some fantasy book | 17:48 |
| lucasagomes | http://www.bartimaeusbooks.com | 17:48 |
| *** pas-ha has quit IRC | 17:48 | |
| NobodyCam | oh I'll have to take a look for them | 17:48 |
| NobodyCam | web page look cool | 17:48 |
| NobodyCam | :-p | 17:49 |
| *** BadCub is now known as BadCub_Away | 17:49 | |
| * NobodyCam notes to nit judge a book by its web page | 17:49 | |
| NobodyCam | s/nit/not/ | 17:49 |
| lucasagomes | heh | 17:50 |
| *** saripurigopi has quit IRC | 17:51 | |
| *** Marga_ has quit IRC | 17:53 | |
| *** Marga_ has joined #openstack-ironic | 17:56 | |
| JoshNang | hey all, i'd love to get eyes on these and get them merged soon, as they'll make testing cleaning with the agent driver much better: https://review.openstack.org/#/c/161001/ and https://review.openstack.org/#/c/161066/ | 18:00 |
| *** purp is now known as purp_away | 18:00 | |
| *** igordcard_ has joined #openstack-ironic | 18:02 | |
| *** derekh has quit IRC | 18:03 | |
| *** ijw has joined #openstack-ironic | 18:06 | |
| *** stendulker has quit IRC | 18:07 | |
| lucasagomes | I will call it a day | 18:10 |
| lucasagomes | gotta catch the train back home yet | 18:10 |
| lucasagomes | have a good night everyone | 18:10 |
| NobodyCam | have a good night lucasagomes | 18:10 |
| lucasagomes | JoshNang, I will review the second one tomorrow | 18:10 |
| *** ijw has quit IRC | 18:12 | |
| *** lucasagomes has quit IRC | 18:12 | |
| jlvillal | JoshNang: JayF: On the wrapper.counted thing. Could the calls just be stored in a list? | 18:14 |
| jlvillal | JoshNang: JayF: wrapper.called = [] wrapper.called.append( (*args, **kwargs) ) or something like that. | 18:16 |
| * jlvillal does not entirely understand everything that the test is trying to do ... | 18:16 | |
| JoshNang | luthanks! | 18:17 |
| *** achanda has quit IRC | 18:17 | |
| JayF | jlvillal: I just know I was explicitly trying to catch (and did, locally when writing the new HW manager API) cases where a method was called more than once | 18:17 |
| JoshNang | heh nvm, lucas is gone | 18:17 |
| *** thiagop has joined #openstack-ironic | 18:17 | |
| *** dprince has quit IRC | 18:18 | |
| JoshNang | jlvillal: that'd still be leaky. if two tests called the same method, it wouldn't get reset and you'd have calls from your last test | 18:18 |
| jlvillal | JoshNang: But with the list you might have more info on why it is leaky? | 18:19 |
| *** ndipanov has quit IRC | 18:19 | |
| *** Nisha has quit IRC | 18:19 | |
| JoshNang | jlvillal: i know why it's leaky though | 18:20 |
| *** Nisha has joined #openstack-ironic | 18:20 | |
| *** Marga_ has quit IRC | 18:20 | |
| jlvillal | JoshNang: Okay. I was just trying to brainstorm. or brain-light-drizzle | 18:20 |
| JoshNang | the decorator isn't getting reset in setup() | 18:20 |
| JoshNang | and i'm not sure that we can reset it there | 18:21 |
| *** penick has joined #openstack-ironic | 18:21 | |
| jlvillal | JoshNang: Some 'special' kwarg that the wrapper sees and then it resets the counter? | 18:22 |
| JoshNang | jlvillal: i'd be much more inclined to throw out the decorator before something like that ;) | 18:22 |
| jlvillal | :D | 18:23 |
| *** achanda has joined #openstack-ironic | 18:23 | |
| *** achanda has quit IRC | 18:23 | |
| *** achanda has joined #openstack-ironic | 18:24 | |
| jlvillal | JoshNang: Maybe the Fake class could just keep the counts without the decorator. And then you can have a reset function in the class. Which maybe is what you were thinking... | 18:24 |
| JoshNang | jlvillal: that's probably what i'll do. probably all the functions as mock since those already have counts and what not | 18:26 |
| *** tiagogomes_ has quit IRC | 18:26 | |
| jlvillal | JoshNang: Makes sense. | 18:27 |
| clif_h | jroll: JayF, et al... Ramakrishnan G brought up a couple of good points in his review, one I don't necessarily need to put the caching stuff in BaseAgentVendor's heartbeat, I could override heartbeat in AgentVendorInterface and deal with the caching stuff there and delegate the rest to the base class's heartbeat | 18:30 |
| clif_h | two, what happens if the node begins a deploy while the caching operation is in progress? I mean, I'm not locking the node during the caching operation, so I had to deal with that case somehow right? | 18:31 |
| *** athomas has quit IRC | 18:34 | |
| clif_h | or can we prevent deploys to nodes with caching in progress somehow? | 18:34 |
| lifeless | JoshNang: what decorator? | 18:35 |
| *** mtanino has quit IRC | 18:41 | |
| *** athomas has joined #openstack-ironic | 18:41 | |
| *** dprince has joined #openstack-ironic | 18:46 | |
| *** Marga_ has joined #openstack-ironic | 18:50 | |
| *** jcoufal has quit IRC | 18:54 | |
| *** Nisha has quit IRC | 18:55 | |
| *** ijw has joined #openstack-ironic | 19:06 | |
| *** Marga_ has quit IRC | 19:11 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Check temp dir is writable for ipmitool driver https://review.openstack.org/160383 | 19:11 |
| *** ijw has quit IRC | 19:11 | |
| jgrimm | jroll, i figured out my issue with my IPA instance image not booting.. entirely user error (as i suspected). i'd destroyed my partition table when i was changing to GPT.. and that's why it wasn't booting. | 19:12 |
| NobodyCam | jgrimm: :( | 19:13 |
| jgrimm | NobodyCam, dumb user error. i was working around another issue failing to realize how destructive that command is. doh | 19:13 |
| jgrimm | all is good, and i learned tons | 19:13 |
| NobodyCam | :) awesome :) | 19:14 |
| jgrimm | I need to open a bug yet against IPA for when disk is >2TB and the image is MBR... the code to create a partition for configdrive at the end of the disk blows up because its >2TB limit | 19:14 |
| NobodyCam | jgrimm: ++ | 19:15 |
| *** jmccrory has quit IRC | 19:20 | |
| *** ParsectiX has quit IRC | 19:22 | |
| *** ParsectiX has joined #openstack-ironic | 19:22 | |
| *** jmccrory has joined #openstack-ironic | 19:24 | |
| *** pelix has quit IRC | 19:25 | |
| *** athomas has quit IRC | 19:34 | |
| *** ParsectiX has quit IRC | 19:36 | |
| *** openstackgerrit has quit IRC | 19:40 | |
| *** openstackgerrit has joined #openstack-ironic | 19:41 | |
| NobodyCam | brb | 19:42 |
| JoshNang | lifeless: sorry, stepped away for lunch. the @counted decorator here: https://review.openstack.org/#/c/161001/3/ironic_python_agent/tests/multi_hardware.py | 19:42 |
| *** athomas has joined #openstack-ironic | 19:43 | |
| *** pas-ha has joined #openstack-ironic | 19:44 | |
| *** Marga_ has joined #openstack-ironic | 19:45 | |
| jroll | jgrimm: heh, glad you found it :) | 19:47 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_log lib https://review.openstack.org/157602 | 19:49 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Sync from oslo.incubator https://review.openstack.org/162505 | 19:49 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_policy package https://review.openstack.org/162501 | 19:49 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_context package https://review.openstack.org/162499 | 19:49 |
| *** Marga_ has quit IRC | 19:50 | |
| jgrimm | jroll, thanks for your help! | 19:53 |
| *** dprince has quit IRC | 19:56 | |
| *** mikal_ is now known as mikal | 20:02 | |
| *** jgrimm is now known as zz_jgrimm | 20:07 | |
| jroll | NobodyCam: TRACE ironic.drivers.modules.ipmitool PasswordFileFailedToCreate: Failed to create the password file. Unexpected error while running command. | 20:10 |
| jroll | :P | 20:10 |
| NobodyCam | huh | 20:10 |
| jroll | I just got this in my preprod | 20:10 |
| NobodyCam | :( | 20:11 |
| NobodyCam | that with jlvillal's patch? | 20:11 |
| jroll | nope | 20:11 |
| jroll | this was before | 20:11 |
| jroll | it's a new conductor, need to dive in and figure it out :P | 20:11 |
| JayF | is your /tmp r/o? | 20:12 |
| jroll | seems not | 20:12 |
| JayF | does it have the sticky bit set? | 20:12 |
| jroll | drwxrwxrwt 3 root root 4096 Mar 12 20:12 . | 20:13 |
| NobodyCam | out of space? | 20:13 |
| JayF | hrmph | 20:13 |
| jroll | I can write to a file as the ironic user | 20:13 |
| JayF | jroll: is this in a container? | 20:13 |
| jroll | ohhh. | 20:13 |
| jroll | you win this round, thanks :D | 20:13 |
| jroll | wait, no it's not, I lied | 20:13 |
| NobodyCam | :-p | 20:13 |
| *** zz_jgrimm is now known as jgrimm | 20:14 | |
| jroll | I can manually do it | 20:15 |
| jroll | might just be a fluke with a bad message | 20:15 |
| jroll | "do it" being the ipmi command | 20:15 |
| NobodyCam | tempdir not set correctly in conf? | 20:16 |
| jroll | is that a config thing? | 20:17 |
| jroll | I thought it was a python thing | 20:17 |
| jroll | at any rate, it should be (yay automation) | 20:17 |
| *** sambetts has quit IRC | 20:18 | |
| jlvillal | jroll: The error is not a temp file issue | 20:19 |
| jlvillal | jroll: It is an error with the underlying command. I believe | 20:19 |
| jroll | yeah, I think it's the ipmi command | 20:19 |
| jroll | agree | 20:19 |
| jlvillal | TRACE ironic.drivers.modules.ipmitool PasswordFileFailedToCreate: Failed to create the password file. Unexpected error while running command. | 20:19 |
| jlvillal | jroll: "Unexpected error while running command" comes from ProcessExecutionError exception | 20:19 |
| jlvillal | jroll: The patch which is already merged in, will now propagate the correct exception. | 20:20 |
| jlvillal | jroll: https://review.openstack.org/161803 | 20:20 |
| *** sambetts has joined #openstack-ironic | 20:20 | |
| jroll | jlvillal: right, I know about all of this (but apparently wasn't clear on what the underlying error really was) | 20:23 |
| jroll | I just thought NobodyCam etc might find it funny that I hit it | 20:23 |
| jroll | :P | 20:23 |
| NobodyCam | :) | 20:23 |
| jlvillal | jroll: I'm not sure what the underlying ipmi command error is. | 20:23 |
| jroll | right, how could you :) | 20:24 |
| jroll | clif_h: back to your questions, 1) I personally don't care; 2) I think you can allow deploys to happen if it's the same image as the one being cached. though ipa rejects commands if one is in progress. I think that will blow up the deploy but unsure. other than that... dunno. | 20:29 |
| clif_h | anyone I should ask about this? | 20:30 |
| clif_h | or am I on my own? | 20:30 |
| jroll | I mean, it's going to blow up fantastically somewhere | 20:33 |
| jroll | IMO the earlier the better | 20:33 |
| jroll | but I think it will need to be at the driver layer | 20:34 |
| clif_h | yeah it will definitely blow up a few times before it works | 20:35 |
| *** Marga_ has joined #openstack-ironic | 20:35 | |
| *** Marga_ has quit IRC | 20:37 | |
| *** Marga_ has joined #openstack-ironic | 20:38 | |
| *** mrda-away is now known as mrda | 20:42 | |
| mrda | Morning Ironic | 20:42 |
| NobodyCam | morning :) mrda | 20:44 |
| mrda | o/ | 20:44 |
| jlvillal | mrda: Good morning | 20:47 |
| mrda | hi jlvillal | 20:49 |
| *** penick has quit IRC | 20:55 | |
| *** kkoski has quit IRC | 21:02 | |
| *** harlowja_ has quit IRC | 21:03 | |
| *** harlowja has joined #openstack-ironic | 21:04 | |
| *** jjohnson2 has quit IRC | 21:04 | |
| *** penick has joined #openstack-ironic | 21:04 | |
| *** penick has quit IRC | 21:04 | |
| *** Marga_ has quit IRC | 21:20 | |
| NobodyCam | mmmmm food.... brb | 21:22 |
| *** Marga_ has joined #openstack-ironic | 21:24 | |
| *** BadCub_Away is now known as BadCub | 21:25 | |
| openstackgerrit | Clif Houck proposed openstack/ironic: Added support for image caching for the agent driver https://review.openstack.org/161832 | 21:27 |
| *** kevinbenton_ is now known as kevinbenton | 21:30 | |
| *** pas-ha has quit IRC | 21:32 | |
| *** Marga_ has quit IRC | 21:38 | |
| *** Marga_ has joined #openstack-ironic | 21:39 | |
| NobodyCam | another installer just appered ... back in a bit | 21:47 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-python-agent: Add dispatch to all managers https://review.openstack.org/161001 | 21:50 |
| *** harlowja has quit IRC | 22:02 | |
| *** harlowja has joined #openstack-ironic | 22:04 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-python-agent: Add dispatch to all managers https://review.openstack.org/161001 | 22:14 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-python-agent: Add dispatch to all managers https://review.openstack.org/161001 | 22:16 |
| jlvillal | clif_h: What happened to agent_base_vendor.py? Is it not modified anymore? | 22:16 |
| jlvillal | JoshNang: Do it right the first time :P | 22:17 |
| jlvillal | /me hopes JoshNang doesn't go through the scroll back and see where jlvillal did the same thing earlier today. | 22:17 |
| * jlvillal hopes JoshNang doesn't go through the scroll back and see where jlvillal did the same thing earlier today. | 22:17 | |
| clif_h | jlvillal: right, based on the last review I thought maybe it would be better to not 'pollute' the base with the image cache interface | 22:17 |
| jlvillal | clif_h: Okay. But still have changes to test_agent... ? | 22:17 |
| jlvillal | clif_h: I'm assuming something else caused that to change. | 22:18 |
| clif_h | yes I made logical changes | 22:19 |
| clif_h | as well | 22:19 |
| jlvillal | clif_h: thanks | 22:19 |
| *** logan2 has quit IRC | 22:26 | |
| *** andreykurilin_ has joined #openstack-ironic | 22:32 | |
| *** athomas has quit IRC | 22:36 | |
| *** Marga_ has quit IRC | 22:36 | |
| *** r-daneel has quit IRC | 22:48 | |
| *** achanda has quit IRC | 22:52 | |
| *** achanda has joined #openstack-ironic | 22:53 | |
| *** mmorais has joined #openstack-ironic | 22:54 | |
| *** achanda_ has joined #openstack-ironic | 22:56 | |
| *** achanda_ has quit IRC | 22:56 | |
| *** achanda_ has joined #openstack-ironic | 22:56 | |
| *** achanda has quit IRC | 22:57 | |
| *** andreykurilin_ has quit IRC | 23:07 | |
| *** achanda has joined #openstack-ironic | 23:08 | |
| *** Marga_ has joined #openstack-ironic | 23:09 | |
| *** Marga_ has quit IRC | 23:10 | |
| *** Marga_ has joined #openstack-ironic | 23:10 | |
| *** achanda_ has quit IRC | 23:11 | |
| *** igordcard_ has quit IRC | 23:12 | |
| *** Marga_ has quit IRC | 23:18 | |
| *** Marga_ has joined #openstack-ironic | 23:19 | |
| devananda | JoshNang: https://review.openstack.org/#/c/161457/ -- no updates in a week, and it's the only code tagged for the implement-zapping-states BP | 23:32 |
| *** achanda has quit IRC | 23:32 | |
| devananda | JoshNang: also it doens't look like a nearly complete implementation. next week is the cut off, s othis seems quite unlikely at this point | 23:32 |
| *** achanda has joined #openstack-ironic | 23:32 | |
| *** absubram has quit IRC | 23:35 | |
| JoshNang | devananda: yeah :/ i've been working on cleaning (most of which is overlap), but it's not going nearly as fast as i had hoped | 23:35 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: iLO driver updates node.properties['capabilities'] during inspection Inpects hardware to get some of the capabilities https://review.openstack.org/163572 | 23:37 |
| JoshNang | devananda: i'm perfectly fine bumping zapping, but there were objections when i suggested it earlier in the cycle | 23:37 |
| devananda | at this point, our targeted blueprint list is completely unrealistic | 23:38 |
| devananda | in less than a week, we feature freeze | 23:38 |
| devananda | so yea | 23:38 |
| devananda | if the code's not even done today, i'm bumping it | 23:39 |
| JoshNang | ++ | 23:39 |
| JoshNang | i'll keep writing it after the deadline, so it can be merged early in L | 23:39 |
| jroll | oh my, we should review some code. | 23:39 |
| devananda | JoshNang: great | 23:40 |
| devananda | jroll: yes. because omg, there's no way. | 23:40 |
| jroll | ya. | 23:40 |
| jroll | I didn't realize it was so soon either | 23:40 |
| * jroll blocks his calendar for tomorrow | 23:40 | |
| NobodyCam | jroll: I'm going to see if I can help focus our review team statrting tomorrow | 23:40 |
| jroll | +1 | 23:40 |
| NobodyCam | also I'm sure BadCub we jumping in | 23:41 |
| JayF | I mean, stuff bumped or not, this is an insanely good release | 23:41 |
| *** david-lyle is now known as david-lyle_afk | 23:41 | |
| JayF | we got a *lot* of stuff in K | 23:41 |
| jroll | indeed | 23:42 |
| devananda | indeed | 23:42 |
| jroll | though seems like a lot of drivers and not a ton else | 23:42 |
| * russell_h debates sending an email to openstack-dev suggesting an end to the farsical idea of "releases" | 23:42 | |
| * russell_h also hides | 23:42 | |
| devananda | state machine | 23:42 |
| NobodyCam | :) we also made some great directonal choices that will help us going down hte raod for a while | 23:42 |
| jroll | but I'm proabbly just forgetting what's what :) | 23:42 |
| devananda | russell_h: do it | 23:42 |
| jroll | russell_h: there's a large thread | 23:42 |
| jroll | doeet | 23:42 |
| devananda | russell_h: also, there's a thread | 23:42 |
| JayF | is IPA default ramdisk in K? | 23:42 |
| russell_h | oh good then I don't need to | 23:42 |
| devananda | russell_h: also, go read the governance repo proposed changes | 23:42 |
| JayF | or is bash-ramdisk? | 23:42 |
| devananda | JayF: both are tested. others can tell you exactly what the state of the test matrix is right now | 23:43 |
| devananda | we should document that | 23:43 |
| devananda | but we aren't | 23:43 |
| devananda | also it's changing frequently | 23:43 |
| devananda | adam_g and lucas have been doing a lot | 23:43 |
| *** jmccrory has quit IRC | 23:43 | |
| JayF | my "upstream time" was taken up by a couple of needed patches for systemd + some conferences this month, but I hope to refocus and get the coreos-image-builder to a good point | 23:44 |
| JayF | although at this point, that's a transition I'll do at the start of L rather than now | 23:44 |
| devananda | JoshNang: cleaning states. serious question. is ALL the code done? | 23:44 |
| *** Haomeng has joined #openstack-ironic | 23:44 | |
| devananda | JayF: IPA doen't have to feature freeze | 23:44 |
| devananda | JayF: clean it up sooner rather than later, pls | 23:45 |
| JayF | heh, okay :) | 23:45 |
| JoshNang | devananda: yes | 23:45 |
| jroll | JoshNang: until someone tears it apart | 23:45 |
| JayF | devananda is going through the cleaning steps right now for the release. Currently in erase_backlog() | 23:45 |
| JayF | lol | 23:45 |
| JoshNang | devananda: i need to test it, and ramesh pointed out using the agent + neutron dhcp would throw an error that we need to sort out | 23:45 |
| devananda | JayF: also, I'm about to open source a project we've been hacking on for the last two weeks -- stand alone ansible + ironic -- that uses IPA. | 23:46 |
| JayF | nice | 23:46 |
| JoshNang | \o/ | 23:46 |
| JayF | me+joshnang just wrote a thing that can API client to agent directly for testing agent stuff without an ironic | 23:46 |
| devananda | nice | 23:47 |
| JayF | super useful for a hardware lab and I can pop that one into gist if you would find it useful | 23:47 |
| devananda | TheJulia: ^ | 23:47 |
| *** Haomeng|2 has quit IRC | 23:47 | |
| devananda | JayF: probably yes | 23:47 |
| jroll | JayF: we need to open source that thing | 23:47 |
| jroll | the whole repo | 23:47 |
| JayF | jroll: onmetal-scripts in general, you mean? | 23:47 |
| jroll | yes. | 23:47 |
| JayF | I think we have some business logic we'd have to purge, but I agree overall | 23:47 |
| JayF | at least the libraries | 23:47 |
| JoshNang | +100 | 23:48 |
| *** kbs1 has quit IRC | 23:48 | |
| jroll | I don't think we do | 23:48 |
| * JayF has a realization he has to post all the libraries for his script to work | 23:48 | |
| jroll | we have things that depend on downstream code | 23:48 |
| jroll | but whatever | 23:48 |
| mrda | devananda: did you want to chat re: microversions? Or is the need for that past? | 23:51 |
| devananda | so I'm going to spend a big chunk of this weekend doing reviews and trying to push things through the gate | 23:54 |
| devananda | ya'll may see me +A'ing my own fix up code | 23:54 |
| devananda | if that's the difference between me -1'ing and waiting another day, or landing something and fixing the nits before feature freeze, i'm just gonna do it at this point | 23:54 |
| * mrda notes how close K is | 23:55 | |
| devananda | if it's a small nit, I'd encourage a few of you to do the same | 23:55 |
| devananda | yea. we should realistically try to tag on Tuesdays | 23:55 |
| devananda | the actual cut off is thursday | 23:55 |
| mrda | very close now | 23:55 |
| *** mtanino has joined #openstack-ironic | 23:55 | |
| devananda | this is, honestly, what I hate most about 6-mo dev cycle | 23:56 |
| devananda | it creates the need to force patches through at the end | 23:56 |
| *** Nisha has joined #openstack-ironic | 23:56 | |
| devananda | stress++ and quality-- | 23:56 |
| mrda | yeah, it would be nice to have more time for things to settle | 23:56 |
| *** ChuckC has quit IRC | 23:56 | |
| devananda | I'd like to talk with everyone in vancouver about changing our development cycle / model | 23:57 |
| devananda | jroll, russell_h - I believe you and I agree on that already | 23:57 |
| devananda | but I'm not sure how everyone else feels | 23:57 |
| mrda | that'll be an interesting discussion, but I look forward to talking about it! | 23:57 |
| jroll | devananda: release daily. | 23:58 |
| jroll | hourly | 23:59 |
| jroll | minutely | 23:59 |
| devananda | jroll: no. as needed. | 23:59 |
| NobodyCam | ++ as needed :) | 23:59 |
| jroll | I'm half joking here | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!