| devananda | what's the status of RAID work? | 00:00 |
|---|---|---|
| mrda | Having a CD model would decrease the cost of official release, f'sure | 00:00 |
| JoshNang | devananda: i think the raid work was relying on zapping | 00:01 |
| devananda | https://review.openstack.org/#/c/155230/ is a huge patch | 00:01 |
| NobodyCam | is that the 1300 + line patch | 00:01 |
| devananda | and i see almost no revies from cores on it | 00:02 |
| devananda | yes | 00:02 |
| devananda | JoshNang: it's not actually a dependent patch | 00:02 |
| *** naohirot has joined #openstack-ironic | 00:02 | |
| *** rameshg87 has joined #openstack-ironic | 00:02 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Enhance AMT driver documentation https://review.openstack.org/164029 | 00:02 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add whole disk image support in iscsi_ilo driver https://review.openstack.org/163589 | 00:02 |
| NobodyCam | no I was thinking of this one: https://review.openstack.org/#/c/150142 | 00:02 |
| NobodyCam | :-p | 00:02 |
| rameshg87 | good morning ironic (sort of early morning here) :) | 00:03 |
| devananda | oh. holw disk images | 00:03 |
| mrda | morning rameshg87 | 00:03 |
| *** achanda has quit IRC | 00:03 | |
| devananda | rameshg87: g'morning | 00:04 |
| rameshg87 | devananda: mrda: morning :) | 00:04 |
| rameshg87 | devananda: i think i am just on time :) | 00:04 |
| devananda | oh neat. whole disk has 2 +2 | 00:04 |
| devananda | anyone tested it? | 00:04 |
| rameshg87 | devananda: i did | 00:04 |
| devananda | rameshg87: thoughts? | 00:05 |
| rameshg87 | but 2 patchsets back (but hasn't changed much after that) | 00:05 |
| jlvillal | rameshg87: Are you waking up early or staying up late? ;) | 00:05 |
| rameshg87 | jlvillal: i slept and came. but woke early | 00:05 |
| rameshg87 | devananda: thoughts about what ? | 00:06 |
| rameshg87 | devananda: don't have scrollback thing to read | 00:06 |
| rameshg87 | devananda: if something was discussed before (just checking eavesdrop) | 00:06 |
| * BadCub loves IRCCloud now | 00:07 | |
| * rameshg87 checks what is IRCCloud | 00:07 | |
| devananda | rameshg87: i mean with respect to the whole disk imaging | 00:07 |
| devananda | rameshg87: but i've just read your comments on the review - so never mind :) | 00:08 |
| devananda | rameshg87: also -- check out irssi | 00:08 |
| BadCub | rameshg87: irccloud.com | 00:08 |
| devananda | most of us stay in irc all the time, using a proxy or remote service | 00:08 |
| NobodyCam | +++ | 00:08 |
| devananda | I run an irssi session inside of screen in a cloud instance, using google-notifier to bounce messages to my phone while i'm afk | 00:08 |
| devananda | I don't lke irccloud becaues then they have access to all my messages | 00:09 |
| NobodyCam | I do same with out notifier! | 00:09 |
| rameshg87 | devananda: oh great .. okay | 00:09 |
| BadCub | I have the irccloud app on phone, and use the web browser on comp. | 00:09 |
| * rameshg87 will try to configure it this weekend | 00:09 | |
| rameshg87 | devananda: one more thing, should we change agent driver to follow the pattern that was mentioned in whole-disk-image-spec | 00:10 |
| rameshg87 | devananda: like we if a glance image given to a node managed by agent_ipmitool has kernel_id, ramdisk_id | 00:10 |
| rameshg87 | devananda: should we just throw an error (for now) saying agent doesn't support partition images (until we support them) | 00:11 |
| devananda | rameshg87: is https://review.openstack.org/#/c/159855/ related to local boot or uefi boot? or both? | 00:11 |
| devananda | if both - the commit messae should tag both BPs | 00:11 |
| devananda | rameshg87: yea, i think that's reaasonable (throw an error if bad params). JayF ? | 00:11 |
| rameshg87 | devananda: i hope we are making a common pattern in ironic (that images without kernel_id, ramdisk_id are whole disk images OR partition images otherwise) | 00:12 |
| jlvillal | rameshg87: I use ZNC. Which you can then connect any IRC client to it. | 00:12 |
| jlvillal | rameshg87: http://wiki.znc.in/ | 00:12 |
| devananda | rameshg87: ++ | 00:12 |
| rameshg87 | devananda: it's uefi boot + local boot. i have only one blueprint right now for that (uefi support for net boot was added in juno itself) | 00:12 |
| devananda | rameshg87: https://blueprints.launchpad.net/ironic/+spec/local-boot-support-with-partition-images covers a lot of changes, and is marked Implemented already | 00:13 |
| rameshg87 | jlvillal: thanks. i think i tried znc once, had some trouble setting it in my office and left it | 00:13 |
| devananda | rameshg87: but your patch is still outstanding | 00:13 |
| jlvillal | rameshg87: Also some guy named Sean Dague explains his ZNC setup here: https://dague.net/2014/09/13/my-irc-proxy-setup/ | 00:13 |
| rameshg87 | jlvillal: oh great .. will have a look | 00:13 |
| JayF | devananda: rameshg87 +1 error we can't do that yet ) | 00:14 |
| rameshg87 | devananda: ironic now support bios and uefi boot modes | 00:14 |
| JayF | :) | 00:14 |
| jlvillal | rameshg87: You can get a free year of Amazon AWS and then run a micro node and run ZNC there :) | 00:14 |
| devananda | jlvillal: 'some guy' heh | 00:14 |
| rameshg87 | devananda: and local boot spec didn't talk about bios/uefi | 00:14 |
| jlvillal | devananda: :D LOL | 00:14 |
| *** Marga_ has quit IRC | 00:15 | |
| rameshg87 | devananda: shouldn't we just add support for local boot for uefi machines (because we support both bios and uefi) | 00:15 |
| devananda | rameshg87: good point | 00:15 |
| rameshg87 | devananda: only extra step in uefi is to create a efi system partition and mount it before running grub-install command | 00:15 |
| rameshg87 | devananda: grub will take care of the rest (detecting efi, installing grubx64.efi onto efi system partition, adding efi boot entry, etc) | 00:16 |
| rameshg87 | devananda: lucas didn't have uefi hardware to test iirc. may be that's the reason he didn't pursue at that time. | 00:17 |
| devananda | rameshg87: quite possibly. I've updated the BP to say NeedsReview | 00:20 |
| rameshg87 | devananda: thanks | 00:21 |
| rameshg87 | devananda: it need dib and ipa changes also | 00:21 |
| rameshg87 | devananda: https://review.openstack.org/#/c/160687/ and https://review.openstack.org/#/c/163739/ | 00:22 |
| rameshg87 | devananda: dib is in a good shape (one +2) | 00:22 |
| jlvillal | rameshg87: Question on: https://review.openstack.org/#/c/163589/3/ironic/tests/drivers/ilo/test_deploy.py Line 251. I'm confused on how props_expected works? | 00:23 |
| jlvillal | rameshg87: Not sure if I'm missing something. | 00:23 |
| rameshg87 | jlvillal: oh my mistake | 00:25 |
| jlvillal | rameshg87: Okay. I left a review for you. | 00:26 |
| rameshg87 | jlvillal: just checking again | 00:26 |
| rameshg87 | :D | 00:26 |
| rameshg87 | i am confused | 00:26 |
| jlvillal | rameshg87: I'm glad it isn't just me :) | 00:26 |
| *** Marga_ has joined #openstack-ironic | 00:27 | |
| *** killer_prince has quit IRC | 00:28 | |
| rameshg87 | jlvillal: yeah it's a mistake, thanks for pointing.. i think implemented only partially what i wanted in the tests | 00:28 |
| jlvillal | rameshg87: You're welcome. Glad I can help. | 00:29 |
| *** kozhukalov has quit IRC | 00:30 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-python-agent: Add cleaning/zapping support to IPA https://review.openstack.org/161066 | 00:31 |
| devananda | rameshg87: it looks like https://blueprints.launchpad.net/ironic/+spec/uefi-secure-boot is not completed yet | 00:32 |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Enhance AMT driver documentation https://review.openstack.org/164029 | 00:33 |
| rameshg87 | devananda: yeah needs code review but not getting much reviews :( | 00:33 |
| devananda | rameshg87: also, is there any more code that needs to be written for https://blueprints.launchpad.net/ironic/+spec/inband-raid-configuration ? | 00:35 |
| *** killer_prince has joined #openstack-ironic | 00:35 | |
| *** killer_prince is now known as lazy_prince | 00:35 | |
| rameshg87 | devananda: it will be making use of things in "Implement cleaning/zapping for the agent driver" https://review.openstack.org/#/c/161453/ | 00:36 |
| rameshg87 | devananda: because it's through agent only | 00:36 |
| devananda | ah, ok | 00:36 |
| devananda | so that's not really tied to ironic's release cycle // feature freeze | 00:36 |
| rameshg87 | devananda: i have tested with a few things, but waiting for cleaning/zapping to get in | 00:36 |
| devananda | so, zapping is not going to land in K | 00:37 |
| devananda | cleaning -- we need to double down on reviewing that and land it ASAP | 00:37 |
| devananda | like - tomorrow | 00:37 |
| devananda | JoshNang: ^ | 00:37 |
| NobodyCam | ++++++ | 00:37 |
| JoshNang | devananda: can do | 00:37 |
| devananda | because we have so many other patches riding on that | 00:37 |
| devananda | and they're all blocked, essentially | 00:37 |
| rameshg87 | devananda: oh so zapping is not in for K ? | 00:37 |
| devananda | rameshg87: I mean, the code isn't done | 00:38 |
| devananda | and feature freeze is next week | 00:38 |
| devananda | so, no. | 00:38 |
| rameshg87 | devananda: Add driver interface for RAID configuration needs only if we are going to do inband raid through zapping https://review.openstack.org/#/c/155230/ | 00:39 |
| rameshg87 | devananda: i mean "Add driver interface for RAID configuration" indirectly depends on zapping | 00:40 |
| rameshg87 | devananda: because only inband raid configuration spec got merged for K | 00:40 |
| openstackgerrit | Merged openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/non-glance-image-refs.rst https://review.openstack.org/162606 | 00:41 |
| * jlvillal decides it is time to go shopping for groceries so he can make dinner | 00:44 | |
| jlvillal | Good night Ironic | 00:44 |
| NobodyCam | night jlvillal | 00:45 |
| mrda | 'night jlvillal | 00:45 |
| rameshg87 | good night jlvillal | 00:46 |
| devananda | rameshg87: oh, gotcha. so we should bump all the raid stuff then | 00:46 |
| devananda | :( | 00:46 |
| rameshg87 | :( | 00:47 |
| rameshg87 | devananda: infact we did a lot of things for raid in our proliantutils library (and generic raid configuration stuff too) :( | 00:49 |
| BadCub | NobodyCam: I need to round up some Cores for a crunch session with me and devananda tomorrow. You free? | 00:49 |
| NobodyCam | you got it.. I'm up for reviewJam | 00:51 |
| JayF | I may not participate directly, but if anything IPA comes up feel free to ping me in here | 00:53 |
| JayF | although I try to stay on top of those patches | 00:53 |
| NobodyCam | JayF: sure :) | 00:59 |
| BadCub | JayF: thanks! | 00:59 |
| NobodyCam | (we'll be happy to assign all work to you) | 00:59 |
| *** kevinbenton has quit IRC | 00:59 | |
| NobodyCam | :-p | 00:59 |
| NobodyCam | j/k | 00:59 |
| BadCub | hehehe | 00:59 |
| *** ijw has joined #openstack-ironic | 01:03 | |
| *** ijw has quit IRC | 01:05 | |
| *** ijw has joined #openstack-ironic | 01:05 | |
| openstackgerrit | Michael Davies proposed openstack/ironic: New field 'name' not supported in port REST API https://review.openstack.org/163730 | 01:09 |
| rloo | g'night and a good weekend everyone. Talk to you on Monday. | 01:12 |
| mrda | Have a nice weekend rloo! | 01:13 |
| *** rloo has quit IRC | 01:13 | |
| *** rwsu is now known as rwsu-afk | 01:13 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Enhance AMT driver documentation https://review.openstack.org/164029 | 01:16 |
| *** enikanorov__ has joined #openstack-ironic | 01:24 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add whole disk image support in iscsi_ilo driver https://review.openstack.org/163589 | 01:24 |
| rameshg87 | jlvillal: ^^^ | 01:24 |
| * rameshg87 wonders if we can write test case for a test case | 01:24 | |
| * NobodyCam is almost afraid to ask why? | 01:25 | |
| NobodyCam | to test that the test works? | 01:25 |
| rameshg87 | NobodyCam: yes :) | 01:26 |
| rameshg87 | NobodyCam: i wrote a bad test which passed and jlvillal found out | 01:26 |
| *** enikanorov_ has quit IRC | 01:26 | |
| rameshg87 | NobodyCam: i missed to check if test case is working as expected :( | 01:26 |
| rameshg87 | JoshNang: nova is still not aware of clean states, right ? | 01:27 |
| JoshNang | rameshg87: the patch is up, it isn't merged yet | 01:33 |
| NobodyCam | :( | 01:33 |
| JoshNang | rameshg87: https://review.openstack.org/#/c/161474/ | 01:33 |
| *** stendulker has joined #openstack-ironic | 01:33 | |
| *** Nisha has quit IRC | 01:38 | |
| *** chenglch has joined #openstack-ironic | 01:39 | |
| rameshg87 | JoshNang: so since nova doesn't know about cleaning, won't "nove delete" of an instance time out | 01:40 |
| rameshg87 | JoshNang: bcecause it doesn't understand cleaning | 01:40 |
| rameshg87 | JoshNang: or is it configurable ? | 01:40 |
| JoshNang | rameshg87: that patch fixes that | 01:40 |
| JoshNang | but otherwise, yes, if cleaning is enabled and that's not in, it would likely timeout | 01:41 |
| *** ChuckC has joined #openstack-ironic | 01:42 | |
| rameshg87 | JoshNang: okay | 01:43 |
| *** ChuckC has quit IRC | 01:46 | |
| *** ChuckC has joined #openstack-ironic | 01:47 | |
| *** lazy_prince has quit IRC | 01:53 | |
| *** Marga_ has quit IRC | 01:53 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Add /nodes/<uuid>/cleaning/steps API https://review.openstack.org/159322 | 01:53 |
| JoshNang | i'm gonna grab some dinner then make sure all of cleaning is ready to be merged tomorrow | 01:54 |
| *** kevinbenton has joined #openstack-ironic | 01:57 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 01:57 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 01:59 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 01:59 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 02:00 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 02:00 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 02:00 |
| *** Marga_ has joined #openstack-ironic | 02:03 | |
| *** stendulker has quit IRC | 02:06 | |
| *** harlowja is now known as harlowja_away | 02:07 | |
| *** stendulker has joined #openstack-ironic | 02:12 | |
| *** killer_prince has joined #openstack-ironic | 02:14 | |
| *** killer_prince is now known as lazy_prince | 02:14 | |
| *** ijw has quit IRC | 02:22 | |
| *** ijw has joined #openstack-ironic | 02:28 | |
| *** ijw has quit IRC | 02:29 | |
| *** ijw has joined #openstack-ironic | 02:30 | |
| *** ramineni has joined #openstack-ironic | 02:38 | |
| *** devlaps has quit IRC | 02:43 | |
| *** stendulker has quit IRC | 02:43 | |
| *** achanda has joined #openstack-ironic | 02:44 | |
| rameshg87 | JoshNang: if nova patch doesn't go through, i think we don't need to worry about neutron ports | 02:50 |
| rameshg87 | JoshNang: because nova delete will delete the neutron ports only after the virt driver delete is complete (our virt driver delete will include tear down + cleaning) | 02:50 |
| *** jmccrory has joined #openstack-ironic | 02:55 | |
| *** absubram has joined #openstack-ironic | 03:09 | |
| *** absubram has quit IRC | 03:11 | |
| *** absubram has joined #openstack-ironic | 03:12 | |
| JoshNang | rameshg87: if the nova patch doesn't get through, cleaning's not going to be terribly useful. i don't think anyone wants an hour+ timeout on nova delete | 03:20 |
| *** jmccrory has quit IRC | 03:23 | |
| *** jmccrory has joined #openstack-ironic | 03:24 | |
| rameshg87 | JoshNang: hmm .. yeah true | 03:30 |
| *** lazy_prince is now known as killer_prince | 03:31 | |
| *** ijw has quit IRC | 03:36 | |
| *** ijw has joined #openstack-ironic | 03:51 | |
| *** ijw has quit IRC | 03:53 | |
| *** ijw has joined #openstack-ironic | 03:53 | |
| *** Nisha has joined #openstack-ironic | 03:56 | |
| *** jmccrory has quit IRC | 03:59 | |
| *** yog_ has joined #openstack-ironic | 04:12 | |
| *** Marga_ has quit IRC | 04:16 | |
| Nisha | devananda, there | 04:17 |
| *** saripurigopi has joined #openstack-ironic | 04:24 | |
| *** rameshg87 has left #openstack-ironic | 04:37 | |
| *** Marga_ has joined #openstack-ironic | 04:37 | |
| *** killer_prince is now known as lazy_prince | 04:37 | |
| *** mtanino has quit IRC | 04:46 | |
| openstackgerrit | Michael Davies proposed openstack/ironic: New field 'name' not supported in port REST API https://review.openstack.org/163730 | 04:52 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 04:57 |
| *** gridinv_ has joined #openstack-ironic | 04:57 | |
| saripurigopi | The review I've submitted is in 'Patch in Merge Conflict' state, how to recover from this.? | 05:01 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 05:01 |
| Haomeng | saripurigopi: that means can not auto-merge, so need to do *manually* merge and commit the new patch again | 05:03 |
| *** ijw has quit IRC | 05:05 | |
| saripurigopi | Haomeng, okay. when I commit the changes for review I've resolved the conflicts and submitted for review. | 05:08 |
| Haomeng | saripurigopi: cool | 05:08 |
| Haomeng | saripurigopi: :) | 05:08 |
| saripurigopi | Haomeng, But it still shows 'Patch in Merge Conflict' , so, do I need to submit again? | 05:09 |
| Haomeng | saripurigopi: ? | 05:09 |
| Haomeng | saripurigopi: which review, can you share the url, let me help you take a look | 05:09 |
| saripurigopi | Haomeng, https://review.openstack.org/#/c/159734/ | 05:09 |
| Haomeng | saripurigopi: I think you should rebase your local code first, then merge it by manually | 05:09 |
| Haomeng | saripurigopi: ok | 05:09 |
| Haomeng | saripurigopi: make sure the base code is latested | 05:10 |
| saripurigopi | okay | 05:10 |
| saripurigopi | Haomeng: okat | 05:10 |
| Haomeng | saripurigopi: :) | 05:10 |
| *** coolsvap|afk is now known as coolsvap | 05:14 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 05:20 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers https://review.openstack.org/159734 | 05:22 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Add /nodes/<uuid>/cleaning/steps API https://review.openstack.org/159322 | 05:50 |
| *** gridinv_ has quit IRC | 05:55 | |
| *** absubram has quit IRC | 06:04 | |
| *** achanda has quit IRC | 06:10 | |
| *** Nisha has quit IRC | 06:11 | |
| *** Nisha has joined #openstack-ironic | 06:11 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 06:11 |
| *** achanda has joined #openstack-ironic | 06:13 | |
| *** sdake_ has quit IRC | 06:17 | |
| *** sdake_ has joined #openstack-ironic | 06:21 | |
| *** takadayuiko has joined #openstack-ironic | 06:27 | |
| *** achanda has quit IRC | 06:28 | |
| *** achanda has joined #openstack-ironic | 06:34 | |
| *** achanda has quit IRC | 06:38 | |
| *** lazy_prince has quit IRC | 06:40 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 06:41 |
| openstackgerrit | Michael Davies proposed openstack/ironic-specs: API Microversions https://review.openstack.org/161110 | 06:48 |
| *** mrda is now known as mrda-weekend | 06:49 | |
| mrda-weekend | Night Ironic, see you Monday | 06:49 |
| *** jcoufal has joined #openstack-ironic | 06:51 | |
| JoshNang | o/ | 06:51 |
| *** coolsvap is now known as coolsvap|afk | 06:54 | |
| *** coolsvap has joined #openstack-ironic | 07:09 | |
| *** Nisha has quit IRC | 07:09 | |
| *** Nisha has joined #openstack-ironic | 07:10 | |
| *** gridinv_ has joined #openstack-ironic | 07:18 | |
| *** gridinv_ has quit IRC | 07:23 | |
| *** jamielennox has quit IRC | 07:31 | |
| *** ifarkas has joined #openstack-ironic | 07:33 | |
| *** jamielennox has joined #openstack-ironic | 07:34 | |
| *** ijw has joined #openstack-ironic | 07:34 | |
| *** ijw has quit IRC | 07:35 | |
| *** ijw has joined #openstack-ironic | 07:36 | |
| *** ijw has quit IRC | 07:38 | |
| *** ijw has joined #openstack-ironic | 07:39 | |
| Haomeng | mrda-weekend: night:) | 07:39 |
| *** jamielennox has quit IRC | 07:39 | |
| *** athomas has joined #openstack-ironic | 07:42 | |
| *** jamielennox|away has joined #openstack-ironic | 07:55 | |
| *** jamielennox|away is now known as jamielennox | 07:55 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: ironic port deletion fails even if node is locked by same process https://review.openstack.org/161861 | 07:57 |
| *** coolsvap has quit IRC | 07:59 | |
| *** chlong has quit IRC | 08:09 | |
| GheRivero | morning | 08:09 |
| *** jistr has joined #openstack-ironic | 08:12 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement cleaning/zapping for the agent driver https://review.openstack.org/161453 | 08:21 |
| *** openstackgerrit has quit IRC | 08:21 | |
| *** openstackgerrit has joined #openstack-ironic | 08:22 | |
| *** Nisha_away has joined #openstack-ironic | 08:33 | |
| *** Nisha has quit IRC | 08:33 | |
| *** killer_prince has joined #openstack-ironic | 08:35 | |
| *** killer_prince is now known as lazy_prince | 08:35 | |
| *** dlpartain has joined #openstack-ironic | 08:38 | |
| *** dlpartain has left #openstack-ironic | 08:38 | |
| *** Nisha_away has quit IRC | 08:38 | |
| *** vdrok_afk is now known as vdrok | 08:46 | |
| vdrok | morning ironic | 08:46 |
| *** jistr has quit IRC | 08:46 | |
| *** andreykurilin_ has joined #openstack-ironic | 08:53 | |
| *** takadayuiko has quit IRC | 08:59 | |
| *** jistr has joined #openstack-ironic | 09:04 | |
| *** ndipanov has joined #openstack-ironic | 09:12 | |
| *** Nisha has joined #openstack-ironic | 09:17 | |
| *** tiagogomes_ has joined #openstack-ironic | 09:23 | |
| *** bnemec has quit IRC | 09:24 | |
| *** bnemec has joined #openstack-ironic | 09:25 | |
| *** andreykurilin_ has quit IRC | 09:31 | |
| *** andreykurilin_ has joined #openstack-ironic | 09:32 | |
| *** rameshg87 has joined #openstack-ironic | 09:39 | |
| *** sandhya has joined #openstack-ironic | 09:43 | |
| *** sandhya has quit IRC | 09:47 | |
| *** naohirot has quit IRC | 09:48 | |
| *** derekh has joined #openstack-ironic | 09:57 | |
| *** Nisha_away has joined #openstack-ironic | 10:11 | |
| *** Nisha has quit IRC | 10:11 | |
| *** igordcard_ has joined #openstack-ironic | 10:13 | |
| *** yog_ has quit IRC | 10:18 | |
| *** lucasagomes has joined #openstack-ironic | 10:21 | |
| *** Haomeng|2 has joined #openstack-ironic | 10:27 | |
| *** Haomeng has quit IRC | 10:30 | |
| *** athomas has quit IRC | 10:34 | |
| *** kozhukalov has joined #openstack-ironic | 10:37 | |
| *** MattMan has quit IRC | 10:38 | |
| *** andreykurilin_ has quit IRC | 10:39 | |
| openstackgerrit | Aparna proposed stackforge/proliantutils: ILO: Support for configuring httpboot through RIS https://review.openstack.org/163325 | 10:41 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 10:42 |
| *** lazy_prince has quit IRC | 10:42 | |
| *** pelix has joined #openstack-ironic | 10:45 | |
| rameshg87 | lucasagomes: the dib patch for uefi localboot got merged yesterday https://review.openstack.org/#/c/160687/ | 10:47 |
| lucasagomes | rameshg87, \o/! | 10:47 |
| rameshg87 | lucasagomes: i have raised one for ipa as well using uuids as we discussed: https://review.openstack.org/#/c/163739/ | 10:47 |
| rameshg87 | lucasagomes: and ofcourse the ironic change is back on review again: https://review.openstack.org/#/c/159855/ | 10:48 |
| lucasagomes | will do it now :D | 10:49 |
| rameshg87 | lucasagomes: please have a look at them when you get some time :) | 10:49 |
| *** athomas has joined #openstack-ironic | 10:50 | |
| *** MattMan has joined #openstack-ironic | 10:53 | |
| *** pas-ha has joined #openstack-ironic | 10:54 | |
| *** jamielennox has quit IRC | 10:55 | |
| pas-ha | morning all | 10:56 |
| *** killer_prince has joined #openstack-ironic | 10:58 | |
| *** Nisha_away has quit IRC | 10:58 | |
| *** killer_prince is now known as lazy_prince | 10:58 | |
| openstackgerrit | Anusha Ramineni proposed openstack/ironic: Add Cleaning Operations for iLO drivers https://review.openstack.org/157715 | 10:59 |
| *** harlowja_away has quit IRC | 10:59 | |
| openstackgerrit | Merged openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 11:00 |
| *** jamielennox|away has joined #openstack-ironic | 11:02 | |
| *** jamielennox|away is now known as jamielennox | 11:02 | |
| rameshg87 | sirushti: ^^^ | 11:02 |
| *** ramineni has quit IRC | 11:04 | |
| *** rameshg871 has joined #openstack-ironic | 11:05 | |
| *** pas-ha has quit IRC | 11:08 | |
| *** rameshg87 has quit IRC | 11:08 | |
| *** rameshg871 is now known as rameshg87 | 11:08 | |
| openstackgerrit | Nisha Agarwal proposed stackforge/proliantutils: Adding functionality required by ilo-inspection https://review.openstack.org/164142 | 11:10 |
| *** Nisha has joined #openstack-ironic | 11:14 | |
| *** jamielennox has quit IRC | 11:14 | |
| *** pas-ha has joined #openstack-ironic | 11:14 | |
| *** athomas_ has joined #openstack-ironic | 11:21 | |
| *** athomas has quit IRC | 11:21 | |
| *** jamielennox|away has joined #openstack-ironic | 11:24 | |
| *** jamielennox|away is now known as jamielennox | 11:24 | |
| *** lazy_prince is now known as killer_prince | 11:30 | |
| *** bauzas is now known as bauwser | 11:32 | |
| *** athomas_ is now known as athomas | 11:38 | |
| *** athomas has quit IRC | 11:40 | |
| *** athomas has joined #openstack-ironic | 11:43 | |
| *** jcoufal_ has joined #openstack-ironic | 11:45 | |
| *** chenglch has quit IRC | 11:47 | |
| *** jcoufal has quit IRC | 11:49 | |
| *** Nisha has quit IRC | 11:52 | |
| sirushti | rameshg87, OMG, finally! :) | 11:53 |
| rameshg87 | sirushti: yeah :) thanks a lot .. | 11:56 |
| rameshg87 | sirushti: i know you have rebase and resolved merge conflicts many times | 11:56 |
| rameshg87 | sirushti: now it's pay-back-time | 11:56 |
| *** ramineni has joined #openstack-ironic | 11:56 | |
| rameshg87 | sirushti: a dozen other patches would have hit merge conflict now :D | 11:56 |
| rameshg87 | sirushti: i myself hit on 3-4 patches after that. still working on resolving merge conflict after your patch got merged :) | 11:58 |
| sirushti | rameshg87, Haha :p Apologies for the merge conflicts all | 11:58 |
| rameshg87 | sirushti: :) | 11:59 |
| sirushti | rameshg87, anyway, time to go home :) | 11:59 |
| sirushti | night all | 12:00 |
| rameshg87 | sirushti: see you .. have a nice weekend :) | 12:00 |
| *** ndipanov is now known as ndipanoff | 12:04 | |
| *** igordcard_ has quit IRC | 12:05 | |
| *** lucasagomes is now known as lucas-hungry | 12:09 | |
| *** ramineni1 has joined #openstack-ironic | 12:10 | |
| *** ramineni has quit IRC | 12:12 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add localboot support for uefi boot mode https://review.openstack.org/159855 | 12:19 |
| *** Marga_ has quit IRC | 12:24 | |
| *** chlong has joined #openstack-ironic | 12:24 | |
| *** saripurigopi has quit IRC | 12:27 | |
| *** frontrunner has quit IRC | 12:34 | |
| *** frontrunner has joined #openstack-ironic | 12:35 | |
| *** dprince has joined #openstack-ironic | 12:42 | |
| *** jjohnson2 has joined #openstack-ironic | 12:50 | |
| NobodyCam | good morning, and .... (uncomfortably long pause) .... TGIF | 12:55 |
| *** kkoski has joined #openstack-ironic | 13:02 | |
| Shrews | happy friday NobodyCam | 13:03 |
| NobodyCam | :) morning Shrews :) | 13:03 |
| *** lucas-hungry is now known as lucasagomes | 13:03 | |
| *** rameshg871 has joined #openstack-ironic | 13:04 | |
| rameshg871 | lucasagomes: do you want to add the version of pyudev with which you have tested: https://review.openstack.org/#/c/163079/9/requirements.txt | 13:06 |
| *** rameshg87 has quit IRC | 13:07 | |
| *** rameshg871 is now known as rameshg87 | 13:07 | |
| lucasagomes | rameshg871, hi there, I can't :( | 13:07 |
| lucasagomes | it has to match with the global-requiremnts one | 13:08 |
| lucasagomes | rameshg87, https://github.com/openstack/requirements/blob/master/global-requirements.txt#L136 | 13:08 |
| lucasagomes | so I would need to cap the version there first and then do it on the IPA | 13:08 |
| lucasagomes | but to cap the version I gotta check other projects that also uses pyudev (since it was in the global-requirements before) | 13:08 |
| rameshg87 | lucasagomes: oh, it was there before, okay | 13:08 |
| lucasagomes | yeah it was there, I'm just using on IPA | 13:09 |
| lucasagomes | I think neutron use it | 13:09 |
| lucasagomes | not sure who else | 13:09 |
| rameshg87 | lucasagomes: just wanted to make sure all the things that we use for ipa are available in the most recent versions (eventhough pip pulls the latest always) :) | 13:09 |
| *** ijw has quit IRC | 13:09 | |
| rameshg87 | can someone please have a look at this : https://review.openstack.org/#/c/163589/ (and hopefully +A it :) ) | 13:10 |
| lucasagomes | rameshg87, yeah it's a good point, but I'm not sure what version to cap it with because of the other projects. if not capped it will download the latest | 13:12 |
| lucasagomes | so I think we are fine for now | 13:12 |
| lucasagomes | Shrews, hi there, I think IPA doesn't support i18n yet :( | 13:12 |
| lucasagomes | I've looked other logs they don't have i18n too | 13:12 |
| Shrews | lucasagomes: oh? odd | 13:13 |
| lucasagomes | Shrews, yeah, probably we need to set it up | 13:13 |
| lucasagomes | and set a transifex for it too etc | 13:13 |
| lucasagomes | all the i18n seems to be missing | 13:13 |
| Shrews | lucasagomes: let me change my vote then, since that's a much larger change | 13:13 |
| Shrews | thx for pointing it out | 13:13 |
| lucasagomes | Shrews, yeah I can look into it, but outside that patch cause it's not really on the scope | 13:14 |
| lucasagomes | np | 13:14 |
| rameshg87 | lucasagomes: Shrews, i don't know if it's really required | 13:15 |
| rameshg87 | lucasagomes: Shrews: i guess ironic translates all messages from ipa before it reaches user | 13:16 |
| lucasagomes | rameshg87, hmm how come? | 13:16 |
| lucasagomes | like IPA throws an exception and the message goes to Ironic | 13:16 |
| lucasagomes | how that gets translated? | 13:16 |
| Shrews | lucasagomes: also, i love the SpongeBob vendor | 13:16 |
| lucasagomes | Shrews, lol | 13:17 |
| rameshg87 | lucasagomes: oh translations works by manually translating to other languages right | 13:17 |
| lucasagomes | writing tests is boring, so we gotta make it more funny u know | 13:17 |
| lucasagomes | rameshg87, yes | 13:17 |
| rameshg87 | lucasagomes: oh completely missed that point | 13:17 |
| lucasagomes | rameshg87, https://www.transifex.com/projects/p/ironic/ | 13:17 |
| lucasagomes | rameshg87, yeah so I think we could set up i18n for IPA | 13:18 |
| lucasagomes | jroll, JayF ^ any thoughts on that? | 13:18 |
| *** rameshg871 has joined #openstack-ironic | 13:19 | |
| rameshg871 | Shrews: lucasagomes: i always was thinking it was done by some tool dynamically | 13:19 |
| rameshg871 | hehe | 13:19 |
| lucasagomes | :D yeah well translating languages is not easy | 13:19 |
| * rameshg871 should participate in translating once to my local language over here | 13:19 | |
| jroll | lucasagomes: morning, so | 13:20 |
| lucasagomes | rameshg87, +1 I did some brazilian portuguese | 13:20 |
| lucasagomes | but I should do more | 13:20 |
| lucasagomes | 11% only :( | 13:20 |
| rameshg871 | lucasagomes: oh awesome | 13:20 |
| lucasagomes | jroll, yo morning | 13:20 |
| rameshg871 | jroll: morning | 13:20 |
| jroll | lucasagomes: devananda and us explicitly decided that IPA isn't user facing so we shouldn't translate | 13:20 |
| jroll | however | 13:20 |
| lucasagomes | jroll, right, but as rameshg87 pointed out. Some exceptions from IPA are logged on Ironic no? | 13:21 |
| jroll | the errors are user facing | 13:21 |
| jroll | so idk. | 13:21 |
| lucasagomes | yes | 13:21 |
| lucasagomes | well we can talk about it, it's not a big deal | 13:21 |
| Shrews | lucasagomes: +A'd | 13:21 |
| jroll | yeah | 13:21 |
| jroll | morning rameshg871 and Shrews :) | 13:21 |
| lucasagomes | but I would be ok with the idea of translating the errors returned to ironic | 13:21 |
| lucasagomes | Shrews, \o/ | 13:21 |
| lucasagomes | thanks | 13:21 |
| Shrews | jroll: morning | 13:22 |
| *** rameshg87 has quit IRC | 13:22 | |
| *** Marga_ has joined #openstack-ironic | 13:23 | |
| jroll | I think today is a review day | 13:24 |
| * jroll catches up on all the scrollbacks and dives into cleaning | 13:24 | |
| NobodyCam | good morning jroll, lucasagomes rameshg871 :) | 13:24 |
| lucasagomes | NobodyCam, morning | 13:25 |
| NobodyCam | :) | 13:25 |
| jroll | heya NobodyCam, happy friday :D | 13:25 |
| NobodyCam | oh ya!!! | 13:25 |
| rameshg871 | NobodyCam: morning | 13:28 |
| * Shrews finally dives into the microversion spec | 13:28 | |
| NobodyCam | morning rameshg871 | 13:28 |
| rameshg871 | lucasagomes: https://review.openstack.org/#/c/163794/3/ironic/drivers/modules/pxe.py | 13:29 |
| rameshg871 | lucasagomes: the call iscsi_deploy.parse_root_device_hints(node) can be moved to iscsi_deploy.validate() no | 13:30 |
| rameshg871 | lucasagomes: i think it's harmless, anyway we would call the same method in agent methods as well | 13:30 |
| lucasagomes | rameshg871, right, I just find it odd having the agent to use iscsi_deploy | 13:31 |
| lucasagomes | rameshg871, but yeah I could add on both | 13:31 |
| lucasagomes | rameshg871, will do that | 13:31 |
| rameshg871 | lucasagomes: but anyway we are moving that method in the next patch, right ? | 13:32 |
| rameshg871 | lucasagomes: so deploy_utils.parse_root_device_hints() can be iscsi_deploy.validate() and agent methods :) | 13:32 |
| lucasagomes | rameshg871, true | 13:32 |
| lucasagomes | makes sense I will do that | 13:32 |
| rameshg871 | lucasagomes: thanks | 13:32 |
| rameshg871 | jroll: can you please have a look at https://review.openstack.org/#/c/162392/ | 13:33 |
| * jroll adds it to list | 13:33 | |
| * rameshg871 assumes jroll likes ipa patches more than ironic patches :D | 13:33 | |
| jroll | I don't :P | 13:34 |
| jroll | wait, I thought we landed this | 13:34 |
| rameshg871 | jroll: was that to me ? | 13:34 |
| jroll | yes | 13:35 |
| jroll | I'm just misinformed, ignore me :) | 13:35 |
| rameshg871 | jroll: :) | 13:35 |
| rameshg871 | jroll: there was naoihirot's patch for the same problem before (that is abandoned now) | 13:35 |
| jroll | rameshg871: so this is an edge case, but what if I make an image with a label of ir-vfd-dev | 13:35 |
| jroll | rameshg871: I think I could break the next deploy | 13:35 |
| jroll | (since cleaning isn't a thing yet) | 13:36 |
| jroll | rameshg871: I'm not sure there's a solution, just curious what you think | 13:36 |
| rameshg871 | jroll: do you mean a partition with the same label exists on some disk on the node somehow ? :) | 13:36 |
| jroll | rameshg871: yep :) | 13:37 |
| *** jjohnson2 has quit IRC | 13:37 | |
| jroll | (also, I wonder how linux handles that when putting things in /dev/disk/by-label) | 13:37 |
| rameshg871 | jroll: ah that's correct .. | 13:37 |
| rameshg871 | jroll: i think linux kernel would pick one | 13:38 |
| rameshg871 | jroll: at random | 13:38 |
| jroll | heh | 13:38 |
| rameshg871 | because it's a soft link | 13:38 |
| rameshg871 | and it can accomodate only one | 13:38 |
| jroll | ok, so roughly as deterministic as finding the deploy disk :) | 13:38 |
| rameshg871 | :) | 13:38 |
| rameshg871 | almost | 13:38 |
| jroll | I think it's fine for now, just something to keep in mind | 13:39 |
| * jroll continues reviewing | 13:39 | |
| *** Nisha has joined #openstack-ironic | 13:42 | |
| rameshg871 | but config drives work on the same way | 13:43 |
| rameshg871 | jroll: identifies by label :) | 13:43 |
| jroll | rameshg871: yeah, touche :) | 13:45 |
| *** rameshg871 is now known as rameshg87 | 13:45 | |
| *** sirushti has quit IRC | 13:45 | |
| NobodyCam | JoshNang: around? | 13:46 |
| NobodyCam | looking at https://review.openstack.org/#/c/155561/20/ironic/drivers/base.py should we have @abc.abstractmethod for the cleaning methods? | 13:47 |
| *** rameshg87 has quit IRC | 13:49 | |
| *** rameshg87 has joined #openstack-ironic | 13:52 | |
| *** sirushti has joined #openstack-ironic | 13:52 | |
| Shrews | NobodyCam: i looked at that earlier and got wrapped up in something else... iirc, if we did that, we'd force all drivers to implement those methods and have to change them all at once, rather than individually. Josh should weigh in, though, as to the intent. | 13:55 |
| rameshg87 | NobodyCam: i think if we add more abstract methods to deploy, we would need to add implementations for all deploy drivers: https://review.openstack.org/#/c/155561/20/ironic/drivers/base.py | 13:56 |
| rameshg87 | Shrews: yeah | 13:56 |
| Shrews | what rameshg87 said :) | 13:56 |
| rameshg87 | NobodyCam: instead just do a no-op for drivers that don't implement them | 13:56 |
| NobodyCam | ahh ok I left commet on the review | 14:00 |
| *** blinky42 has quit IRC | 14:02 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Add support for root device hints https://review.openstack.org/163079 | 14:02 |
| rameshg87 | jroll and other folks: https://review.openstack.org/#/c/159322/4/ironic/conductor/manager.py | 14:03 |
| rameshg87 | we would end up talking to the agent service that is running on the baremetal node synchoronously on an GET api call | 14:04 |
| rameshg87 | i hope since agent is an openstack service, it should be fine | 14:04 |
| rameshg87 | any thoughts ? | 14:04 |
| jroll | since when are openstack services fast? :) | 14:05 |
| *** r-daneel has joined #openstack-ironic | 14:06 | |
| rameshg87 | jroll: i meant we try to make them fast :) | 14:06 |
| jroll | I think it's likely fine, because: 1) the cleaning steps in the agent are a static list; 2) it seems complex to store them somehow beforehand (at agent boot?) in order to avoid talking to the agent synchronously | 14:06 |
| jroll | and 3) the agent is fairly fast | 14:06 |
| rameshg87 | but on the counter-point it depends on resources in the bare metal | 14:06 |
| rameshg87 | i mean how fast agent can respond depends on the resources in the bare metal | 14:06 |
| rameshg87 | and decides whether api will timeout or not | 14:07 |
| openstackgerrit | Merged openstack/python-ironicclient: Fix two error strings in the CLI https://review.openstack.org/162431 | 14:08 |
| jroll | rameshg87: I don't know of a machine where the agent would be that slow to return an API call | 14:08 |
| * jroll curious to run this on a raspberry pi and benchmark api responses | 14:08 | |
| jroll | rameshg87: would I be able to put the virtualmedia iso on an sd card and boot it? | 14:09 |
| NobodyCam | rameshg87: did we bump the raid stuff? | 14:10 |
| jroll | NobodyCam: I believe so because it depends on zapping | 14:10 |
| rameshg87 | NobodyCam: yeah unfortunately :( | 14:10 |
| NobodyCam | ack thats what I thought | 14:10 |
| NobodyCam | :( | 14:10 |
| rameshg87 | jroll: someone checked this actually - using ironic to provision embedded boards | 14:10 |
| rameshg87 | jroll: sometime back in irc | 14:11 |
| rameshg87 | jroll: now raspberry pis come with 512 mb ram, so should be able to do it over network itself | 14:11 |
| jroll | rameshg87: just thinking about a regular machine, booting via sd card / usb / etc | 14:11 |
| jroll | though it's ARM... idk if coreos runs on ARM | 14:11 |
| rameshg87 | jroll: why sd card ? | 14:11 |
| jroll | pis don't have a PXE rom :( | 14:11 |
| NobodyCam | I thought pi's had issues with pxe booting | 14:11 |
| jroll | rameshg87: that's how raspberry pis boot :) | 14:12 |
| rameshg87 | jroll: oh right, i read | 14:12 |
| rameshg87 | jroll: by loading a static file from sdcard, right ? | 14:12 |
| * jroll has a raspberry pi sitting on his desk and is thinking about booting the agent on it for fun | 14:12 | |
| jroll | yes, something like that | 14:12 |
| rameshg87 | jroll: interesting .. :) | 14:12 |
| jroll | might just boot debian/ubuntu and load the agent on it | 14:13 |
| * rameshg87 is also interested on booting embedded boards | 14:15 | |
| rameshg87 | jroll: iscsi deploy should work right ? | 14:16 |
| rameshg87 | jroll: kernel needs to have enough ram to start itself and start software iscsi target | 14:16 |
| *** ChuckC_ has joined #openstack-ironic | 14:16 | |
| rameshg87 | jroll: i think we already run iscsi deploy with 512 mb ram vms on gate | 14:16 |
| jroll | rameshg87: it can't pxe boot | 14:16 |
| *** ChuckC has quit IRC | 14:17 | |
| rameshg87 | jroll: yeah assuming we fix that :) | 14:17 |
| jroll | I'm not flashing the firmware :P | 14:17 |
| rameshg87 | jroll: i mean not flashing firmware | 14:17 |
| jroll | rameshg87: so going back to the vmedia params thing... why not use a uuid? | 14:17 |
| jroll | well ti doesn't have any pxe stuff in the firmware | 14:17 |
| rameshg87 | jroll: how does agent know uuid | 14:17 |
| *** Nisha has quit IRC | 14:18 | |
| jroll | heh | 14:18 |
| jroll | I was just wondering that | 14:18 |
| rameshg87 | jroll: in vmedia, we need to know the ironic url only after reading from vmedia | 14:18 |
| rameshg87 | jroll: so back to the problem how do we pass uuid to the agent :) | 14:18 |
| jroll | rameshg87: could be a static UUID though | 14:19 |
| jroll | 000000-000-000-00-00000 or whatever | 14:19 |
| rameshg87 | jroll: yeah possible | 14:20 |
| jroll | but then the same thing could happen | 14:20 |
| rameshg87 | jroll: but we can argue that someone mischevious can assign the same static UUID to some partition | 14:20 |
| rameshg87 | jroll: hehe | 14:20 |
| jroll | :) | 14:21 |
| rameshg87 | jroll: (after looking at ironic code obviously) | 14:21 |
| jroll | yeah | 14:21 |
| jroll | make it a config option | 14:21 |
| jroll | :P | 14:21 |
| jroll | oh but then how do you get that to the agent... urgh | 14:21 |
| rameshg87 | hehe | 14:21 |
| rameshg87 | if agent has to pre know it - it has to be static | 14:22 |
| rameshg87 | jroll: so here it is coming back to rpi - put uboot on the sdcard, configure uboot to always boot from network, and let ironic not touch this partition containing uboot | 14:22 |
| *** ChuckC_ has quit IRC | 14:23 | |
| jroll | rameshg87: yeah, I've thought about that | 14:23 |
| BadCub | Morning Folks | 14:24 |
| NobodyCam | morning BadCub | 14:24 |
| NobodyCam | seems we've started the jam! unofficially ofc | 14:25 |
| BadCub | Awesome! | 14:25 |
| rameshg87 | started ? when ? :) | 14:25 |
| jroll | heh | 14:25 |
| NobodyCam | we all seem to be reviewing things | 14:26 |
| NobodyCam | :-p | 14:26 |
| rameshg87 | and nobody is writing code :) | 14:26 |
| NobodyCam | i nomante JayF to write all the code! | 14:26 |
| NobodyCam | hehehehe | 14:26 |
| rameshg87 | btw NobodyCam, any reason behind your name "NobodyCam" ? | 14:26 |
| NobodyCam | was a typo over 20 years ago. when I set up my hotmail account :-p | 14:27 |
| * NobodyCam tried to type NobodyCan | 14:28 | |
| NobodyCam | but failed | 14:28 |
| NobodyCam | and it just stuck | 14:28 |
| rameshg87 | oh :) | 14:28 |
| NobodyCam | lol | 14:28 |
| NobodyCam | can anyone access: https://docs.google.com/spreadsheets/d/1Hxyfy60hN_Fit0b-plsPzK6yW3ePQC5IfwuzJwltlbo/edit#gid=1604970109 | 14:29 |
| jroll | lol | 14:30 |
| jroll | "Waiting for docs.google.com..." | 14:31 |
| NobodyCam | lol google broke :-p | 14:31 |
| jroll | game over | 14:31 |
| jroll | for real though, it's broken | 14:32 |
| rameshg87 | me too :( | 14:35 |
| * lucasagomes is not sure why gate-project-config-layout is failing on https://review.openstack.org/#/c/163344/ | 14:35 | |
| rameshg87 | opened :) | 14:35 |
| Shrews | ALL: please try not to 'recheck' without a bug number if possible. It makes it more difficult to see how often a problem is occuring. | 14:35 |
| * lucasagomes found sth | 14:36 | |
| Shrews | this one looks particularly interesting: http://logs.openstack.org/29/164029/3/check/check-tempest-dsvm-ironic-pxe_ssh/075b1a0/console.html#_2015-03-13_05_39_39_588 | 14:36 |
| rameshg87 | Shrews: do we have an easy way of bug # for recheks ? | 14:38 |
| rameshg87 | Shrews: is it there in some etherpad ? | 14:38 |
| jroll | Shrews: I thought they didn't record bug numbers any more and everything relies on elastic recheck now | 14:38 |
| Shrews | rameshg87: first check http://status.openstack.org/elastic-recheck for an existing bug | 14:38 |
| Shrews | rameshg87: if there is none, create a new bug | 14:38 |
| Shrews | jroll: this is news to me. if so, someone still has to build an e-r check, yes? | 14:39 |
| NobodyCam | Shrews: I try to use recheck # | 14:39 |
| Shrews | jroll: was something sent to the ML about that? | 14:39 |
| jroll | Shrews: yes, and dunno | 14:40 |
| * BadCub is sad that the great Google wont share the spreadsheet | 14:40 | |
| *** rameshg87 has quit IRC | 14:40 | |
| *** rameshg87 has joined #openstack-ironic | 14:41 | |
| rameshg87 | Shrews: should we add it in wiki ? | 14:42 |
| * rameshg87 checks if it's there | 14:42 | |
| devananda | g'morning, all | 14:42 |
| NobodyCam | goood morning devananda | 14:42 |
| BadCub | devananda: morning | 14:42 |
| rameshg87 | devananda: o/ | 14:43 |
| jroll | heya devananda :) | 14:43 |
| devananda | rameshg87: http://status.openstack.org/elastic-recheck/ | 14:44 |
| devananda | rameshg87: how to add a new e-r query: http://docs.openstack.org/infra/elastic-recheck/readme.html#adding-bug-signatures | 14:44 |
| *** mgoddard1 has joined #openstack-ironic | 14:45 | |
| rameshg87 | devananda: okay .. | 14:46 |
| *** mgoddard has quit IRC | 14:47 | |
| rameshg87 | lucasagomes: https://review.openstack.org/#/c/159855/ needs your review again after rebase (after merge of whole disk image thing) | 14:47 |
| lucasagomes | ack | 14:48 |
| rameshg87 | Shrews: devananda: i think we should just document it in our wiki for someone new to know | 14:48 |
| rameshg87 | devananda: this looks like the place to me: https://wiki.openstack.org/wiki/Ironic/Developer_guidelines | 14:48 |
| Shrews | people read our wiki? :) | 14:49 |
| Shrews | rameshg87: feel free to update the wiki | 14:49 |
| devananda | oh, that page is old :) | 14:50 |
| lucasagomes | devananda, morning | 14:50 |
| lucasagomes | BadCub, morning too :) | 14:50 |
| BadCub | lucasagomes: morning bud! Happy Friday!!!! :-) | 14:51 |
| lucasagomes | \o/ | 14:51 |
| *** ramineni1 has quit IRC | 14:51 | |
| *** mgoddard1 has quit IRC | 14:52 | |
| * Shrews waves to BadCub, hopes his morning is pounce-free | 14:52 | |
| BadCub | Shrews: LOL, It's only pounce free if I hide from the circus! hehehe | 14:53 |
| Shrews | :) | 14:53 |
| *** subscope has quit IRC | 14:53 | |
| *** mgoddard has joined #openstack-ironic | 14:53 | |
| jroll | hahaha | 14:55 |
| jroll | morning BadCub :) | 14:55 |
| * jroll is going to have to -1 the first cleaning patch :( | 14:56 | |
| BadCub | jroll: morning and happy friday! | 14:56 |
| jroll | (or update it) | 14:56 |
| *** thiagop_ has joined #openstack-ironic | 14:57 | |
| rameshg87 | Shrews: done, https://wiki.openstack.org/wiki/Ironic/Developer_guidelines#Guidelines_for_Developers | 14:58 |
| jroll | JoshNang: unless you're aroudn in the next five minutes I'm gonna update your patch | 14:58 |
| NobodyCam | anyone object to me +a'ing a patch that is only a typo correction? https://review.openstack.org/#/c/162610 adds a single comma | 15:01 |
| devananda | NobodyCam: do eet | 15:02 |
| NobodyCam | done | 15:03 |
| NobodyCam | :) | 15:03 |
| BadCub | cool | 15:03 |
| BadCub | I put a comment on https://review.openstack.org/#/c/151596/ looks like it just needs to be rebased | 15:03 |
| BadCub | Any non-HP Cores please look at https://review.openstack.org/#/c/161861 has 2 +2s from HP'ers | 15:04 |
| openstackgerrit | Merged openstack/ironic-specs: Fix typo in ironic-specs/specs/kilo/ironic-node-properties-discovery.rst https://review.openstack.org/162610 | 15:05 |
| jroll | we don't translate debug messages right? | 15:06 |
| NobodyCam | correct | 15:07 |
| jroll | ignore me, answered my own question | 15:07 |
| jroll | heh thanks :P | 15:07 |
| NobodyCam | :-p | 15:07 |
| NobodyCam | \i jroll | 15:07 |
| NobodyCam | lol | 15:07 |
| *** ChuckC_ has joined #openstack-ironic | 15:07 | |
| jroll | :P | 15:08 |
| NobodyCam | :-p | 15:08 |
| devananda | TheJulia: I just found this open in a tab, and realize I think I forgot to file a bug for it - http://paste.openstack.org/show/189428/ | 15:09 |
| *** Marga_ has quit IRC | 15:10 | |
| *** yuriyz has quit IRC | 15:11 | |
| TheJulia | devananda: Thanks for the reminder, I was working on getting all the information together yesterday and then got interrupted. | 15:11 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Update unittests and use NamedTemporaryFile https://review.openstack.org/162672 | 15:12 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 15:12 |
| jroll | NobodyCam: rameshg87 lucasagomes ^ adds migration test and fixes nits | 15:13 |
| NobodyCam | lol H802 git commit title should be under 50 chars ... lol sometimes /me thinks flake8 can be too pickey .. lol | 15:13 |
| jroll | previously 2x+2 | 15:13 |
| lucasagomes | jroll, cool | 15:13 |
| *** mtanino has joined #openstack-ironic | 15:13 | |
| lucasagomes | jroll, I had a question on whether we should enable it by default too | 15:13 |
| lucasagomes | jroll, you have opnions on that? It sounds like a logical thing for me to do | 15:13 |
| lucasagomes | since we have no-op operations | 15:13 |
| *** jgrimm has quit IRC | 15:13 | |
| lucasagomes | and when we talk about config defauls they should be production defauls | 15:14 |
| *** ramineni has joined #openstack-ironic | 15:14 | |
| jroll | lucasagomes: in general I agree but I think it may need some time to bake | 15:14 |
| *** jgrimm has joined #openstack-ironic | 15:14 | |
| lucasagomes | have the node cleaned after usage, seems a good production default to me | 15:14 |
| *** thiagop_ has quit IRC | 15:14 | |
| lucasagomes | since that's remove old user data from the node | 15:14 |
| lucasagomes | jroll, right | 15:14 |
| jroll | lucasagomes: I vote enable it in tempest somehow and enable by default before kilo final | 15:14 |
| devananda | NobodyCam: yes. we should be able to ignore that flake check | 15:14 |
| NobodyCam | ahh is ^^ this about the cleaning default | 15:14 |
| devananda | NobodyCam: did someone turn on H802? | 15:14 |
| jroll | NobodyCam: ya | 15:14 |
| rameshg87 | jroll: will have a look in a few mins | 15:15 |
| *** rameshg87 is now known as rameshg87-away | 15:15 | |
| NobodyCam | devananda: https://review.openstack.org/#/c/163572 hit that one | 15:15 |
| lucasagomes | jroll, fair enough, yeah it would be good to have a default true on kilo | 15:15 |
| jroll | I agree | 15:15 |
| * lucasagomes considers not cleaning the node a serious bug | 15:15 | |
| lucasagomes | I mean not bug, but misleading default at least | 15:15 |
| NobodyCam | jroll: lucasagomes: ya I do agree with JoshNang about the false setting to start with.. but not a blocker for me | 15:16 |
| *** viktors has quit IRC | 15:16 | |
| jroll | lucasagomes: I do too | 15:16 |
| jroll | and it is a bug | 15:16 |
| jroll | (imo) | 15:16 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: iLO driver updates node capabilities during inspection Inpects hardware to get some of the capabilities https://review.openstack.org/163572 | 15:16 |
| NobodyCam | lol ty devananda :) | 15:17 |
| lucasagomes | NobodyCam, yeah I wouldn't -1 for that. But it's good to think about strategy on making it enabled by default since for production we may expect the node to be cleaned (I believe) | 15:17 |
| lucasagomes | anyhoo, I'm good with the false for now | 15:17 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: iLO driver updates node capabilities during inspection https://review.openstack.org/163572 | 15:17 |
| jroll | ^ needed a blank line too :P | 15:17 |
| jroll | lucasagomes: yeah I think it should be a goal for kilo, though switching it between k3 and k final might be a bad thing (tm) to do, devananda thoughts? | 15:18 |
| devananda | jroll: switching what? | 15:19 |
| jroll | devananda: enabling cleaning by default | 15:19 |
| jroll | currently disabled by default | 15:20 |
| devananda | jroll: no. we do that as soon as L opens | 15:20 |
| jroll | mehhhh. | 15:20 |
| devananda | because the feature hasn't been in-tree long enough at this point | 15:20 |
| jroll | what if we tested it in tempest? :) | 15:20 |
| devananda | jroll: well, that'd be great | 15:20 |
| jroll | but still not enough? | 15:21 |
| devananda | jroll: if tempest scenario test covers it in the pxe_ssh job, and we turn it on now(), we have another few weeks for it to bake | 15:21 |
| devananda | an dthat's it | 15:21 |
| jroll | uh huh... | 15:21 |
| jroll | a few weeks is a long time for most software :) | 15:21 |
| devananda | yup | 15:21 |
| devananda | if we dont have a tempest test, I'm really not comfortable enabling it by default | 15:21 |
| devananda | if we do, and it works and all that -- probably OK | 15:22 |
| jroll | I mean if we enable it in tempest now are you ok with enabling by default for kilo (or even now) | 15:22 |
| *** Nisha has joined #openstack-ironic | 15:22 | |
| jroll | enabling by default now will test it in tempest :P | 15:22 |
| jroll | or it won't because that job doesn't vote, boo. | 15:22 |
| devananda | which job? | 15:23 |
| jroll | the pxe job with ipa ramdisk | 15:23 |
| jroll | because it's a no-op without IPA | 15:23 |
| devananda | ah right | 15:23 |
| jroll | so of course it will work | 15:23 |
| jroll | though the IPA job votes | 15:23 |
| jroll | let's do it by default now | 15:23 |
| jroll | because sanity. | 15:24 |
| jroll | because not cleaning is a huge bug imo | 15:24 |
| devananda | jroll: agent_ssh is voting | 15:24 |
| lucasagomes | +1 | 15:24 |
| jroll | right, I missed that | 15:24 |
| * jroll finds more coffee | 15:24 | |
| lucasagomes | I'm fine adding to tests first just to be safe | 15:24 |
| devananda | so there are two kinds of tests that tepmest runs | 15:25 |
| lucasagomes | but I'd like to see the default changing to true soon, cause that's what we should enable for production | 15:25 |
| jroll | lucasagomes: if it's enabled it happens on teardown... let's enable it and see what happens | 15:25 |
| BadCub | ++ on more cofffee | 15:25 |
| lucasagomes | jroll, ack | 15:25 |
| * jlvillal just found coffee :) | 15:25 | |
| devananda | API (functional) tests and scenario tests | 15:25 |
| NobodyCam | morning jlvillal | 15:25 |
| devananda | jroll: no no ... | 15:25 |
| jroll | ... | 15:26 |
| jroll | (this will also actually test the IPA changes that do stuff) | 15:26 |
| devananda | I'm really not clear on something here. or maybe I am and just need more coffee | 15:26 |
| jroll | (rather than dropping those in without real testing) | 15:26 |
| jlvillal | NobodyCam: Good morning :) I'm feeling like I'm getting close on that temporary file patch. Not sure if you are feeling like me, but it seems like what was going to be a simple patch became more of an epic adventure :) | 15:26 |
| devananda | jroll: did ya'll add API functional tests to tempest yet? | 15:26 |
| jroll | devananda: it's clear, you're more reserved about this than me | 15:26 |
| jroll | devananda: no | 15:26 |
| devananda | eg, with the fake driver, to exercise the API about it | 15:26 |
| jroll | there's no API | 15:27 |
| jroll | it just happens on teardown. | 15:27 |
| devananda | oh | 15:27 |
| devananda | right. not zapping | 15:27 |
| lucasagomes | the cleaning is invoked from manageable -> available, deleting -> available | 15:27 |
| jroll | right. | 15:27 |
| devananda | gotcha | 15:27 |
| devananda | so what is there to enable? | 15:27 |
| jroll | so I'm thinking I enable it by default now. let's see how the gate goes. | 15:27 |
| jroll | the config option to clean after teardown. | 15:27 |
| lucasagomes | devananda, you could configure whether you want clean to run automatically (on that flow above) or not | 15:28 |
| devananda | why is there a config option for that? | 15:28 |
| devananda | I'm sure that seems like a dumb question | 15:28 |
| jroll | because some people don't care about cleaning | 15:28 |
| lucasagomes | imo, it should be enabled by default. Cause in a production cloud we should get rid of rprevious tenant data | 15:28 |
| devananda | but if having it default to True is so important ... | 15:28 |
| jroll | people have been running ironic without it | 15:28 |
| lucasagomes | and right now it's no-op so it's safe | 15:28 |
| jroll | clearly they don't care | 15:28 |
| jroll | but it's a sane production default | 15:28 |
| NobodyCam | sane once we know its all working as it should | 15:29 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 15:29 |
| jroll | there, enabled. | 15:29 |
| jroll | let's see how the gate goes | 15:29 |
| NobodyCam | just thinking out loud | 15:29 |
| jroll | (should be fine, it's a no-op on this patch | 15:29 |
| jroll | ) | 15:29 |
| devananda | jroll: my suggestion would be two patches | 15:29 |
| jroll | devananda: | 15:29 |
| jroll | grr, typing is hard | 15:30 |
| devananda | jroll: land the feature in step 1. turn it on in a tiny follow on patch | 15:30 |
| *** rameshg87-away is now known as rameshg87 | 15:30 | |
| devananda | jroll: but ths is fine too | 15:30 |
| jroll | devananda: why a separate patch? | 15:30 |
| jroll | ok | 15:30 |
| * NobodyCam offers jroll some of his fresh coffee | 15:30 | |
| jroll | that last patchset enables it | 15:30 |
| devananda | jroll: if having it on breaks this patch, well, we'll know something's wrong :) | 15:30 |
| * jroll fixes commit message | 15:30 | |
| jroll | yep. | 15:30 |
| lucasagomes | jroll, related but off-topic. I really want to have the cleaning/zapping steps in the future to be configured like pluggins you know | 15:30 |
| jroll | devananda: and it doesn't do any real things in this patch, so IMO if this breaks it's horribly wrong | 15:30 |
| devananda | jroll: also, you may want to tag this bug on that commit https://bugs.launchpad.net/ironic/+bug/1174153 | 15:30 |
| openstack | Launchpad bug 1174153 in Ironic "data from previous tenants accessible with nova baremetal" [High,Triaged] | 15:31 |
| lucasagomes | where you could add a step without having to change the drivers code directly | 15:31 |
| BadCub | brb | 15:31 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 15:31 |
| jroll | commit message fixed | 15:31 |
| jroll | or not /me adds bug | 15:31 |
| jroll | well | 15:31 |
| lucasagomes | Relate-Bug :) | 15:31 |
| jroll | this patch specifically doesn't do any disk erasing | 15:31 |
| TheJulia | devananda: Opened, https://bugs.launchpad.net/ironic/+bug/1431929 | 15:31 |
| openstack | Launchpad bug 1431929 in Ironic "Ironic failing to gracefully handle: ipmi error "insufficient resources for session"" [Undecided,New] | 15:31 |
| devananda | jroll: oh | 15:32 |
| devananda | jroll: then what does it do?? | 15:32 |
| jroll | I've already pointed that bug at the BP so I think "related" is already there | 15:32 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 15:32 |
| *** Nisha has quit IRC | 15:32 | |
| jroll | devananda: calls all of the clean steps (which today is []) | 15:32 |
| jroll | devananda: if we add a clean step to the agent after this lands, it will run. | 15:32 |
| devananda | jroll: I see. so here's my concern with a) landing it in that order b) turning it on by default | 15:32 |
| *** Nisha has joined #openstack-ironic | 15:33 | |
| *** rameshg87 has quit IRC | 15:33 | |
| * jroll listens | 15:33 | |
| *** david-lyle_afk is now known as david-lyle | 15:33 | |
| devananda | if it's not ACTUALLY doing the cleaning, it might be broken right now and we dont know it | 15:33 |
| devananda | landing it in that state,w hich I'd call experimental, is questionable, but probably ok | 15:33 |
| devananda | turning it on by default when there's nothing using it yet -- not OK. signals that others should add their own implementations,which, well, it's untested, so ... | 15:34 |
| devananda | jroll: so -- if should really be DOING something in a voting job | 15:34 |
| devananda | ideally, actually, in a non-voting job so we can watch it for a bit. then make it voting // on by default | 15:34 |
| devananda | but meh. it's not going to break any othe rproject's gate, and we can fix it since it's in our tree | 15:34 |
| lucasagomes | my 0.2c is that this patch is 1 patch of a series, this does the plumbing work | 15:34 |
| devananda | so I'm ok with landi ngit in a voting project to start | 15:35 |
| lucasagomes | the next patches on the series will add a cleaning task and then we will confirm if it's working | 15:35 |
| jroll | yeah, I like the plumbing being tested | 15:35 |
| devananda | lucasagomes: right. we dont enable by default until we know the whole patch series works as expected | 15:35 |
| lucasagomes | we always can revert it if it doesn't | 15:35 |
| jroll | I'm thinking of it from a code coverage perspective | 15:35 |
| lucasagomes | or fix | 15:35 |
| *** rameshg87 has joined #openstack-ironic | 15:35 | |
| jroll | devananda: we don't know if the whole series works if we're not testing it | 15:35 |
| devananda | jroll: we should be testing it before we land it! | 15:35 |
| devananda | jroll: the right way to do that is create a separate -nv job that toggles a config option | 15:36 |
| devananda | or an -experimental job | 15:36 |
| jroll | devananda: testing it in the gate does that. | 15:36 |
| devananda | jroll: so you set the default to True in the base patch, then rebase the others on top of that, and we watch the test results | 15:37 |
| devananda | we don't land it right away | 15:37 |
| devananda | I agree with that | 15:37 |
| lucasagomes | +1 | 15:37 |
| jroll | sure thing | 15:37 |
| lucasagomes | we can see the others patches on the series failing if it doesn't work | 15:37 |
| devananda | cool | 15:37 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add Cleaning Operations for iLO drivers https://review.openstack.org/157715 | 15:38 |
| devananda | i thought you were advocating turning it on by default then landing the first patch. apologies if I misunderstood | 15:38 |
| lucasagomes | I wanna see if that works too, but I think that logically it makes sense to have a patch doing the plumbing work and other patches on the series adding actually cleaning tasks | 15:39 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add /nodes/<uuid>/cleaning/steps API https://review.openstack.org/159322 | 15:39 |
| lucasagomes | so yeah wait the tests run and then we can land stuff once everything in the series is passing | 15:39 |
| devananda | lucasagomes: totally makes sense to break up the patches like that. | 15:40 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Implement cleaning/zapping for the agent driver https://review.openstack.org/161453 | 15:40 |
| lucasagomes | yeah | 15:40 |
| jroll | ok everything is rebased now | 15:40 |
| devananda | jroll: cheers, thanks | 15:40 |
| lucasagomes | cause if we land as false, someone can turn it to true | 15:40 |
| jroll | yeah np | 15:40 |
| lucasagomes | and things can fail without any testing | 15:40 |
| lucasagomes | that's bad imo | 15:41 |
| * jroll walks his dog, bbiab | 15:41 | |
| NobodyCam | :) enjoy jroll | 15:41 |
| devananda | lucasagomes: well. in that case, we would need to have a separate job that enables it, so that we test both | 15:41 |
| lucasagomes | devananda, oh yeah, that's true | 15:42 |
| JoshNang | good morning y'all | 15:42 |
| *** jcoufal_ has quit IRC | 15:42 | |
| JoshNang | jroll: thanks for pushing up those fixes | 15:43 |
| devananda | JoshNang, jroll: oh hey, I didnt realize you needed a patch to nova??!!? https://review.openstack.org/#/c/161474 | 15:43 |
| devananda | JoshNang: so that's almost guaranteed not to land | 15:44 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Force LANGUAGE=en_US in test runs https://review.openstack.org/164226 | 15:44 |
| lucasagomes | :( noes | 15:44 |
| JoshNang | devananda: hmm? how will it not land? | 15:44 |
| devananda | i may be exxagerating, but they've been very hesitant to allow in changes like that to drivers, which I do not understand | 15:44 |
| lucasagomes | (wonder if we need to use the Depends-On tag on ironic too) | 15:44 |
| devananda | JoshNang: nova is well past feature freeze | 15:44 |
| *** mdbooth has quit IRC | 15:45 | |
| JoshNang | full feature freeze? or non priority feature freeze? | 15:45 |
| devananda | full | 15:45 |
| devananda | so if it's not a bug ... | 15:45 |
| devananda | and this is clearly not a bug | 15:45 |
| devananda | and it wasn't granted a FFE | 15:45 |
| JoshNang | their wiki says general FF is march 19 | 15:47 |
| devananda | ah, my mistake | 15:47 |
| JoshNang | my goal was to poke nova people all morning :) | 15:48 |
| devananda | JoshNang: go for it :) | 15:48 |
| devananda | also, I think we can improve that code by not listing states that the node may or may not reach | 15:48 |
| *** ChuckC_ has quit IRC | 15:49 | |
| NobodyCam | ok some thing strange: http://logs.openstack.org/29/164029/3/check/check-tempest-dsvm-ironic-pxe_ssh/075b1a0/logs/screen-ir-cond.txt.gz#_2015-03-13_05_31_24_237 | 15:49 |
| devananda | yea that whole block of code is buggy | 15:49 |
| NobodyCam | that should cause this: (should it) http://logs.openstack.org/29/164029/3/check/check-tempest-dsvm-ironic-pxe_ssh/075b1a0/console.html#_2015-03-13_05_39_39_587 | 15:49 |
| *** mdbooth has joined #openstack-ironic | 15:50 | |
| NobodyCam | *that shouldn't * | 15:50 |
| devananda | JoshNang: shouldn't _unprovision return success if the request is actioned, not based on what the next state is? | 15:50 |
| devananda | NobodyCam: those look unrelated. what caused the lock? | 15:51 |
| devananda | NobodyCam: also those are 8 minutes aparat | 15:51 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add validations for root device hints https://review.openstack.org/163794 | 15:51 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: IPA: Add support for root device hints https://review.openstack.org/163857 | 15:51 |
| devananda | NobodyCam: oooh. we changed delete_port to now require a lock | 15:51 |
| JoshNang | devananda: hmm let me look. i'm assuming it was that way for async-ness? | 15:51 |
| NobodyCam | oh ya | 15:52 |
| devananda | NobodyCam: there's the failure http://logs.openstack.org/29/164029/3/check/check-tempest-dsvm-ironic-pxe_ssh/075b1a0/console.html#_2015-03-13_05_31_22_808 | 15:52 |
| *** Nisha has quit IRC | 15:52 | |
| *** hemna has joined #openstack-ironic | 15:53 | |
| devananda | NobodyCam: which coincides with the timing of hte sync power state run -- http://logs.openstack.org/29/164029/3/check/check-tempest-dsvm-ironic-pxe_ssh/075b1a0/logs/screen-ir-cond.txt.gz#_2015-03-13_05_31_22_857 | 15:53 |
| *** ChuckC has joined #openstack-ironic | 15:53 | |
| devananda | http://logs.openstack.org/29/164029/3/check/check-tempest-dsvm-ironic-pxe_ssh/075b1a0/logs/screen-ir-api.txt.gz#_2015-03-13_05_31_22_767 | 15:53 |
| *** logan2 has joined #openstack-ironic | 15:54 | |
| devananda | so we introduced a new race condition yesterday. awesome | 15:54 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 15:55 |
| rameshg87 | 2 year old bug finally tagged in a commit \o/ | 15:56 |
| rameshg87 | ^^^^ | 15:56 |
| jroll | devananda: I'd say the power sync loop is the race condition, not the lock-for-port-destroy. | 15:56 |
| devananda | oh, no, we didn't land it yet | 15:56 |
| NobodyCam | lol | 15:56 |
| devananda | jroll: yea - i thought that https://review.openstack.org/#/c/161861/ might have created that ^ failure. but it hasn't landed yet | 15:57 |
| jroll | oh huh | 15:57 |
| jroll | well | 15:57 |
| jroll | destroy_port checks the lock either way | 15:57 |
| devananda | right | 15:57 |
| jroll | before or after that change | 15:57 |
| JoshNang | so i'm unclear. when the ironic api calls rpcapi.do_node_tear_down, does it wait for that call to execute before returning? or return immediately once it's on the rpc bus? | 15:58 |
| *** Nisha has joined #openstack-ironic | 15:58 | |
| jroll | JoshNang: it waits | 15:59 |
| jroll | which is why we tend to use _spawn_worker | 15:59 |
| JoshNang | gotcha | 15:59 |
| jroll | (I'm not 100% sure I'm right, but yeah) | 15:59 |
| devananda | JoshNang: it waits for confirmation that the job was received by the conductor, and the work started without error | 16:00 |
| JoshNang | devananda: so, this ensures tear_down() and cleanup() have been run before it disappears from the users list. for example, if we can't power off the node, we error the delete, so the user is aware their box is still open to the internet | 16:01 |
| devananda | JoshNang: IOW, it waits for spawn_worker to be called, but does not wait for the delete to actually finish | 16:01 |
| devananda | JoshNang: right. and similarly, we leave the instance UUID set in Ironic so it can't associate with another user | 16:01 |
| devananda | s/usr/instance/ | 16:01 |
| JoshNang | right, makes sense | 16:01 |
| devananda | JoshNang: so Nova showing that the node is in "deleting" state for a long time -- the whole duration of cleaning -- actually might be the right behavior | 16:02 |
| devananda | the node isn't available for another user // instance yet, and the node still has (some) of old-user's data on it | 16:02 |
| JayF | Oh wow, I can't disagree more | 16:02 |
| jroll | eh? | 16:02 |
| devananda | as a user, I'd say the node is still "being deleted" until all of my data is gone | 16:03 |
| jroll | if we only provision to nodes in AVAILABLE, there's no reason to let it sit. | 16:03 |
| devananda | HOWEVER i don't want to get billed for that time | 16:03 |
| jroll | eh, the instance is deleted as soon as I can't use it IMO | 16:03 |
| JayF | from my perspective, I'd say the node is deleted as soon as I can't access and use it anymore | 16:03 |
| JayF | ==jroll exactly | 16:03 |
| jroll | I don't care how long it takes my data to be removed, as long as I know it will happen | 16:04 |
| JayF | how the data gets removed afterward is an implementation detail -- one we consider so minor that we didn't do it for several releases and still let people disable cleaning (once it lands) | 16:04 |
| NobodyCam | morning JayF and JoshNang :-p | 16:05 |
| JayF | morning | 16:05 |
| JoshNang | NobodyCam: good morning! | 16:05 |
| jlvillal | JoshNang: Does it just need a 'recheck'? https://review.openstack.org/#/c/161001/ | 16:05 |
| devananda | what if cleaning fails, and ironic somehow restarts the node and my data is all still there? | 16:05 |
| JayF | That's a bug in cleaning, and then what? The node is stuck in deleting(nova) and CLEANFAIL(ironic) forever? | 16:06 |
| jroll | jlvillal: ya | 16:06 |
| jlvillal | jroll: JoshNang: Okay I will do that. | 16:06 |
| jroll | devananda: if ironic can get a node to AVAILABLE without doing a clean, that's a huge security bug | 16:06 |
| jroll | like | 16:06 |
| jroll | that's no reason to keep the instance around | 16:07 |
| devananda | jroll: fair point | 16:07 |
| devananda | if cleaning is enabled, it has to be mandatory | 16:07 |
| JoshNang | jlvillal: yeah failed to fetch some stuff from the mirrors :/ | 16:07 |
| devananda | though, ofc, i could go edit the DB and skip it ... | 16:07 |
| jroll | devananda: you could also take over the node and pxe boot it, and steal the data. | 16:07 |
| jlvillal | JoshNang: I thought it was a transient error. I did 'recheck' on the patch. | 16:07 |
| JayF | At which point we're not talking about what the code should or shouldn't do, we're talking about what operators should or shouldn't do | 16:07 |
| JayF | heh | 16:07 |
| JoshNang | jlvillal: it is, i was just making sure it wasn't a real bug :) | 16:08 |
| * rameshg87 calls it for the day | 16:08 | |
| rameshg87 | good night folks | 16:08 |
| jroll | have a good weekend rameshg87 :) | 16:08 |
| JayF | night | 16:08 |
| NobodyCam | night rameshg87 | 16:08 |
| JoshNang | rameshg87: o/ | 16:08 |
| JoshNang | rameshg87: and thanks for the reviews last night | 16:08 |
| jlvillal | rameshg87: Ciao! | 16:08 |
| *** rameshg87 has quit IRC | 16:08 | |
| devananda | JayF: yea... right. so. | 16:08 |
| devananda | Nova thinks the node is deleted once it leaves ACTIVE, right? | 16:09 |
| devananda | (that doesn't seem right either) | 16:10 |
| jroll | I think this conversation is going to end with a larger patch to nova. | 16:10 |
| devananda | heh | 16:10 |
| devananda | sorry | 16:10 |
| jroll | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L248 | 16:10 |
| victor_lowther | Good morning/afternoon/evening, Ironic. | 16:11 |
| jroll | that needs to change to: if node.provision_state != AVAILABLE | 16:11 |
| jroll | not just for cleaning but for e.g. MANAGEABLE | 16:11 |
| *** Nisha has quit IRC | 16:11 | |
| *** Nisha has joined #openstack-ironic | 16:11 | |
| jroll | devananda: JoshNang: ^ | 16:11 |
| JoshNang | jroll: we need a bunch more here then? https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L198 | 16:13 |
| jroll | JoshNang: that's power state | 16:13 |
| jroll | JoshNang: that method makes the node appear as having zero resources at all | 16:13 |
| jroll | JoshNang: what I pointed to makes the node appear as having resources that are taken | 16:13 |
| devananda | the change should go here https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L191 | 16:13 |
| jroll | so actually maybe you're right | 16:13 |
| JoshNang | ahh | 16:14 |
| devananda | JoshNang: yea, what you linked | 16:14 |
| *** ramineni has quit IRC | 16:14 | |
| jroll | either way, accomplishes roughly the same thing | 16:14 |
| jlvillal | victor_lowther: Good morning. | 16:14 |
| *** ramineni has joined #openstack-ironic | 16:14 | |
| jroll | a node in a cleaning state should probably show as all resources in use, *technically* | 16:15 |
| *** rwsu-afk is now known as rwsu | 16:15 | |
| JoshNang | but a node in manageable should show no reasources? | 16:15 |
| jroll | if I'm looking at capacity in my fleet, I'd like to see those as present but in use | 16:15 |
| jroll | correct | 16:15 |
| jroll | (imho) | 16:15 |
| JoshNang | seems reasonable | 16:15 |
| JoshNang | i can add this to my patch? or a separate one? | 16:15 |
| jroll | (just thought of the capacity thing, I guess that's the only difference) | 16:16 |
| jroll | whichever you think will get through nova faster :) | 16:16 |
| devananda | yes | 16:16 |
| * jroll wonders if we should write this down before making the patch | 16:17 | |
| NobodyCam | anyone have an open eye for https://review.openstack.org/#/c/161066/ ... 2 +2's | 16:17 |
| devananda | jroll: ++ | 16:17 |
| JoshNang | jroll: ++ | 16:17 |
| NobodyCam | oh an looks like dependent patch is approved | 16:17 |
| jroll | though I thought about writing it down and it ended up sounding like code | 16:18 |
| JoshNang | jroll: split it into two functions, _node_resources_unavailable and _node_resources_used, split up the states as unavailable vs used? | 16:19 |
| jroll | JoshNang: yeah, break out the if node.instance_uuid into a method | 16:19 |
| JoshNang | right | 16:20 |
| NobodyCam | bbt...brb | 16:20 |
| jroll | maybe even constants for the list of states | 16:20 |
| jroll | JoshNang: let's put those constants in an etherpad and all look at them | 16:20 |
| JoshNang | jroll: https://etherpad.openstack.org/p/KRcZ9LlgSd | 16:20 |
| *** vdrok is now known as vdrok_afk | 16:21 | |
| jroll | JoshNang: zapping is a state yeah? | 16:22 |
| jroll | nevermind | 16:22 |
| jroll | :P | 16:22 |
| JoshNang | heh | 16:22 |
| jroll | devananda: ^^ | 16:22 |
| jroll | JoshNang: I think that's good, curious what devananda thinks | 16:28 |
| JoshNang | jroll: that looks pretty good (assuming you're the mustard one) | 16:28 |
| *** jmccrory has joined #openstack-ironic | 16:29 | |
| jroll | ya | 16:29 |
| jroll | mustard, lol | 16:29 |
| JoshNang | heh :) | 16:30 |
| jroll | NobodyCam: BadCub: google docs is back | 16:31 |
| devananda | jroll: one issue, updated | 16:32 |
| jroll | oh right | 16:32 |
| jroll | that was obvious :) | 16:32 |
| BadCub | jroll: yep! I have been putting some new notes on it | 16:32 |
| JoshNang | does rebuild go in here? | 16:33 |
| jroll | so this seems large enough to be a separate patch (and maybe bug?) | 16:33 |
| jroll | I think nova will understand | 16:33 |
| * BadCub needs to grab a quick breakfast | 16:33 | |
| NobodyCam | woo hoo | 16:33 |
| jroll | JoshNang: rebuild just runs through deploying afaik | 16:33 |
| jroll | BadCub: grab a bagel for NobodyCam | 16:33 |
| NobodyCam | :) | 16:34 |
| * NobodyCam already has req for bagel in | 16:34 | |
| jroll | lol | 16:34 |
| NobodyCam | :-p | 16:34 |
| jroll | dang, now I want a bagel | 16:34 |
| JoshNang | jroll: i'm fine with separate patch | 16:34 |
| jroll | JoshNang: or you could land the existing one and then file a critical bug about deploying to nodes in cleaning :P | 16:35 |
| jlvillal | Has there ever been thought to use the httplib library for HTTP response codes? Instead of putting 404, use httplib.NOT_FOUND | 16:36 |
| jroll | (I'm kidding, don't do that) | 16:36 |
| JoshNang | >:) | 16:36 |
| jroll | jlvillal: when the RFC for status codes starts changing, I might care about doing that :P | 16:36 |
| jroll | jlvillal: that said, idk if there's been thoughts on it | 16:36 |
| JayF | http2 is a thing now. | 16:37 |
| jlvillal | jroll: To me it then becomes blatantly obvious in the code that is an HTTP response. Where a bare number is somewhat less obvious. | 16:37 |
| jroll | jlvillal: yeah, I guess | 16:37 |
| jroll | JayF: does it change status codes though? | 16:37 |
| JayF | idk | 16:37 |
| jroll | kinda doubt it | 16:38 |
| BadCub | https://review.openstack.org/#/c/161110 Microversion Spec looks good, has one +2 looking for some happiness! | 16:38 |
| victor_lowther | https://review.openstack.org/#/c/150488/ DRAC BIOS vendor passthru also looking for another +2 | 16:41 |
| NobodyCam | morning victor_lowther :) | 16:42 |
| NobodyCam | oh wow one of the first reviews i've seen with : Signed-off-by | 16:43 |
| NobodyCam | nice! | 16:43 |
| *** Marga_ has joined #openstack-ironic | 16:46 | |
| JoshNang | are we good with the nova patch then? (before i start poking nova folks) https://review.openstack.org/#/c/161474/ | 16:47 |
| JoshNang | and a separate patch for the states bugs | 16:47 |
| jroll | JoshNang: yeah, but I would want the existing one on top of the states patch | 16:47 |
| JoshNang | jroll: gotcha | 16:48 |
| NobodyCam | victor_lowther: looking at bios.py now.. I would like to see :param and :returns added to many of the functions, would you like me to tag the review? | 16:48 |
| jroll | JoshNang: because that patch is broken without it | 16:48 |
| JoshNang | right | 16:48 |
| * JoshNang writes | 16:48 | |
| JoshNang | (unless anyone else wants the pleasure) | 16:49 |
| victor_lowther | NobodyCam: Depends on the functions. :) | 16:49 |
| jlvillal | NobodyCam: I was told not to use Signed-Off-By on my first patch. | 16:49 |
| jroll | you just volunteered :P | 16:49 |
| jlvillal | victor_lowther: FYI: The first time I used Signed-Off-By I was told not to use it in OpenStack code. | 16:50 |
| NobodyCam | victor_lowther: parse_integer(item, ns) / _val_or_nil | 16:50 |
| jroll | someone is a ruby dev | 16:50 |
| jroll | :P | 16:50 |
| victor_lowther | jroll: That, and go, but the idioms I use in go don't really translate into python | 16:51 |
| jroll | victor_lowther: yeah, twas a joke | 16:51 |
| jroll | that reminds me... | 16:51 |
| JayF | you can never stop writing ruby, you can only try | 16:51 |
| jroll | devananda: for Liberty, rescue mode. how do you feel about it relying on go code in the ramdisk? | 16:52 |
| victor_lowther | NobodyCam: ah, those. They are not really supposed to be consumed seperately | 16:52 |
| victor_lowther | they only exist pecause pep8 bitched about the main wsman decoding function being too long. | 16:52 |
| jroll | devananda: e.g. https://github.com/rackerlabs/onmetal-rescue-agent | 16:52 |
| victor_lowther | jroll: and I got my nif from the proper source. | 16:53 |
| victor_lowther | Lisp. | 16:53 |
| *** absubram has joined #openstack-ironic | 16:53 | |
| victor_lowther | erm nil. | 16:53 |
| jroll | victor_lowther: aha, I see | 16:53 |
| NobodyCam | victor_lowther: my comment was because I found my self diging thru the file to figure out was ns and item where | 16:54 |
| NobodyCam | would be help (imo) to have them stated in doc string | 16:55 |
| victor_lowther | ns == xml namespace | 16:55 |
| NobodyCam | ya I fiund on line 215 | 16:56 |
| NobodyCam | found even | 16:56 |
| victor_lowther | gotta have it because SOAP and WSMAN live their namespaces | 16:56 |
| victor_lowther | er, love. | 16:56 |
| victor_lowther | Unnaturally. | 16:56 |
| *** harlowja has joined #openstack-ironic | 16:57 | |
| NobodyCam | lol, my thought was a doc string would save folks from having to search the code | 16:57 |
| victor_lowther | eh. If they are already reading the file it is too late for their sanity. :) | 16:58 |
| JoshNang | i'm just gonna forklift all the new states and changed docstrings from our states.py (minus the fsm stuff ofc) | 17:00 |
| NobodyCam | victor_lowther: but doc strings are converted to docs? i.e. http://docs.openstack.org/developer/ironic/webapi/v1.html | 17:00 |
| victor_lowther | I know. That is why get_config has a huge and detailed one. | 17:01 |
| victor_lowther | All the parse_* stuff was originally in get_config, and it would have stayed there if pep8 had not complaned about too much complexity. | 17:03 |
| victor_lowther | But that is just history. | 17:03 |
| victor_lowther | I can add extra doc strings. | 17:04 |
| lucasagomes | jroll, https://review.openstack.org/#/c/163344/ when u get some time | 17:04 |
| lucasagomes | (that's the pxe_ipa building from source on project-config) | 17:04 |
| *** gridinv_ has joined #openstack-ironic | 17:04 | |
| * jroll reviews | 17:05 | |
| *** ifarkas has quit IRC | 17:10 | |
| devananda | jroll: re: go, so we already use coreos in the ramdisk. which isn't used elsewhere in openstack | 17:14 |
| jroll | devananda: this would be go code that we wrote | 17:15 |
| jroll | but yeah. | 17:15 |
| devananda | jroll: on the one hand, as long as things are modular and could be re-implemented in something else (without changing the API) then its probably ok | 17:15 |
| devananda | jroll: on the other hand, think about this -- the rest of the ironic community needs to be able to review / test / maintain / fix bugs in it | 17:15 |
| jroll | devananda: indeed, it's really simple | 17:15 |
| jroll | right | 17:16 |
| JoshNang | fwiw we tried implementing this in IPA first, it uses the same apis | 17:16 |
| devananda | jroll: so by adding go, you're asserting that the rest of us learn how to maintain it | 17:16 |
| jroll | time for ironic to learn something other than python :) | 17:16 |
| jroll | I kid | 17:16 |
| devananda | heh | 17:16 |
| lucasagomes | as long as it's not js | 17:16 |
| lucasagomes | jk | 17:16 |
| lucasagomes | heh python ftw | 17:16 |
| devananda | not having to learn coreos is one reason i want the DIB IPA ramdisk to be viable | 17:16 |
| jroll | it really just does a lookup | 17:16 |
| jroll | https://github.com/rackerlabs/onmetal-rescue-agent/blob/master/agent.go | 17:16 |
| devananda | there are folks for whom that does and will matter downstream to us | 17:17 |
| * lucasagomes remembers once he read a tutorial on js arrays, nothing made sense to me | 17:17 | |
| jroll | devananda: all you need to learn is systemd | 17:17 |
| jroll | but | 17:17 |
| jroll | sure | 17:17 |
| devananda | jroll: sure. not saying coreos is bad or should go away. but $options. | 17:17 |
| jroll | yeah, options are cool | 17:17 |
| devananda | it's also just a tool to build the image with | 17:17 |
| jroll | though I tend to think duplicated work is not | 17:17 |
| jroll | s/build/run/ | 17:17 |
| devananda | right. | 17:18 |
| *** pelix has quit IRC | 17:18 | |
| devananda | anyway. i'm -0 on using go in the ramdisk, fwiw | 17:18 |
| jroll | ok | 17:18 |
| devananda | mostly because I wont be able to review it meaningfully | 17:18 |
| jroll | it can be easily ported to python | 17:19 |
| lucasagomes | jroll, +1 | 17:19 |
| jroll | but then it needs to run in a container to run on coreos | 17:19 |
| jroll | which is part of what we were avoiding | 17:19 |
| lucasagomes | also having go just increase the ramdisk size | 17:19 |
| devananda | if it's a thing that IPA calls (eg, lik eit calls out to megacli or what ever for RAID building) then I'm +1 | 17:19 |
| jroll | the other part being avoiding customers having access to IPA | 17:19 |
| JayF | lucasagomes: go doesn't work that way | 17:19 |
| devananda | and you should put that tool in a separate repo | 17:19 |
| JayF | lucasagomes: go produces a mostly-static binary | 17:19 |
| JayF | lucasagomes: which is exactly why we chose it, so it didn't need any userspace support in the image :) | 17:20 |
| jroll | devananda: it's just another ramdisk (tm) | 17:20 |
| lucasagomes | JayF, right, yeah if we can compile | 17:20 |
| devananda | JayF: build the tool, ship it, have IPA consume it | 17:20 |
| devananda | jroll: huh? | 17:20 |
| jroll | the point is not to have IPA accessible to the customer. | 17:20 |
| jroll | because presumably there's proprietary vendor tools in it. | 17:20 |
| *** pas-ha has quit IRC | 17:20 | |
| jroll | (which sucks, but that's a completely different topic) | 17:21 |
| devananda | oooh | 17:21 |
| lucasagomes | jroll, but IPA is modular right? we could build IPA with only 1 module (rescue) | 17:21 |
| lucasagomes | nothing else | 17:21 |
| devananda | jroll: to rephrase, "for liberty rescue mode, how do I feel about using a completely separate ramdisk that is not IPA?" | 17:21 |
| devananda | is ^ accurate? | 17:21 |
| devananda | jroll: I'd be fine with that | 17:21 |
| jroll | devananda: to rephrase: "how upstreamable is our current rescue mode implementation" :P | 17:21 |
| jroll | yeah, ok | 17:21 |
| devananda | jroll: haha well that requires me to go review it | 17:21 |
| devananda | jroll: which I'm not going to do until after kilo RC | 17:22 |
| jroll | right | 17:22 |
| jroll | I guess the question was, is go a non-starter. | 17:22 |
| jroll | it sounds like the answer is almost | 17:22 |
| devananda | jroll: go is a tool. it's the architecture I care about | 17:22 |
| jroll | right, but I like lucasagomes' idea | 17:22 |
| jroll | build a second ramdisk without secrets | 17:23 |
| devananda | yup | 17:23 |
| devananda | the rescue ramdisk should not be the same ramdisk as deploy / clean / etc | 17:23 |
| jroll | although... | 17:23 |
| jroll | hrm. | 17:23 |
| BadCub | devananda: popped you a couple questions in PM | 17:23 |
| devananda | I think I just assumed that | 17:23 |
| devananda | https://review.openstack.org/#/c/161861/ could use eyes from non-HP cores. jroll, I think you're already familiar with it, mind giving it a review? | 17:28 |
| jroll | ya, one minute | 17:28 |
| devananda | ta | 17:29 |
| *** jistr has quit IRC | 17:31 | |
| *** ramineni has quit IRC | 17:32 | |
| devananda | JayF: interesting failyure on https://review.openstack.org/#/c/161001/6 | 17:32 |
| devananda | I just rechecked -- just pointing it out. i haven't seen that before | 17:32 |
| JayF | looks like rackspace mirrors were broken | 17:32 |
| devananda | JayF: it's installing xen things in the agent_ssh-src job | 17:32 |
| devananda | k | 17:33 |
| *** achanda has joined #openstack-ironic | 17:33 | |
| JayF | that's just doing security updates, the xen stuff already exists in the image apparently | 17:33 |
| JayF | which might be another good candidate to purge and shave another meg off the image | 17:33 |
| devananda | ahh. right | 17:33 |
| devananda | JoshNang: what happens if we land all the cleaning stuff, but nova doesn't accept https://review.openstack.org/#/c/161474/5 ? | 17:34 |
| NobodyCam | lol 161001 has been in recheck queue for about an hour and a half | 17:35 |
| JayF | We file a critical bug against nova for deletes taking hours and get them to merge it anyway? lol | 17:35 |
| JoshNang | ^ or we remove the config option and unconditionally skip cleaning | 17:35 |
| *** gridinv_ has quit IRC | 17:36 | |
| devananda | oh yah. expect the gate to get REALLY LONG | 17:39 |
| devananda | cause, you know, everyone's trying to cram features in | 17:39 |
| devananda | JoshNang: yah. we'll have to consider the possibility of disabling the feature and saying "not supported by Nova in Kilo" | 17:40 |
| NobodyCam | dmitry out on pto? correct? | 17:40 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add missing exceptions to destroy_node docstrings https://review.openstack.org/164279 | 17:40 |
| devananda | NobodyCam: don't know. I've seen reviews by him this week, I thought | 17:40 |
| *** Marga_ has quit IRC | 17:40 | |
| JoshNang | devananda: that's reaonable | 17:40 |
| JoshNang | reasonable, even | 17:41 |
| *** Marga_ has joined #openstack-ironic | 17:41 | |
| devananda | woot - whle disk image support is done | 17:41 |
| jroll | devananda: +A'd that destory_port thing with a followup | 17:41 |
| NobodyCam | I don't see in channel, but $timeZones ... I'm going to rebase 161132 | 17:41 |
| jroll | devananda: wow | 17:41 |
| devananda | local boot looks almost done too -- https://review.openstack.org/#/c/159855/ | 17:42 |
| devananda | is the only one left | 17:42 |
| devananda | jroll: cheers | 17:42 |
| devananda | jroll: approved the doc change | 17:43 |
| jroll | devananda: I added a test and dealt with nits on this, are you ok with +2 https://review.openstack.org/#/c/155561/ | 17:43 |
| jroll | are you ok with me giving it a +2* | 17:43 |
| jroll | nice | 17:43 |
| devananda | jroll: I haven't actually read the whole thing yet >_< | 17:43 |
| devananda | jroll: oh. you giving it a +2. sure | 17:44 |
| jroll | devananda: I was +2 other than the missing test I added. I also fixed nits. ok for me to... yeah | 17:44 |
| jroll | thanks | 17:44 |
| *** derekh has quit IRC | 17:45 | |
| *** ChuckC has quit IRC | 17:45 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Start using in-band inspection https://review.openstack.org/161132 | 17:46 |
| NobodyCam | rebased ^^^^ | 17:46 |
| *** Marga_ has quit IRC | 17:46 | |
| BadCub | brb | 17:48 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 17:49 |
| devananda | anyone here used discoverd for in-band discovery? | 17:49 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 17:50 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 17:51 |
| devananda | NobodyCam: it's disabled by default right now. I believe that's the right course of action, becaues discoverd, last I talked with dtantsur, has no functional testing in its gate | 17:51 |
| devananda | and ew aren't testing it in ours | 17:51 |
| devananda | so I think that feature should be considered experimental at this point | 17:51 |
| devananda | that said, hooking up the plumbing for those drivers that want it is fine -- but it shouldn't be displayed | 17:51 |
| devananda | if it's disabled | 17:51 |
| *** stendulker has joined #openstack-ironic | 17:52 | |
| lucasagomes | folks I will call it a day | 17:52 |
| lucasagomes | have a good night everyone! Enjoy the weekend | 17:52 |
| devananda | lucasagomes: cheers, have a good weekend! | 17:53 |
| devananda | ooh. nice, I'm glad to see this output | 17:53 |
| devananda | | inspect | False | ironic-discoverd support is disabled in configuration, set [discoverd]enabled to true to enable | | 17:53 |
| *** lucasagomes is now known as lucas-dinner | 17:54 | |
| *** dprince has quit IRC | 17:56 | |
| NobodyCam | have a good weekend lucas-dinner | 17:57 |
| *** omnibus7 is now known as davidlenwell | 17:57 | |
| *** Nisha has quit IRC | 17:57 | |
| *** Nisha has joined #openstack-ironic | 17:58 | |
| stendulker | NobodyCam: Hi | 17:59 |
| NobodyCam | hello there stendulker :) | 17:59 |
| stendulker | NobodyCam: Have addressed all your comments related to secure boot | 17:59 |
| NobodyCam | awesome #? | 18:00 |
| NobodyCam | lol | 18:00 |
| NobodyCam | sorry so many open windows | 18:00 |
| *** alexpilotti has joined #openstack-ironic | 18:00 | |
| stendulker | NobodyCam: Have merged all the changes of localboot and whole-disk images (latest) and validated all the drivers working with grub in uefi boot mode | 18:01 |
| *** alexpilotti has quit IRC | 18:01 | |
| stendulker | NobodyCam: Please have a look when you get some time. | 18:01 |
| jroll | JoshNang: https://review.openstack.org/#/c/161066/7/ironic_python_agent/extensions/clean.py | 18:02 |
| *** alexpilotti has joined #openstack-ironic | 18:02 | |
| jroll | JoshNang: should get_clean_steps be sync, not async? | 18:02 |
| JoshNang | jroll: ooo good catch | 18:03 |
| jroll | hehe | 18:03 |
| * jroll stops reviewing :P | 18:03 | |
| jroll | left a comment for you, I'll review the rest | 18:03 |
| jroll | JoshNang: also... | 18:04 |
| jroll | what's the return look like for that | 18:04 |
| jroll | I guess I can look at tests | 18:04 |
| jroll | but it seems weird | 18:04 |
| devananda | should an interface which is desabled report True or Fales from node-validate? | 18:04 |
| devananda | have we ever decided that before? | 18:04 |
| JoshNang | its like {'hardware_manager': [step1, step2]..} | 18:04 |
| jroll | oh right it should return a list of dicts | 18:05 |
| jroll | ok | 18:05 |
| JoshNang | a dict of lists of dicts | 18:05 |
| jroll | devananda: great question. because validation passes ya? | 18:05 |
| *** PaulCzar has joined #openstack-ironic | 18:05 | |
| devananda | if validate returns False for an interface, that means bad things, right? | 18:05 |
| devananda | but if the interface is disabled globally (ie, in ironic's config) then it's not bad | 18:06 |
| devananda | it's just turned off | 18:06 |
| jroll | JoshNang: should there be a test for get_clean_step() if the version doesn't match? (or is it not checked there) | 18:08 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 18:08 |
| JoshNang | jroll: it's not checked there | 18:08 |
| jroll | devananda: precedent: | console | False | IPMI terminal port not supplied to IPMI driver. | | 18:08 |
| jroll | oh that might be different | 18:08 |
| JoshNang | because it needs a baseline for clean steps, which it gets when calling get_clean_steps | 18:08 |
| devananda | jroll: yea, that's missing info | 18:09 |
| jroll | yeah, I guess that's not "disabling" per se | 18:09 |
| jroll | JoshNang: right, ok | 18:09 |
| openstackgerrit | Merged openstack/ironic: Add whole disk image support in iscsi_ilo driver https://review.openstack.org/163589 | 18:09 |
| jroll | JoshNang: does get_clean_steps get called every round of cleaning? what if version changes in the middle? | 18:09 |
| devananda | jroll: console | None | not supported | 18:09 |
| devananda | so ya. it should say None, not False | 18:09 |
| jroll | devananda: aha | 18:09 |
| JoshNang | jroll: it gets called at the start only. if it changes in the middle (it checks on every execute_clean_step), cleaning gets restarted | 18:09 |
| jroll | JoshNang: oh right. I suck. I meant should there be a test for execute_clean_step on version mismatch | 18:10 |
| jroll | and sounds like yes | 18:11 |
| JoshNang | lol oh. and yeah let me put that in there | 18:11 |
| jroll | cool | 18:11 |
| jroll | LGTM other than those things | 18:11 |
| jroll | JoshNang: and if you add Depends-On: $changeid | 18:11 |
| jroll | where changeid is the add zapping steps thing | 18:12 |
| jroll | add cleaning steps thing* | 18:12 |
| jroll | it'll get run in the gate, and that would be awesome to see | 18:12 |
| JoshNang | jroll: cleaning is disabled by default :/ | 18:12 |
| JoshNang | so it wouldn't run in the gate. | 18:12 |
| jroll | JoshNang: no it's not :) | 18:12 |
| jroll | I turned it on this morning after much debate | 18:13 |
| JoshNang | \o/ | 18:13 |
| JoshNang | i didn't get very far back into scrollback this morning | 18:13 |
| jroll | changeid is the long-form change id btw, I96af133c501f86a6e620c4684ee65abad2111f7b | 18:13 |
| JoshNang | gotcha. i gotta change a couple things since this is sync and add that test. should be up shortly | 18:14 |
| NobodyCam | anyone else want to lok at https://review.openstack.org/#/c/159855 before I approve, lucas had a +1 befor rebase? | 18:14 |
| jroll | word | 18:14 |
| jroll | NobodyCam: it was next on my list, I'll give it a quick look | 18:14 |
| NobodyCam | ack +2'ing please +a if it passed the mustard | 18:15 |
| NobodyCam | s/passed/passes/ | 18:15 |
| jroll | heh | 18:15 |
| devananda | so yah. i dont see a neat way to do this yet | 18:17 |
| devananda | inspect interface needs to be unset if discoverd is disabled | 18:17 |
| devananda | but it's not | 18:17 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 18:17 |
| *** tiagogomes_ has quit IRC | 18:18 | |
| devananda | self.inspect = discoverd.DiscoverdInspect() | 18:20 |
| devananda | + if not CONF.discoverd.enabled: | 18:20 |
| devananda | + del(self.inspect) | 18:20 |
| devananda | one way is ^ in every driver base class that uses it | 18:20 |
| devananda | but that's gross | 18:20 |
| * devananda proposes it anyway | 18:21 | |
| jroll | NobodyCam: +A'd | 18:21 |
| jroll | devananda: if CONF.discoverd.enabled: self.inspect = discoverd.DiscoverdInspect() | 18:22 |
| jroll | wouldn't work? | 18:22 |
| devananda | oh. duh | 18:22 |
| devananda | maybe | 18:22 |
| devananda | i mean, less gross. | 18:22 |
| BadCub | jroll: thnx :-) | 18:22 |
| jroll | right :P | 18:22 |
| jroll | BadCub: what's next on the list? :P | 18:23 |
| BadCub | 155561 was being discussed earlier. | 18:24 |
| openstackgerrit | Merged openstack/ironic: ironic port deletion fails even if node is locked by same process https://review.openstack.org/161861 | 18:25 |
| jroll | BadCub: yeah, I reviewed that | 18:25 |
| * jroll looks at some lists | 18:25 | |
| jroll | BadCub: looking in general for which topics are priority | 18:26 |
| *** MattMan has quit IRC | 18:28 | |
| NobodyCam | anyone know anthing about 163738 | 18:28 |
| NobodyCam | naotokl: ^^^^ ???? | 18:28 |
| *** Marga_ has joined #openstack-ironic | 18:29 | |
| BadCub | NobodyCam: 163738 is the only stopper left on the corresponding BP, I think | 18:29 |
| jroll | it's marked WIP :/ | 18:30 |
| *** stendulker has quit IRC | 18:30 | |
| NobodyCam | jroll: ya just wish we had a comment as to why | 18:32 |
| NobodyCam | :-p | 18:32 |
| jroll | ikr | 18:32 |
| BadCub | https://review.openstack.org/#/c/142178/ looks like it could use a look | 18:32 |
| NobodyCam | w00 h00 gate is up to like 4 hours for check queue! | 18:32 |
| jlvillal | Nisha: I just commented on https://review.openstack.org/#/c/151596/31/ironic/drivers/modules/ilo/inspect.py Hopefully I explained about split and 'if' block. | 18:33 |
| * devananda is fixing discoverd | 18:33 | |
| devananda | https://bugs.launchpad.net/ironic/+bug/1431999 | 18:33 |
| openstack | Launchpad bug 1431999 in Ironic "discoverd incorrectly reports False from validate when disabled" [High,Triaged] - Assigned to Devananda van der Veen (devananda) | 18:33 |
| BadCub | yeah, 163794 & 163857 appear to be in test pergatory | 18:33 |
| Nisha | jlvillal, yeah. | 18:37 |
| Nisha | got it | 18:37 |
| jlvillal | Nisha: Cool. | 18:37 |
| devananda | wow. mem error during pyton setup.py | 18:39 |
| NobodyCam | hey there Nisha :) | 18:40 |
| Nisha | NobodyCam, yes | 18:40 |
| NobodyCam | just saying hi | 18:41 |
| NobodyCam | :) | 18:41 |
| Nisha | NobodyCam, hi | 18:41 |
| devananda | neat. does it agan | 18:41 |
| NobodyCam | devananda: mamory going bad? | 18:41 |
| devananda | no | 18:41 |
| devananda | bug | 18:41 |
| jroll | devananda: locally or? | 18:41 |
| NobodyCam | :( | 18:41 |
| devananda | looks like infinite recursion somewhere during setup | 18:41 |
| devananda | i dont really want to dig in | 18:42 |
| jroll | devananda: on your patch or? | 18:42 |
| * jroll lunches | 18:43 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-python-agent: Add cleaning/zapping support to IPA https://review.openstack.org/161066 | 18:43 |
| * devananda rebuilds venv | 18:43 | |
| jroll | JoshNang: already in merge conflict LOL | 18:44 |
| JoshNang | jroll: womp. | 18:44 |
| jroll | heh | 18:44 |
| jlvillal | JoshNang: Do you need to rebase that patch? Gerrit says patch in merge conflict | 18:44 |
| * jroll looks up four lines | 18:44 | |
| jlvillal | JoshNang: But Gerrit gives very little details on what that message means. | 18:44 |
| jroll | jlvillal: that's what it means, yes | 18:45 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement cleaning/zapping for the agent driver https://review.openstack.org/161453 | 18:45 |
| * jroll really steps away now | 18:45 | |
| *** ijw has joined #openstack-ironic | 18:45 | |
| jlvillal | jroll: Thanks. And now I see where you said same thing :) | 18:45 |
| JoshNang | yay rebase button. blah should have cherry-picked in the first place | 18:45 |
| *** athomas has quit IRC | 18:45 | |
| NobodyCam | JoshNang: you use the rebase button? | 18:46 |
| NobodyCam | I always pull down and rebase | 18:46 |
| NobodyCam | :-p | 18:46 |
| JoshNang | NobodyCam: very occasionally | 18:46 |
| JoshNang | usually git review -d the parent patch, cherry pick and then i don't have to worry abou tit | 18:47 |
| jlvillal | JoshNang: I usually do 'git pull --rebase' | 18:47 |
| jlvillal | JoshNang: I haven't tried 'git review' Maybe I should :) | 18:47 |
| devananda | so general word of advice -- if you dont have to rebase a patch, please don't | 18:47 |
| devananda | it makes it harder to see the difference between revisions of the patch | 18:47 |
| devananda | and if you need to make changes to address review comments AND rebase the patch, plesae do that in different revs | 18:48 |
| * devananda thnks ^ should be in our dev ref guide | 18:48 | |
| jlvillal | devananda: Makes sense. Thanks. | 18:48 |
| *** andreykurilin_ has joined #openstack-ironic | 18:49 | |
| *** ndipanoff has quit IRC | 18:55 | |
| NobodyCam | brb | 18:57 |
| *** dprince has joined #openstack-ironic | 19:01 | |
| devananda | correct me if I'm wrong folks -- doesn't all the RAID config stuff depend on zapping, because without that, there's no API to drive RAID configuration? | 19:17 |
| devananda | JayF JoshNang ^ | 19:17 |
| JoshNang | devananda: as i understood it, yeah | 19:18 |
| * NobodyCam is back ... | 19:18 | |
| devananda | JoshNang: thought so. /me bumps on LP | 19:20 |
| JoshNang | devananda: jroll: nova patch for using the new states in the resource tracker https://review.openstack.org/164313 | 19:21 |
| JoshNang | and the nova cleaning patch is now dependent on that. | 19:22 |
| * JoshNang grabs lunch | 19:23 | |
| *** mgoddard1 has joined #openstack-ironic | 19:24 | |
| *** thiagop has quit IRC | 19:25 | |
| *** mgoddard has quit IRC | 19:26 | |
| JayF | JoshNang: do you want a bug or blueprint on that? | 19:27 |
| JayF | JoshNang: seems like you probably want a bug at minimum or to tag it with the state machine bp | 19:27 |
| devananda | JoshNang: I'm going to set those to the 'ironic-driver' topic | 19:28 |
| devananda | JoshNang: oh wait. i can't. could you (when yuou get back)? | 19:28 |
| *** mgoddard1 has quit IRC | 19:28 | |
| * BadCub needs to go move the house out of the driveway of the house for delivery folks | 19:29 | |
| NobodyCam | victor_lowther: where you going to add the doc strings in that patch or follow up? (re: 150488) | 19:29 |
| NobodyCam | also microversion spec stil look'n for another +2 ( https://review.openstack.org/#/c/161110 ) | 19:31 |
| devananda | NobodyCam: yah I need to re-read it | 19:31 |
| JoshNang | JayF: devananda will do | 19:32 |
| JoshNang | do blueprints work across projects? | 19:32 |
| devananda | bug for tracking it in nova | 19:32 |
| *** hemna has quit IRC | 19:32 | |
| JoshNang | wfm | 19:32 |
| devananda | JoshNang: not so well | 19:32 |
| devananda | bugs work across projects, bp do not | 19:32 |
| JoshNang | gotcha. thanks! | 19:33 |
| devananda | on the discoverd patch, I'd ask dmitry but he's on PT | 19:33 |
| devananda | I have a fix for https://bugs.launchpad.net/ironic/+bug/1431999 -- I can do it on top of dmitry's patch (meaning we land the bug then immediately fix it) | 19:35 |
| openstack | Launchpad bug 1431999 in Ironic "discoverd incorrectly reports False from validate when disabled" [High,Triaged] - Assigned to Devananda van der Veen (devananda) | 19:35 |
| devananda | or I can clobber his patch, meaning we mostly avoid the bug, since it wont actually get turned on in trunk | 19:35 |
| devananda | anyone care which way I do it? | 19:35 |
| JayF | I mean, one less patch to have to fly through the gate seems like the more prudent path | 19:36 |
| JayF | imo | 19:37 |
| devananda | *nod* | 19:37 |
| *** mgoddard has joined #openstack-ironic | 19:38 | |
| NobodyCam | :) sweeping pine needles in the wind is like trying to push a rain drop back up into the cloud! | 19:44 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Start using in-band inspection https://review.openstack.org/161132 | 19:51 |
| *** hemna has joined #openstack-ironic | 19:52 | |
| devananda | NobodyCam: ^ | 19:52 |
| NobodyCam | devananda: ack will look in a few ... looking at root hint patches now? | 19:53 |
| NobodyCam | s/?/./ | 19:53 |
| NobodyCam | :) | 19:53 |
| *** lucas-dinner has quit IRC | 19:54 | |
| *** achanda has quit IRC | 20:06 | |
| openstackgerrit | Merged openstack/ironic: Add localboot support for uefi boot mode https://review.openstack.org/159855 | 20:09 |
| *** achanda has joined #openstack-ironic | 20:11 | |
| *** Nisha has quit IRC | 20:11 | |
| *** Nisha has joined #openstack-ironic | 20:11 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Write documentation for hardware inspection https://review.openstack.org/161775 | 20:12 |
| * devananda goes to read the api microversion spec | 20:13 | |
| BadCub | could I get some love for https://review.openstack.org/#/c/163857/ & https://review.openstack.org/#/c/163794/? | 20:16 |
| *** achanda has quit IRC | 20:25 | |
| NobodyCam | gah check queue now over 4 hours | 20:27 |
| devananda | NobodyCam: -1'd the api miroversoin spec. since mrda-weekend is probably not working for a few days, perhaps we should just fix it and approve | 20:32 |
| devananda | NobodyCam: you want to follow up or shall I? | 20:32 |
| devananda | also, i need to fix something in the API itself, which I should have fixed a month ago | 20:32 |
| * NobodyCam looks for devananda's comment | 20:33 | |
| *** alexpilotti has quit IRC | 20:37 | |
| devananda | we dont actually have the same API as stable/juno right now | 20:42 |
| devananda | about a week after juno was cut, we landed maintenance_reason | 20:42 |
| devananda | and then we landed micro versions a few months after that | 20:42 |
| devananda | with no api changes between | 20:42 |
| JayF | so maintenance_reason needs to support microversions? | 20:42 |
| devananda | if we want to claim that someone sending a request header of version == 1.0 will actually get the same API as stable/juno | 20:43 |
| devananda | then yes | 20:43 |
| devananda | looked at from another angle, the question is really about: when we extend the functionality if our API, do we need to bump the microversion? | 20:44 |
| devananda | or do we only bump when there is something that changes existing behavior? | 20:44 |
| devananda | so far, we seem to all be going with the former answer | 20:44 |
| devananda | JayF: you should read the api microversion spec tho | 20:44 |
| BadCub | brb | 20:56 |
| *** achanda has joined #openstack-ironic | 20:57 | |
| *** kkoski has quit IRC | 20:58 | |
| *** harlowja has quit IRC | 21:00 | |
| devananda | I mean, we added a new endpoint: /v1/nodes/NNNN/maintenance | 21:03 |
| devananda | if we did that today, wouldn't we put a microversion around it? | 21:03 |
| jroll | so | 21:03 |
| jroll | is it really a rush to approve that spec | 21:03 |
| jroll | I thought it was an FYI sorta thing | 21:03 |
| devananda | true | 21:03 |
| jroll | and we decided 1.0 wouldn't be juno equiv already. | 21:04 |
| devananda | jroll: you mean 1.1 | 21:04 |
| JayF | devananda: put some comments on that microversion spec | 21:04 |
| JayF | the "kilo is 1.1, juno is 1.0" stuff seems confusing | 21:04 |
| jroll | devananda: I'm not sure without looking things up. | 21:04 |
| jroll | I thought 1.1 was NOSTATE -> AVAILABLE | 21:04 |
| devananda | re: the spec, yes informational, not rushed for next week, but we hould sort it before RC1 | 21:04 |
| devananda | JayF: exactly | 21:05 |
| jroll | who has a link handy? | 21:05 |
| devananda | if we are promising that curent server can support same API as juno/stable, we need to fix the current api before RC | 21:05 |
| devananda | that's my point | 21:05 |
| JayF | https://review.openstack.org/#/c/161110 | 21:05 |
| JayF | jroll: ^ | 21:05 |
| jroll | we shouldn't promise that, it would be tons of work :x | 21:05 |
| NobodyCam | devananda: all reffs to v1.1 should be v1(.0) in the microversion spec | 21:05 |
| jroll | it wasn't just maintenance reason | 21:05 |
| JayF | devananda: I'm +1000 to that after reading the spec | 21:05 |
| JayF | NobodyCam: That's what I was thinking, but got confused halfway through | 21:06 |
| *** harlowja has joined #openstack-ironic | 21:06 | |
| devananda | if we say that v1.0 == some random point in Kilo where we added microversions, then yes, the spec should s/1.1/1.0 | 21:06 |
| NobodyCam | I'm editing now | 21:06 |
| devananda | however I would rather say that v1.0 == stable/juno, and v1.1 == where we added microversions | 21:06 |
| JayF | if 1.0 and 1.1 behave no differently when a microversion header is not specified | 21:07 |
| devananda | AND i would like the server to actually provide the same semantics as stable/juno, but maybe that's just crazy talk | 21:07 |
| JayF | the difference is kinda arbitrary and confusing | 21:07 |
| devananda | JayF: yup. I'd like to actually lower it to v1.0 | 21:07 |
| devananda | so that "no header == v1.0" | 21:07 |
| JayF | Yeah, I agree | 21:07 |
| devananda | and 1.0 == stable/juno | 21:08 |
| devananda | jroll: what else was it? | 21:08 |
| devananda | jroll: I believe I've read the commit logs and didn't find anything else | 21:08 |
| JayF | The other major confusing thing is the idea we'd ever have a client/server combiation that couldn't negotiate a working API connection | 21:08 |
| devananda | and wrapping maintenance isn't tha tmuch work | 21:08 |
| jroll | devananda: I'm looking... when you did the first patch I swear that it was like 6 commits | 21:08 |
| JayF | because our API inherently always supports fallback to "/1.0" | 21:08 |
| devananda | JayF: seriously. that's a silly idea and we should never ever do that | 21:08 |
| JayF | and if the client always supports that, it's never a problem | 21:08 |
| JayF | you might have features you wanna use that just don't work | 21:09 |
| openstackgerrit | Merged openstack/ironic-python-agent: Add dispatch to all managers https://review.openstack.org/161001 | 21:09 |
| *** gridinv_ has joined #openstack-ironic | 21:09 | |
| jroll | devananda: hrm. not seeing it. | 21:10 |
| devananda | huh. so, i'm not seeing how to selectively disable or hide an API endpoint in wsme | 21:17 |
| jroll | devananda: couldn't you just 404 it if version is too low? | 21:18 |
| devananda | jroll: yes. but it's handled differently, and pecan/wsme returns that as a client error | 21:18 |
| jroll | wat | 21:19 |
| jroll | how is a 404 handled differently | 21:19 |
| devananda | jroll: http://paste.openstack.org/show/192189/ | 21:20 |
| jroll | rage | 21:20 |
| devananda | yah | 21:21 |
| devananda | also the second one generate this log entry | 21:21 |
| devananda | 2015-03-13 14:19:37.949 25931 WARNING wsme.api [-] Client-side error: The resource could not be found. | 21:21 |
| devananda | the former does not | 21:21 |
| jroll | I don't care so much about that | 21:21 |
| devananda | er, other way around, sorry | 21:21 |
| jroll | but it is different and that sucks | 21:21 |
| devananda | yes | 21:21 |
| devananda | raising a 404 from inside the controller != the controller not being three | 21:22 |
| devananda | there | 21:22 |
| *** andreykurilin_ has quit IRC | 21:23 | |
| *** andreykurilin_ has joined #openstack-ironic | 21:23 | |
| JayF | JoshNang: https://review.openstack.org/#/c/161066/ (cleaning/zapping for IPA) is still V-1 because of merge conflict | 21:25 |
| JayF | :( | 21:25 |
| JoshNang | JayF: :( fixing now | 21:26 |
| JayF | okay awesome, then I can review | 21:26 |
| *** achanda has quit IRC | 21:27 | |
| *** mjturek1 has quit IRC | 21:30 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-python-agent: Add cleaning/zapping support to IPA https://review.openstack.org/161066 | 21:30 |
| NobodyCam | anyone have the command to build a spec file locally? | 21:31 |
| NobodyCam | need to test rendered formating | 21:31 |
| JoshNang | JayF: ^ i'm not sure why it was in merge conflict tbh. | 21:31 |
| JayF | it still is | 21:31 |
| JoshNang | grr one sec | 21:31 |
| JayF | JoshNang: a suggestion? | 21:31 |
| JayF | JoshNang: get a clean checkout of IPA master. Cherry-pick your commit into it. Push that as the change. | 21:32 |
| JoshNang | heh exactly what i di | 21:32 |
| JoshNang | *did | 21:32 |
| *** achanda has joined #openstack-ironic | 21:33 | |
| NobodyCam | doh .... tox | 21:34 |
| *** jgrimm_ has joined #openstack-ironic | 21:34 | |
| jroll | JoshNang: when it's in merge conflict I don't believe you can use the rebase button | 21:35 |
| jroll | if you can then magic | 21:35 |
| *** maurosr has quit IRC | 21:35 | |
| jroll | (but then why doesn't gerrit handle the merge conflicts) | 21:35 |
| NobodyCam | brb while that runs | 21:35 |
| *** jgrimm- has joined #openstack-ironic | 21:36 | |
| JayF | jroll: JoshNang: I wonder if the merge conflict checker job is running behind or something | 21:36 |
| JoshNang | jroll: i wasn't. "git fetch origin master; git checkout origin/master; git review -x $review; git review" | 21:36 |
| *** jgrimm has quit IRC | 21:36 | |
| jroll | oh idk, it should clear on upload... | 21:36 |
| *** maurosr has joined #openstack-ironic | 21:36 | |
| JoshNang | yeah :/ | 21:37 |
| jroll | OH | 21:37 |
| jroll | the change it depends on has a conflict | 21:37 |
| jroll | heh | 21:37 |
| JoshNang | OH ha | 21:37 |
| JayF | oh man, that's actually really confusing | 21:38 |
| JoshNang | heh that makes sense. first time using depends-on | 21:38 |
| JoshNang | yeah, that's a bit of a bad ui.. | 21:38 |
| * JoshNang fixes agent driver | 21:39 | |
| *** jgrimm_ has quit IRC | 21:39 | |
| *** ijw has quit IRC | 21:40 | |
| *** andreykurilin_ has quit IRC | 21:41 | |
| *** Nisha has quit IRC | 21:41 | |
| *** Nisha has joined #openstack-ironic | 21:41 | |
| *** andreykurilin_ has joined #openstack-ironic | 21:42 | |
| *** sambetts has quit IRC | 21:45 | |
| *** dprince has quit IRC | 21:46 | |
| *** sambetts has joined #openstack-ironic | 21:47 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 21:52 |
| JoshNang | jroll: if you get a sec, can you put your +2 back on that? destroy_port bumped the rpc version, caused merge conflicts | 21:53 |
| *** kozhukalov has quit IRC | 22:00 | |
| *** rwsu has quit IRC | 22:00 | |
| jroll | oh, right | 22:01 |
| jroll | JoshNang: done | 22:03 |
| JoshNang | jroll: thanks! | 22:03 |
| *** harlowja has quit IRC | 22:04 | |
| jroll | np | 22:04 |
| *** harlowja has joined #openstack-ironic | 22:06 | |
| *** harlowja has quit IRC | 22:06 | |
| *** harlowja has joined #openstack-ironic | 22:06 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 22:10 |
| *** Nisha_away has joined #openstack-ironic | 22:11 | |
| *** Nisha has quit IRC | 22:11 | |
| *** killer_prince has quit IRC | 22:11 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Add /nodes/<uuid>/cleaning/steps API https://review.openstack.org/159322 | 22:13 |
| *** Nisha_away is now known as Nisha | 22:13 | |
| *** killer_prince has joined #openstack-ironic | 22:14 | |
| *** killer_prince is now known as lazy_prince | 22:15 | |
| *** gridinv_ has quit IRC | 22:16 | |
| *** gridinv_ has joined #openstack-ironic | 22:17 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 22:17 |
| JoshNang | blah, commit message had the old api version :( | 22:17 |
| JayF | JoshNang: Related-bug: #1174153 | 22:18 |
| openstack | bug 1174153 in Ironic "data from previous tenants accessible with nova baremetal" [High,Triaged] https://launchpad.net/bugs/1174153 | 22:18 |
| JayF | IDK <3 | 22:18 |
| JayF | er, just meant the <3 | 22:18 |
| JayF | lol | 22:18 |
| JoshNang | deva added that. <3 | 22:18 |
| devananda | going to ask a terrible question - are we crazy for doing microversions at all? | 22:18 |
| JayF | A little bit, but moving slower is much more crazy | 22:18 |
| devananda | heh | 22:18 |
| devananda | i've just about got the "hide maintenance from v1.0" done | 22:19 |
| devananda | and realized how weird this looks in my logs | 22:19 |
| devananda | 127.0.0.1 - - [13/Mar/2015 15:16:03] "DELETE /v1/nodes/ccbb2d62-a5e0-463e-9eab-b33267bb99ce/maintenance HTTP/1.1" 404 186 | 22:19 |
| devananda | 127.0.0.1 - - [13/Mar/2015 15:16:15] "DELETE /v1/nodes/ccbb2d62-a5e0-463e-9eab-b33267bb99ce/maintenance HTTP/1.1" 202 0 | 22:19 |
| devananda | the only difference between those is the requested version header -- first request didn't specify one, second request did | 22:19 |
| JayF | We should perhaps alter the default logging configuration we ship with | 22:20 |
| devananda | it's the correct behavior according to the current spec. it's just ... odd | 22:20 |
| JayF | to also log the microversion header | 22:20 |
| devananda | ah | 22:20 |
| devananda | that would make it less odd, indeed | 22:20 |
| JayF | I know that's possible in apache, not sure if it's possible in our middleware | 22:20 |
| JayF | I agree that seems /very/ wrong | 22:20 |
| JayF | (the log messages) | 22:21 |
| *** gridinv_ has quit IRC | 22:21 | |
| devananda | JayF: just confirming - other than that, you find the behavior reasonable? | 22:21 |
| JayF | You aren't going to like my answer :) | 22:21 |
| JayF | it's reasonable for an API like Ironic, which is mostly used by a static set of things: Nova, py-ironicclient, maybe an ansible module | 22:22 |
| JayF | if this were a more customer-facing API, I'd think it's really complex | 22:22 |
| JayF | but given we generally control most clients to our api, the complexity is worth the value created | 22:22 |
| JayF | Honestly I'm just glad to know we're going to avoid the pain of a big real api version bump | 22:24 |
| jroll | I don't think we should ever say our client list is limited | 22:24 |
| JayF | and instead getting the pain in little bits as we add features and change the api | 22:24 |
| jroll | because it's only going to get less limited | 22:24 |
| JayF | I didn't say it's limited, I said in most cases we control the clients | 22:24 |
| jroll | there's already a node.js client to add to your list | 22:25 |
| devananda | JayF: I disagree. we can't asume that | 22:25 |
| devananda | jroll: oh there is? | 22:25 |
| jroll | yeah, we don't control the clients at all | 22:25 |
| jroll | devananda: it's crappy and not very featureful, and not open source | 22:25 |
| jroll | but yes | 22:25 |
| devananda | jroll is right -- we do not control the clients at all, and should never act like we do | 22:25 |
| devananda | krotscheck: ^ | 22:25 |
| jroll | :x | 22:26 |
| jroll | devananda: it literally does node-list and node-show | 22:26 |
| jroll | not much value to be had, and it isn't abstracted at all | 22:26 |
| jroll | but yes it exists | 22:26 |
| russell_h | I've got my own python client too if it makes you feel better | 22:26 |
| devananda | jroll: cool | 22:26 |
| devananda | russell_h: it does | 22:26 |
| russell_h | because pip was pissing me off | 22:26 |
| jroll | russell_h: and we have yet another in onmetal-scripts | 22:26 |
| JayF | heh | 22:26 |
| devananda | i'd also love to see support in openstackclient | 22:26 |
| devananda | tempest also has its own client implementation | 22:27 |
| jroll | +1 | 22:27 |
| devananda | because it needs to test w/o using the client we produce | 22:27 |
| *** mtanino has quit IRC | 22:27 | |
| jroll | clif_h: openstackclient does not have ironic yet at all, correct? | 22:28 |
| clif_h | openstackclient? | 22:28 |
| JayF | clif_h: unified openstack client that's replacing (eventually) python-[project]client | 22:29 |
| JayF | clif_h: Ironic doesn't have any support in it yet at all | 22:29 |
| jroll | clif_h: oh, I was mistaken as to the intent of that PR to arsenal :P | 22:29 |
| jroll | names are hard. | 22:29 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 22:29 |
| clif_h | am I replicating work? | 22:29 |
| JayF | Not at all. | 22:29 |
| jroll | no | 22:29 |
| jroll | just names :P | 22:29 |
| clif_h | mine is named OpenstackClientWrapper | 22:30 |
| jroll | JayF: at any rate, many clients. | 22:30 |
| jroll | clif_h: right, I thought it dealt with the new openstackclient thing, and was wondering how that worked without ironic support there | 22:30 |
| NobodyCam | devananda: are you around? | 22:32 |
| JayF | JoshNang: https://review.openstack.org/#/c/155561/26/etc/ironic/ironic.conf.sample,cm why did line 18/79 change? | 22:33 |
| *** rwsu has joined #openstack-ironic | 22:33 | |
| JayF | JoshNang: it seems very unrelated | 22:33 |
| devananda | NobodyCam: yes | 22:34 |
| *** bauwser is now known as bauzas | 22:34 | |
| jroll | JayF: yay for auto-generating things | 22:34 |
| jroll | JayF: if you -1 for that I will stab something nearby | 22:35 |
| jroll | (but good catch) | 22:35 |
| NobodyCam | ahh | 22:35 |
| JayF | I do it in IRC for that reason | 22:35 |
| JoshNang | JayF: ah, changed with in band inspection | 22:35 |
| JayF | why is it OK that we changed those values from something that had any chance of being valid to something that has a near-zero chance of being valid? | 22:35 |
| jroll | JayF: it's an external library defining the defaults. | 22:36 |
| JayF | that just seems to violate the principle of sane defaults | 22:36 |
| JayF | ugh | 22:36 |
| * jroll wonders if through code or what | 22:36 | |
| NobodyCam | devananda: can you look over my comments on the microversion spec | 22:36 |
| NobodyCam | have new rev ready to push up | 22:36 |
| * NobodyCam also shakes fist at devananda for rendering comments :-p | 22:37 | |
| NobodyCam | hehehe | 22:37 |
| devananda | JayF: changed what? | 22:38 |
| jroll | NobodyCam: it's easier to comment on a patchset than inline comments? | 22:38 |
| jroll | devananda: oslo.messaging defaults: 22:33:32 JayF | JoshNang: https://review.openstack.org/#/c/155561/26/etc/ironic/ironic.conf.sample,cm why did line 18/79 change? | 22:38 |
| JayF | that | 22:38 |
| NobodyCam | jroll: ok.... | 22:38 |
| JayF | I am very not a fan of that change ^ | 22:38 |
| JayF | but if it's not us, it's not us | 22:38 |
| jroll | JayF: idk, it happens to me every time I generate configs but | 22:39 |
| openstackgerrit | Chris Krelle proposed openstack/ironic-specs: API Microversions https://review.openstack.org/161110 | 22:39 |
| jroll | not sure why | 22:39 |
| NobodyCam | jroll: ^^^^^ | 22:39 |
| jroll | JayF: obviously oslo.messaging doesn't hardcode ironic | 22:39 |
| devananda | so there arebugs in our config generation? | 22:41 |
| devananda | that's not oslo's fault | 22:41 |
| devananda | (unless it is) | 22:41 |
| JayF | I pointed it out, I'm still reviewing that patch though so haven't dug into why those changed yet | 22:41 |
| devananda | also that's easy to fix // not do | 22:41 |
| devananda | JayF: cause someone regenerated the file and did'nt do "git add -p" ? | 22:42 |
| jroll | there, fixed | 22:42 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 22:42 |
| JoshNang | looks like it changed this morning between patchsets 21 and 22 | 22:42 |
| *** thiagop has joined #openstack-ironic | 22:42 | |
| JoshNang | jroll: thanks :) | 22:42 |
| JayF | jroll: I wish you'd have let me know, I had another nit you could've fixed | 22:43 |
| JayF | lol | 22:43 |
| jroll | JayF: fix it | 22:43 |
| jroll | I just want the churn to stop | 22:43 |
| jroll | also that took 30 seconds to fix, we talked about it for far longer | 22:43 |
| jroll | I just want to see tempest passing on the full stack of changes | 22:44 |
| JayF | I'm just going to ignore my nit, it was s/zap/clean/ in a few places in test comments | 22:44 |
| JayF | nothign that actually matters | 22:44 |
| JayF | JoshNang: https://review.openstack.org/#/c/161453/7 is in merge conflict (again?) | 22:45 |
| JoshNang | JayF: haven't gotten to that one yet | 22:45 |
| JayF | ah, okay | 22:45 |
| JoshNang | merge conflicts everywhere! | 22:45 |
| JayF | I'm just looking at the patchset, wanted to make sure you knew | 22:45 |
| JoshNang | thanks :) | 22:45 |
| JayF | it's almost like lots of code is merging :) | 22:45 |
| JoshNang | heh yeah | 22:45 |
| devananda | jroll: just to check, did you end up finding any other api changes? | 22:48 |
| devananda | betwee juno and microversions, i mean | 22:48 |
| jroll | devananda: I haven't | 22:48 |
| devananda | k | 22:48 |
| jroll | I swear we had a list of stuff | 22:48 |
| devananda | i've got this worked out then | 22:48 |
| devananda | and i now share ryanpetrello's hatred of RestController | 22:49 |
| jroll | heh | 22:49 |
| devananda | just fixing unit tets for v0 | 22:49 |
| devananda | 1.0 | 22:49 |
| JayF | JoshNang: if you'll poke me when that other one is pushed, I will review it. | 22:49 |
| JoshNang | JayF: can do. refactored some of the functions out so ramieni doesn't need to duplicate get_clean_steps or execute_clean_steps in ilo_agent | 22:50 |
| JayF | nice | 22:50 |
| * krotscheck reads backscroll | 22:51 | |
| NobodyCam | krotscheck: been a fun day! | 22:52 |
| krotscheck | jroll: Talk to me about this nodejs client? | 22:52 |
| devananda | krotscheck: hey there! was just pointing out to you that someone else has a node.js client for Ironic | 22:53 |
| krotscheck | As in, what company is working on it? Because.... | 22:53 |
| devananda | nvm - you found it | 22:53 |
| jroll | krotscheck: heh | 22:53 |
| jroll | 22:26:17 jroll | devananda: it literally does node-list and node-show | 22:53 |
| *** hemna has quit IRC | 22:53 | |
| jroll | 22:26:28 jroll | not much value to be had, and it isn't abstracted at all | 22:53 |
| jroll | 22:26:31 jroll | but yes it exists | 22:53 |
| krotscheck | Yes. I want to see code, or the name of the company that's written it. | 22:53 |
| krotscheck | For reasons that will likely become obvious in the not-too-distant future. | 22:53 |
| jroll | I'm from rackspace | 22:54 |
| jroll | and I'm trying to dig up the relevant code | 22:54 |
| jroll | but literally it does two types of GET requests and nothing else | 22:54 |
| jroll | it isn't very useful | 22:54 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Support the equivalent of the Juno API https://review.openstack.org/164369 | 22:56 |
| devananda | let's see if ^ passes tests :) | 22:56 |
| jroll | krotscheck: oh! it extends pkgcloud | 22:56 |
| * jroll gists some stuff | 22:56 | |
| devananda | JayF: on the version thing, ^^ :) | 22:57 |
| JayF | thanks, I'll look | 22:57 |
| devananda | cheers | 22:57 |
| JayF | working on c-i-b project creation patches right now :D | 22:58 |
| jroll | krotscheck: https://gist.github.com/jimrollenhagen/da92eb75ec4bedf5ef36 | 23:00 |
| krotscheck | Hrm. Interesting. | 23:00 |
| jroll | notable stuff is 121-137, ironic-wise | 23:01 |
| jroll | pkgcloud does all the auth and whatnot | 23:01 |
| * krotscheck blows up. | 23:01 | |
| jroll | basically we have an internal dashboard for our team, it uses node.js, this is the bare minimum to get the data we're interested in for it. | 23:01 |
| jroll | lol | 23:01 |
| krotscheck | :D | 23:01 |
| jroll | not a pkgcloud fan or? | 23:01 |
| krotscheck | I'm allergic to Node.js as a server. | 23:01 |
| jroll | heh | 23:02 |
| jroll | so uh | 23:02 |
| krotscheck | I love it as a runtime. But good lord not as a server. | 23:02 |
| jroll | what are you building with node.js? | 23:02 |
| krotscheck | me? StoryBoard. | 23:02 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Support the equivalent of the Juno API https://review.openstack.org/164369 | 23:02 |
| jroll | 22:53:56 krotscheck | For reasons that will likely become obvious in the not-too-distant future. | 23:02 |
| jroll | I want these to be obvious now :P | 23:02 |
| krotscheck | Oh that. | 23:02 |
| krotscheck | I want to write javascript-lib-ironic in a way that lets it drop cleanly into horizon, node, or roll-your-own-app. | 23:03 |
| krotscheck | And then publish it to bower. | 23:03 |
| jroll | oh, neat | 23:04 |
| JayF | krotscheck: https://c34a6498d4802e89941e-16c214a4a8ca35317ce45a32e60db84b.ssl.cf1.rackcdn.com/7y.jpeg | 23:04 |
| jroll | +1 | 23:04 |
| krotscheck | And do the same with swift, etc etc. | 23:04 |
| JayF | so my meme is wrong :( | 23:04 |
| krotscheck | ....whaaaaaa.... what's that image? | 23:04 |
| jroll | lol | 23:04 |
| devananda | JayF: LOL | 23:04 |
| JayF | The onmetal bare metal bear | 23:04 |
| jroll | krotscheck: "bear metal" | 23:04 |
| krotscheck | Oh. | 23:04 |
| krotscheck | Wat | 23:04 |
| krotscheck | I | 23:04 |
| devananda | krotscheck: we have a mascot | 23:04 |
| jroll | krotscheck: https://wiki.openstack.org/wiki/Ironic#Pixie_Boots.2C_the_Ironic_drummer_bear | 23:05 |
| jroll | lamo | 23:05 |
| jroll | lmao, too | 23:05 |
| krotscheck | And this is why we can't have nice things. | 23:05 |
| jroll | krotscheck: so uh, back to real work. why not pkg cloud? (if it only works on rackspace tell me to gtfo now) | 23:05 |
| krotscheck | Well, personally speaking, because I think running node as a server is moronic. | 23:06 |
| krotscheck | But that's purely an independent thing. | 23:06 |
| jroll | well | 23:06 |
| krotscheck | And if you're going to be dependent on node, then no. | 23:06 |
| jroll | plgcloud is just a node library | 23:06 |
| jroll | oh, you want it to be not node-specific | 23:06 |
| krotscheck | Can you run it in a thick client? | 23:06 |
| jroll | idk. | 23:07 |
| jroll | browserify man. | 23:07 |
| JayF | I think pkgcloud can be used in the browser but imbw | 23:07 |
| jroll | (no idea how realistic that is) | 23:07 |
| JayF | kenperkins on IRC is the guy to ask, IDK what public channel's he's in though | 23:07 |
| jroll | um | 23:07 |
| * jroll asks people | 23:07 | |
| jroll | he's in #rackspace at a minimum | 23:07 |
| JayF | s/\'// | 23:07 |
| jroll | ? | 23:07 |
| JayF | channel's vs channels | 23:08 |
| jroll | oh wow | 23:08 |
| * jroll *whoosh* | 23:08 | |
| jroll | must be quittin time | 23:08 |
| krotscheck | ARGH. Everything that I want to do has already been done. | 23:08 |
| jroll | lol | 23:09 |
| jroll | I think that means you can go on vacation | 23:09 |
| jroll | surely there will be something to do when you come back | 23:09 |
| NobodyCam | lol | 23:09 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement cleaning/zapping for the agent driver https://review.openstack.org/161453 | 23:10 |
| JayF | devananda: your +1 was specifically requested for these, but obviously not urgent so please look at your leisure https://review.openstack.org/#/c/155868 + https://review.openstack.org/164370 | 23:11 |
| JayF | JoshNang: looking ^ | 23:11 |
| * devananda looks | 23:11 | |
| JoshNang | thanks! | 23:11 |
| openstackgerrit | Merged openstack/ironic: Add missing exceptions to destroy_node docstrings https://review.openstack.org/164279 | 23:11 |
| devananda | JayF: I assume you'll soon add build testing, artefact publishing, etc, to the new repo | 23:12 |
| devananda | once, you know, it's there and stuff | 23:12 |
| JayF | Absolutely; I wanted to do all that work in openstack though | 23:12 |
| devananda | totally | 23:12 |
| JayF | rather than ninja'ing in a pile of commits in github | 23:12 |
| JayF | which I was totally tempted to do | 23:13 |
| JayF | lol | 23:13 |
| devananda | JayF: putting my +1 on them | 23:13 |
| JayF | thanks! | 23:13 |
| jroll | devananda: so with this 1.0 == stable/juno change | 23:17 |
| jroll | are you planning to also make 0 the min_version? | 23:17 |
| JayF | JoshNang: +1 w/a very small nit | 23:17 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 23:17 |
| JoshNang | JayF: \o/ | 23:17 |
| JoshNang | JayF: mm good call. i'll fix it one way or another | 23:18 |
| devananda | jroll: i did | 23:19 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Support the equivalent of the Juno API https://review.openstack.org/164369 | 23:20 |
| jroll | devananda: ok | 23:20 |
| JayF | devananda: ^ that got a +1 from me, just fixed the commit message nit jlvillal found | 23:21 |
| jroll | oh, I didn't know that change was up | 23:21 |
| * jroll -1'd | 23:24 | |
| jroll | I wish we used the word 'version' rather than 'microversion' | 23:26 |
| * jroll random thoughts | 23:26 | |
| devananda | yah | 23:26 |
| NobodyCam | gah | 23:27 |
| NobodyCam | :-p | 23:27 |
| * NobodyCam steps away for a smoke | 23:28 | |
| *** david-lyle is now known as david-lyle_afk | 23:29 | |
| *** absubram has quit IRC | 23:29 | |
| jroll | NobodyCam: +2'd the version spec | 23:34 |
| NobodyCam | w00t | 23:34 |
| NobodyCam | :) | 23:34 |
| jroll | I think at least half the cores have +2'd at this point | 23:35 |
| jroll | I did leave some notes though | 23:35 |
| *** rwsu has quit IRC | 23:35 | |
| NobodyCam | thou all I did was basiclly a search and replace | 23:35 |
| jroll | heh | 23:35 |
| NobodyCam | :o | 23:35 |
| devananda | this is done now, right? https://blueprints.launchpad.net/ironic/+spec/local-boot-support-with-partition-images | 23:35 |
| jroll | I believe so, though BadCub said it was waiting on AMT or something? | 23:36 |
| jroll | or no... naohirot's driver | 23:36 |
| jroll | irmc? | 23:36 |
| NobodyCam | devananda: I think BadCub pinged something about it | 23:36 |
| jroll | yeah, there's an irmc patch for it | 23:37 |
| jroll | but I would call it done without that | 23:37 |
| * jroll is 15 | 23:37 | |
| jroll | oops | 23:37 |
| * jroll is mean like that | 23:37 | |
| * jroll is also super ADD right now | 23:37 | |
| NobodyCam | your older then that :-p | 23:37 |
| NobodyCam | lol | 23:37 |
| BadCub | I put a note on LP for https://blueprints.launchpad.net/ironic/+spec/local-boot-support-with-partition-images | 23:37 |
| *** rwsu has joined #openstack-ironic | 23:38 | |
| jroll | NobodyCam: I got distracted for 5 seconds and thought I typed /b when I really typed /me is | 23:38 |
| NobodyCam | lol :) | 23:38 |
| NobodyCam | happens to me after the 10 hour mark | 23:39 |
| * jroll looks at the cloock | 23:39 | |
| jroll | 10+ | 23:39 |
| NobodyCam | lol which was like an hour ago | 23:39 |
| jroll | yeah, beer time | 23:39 |
| devananda | BadCub: gotcha. thta patch is blocked, because we deferred irmc vmedia driver | 23:39 |
| devananda | i just blocked that patch to make it more clear | 23:40 |
| jroll | oh | 23:40 |
| NobodyCam | lol this weeks beeen rum and (diet) coke | 23:40 |
| BadCub | I think we are very close to closing https://blueprints.launchpad.net/ironic/+spec/root-device-hints with a couple reviews on 163794 & 163857 | 23:40 |
| jroll | yay, we finished a thing | 23:40 |
| jroll | NobodyCam: funny, I have a rum and lemonade atm | 23:40 |
| NobodyCam | jroll: ++++ | 23:40 |
| *** ChuckC has joined #openstack-ironic | 23:41 | |
| jroll | so good | 23:41 |
| * BadCub gets ready for Cherry Noir Gray Goose and Dr. pepper | 23:41 | |
| jroll | mmmm | 23:41 |
| devananda | doc patch here https://review.openstack.org/#/c/164029/3 with one +2 already | 23:41 |
| jroll | easy enough | 23:41 |
| * jroll finishes that out | 23:41 | |
| NobodyCam | awesome ! | 23:42 |
| jroll | devananda: is it bad that I don't know what "vpro tag" or "intel's tag" means? | 23:42 |
| devananda | jroll: nah | 23:43 |
| devananda | I do | 23:43 |
| jroll | I mean, it's a docs thing. | 23:43 |
| jlvillal | jroll: Earlier you were talking about a program written in Go that runs on Core-OS. And that if it was moved to Python would need to have additional environment setup. | 23:43 |
| jroll | jlvillal: yep | 23:43 |
| NobodyCam | this has been a great day! Thank you all! (here and -away) !!! awesome work! | 23:43 |
| jlvillal | jroll: I was wondering if something like PEX would help for that situation: http://pex.readthedocs.org/en/latest/ | 23:43 |
| jroll | CoreOS* because I'm feeling pedantic | 23:43 |
| jroll | NobodyCam: :) | 23:43 |
| jlvillal | jroll: It sort of takes a virtualenv and makes it into an EXE I think | 23:43 |
| jroll | jlvillal: interesting. I'm probably going to hate it because it's yet another way(tm) to package python | 23:44 |
| jlvillal | It's written by some twits. I mean it is written by Twitter ;) | 23:44 |
| jroll | yeah | 23:44 |
| jroll | at any rate... I'd rather just use a container | 23:44 |
| jlvillal | jroll: Okay. Just thought I'd mention it as an option. | 23:45 |
| JayF | You know what'd be an interesting project? A small, python-only operating system for running python things in a container | 23:45 |
| jroll | jlvillal: indeed | 23:45 |
| jroll | JayF: ogod | 23:45 |
| NobodyCam | lol anyone ever look up the faild attemp at the pyhon linux shell | 23:46 |
| jroll | JayF: I kinda want to hear glyph's thoughts on that | 23:46 |
| JayF | jroll: we could make it support openpower :P | 23:46 |
| jroll | you're going to compile python for openpower? | 23:46 |
| jroll | haaaaaaa, have fun. | 23:46 |
| * devananda approves the microversion spec | 23:46 | |
| JayF | dude, you don't think it already exists? | 23:46 |
| JayF | almost all commonly used things are already supported on power :) | 23:46 |
| russell_h | it does | 23:46 |
| russell_h | http://www.ubuntu.com/download/server/power8 | 23:47 |
| jroll | right on | 23:48 |
| openstackgerrit | Merged openstack/ironic-specs: API Microversions https://review.openstack.org/161110 | 23:49 |
| NobodyCam | and now I think its time to start the dinner thought process... :) | 23:50 |
| JayF | krotscheck: can you /join #rackspace on this network if you're interested in the js library thing? | 23:51 |
| JayF | krotscheck: ken is around now and I can introduce | 23:52 |
| jroll | NobodyCam: indeed | 23:52 |
| jroll | NobodyCam: devananda: thoughts on my comment here? https://review.openstack.org/#/c/164029/3/doc/source/drivers/amt.rst | 23:52 |
| NobodyCam | have a great weekend all :) | 23:52 |
| * NobodyCam slowlly clicks | 23:52 | |
| jroll | hehehe | 23:52 |
| *** mgoddard has quit IRC | 23:53 | |
| * BadCub needs to go hunt fast food and hang more curtains.... So many curtains........ | 23:53 | |
| jlvillal | NobodyCam: Enjoy! | 23:54 |
| openstackgerrit | Merged openstack/ironic: Add validations for root device hints https://review.openstack.org/163794 | 23:56 |
| NobodyCam | jroll: the password comment | 23:56 |
| jroll | NobodyCam: ya | 23:57 |
| NobodyCam | I agree and am about to +a that.. with a follow up patch... | 23:57 |
| jroll | cool | 23:57 |
| NobodyCam | jroll: done | 23:58 |
| jroll | woot, thanks | 23:58 |
| jlvillal | Have a great weekend Ironic. | 23:59 |
| jroll | ^ | 23:59 |
| * jroll goes away for the night | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
