| *** causten has quit IRC | 00:04 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: [WIP / POC] Add Intel Node Manager sensor data collection https://review.openstack.org/410465 | 00:04 |
|---|---|---|
| *** baoli has quit IRC | 00:07 | |
| *** mtanino has quit IRC | 00:10 | |
| *** rcernin has quit IRC | 00:22 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic: Reusing oneview_client when possible https://review.openstack.org/358041 | 00:27 |
| *** harlowja has joined #openstack-ironic | 00:30 | |
| *** yuanying has joined #openstack-ironic | 00:44 | |
| *** hugonicodemos has joined #openstack-ironic | 00:45 | |
| *** lindycoder has quit IRC | 00:45 | |
| *** hw_wutianwei has joined #openstack-ironic | 00:48 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Clarify the comment about the object hashes https://review.openstack.org/410479 | 00:49 |
| *** yuanying has quit IRC | 00:52 | |
| *** yuanying has joined #openstack-ironic | 00:52 | |
| *** SerenaFeng has joined #openstack-ironic | 00:55 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic: Fix return values in OneView deploy interface https://review.openstack.org/396698 | 00:56 |
| *** sacharya has joined #openstack-ironic | 00:58 | |
| *** hoangcx has joined #openstack-ironic | 01:01 | |
| *** sacharya has quit IRC | 01:03 | |
| *** rama_y has quit IRC | 01:07 | |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Moving Reboot bashscript to python https://review.openstack.org/410486 | 01:20 |
| *** zhangjl has joined #openstack-ironic | 01:22 | |
| *** jkilpatr_ has quit IRC | 01:22 | |
| *** rbudden has quit IRC | 01:28 | |
| openstackgerrit | zhangyanying proposed openstack/ironic: Fix error when system uses /usr/bin/qemu-kvm, as in CentOS 7.2. https://review.openstack.org/410052 | 01:34 |
| openstackgerrit | Sam Stoelinga proposed openstack/bifrost: Fix bifrost install playbook README: default value https://review.openstack.org/410492 | 01:38 |
| *** Nisha_Agarwal has joined #openstack-ironic | 01:40 | |
| *** tuanluong has joined #openstack-ironic | 01:42 | |
| *** Nisha_Agarwal has quit IRC | 01:45 | |
| *** yufei has joined #openstack-ironic | 01:47 | |
| openstackgerrit | Stenio Araujo proposed openstack/ironic: Adds another validation step when using dynamic allocation https://review.openstack.org/377073 | 01:48 |
| *** zhugaoxiao has quit IRC | 01:51 | |
| *** hugonicodemos has quit IRC | 01:51 | |
| *** zhugaoxiao has joined #openstack-ironic | 01:52 | |
| *** SerenaFeng has quit IRC | 01:55 | |
| *** zhs_ has joined #openstack-ironic | 02:02 | |
| *** wajdi has joined #openstack-ironic | 02:03 | |
| *** zhs has quit IRC | 02:05 | |
| openstackgerrit | zhangyanying proposed openstack/ironic: Fix error when system uses /usr/bin/qemu-kvm, as in CentOS 7.2. https://review.openstack.org/410052 | 02:06 |
| *** SerenaFeng has joined #openstack-ironic | 02:07 | |
| *** SerenaFeng has quit IRC | 02:07 | |
| *** SerenaFeng has joined #openstack-ironic | 02:07 | |
| *** yufei_ has quit IRC | 02:08 | |
| *** lindycoder has joined #openstack-ironic | 02:11 | |
| *** yufei_ has joined #openstack-ironic | 02:17 | |
| *** fragatin_ has joined #openstack-ironic | 02:23 | |
| *** lindycoder has quit IRC | 02:25 | |
| *** fragatina has quit IRC | 02:27 | |
| *** fragatin_ has quit IRC | 02:28 | |
| *** baoli has joined #openstack-ironic | 02:32 | |
| *** aNuposic has quit IRC | 02:36 | |
| openstackgerrit | chenyingnan proposed openstack/ironic-inspector: Add author and author-email in setup.cfg https://review.openstack.org/410508 | 02:38 |
| *** bcornec2 has quit IRC | 02:49 | |
| *** bcornec has joined #openstack-ironic | 02:49 | |
| *** alexpilo_ has quit IRC | 02:52 | |
| *** yuanying has quit IRC | 02:53 | |
| *** yuanying has joined #openstack-ironic | 02:54 | |
| *** yuanying has quit IRC | 02:58 | |
| *** sacharya has joined #openstack-ironic | 02:59 | |
| *** awiddersheim has quit IRC | 03:04 | |
| *** sacharya has quit IRC | 03:04 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 03:07 |
| *** awiddersheim has joined #openstack-ironic | 03:12 | |
| *** SerenaFeng has quit IRC | 03:12 | |
| *** rloo has quit IRC | 03:19 | |
| *** EmilienM has quit IRC | 03:19 | |
| *** EmilienM has joined #openstack-ironic | 03:19 | |
| *** Syed__ has quit IRC | 03:25 | |
| *** sacharya has joined #openstack-ironic | 03:25 | |
| *** gmmaha has quit IRC | 03:31 | |
| *** gmmaha has joined #openstack-ironic | 03:31 | |
| openstackgerrit | zhangyanying proposed openstack/ironic: Fix error when system uses /usr/bin/qemu-kvm, as in CentOS 7.2. https://review.openstack.org/410052 | 03:34 |
| *** vikrant has joined #openstack-ironic | 03:39 | |
| *** yuanying has joined #openstack-ironic | 03:52 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 03:54 | |
| *** baoli has quit IRC | 03:57 | |
| *** ijw has quit IRC | 03:59 | |
| *** hoangcx has quit IRC | 04:04 | |
| *** gmmaha has quit IRC | 04:07 | |
| *** gmmaha has joined #openstack-ironic | 04:09 | |
| *** bks has joined #openstack-ironic | 04:22 | |
| *** sambetts_ has quit IRC | 04:43 | |
| *** sambetts_ has joined #openstack-ironic | 04:44 | |
| *** chlong has joined #openstack-ironic | 04:44 | |
| *** sambetts_ is now known as Guest51566 | 04:44 | |
| *** ijw has joined #openstack-ironic | 04:46 | |
| *** jrcloud has joined #openstack-ironic | 04:50 | |
| *** zackf has quit IRC | 04:53 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Generic management I/F for Inject NMI https://review.openstack.org/348191 | 04:54 |
| *** Guest51566 has quit IRC | 04:55 | |
| *** sambetts has joined #openstack-ironic | 04:57 | |
| *** links has joined #openstack-ironic | 04:57 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Ipmitool management driver for Inject NMI https://review.openstack.org/348721 | 05:08 |
| *** yuriyz|2 has joined #openstack-ironic | 05:11 | |
| *** yuriyz|2 has quit IRC | 05:12 | |
| *** jrcloud has quit IRC | 05:12 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: iRMC management driver for Inject NMI https://review.openstack.org/348732 | 05:18 |
| *** rama_y has joined #openstack-ironic | 05:20 | |
| *** aparnav has joined #openstack-ironic | 05:25 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Fix ironic dev-quickstart doc https://review.openstack.org/410537 | 05:35 |
| *** gcb has quit IRC | 05:35 | |
| *** SerenaFeng has joined #openstack-ironic | 05:41 | |
| *** rajinir has quit IRC | 05:46 | |
| *** jaosorior has joined #openstack-ironic | 05:50 | |
| *** gcb has joined #openstack-ironic | 05:52 | |
| *** fragatina has joined #openstack-ironic | 06:03 | |
| *** gcb has quit IRC | 06:05 | |
| *** fragatina has quit IRC | 06:08 | |
| *** pmannidi_ has quit IRC | 06:10 | |
| *** pmannidi has joined #openstack-ironic | 06:11 | |
| *** amotoki has joined #openstack-ironic | 06:12 | |
| *** amotoki has quit IRC | 06:14 | |
| *** tuanluong has quit IRC | 06:16 | |
| *** Fdaisuke has quit IRC | 06:17 | |
| *** amotoki has joined #openstack-ironic | 06:17 | |
| *** Fdaisuke has joined #openstack-ironic | 06:18 | |
| *** tuanluong has joined #openstack-ironic | 06:21 | |
| *** gcb has joined #openstack-ironic | 06:22 | |
| *** zackf has joined #openstack-ironic | 06:31 | |
| *** eroux has joined #openstack-ironic | 06:31 | |
| *** zackf has quit IRC | 06:35 | |
| *** afazekas has quit IRC | 06:40 | |
| *** afazekas has joined #openstack-ironic | 06:42 | |
| *** kumarb has joined #openstack-ironic | 06:44 | |
| *** bks has quit IRC | 06:47 | |
| *** zackf has joined #openstack-ironic | 06:51 | |
| *** moshele has joined #openstack-ironic | 06:59 | |
| *** ChubYann has quit IRC | 07:01 | |
| *** moshele has quit IRC | 07:01 | |
| *** ijw has quit IRC | 07:02 | |
| *** mjura has joined #openstack-ironic | 07:02 | |
| *** moshele has joined #openstack-ironic | 07:03 | |
| *** fxpester has joined #openstack-ironic | 07:06 | |
| *** rama_y has quit IRC | 07:06 | |
| tuanluong | Morning ironic | 07:07 |
| *** mjura has quit IRC | 07:08 | |
| *** mjura has joined #openstack-ironic | 07:09 | |
| *** phuongnh has joined #openstack-ironic | 07:09 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 07:09 | |
| *** zackf has quit IRC | 07:12 | |
| *** bks has joined #openstack-ironic | 07:17 | |
| *** bapalm has quit IRC | 07:18 | |
| *** swatson has quit IRC | 07:19 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Add support of remote logging https://review.openstack.org/410247 | 07:19 |
| *** kumarb has quit IRC | 07:19 | |
| *** sacharya has quit IRC | 07:26 | |
| *** vsaienko has joined #openstack-ironic | 07:27 | |
| *** SerenaFeng has quit IRC | 07:35 | |
| *** bapalm has joined #openstack-ironic | 07:38 | |
| *** gcb has quit IRC | 07:44 | |
| *** gcb has joined #openstack-ironic | 07:45 | |
| *** SerenaFeng has joined #openstack-ironic | 07:49 | |
| *** ralonsoh has joined #openstack-ironic | 07:51 | |
| *** zhangjl1 has joined #openstack-ironic | 07:55 | |
| *** rcernin has joined #openstack-ironic | 07:56 | |
| *** Romanenko_K has joined #openstack-ironic | 07:56 | |
| *** rcernin has quit IRC | 07:56 | |
| *** zhangjl has quit IRC | 07:57 | |
| openstackgerrit | paresh sao proposed openstack/proliantutils: Adds 'UefiTarget' as a boot option https://review.openstack.org/407487 | 07:57 |
| *** rcernin has joined #openstack-ironic | 07:57 | |
| vdrok | morning ironic and tuanluong | 07:59 |
| tuanluong | Morning vdrok | 07:59 |
| *** pcaruana has joined #openstack-ironic | 07:59 | |
| *** SerenaFeng has quit IRC | 08:00 | |
| *** sacharya has joined #openstack-ironic | 08:00 | |
| *** SerenaFeng has joined #openstack-ironic | 08:00 | |
| *** sacharya has quit IRC | 08:05 | |
| *** Nisha_Agarwal has quit IRC | 08:05 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 08:06 | |
| *** SerenaFeng has quit IRC | 08:08 | |
| *** ccamacho has joined #openstack-ironic | 08:10 | |
| *** gcb has quit IRC | 08:10 | |
| *** gcb has joined #openstack-ironic | 08:11 | |
| tuanluong | vdrok, I'm using disk-image-create ubuntu vm dhcp-all-interfaces grub2 -o my-image | 08:14 |
| tuanluong | hello vdrok | 08:14 |
| *** SerenaFeng has joined #openstack-ironic | 08:15 | |
| tuanluong | but after deploy sucessfull iamge I can't access to instances using ssh | 08:15 |
| *** jaosorior has quit IRC | 08:16 | |
| *** jaosorior has joined #openstack-ironic | 08:16 | |
| vdrok | tuanluong: are you using multitenancy in ironic? ie have separate provision clean and tenant networks? | 08:18 |
| tuanluong | vdrok, I am using flat network | 08:19 |
| tuanluong | follow guide here http://docs.openstack.org/developer/ironic/4.3.0/deploy/install-guide.html | 08:19 |
| vdrok | tuanluong: do you include the ssh key in the image? | 08:20 |
| vdrok | tuanluong: or you do nova boot with --key-name? | 08:21 |
| vdrok | otherwise if there is no key, you won't be able to ssh | 08:21 |
| tuanluong | I using nove --key-name | 08:21 |
| tuanluong | vdrok, my case is after i deploy image | 08:22 |
| vdrok | yeah I got that | 08:22 |
| tuanluong | i can't ping to a instance | 08:22 |
| vdrok | tuanluong: ah, so you can't ping | 08:22 |
| vdrok | that's a network issue then | 08:22 |
| tuanluong | vdrok, yes | 08:22 |
| vdrok | tuanluong: is it a hardware node? | 08:23 |
| vdrok | or a vm? | 08:23 |
| tuanluong | Im try in vm | 08:23 |
| tuanluong | vdrok, when i using an image on the internet it sucessfull | 08:24 |
| tuanluong | vdrok, for example https://uec-images.ubuntu.com/releases/14.04/release/ | 08:24 |
| vdrok | tuanluong: ok, that seems like dhcp-all-interfaces can be causing issues | 08:25 |
| tuanluong | I thinks i create image not correct when using disk-image-create | 08:25 |
| vdrok | could you check the network interfaces in the node's console, do they get ips? | 08:25 |
| tuanluong | vdrok, what do you means "node's console" | 08:26 |
| *** jpich has joined #openstack-ironic | 08:27 | |
| tuanluong | I'm using Ubuntu 16.04. for get my ip. often using ifconfig | 08:27 |
| *** sborkows has joined #openstack-ironic | 08:27 | |
| vdrok | tuanluong: just going into KVM vonsole and checking the interfaces | 08:27 |
| sborkows | morning, all | 08:27 |
| vdrok | morning sborkows | 08:27 |
| tuanluong | vdrok, I depoy openstack in hardware | 08:29 |
| vdrok | tuanluong: but you're saying that your ironic nodes are vms? then you should be able to access their console not only through ssh, but through hypervisor too | 08:31 |
| tuanluong | vdrok, I can see Virtual Network Interface | 08:32 |
| vsaienk0 | morning Ironic'ers! | 08:34 |
| tuanluong | morning vsaienk0 | 08:39 |
| *** SerenaFeng has quit IRC | 08:40 | |
| aarefiev | morning all! | 08:41 |
| openstackgerrit | zhangyanying proposed openstack/ironic: Fix error when system uses /usr/bin/qemu-kvm, as in CentOS 7.2. https://review.openstack.org/410052 | 08:41 |
| tuanluong | Morning aarefiev | 08:41 |
| aarefiev | o/ | 08:41 |
| *** SerenaFeng has joined #openstack-ironic | 08:42 | |
| vdrok | tuanluong: do you use virt-manager? | 08:43 |
| vdrok | mornin vsaienk0 and aarefiev | 08:43 |
| openstackgerrit | Merged openstack/bifrost: Adding staging driver support https://review.openstack.org/406401 | 08:43 |
| tuanluong | sorry, vdrok yes | 08:43 |
| aarefiev | hey vdrok | 08:43 |
| *** vsaienko has quit IRC | 08:44 | |
| vdrok | tuanluong: you can add a connection to devstack there, connect, and see the list of vms, node-0 node-1 etc. | 08:44 |
| *** daemontool has joined #openstack-ironic | 08:44 | |
| vdrok | just double click on the running one and you'll get its console | 08:44 |
| tuanluong | Yes, i can see it | 08:44 |
| openstackgerrit | Merged openstack/bifrost: Fix keystone config templates https://review.openstack.org/407105 | 08:44 |
| *** moshele has quit IRC | 08:45 | |
| tuanluong | vdrok, I can login to console but i don't know pass to login | 08:45 |
| vdrok | tuanluong: ah, but if it's dib-built image, local login is disabled there :( | 08:45 |
| vdrok | tuanluong: there should be another element to enable local login, lemme search | 08:46 |
| vdrok | tuanluong: https://github.com/openstack/diskimage-builder/tree/master/elements/devuser | 08:46 |
| vdrok | could you add it too, set the DIB_DEV_USER_PASSWORD and login to that vm locally afterwards and check that interfaces come up? | 08:47 |
| *** moshele has joined #openstack-ironic | 08:47 | |
| tuanluong | vdrok, yes. I will try it . thanks vdrok | 08:48 |
| *** openstackgerrit has quit IRC | 08:48 | |
| vdrok | maybe setting DIB_DEV_USER_PWDLESS_SUDO too | 08:48 |
| *** Nisha_Agarwal has quit IRC | 08:48 | |
| tuanluong | vdrok, I can see the DIB_DEV_USER_USERNAME=${DIB_DEV_USER_USERNAME:-devuser} | 08:50 |
| vdrok | yes. that's the default name | 08:50 |
| *** openstackgerrit has joined #openstack-ironic | 08:50 | |
| openstackgerrit | Aparna proposed openstack/ironic-specs: In-band hpsum firmware update for iLO drivers https://review.openstack.org/410161 | 08:50 |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector: Remove upgrade from non-ironic setup https://review.openstack.org/410606 | 08:51 |
| *** zhangjl1 has left #openstack-ironic | 08:51 | |
| tuanluong | vdrok, sorry, it take time to me to re-deploy. | 08:52 |
| vdrok | sure, np :) | 08:52 |
| *** daemontool_ has joined #openstack-ironic | 08:55 | |
| *** amoralej|off is now known as amoralej | 08:56 | |
| *** strigazi1AFK has joined #openstack-ironic | 08:58 | |
| *** daemontool has quit IRC | 08:58 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-ironic | 09:00 | |
| *** strigazi_AFK has quit IRC | 09:00 | |
| *** yolanda has quit IRC | 09:01 | |
| *** tuanluong has quit IRC | 09:02 | |
| *** rama_y has joined #openstack-ironic | 09:02 | |
| *** tuanluong has joined #openstack-ironic | 09:03 | |
| *** dtantsur|afk is now known as dtantsur | 09:03 | |
| dtantsur | Morning Ironic | 09:03 |
| vdrok | morning dtantsur | 09:03 |
| sborkows | morning dtantsur | 09:03 |
| *** strigazi_AFK has joined #openstack-ironic | 09:04 | |
| *** yolanda has joined #openstack-ironic | 09:05 | |
| *** strigazi1AFK has quit IRC | 09:07 | |
| aarefiev | morning dtantsur | 09:09 |
| dtantsur | o/ | 09:09 |
| *** ohamada has joined #openstack-ironic | 09:15 | |
| *** gcb has quit IRC | 09:21 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 09:23 | |
| *** lucas-afk is now known as lucasagomes | 09:27 | |
| *** derekh has joined #openstack-ironic | 09:32 | |
| lucasagomes | morning dtantsur vdrok sborkows aarefiev all | 09:32 |
| vdrok | morning lucasagomes | 09:32 |
| aarefiev | morning lucasagomes | 09:32 |
| *** SerenaFeng has quit IRC | 09:33 | |
| *** tuanluong_ has joined #openstack-ironic | 09:34 | |
| *** athomas has joined #openstack-ironic | 09:35 | |
| *** tuanluong has quit IRC | 09:36 | |
| *** gcb has joined #openstack-ironic | 09:39 | |
| *** milan has joined #openstack-ironic | 09:39 | |
| milan | morning Ironic! :) | 09:40 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic-specs: Update notifications specs https://review.openstack.org/410640 | 09:40 |
| vdrok | morning milan | 09:40 |
| milan | morning vdrok! :) | 09:41 |
| *** Nisha_Agarwal has quit IRC | 09:42 | |
| aarefiev | morning milan | 09:46 |
| milan | morning aarefiev! :) | 09:46 |
| * milan about to update inspector states patch | 09:47 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-python-agent: Probe for TC mirror during tinyipa build https://review.openstack.org/410404 | 09:47 |
| *** karthiks has quit IRC | 09:48 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-python-agent: Probe for TC mirror during tinyipa build https://review.openstack.org/410404 | 09:50 |
| pas-ha | morning all | 09:52 |
| vdrok | morning pas-ha | 09:53 |
| openstackgerrit | zhangyanying proposed openstack/ironic: Fix error when system uses /usr/bin/qemu-kvm, as in CentOS 7.2. https://review.openstack.org/410052 | 09:56 |
| *** Nisha_Agarwal has joined #openstack-ironic | 10:00 | |
| *** kumarb has joined #openstack-ironic | 10:02 | |
| *** bks has quit IRC | 10:06 | |
| *** dtantsur is now known as dtantsur|brb | 10:09 | |
| *** zackf has joined #openstack-ironic | 10:10 | |
| *** hshiina has joined #openstack-ironic | 10:13 | |
| *** zackf has quit IRC | 10:14 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Fix ironic dev-quickstart doc https://review.openstack.org/410537 | 10:17 |
| milan | morning pas-ha! :) | 10:18 |
| *** tuanluong_ has quit IRC | 10:24 | |
| *** strigazi_AFK is now known as strigazi | 10:26 | |
| *** bks has joined #openstack-ironic | 10:28 | |
| *** kumarb has quit IRC | 10:30 | |
| *** Nisha_Agarwal has quit IRC | 10:31 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _get_sensors_data concurrent https://review.openstack.org/407429 | 10:35 |
| *** links has quit IRC | 10:38 | |
| *** links has joined #openstack-ironic | 10:38 | |
| lukl | dtantsur: Do you have a moment to discuss The hooks can be enabled in the inspector.conf file. By default, these LLDP plugins will not be enabled. Background information on ironic-inspector plugins is here: ironic-inspector plugins. | 10:47 |
| lukl | https://review.openstack.org/#/c/404372/8/specs/Network-Interface-Resource-Info.rst <I meant to paste this :) | 10:47 |
| patchbot | patch 404372 - ironic-inspector-specs - Collect NIC name given by BIOS | 10:47 |
| *** _milan_ has joined #openstack-ironic | 10:47 | |
| *** milan has quit IRC | 10:48 | |
| lukl | One of the things that I would like to have with NIC data collection is knowledge about numa topology | 10:49 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _get_sensors_data concurrent https://review.openstack.org/407429 | 10:49 |
| lukl | For telco workloads it's important to know which NIC is in which NUMA node. | 10:50 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Refactor waiters in our tempest plugin https://review.openstack.org/410684 | 10:50 |
| lukl | I don't know if extra field is the right one for this, but I do feel that this information should available to both end users and nova scheduler. | 10:51 |
| *** kumarb has joined #openstack-ironic | 10:52 | |
| *** yufei has quit IRC | 10:54 | |
| *** bks has quit IRC | 10:55 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add os_project_name to functional tests config https://review.openstack.org/408235 | 10:58 |
| pas-ha | morning milan :) | 10:59 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Refactor waiters in our tempest plugin https://review.openstack.org/410684 | 11:01 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Fix ironic dev-quickstart doc https://review.openstack.org/410537 | 11:03 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Refactor waiters in our tempest plugin https://review.openstack.org/410684 | 11:04 |
| *** MattMan has quit IRC | 11:04 | |
| *** MattMan has joined #openstack-ironic | 11:04 | |
| *** eroux has quit IRC | 11:05 | |
| openstackgerrit | Merged openstack/ironic: Enhance wait_for_bm_node_status waiter https://review.openstack.org/410343 | 11:17 |
| *** jaosorior has quit IRC | 11:19 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/ironic: Test ML2 Neutron Events feature https://review.openstack.org/370016 | 11:25 |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fix ipa images urls in pxe config https://review.openstack.org/410703 | 11:28 |
| *** dtantsur|brb is now known as dtantsur | 11:28 | |
| dtantsur | lukl, anything available to the scheduler should be exposed in node capabilities | 11:29 |
| dtantsur | also yes, the lldp plugins are not enabled by default, mostly because lldp collection is not enabled in IPA by default | 11:30 |
| *** jaosorior has joined #openstack-ironic | 11:30 | |
| lukl | I just found there is another spec for numa: https://bugs.launchpad.net/ironic-inspector/+bug/1635253 | 11:31 |
| openstack | Launchpad bug 1635253 in ironic-python-agent "[RFE] Retrieve NUMA node information during introspection" [Wishlist,In progress] - Assigned to Karthik S (ksundara) | 11:31 |
| *** Nisha_Agarwal has joined #openstack-ironic | 11:33 | |
| *** kumarb has quit IRC | 11:33 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fix ipa images urls in pxe config https://review.openstack.org/410703 | 11:34 |
| lukl | Is there a spec for that already merged? | 11:34 |
| dtantsur | I don't think it's merged | 11:35 |
| dtantsur | lukl, https://review.openstack.org/#/c/396147/ | 11:35 |
| patchbot | patch 396147 - ironic-inspector-specs - Spec for retrieving NUMA node information | 11:35 |
| *** galyna has joined #openstack-ironic | 11:35 | |
| *** phuongnh has quit IRC | 11:36 | |
| *** bks has joined #openstack-ironic | 11:43 | |
| lukl | thanks | 11:44 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode https://review.openstack.org/374988 | 11:48 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode https://review.openstack.org/374988 | 11:49 |
| *** bks has quit IRC | 11:52 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: ETAGs maintenance for all api node's requests https://review.openstack.org/392213 | 11:59 |
| *** sborkows has quit IRC | 12:00 | |
| *** sacharya has joined #openstack-ironic | 12:02 | |
| *** e0ne has joined #openstack-ironic | 12:03 | |
| *** sacharya has quit IRC | 12:07 | |
| *** jkilpatr has joined #openstack-ironic | 12:08 | |
| *** athomas has quit IRC | 12:13 | |
| *** jkilpatr has quit IRC | 12:15 | |
| *** zackf has joined #openstack-ironic | 12:16 | |
| *** zhs__ has joined #openstack-ironic | 12:16 | |
| *** Nisha_Agarwal has quit IRC | 12:17 | |
| *** lucasagomes is now known as lucas-hungry | 12:17 | |
| *** gcb has quit IRC | 12:20 | |
| *** zhs_ has quit IRC | 12:20 | |
| *** awiddersheim has quit IRC | 12:20 | |
| *** zackf has quit IRC | 12:20 | |
| *** dtantsur is now known as dtantsur|brb | 12:21 | |
| *** gcb_ has joined #openstack-ironic | 12:24 | |
| *** athomas has joined #openstack-ironic | 12:27 | |
| *** jkilpatr has joined #openstack-ironic | 12:29 | |
| *** vikrant has quit IRC | 12:29 | |
| *** e0ne has quit IRC | 12:39 | |
| *** pc_m has quit IRC | 12:42 | |
| nicodemos | morning, ironic. | 12:45 |
| *** pc_m has joined #openstack-ironic | 12:50 | |
| *** aparnav has quit IRC | 12:50 | |
| *** hw_wutianwei has quit IRC | 12:51 | |
| *** trown|outtypewww is now known as trown | 12:51 | |
| *** gcb_ has quit IRC | 12:52 | |
| *** amoralej is now known as amoralej|lunch | 12:55 | |
| *** ijw has joined #openstack-ironic | 12:56 | |
| *** dtantsur|brb is now known as dtantsur | 12:59 | |
| *** yufei has joined #openstack-ironic | 12:59 | |
| *** ijw has quit IRC | 13:00 | |
| *** yufei has joined #openstack-ironic | 13:01 | |
| *** jheroux has joined #openstack-ironic | 13:03 | |
| TheJulia | good morning everyone | 13:05 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 13:06 |
| _milan_ | morning nicodemos, TheJulia! :) | 13:07 |
| *** lucas-hungry is now known as lucasagomes | 13:07 | |
| *** moshele has quit IRC | 13:09 | |
| ricardoas | morning nicodemos, TheJulia, _milan_ | 13:10 |
| _milan_ | ricardoas, morning! :) | 13:11 |
| *** bfournie has quit IRC | 13:12 | |
| TheJulia | dtantsur: When you have a free minute to discuss auth parameters :) | 13:13 |
| dtantsur | TheJulia, not this second, unfortunately :( but this is not blocking from my pov, as soon as you're fine with it | 13:13 |
| TheJulia | dtantsur: no worries | 13:13 |
| TheJulia | dtantsur: and okay, I left you a detailed comment in the review for when you have time | 13:15 |
| *** e0ne has joined #openstack-ironic | 13:15 | |
| lucasagomes | TheJulia, morning | 13:18 |
| *** yufei has quit IRC | 13:18 | |
| TheJulia | Good morning lucasagomes | 13:18 |
| *** mrtenio-afk is now known as mrtenio | 13:22 | |
| mrtenio | Morning all | 13:22 |
| *** yufei has joined #openstack-ironic | 13:22 | |
| TheJulia | Good morning | 13:23 |
| xavierr | $ morning --all | 13:25 |
| *** snecklifter has joined #openstack-ironic | 13:26 | |
| vdrok | morning nicodemos TheJulia mrtenio and xavierr | 13:27 |
| snecklifter | Hello, I appear to be unable to move a node out of inspecting state | 13:28 |
| snecklifter | abort doesn't work | 13:29 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Make $IRONIC_IMAGE_NAME less dependent of the name in DevStack https://review.openstack.org/410753 | 13:29 |
| *** yufei has quit IRC | 13:29 | |
| *** hw_wutianwei has joined #openstack-ironic | 13:30 | |
| *** daemontool_ has quit IRC | 13:30 | |
| *** chlong has quit IRC | 13:32 | |
| TheJulia | good morning vdrok | 13:34 |
| TheJulia | xavierr: ++ | 13:34 |
| *** ohamada_ has joined #openstack-ironic | 13:36 | |
| *** ohamada has quit IRC | 13:36 | |
| _milan_ | morning xavierr! :) | 13:36 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add a possibility to send sensors data in standalone mode https://review.openstack.org/410760 | 13:38 |
| *** lindycoder has joined #openstack-ironic | 13:39 | |
| *** moshele has joined #openstack-ironic | 13:39 | |
| mrtenio | snecklifter, Are you using ironic --ironic-api-version=1.22? | 13:42 |
| snecklifter | mrtenio: no, this is OSP 9 so 1.9 I think | 13:43 |
| *** yufei has joined #openstack-ironic | 13:43 | |
| mrtenio | snecklifter, what is the error message? | 13:45 |
| dtantsur | snecklifter, node-set-provision-state abort is not implemented for inspection | 13:45 |
| dtantsur | snecklifter, I think you can force it by $ openstack baremetal introspection abort UUID | 13:45 |
| openstackgerrit | Merged openstack/ironic-inspector: Add author and author-email in setup.cfg https://review.openstack.org/410508 | 13:45 |
| snecklifter | dtantsur: that did it, thanks, i assumed that using node-set-provision-state would move it out as well as into inspecting | 13:47 |
| *** bfournie has joined #openstack-ironic | 13:47 | |
| dtantsur | it's just not implemented yet | 13:47 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Keystone session for swift-temp-url generation https://review.openstack.org/410764 | 13:49 |
| snecklifter | dtantsur: right ok, maybe hide command in OSP 9 | 13:49 |
| *** Goneri has joined #openstack-ironic | 13:50 | |
| *** srobert has joined #openstack-ironic | 13:53 | |
| nicodemos | vdrok. Can I do that in a follow up patch? | 13:53 |
| *** baoli has joined #openstack-ironic | 13:55 | |
| *** Goneri has quit IRC | 13:55 | |
| *** Goneri has joined #openstack-ironic | 13:55 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Migrate to session for glance client https://review.openstack.org/410767 | 13:58 |
| *** krtaylor has joined #openstack-ironic | 13:59 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Migrate to session for glance client https://review.openstack.org/410767 | 14:01 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Keystone session for swift-temp-url generation https://review.openstack.org/410764 | 14:02 |
| *** sacharya has joined #openstack-ironic | 14:03 | |
| vdrok | nicodemos: you mean moving oneview client initialization to the driver? | 14:03 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: ETAGs maintenance for all api node's requests https://review.openstack.org/392213 | 14:03 |
| nicodemos | vdrok: yeah | 14:04 |
| *** fragatina has joined #openstack-ironic | 14:04 | |
| vdrok | nicodemos: dunno, why do it twice? if you agree that's better, I'd prefer the same change. as it is code with tests, not some nit in docs or reno | 14:05 |
| *** glonlas has joined #openstack-ironic | 14:06 | |
| *** amoralej|lunch is now known as amoralej | 14:07 | |
| *** rloo has joined #openstack-ironic | 14:07 | |
| nicodemos | vdrok: ok. =D | 14:08 |
| *** sacharya has quit IRC | 14:08 | |
| *** fragatina has quit IRC | 14:09 | |
| TheJulia | nicodemos: vdrok: I commented on that as well, I think it is good as-is | 14:11 |
| *** hw_wutianwei has quit IRC | 14:11 | |
| xavierr | TheJulia: indeed | 14:11 |
| *** hw_wutianwei has joined #openstack-ironic | 14:12 | |
| nicodemos | TheJulia: ack | 14:13 |
| vdrok | TheJulia: but it's not about picking interfaces? If we have oneview hardware we need to have oneview client anyway right? Even if eg only power interface is oneview. So after driver composition, we could just define the client once in hardware type object, instead of the driver object | 14:13 |
| vdrok | with driver composition, we'll still be accessing task.driver.oneview_client no matter if it is a hw type or a classic driver. so no changes to the oneview/* modules. | 14:15 |
| TheJulia | vdrok: I think it would get more complex than that. The interfaces upon init would essentially have to establish an overall client, which they might be able to do cleanly and not break anything. | 14:15 |
| *** hw_wutianwei1 has joined #openstack-ironic | 14:16 | |
| *** hw_wutianwei has quit IRC | 14:16 | |
| *** hw_wutianwei1 is now known as hw_wutianwei | 14:16 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Migrate to session for glance client https://review.openstack.org/410767 | 14:16 |
| TheJulia | since task.driver.x comes from the driver loader interface | 14:16 |
| TheJulia | s/interface/factory/ | 14:17 |
| vdrok | TheJulia: yes, but I can't get why to do it in every interface instead of instantiating it once in hw type/ classic driver constructor | 14:17 |
| TheJulia | Well, this is a significant improvement over what they were doing too. I think we need to land the improvement, and let them iterate. | 14:18 |
| TheJulia | Besides, the assembly once you start breaking up the interfaces might be a little brain breaking, unless we kept oneview_client as more of a common interface, but it is a single driver too. | 14:19 |
| vdrok | TheJulia: like for now, add it to __init__ here - https://github.com/openstack/ironic/blob/master/ironic/drivers/oneview.py. ah, for composition, looking at the current code, that should not go into hw type itself, it could be added dynamically on request it seems | 14:21 |
| vdrok | ok, I just don't like reviewing basically the same code twice :) | 14:21 |
| TheJulia | hehe | 14:21 |
| TheJulia | I don't blame you there, nor do I. | 14:22 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/python-ironicclient: Fix exception message creation in get_client() https://review.openstack.org/410778 | 14:23 |
| *** dprince has joined #openstack-ironic | 14:24 | |
| xavierr | so, nicodemos may procede with the patch as it is now, is that ok for you TheJulia and vdrok? :) | 14:27 |
| *** jcoufal has joined #openstack-ironic | 14:27 | |
| vdrok | xavierr: well, I don't particularly like that, so won't +A, but if others are OK with it I'm fine too :) | 14:28 |
| TheJulia | vdrok: fair enough :) | 14:30 |
| xavierr | vdrok: understood, ty :) | 14:32 |
| *** srobert has quit IRC | 14:34 | |
| rloo | hi and morning all, xavierr, TheJulia, vdrok | 14:35 |
| TheJulia | Good morning rloo | 14:35 |
| vdrok | morning rloo | 14:35 |
| vdrok | rloo: yuriyz wanted to discuss the notifications stuff, he'll be here in ~1.5 hours, but I guess we'll need mariojv/JayF too :) | 14:36 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Make $IRONIC_IMAGE_NAME less dependent of the name in DevStack https://review.openstack.org/410753 | 14:36 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode https://review.openstack.org/374988 | 14:36 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Remove check for UEFI + Whole disk images https://review.openstack.org/410784 | 14:36 |
| *** hshiina has quit IRC | 14:36 | |
| rloo | vdrok: ok. i'd like to discuss so he isn't blocked. i think we should use start/end/error for crud :) (but yeah, discuss when the others are here) | 14:37 |
| *** snecklifter has quit IRC | 14:42 | |
| xavierr | rloo: morning :) | 14:43 |
| *** moshele has quit IRC | 14:44 | |
| *** moshele has joined #openstack-ironic | 14:45 | |
| mariojv | hivdrok - i'll be around | 14:46 |
| *** gcb has joined #openstack-ironic | 14:47 | |
| *** glonlas has quit IRC | 14:47 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Allow diskless nodes thru a configuration option https://review.openstack.org/326620 | 14:47 |
| dtantsur | morning rloo, xavierr, TheJulia | 14:47 |
| rloo | morning dtantsur | 14:47 |
| *** causten has joined #openstack-ironic | 14:48 | |
| *** glonlas has joined #openstack-ironic | 14:48 | |
| *** glonlas has quit IRC | 14:49 | |
| *** glonlas has joined #openstack-ironic | 14:49 | |
| *** rbudden has joined #openstack-ironic | 14:51 | |
| vdrok | FYI: reno jobs broken until https://review.openstack.org/410792 lands | 14:52 |
| patchbot | patch 410792 - reno - support removed stable branches | 14:52 |
| *** mtanino has joined #openstack-ironic | 14:52 | |
| dhellmann | vdrok : if you want to, in the short term, remove the liberty file | 14:53 |
| dhellmann | it may be some time before the series in front of that fix can be fully reviewed, because it depends on a pretty big rewrite of reno's internals | 14:53 |
| *** yufei has quit IRC | 14:53 | |
| vdrok | dhellmann: ok, gotcha, thanks. | 14:54 |
| dhellmann | vdrok : you could also change the stable/liberty value to liberty-eol | 14:54 |
| dhellmann | that may be the simplest, since that should also work with the new reno | 14:54 |
| vdrok | dhellmann: oh, that's the better way I think :) | 14:55 |
| vdrok | doing | 14:55 |
| dhellmann | vdrok : let me know if that works, please. Maybe follow-up to the -dev thread "Tagging liberty as EOL"? | 14:55 |
| vdrok | dhellmann: will do | 14:56 |
| *** glonlas_ has joined #openstack-ironic | 14:56 | |
| *** glonlas__ has joined #openstack-ironic | 14:56 | |
| *** glonlas_ has quit IRC | 14:56 | |
| rloo | dtantsur: are you going to push up another patch set for 336626 soon (i was going to continue reviewing it) | 14:56 |
| rloo | dtantsur: or are you waiting for answers? :) | 14:57 |
| dtantsur | rloo, I am. I can wait or push it in a few minutes, whatever is more convenient for you. | 14:57 |
| *** links has quit IRC | 14:57 | |
| rloo | dtantsur: push it | 14:57 |
| dtantsur | k | 14:57 |
| *** glonlas has quit IRC | 14:58 | |
| *** eroux has joined #openstack-ironic | 14:59 | |
| lucasagomes | hi, if someone has some time mind taking a look at https://review.openstack.org/#/c/409755/ ? I've marked it as high prio for virtualbmc because it hide errors and might lead to a deployment failure if an action fails and Ironic don't retry | 14:59 |
| patchbot | patch 409755 - virtualbmc - Return proper errors on BMC action failures | 14:59 |
| lucasagomes | cheers :-) | 14:59 |
| *** causten has quit IRC | 15:00 | |
| vdrok | dhellmann: leaving only :branch: liberty-eol seems to work | 15:01 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Draft https://review.openstack.org/410798 | 15:01 |
| *** yufei has joined #openstack-ironic | 15:02 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Support defining and loading hardware types https://review.openstack.org/336626 | 15:02 |
| dtantsur | rloo, ^^^ | 15:02 |
| *** causten has joined #openstack-ironic | 15:02 | |
| rloo | dtantsur: thx! | 15:02 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Change liberty's reno page to use the tag https://review.openstack.org/410798 | 15:03 |
| *** lindycoder has quit IRC | 15:07 | |
| *** causten has quit IRC | 15:10 | |
| *** gcb has quit IRC | 15:14 | |
| *** gcb has joined #openstack-ironic | 15:14 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 15:16 |
| _milan_ | morning rloo! :) | 15:18 |
| *** wajdi has quit IRC | 15:18 | |
| *** wajdi has joined #openstack-ironic | 15:18 | |
| rloo | hi _milan_. Are you hiding in _.._? :) | 15:18 |
| _milan_ | rloo, exactly :D | 15:18 |
| *** _milan_ is now known as milan | 15:18 | |
| milan | rloo, the thing is there's already some milan in Freenode | 15:19 |
| * milan needs to figure out new nick :-/ | 15:19 | |
| rloo | milan: :( so are you really the milan that we know? | 15:19 |
| milan | * and register it with NickServ | 15:19 |
| *** gcb has quit IRC | 15:20 | |
| *** wajdi_ has joined #openstack-ironic | 15:20 | |
| milan | rloo, I hope so the other nick doesn't appear in Ironic | 15:20 |
| milan | but it makes my client frustrated from time to time while connecting to Freenode :-/ | 15:20 |
| rloo | milan: hmm, seems like something an imposter milan would say... ;) | 15:21 |
| *** chlong has joined #openstack-ironic | 15:21 | |
| milan | rloo, exactly, I'm sort of a Shroedinger's milan now | 15:21 |
| milan | :D | 15:21 |
| rloo | welcome to ironic, Shroedinger's milan! | 15:22 |
| milan | rloo, thx :D | 15:22 |
| *** wajdi has quit IRC | 15:22 | |
| * lucasagomes thinks about changing his IRC name as well, he owns "lcs" on freenode | 15:23 | |
| *** milan is now known as [milan] | 15:23 | |
| [milan] | rloo, wdyt my new nick? ;) | 15:23 |
| [milan] | lucasagomes, I share your pain, but no worries, we imposters trust each other, right ;) | 15:25 |
| lucasagomes | that's right :D | 15:25 |
| vdrok | [milan]: maybe mln for consistency? "D | 15:27 |
| patchbot | Error: No closing quotation | 15:27 |
| vdrok | ouch | 15:27 |
| vdrok | consistency with lucasagomes :) | 15:27 |
| lucasagomes | ++ and shorter | 15:27 |
| [milan] | vdrok, heh, yeah, so everyone can tell we're the imposters right away | 15:27 |
| * vdrok going vldslv | 15:28 | |
| [milan] | and it's hipster too :) | 15:28 |
| lucasagomes | lol | 15:28 |
| [milan] | vdrok, ++ :D | 15:28 |
| NobodyCam | Good Morning Ironic'ers | 15:29 |
| vdrok | morning NobodyCam | 15:29 |
| [milan] | morning NobodyCam! :) | 15:29 |
| lucasagomes | NobodyCam, morning | 15:29 |
| NobodyCam | Morning vdrok [milan] lucasagomes :) | 15:29 |
| *** baoli has quit IRC | 15:29 | |
| *** hecliunyx_ has quit IRC | 15:30 | |
| *** ohamada__ has joined #openstack-ironic | 15:33 | |
| *** ohamada_ has quit IRC | 15:33 | |
| dtantsur | morning NobodyCam | 15:35 |
| dtantsur | [milan], I suggest iMilan :D | 15:35 |
| NobodyCam | morning dtantsur :) | 15:35 |
| NobodyCam | :) | 15:35 |
| [milan] | dtantsur, lol | 15:35 |
| [milan] | sure | 15:35 |
| *** glonlas__ has quit IRC | 15:36 | |
| *** glonlas has joined #openstack-ironic | 15:37 | |
| *** glonlas has quit IRC | 15:37 | |
| *** fragatina has joined #openstack-ironic | 15:37 | |
| *** glonlas has joined #openstack-ironic | 15:37 | |
| *** fragatina has quit IRC | 15:37 | |
| *** fragatina has joined #openstack-ironic | 15:38 | |
| TheJulia | Good morning NobodyCam | 15:39 |
| NobodyCam | Good Morning TheJulia :) | 15:40 |
| *** lindycoder has joined #openstack-ironic | 15:40 | |
| rloo | morning NobodyCam | 15:41 |
| NobodyCam | Good Morning rloo :) | 15:41 |
| rloo | [milan]: you seem to like being enclosed. It makes me uncomfortable; i want you to be free | 15:41 |
| *** causten has joined #openstack-ironic | 15:42 | |
| [milan] | rloo, thanks I want to break free! | 15:42 |
| *** [milan] is now known as miLan | 15:43 | |
| miLan | come on NickServ! | 15:43 |
| rloo | dtantsur: wrt hardware_types.py. can we move FakeHardware to fake_hardware.py? | 15:43 |
| NobodyCam | hehehe | 15:43 |
| *** miLan is now known as iMilan | 15:44 | |
| iMilan | wow | 15:44 |
| iMilan | dtantsur, you were right again :D | 15:44 |
| *** rama_y_ has joined #openstack-ironic | 15:44 | |
| *** iMilan is now known as ]milan[ | 15:45 | |
| ]milan[ | that's even more narrow | 15:45 |
| ]milan[ | damn | 15:45 |
| *** ]milan[ is now known as milan | 15:46 | |
| *** rama_y has quit IRC | 15:46 | |
| NobodyCam | lol | 15:46 |
| milan | it's good to be my old imposters me O:-) | 15:46 |
| dtantsur | rloo, I'll check if we actually can move it to fake.py | 15:46 |
| dtantsur | I think my old argument about not moving it there is no longer valid | 15:46 |
| *** NobodyCam is now known as WeAreAllMiLan | 15:46 | |
| openstackgerrit | Merged openstack/python-ironicclient: Fix exception message creation in get_client() https://review.openstack.org/410778 | 15:46 |
| milan | WeAreAllMiLan, +1000 :D | 15:47 |
| WeAreAllMiLan | :p | 15:47 |
| dtantsur | OMG :D | 15:47 |
| rloo | dtantsur: ok. although i looked at fake and it has a lot of stuff there, i'd be fine if it wasn't with all those drivers. | 15:47 |
| dtantsur | well, creating a new file for a tiny class does not look right too... dunno :) | 15:47 |
| milan | dtantsur, call it iFakeHardware.py for greater good :P | 15:48 |
| *** WeAreAllMiLan is now known as NobodyCam | 15:48 | |
| TheJulia | lol | 15:48 |
| dtantsur | milan, then we have to make sure it can work with your mac ;) | 15:48 |
| NobodyCam | :) | 15:48 |
| milan | that's probably the only thing that will :D | 15:49 |
| *** rama_y_ has quit IRC | 15:49 | |
| *** Sukhdev has joined #openstack-ironic | 15:50 | |
| *** soliosg has quit IRC | 15:50 | |
| rloo | dtantsur: oh, i don't care about the size of the file. just thinking of the organization of the files. | 15:50 |
| lucasagomes | until you update to the new pro and the iMilan port is removed | 15:50 |
| *** jkilpatr_ has joined #openstack-ironic | 15:50 | |
| dtantsur | haha | 15:50 |
| lucasagomes | iDongleMilan | 15:51 |
| *** ralonsoh_ has joined #openstack-ironic | 15:51 | |
| milan | lucasagomes, sure :D but I bet there's gonna be some iMposter interface | 15:51 |
| *** ralonsoh has quit IRC | 15:51 | |
| milan | iMPoster | 15:51 |
| *** jkilpatr has quit IRC | 15:52 | |
| *** trown is now known as trown|outtypewww | 15:52 | |
| *** milan is now known as iMPoster | 15:52 | |
| iMPoster | NickSrv seriously!?!?!? | 15:52 |
| *** iMPoster is now known as milan | 15:52 | |
| * dtantsur suspects it's Friday somehow | 15:52 | |
| TheJulia | dtantsur: That is what it feels like.... | 15:52 |
| milan | ~TGIF | 15:52 |
| dtantsur | TGINF | 15:53 |
| dtantsur | Nearly Friday | 15:53 |
| *** yufei has left #openstack-ironic | 15:54 | |
| *** causten has quit IRC | 15:56 | |
| *** fragatina has quit IRC | 15:58 | |
| pas-ha | dtantsur: lucasagomes vdrok https://review.openstack.org/#/c/410828/ | 16:00 |
| patchbot | patch 410828 - requirements - Add ironic-staging-drivers to projects | 16:00 |
| lucasagomes | pas-ha, will take a look, in a meeting right now | 16:00 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add portgroup configuration fields https://review.openstack.org/398417 | 16:01 |
| pas-ha | np, just should enable requirements sync for staging drivers | 16:01 |
| openstackgerrit | octopuszhang proposed openstack/ironic: Update multitenancy docs https://review.openstack.org/397517 | 16:01 |
| rloo | dtantsur: ok, i think i reviewed/commented on 336626. just that my comments are spread between patch sets 26 & 27. | 16:01 |
| *** Syed__ has joined #openstack-ironic | 16:02 | |
| dtantsur | rloo, k, will check (renaming files now) | 16:02 |
| rloo | dtantsur: thx. gonna try to get this done today! | 16:02 |
| dtantsur | yep | 16:02 |
| *** srobert has joined #openstack-ironic | 16:03 | |
| *** sacharya has joined #openstack-ironic | 16:04 | |
| *** causten has joined #openstack-ironic | 16:05 | |
| *** Romanenko_K has quit IRC | 16:08 | |
| *** sacharya has quit IRC | 16:08 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add portgroup configuration fields https://review.openstack.org/398417 | 16:11 |
| *** jvgrant has quit IRC | 16:11 | |
| *** jvgrant has joined #openstack-ironic | 16:11 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 16:12 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface RPC APIs https://review.openstack.org/404239 | 16:12 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface Driver APIs https://review.openstack.org/327046 | 16:12 |
| *** eroux has quit IRC | 16:13 | |
| *** rcernin has quit IRC | 16:14 | |
| *** moshele has quit IRC | 16:15 | |
| *** swatson has joined #openstack-ironic | 16:17 | |
| *** Goneri has quit IRC | 16:18 | |
| *** zackf has joined #openstack-ironic | 16:18 | |
| *** yuriyz|2 has joined #openstack-ironic | 16:19 | |
| *** glonlas_ has joined #openstack-ironic | 16:19 | |
| *** jaosorior has quit IRC | 16:20 | |
| *** jaosorior has joined #openstack-ironic | 16:20 | |
| *** zackf has quit IRC | 16:22 | |
| *** glonlas has quit IRC | 16:22 | |
| *** mjura has quit IRC | 16:23 | |
| *** Goneri has joined #openstack-ironic | 16:25 | |
| *** zackf has joined #openstack-ironic | 16:26 | |
| *** vsaienko has joined #openstack-ironic | 16:27 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 16:27 | |
| *** glonlas_ has quit IRC | 16:28 | |
| *** Linkmark has joined #openstack-ironic | 16:30 | |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-inspector: Update documentation to deploy Ironic Inspector with DevStack https://review.openstack.org/410456 | 16:30 |
| *** zackf has quit IRC | 16:30 | |
| *** zackf has joined #openstack-ironic | 16:30 | |
| *** glonlas has joined #openstack-ironic | 16:31 | |
| *** causten has quit IRC | 16:32 | |
| *** causten has joined #openstack-ironic | 16:33 | |
| *** soliosg has joined #openstack-ironic | 16:34 | |
| JayF | whiteboard updated; all known gate issues resolved | 16:35 |
| TheJulia | \o/ | 16:35 |
| dtantsur | \o/ | 16:37 |
| *** rama_y has joined #openstack-ironic | 16:37 | |
| *** vsaienko has quit IRC | 16:38 | |
| vdrok | mariojv: JayF yuriyz|2 ping, are you all here? :) | 16:39 |
| rloo | thx JayF! | 16:39 |
| yuriyz|2 | here hello to all | 16:39 |
| JayF | I'm here | 16:39 |
| JayF | and I know mariojv is lurking | 16:39 |
| rloo | hi yuriyz|2, JayF, vdrok, lurking mariojv | 16:39 |
| vdrok | hey rloo :) | 16:39 |
| rloo | i vote for crud .start/end/error notifications. anything else to discuss? :) | 16:40 |
| vdrok | yuriyz|2: so, fire up your thoughts :) | 16:40 |
| yuriyz|2 | agree with rloo this make all consistent at least | 16:40 |
| rloo | for all those paying attention, we're talking about https://review.openstack.org/#/c/410640/ | 16:41 |
| patchbot | patch 410640 - ironic-specs - Update notifications specs | 16:41 |
| rloo | JayF, vdrok, mariojv: you good with that? | 16:41 |
| JayF | I don't have any objection. | 16:42 |
| *** rpioso has joined #openstack-ironic | 16:42 | |
| vdrok | I don't object. | 16:42 |
| rloo | yuriyz|2: wrt when the .start starts, i was thinking it could start at the beginning of the method, not after we check some stuff in the API. | 16:42 |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Moving Reboot bashscript to python https://review.openstack.org/372478 | 16:43 |
| vdrok | all of those apart from .end will be ignored by searchlight tho, is that correct yuriyz|2 ? | 16:43 |
| lucasagomes | pas-ha, thanks for including stanging there :-) | 16:43 |
| lucasagomes | +1'd | 16:43 |
| yuriyz|2 | rloo we can prepare payload only after instantiate object | 16:44 |
| rloo | JayF: wrt .error, do you think the notification system/end user wants to know about user errors (wrt the API request) or only errors within ironic? | 16:44 |
| rloo | yuriyz|2: oh | 16:44 |
| JayF | rloo: when I've modeled this in monitoring systems in the past, I basically counted 5xx as a system error | 16:44 |
| JayF | rloo: and a 4xx as a user error | 16:44 |
| JayF | rloo: so I'd think 5xx should generate an err, and 4xx should not | 16:44 |
| yuriyz|2 | vdrok "start" will be ignored not "end" | 16:44 |
| JayF | rloo: except for us, we overuse 409 conflict, and knowing a node is always locked is maybe useful? but probably not worth the complexity of singling it out | 16:45 |
| *** chlong has quit IRC | 16:45 | |
| rloo | JayF: ok, that's good to know. i think that aligns with what yuriyz|2 did. | 16:45 |
| vdrok | yuriyz|2: yes, but error is going to be ignored too right? | 16:45 |
| yuriyz|2 | and "error" for crud operations because resourse not changed | 16:45 |
| mariojv | i'm here | 16:45 |
| vdrok | exactly | 16:45 |
| mariojv | reading scrollback | 16:45 |
| rloo | JayF: that 409 thing. we should have fixed that :-( | 16:45 |
| mariojv | i'm fine with start/end/error for CRUD in api notifications | 16:46 |
| *** rcernin has joined #openstack-ironic | 16:46 | |
| mariojv | for the issue with the full object not being available yet | 16:46 |
| mariojv | maybe we can just have a separate payload for .start | 16:46 |
| mariojv | if certain things aren't available | 16:46 |
| mariojv | or, leave some fields empty | 16:47 |
| mariojv | and then have the full(er) object in error or end | 16:47 |
| mariojv | thoughts? ^ | 16:47 |
| yuriyz|2 | there is a limitation as I mentioned because all wants base payload we can send notify only after res obj instantiated | 16:47 |
| yuriyz|2 | I can try change patch for sending start early as possible | 16:48 |
| *** jaosorior has quit IRC | 16:48 | |
| rloo | mariojv: i think it is OK to do the .start after instantiation (it is instantiation not .save) | 16:48 |
| *** jaosorior has joined #openstack-ironic | 16:48 | |
| mariojv | i see, you need a full objects.Chassis or objects.Port | 16:49 |
| yuriyz|2 | agree because validation fail is user error | 16:49 |
| mariojv | that makes sense | 16:49 |
| mariojv | i'm fine with that | 16:49 |
| rloo | vdrok: would you mind updating the spec patch, or would you like one of us to do it? | 16:49 |
| vdrok | a bit busy at the moment, but can do in an hour or so | 16:50 |
| mariojv | so does that mean everything's changing to start/end/error? | 16:50 |
| mariojv | and that's the update required? | 16:50 |
| rloo | vdrok: works for me | 16:51 |
| vdrok | mariojv: I suppose so | 16:51 |
| mariojv | s/everything/everything in CRUD | 16:51 |
| yuriyz|2 | vdrok, please update the spec patch, I will change the code | 16:51 |
| rloo | mariojv: in the crud. we still keep .success in the power stuff | 16:51 |
| mariojv | yuriyz|2: agree? ^T | 16:51 |
| mariojv | right rloo | 16:51 |
| yuriyz|2 | agree | 16:51 |
| mariojv | ok, sounds good | 16:51 |
| mariojv | thanks all | 16:51 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Remove check for UEFI + Whole disk images https://review.openstack.org/410784 | 16:51 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode https://review.openstack.org/374988 | 16:51 |
| vdrok | OK, that was easy :D | 16:51 |
| JayF | o/ ty all | 16:51 |
| rloo | thx! | 16:51 |
| *** Linkmark has quit IRC | 16:51 | |
| *** Nisha_Agarwal has quit IRC | 16:53 | |
| openstackgerrit | Merged openstack/ironic: Fix error when system uses /usr/bin/qemu-kvm, as in CentOS 7.2. https://review.openstack.org/410052 | 16:54 |
| openstackgerrit | Merged openstack/ironic: Clarify the comment about the object hashes https://review.openstack.org/410479 | 16:54 |
| openstackgerrit | Merged openstack/ironic: Change liberty's reno page to use the tag https://review.openstack.org/410798 | 16:55 |
| vdrok | lucasagomes: reno job fix merged ^^ | 16:57 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Support defining and loading hardware types https://review.openstack.org/336626 | 16:57 |
| vdrok | so yeah, safe to recheck | 16:57 |
| dtantsur | rloo, I hope I haven't missed anything. hard to track comments over several patchsets ^^^ | 16:57 |
| lucasagomes | vdrok, oh! I just rechecked something, I didn't know it was broken broken | 16:57 |
| *** fragatina has joined #openstack-ironic | 16:57 | |
| lucasagomes | vdrok, thanks! | 16:58 |
| rloo | dtantsur: yeah, sorry about that. i debated about whether to carry the comments forward or not. thx for the update. will look in a few minutes. | 16:58 |
| *** chlong has joined #openstack-ironic | 16:58 | |
| nicodemos | hey JayF, now that the gate its ok, can you +A again? https://review.openstack.org/#/c/358041 | 16:59 |
| patchbot | patch 358041 - ironic - Reusing oneview_client when possible | 16:59 |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Add python API and CLI for port groups https://review.openstack.org/335964 | 16:59 |
| *** dsneddon has joined #openstack-ironic | 16:59 | |
| JayF | man it's all green | 17:00 |
| JayF | including third party CI | 17:00 |
| JayF | that might be one of the first times I've seen that | 17:00 |
| JayF | lol | 17:00 |
| nicodemos | hehehhe | 17:00 |
| *** rajinir has joined #openstack-ironic | 17:00 | |
| lucasagomes | w00t | 17:00 |
| xavierr | \o/ | 17:02 |
| *** sacharya has joined #openstack-ironic | 17:05 | |
| *** e0ne has quit IRC | 17:11 | |
| mariojv | is anyone familiar with this test code? https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/network/test_flat.py | 17:12 |
| mariojv | i'm curious why CONF.neutron.cleaning_network isn't just None | 17:12 |
| mariojv | some of the tests would fail if that was the case | 17:13 |
| *** causten has quit IRC | 17:14 | |
| rloo | dtantsur: i'm good with 336626, except for one thing. don't know if you missed my comment: https://review.openstack.org/#/c/336626/26..28/ironic/common/driver_factory.py | 17:14 |
| patchbot | patch 336626 - ironic - Support defining and loading hardware types | 17:14 |
| rloo | dtantsur: for check_and_update_node_interfaces(), do we really need to pass driver_or_hw_type? or can we just figure it out from node.driver | 17:15 |
| *** causten has joined #openstack-ironic | 17:15 | |
| mariojv | well, i guess it is None, looking at some print debugging output | 17:16 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Comment on when the TinyCore mirror list was generated https://review.openstack.org/410873 | 17:16 |
| rloo | mariojv: you figured it out (cuz i don't want to look) | 17:17 |
| mariojv | actually, it's not None, it gets randomly generated on every run | 17:17 |
| mariojv | not yet rloo | 17:17 |
| mariojv | i thought it might come from the port's internal info somehow, but i don't know how that could possibly set the config option | 17:18 |
| *** jpich has quit IRC | 17:18 | |
| mariojv | found it | 17:18 |
| *** fragatina has quit IRC | 17:19 | |
| mariojv | happens way up here in the base classes: https://github.com/openstack/ironic/blob/master/ironic/tests/base.py#L122 | 17:19 |
| mariojv | rloo: figured it out ^ | 17:19 |
| rloo | mariojv: :) | 17:20 |
| JayF | sometimes all you have to do is cry out to irc, and the answer comes to you even without help | 17:20 |
| JayF | lol | 17:20 |
| mariojv | yep | 17:21 |
| *** bdeschenes has joined #openstack-ironic | 17:21 | |
| mariojv | the world is my rubber duck | 17:21 |
| rloo | JayF: it is positive energy from the community. like 'i hope he figures it out so i don't feel obliged to look into it' :) | 17:21 |
| mariojv | https://en.wikipedia.org/wiki/Rubber_duck_debugging | 17:21 |
| *** jkilpatr_ has quit IRC | 17:24 | |
| *** fragatina has joined #openstack-ironic | 17:25 | |
| dtantsur | rloo, forgot to post a response. did now. | 17:26 |
| *** causten has quit IRC | 17:27 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Probe for TC mirror during tinyipa build https://review.openstack.org/410404 | 17:27 |
| *** causten has joined #openstack-ironic | 17:28 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic-specs: Update notifications specs https://review.openstack.org/410640 | 17:28 |
| rloo | dtantsur: thx | 17:28 |
| vdrok | rloo: mariojv yuriyz|2 ^^ tried to make it clear | 17:28 |
| vdrok | and, it's time to leave for me | 17:28 |
| vdrok | good night! | 17:29 |
| mariojv | cool i will review | 17:29 |
| mariojv | night vdrok | 17:29 |
| rloo | thx and good night vdrok! | 17:29 |
| lucasagomes | folks, I'm calling it a day | 17:30 |
| rloo | dtantsur: you got your +2 :) | 17:30 |
| lucasagomes | have a great evening all | 17:30 |
| rloo | bye lucasagomes! | 17:30 |
| lucasagomes | see ya :-) | 17:30 |
| *** lucasagomes is now known as lucas-afk | 17:30 | |
| dtantsur | rloo, woohoo! thanks :) | 17:31 |
| *** aNuposic has joined #openstack-ironic | 17:31 | |
| dtantsur | now looking for volunteers for a potential second +2 :) TheJulia, vdrok? | 17:31 |
| dtantsur | (pinging you two because you've already looked at https://review.openstack.org/336626) | 17:31 |
| patchbot | patch 336626 - ironic - Support defining and loading hardware types | 17:32 |
| JayF | I've been looking at that too, even if not voting | 17:32 |
| vdrok | ugh, dtantsur will try to look at home and digest the changes | 17:32 |
| dtantsur | heh | 17:32 |
| JayF | dtantsur: my only question about that is a doozy | 17:33 |
| mariojv | vdrok: put a conditional +1 there based on yuriyz|2 's review | 17:33 |
| JayF | dtantsur: is it a good idea to merge a patch that adds a crapload of config options that do absolutely nothing right now/ | 17:33 |
| JayF | dtantsur: in the past we've tended to block those patches until the "useful" part comes in | 17:33 |
| rloo | JayF: I wondered about that too. | 17:33 |
| vdrok | mariojv: right, it's dropped on the ironic searchlight plugin side | 17:34 |
| dtantsur | JayF, I seem some sense in it, but I also can't imagine actually finishing the driver composition if we pile all things first | 17:34 |
| vdrok | gone for real now :) | 17:34 |
| JayF | Yeah. | 17:34 |
| mariojv | cool vdrok | 17:34 |
| rloo | JayF: did we block those in the past? I couldn't remember. | 17:34 |
| JayF | Is it worthwhile to maybe add something to the config option description | 17:34 |
| JayF | that says "these are currently not function" | 17:34 |
| JayF | or something like that? | 17:34 |
| JayF | so that an operator deploying an intermediate ironic sha would know they are noop right now | 17:34 |
| *** bdeschenes has quit IRC | 17:34 | |
| dtantsur | JayF, it's not that they don't function.. they do, you just cannot see their effect | 17:34 |
| JayF | From an operator standpoint, there's absolutely no difference | 17:35 |
| dtantsur | ok, let's look at this from the following standpoint: what's the harm of operator trying to set them to something? | 17:35 |
| JayF | I'm thinking more, as someone who has deployed master in the poast | 17:36 |
| *** baoli has joined #openstack-ironic | 17:36 | |
| rloo | dtantsur: why not add something like JayF mentioned, to indicate that they shouldn't be used yet. | 17:36 |
| JayF | if I see all those new config options come up, I'm going to go down a research-rabbithole to see what good they do | 17:36 |
| JayF | and come up really confused at worse, annoyed at best when I figure it out | 17:36 |
| rloo | dtantsur: it won't hurt, it could help, and we can remove it later when it is actually useful. | 17:36 |
| dtantsur | ok, lemme come up with something | 17:37 |
| rloo | dtantsur, JayF: i don't think we mention the configs or anything in the release notes so it might be confusing. | 17:37 |
| rloo | JayF: what wording would you suggest? :) | 17:37 |
| *** jkilpatr_ has joined #openstack-ironic | 17:37 | |
| *** vsaienko has joined #openstack-ironic | 17:37 | |
| rloo | JayF: although it might mess with how dtantsur coded the help strings for all those configs. but he can figure it out. | 17:37 |
| JayF | "This configuration option is part of the incomplete driver composition work. Changing it's setting has no effect." | 17:38 |
| *** glonlas has quit IRC | 17:38 | |
| JayF | at the top of the config help fro all the added options | 17:38 |
| rloo | dtantsur: ^^. s/it's/its/ | 17:38 |
| JayF | gah | 17:38 |
| dtantsur | k | 17:38 |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Moving Reboot bashscript to python https://review.openstack.org/372478 | 17:41 |
| *** AlexeyAbashkin has quit IRC | 17:41 | |
| JayF | lucas-afk: ^ I think aslezil fixed all your issues with that patch, if you're still around to vote on it | 17:43 |
| *** led_ has quit IRC | 17:44 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Support defining and loading hardware types https://review.openstack.org/336626 | 17:48 |
| dtantsur | JayF, rloo, like this ^^^? | 17:48 |
| *** yuriyz|2 has quit IRC | 17:48 | |
| JayF | dtantsur: except you missed enabled_hardware_types | 17:48 |
| dtantsur | damn... gimme a second | 17:48 |
| rloo | dtantsur: don't forget to update .sample | 17:50 |
| dtantsur | sure | 17:50 |
| rloo | dtantsur: i'm even fine if you put the warning and no description of how the config works :) | 17:50 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Support defining and loading hardware types https://review.openstack.org/336626 | 17:51 |
| dtantsur | well, I did it with descriptions already :) not sure if it looks fancy, but it works | 17:51 |
| rloo | dtantsur: +2 (again) | 17:53 |
| dtantsur | cool! | 17:53 |
| dtantsur | I'll call it a day soon. JayF, could you please check the wording before I go? | 17:53 |
| JayF | the warning looks good | 17:54 |
| *** jaosorior has quit IRC | 17:54 | |
| JayF | I'll likely vote +2 unless something major changed | 17:54 |
| dtantsur | awesome | 17:54 |
| JayF | but would rather another core vote as well as this gets on the edges of what I'm good at :) | 17:54 |
| dtantsur | yeah, sure. would be cool to get TheJulia to review it, this affects her volume work | 17:54 |
| TheJulia | dtantsur: I can look shortly, just need to pull my brain out of unit tests. | 17:55 |
| dtantsur | yeah, no hurry | 17:55 |
| dtantsur | I'll anyway address any new comments tomorrow | 17:55 |
| JayF | have a good night dmitry, hopefully you get a patch merged for christmas | 17:56 |
| JayF | (well, and better stuff, as that's a somewhat lame gift) | 17:56 |
| dtantsur | haha, thanks :) | 17:56 |
| *** dtantsur is now known as dtantsur|afk | 17:56 | |
| *** Sukhdev has quit IRC | 17:59 | |
| *** vsaienko has quit IRC | 18:02 | |
| *** ralonsoh_ has quit IRC | 18:04 | |
| *** athomas has quit IRC | 18:05 | |
| JayF | Gate is going to be broken | 18:08 |
| JayF | reno bug relating to EOL'd branches | 18:08 |
| JayF | I'm updating whiteboard | 18:08 |
| JayF | aslezil: ^ why your patch failed ci | 18:08 |
| *** derekh has quit IRC | 18:09 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add Cinder storage driver https://review.openstack.org/366197 | 18:10 |
| JayF | https://bugs.launchpad.net/reno/+bug/1649982 is the relevant bug | 18:10 |
| openstack | Launchpad bug 1649982 in reno "reno doesn't check for an -eol tag when a stable branch is deleted" [Wishlist,Fix committed] - Assigned to Doug Hellmann (doug-hellmann) | 18:10 |
| JayF | seeing if we should workaround right now or if the release will get out quick enough | 18:10 |
| openstackgerrit | Merged openstack/ironic: Reusing oneview_client when possible https://review.openstack.org/358041 | 18:14 |
| *** e0ne has joined #openstack-ironic | 18:15 | |
| *** milan has quit IRC | 18:16 | |
| openstackgerrit | Merged openstack/ironic: Fix return values in OneView deploy interface https://review.openstack.org/396698 | 18:16 |
| openstackgerrit | Merged openstack/python-ironicclient: Add more tests to node_shell https://review.openstack.org/410100 | 18:16 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Use liberty-eol tag for liberty release notes https://review.openstack.org/410898 | 18:18 |
| JayF | ^ fixes the IPA gate | 18:18 |
| JayF | it looks like ironic is not impacted | 18:18 |
| *** vsaienko has joined #openstack-ironic | 18:19 | |
| JayF | rloo: TheJulia ^ if you have a moment, would love to unclog the IPA gate | 18:19 |
| *** jkilpatr_ has quit IRC | 18:20 | |
| *** david-lyle has quit IRC | 18:21 | |
| *** jkilpatr has joined #openstack-ironic | 18:22 | |
| TheJulia | JayF: +2'ed | 18:23 |
| JayF | pas-ha: ^^ that patch fixes IPA gate | 18:29 |
| JayF | pas-ha: the failure of releasenotes on your patch | 18:29 |
| jlvillal | JayF: +2 +A | 18:29 |
| pas-ha | ack, thanks for the info | 18:29 |
| *** vinsh has joined #openstack-ironic | 18:29 | |
| * JayF playing gate whackamole this morning | 18:30 | |
| *** david-lyle has joined #openstack-ironic | 18:30 | |
| jlvillal | Thanks JayF! Much appreciated :) | 18:30 |
| JayF | it's enjoyable, I really don't mind, lol | 18:30 |
| TheJulia | Very much appreciated, thank you JayF | 18:30 |
| JayF | just don't make me write a giant driver comp patch like dmitry did | 18:30 |
| JayF | lol | 18:30 |
| rloo | JayF: sorry, was in a meeting. Looks like it is all good now | 18:31 |
| TheJulia | JayF: heh | 18:31 |
| * TheJulia suspects there is a decent video reply to JayF enticing him to write a giant driver comp like patch somewhere on youtube | 18:32 | |
| *** glonlas has joined #openstack-ironic | 18:32 | |
| *** ohamada__ has quit IRC | 18:32 | |
| openstackgerrit | Anup Navare proposed openstack/ironic: Allow logical name along with UUID in port creation https://review.openstack.org/405586 | 18:34 |
| jlvillal | JayF: If you can look at: https://review.openstack.org/#/c/410910/ it would be appreciated. | 18:34 |
| patchbot | patch 410910 - openstack-infra/project-config - ironic.yaml: Remove stable/liberty specific checks | 18:34 |
| openstackgerrit | Merged openstack/ironic-python-agent: Use liberty-eol tag for liberty release notes https://review.openstack.org/410898 | 18:35 |
| *** vsaienko has quit IRC | 18:44 | |
| *** e0ne has quit IRC | 18:44 | |
| *** ijw has joined #openstack-ironic | 18:45 | |
| jlvillal | JayF: On that liberty-eol thing. Do you want to propose a patch for ironic-inspector too? | 18:46 |
| JayF | oh sure I can | 18:46 |
| *** vsaienko has joined #openstack-ironic | 18:46 | |
| JayF | I checked ironic and client, forgot inspector :-x | 18:46 |
| *** e0ne has joined #openstack-ironic | 18:47 | |
| jlvillal | JayF: Awesome. Thanks. | 18:47 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-inspector: Use liberty-eol tag for liberty release notes https://review.openstack.org/410917 | 18:47 |
| JayF | jlvillal: TheJulia: ^ if you wanna land that one too | 18:47 |
| *** vsaienko has quit IRC | 18:48 | |
| *** ijw has quit IRC | 18:50 | |
| *** ijw has joined #openstack-ironic | 18:56 | |
| *** ijw has quit IRC | 18:57 | |
| *** ijw has joined #openstack-ironic | 18:58 | |
| jlvillal | JayF: +2 +A, I'm trusting the gate | 19:00 |
| jlvillal | JayF: Looks like you are fixing a broken gate there :) https://review.openstack.org/#/c/348943/ | 19:00 |
| patchbot | patch 348943 - ironic-inspector - Introducing node introspection state management | 19:00 |
| openstackgerrit | Aparna proposed openstack/proliantutils: Add Sanitize disk erase support using SSA https://review.openstack.org/398202 | 19:01 |
| *** ijw has quit IRC | 19:04 | |
| *** cdearborn has joined #openstack-ironic | 19:04 | |
| * TheJulia wonders where the morning went | 19:05 | |
| *** pester has joined #openstack-ironic | 19:05 | |
| jlvillal | TheJulia: I think Hawaii stole it ;) | 19:07 |
| jlvillal | Yep 9am in Hawaii | 19:07 |
| TheJulia | I feel the need to send an expeditionary force to investigate this.... | 19:07 |
| *** fxpester has quit IRC | 19:08 | |
| TheJulia | jlvillal: I suspect Maui would be a good place for this investigation to take place. | 19:10 |
| *** amoralej is now known as amoralej|off | 19:11 | |
| jlvillal | TheJulia: ++! | 19:12 |
| * TheJulia wonders if there is a OGG <-> SYD route.... | 19:12 | |
| openstackgerrit | Merged openstack/ironic-inspector: Use liberty-eol tag for liberty release notes https://review.openstack.org/410917 | 19:14 |
| TheJulia | Drat! No direct flights | 19:15 |
| mrtenio | JayF, this patch you just landed, is the failing "gate-ironic-releasenotes" related to it? | 19:18 |
| JayF | yes | 19:19 |
| *** Sukhdev has joined #openstack-ironic | 19:20 | |
| openstackgerrit | Merged openstack/python-ironicclient: Describe possible exception in docstring https://review.openstack.org/410253 | 19:21 |
| *** vsaienko has joined #openstack-ironic | 19:23 | |
| mrtenio | JayF, Thank you :) | 19:24 |
| *** vsaienko has quit IRC | 19:27 | |
| nicodemos | quick review: https://review.openstack.org/#/c/337751/ :) | 19:31 |
| patchbot | patch 337751 - ironic - Add support for the OneView audit logging | 19:31 |
| *** e0ne has quit IRC | 19:31 | |
| *** vsaienko has joined #openstack-ironic | 19:34 | |
| *** jkilpatr has quit IRC | 19:34 | |
| *** fragatina has quit IRC | 19:35 | |
| *** fragatina has joined #openstack-ironic | 19:36 | |
| *** vsaienko has quit IRC | 19:36 | |
| *** fragatina has quit IRC | 19:38 | |
| openstackgerrit | Merged openstack/bifrost: Fix bifrost install playbook README: default value https://review.openstack.org/410492 | 19:43 |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Default keystone to uuid tokens https://review.openstack.org/407231 | 19:49 |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Add keystone to git contents download https://review.openstack.org/407215 | 19:49 |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Correct inspector keystone endpoint name https://review.openstack.org/407245 | 19:50 |
| *** jkilpatr has joined #openstack-ironic | 19:53 | |
| *** cdearborn has quit IRC | 19:57 | |
| *** ChubYann has joined #openstack-ironic | 20:05 | |
| *** srobert has quit IRC | 20:07 | |
| *** pester has quit IRC | 20:10 | |
| JayF | https://review.openstack.org/#/c/398989/ + the patch following it are both in really good shape, and could use a review+approval | 20:12 |
| patchbot | patch 398989 - ironic-python-agent - Use oslo-config-generator for sample config | 20:12 |
| JayF | well, the follow on patch needs some love | 20:14 |
| JayF | but that one is good | 20:14 |
| *** cdearborn has joined #openstack-ironic | 20:14 | |
| *** causten has quit IRC | 20:16 | |
| *** Goneri has quit IRC | 20:16 | |
| *** rbartal has quit IRC | 20:16 | |
| *** causten has joined #openstack-ironic | 20:16 | |
| *** moshele has joined #openstack-ironic | 20:18 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Comment on when the TinyCore mirror list was generated https://review.openstack.org/410873 | 20:21 |
| *** aNuposic has quit IRC | 20:24 | |
| TheJulia | JayF: On my list for later today | 20:25 |
| *** hw_wutianwei1 has joined #openstack-ironic | 20:32 | |
| *** hw_wutianwei has quit IRC | 20:33 | |
| *** hw_wutianwei1 is now known as hw_wutianwei | 20:33 | |
| *** pcaruana has quit IRC | 20:33 | |
| *** rm_work has quit IRC | 20:34 | |
| *** rm_work has joined #openstack-ironic | 20:34 | |
| *** moshele has quit IRC | 20:36 | |
| *** e0ne has joined #openstack-ironic | 20:40 | |
| *** e0ne has quit IRC | 20:42 | |
| mrda | Morning Ironic | 20:46 |
| *** dprince has quit IRC | 20:57 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add Cinder storage driver https://review.openstack.org/366197 | 20:58 |
| openstackgerrit | Merged openstack/ironic-specs: Update notifications specs https://review.openstack.org/410640 | 21:01 |
| openstackgerrit | Merged openstack/ironic: Support defining and loading hardware types https://review.openstack.org/336626 | 21:03 |
| *** jkilpatr has quit IRC | 21:07 | |
| *** aNuposic has joined #openstack-ironic | 21:11 | |
| *** vsaienko has joined #openstack-ironic | 21:12 | |
| *** glonlas_ has joined #openstack-ironic | 21:14 | |
| *** glonlas has quit IRC | 21:17 | |
| *** r-daneel has joined #openstack-ironic | 21:20 | |
| *** jkilpatr has joined #openstack-ironic | 21:22 | |
| TheJulia | Good morning mrda | 21:23 |
| *** vsaienko has quit IRC | 21:31 | |
| mrda | hi TheJulia | 21:36 |
| *** glonlas_ has quit IRC | 21:36 | |
| *** Goneri has joined #openstack-ironic | 21:38 | |
| *** glonlas has joined #openstack-ironic | 21:39 | |
| *** glonlas has quit IRC | 21:39 | |
| *** glonlas has joined #openstack-ironic | 21:40 | |
| *** milan has joined #openstack-ironic | 21:43 | |
| *** cdearborn has quit IRC | 21:43 | |
| *** glonlas has quit IRC | 21:44 | |
| *** glonlas has joined #openstack-ironic | 21:45 | |
| *** cdearborn has joined #openstack-ironic | 21:49 | |
| openstackgerrit | Merged openstack/virtualbmc: Add support for a "global" configuration file https://review.openstack.org/406916 | 21:50 |
| mariojv | rloo: hey - the RFE on ceph configdrive support has been approved, if you'd like to remove your -2 on https://review.openstack.org/#/c/407639/ | 21:52 |
| patchbot | patch 407639 - ironic - Configdrive support for Ceph | 21:52 |
| *** [1]rpioso has joined #openstack-ironic | 21:56 | |
| *** glonlas has quit IRC | 21:56 | |
| *** rpioso has quit IRC | 21:58 | |
| *** glonlas has joined #openstack-ironic | 22:00 | |
| *** glonlas has quit IRC | 22:01 | |
| *** glonlas has joined #openstack-ironic | 22:01 | |
| *** e0ne has joined #openstack-ironic | 22:02 | |
| *** glonlas has quit IRC | 22:02 | |
| *** glonlas has joined #openstack-ironic | 22:02 | |
| rloo | mariojv: thx for the reminder! | 22:03 |
| mariojv | thanks rloo | 22:04 |
| *** jcoufal has quit IRC | 22:05 | |
| *** cdearborn has quit IRC | 22:14 | |
| *** vsaienko has joined #openstack-ironic | 22:26 | |
| *** e0ne has quit IRC | 22:31 | |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Use liberty-eol tag for liberty release notes https://review.openstack.org/410986 | 22:38 |
| *** rbudden has quit IRC | 22:38 | |
| JayF | Question for the channel: if a patch I authored was backported to stable by someone else, should I +2 it? | 22:39 |
| JayF | (Asking about ^^^ that gate fix specificially) | 22:40 |
| *** cdearborn has joined #openstack-ironic | 22:40 | |
| jlvillal | JayF, I think it is okay. Maybe not you be the +A. I don't know. But since only you and dtantsur|afk are around this week to approve stable fixes I say go for it. | 22:40 |
| JayF | tonyb: around yet? ^ 410986 fixes the IPA gate if you can take a look and approve it | 22:42 |
| tonyb | JayF: on a call, I'll look at it when it's done | 22:42 |
| *** baoli has quit IRC | 22:44 | |
| *** rama_y has quit IRC | 22:45 | |
| rloo | JayF: go for it. I gave my +1 blessing too :) Anyway, i think everyone knows that reno is broken. | 22:47 |
| rloo | JayF: although, it isn't 'urgent', is it? | 22:47 |
| JayF | I mean, we have stable/newton patches failing the gate | 22:47 |
| JayF | nothing can merge in IPA stable/newton until that goes in | 22:47 |
| JayF | anytime the gate is broken I consider it urgent b/c IDK when we might haev some kind of urgent security fix to make | 22:48 |
| rloo | JayF: yeah, but unless we're planning on doing a newton release it can wait a day? | 22:48 |
| rloo | JayF: maybe. 'urgent' security fixes seem to take more than a day to get through whatever process we have so still enough time. but i don't know enough about this. | 22:49 |
| JayF | Everything can wait however long it needs to wait? If you don't want me to +2 I can change it to a +1. I just don't generally like waiting on simple things that fix stuff | 22:50 |
| *** vsaienko has quit IRC | 22:51 | |
| JayF | rloo: the only stable cores on ironic are me/dmitry/ptl(jim, obviously) | 22:51 |
| rloo | JayF: oh, your +2 is fine. Just wondering if it can wait for dmitry tomorrow instead of pinging someone else. | 22:51 |
| *** vsaienko has joined #openstack-ironic | 22:52 | |
| JayF | rloo: I wouldn't have ping'd Tony if he hadn't told me in the past he doesn't mind :) | 22:52 |
| rloo | JayF: ah, in that case... :) | 22:52 |
| *** hw_wutianwei has quit IRC | 22:55 | |
| tonyb | JayF: I think devananda is still stable core, plus you can lean on the stable-maint team in a pinch | 23:00 |
| tonyb | JayF: +W'd | 23:00 |
| *** cdearborn has quit IRC | 23:01 | |
| *** jheroux has quit IRC | 23:02 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Use liberty-eol tag for liberty release notes https://review.openstack.org/410986 | 23:03 |
| *** rama_y has joined #openstack-ironic | 23:04 | |
| *** rcernin has quit IRC | 23:05 | |
| *** bfournie has quit IRC | 23:06 | |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Moving Reboot bashscript to python https://review.openstack.org/372478 | 23:08 |
| *** rama_y has quit IRC | 23:10 | |
| *** trown|outtypewww has quit IRC | 23:12 | |
| *** trown has joined #openstack-ironic | 23:14 | |
| *** mtanino has quit IRC | 23:15 | |
| *** mtanino has joined #openstack-ironic | 23:15 | |
| *** vsaienko has quit IRC | 23:16 | |
| *** jschwarz has quit IRC | 23:16 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 23:20 |
| *** jschwarz has joined #openstack-ironic | 23:21 | |
| *** ijw has joined #openstack-ironic | 23:22 | |
| jlvillal | JayF, TheJulia Regarding: https://review.openstack.org/372478 Please let me know if I am being dumb on my comment. | 23:26 |
| patchbot | patch 372478 - ironic-python-agent - Moving Reboot bashscript to python | 23:26 |
| * jlvillal often gets confused by lambda... | 23:27 | |
| JayF | jlvillal: I honestly don't know either, but it raises the error from the method which is why I thought it was fine | 23:27 |
| JayF | aslezil: ^ idk if that was something already there or something you added | 23:27 |
| jlvillal | JayF, I think it was already there. | 23:27 |
| jlvillal | JayF, I guess I would like to have it be simple as I don't see any other usage of lambda in the file. | 23:28 |
| jlvillal | JayF, And it always takes extra processing power plug Google searches for me to understand lambda ;) | 23:28 |
| jlvillal | s/plug/plus/ | 23:28 |
| aslezil | JayF it was already there | 23:29 |
| jlvillal | aslezil, Would you mind trying my suggested change and see if it works. I think it will make the tests easier to understand. | 23:30 |
| jlvillal | aslezil, I think it will work. | 23:30 |
| aslezil | Sure jlvillal I will make the change requested | 23:30 |
| jlvillal | aslezil, Thank you | 23:31 |
| jlvillal | aslezil, Ping me if you have questions | 23:31 |
| JayF | aslezil: jlvillal I made the change locally | 23:31 |
| JayF | give me all of 2 minutes and I'll let you know if it passes | 23:31 |
| aslezil | sure jlvilla | 23:31 |
| JayF | without taxing the gate | 23:31 |
| jlvillal | Thanks JayF | 23:32 |
| * JayF wonders if somehow python on his dev vm is hosed | 23:34 | |
| JayF | whoa | 23:36 |
| JayF | without the lambda, the exception throws | 23:36 |
| JayF | and isn't quashed by the assertRaises | 23:36 |
| JayF | jlvillal: aslezil: https://gist.github.com/jayofdoom/ba8bcb552a1aff0b0c37caf225dc98b4 | 23:36 |
| aslezil | jlvillal it throws error | 23:36 |
| JayF | that's the right exception it should be looking for | 23:36 |
| JayF | but self.assertRaises doesn't gobble it up | 23:36 |
| jlvillal | JayF, Can you do a pastebin/gist of your diff? | 23:37 |
| *** chlong has quit IRC | 23:37 | |
| * jlvillal doesn't understand why he can't find a USB flash drive when he needs one. | 23:38 | |
| *** rama_y has joined #openstack-ironic | 23:39 | |
| *** bfournie has joined #openstack-ironic | 23:40 | |
| jlvillal | JayF, aslezil: This worked for me: http://paste.openstack.org/show/592404/ | 23:45 |
| *** baoli has joined #openstack-ironic | 23:46 | |
| *** milan has quit IRC | 23:47 | |
| aslezil | jlvilla: JayF: http://stackoverflow.com/questions/6103825/how-to-properly-use-unit-testings-assertraises-with-nonetype-objects | 23:48 |
| aslezil | your are correct jlvillal: | 23:48 |
| aslezil | we could write both ways | 23:48 |
| jlvillal | aslezil, Correct both ways "work". But using lambda increases the complexity for the reader of the code. | 23:49 |
| jlvillal | In my opinion. | 23:49 |
| *** [1]rpioso has quit IRC | 23:50 | |
| aslezil | I will upload the patch now jlvillal: | 23:50 |
| jlvillal | Thanks | 23:50 |
| JayF | Man I like that context manager syntax | 23:51 |
| JayF | I wish I had known that exists, that's great | 23:51 |
| *** ppiela has quit IRC | 23:51 | |
| JayF | aslezil: jfyi there's more than just that one test that needs it | 23:51 |
| *** awiddersheim has joined #openstack-ironic | 23:52 | |
| jlvillal | JayF, Oh yeah, that could be useful. I vaguely remember reading about using: with self.assertRaises(): | 23:52 |
| jlvillal | But then forgot about it... | 23:52 |
| JayF | I really like context manager syntax in python | 23:52 |
| jlvillal | +1 | 23:53 |
| jlvillal | JayF, And the contextlib library is nice to make your own contextmanager's | 23:53 |
| JayF | Yeah; I believe we use that for metrics | 23:53 |
| *** aNuposic has quit IRC | 23:53 | |
| *** lindycoder has quit IRC | 23:56 | |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Moving Reboot bashscript to python https://review.openstack.org/372478 | 23:56 |
| JayF | oh, that's an even better fix than we talked about here | 23:58 |
| JayF | jlvillal: ^ | 23:58 |
| jlvillal | JayF, looking | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!