| JayF | jlvillal: the gerrit monster is going to get you, it's 00:00 UTC | 00:00 |
|---|---|---|
| jlvillal | JayF, Thanks! | 00:00 |
| jlvillal | JayF, I will wait a few minutes before putting the +2/+A on it | 00:00 |
| JayF | awesome | 00:00 |
| JayF | nice catch | 00:00 |
| jlvillal | JayF, I prefer if I don't have to think too hard when reading code :) | 00:01 |
| JayF | I always just think of lambdas, maybe somewhat wrongly, as a giant pair of parenthesis | 00:01 |
| JayF | isolating those bits from everything else | 00:02 |
| aslezil | he he | 00:02 |
| JayF | my overly-simplistic view of it in most cases probably is why it doesn't read as complex to me | 00:02 |
| jlvillal | JayF, I always get them sort of confused. And seem to always google about them to refresh my memory | 00:02 |
| JayF | but that only was needed because assertRaises was being used wrong :x | 00:02 |
| jlvillal | aslezil, Would you like credit for that patch in Stackalytics? | 00:03 |
| jlvillal | aslezil, I'm not sure it will understand your Co-Authored-By line | 00:04 |
| jlvillal | aslezil, No space between name and <email_address> | 00:04 |
| JayF | ooh, missing whitespace | 00:04 |
| JayF | jlvillal: we all know that stackalytics doesn't matter, riiiight? :P | 00:04 |
| JayF | jlvillal: I'm just going to fix it | 00:04 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Moving Reboot bashscript to python https://review.openstack.org/372478 | 00:05 |
| *** baoli has quit IRC | 00:05 | |
| JayF | jlvillal: ^ fixed and reapplied my +2 | 00:05 |
| jlvillal | And +2/+A from me | 00:05 |
| aslezil | thanks JayF and jlvillal | 00:06 |
| jlvillal | aslezil, You're welcome | 00:06 |
| *** dsneddon has quit IRC | 00:06 | |
| JayF | now tomorrow you get to fix mikal's favorite bug | 00:07 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: [WIP / POC] Add Intel Node Manager sensor data collection https://review.openstack.org/410465 | 00:07 |
| JayF | assuming you don't have anything else going on | 00:07 |
| aslezil | JayF: Thats my next task also test biosdevname package of tinycorelinux on physical server | 00:09 |
| JayF | I don't think that reboot in chroot bug will be hard to fix, tbh | 00:10 |
| *** [1]rpioso has joined #openstack-ironic | 00:12 | |
| *** hw_wutianwei has joined #openstack-ironic | 00:14 | |
| *** ijw has quit IRC | 00:21 | |
| *** ijw has joined #openstack-ironic | 00:21 | |
| *** ijw has quit IRC | 00:26 | |
| *** glonlas has quit IRC | 00:31 | |
| *** [1]rpioso has quit IRC | 00:35 | |
| *** cdearborn has joined #openstack-ironic | 00:37 | |
| *** ijw has joined #openstack-ironic | 00:42 | |
| *** Syed__ has quit IRC | 00:45 | |
| *** causten has quit IRC | 00:46 | |
| *** ijw has quit IRC | 00:48 | |
| *** ijw has joined #openstack-ironic | 00:53 | |
| *** SerenaFeng has joined #openstack-ironic | 00:54 | |
| *** fragatina has joined #openstack-ironic | 00:55 | |
| *** phuongnh has joined #openstack-ironic | 00:59 | |
| *** rloo has quit IRC | 01:00 | |
| *** rama_y has quit IRC | 01:10 | |
| *** ijw has quit IRC | 01:24 | |
| *** ijw has joined #openstack-ironic | 01:25 | |
| *** mtan_____ has joined #openstack-ironic | 01:26 | |
| *** mtanino has quit IRC | 01:27 | |
| *** zhangjl has joined #openstack-ironic | 01:28 | |
| *** SerenaFeng has quit IRC | 01:30 | |
| *** mtan_____ has quit IRC | 01:31 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Moving Reboot bashscript to python https://review.openstack.org/372478 | 01:40 |
| *** pleia2 has left #openstack-ironic | 01:59 | |
| *** jkilpatr has quit IRC | 02:08 | |
| *** ijw has quit IRC | 02:19 | |
| *** Sukhdev has quit IRC | 02:22 | |
| *** gabriel-bezerra has quit IRC | 02:22 | |
| *** gabriel-bezerra has joined #openstack-ironic | 02:24 | |
| *** Goneri has quit IRC | 02:26 | |
| *** ijw has joined #openstack-ironic | 02:31 | |
| *** SerenaFeng has joined #openstack-ironic | 02:36 | |
| *** SerenaFeng has quit IRC | 02:37 | |
| *** SerenaFeng has joined #openstack-ironic | 02:38 | |
| *** tuanluong has joined #openstack-ironic | 02:59 | |
| *** rbudden has joined #openstack-ironic | 02:59 | |
| *** harlowja has quit IRC | 03:03 | |
| *** zhangjl has left #openstack-ironic | 03:13 | |
| *** r-daneel has quit IRC | 03:38 | |
| *** SerenaFeng has quit IRC | 03:40 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/411059 | 03:48 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/411060 | 03:48 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/411079 | 03:54 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/411080 | 03:55 |
| *** Nisha_Agarwal has joined #openstack-ironic | 04:02 | |
| *** links has joined #openstack-ironic | 04:06 | |
| *** ccamacho has quit IRC | 04:09 | |
| *** vikrant has joined #openstack-ironic | 04:11 | |
| *** vsaienko has joined #openstack-ironic | 04:16 | |
| *** vsaienko has quit IRC | 04:18 | |
| *** Sukhdev has joined #openstack-ironic | 04:26 | |
| *** rbudden has quit IRC | 04:32 | |
| *** ijw has quit IRC | 04:51 | |
| *** ChubYann has quit IRC | 04:59 | |
| *** ChubYann has joined #openstack-ironic | 05:03 | |
| *** lindycoder has joined #openstack-ironic | 05:17 | |
| *** lindycoder has quit IRC | 05:24 | |
| *** ChubYann has quit IRC | 05:25 | |
| *** bks has joined #openstack-ironic | 05:25 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Using base64 module from oslo_serialization https://review.openstack.org/411106 | 05:29 |
| *** ChubYann has joined #openstack-ironic | 05:31 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/python-ironicclient: Using base64 module from oslo_serialization https://review.openstack.org/411111 | 05:36 |
| *** ijw_ has joined #openstack-ironic | 05:39 | |
| *** dhellmann has quit IRC | 05:39 | |
| *** Sukhdev has quit IRC | 05:39 | |
| *** dhellmann has joined #openstack-ironic | 05:39 | |
| *** rbudden has joined #openstack-ironic | 05:42 | |
| *** ijw_ has quit IRC | 05:44 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Using base64 module from oslo_serialization https://review.openstack.org/411117 | 05:44 |
| *** moshele has joined #openstack-ironic | 05:45 | |
| *** moshele has quit IRC | 05:48 | |
| openstackgerrit | octopuszhang proposed openstack/ironic: Update multitenancy docs https://review.openstack.org/397517 | 05:54 |
| *** fragatina has quit IRC | 05:55 | |
| *** SerenaFeng has joined #openstack-ironic | 06:01 | |
| *** ijw has joined #openstack-ironic | 06:01 | |
| *** Nisha_Agarwal has quit IRC | 06:02 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-lib: Using base64 module from oslo_serialization https://review.openstack.org/411124 | 06:02 |
| *** Nisha_Agarwal has joined #openstack-ironic | 06:02 | |
| *** ijw has quit IRC | 06:06 | |
| *** trananhkma has joined #openstack-ironic | 06:09 | |
| *** rbudden has quit IRC | 06:10 | |
| openstackgerrit | paresh sao proposed openstack/ironic: Boot from iSCSI volume https://review.openstack.org/308425 | 06:11 |
| *** Nisha_Agarwal is now known as Nisha_ | 06:16 | |
| *** jaosorior has joined #openstack-ironic | 06:16 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-python-agent: Using base64 module from oslo_serialization https://review.openstack.org/411131 | 06:24 |
| *** e0ne has joined #openstack-ironic | 06:34 | |
| *** e0ne has quit IRC | 06:44 | |
| *** rajinir has quit IRC | 06:46 | |
| *** vsaienko has joined #openstack-ironic | 06:53 | |
| *** ChubYann has quit IRC | 06:56 | |
| *** mjura has joined #openstack-ironic | 07:08 | |
| *** rcernin has joined #openstack-ironic | 07:13 | |
| *** mjura has quit IRC | 07:14 | |
| *** mjura has joined #openstack-ironic | 07:15 | |
| *** vsaienko has quit IRC | 07:23 | |
| *** e0ne has joined #openstack-ironic | 07:35 | |
| *** jaosorior has quit IRC | 07:37 | |
| *** jaosorior has joined #openstack-ironic | 07:37 | |
| *** zhugaoxiao has quit IRC | 07:39 | |
| *** zhugaoxiao has joined #openstack-ironic | 07:39 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/python-ironicclient: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411111 | 07:41 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-lib: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411124 | 07:43 |
| *** milan has joined #openstack-ironic | 07:44 | |
| *** rbartal has joined #openstack-ironic | 07:45 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: https://review.openstack.org/411117 | 07:45 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411117 | 07:46 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-python-agent: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411131 | 07:47 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411106 | 07:47 |
| *** moshele has joined #openstack-ironic | 07:51 | |
| *** nicodemos has quit IRC | 07:54 | |
| *** nicodemos has joined #openstack-ironic | 07:54 | |
| *** jaosorior has quit IRC | 07:55 | |
| *** Nisha_ has quit IRC | 07:57 | |
| openstackgerrit | Tovin Seven proposed openstack/ironic: Enable OSProfiler support in Ironic https://review.openstack.org/358142 | 07:59 |
| aarefiev | Good morning! | 08:03 |
| milan | morning aarefiev! :) | 08:04 |
| aarefiev | hey milan | 08:04 |
| *** Nisha_Agarwal has joined #openstack-ironic | 08:04 | |
| milan | aarefiev, dtantsur|afk gave the states patch +2 with 2 significant "nits" which I've fixed yesterday so this should be good to go ;) | 08:05 |
| aarefiev | milan: nice, I'll take a look | 08:06 |
| milan | aarefiev, thanks! :) | 08:07 |
| tuanluong | Morning Ironic | 08:07 |
| *** soliosg has quit IRC | 08:10 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-python-agent: [POC] BitTorrent image provisioning https://review.openstack.org/404120 | 08:13 |
| openstackgerrit | Anton Arefiev proposed openstack/ironic: [POC]: Torrent provisioning https://review.openstack.org/409711 | 08:14 |
| *** ccamacho has joined #openstack-ironic | 08:15 | |
| aarefiev | morning tuanluong | 08:16 |
| tuanluong | Morning aarefiev milan | 08:16 |
| milan | morning tuanluong! :) | 08:16 |
| *** vsaienko has joined #openstack-ironic | 08:18 | |
| vdrok | good morning ironic, aarefiev milan and tuanluong ! | 08:19 |
| tuanluong | morning vdrok | 08:19 |
| milan | morning vdrok! :) | 08:19 |
| aarefiev | morning vdrok | 08:21 |
| *** eroux has joined #openstack-ironic | 08:27 | |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Add python API and CLI for port groups https://review.openstack.org/335964 | 08:29 |
| *** jaosorior has joined #openstack-ironic | 08:30 | |
| pas-ha | morning all :) | 08:31 |
| *** fragatina has joined #openstack-ironic | 08:33 | |
| vdrok | morning pas-ha | 08:35 |
| *** pcaruana has joined #openstack-ironic | 08:37 | |
| *** fragatina has quit IRC | 08:37 | |
| *** ohamada has joined #openstack-ironic | 08:40 | |
| tuanluong | mroning pas-ha | 08:40 |
| *** ralonsoh has joined #openstack-ironic | 08:48 | |
| milan | morning pas-ha! :) | 08:49 |
| *** ralonsoh has quit IRC | 08:50 | |
| pas-ha | morning vdrok milan tuanluong | 08:50 |
| *** amoralej|off is now known as amoralej | 08:51 | |
| *** ralonsoh has joined #openstack-ironic | 08:51 | |
| *** vinsh has quit IRC | 08:53 | |
| *** vinsh has joined #openstack-ironic | 08:53 | |
| * milan relocates | 08:53 | |
| *** milan has quit IRC | 08:53 | |
| *** jpich has joined #openstack-ironic | 08:55 | |
| *** ohamada has quit IRC | 08:56 | |
| *** ohamada has joined #openstack-ironic | 08:56 | |
| *** vsaienko has quit IRC | 08:56 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-ironic | 09:00 | |
| *** moshele has quit IRC | 09:03 | |
| *** athomas has joined #openstack-ironic | 09:04 | |
| *** fxpester has joined #openstack-ironic | 09:14 | |
| *** yufei has joined #openstack-ironic | 09:18 | |
| yufei | hi, vdork, I see your comments at https://review.openstack.org/#/c/397517/， how about this sentence: Spawning instances by non-admin users in these networks and getting access to ironic control plane is a security risk. | 09:21 |
| patchbot | patch 397517 - ironic - Update multitenancy docs | 09:21 |
| openstackgerrit | paresh sao proposed openstack/ironic: Boot from iSCSI volume https://review.openstack.org/308425 | 09:22 |
| *** moshele has joined #openstack-ironic | 09:24 | |
| *** e0ne has quit IRC | 09:24 | |
| openstackgerrit | octopuszhang proposed openstack/ironic: Update multitenancy docs https://review.openstack.org/397517 | 09:25 |
| *** e0ne has joined #openstack-ironic | 09:25 | |
| *** e0ne has quit IRC | 09:26 | |
| *** e0ne has joined #openstack-ironic | 09:26 | |
| *** e0ne has quit IRC | 09:26 | |
| *** e0ne has joined #openstack-ironic | 09:27 | |
| *** e0ne has quit IRC | 09:27 | |
| *** dtantsur|afk is now known as dtantsur | 09:29 | |
| dtantsur | morning Ironic | 09:29 |
| yufei | morning, dtantsur: | 09:30 |
| *** moshele has quit IRC | 09:35 | |
| *** tovin07_ has joined #openstack-ironic | 09:35 | |
| *** moshele has joined #openstack-ironic | 09:36 | |
| *** eroux has quit IRC | 09:36 | |
| tovin07_ | Hello, I see we face this one https://bugs.launchpad.net/reno/+bug/1649982 | 09:37 |
| openstack | Launchpad bug 1649982 in reno "reno doesn't check for an -eol tag when a stable branch is deleted" [Wishlist,Fix committed] - Assigned to Doug Hellmann (doug-hellmann) | 09:37 |
| tovin07_ | It causes all gate-ironic-releasenotes fails | 09:37 |
| dtantsur | yep, we're slowly backporting the fixes | 09:39 |
| * tovin07_ hope someone will fix it soon | 09:40 | |
| dtantsur | and as you see, the bug is fixed as well, so new reno should not have these problems | 09:40 |
| * dtantsur too :) | 09:40 | |
| aarefiev | morning dtantsur, we also need your eyes on :) https://review.openstack.org/#/c/410606/ | 09:41 |
| patchbot | patch 410606 - ironic-inspector (stable/newton) - Remove upgrade from non-ironic setup | 09:41 |
| tuanluong | morning dtantsur tovin07_ yufei | 09:41 |
| dtantsur | aarefiev, approved | 09:41 |
| aarefiev | thx | 09:41 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Introduce generic hardware types https://review.openstack.org/400678 | 09:47 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: [WIP] Load hardware types in the conductor https://review.openstack.org/409812 | 09:48 |
| openstackgerrit | Sofiia Andriichenko proposed openstack/ironic: This adds a tempest tests for creating a node: https://review.openstack.org/411197 | 09:48 |
| *** lucas-afk is now known as lucasagomes | 09:49 | |
| lucasagomes | good morning all! | 09:49 |
| dtantsur | hey lucasagomes | 09:49 |
| *** zhugaoxiao has quit IRC | 09:50 | |
| *** zhugaoxiao has joined #openstack-ironic | 09:51 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411117 | 09:51 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 09:52 |
| aarefiev | morning lucasagomes | 09:52 |
| *** swatson has quit IRC | 09:52 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-lib: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411124 | 09:54 |
| *** milan has joined #openstack-ironic | 09:58 | |
| vdrok | morning dtantsur and lucasagomes | 09:58 |
| dtantsur | o/ | 09:59 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-lib: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411124 | 09:59 |
| milan | morning dtantsur, lucasagomes! :) | 09:59 |
| dtantsur | hey milan, seen a W+1 on one patch? | 09:59 |
| milan | nope | 09:59 |
| * milan checks | 10:00 | |
| milan | states patch merging \o/ | 10:00 |
| milan | :D | 10:00 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411117 | 10:00 |
| milan | merry Christmas milan! :D | 10:00 |
| dtantsur | tuanluong, please expand your commit messages to provide the actual reasoning | 10:00 |
| milan | aarefiev, dtantsur I love you guys! :D | 10:00 |
| dtantsur | :) | 10:01 |
| tuanluong | yes dtantsur | 10:01 |
| aarefiev | :) | 10:01 |
| dtantsur | tuanluong, actually, I'd prefer a unit test that fails before your change but is fixed by your change | 10:01 |
| dtantsur | otherwise it looks like a change for the sake of it | 10:01 |
| openstackgerrit | Tovin Seven proposed openstack/python-ironicclient: Add OSProfiler support to Ironicclient https://review.openstack.org/362331 | 10:04 |
| *** ralonsoh_ has joined #openstack-ironic | 10:05 | |
| *** SerenaFeng has quit IRC | 10:07 | |
| dtantsur | aarefiev, do you know if https://review.openstack.org/#/c/404436/ breaks us? | 10:08 |
| patchbot | patch 404436 - ironic - Move CONF.service_available.ironic to our plugin | 10:08 |
| *** ralonsoh has quit IRC | 10:08 | |
| dtantsur | oh, it does | 10:09 |
| * dtantsur is close to -2ing it | 10:09 | |
| aarefiev | dtantsur: it shouldn't as is | 10:09 |
| aarefiev | I've tested and it's worked | 10:10 |
| *** Romanenko_K has joined #openstack-ironic | 10:10 | |
| aarefiev | because tempest will configure it for us | 10:10 |
| aarefiev | also I saw Vasyl's patch for copy tempest config for grenade, instead of generating new one, so should work, but a lot of 'ifs' | 10:12 |
| dtantsur | aarefiev, well, it failed our CI job even with "no tests executed" | 10:13 |
| dtantsur | so dunno | 10:13 |
| pas-ha | reno jobs fail again - Command '(['git', 'log', '--simplify-by-decoration', '--pretty="%d"', u'liberty-eol-eol'],)' returned non-zero exit status 128 | 10:13 |
| pas-ha | liberty-eol-eol looks suspicios | 10:13 |
| dtantsur | dhellmann, ^^^ | 10:13 |
| pas-ha | http://logs.openstack.org/89/398989/6/check/gate-ironic-python-agent-releasenotes/5408681/console.html | 10:14 |
| aarefiev | dtantsur: tested here https://review.openstack.org/#/c/400690/ | 10:14 |
| patchbot | patch 400690 - ironic-inspector - Grenade: test | 10:14 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Migrate to session for glance client https://review.openstack.org/410767 | 10:14 |
| dtantsur | let's re-test | 10:15 |
| *** SerenaFeng has joined #openstack-ironic | 10:15 | |
| aarefiev | dtantsur: already recheck | 10:15 |
| *** bks has quit IRC | 10:16 | |
| *** bks has joined #openstack-ironic | 10:16 | |
| *** tovin07_ has left #openstack-ironic | 10:17 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fixes to allow install Ironic on remote node https://review.openstack.org/409213 | 10:18 |
| *** openstackgerrit has quit IRC | 10:18 | |
| *** Linkmark has joined #openstack-ironic | 10:20 | |
| *** ralonsoh__ has joined #openstack-ironic | 10:27 | |
| *** openstackgerrit has joined #openstack-ironic | 10:28 | |
| openstackgerrit | Merged openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/411079 | 10:28 |
| *** ralonsoh__ is now known as ralonsoh | 10:28 | |
| vdrok | dtantsur: a quick one https://review.openstack.org/411022, I'll merge the 'use upper-constraints' on after it is approved | 10:29 |
| patchbot | patch 411022 - ironic-staging-drivers - Updated from global requirements | 10:29 |
| *** ralonsoh_ has quit IRC | 10:30 | |
| dtantsur | +A | 10:30 |
| vdrok | thx :) | 10:30 |
| *** nmathew has joined #openstack-ironic | 10:31 | |
| *** skazi has quit IRC | 10:32 | |
| *** Nisha_Agarwal has quit IRC | 10:33 | |
| *** skazi has joined #openstack-ironic | 10:33 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-inspector: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411117 | 10:35 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-lib: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411124 | 10:35 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic-python-agent: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411131 | 10:36 |
| *** derekh has joined #openstack-ironic | 10:36 | |
| tuanluong | dtantsur, I hope now my commit messages more clearly. | 10:36 |
| dtantsur | yep, makes sense now | 10:38 |
| openstackgerrit | octopuszhang proposed openstack/ironic: Fix wrong exception message when deploy failed https://review.openstack.org/411224 | 10:44 |
| milan | aarefiev, dtantsur http://logs.openstack.org/60/411060/1/check/gate-ironic-inspector-releasenotes/1ccfe7b/console.html#_2016-12-15_03_52_20_962793 | 10:45 |
| milan | seems the release notes job is hosed again | 10:45 |
| milan | same in the state patch :-/ | 10:46 |
| openstackgerrit | octopuszhang proposed openstack/ironic: Fix wrong exception message when deploy failed https://review.openstack.org/411224 | 10:46 |
| * dtantsur facepalm | 10:48 | |
| *** lets has quit IRC | 10:50 | |
| openstackgerrit | octopuszhang proposed openstack/ironic: Fix wrong exception message when deploy failed https://review.openstack.org/411224 | 10:50 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Keystone session for swift-temp-url generation https://review.openstack.org/410764 | 10:53 |
| openstackgerrit | octopuszhang proposed openstack/ironic: Fix wrong exception message when deploy failed https://review.openstack.org/411224 | 10:54 |
| *** yufei has quit IRC | 10:56 | |
| *** amotoki has quit IRC | 10:56 | |
| milan | aarefiev, dtantsur and I think we'll see http://paste.openstack.org/show/592449/ once the fixed reno version is put in (test)requirements, shall we revert 9af663b59f4dbacecbddae59f2469bc267225d2c | 11:01 |
| milan | ? | 11:01 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-inspector: Use the device hints matching mechanism from ironic-lib https://review.openstack.org/408552 | 11:02 |
| * milan still unsure about what is the root case for the previous issue :-/ | 11:02 | |
| dtantsur | milan, let's try | 11:02 |
| aarefiev | ehh | 11:03 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Update from global requirements https://review.openstack.org/411237 | 11:04 |
| milan | dtantsur, aarefiev ^ the reno thing | 11:04 |
| *** MattMan has quit IRC | 11:05 | |
| openstackgerrit | Merged openstack/ironic-inspector: Remove upgrade from non-ironic setup https://review.openstack.org/410606 | 11:05 |
| *** MattMan has joined #openstack-ironic | 11:05 | |
| * milan -> food a bit | 11:05 | |
| aarefiev | thx milan | 11:05 |
| milan | np | 11:05 |
| *** e0ne has joined #openstack-ironic | 11:07 | |
| *** cdearborn has quit IRC | 11:20 | |
| *** dtantsur is now known as dtantsur|brb | 11:32 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Introduce generic hardware types https://review.openstack.org/400678 | 11:34 |
| *** tuanluong has quit IRC | 11:36 | |
| openstackgerrit | Merged openstack/ironic: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411106 | 11:41 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _get_sensors_data concurrent https://review.openstack.org/407429 | 11:43 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _get_sensors_data concurrent https://review.openstack.org/407429 | 11:45 |
| *** vikrant has quit IRC | 11:47 | |
| *** SerenaFeng has quit IRC | 11:52 | |
| charlledaniel | morning NobodyCam, vdrok, milan, lucasagomes, dtantsur|brb and all | 11:53 |
| *** jkilpatr has joined #openstack-ironic | 11:57 | |
| *** cvstealth has joined #openstack-ironic | 11:58 | |
| *** amotoki has joined #openstack-ironic | 11:59 | |
| *** SerenaFeng has joined #openstack-ironic | 11:59 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add portgroup configuration fields https://review.openstack.org/398417 | 12:00 |
| vdrok | morning charlledaniel | 12:00 |
| *** phuongnh has quit IRC | 12:01 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-python-agent: Configure and use SSL-related requests options https://review.openstack.org/398992 | 12:01 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 12:02 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface RPC APIs https://review.openstack.org/404239 | 12:02 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface Driver APIs https://review.openstack.org/327046 | 12:02 |
| *** hw_wutianwei has quit IRC | 12:02 | |
| lucasagomes | charlledaniel, morning | 12:02 |
| *** vikrant has joined #openstack-ironic | 12:03 | |
| lucasagomes | wasn't the releasenotes job fixed yesterday ? I think I've hit it again at https://review.openstack.org/#/c/410168/ | 12:03 |
| patchbot | patch 410168 - ironic - Make CONF.debug also reflect on IPA | 12:03 |
| *** SerenaFeng has quit IRC | 12:03 | |
| vdrok | lucasagomes: so, it appears that another fix to reno itself was merged after we've fixed out liberty reno file | 12:04 |
| *** david-lyle has quit IRC | 12:05 | |
| *** david-lyle has joined #openstack-ironic | 12:05 | |
| lucasagomes | vdrok, right on | 12:05 |
| vdrok | lucasagomes: https://review.openstack.org/#/c/410792/1/reno/scanner.py | 12:06 |
| patchbot | patch 410792 - reno - support removed stable branches (MERGED) | 12:06 |
| openstackgerrit | Sofiia Andriichenko proposed openstack/ironic: This adds a tempest tests for creating a node: https://review.openstack.org/411197 | 12:06 |
| vdrok | seems like we can put stable/liberty back as it was before | 12:06 |
| *** lekha has quit IRC | 12:07 | |
| lucasagomes | vdrok, yeah lemme try | 12:07 |
| TheJulia | CalledProcessError: Command '(['git', 'log', '--simplify-by-decoration', '--pretty="%d"', u'liberty-eol-eol'],)' returned non-zero exit status 128 | 12:07 |
| TheJulia | wheeee | 12:07 |
| vdrok | lucasagomes: yup, could you try locally, I'd just revert the yesterday fix | 12:07 |
| vdrok | or actually, I can revert anyway :) | 12:08 |
| *** aweeks has quit IRC | 12:08 | |
| lucasagomes | vdrok, yeah running locally to see if it works w/ and w/o thje revert | 12:08 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Revert "Change liberty's reno page to use the tag" https://review.openstack.org/411271 | 12:08 |
| vdrok | just in case ^^ | 12:08 |
| *** mjura has quit IRC | 12:08 | |
| *** moshele has quit IRC | 12:08 | |
| *** moshele has joined #openstack-ironic | 12:09 | |
| lucasagomes | vdrok, works | 12:11 |
| TheJulia | lucasagomes: confirmed locally with updated reno? | 12:11 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Migrate to session for glance client https://review.openstack.org/410767 | 12:12 |
| vdrok | ok good | 12:12 |
| lucasagomes | TheJulia, sorry, so yeah reverting the patch makes it work again | 12:12 |
| lucasagomes | with the new reno | 12:12 |
| TheJulia | I'll fire off the other two reverts | 12:13 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent: Revert "Use liberty-eol tag for liberty release notes" https://review.openstack.org/411275 | 12:14 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-inspector: Revert "Use liberty-eol tag for liberty release notes" https://review.openstack.org/411276 | 12:14 |
| *** cdearborn has joined #openstack-ironic | 12:14 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 12:15 | |
| TheJulia | I _think_ that is it... | 12:16 |
| *** moshele has quit IRC | 12:16 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent: Revert "Use liberty-eol tag for liberty release notes" https://review.openstack.org/411279 | 12:17 |
| milan | morning charlledaniel lucasagomes TheJulia! :) | 12:19 |
| TheJulia | Good morning | 12:19 |
| vdrok | oh, morning TheJulia by the way :) | 12:19 |
| TheJulia | good morning vdrok | 12:20 |
| TheJulia | I don't know how long I'll be awake for this morning, I didn't really sleep last night. If coffee works \o/, but it might not. | 12:20 |
| *** mjura has joined #openstack-ironic | 12:21 | |
| milan | coffee++ :) | 12:21 |
| milan | aarefiev, dtantsur|brb http://logs.openstack.org/37/411237/1/check/gate-ironic-inspector-releasenotes/1b2d96a/console.html#_2016-12-15_11_07_33_952947 < we need to revert too | 12:22 |
| TheJulia | milan: I already posted the inspector revert | 12:23 |
| TheJulia | 411276 | 12:23 |
| milan | TheJulia, ah, thx! | 12:23 |
| * milan checks | 12:23 | |
| xavierr | good morning :) | 12:24 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add portgroup configuration fields https://review.openstack.org/398417 | 12:24 |
| xavierr | coffee^2 | 12:25 |
| lucasagomes | TheJulia, thanks! | 12:25 |
| milan | morning xavierr! :D | 12:25 |
| lucasagomes | milan, morning :D | 12:25 |
| lucasagomes | xavierr, morning too | 12:25 |
| milan | coffee^2 indeed | 12:25 |
| * lucasagomes s/coffee/lunch | 12:25 | |
| * lucasagomes lucas-hungry | 12:25 | |
| *** lucasagomes is now known as lucas-hungry | 12:26 | |
| lucas-hungry | ops :-) | 12:26 |
| xavierr | hey lucasagomes and milan :) | 12:26 |
| *** vinsh has quit IRC | 12:27 | |
| * milan wonders what about the other issue now | 12:27 | |
| openstackgerrit | Merged openstack/ironic: Revert "Change liberty's reno page to use the tag" https://review.openstack.org/411271 | 12:28 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: ETAGs maintenance for all api node's requests https://review.openstack.org/392213 | 12:29 |
| *** dprince has joined #openstack-ironic | 12:29 | |
| *** amotoki has quit IRC | 12:32 | |
| openstackgerrit | Merged openstack/ironic-inspector: Revert "Use liberty-eol tag for liberty release notes" https://review.openstack.org/411276 | 12:32 |
| *** vikrant has quit IRC | 12:38 | |
| *** nmathew has quit IRC | 12:42 | |
| *** bdeschenes has joined #openstack-ironic | 12:44 | |
| *** bfournie has quit IRC | 12:44 | |
| *** amotoki has joined #openstack-ironic | 12:50 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add os_project_name to functional tests config https://review.openstack.org/408235 | 12:50 |
| *** chlong has joined #openstack-ironic | 12:51 | |
| *** zhs_ has joined #openstack-ironic | 12:53 | |
| *** amotoki has quit IRC | 12:55 | |
| milan | aarefiev, dtantsur|brb so 2016-12-15 12:53:46.874946 | /usr/local/jenkins/slave_scripts/run-tox.sh: line 28: .tox/releasenotes/bin/pip: No such file or directory is still there but the job passes now | 12:55 |
| * milan files a bug ? | 12:55 | |
| *** zhs__ has quit IRC | 12:56 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Allow enroll-dynamic on remote host https://review.openstack.org/411299 | 12:58 |
| *** cdearborn has quit IRC | 12:58 | |
| milan | FYI https://bugs.launchpad.net/ironic-inspector/+bug/1650268 not sure what else is affected | 13:06 |
| openstack | Launchpad bug 1650268 in Ironic Inspector "Releasenotes gate job has issues pip freezing" [Undecided,New] | 13:06 |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Allow deploy-dynamic on remote host https://review.openstack.org/411304 | 13:08 |
| *** amoralej is now known as amoralej|lunch | 13:10 | |
| milan | wut http://logs.openstack.org/37/411237/1/check/gate-ironic-inspector-requirements/b60576b/console.html#_2016-12-15_12_39_32_883093 ?!?! | 13:14 |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Allow deploy-dynamic on remote host https://review.openstack.org/411304 | 13:18 |
| milan | vdrok, maybe you know ^^ me updated the reno dependency in Inspector but the job is failing with dependency check :-/ | 13:19 |
| * milan wonders what to do | 13:19 | |
| vdrok | Milan I think you need a commit in master history for it to work | 13:21 |
| vdrok | At least that's what I suspect | 13:21 |
| nicodemos | good morning, ironic'ers. , | 13:21 |
| *** cdearborn has joined #openstack-ironic | 13:22 | |
| milan | morning nicodemos! :) | 13:22 |
| milan | vdrok, OK | 13:22 |
| * milan doesn't follow but OK | 13:22 | |
| milan | vdrok, thx :) | 13:22 |
| *** bfournie has joined #openstack-ironic | 13:24 | |
| vdrok | milan: I mean, I dunno what Reno does in case of change on review. If it only cherry picks one commit, applies to master and scans/builds Reno, or if it rebases the whole chain and does that | 13:25 |
| milan | vdrok, yeah I dunno either, the other commit seems passing the reno job (without having applied this version bump): http://docs-draft.openstack.org/60/411060/1/check/gate-ironic-inspector-releasenotes/c16b5d3//releasenotes/build/html/ I'm confused :) | 13:27 |
| *** [1]cdearborn has joined #openstack-ironic | 13:27 | |
| *** lucas-hungry is now known as lucasagomes | 13:29 | |
| jroll | morning y'all | 13:30 |
| vdrok | morning jroll | 13:31 |
| *** links has quit IRC | 13:31 | |
| milan | morning jroll! :) | 13:32 |
| aarefiev | morning jroll | 13:32 |
| *** jheroux has joined #openstack-ironic | 13:32 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Verify JSON response of chassis commands https://review.openstack.org/336596 | 13:32 |
| aarefiev | milan: ci is passed w/o your bump ? | 13:32 |
| milan | aarefiev, yeah seems so or I dunno what I'm reading in Zuul :D https://review.openstack.org/#/c/411237/ | 13:33 |
| patchbot | patch 411237 - ironic-inspector - Update from global requirements | 13:33 |
| vdrok | milan: ah, so that's just a version conflict | 13:33 |
| milan | aarefiev, sry wrong link | 13:33 |
| milan | https://review.openstack.org/#/c/411060/1 | 13:33 |
| patchbot | patch 411060 - ironic-inspector - Updated from global requirements | 13:33 |
| vdrok | I thought you've seen the liberty-eol-eol again | 13:33 |
| milan | vdrok, version conflict it is | 13:34 |
| milan | aarefiev, http://docs-draft.openstack.org/60/411060/1/check/gate-ironic-inspector-releasenotes/c16b5d3//releasenotes/build/html/ | 13:34 |
| milan | seems it passed even w/o the version bump | 13:34 |
| aarefiev | ( | 13:37 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic: Onetime boot when set_boot_device isn't persistent https://review.openstack.org/340596 | 13:40 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: ETAGs maintenance for all api node's requests https://review.openstack.org/392213 | 13:41 |
| *** moshele has joined #openstack-ironic | 13:41 | |
| *** cdearborn has quit IRC | 13:41 | |
| pas-ha | those with the ipa +2 powers - please merge and unblock IPA gates re reno - again :-/ https://review.openstack.org/#/c/411319/ | 13:43 |
| patchbot | patch 411319 - requirements (stable/newton) - update reno to 1.9.0 | 13:43 |
| pas-ha | oops, wrong one | 13:43 |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fixes to allow install Ironic on remote node https://review.openstack.org/409213 | 13:44 |
| pas-ha | https://review.openstack.org/#/c/411275/ | 13:44 |
| patchbot | patch 411275 - ironic-python-agent - Revert "Use liberty-eol tag for liberty release no... | 13:44 |
| pas-ha | vdrok jroll ^ | 13:45 |
| jroll | pas-ha: fun, thanks, mind cherry-picking that to stable/newton? | 13:46 |
| vdrok | jroll: there is a stable/newton bump in upper-constraints that needs to go in first | 13:48 |
| jroll | vdrok: ah | 13:48 |
| vdrok | https://review.openstack.org/#/c/411319/ and then https://review.openstack.org/411279 | 13:49 |
| patchbot | patch 411319 - requirements (stable/newton) - update reno to 1.9.0 | 13:49 |
| patchbot | patch 411279 - ironic-python-agent (stable/newton) - Revert "Use liberty-eol tag for liberty release no... | 13:49 |
| openstackgerrit | Merged openstack/ironic-python-agent: Revert "Use liberty-eol tag for liberty release notes" https://review.openstack.org/411275 | 13:50 |
| jroll | thanks | 13:50 |
| *** amotoki has joined #openstack-ironic | 13:51 | |
| *** wajdi_ has quit IRC | 13:53 | |
| *** lindycoder has joined #openstack-ironic | 13:55 | |
| *** glonlas has joined #openstack-ironic | 13:56 | |
| *** skazi has quit IRC | 13:58 | |
| *** glonlas_ has joined #openstack-ironic | 13:59 | |
| *** glonlas_ has quit IRC | 13:59 | |
| *** skazi has joined #openstack-ironic | 13:59 | |
| *** glonlas_ has joined #openstack-ironic | 14:00 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Allow enroll-dynamic on remote host https://review.openstack.org/411299 | 14:00 |
| *** glonlas_ has quit IRC | 14:00 | |
| *** glonlas has quit IRC | 14:00 | |
| *** skazi has quit IRC | 14:00 | |
| *** bks has quit IRC | 14:01 | |
| *** skazi has joined #openstack-ironic | 14:01 | |
| *** rbudden has joined #openstack-ironic | 14:03 | |
| *** glonlas has joined #openstack-ironic | 14:04 | |
| *** aweeks has joined #openstack-ironic | 14:04 | |
| *** lekha has joined #openstack-ironic | 14:04 | |
| *** tuan_luong has joined #openstack-ironic | 14:05 | |
| *** Nisha_Agarwal has quit IRC | 14:06 | |
| *** amoralej|lunch is now known as amoralej | 14:09 | |
| *** baoli has joined #openstack-ironic | 14:11 | |
| *** baoli has quit IRC | 14:12 | |
| *** baoli has joined #openstack-ironic | 14:12 | |
| *** derekh is now known as derekh_brb | 14:12 | |
| *** rloo has joined #openstack-ironic | 14:15 | |
| *** chlong has quit IRC | 14:20 | |
| tuan_luong | hello sambetts | 14:22 |
| *** chlong has joined #openstack-ironic | 14:22 | |
| *** chlong has quit IRC | 14:26 | |
| *** causten has joined #openstack-ironic | 14:27 | |
| *** chlong has joined #openstack-ironic | 14:28 | |
| *** Goneri has joined #openstack-ironic | 14:31 | |
| *** jcoufal has joined #openstack-ironic | 14:31 | |
| rloo | hi and good Thursday morning all! Thx for fixing the reno stuff :) | 14:32 |
| openstackgerrit | octopuszhang proposed openstack/ironic: Fix wrong exception message when deploy failed https://review.openstack.org/411224 | 14:32 |
| rloo | tuan_luong: I think sambetts is away, i can't remember when he is coming back | 14:33 |
| tuan_luong | hello rloo | 14:33 |
| tuan_luong | is that reno can pass | 14:34 |
| lucasagomes | rloo, tuan_luong morning | 14:35 |
| tuan_luong | good night lucasagomes, | 14:35 |
| lucasagomes | :-) | 14:35 |
| rloo | tuan_luong: you mean you wanted to let sam know that reno is working now? | 14:36 |
| tuan_luong | rloo, I just want to ask sambetts some questions relate to ironic | 14:37 |
| tuan_luong | rloo, my lab have bought a new switch | 14:38 |
| rloo | tuan_luong: oh. you're welcome to ask here, maybe someone else will answer. or wait til sambetts comes back | 14:38 |
| vdrok | morning rloo | 14:38 |
| milan | morning rloo! :) | 14:38 |
| tuan_luong | I want to setup to deploy an instance using ironic | 14:38 |
| rloo | hi vdrok, gonna try to get some of those portgroup patches merged today :) | 14:38 |
| vdrok | rloo: yeah, the client one seems good to go. was using it today, not a single breakage :) | 14:39 |
| tuan_luong | hi vdrok , milan | 14:39 |
| milan | morning tuan_luong! :) | 14:39 |
| vdrok | hey tuan_luong | 14:39 |
| rloo | vdrok: :) I +2'd the first client one. | 14:39 |
| milan | \o/ :) | 14:40 |
| rloo | vsaienk0: you have any idea what is wrong with jenkins here: https://review.openstack.org/#/c/362130/ | 14:40 |
| patchbot | patch 362130 - python-ironicclient - Add portgroup support to osc plugin | 14:40 |
| vdrok | rloo: yup. second one still has address mandatory tho | 14:40 |
| rloo | vdrok: ah. ok, so i will wait to review it. | 14:40 |
| vdrok | vsaienk0: is out already, but it seems just one unittest needs update | 14:41 |
| vdrok | rloo: ^ | 14:41 |
| vdrok | maybe I'll do the update | 14:42 |
| rloo | vdrok: what do you mean, what is out already? vsaienk0 is away? | 14:42 |
| vdrok | yup | 14:42 |
| rloo | vdrok: away for today? | 14:42 |
| rloo | vdrok: or away for a few weeks? | 14:42 |
| vdrok | dunno, come to the office from lunch and he's disappeared :) | 14:42 |
| rloo | vdrok: ha ha. ok | 14:42 |
| vdrok | hopefully just for today :) | 14:42 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-inspector: Update config sample https://review.openstack.org/411351 | 14:43 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-inspector: Change drac_host to drac_address https://review.openstack.org/411352 | 14:43 |
| *** derekh_brb is now known as derekh | 14:44 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-inspector: Change drac_host to drac_address https://review.openstack.org/411352 | 14:44 |
| *** zhangyufei has joined #openstack-ironic | 14:50 | |
| *** zhangyufei has left #openstack-ironic | 14:50 | |
| *** yufei has joined #openstack-ironic | 14:50 | |
| *** athomas has quit IRC | 14:53 | |
| *** vsaienko has joined #openstack-ironic | 14:53 | |
| *** yuriyz has quit IRC | 14:53 | |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Fix API object representation in unittests https://review.openstack.org/410112 | 14:54 |
| openstackgerrit | Sofiia Andriichenko proposed openstack/ironic: This adds a tempest test for creating a chassis with a specific UUID. https://review.openstack.org/409196 | 14:54 |
| *** wajdi has joined #openstack-ironic | 14:55 | |
| *** yuriyz has joined #openstack-ironic | 14:57 | |
| *** yuriyz has quit IRC | 14:58 | |
| *** yuriyz has joined #openstack-ironic | 14:58 | |
| *** athomas has joined #openstack-ironic | 15:01 | |
| *** links has joined #openstack-ironic | 15:01 | |
| *** glonlas_ has joined #openstack-ironic | 15:02 | |
| *** glonlas_ has quit IRC | 15:02 | |
| *** glonlas_ has joined #openstack-ironic | 15:03 | |
| *** Goneri has quit IRC | 15:03 | |
| *** chlong has quit IRC | 15:03 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fixes to allow install Ironic on remote node https://review.openstack.org/409213 | 15:04 |
| *** glonlas has quit IRC | 15:05 | |
| *** rbartal has quit IRC | 15:06 | |
| jroll | dtantsur|brb: I assume you're out, but can we talk about the best way to resolve https://review.openstack.org/#/c/404436/5 ? we clearly need to skip those if ironic isn't available. and given inspector requires ironic, I don't see how this breaks it (unless we just aren't setting that config in inspector things?) | 15:06 |
| patchbot | patch 404436 - ironic - Move CONF.service_available.ironic to our plugin | 15:06 |
| *** Syed__ has joined #openstack-ironic | 15:11 | |
| openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/411080 | 15:11 |
| openstackgerrit | Merged openstack/python-ironicclient: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411111 | 15:12 |
| *** glonlas_ has quit IRC | 15:14 | |
| *** eroux has joined #openstack-ironic | 15:14 | |
| *** glonlas has joined #openstack-ironic | 15:15 | |
| *** Goneri has joined #openstack-ironic | 15:15 | |
| aarefiev | jroll: I've tested your patch it works, also if we will copy tempest conf instead of generate new one it should be fine | 15:17 |
| jroll | aarefiev: okay, so we're good to merge that? | 15:18 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-inspector: Add drac_address to ipmi_address_fields https://review.openstack.org/411352 | 15:18 |
| jlvillal | jroll, Maybe you can ping some of the grenade cores to get the grenade patch merged? | 15:19 |
| aarefiev | jroll: +1 from me | 15:19 |
| jlvillal | jroll, https://review.openstack.org/407502 | 15:19 |
| patchbot | patch 407502 - openstack-dev/grenade - Use same tempest.conf for base and target | 15:19 |
| jlvillal | I've done some begging but no success so far :( | 15:19 |
| jroll | jlvillal: sure, wasn't going to do that if current plan wasn't valid | 15:19 |
| jlvillal | Okay | 15:19 |
| openstackgerrit | Merged openstack/python-ironicclient: Add python API and CLI for port groups https://review.openstack.org/335964 | 15:20 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 15:24 |
| *** soliosg has joined #openstack-ironic | 15:26 | |
| *** ralonsoh has quit IRC | 15:29 | |
| JayF | Per the nova folks, we have to roll back that liberty-eol release notes patch from yesterday | 15:30 |
| JayF | getting teh details now | 15:30 |
| *** moshele has quit IRC | 15:30 | |
| rloo | JayF: I think "we" (royal, not me) already rolled back | 15:31 |
| JayF | ah, okay | 15:31 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Functional tests for portgroups in ironicclient https://review.openstack.org/297727 | 15:31 |
| JayF | apparently that fix was supposed to be good, but there was a different bug in the new reno release | 15:31 |
| JayF | did that patch get reverted everywhere? inc stable? | 15:32 |
| rloo | JayF: i saw a bunch of reverts, am assuming the folks here were thorough :) | 15:32 |
| vdrok | morning JayF and jlvillal | 15:32 |
| vdrok | JayF: not everywhere I think | 15:32 |
| vdrok | not in stable at least | 15:32 |
| rloo | JayF, i've got a good question for you. Or others wrt sensor data: https://review.openstack.org/#/c/410760/1/ironic/conductor/manager.py. how to address/fix that? | 15:33 |
| patchbot | patch 410760 - ironic - Add a possibility to send sensors data in standalo... | 15:33 |
| jroll | JayF: stable waiting on https://review.openstack.org/#/c/411319/ and then it's at: https://review.openstack.org/#/c/411279/ | 15:33 |
| patchbot | patch 411319 - requirements (stable/newton) - update reno to 1.9.0 | 15:33 |
| patchbot | patch 411279 - ironic-python-agent (stable/newton) - Revert "Use liberty-eol tag for liberty release no... | 15:33 |
| JayF | got it | 15:34 |
| JayF | ty jroll | 15:34 |
| jroll | np | 15:34 |
| *** glonlas has quit IRC | 15:36 | |
| vdrok | rloo: I'd actually suppose that this stuff is queried from only active nodes. are you asking about should we leave the things as is? | 15:37 |
| rloo | vdrok: backwards compatibility | 15:37 |
| rloo | vdrok: will we break someone that is using that, if we change it to active. | 15:37 |
| JayF | rloo: TBH I haven't really read this code closesly before, it seems silly we're only checking sensors on nodes w/an instance_uuid in general | 15:38 |
| JayF | rloo: but I agree with you that is a significant behavioral change | 15:38 |
| rloo | vdrok: unless we support both and deprecate old behaviour | 15:38 |
| rloo | JayF: yeah, i agree it should be fixed. just not sure what the fix is. | 15:38 |
| JayF | rloo: it would, for instance, once rescue lands, stop gathering sensors on rescue'd nodes | 15:38 |
| JayF | which is a really, really nasty side effect | 15:38 |
| vdrok | JayF: we can just add it to the filter | 15:39 |
| JayF | And all the other states a node with instance uuid can be in? Deploying? Deleting? | 15:39 |
| TheJulia | Good morning again everyone | 15:39 |
| JayF | That's just a nasty road to go down | 15:39 |
| JayF | when instance_uuid is the indicator we use in many other places -- including nova -- to indicate an instance is deployed on a node | 15:40 |
| vdrok | JayF: for cleaning we don't do it right now | 15:40 |
| rloo | vdrok: for standalone use, do you think they *only* want it in active? | 15:40 |
| vdrok | yuriyz: was thinking about the unnexessary load on ipmi during provisioning/cleaning | 15:40 |
| vdrok | if we collect the metrics in those states | 15:40 |
| rloo | vdrok, JayF: so do you think, at least for now, an 'or' would be ok? ACTIVE OR has instance? | 15:40 |
| vdrok | rloo: to deprecate, it seems we'll have to add a config option? | 15:41 |
| JayF | I'm putting a suggestion in the code right now | 15:41 |
| rloo | vdrok, JayF, yuriyz: and/or do you think the operator wants more control as to when to get sensor data? | 15:41 |
| JayF | config options is what I'm suggesting, yes | 15:41 |
| patchbot | Error: 'supybot.options' is not a valid configuration variable. | 15:41 |
| JayF | success I'm a stupid irc robot. | 15:41 |
| patchbot | The operation succeeded. I'm a stupid irc robot. | 15:41 |
| * TheJulia just looks at the bot | 15:41 | |
| rloo | JayF: I like supybot.options :) | 15:41 |
| vdrok | morning TheJulia :) | 15:41 |
| TheJulia | vdrok: good morning, again! | 15:42 |
| vdrok | doh :) | 15:42 |
| TheJulia | My fitbit said I only got three hours of sleep, another hour seems to have helped a lot. | 15:42 |
| nicodemos | morning TheJulia | 15:42 |
| yuriyz | hi rloo all maybe but operator should not define all ironic states I think config should be simple | 15:42 |
| JayF | oh man, that code has an even nastier bug: it fetches sensor data from maint'd machines | 15:42 |
| NobodyCam | Good morning ironic'ers | 15:42 |
| rloo | TheJulia: i hope your fitbit is wrong but i suspect not :-( | 15:42 |
| TheJulia | rloo: sadly, I think it was more like two hours of sleep, not three | 15:43 |
| rloo | yuriyz: yes, config would work for me. but what values/how to configure? | 15:43 |
| rloo | TheJulia: :-( | 15:43 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 15:43 |
| * rloo is glad that someone is using (or trying to use) sensor data | 15:45 | |
| JayF | rloo: yuriyz: I put a comment with a concrete suggestion on the patch | 15:45 |
| tuan_luong | hello rloo, can i ask about https://review.openstack.org/#/c/410537/ | 15:45 |
| patchbot | patch 410537 - ironic - Fix ironic dev-quickstart doc | 15:45 |
| yuriyz | simple solution for example is boolean config value False == only active state True == active + transitions (deploy, cleaning etc) | 15:45 |
| tuan_luong | i saw it is a small bug in document | 15:45 |
| rloo | tuan_luong: you are always welcome to ask :) | 15:45 |
| JayF | yuriyz: my suggestion was to do two configs: 1 for deployed vs not (instance_uuid = None vs a uuid), and 1 for what states to collect sensor data in | 15:45 |
| tuan_luong | rloo, thus i didn't report bugs or information to re-produce bugs. | 15:46 |
| JayF | yuriyz: also that code has a nasty bug in it where it collects sensor data from maintenance'd nodes. | 15:46 |
| rloo | tuan_luong: pas-ha said he filed a bug, so that is fine. i just don't know if we want to update the docs, or fix the bug, or update the docs with a note that there is a bug, or ... ? | 15:47 |
| rloo | tuan_luong: and i don't have time right now to look into it | 15:47 |
| *** vsaienko has quit IRC | 15:48 | |
| yuriyz | JayF maybe one of cases is collect sensors data from maintenanced nodes I'm not sure | 15:49 |
| vdrok | rloo: what's your opinion on --portgroup vs --port-group for osc plugin, as we did break up into port group for command names | 15:49 |
| TheJulia | I would think one might want to | 15:49 |
| TheJulia | I mean, ideally not, it could be failing at the same time | 15:50 |
| JayF | yuriyz: that's a safety issue; doesn't matter what the use case -- if a node is in maintenance, ironic should not touch the BMC | 15:50 |
| rloo | vdrok: oh. ugh. is that a trick question? :) give me a few minutes to look at that patch. i see you updated it. i thought i answered that question awhile ago but maybe not. | 15:50 |
| yuriyz | for example I put node in maintenance and run some hard tests | 15:50 |
| vdrok | rloo: ok, I'll look at the history too :) | 15:50 |
| JayF | yuriyz: Sure; but what about I maintenance a node because the BMC is partially bricked from a bad firmware update. Ironic hits the BMC with a request and finishes the bricking. | 15:51 |
| rloo | vdrok: i am not sure, but i think it was in irc, and i think sam may have asked me about it. but i don't recall for sure. hopefully, i can give the same answer i gave before, if this wasn't all a figment of my imagination | 15:51 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 15:52 |
| vdrok | missed a couple portgroup->port group | 15:52 |
| JayF | yuriyz: or even worse: I maintenance a node to perform a firmware update. Ironic making an IPMI call in the interim causes the firmware upgrade to get corrupted and break the server | 15:53 |
| yuriyz | JayF agree but we do not block power/management operation in the maintenance | 15:54 |
| JayF | yuriyz: we do in the API | 15:55 |
| JayF | yuriyz: I can't api power on/off a maint'd node | 15:55 |
| JayF | yuriyz: and the power status loop skips maintenance nodes | 15:55 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Fix ironic dev-quickstart doc bug https://review.openstack.org/410537 | 15:56 |
| openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/411060 | 15:56 |
| yuriyz | JayF ok looks like we should also check maintenance into loop | 15:56 |
| *** vinsh has joined #openstack-ironic | 15:56 | |
| mariojv | i agree. if a node is in maintenance, ironic shouldn't touch it | 15:57 |
| JayF | yuriyz: this becomes more clear when my node-fault work gets in during pike | 15:57 |
| mariojv | the specific fault support work JayF and i are designing should help .. yup | 15:57 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Fix ironic dev-quickstart doc bug https://review.openstack.org/410537 | 15:57 |
| mariojv | essentially, ironic set "maintenance" will no longer be called maintenance and be distinct from operator maintenance | 15:58 |
| NobodyCam | Good Morning Ironic'ers | 15:59 |
| yuriyz | morning NobodyCam | 15:59 |
| mrtenio | morning NobodyCam | 15:59 |
| NobodyCam | Morning yuriyz and mrtenio | 16:00 |
| rloo | vdrok: the spec shows --port-group. | 16:00 |
| NobodyCam | morning rloo :) | 16:00 |
| vdrok | morning NobodyCam | 16:00 |
| rloo | hey, morning NobodyCam! | 16:00 |
| vdrok | rloo: oh right, so I did write that :) | 16:00 |
| *** e0ne has quit IRC | 16:01 | |
| rloo | vdrok: i think that's when we/i had that discussion. | 16:01 |
| NobodyCam | morning vdork | 16:01 |
| *** Goneri has quit IRC | 16:01 | |
| rloo | vdrok: so should i review that patch or are you going to update it again/soon? | 16:01 |
| vdrok | rloo: yeah, that should be quick, I'll update now | 16:01 |
| *** trown is now known as trown|mtg | 16:01 | |
| rloo | vdrok: ok. no worries, it isn't like i am twiddling my thumbs with nothing to do :) | 16:01 |
| yuriyz | JayF mariojv if we want configure states for collecting sensors data config values should be not the same as ironic states (in other case I should list all deploy, deploywait, cleanwait etc) | 16:02 |
| mariojv | yuriyz: is there a patch up with what is being discussed? i haven't read full scrollback yet | 16:02 |
| mariojv | 410760 right? | 16:03 |
| JayF | yuriyz: I'm OK with that, three general categories: idle nodes, deploy[ed|ing] nodes, cleaning nodes | 16:03 |
| yuriyz | https://review.openstack.org/#/c/410760/ | 16:03 |
| patchbot | patch 410760 - ironic - Add a possibility to send sensors data in standalo... | 16:03 |
| JayF | yuriyz: because I could very much see wnating to disable sensor data during cleaning | 16:03 |
| *** mjura has quit IRC | 16:03 | |
| yuriyz | JayF ++ and active | 16:03 |
| mariojv | yuriyz: what if we use the stable vs. unstable state distinction? | 16:03 |
| *** links has quit IRC | 16:04 | |
| mariojv | would that make sense at all? | 16:04 |
| mariojv | that way you keep the config binary | 16:04 |
| yuriyz | no for operator I think | 16:04 |
| mariojv | ah, right | 16:04 |
| mariojv | they'd have to know the internals of the state machine | 16:04 |
| JayF | yuriyz: well, I grouped those into deploy group, but IDC if it's separate | 16:04 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 16:05 |
| yuriyz | values set can be: active, deploy, cleaning, idle(available) | 16:05 |
| mariojv | so, i have a suggestion | 16:05 |
| mariojv | i think the less complicated version of this is to just check for active and not maintenance, to close https://bugs.launchpad.net/ironic/+bug/1649884 | 16:06 |
| openstack | Launchpad bug 1649884 in Ironic "Send sensors data is not possible in standalone mode" [Undecided,In progress] - Assigned to Yuriy Zveryanskyy (yzveryanskyy) | 16:06 |
| vdrok | rloo: done :) | 16:06 |
| mariojv | if additional states (which is an additional feature) is desired by anyone, maybe there should be an RFE | 16:06 |
| mariojv | since this is a new config option that slices up the state machine in a new way | 16:06 |
| openstackgerrit | Merged openstack/bifrost: Fix ipa images urls in pxe config https://review.openstack.org/410703 | 16:06 |
| yuriyz | mariojv yes it's not bug related | 16:07 |
| mariojv | ++ | 16:07 |
| mariojv | i'd also be curious to hear from users who actually operate clouds with the sensor feature | 16:07 |
| yuriyz | but only active change behavior of sending sensors (w/o deploy and some unpredictable states) | 16:08 |
| JayF | mariojv: that was nack'd by ruby and i | 16:08 |
| JayF | mariojv: because it changes the existing behavior without a deprecation period | 16:08 |
| mariojv | hm | 16:09 |
| yuriyz | currently we can only fix the bug and add deprecation | 16:10 |
| mariojv | JayF: how does this change the behavior for people who use nova with ironic? active w/o instance nodes? | 16:10 |
| mariojv | JayF: that state seems like a bug if being used with nova and ironic | 16:10 |
| JayF | mariojv: because nova puts the intance uuid on the node /before/ any deploying starts | 16:10 |
| yuriyz | nova writes instance uuid before deploy | 16:10 |
| mariojv | got it | 16:10 |
| JayF | mariojv: so you lose deploying, deploywait, and deleting states collecting data | 16:10 |
| mariojv | so you could have a failed .. yup | 16:10 |
| mariojv | ok | 16:11 |
| mariojv | why not associated || active ? | 16:11 |
| yuriyz | and deploy fail | 16:11 |
| mariojv | all active nodes should already be sending sensor data with nova, since they're associated with an instance | 16:11 |
| mariojv | then the only change would be for people who use standalone | 16:11 |
| mariojv | that feature doesn't currently work for them | 16:11 |
| mariojv | i think a release note would suffice for that | 16:12 |
| JayF | mariojv: assosicated or active would be teh closest thing to existing behavior, you're probably right... but it's still a more useful featuer if it's configurable | 16:12 |
| JayF | mariojv: but I'd be OK With that as a solution | 16:12 |
| mariojv | JayF: i agree, but that is a separate problem in my mind | 16:12 |
| yuriyz | associated causes unpredictable sending data, see my comment for Ruby | 16:12 |
| * mariojv looks | 16:12 | |
| *** krtaylor has quit IRC | 16:13 | |
| soliosg | when zuul runs gate-ironic-releasenotes, what does this error possibly mean? http://logs.openstack.org/75/404975/14/gate/gate-ironic-releasenotes/f1d48b6/console.html | 16:13 |
| soliosg | btw, in regards of Joanna's patch, https://review.openstack.org/#/c/404975/ | 16:13 |
| patchbot | patch 404975 - ironic - Fail ironic startup if no protocol prefix in ironi... | 16:13 |
| *** Goneri has joined #openstack-ironic | 16:14 | |
| mariojv | yuriyz: sorry, can you repeat the comment about associated causing unpredictable sending data? i can't find it | 16:14 |
| JayF | soliosg: a gate issue that's been fixed, you can recheck it | 16:14 |
| yuriyz | mariojv here after Ruby https://review.openstack.org/#/c/410760/1/ironic/conductor/manager.py | 16:17 |
| patchbot | patch 410760 - ironic - Add a possibility to send sensors data in standalo... | 16:17 |
| mariojv | oh, i was looking in irc | 16:18 |
| mariojv | ah, rloo suggested that before i did :) | 16:18 |
| *** mtanino has joined #openstack-ironic | 16:18 | |
| mariojv | yuriyz: i think good documentation will fix the predictability issue | 16:19 |
| mariojv | yuriyz: i also think the RFE follow up could be approved quickly | 16:19 |
| mariojv | i worry about making the config option too complex - ironic's already pretty difficult to configure correctly | 16:20 |
| yuriyz | mariojv ok will prepare rfe about config | 16:20 |
| yuriyz | mariojv ++ | 16:21 |
| yuriyz | should be simple | 16:21 |
| mariojv | cool thanks yuriyz | 16:21 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add portgroup configuration fields https://review.openstack.org/398417 | 16:21 |
| mariojv | so in summary we will go with rloo's suggestion for now (active and associated), or just go ahead with the rfe | 16:21 |
| *** rama_y has joined #openstack-ironic | 16:21 | |
| mariojv | active and associated would not require deprecation period, rfe will | 16:21 |
| mariojv | or rfe could have a default that has existing behavior | 16:22 |
| mariojv | we will see | 16:22 |
| rloo | mariojv: i thought i suggested active or associated? | 16:22 |
| mariojv | right | 16:22 |
| mariojv | or, not and | 16:22 |
| rloo | mariojv: :) i'm good with that too. | 16:22 |
| mariojv | if (active || associated) send_sensor_data | 16:22 |
| rloo | mariojv: just please, no API version bump for that... | 16:22 |
| mariojv | haha | 16:22 |
| yuriyz | and this will be quick fix standalone case w/o instance uuid | 16:23 |
| * mariojv waits for ironic API 1.24378..... | 16:23 | |
| * vdrok has to leave early | 16:23 | |
| vdrok | good night! | 16:23 |
| mariojv | correct yuriyz | 16:23 |
| rloo | bye vdrok! | 16:23 |
| *** jkilpatr_ has joined #openstack-ironic | 16:24 | |
| *** jkilpatr has quit IRC | 16:27 | |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/411059 | 16:27 |
| nicodemos | night vdrok | 16:30 |
| *** jaosorior has quit IRC | 16:30 | |
| *** jaosorior has joined #openstack-ironic | 16:31 | |
| *** tuan_luong has quit IRC | 16:32 | |
| *** rcernin has quit IRC | 16:34 | |
| *** Linkmark has quit IRC | 16:35 | |
| *** swatson has joined #openstack-ironic | 16:35 | |
| *** baoli has quit IRC | 16:36 | |
| *** jaosorior has quit IRC | 16:39 | |
| *** yufei has quit IRC | 16:39 | |
| *** jaosorior has joined #openstack-ironic | 16:40 | |
| *** ccamacho is now known as ccamacho|out | 16:41 | |
| *** pcaruana has quit IRC | 16:42 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Describe possible exception in docstring https://review.openstack.org/411408 | 16:43 |
| *** jpich has quit IRC | 16:51 | |
| jroll | TheJulia: did you ever make a devstack networking diagram thing? | 16:52 |
| *** fragatina has joined #openstack-ironic | 16:53 | |
| TheJulia | No, I saw mariojv was retooling it so I decided to hold off, at least in terms of how we hook into it | 16:53 |
| jroll | ok, thanks | 16:54 |
| mariojv | i'm retooling devstack networking? | 16:54 |
| mariojv | i changed the state machine diagram generation code, but it's a really small changed and blocked on another patch | 16:54 |
| *** rcernin has joined #openstack-ironic | 16:54 | |
| mariojv | s/changed/change | 16:55 |
| *** rama_y has quit IRC | 16:56 | |
| *** fragatina has quit IRC | 16:57 | |
| *** ohamada has quit IRC | 17:01 | |
| openstackgerrit | Jesse J. Cook proposed openstack/ironic-specs: Update rescue spec https://review.openstack.org/407236 | 17:01 |
| *** Nisha_Agarwal has joined #openstack-ironic | 17:02 | |
| jcook | JayF how's that ^ | 17:02 |
| *** wajdi has quit IRC | 17:02 | |
| JayF | jcook: +2 | 17:04 |
| jcook | right on, thanks | 17:04 |
| *** vsaienko has joined #openstack-ironic | 17:05 | |
| openstackgerrit | Merged openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 17:07 |
| * jroll lunches | 17:07 | |
| TheJulia | mariojv: Then I might have you confused with someone else at the moment. I'm a little distracted today. :( | 17:13 |
| *** jkilpatr_ has quit IRC | 17:15 | |
| *** [1]cdearborn has quit IRC | 17:21 | |
| milan | \o/ merged! ^^^ | 17:22 |
| milan | :D | 17:22 |
| *** trown|mtg is now known as trown | 17:22 | |
| *** swatson_ has joined #openstack-ironic | 17:28 | |
| *** jkilpatr has joined #openstack-ironic | 17:28 | |
| jlvillal | FYI: https://www.packtpub.com/ has $5 for every e-book today. This Neutron one might be good: https://www.packtpub.com/virtualization-and-cloud/learning-openstack-networking-neutron-second-edition | 17:29 |
| *** swatson has quit IRC | 17:29 | |
| *** baoli has joined #openstack-ironic | 17:31 | |
| *** derekh has quit IRC | 17:33 | |
| *** dtantsur|brb is now known as dtantsur | 17:36 | |
| dtantsur | morning jroll, NobodyCam, TheJulia, JayF, and everyone else | 17:38 |
| dtantsur | sorry, errands took too long | 17:38 |
| milan | dtantsur, hey! :) | 17:38 |
| NobodyCam | Good Morning dtantsur :) | 17:38 |
| NobodyCam | morning milan :) | 17:38 |
| milan | morning JayF NobodyCam :) | 17:38 |
| JayF | o/ | 17:39 |
| milan | dtantsur, great news, after one day struggle with failing reno, the states patch was merged! :D | 17:39 |
| dtantsur | wooohooo | 17:40 |
| *** mtanino has quit IRC | 17:42 | |
| *** trown is now known as trown|lunch | 17:43 | |
| *** jaosorior has quit IRC | 17:44 | |
| * milan runs | 17:44 | |
| milan | Night Ironic! | 17:44 |
| dtantsur | see you milan | 17:45 |
| milan | see you! :) | 17:45 |
| lucasagomes | milan, see ya | 17:45 |
| milan | o/ :) | 17:45 |
| *** milan has quit IRC | 17:45 | |
| openstackgerrit | Merged openstack/ironic-inspector: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/411117 | 17:47 |
| *** [1]cdearborn has joined #openstack-ironic | 17:47 | |
| *** rama_y has joined #openstack-ironic | 17:48 | |
| *** Romanenko_K has quit IRC | 17:53 | |
| lucasagomes | folks I'm calling it a day as well | 17:54 |
| lucasagomes | have a great evening all | 17:54 |
| *** lucasagomes is now known as lucas-afk | 17:54 | |
| TheJulia | goodnight lucas-afk | 17:54 |
| rloo | bye lucas-afk | 17:55 |
| *** exodusftw has joined #openstack-ironic | 17:55 | |
| lucas-afk | o/ | 17:55 |
| *** exodusftw has quit IRC | 17:59 | |
| *** fragatina has joined #openstack-ironic | 18:02 | |
| mariojv | jcook: JayF: do you think we should have docs for agent rescue (not rescue in general) in ironic, IPA, or both? | 18:03 |
| mariojv | specifically i'm wondering whether i should include them in my agent driver rescue implementation patch | 18:03 |
| *** fragatina has quit IRC | 18:03 | |
| mariojv | maybe we should have ironic docs just link to IPA docs or something, idk | 18:03 |
| *** fragatina has joined #openstack-ironic | 18:04 | |
| * dtantsur leaves again, see you | 18:05 | |
| *** dtantsur is now known as dtantsur|afk | 18:05 | |
| JayF | mariojv: I'd say any docs about customizing rescue by customizing the ramdisk go in ipadevdocs | 18:06 |
| mariojv | then docs about configuring agent rescue on the ironic side go in ironic? | 18:07 |
| JayF | y | 18:07 |
| * jcook defers to JayF | 18:07 | |
| mariojv | which basically just means put the ramdisk in the right place, set up neutron network | 18:07 |
| JayF | all deployer facing docs go into ironic | 18:07 |
| JayF | ipa docs are solely for developers developing things on IPA | 18:07 |
| JayF | or /maybe/ building custom ramdisks | 18:08 |
| mariojv | cool | 18:08 |
| mariojv | i'll put that in my patch then | 18:08 |
| rloo | ciao dtantsur|afk, have a great holiday if I don't talk to you before the new year! | 18:08 |
| *** athomas has quit IRC | 18:12 | |
| *** chlong has joined #openstack-ironic | 18:14 | |
| JayF | Has anyone had experience resolving this particular pep8 error | 18:22 |
| JayF | ./ironic/api/controllers/v1/node.py:477:1: C901 'NodeStatesController.provision' is too complex (18) | 18:22 |
| JayF | it's a new one on me, and I've never seen something complain about method complexity | 18:22 |
| JayF | it smells a little like my patch might have gotten a lot more work ninja'd into it by hacking, but I'm not sure | 18:23 |
| JayF | lol | 18:23 |
| *** vsaienko has quit IRC | 18:24 | |
| *** vsaienko has joined #openstack-ironic | 18:24 | |
| *** amoralej is now known as amoralej|off | 18:27 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM: Testing tempest stuff https://review.openstack.org/411446 | 18:31 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Add 'inspect_ports' as a 'driver_info' parameter to iLO drivers https://review.openstack.org/325230 | 18:31 |
| *** harlowja has joined #openstack-ironic | 18:31 | |
| TheJulia | JayF: I have, basically too many conditional paths detected. It will likely need to be broken into helpers | 18:32 |
| jlvillal | JayF: The function became more complex. Maybe adding additonal arguments or such | 18:32 |
| jlvillal | JayF: Or as TheJulia said, more conditionals. | 18:32 |
| jlvillal | JayF: Is there a link to the patch? | 18:32 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add ironic resources CRUD notifications https://review.openstack.org/356541 | 18:32 |
| jlvillal | JayF: But yeah, breaking it up into smaller functions will fix the issue. Or increasing the complexity allowed in tox.ini. But I'm not sure about that option being a good one. | 18:33 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add node maintenance notifications https://review.openstack.org/396239 | 18:33 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add node console notifications https://review.openstack.org/397812 | 18:34 |
| JayF | jlvillal: it's the rescue api patch, but it didn't start failing until I properly added support for rescue_password | 18:34 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: SNMP agent support for OOB inspection for iLO Drivers https://review.openstack.org/372428 | 18:34 |
| *** fxpester has quit IRC | 18:36 | |
| *** trown|lunch is now known as trown | 18:44 | |
| *** ashestakov has joined #openstack-ironic | 18:44 | |
| *** Nisha_Agarwal has quit IRC | 18:45 | |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Agent driver rescue implementation https://review.openstack.org/400437 | 18:48 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent: Revert "Use liberty-eol tag for liberty release notes" https://review.openstack.org/411279 | 18:50 |
| JayF | TheJulia: a patch already exists | 18:50 |
| JayF | TheJulia: oh, you just edited it | 18:51 |
| TheJulia | yeah | 18:51 |
| JayF | NEVERMIND | 18:51 |
| TheJulia | :) | 18:52 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add storage_interface DB field and object https://review.openstack.org/348005 | 18:52 |
| *** harlowja has quit IRC | 18:52 | |
| *** Sukhdev has joined #openstack-ironic | 18:54 | |
| jlvillal | This seems like the very definition of churn :) We make patch to fix issue with program, then program releases new version to fix issue and kills our workaround, then we have to revert our fix... | 18:55 |
| jlvillal | :( | 18:55 |
| TheJulia | pretty much | 18:55 |
| JayF | jlvillal: it was not intended to break us on 1.9.0 | 18:55 |
| JayF | jlvillal: like our fix was supposed to work across that reno release, just a bug introduced when they fixed the other bug :( | 18:55 |
| JayF | which makes me not worry so much about it, because we've all released buggy code | 18:56 |
| jlvillal | JayF: Yeah. Unfortunately. | 18:56 |
| jlvillal | JayF: Not a huge problem. Just a bit of a time waster. | 18:56 |
| * jlvillal has been guilty of breaking things... | 18:56 | |
| *** dprince has quit IRC | 18:57 | |
| *** dprince has joined #openstack-ironic | 18:58 | |
| JayF | jroll: got a moment to +2A https://review.openstack.org/#/c/411279/ ? | 18:58 |
| patchbot | patch 411279 - ironic-python-agent (stable/newton) - Revert "Use liberty-eol tag for liberty release no... | 18:58 |
| ashestakov | hi folks, can we discuss patches to bifrost for remote installation/enroll/etc? | 18:58 |
| TheJulia | ashestakov: Sure | 18:59 |
| ashestakov | can you pls check this patch https://review.openstack.org/#/c/411299/ | 18:59 |
| patchbot | patch 411299 - bifrost - Allow enroll-dynamic on remote host | 18:59 |
| ashestakov | is it ok way to get it works remotely? | 19:00 |
| *** dsneddon has joined #openstack-ironic | 19:01 | |
| TheJulia | Well, functionally that is the same | 19:01 |
| *** wajdi has joined #openstack-ironic | 19:02 | |
| TheJulia | ashestakov: so, even if not exactly delegated to localhost, whatever host it is delegated to would need shade, as well as supporting libraries | 19:02 |
| *** aNuposic has joined #openstack-ironic | 19:03 | |
| ashestakov | TheJulia: there is issue with group name, inventory.py updates that group with host "127.0.0.1", and then inventory can contain two hosts in group | 19:03 |
| jroll | JayF: done | 19:04 |
| ashestakov | TheJulia: yes, shade installing same as to localhost | 19:05 |
| TheJulia | ashestakov: How do you perceive localhost being added by inventory as a problem? | 19:05 |
| ashestakov | TheJulia: how i running enroll for remote host - ansible-playbook -i my_inventory/ enroll-dynamic.yaml (my_inventory is directory with inventory.py and inventory file) | 19:07 |
| TheJulia | and your local host cannot connect to the api I take it? | 19:07 |
| ashestakov | check pls my dirty fork https://github.com/andreyshestakov/bifrost/tree/works/playbooks/my_inventory (i renamed localhost to 'target') | 19:08 |
| openstackgerrit | Merged openstack/ironic-python-agent: Revert "Use liberty-eol tag for liberty release notes" https://review.openstack.org/411279 | 19:09 |
| TheJulia | ashestakov: It seems like we need to designate a single specific group to perform the actions on explicitly instead of using the localhost group. The default could be localhost though. | 19:11 |
| *** fragatina has quit IRC | 19:11 | |
| openstackgerrit | Merged openstack/ironic: Fail ironic startup if no protocol prefix in ironic api address https://review.openstack.org/404975 | 19:11 |
| ashestakov | it is possible to remove localhost group from inventory.py https://github.com/openstack/bifrost/blob/master/bifrost/inventory.py#L155 | 19:13 |
| ashestakov | but then inventory should contain group with real host | 19:13 |
| ashestakov | and enroll/deploy/etc should execs with multiple inventories, like in my fork - inventory.py and "target" | 19:14 |
| TheJulia | doing so, removing localhost right now without significant changes, seems rather impactful in a potentially negative way | 19:15 |
| ashestakov | yes | 19:15 |
| *** [1]cdearborn has quit IRC | 19:17 | |
| rloo | jroll, jlvillal, JayF, TheJulia: this patch makes portgroup.address optional. this patch merged today: https://review.openstack.org/#/c/335964/ | 19:17 |
| patchbot | patch 335964 - python-ironicclient - Add python API and CLI for port groups (MERGED) | 19:17 |
| TheJulia | so an intermediate step, since the yaml is processed, we default to localhost to a variable but offer variables for the various types of actions, if that makes sense | 19:17 |
| rloo | the patch that merged today allows ironic portgroup-show --address | 19:18 |
| TheJulia | \o/ | 19:18 |
| rloo | but address will be optional, so i'm not sure we should have portgroup-show --address | 19:18 |
| *** dprince has quit IRC | 19:18 | |
| rloo | you can get the same thing via portgroup-list --address | 19:18 |
| *** [1]cdearborn has joined #openstack-ironic | 19:18 | |
| rloo | so should i delete/revert the code that allows that, before it is too late to remove it w/o some deprecation. if we think we want to remove it? | 19:19 |
| rloo | we allow that for port, ie ironic port-show --address, but in that case, port.address is mandatory and unique | 19:19 |
| TheJulia | That is a really good question | 19:20 |
| *** dprince has joined #openstack-ironic | 19:20 | |
| rloo | TheJulia: vdrok, vsaienk0, and sambetts are not around to ask today. | 19:20 |
| TheJulia | rloo: I don't think portgroup-list --address is a big deal. I guess the question is what exactly will the api return when attempted | 19:21 |
| rloo | TheJulia: i'm guessing a portgroup if one exists with the specified mac address | 19:22 |
| TheJulia | yeah, so, I think because it is optional on the command line as well, at least according to the patch, I _think_ it is okay to leave as-is | 19:22 |
| rloo | TheJulia: yeah, it is optional on the command line. It will work, am wondering if it makes sense. | 19:23 |
| rloo | TheJulia: well, since the address has to be unique IF it is specified, I guess it is OK... | 19:23 |
| TheJulia | I think this is going to be one of those things where milage will vary | 19:24 |
| rloo | TheJulia: ok, more power to the user then, I'll leave it in :) | 19:24 |
| rloo | TheJulia: it does make the help for the command a bit odd but we already have it for port, so | 19:25 |
| rloo | thx TheJulia! | 19:25 |
| TheJulia | :) | 19:25 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM: Testing tempest stuff https://review.openstack.org/411446 | 19:36 |
| *** dprince has quit IRC | 19:38 | |
| *** ChubYann has joined #openstack-ironic | 19:40 | |
| ashestakov | TheJulia: this seems works for both cases - delegate_to: "{{ groups['target'][0] if groups['target'] is defined else 'localhost' }}" | 19:41 |
| *** Sukhdev has quit IRC | 19:43 | |
| TheJulia | ashestakov: install_target, node_action_target ? ;) | 19:45 |
| ashestakov | do not understand :) | 19:46 |
| *** vsaienko has joined #openstack-ironic | 19:50 | |
| *** vsaienko has quit IRC | 19:50 | |
| *** mtanino has joined #openstack-ironic | 19:53 | |
| *** eroux has quit IRC | 19:55 | |
| *** rama_y has quit IRC | 19:58 | |
| *** aNuposic has quit IRC | 20:00 | |
| *** dsneddon has quit IRC | 20:00 | |
| *** dsneddon has joined #openstack-ironic | 20:01 | |
| openstackgerrit | Charlle Daniel proposed openstack/ironic: Ensures that OneView nodes are free for use by Ironic https://review.openstack.org/372762 | 20:04 |
| TheJulia | ashestakov I would think if I wanted to install on hosts a,b,c and perform deployments via node host d. | 20:05 |
| *** mjturek has quit IRC | 20:15 | |
| ashestakov | TheJulia: you mean install separate ironics on hosts a b c? | 20:15 |
| TheJulia | eventually yes | 20:15 |
| *** moshele has joined #openstack-ironic | 20:16 | |
| *** derekh has joined #openstack-ironic | 20:17 | |
| *** mjturek has joined #openstack-ironic | 20:19 | |
| ashestakov | for install, you still can add any hosts to localhost group | 20:21 |
| *** mjturek has quit IRC | 20:23 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Log warning if no property for (Un)Set commands https://review.openstack.org/411486 | 20:24 |
| ashestakov | but name 'localhost' may confuse, if you add remote host | 20:24 |
| *** moshele has quit IRC | 20:25 | |
| ashestakov | for enroll/deploy, seems is hard to make changes yet, but you can add to inventory group 'target' with remote host | 20:25 |
| TheJulia | ashestakov: which is why we should ultimately change the group name, but have the default be localhost unless otherwise specified | 20:25 |
| openstackgerrit | Merged openstack/ironic-inspector: Update config sample https://review.openstack.org/411351 | 20:27 |
| ashestakov | is change delegate_to to "{{ groups['target'][0] if groups['target'] is defined else 'localhost' }}", then you can just add group 'target' with remote host if you need, otherwise it will run on localhost as now | 20:27 |
| TheJulia | I think that will work, although I feel like we would want to offer more granularity to anyone who wishes to execute multiple steps together | 20:29 |
| TheJulia | NobodyCam: thoughts on ^^ | 20:29 |
| TheJulia | ? | 20:29 |
| NobodyCam | humm | 20:33 |
| *** e0ne has joined #openstack-ironic | 20:35 | |
| NobodyCam | I do agree that remote hosts in localhost group is not a good thing. I like what ashestakov is is proposing here. maybe instead of target we could use remote_target?? <- just a off the top of the head thought | 20:35 |
| NobodyCam | brb | 20:36 |
| ashestakov | actually, is possible to add 127.0.0.1 to group 'target' by default, effect will same, and if need, 127.1 can be replaced by remote host | 20:39 |
| *** derekh has quit IRC | 20:41 | |
| TheJulia | i suspect we're talking about basically the same thing, but using different words | 20:43 |
| zer0c00l | I am trying to run multiple conductor's on the same host. It looks like i need to set 'host=' in /etc/ironic/ironic.conf for every conductor | 20:51 |
| zer0c00l | My question is how do i avoid having multiple ironic.conf's per conductor? | 20:51 |
| zer0c00l | Is there a way to spawn multiple conductors without having to set have /etc/ironic/ironic.conf | 20:52 |
| jroll | host= defaults to 'hostname', so no | 20:52 |
| zer0c00l | so if i need to run 10 conductors i need to have 10 ironic.conf's ? | 20:52 |
| jroll | if they are on machines with the same hostname, yes | 20:53 |
| zer0c00l | jroll: okay. Doesn't seems to be a pretty solution, can we improve this? | 20:55 |
| zer0c00l | i mean in the future? | 20:55 |
| openstackgerrit | Merged openstack/ironic: Update multitenancy docs https://review.openstack.org/397517 | 20:57 |
| zer0c00l | The ironic-api seems to be using 'workers' https://github.com/openstack/ironic/blob/stable/mitaka/ironic/cmd/api.py#L40 | 20:58 |
| zer0c00l | to spawn multiple api's on a host | 20:58 |
| zer0c00l | perhaps we can reuse it? I don't know if it will break anything | 20:59 |
| TheJulia | each conductor process would need a unique, reproducible, consistent hostname | 20:59 |
| zer0c00l | sure. | 21:00 |
| zer0c00l | Lets say spawn 10 conductors and the hostname is ic1.openstack.example.com | 21:00 |
| mrda | Morning Ironic | 21:00 |
| TheJulia | and if you go from 10 to 9 processes, you would orphan control from nova of nodes created using that conductor process, at least until the same conductor with the same "hostname" re-appeared | 21:00 |
| JayF | You are not going to have a lot of success running multiple conductors on the same host | 21:00 |
| zer0c00l | we can generate this 10 hostnames ic1.openstack.example.com-[1-10] | 21:00 |
| TheJulia | truthfully, cluster management software would likely be a better thing at that point.... | 21:01 |
| JayF | because they're going to stomp all over each others' tftp config | 21:01 |
| zer0c00l | if the nodes are distributed amoung n conductors in the hash ring, why would they stomp on tftp config? | 21:02 |
| zer0c00l | Is there a race condition? | 21:02 |
| jroll | TheJulia: we redistribute periodically, so you'd only lost it for a short time | 21:04 |
| jroll | zer0c00l: tftp can only have one root, and conductor processes expect to own that directory | 21:04 |
| * TheJulia doesn't remember the code that manages the tftp folder structure | 21:04 | |
| TheJulia | jroll: oh, right, completely forgot about that change | 21:04 |
| jroll | TheJulia: it's organized by node, but imagine the failover case where conductor x takes over node n because y died, y comes back, sees node n is no longer managed by it, cleans up config :) | 21:05 |
| TheJulia | jroll: I think if already deployed though it should recreate. It has been a few months since my head was in that part of the code. That and I likely should not be in front of a keyboard right now :) | 21:06 |
| *** e0ne has quit IRC | 21:06 | |
| jroll | jlvillal: we has the grenade +W, feels like everyone is talking past each other in https://review.openstack.org/#/c/404436/ though :( | 21:06 |
| patchbot | patch 404436 - ironic - Move CONF.service_available.ironic to our plugin | 21:06 |
| jroll | TheJulia: yeah ditto :P | 21:06 |
| * TheJulia hears the leaf blowers outside... again... and goes crazy | 21:07 | |
| *** Goneri has quit IRC | 21:07 | |
| jlvillal | jroll: Yeah, glad to have the grenade +W. Unsure about the other patch, if valid concern or not. | 21:07 |
| zer0c00l | hmm, atleast in our deployment we don't expect the pxe config to be there for all the time | 21:07 |
| jroll | zer0c00l: I expect we could make this better if we introduced something like zookeeper, which we want to do but don't have people working on it | 21:07 |
| zer0c00l | pxe config gets cleaned up after 10 mins after the deployment | 21:08 |
| jroll | jlvillal: yeah, your last comment is correct, and that's what this patch does, so :) | 21:08 |
| *** bdeschenes has quit IRC | 21:10 | |
| openstackgerrit | Xavier proposed openstack/ironic: Shutdown server before change boot order for agent drivers https://review.openstack.org/408298 | 21:19 |
| *** dsneddon has quit IRC | 21:25 | |
| ashestakov | NobodyCam: TheJulia: can you clarify what names of groups are ok? | 21:25 |
| *** trown is now known as trown|outtypewww | 21:32 | |
| *** jkilpatr has quit IRC | 21:44 | |
| *** dsneddon has joined #openstack-ironic | 21:46 | |
| *** fragatina has joined #openstack-ironic | 21:46 | |
| *** ashestakov has quit IRC | 21:47 | |
| *** ashestakov has joined #openstack-ironic | 21:47 | |
| *** aNuposic has joined #openstack-ironic | 21:56 | |
| openstackgerrit | Xavier proposed openstack/ironic: Adds validation before delete profile in oneview https://review.openstack.org/386014 | 21:57 |
| *** rama_y has joined #openstack-ironic | 21:59 | |
| *** jkilpatr has joined #openstack-ironic | 22:01 | |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-inspector: Update documentation to deploy Ironic Inspector with DevStack https://review.openstack.org/410456 | 22:03 |
| *** bnemec has quit IRC | 22:10 | |
| *** dsneddon has quit IRC | 22:15 | |
| *** bnemec has joined #openstack-ironic | 22:16 | |
| * jroll done for the day, see y'all tomorrow | 22:19 | |
| *** lindycoder has quit IRC | 22:21 | |
| *** jheroux has quit IRC | 22:21 | |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Enable OSProfiler support in Ironic https://review.openstack.org/358142 | 22:24 |
| *** dsneddon has joined #openstack-ironic | 22:26 | |
| swatson_ | Anyone in the channel familiar with the ironic migration tests? | 22:27 |
| *** jcoufal has quit IRC | 22:34 | |
| *** baoli has quit IRC | 22:45 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add portgroup configuration fields https://review.openstack.org/398417 | 22:45 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 22:46 |
| *** bfournie has quit IRC | 22:47 | |
| *** aNuposic has quit IRC | 22:53 | |
| *** rbudden has quit IRC | 22:55 | |
| *** lindycoder has joined #openstack-ironic | 23:20 | |
| *** aNuposic has joined #openstack-ironic | 23:41 | |
| *** lindycoder has quit IRC | 23:43 | |
| *** lindycoder has joined #openstack-ironic | 23:49 | |
| *** [1]cdearborn has quit IRC | 23:53 | |
| *** wajdi_ has joined #openstack-ironic | 23:56 | |
| *** lindycoder has quit IRC | 23:57 | |
| *** harlowja has joined #openstack-ironic | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!