*** rloo has quit IRC | 00:13 | |
*** mcarden has joined #openstack-ironic | 00:14 | |
*** gyee has quit IRC | 00:17 | |
*** bfournie has joined #openstack-ironic | 00:37 | |
*** hoangcx has quit IRC | 01:07 | |
*** hshiina has joined #openstack-ironic | 01:35 | |
*** MattMan_ has quit IRC | 01:45 | |
*** MattMan_ has joined #openstack-ironic | 01:46 | |
*** Chaserjim has quit IRC | 01:48 | |
*** Chaserjim has joined #openstack-ironic | 01:49 | |
*** Chaserjim has quit IRC | 01:54 | |
*** Chaserjim has joined #openstack-ironic | 02:20 | |
*** lucasagomes has quit IRC | 04:03 | |
*** hshiina has quit IRC | 04:04 | |
*** hshiina has joined #openstack-ironic | 04:04 | |
*** Chaserjim has quit IRC | 04:27 | |
*** skazi has quit IRC | 04:44 | |
*** pcaruana has quit IRC | 04:46 | |
*** e0ne has joined #openstack-ironic | 05:05 | |
openstackgerrit | Ankit Kumar proposed openstack/ironic-specs master: Add 'inspect_ports' as a 'driver_info' parameter to iLO drivers https://review.openstack.org/611238 | 05:25 |
---|---|---|
*** bdodd has quit IRC | 05:25 | |
openstackgerrit | paresh sao proposed openstack/sushy master: Requests session keyword arguments for sushy connector https://review.openstack.org/607809 | 05:26 |
*** bdodd has joined #openstack-ironic | 05:29 | |
*** hjensas has quit IRC | 06:12 | |
iurygregory | good morning | 06:18 |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: [DNM] Testing CI paramaters https://review.openstack.org/607480 | 06:31 |
*** pcaruana has joined #openstack-ironic | 06:34 | |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Begin change over to use python3 https://review.openstack.org/588325 | 06:37 |
*** gabys has quit IRC | 06:41 | |
*** moshele has joined #openstack-ironic | 06:43 | |
*** e0ne has quit IRC | 06:55 | |
*** gabys has joined #openstack-ironic | 06:57 | |
*** adrianc has joined #openstack-ironic | 07:02 | |
*** Chaserjim has joined #openstack-ironic | 07:03 | |
*** gabys has quit IRC | 07:06 | |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Fix CI for CentOS https://review.openstack.org/607480 | 07:08 |
*** Chaserjim has quit IRC | 07:08 | |
*** rcernin has quit IRC | 07:09 | |
*** Chaserjim has joined #openstack-ironic | 07:10 | |
*** hshiina_ has joined #openstack-ironic | 07:13 | |
*** hjensas has joined #openstack-ironic | 07:14 | |
*** Chaserjim has quit IRC | 07:15 | |
*** hshiina has quit IRC | 07:17 | |
etingof | iurygregory, o/ | 07:29 |
iurygregory | etingof, morning =) | 07:29 |
*** sthussey has quit IRC | 07:45 | |
*** mmethot is now known as mmethot|away | 07:49 | |
*** dougsz has joined #openstack-ironic | 08:05 | |
*** Chaserjim has joined #openstack-ironic | 08:14 | |
*** e0ne has joined #openstack-ironic | 08:15 | |
*** Chaserjim has quit IRC | 08:19 | |
openstackgerrit | Digambar proposed openstack/ironic master: Fix CPU count returned by introspection in Ironic iDRAC driver https://review.openstack.org/609982 | 08:23 |
*** tssurya has joined #openstack-ironic | 08:26 | |
derekh | TheJulia: will do | 08:45 |
*** lucasagomes has joined #openstack-ironic | 08:48 | |
*** hshiina_ has quit IRC | 08:56 | |
openstackgerrit | Ankit Kumar proposed openstack/ironic-specs master: Add 'inspect_ports' as a 'driver_info' parameter to iLO drivers https://review.openstack.org/611238 | 09:02 |
*** dtantsur|afk is now known as dtantsur | 09:12 | |
olivierb | morning everyone | 09:13 |
iurygregory | morning =) | 09:13 |
olivierb | I have a question about https://github.com/openstack/bifrost/blob/master/playbooks/roles/bifrost-ironic-install/defaults/main.yml#L9:L13 | 09:13 |
olivierb | why are the *_source_install true in some cases and false in others ? just trying to understand differences of handling for all components | 09:14 |
dtantsur | morning ironic | 09:14 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: Allow streaming raw partition images https://review.openstack.org/605707 | 09:16 |
iurygregory | morning dtantsur o/ | 09:17 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [DNM] Allow streaming raw partition images https://review.openstack.org/610013 | 09:17 |
iurygregory | olivierb, may this will give you an idea i think https://github.com/openstack/bifrost/blob/0232b6b4e507963c035c989a412869903bbe4276/releasenotes/notes/openstacksdk-addition-efec3878ef988295.yaml | 09:19 |
iurygregory | its a way to let configurable so you can install from pypi thats what i understood (not 100% sure) | 09:20 |
iurygregory | s/may/maybe | 09:21 |
olivierb | iurygregory thanks I now understand this point but wonderning for instance why *client_source_install are false compared to ironicinspector_source_install true for instance | 09:23 |
olivierb | s/for instance// ;-) | 09:23 |
sambetts|afk | we typically always install the clients from released versions, even in CI, however the services were never published to pypi so we always had to install them from source until recently | 09:24 |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Begin change over to use python3 https://review.openstack.org/588325 | 09:24 |
iurygregory | sambetts|afk, tks! olivierb see his answer =) | 09:27 |
openstackgerrit | Ankit Kumar proposed openstack/ironic-specs master: Add 'inspect_ports' as a 'driver_info' parameter to iLO drivers https://review.openstack.org/611238 | 09:33 |
*** Emine has joined #openstack-ironic | 09:40 | |
openstackgerrit | Nguyen Van Trung proposed openstack/ironic master: [WIP] Support firmware upgrade for irmc driver https://review.openstack.org/599992 | 09:43 |
olivierb | sambetts|afk ok this makes sense, however if you look at http://logs.openstack.org/25/588325/35/check/bifrost-integration-tinyipa-ubuntu-xenial/c90fe2b/job-output.txt.gz (Python3) this may be an issue, currently testing this | 09:44 |
sambetts|afk | olivierb: the cannot uninstall packages from the system is the main reason for switching to using virtualenvs for everything I think | 09:46 |
olivierb | sambetts|afk got it | 09:47 |
olivierb | thx | 09:47 |
sambetts|afk | I don't think switching between packaged version and source version will make a difference on that, because either way the dependecies are the same, and if they conflict with the system install packages then pip will explode trying to install it | 09:48 |
sambetts|afk | uninstall it | 09:48 |
sambetts|afk | so unless you "apt-get uninstall pyyaml" first then it makes pip sad | 09:49 |
*** adrianc has quit IRC | 09:53 | |
openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: playbooks: Convert venv_python_path to proper role https://review.openstack.org/610898 | 10:05 |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Fix typo https://review.openstack.org/611282 | 10:07 |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Begin change over to use python3 https://review.openstack.org/588325 | 10:08 |
*** adrianc has joined #openstack-ironic | 10:09 | |
*** Emine has quit IRC | 10:10 | |
*** Emine has joined #openstack-ironic | 10:13 | |
*** Emine has quit IRC | 10:30 | |
*** e0ne has quit IRC | 10:45 | |
*** Emine has joined #openstack-ironic | 10:50 | |
*** Chaserjim has joined #openstack-ironic | 10:52 | |
*** Chaserjim has quit IRC | 10:57 | |
jroll | morninnnnng | 11:05 |
iurygregory | morning jroll o/ | 11:06 |
*** moshele has quit IRC | 11:22 | |
*** bfournie has quit IRC | 11:22 | |
*** pcaruana has quit IRC | 11:28 | |
*** moshele has joined #openstack-ironic | 11:29 | |
dtantsur | morning jroll | 11:43 |
*** e0ne has joined #openstack-ironic | 11:46 | |
*** dtantsur is now known as dtantsur|brb | 11:48 | |
*** trown|outtypewww is now known as trown | 11:56 | |
*** bfournie has joined #openstack-ironic | 11:57 | |
iurygregory | dtantsur|brb, tks for the +A ;) do you want a patch to change what you said? =) | 11:59 |
*** mmethot|away is now known as mmethot | 12:03 | |
*** moshele has quit IRC | 12:04 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic-specs master: No IPA to conductor communication https://review.openstack.org/212206 | 12:05 |
*** moshele has joined #openstack-ironic | 12:05 | |
jroll | this becomes more work on each revision | 12:05 |
*** rh-jelabarre has joined #openstack-ironic | 12:06 | |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Fix CI for CentOS https://review.openstack.org/607480 | 12:19 |
iurygregory | jroll, do you have a minute for a newbie question? | 12:23 |
jroll | iurygregory: you can always ask, I may not have the answer :) | 12:23 |
*** pcaruana has joined #openstack-ironic | 12:24 | |
iurygregory | jroll, i was reviewing a patch, if a new attribute is added to a class i should keep the alphabetical order right? like https://review.openstack.org/#/c/547356/27/ironic/drivers/base.py | 12:25 |
patchbot | patch 547356 - ironic - Implement basic interfaces for GraphicalConsole In... - 27 patch sets | 12:25 |
iurygregory | it should go after deploy the new attribute i think | 12:26 |
jroll | iurygregory: in general, it doesn't matter. since we have it alphabetical there, I'd prefer to keep it that way. but it's a bit of a nit, I guess | 12:26 |
iurygregory | jroll, tks =) | 12:27 |
*** moshele has quit IRC | 12:49 | |
*** moshele has joined #openstack-ironic | 12:51 | |
*** Chaserjim has joined #openstack-ironic | 12:53 | |
*** dtantsur|brb is now known as dtantsur | 12:55 | |
*** Chaserjim has quit IRC | 12:57 | |
*** dnuka has joined #openstack-ironic | 12:59 | |
*** hjensas has quit IRC | 13:06 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Allow streaming raw partition images https://review.openstack.org/610013 | 13:08 |
dtantsur | this seems to work now ^^^ | 13:08 |
iurygregory | \o/ | 13:12 |
*** sthussey has joined #openstack-ironic | 13:15 | |
*** Chaserjim has joined #openstack-ironic | 13:27 | |
TheJulia | mgoddard: would you please press the restore button on https://review.openstack.org/#/c/600411/ ? | 13:30 |
patchbot | patch 600411 - governance - Add tenks under Ironic governance (ABANDONED) - 1 patch set | 13:30 |
TheJulia | jroll: sorry :( | 13:31 |
*** Chaserjim has quit IRC | 13:32 | |
TheJulia | Can I twist anyone's arm for an ipa review? https://review.openstack.org/#/c/592639/ | 13:37 |
patchbot | patch 592639 - ironic-python-agent - Fix multi-device behavior - 5 patch sets | 13:37 |
openstackgerrit | Merged openstack/ironic-specs master: Add virtual Bare Metal Clusters spec https://review.openstack.org/579583 | 13:37 |
*** dims has quit IRC | 13:40 | |
dtantsur | folks, you can make the word a bit better place (at least for the other side of API) by reviewing https://review.openstack.org/596671 :) | 13:40 |
patchbot | patch 596671 - ironic - Add version discovery information to the /v1 endpoint - 1 patch set | 13:40 |
dtantsur | * world | 13:40 |
*** gabys has joined #openstack-ironic | 13:43 | |
TheJulia | I'm surprised I've not reviewed this, I thought I had | 13:44 |
*** munimeha1 has joined #openstack-ironic | 13:47 | |
*** mgoddard has quit IRC | 13:49 | |
*** mjturek has joined #openstack-ironic | 13:54 | |
*** mgoddard has joined #openstack-ironic | 13:54 | |
*** gabys has quit IRC | 14:00 | |
*** gabys has joined #openstack-ironic | 14:01 | |
*** dims has joined #openstack-ironic | 14:03 | |
*** gabys has quit IRC | 14:06 | |
*** dims has quit IRC | 14:16 | |
*** rloo has joined #openstack-ironic | 14:17 | |
openstackgerrit | Ilya Etingof proposed openstack/sushy master: Untie `Connection` object from authenticator object on `.close()` https://review.openstack.org/611095 | 14:19 |
*** dims has joined #openstack-ironic | 14:19 | |
*** Chaserjim has joined #openstack-ironic | 14:20 | |
openstackgerrit | Merged openstack/ironic master: Remove Vagrant https://review.openstack.org/610964 | 14:22 |
iurygregory | yay 1st patch \o/ | 14:23 |
TheJulia | :) | 14:23 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector master: Remove deprecate authentication options for accessing ironic https://review.openstack.org/587041 | 14:26 |
dtantsur | congrats iurygregory :) | 14:27 |
iurygregory | tks 1st of many \o/ | 14:28 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector master: Remove deprecated authentication options for accessing ironic https://review.openstack.org/587041 | 14:31 |
*** openstackgerrit has quit IRC | 14:36 | |
*** logan_ has joined #openstack-ironic | 14:40 | |
*** hamzy has quit IRC | 14:41 | |
*** bdodd_ has joined #openstack-ironic | 14:47 | |
*** rloo has quit IRC | 14:49 | |
*** munimeha1 has quit IRC | 14:49 | |
*** sthussey has quit IRC | 14:49 | |
*** bdodd has quit IRC | 14:49 | |
*** devananda has quit IRC | 14:49 | |
*** vabada has quit IRC | 14:49 | |
*** logan- has quit IRC | 14:49 | |
*** logan_ is now known as logan- | 14:49 | |
*** Chaserjim has quit IRC | 14:54 | |
*** dnuka has quit IRC | 14:54 | |
*** bdodd_ is now known as bdodd | 14:57 | |
*** openstackgerrit has joined #openstack-ironic | 15:10 | |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Fix typos https://review.openstack.org/611282 | 15:10 |
openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Begin change over to use python3 https://review.openstack.org/588325 | 15:11 |
*** hamzy has joined #openstack-ironic | 15:12 | |
openstackgerrit | Christopher Dearborn proposed openstack/ironic-specs master: Add firmware update spec for Dell EMC hardware https://review.openstack.org/602132 | 15:15 |
NobodyCam | Good Morning Ironic'ers | 15:15 |
NobodyCam | Happy Hump Day | 15:15 |
dtantsur | hey hey NobodyCam | 15:15 |
TheJulia | \o/ hump day | 15:16 |
NobodyCam | :) Good Morning dtantsur and TheJulia | 15:16 |
olivierb | good afternoon everyone ;-) | 15:17 |
dtantsur | g'afternoon olivierb | 15:17 |
*** rloo has joined #openstack-ironic | 15:18 | |
*** rloo has quit IRC | 15:19 | |
*** rloo has joined #openstack-ironic | 15:20 | |
*** Chaserjim has joined #openstack-ironic | 15:21 | |
bdodd | Good morning everyone | 15:22 |
dtantsur | morning bdodd | 15:22 |
bdodd | dtantsur o/ | 15:22 |
bdodd | Regarding the Redfish BIOS implementation, I’m having some trouble with my periodic task to monitor the success or failure of setting the BIOS attributes and could use some input. | 15:23 |
bdodd | In the apply_configuration() clean step, after I have set the BIOS attributes on the system, I issue a reboot to the system, set 'cleaning_reboot' in driver_internal_info and return states.CLEANWAIT. | 15:24 |
bdodd | When my period task fires, I locate the target task and check if the BIOS settings were made in the server. | 15:24 |
bdodd | If I find that the BIOS settings were not applied, I can log the error and set the last_error. | 15:24 |
bdodd | So far, so good | 15:25 |
bdodd | But typically the state of the node has already gone through the cleaning and clean wait states and is already back in manageable state. | 15:25 |
bdodd | So I can’t (as far as I can tell) move the state to clean failed. | 15:26 |
bdodd | I was expecting or wanting the state to be held in cleaning or clean wait until the periodic task could verify the BIOS settings and be able to issue a ‘fail’ event to move it to clean failed. | 15:26 |
*** moshele has quit IRC | 15:27 | |
*** rloo has quit IRC | 15:27 | |
openstackgerrit | Merged openstack/sushy master: Fix crashing `BasicAuth` context manager https://review.openstack.org/611107 | 15:28 |
bdodd | Not sure if I'm taking the right approach or completely off in the weeds. Any insights appreciated. :-) | 15:29 |
dtantsur | etingof: ^^^ | 15:29 |
olivierb | dtantsur glad you liked the green CI | 15:29 |
TheJulia | bdodd: weeds can grow quickly :( I'm on a meeting right now so I'll try to read/grok what you wrote after my meeting | 15:30 |
bdodd | Sure, thanks TheJulia | 15:30 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic-specs master: No IPA to conductor communication https://review.openstack.org/212206 | 15:39 |
*** vdrok has quit IRC | 15:41 | |
*** vdrok has joined #openstack-ironic | 15:42 | |
*** gabys has joined #openstack-ironic | 15:51 | |
*** gabys has quit IRC | 15:56 | |
*** gabys has joined #openstack-ironic | 16:01 | |
*** hamzy has quit IRC | 16:01 | |
*** hamzy has joined #openstack-ironic | 16:01 | |
openstackgerrit | Merged openstack/ironic-python-agent stable/rocky: Raise udevadm settle timeout from 5 to 20 seconds https://review.openstack.org/610148 | 16:02 |
openstackgerrit | Merged openstack/ironic-python-agent master: Add missing dependencies to CoreOS IPA docker image https://review.openstack.org/610933 | 16:02 |
*** gabys has quit IRC | 16:06 | |
TheJulia | bdodd: so, cleaning reboot should occur, task should hang in CLEANWAIT until the next heartbeat occurs | 16:06 |
TheJulia | bdodd: I guess at that point the steps on the bios interface would need a sanity check/validate step in that case to verify. I know there is the collect current bios configuration as well | 16:07 |
openstackgerrit | Pierre Riteau proposed openstack/ironic-python-agent stable/rocky: Add missing dependencies to CoreOS IPA docker image https://review.openstack.org/611377 | 16:07 |
*** priteau has joined #openstack-ironic | 16:08 | |
TheJulia | the collection step after cleaning could fail it if it still has the requested data, I guess. Or I think you can issue a cleaning reboot and the step not yet be completed | 16:09 |
openstackgerrit | Pierre Riteau proposed openstack/ironic-python-agent stable/queens: Add missing dependencies to CoreOS IPA docker image https://review.openstack.org/611379 | 16:12 |
*** tssurya has quit IRC | 16:14 | |
bdodd | TheJulia - Ah, so perhaps I should be making my checks in the cache_bios_settings() call rather than in a periodic task. Is that along the lines of what you are thinking? | 16:16 |
TheJulia | I feel like the step can issue the reboot with the flag step, and upon recollection with the next heartbeat in, then it should run | 16:16 |
TheJulia | bdodd: two different ways to do it I think | 16:16 |
TheJulia | but I don't think a periodic task is the best way because as you've indicated it never really catches the failure | 16:16 |
TheJulia | I guess I need to look at the code to think through this too, is the patch up to date? | 16:17 |
bdodd | TheJulia No, I haven't updated the patch with this code yet. Was hoping to get it working better first. | 16:18 |
* TheJulia opens up the cleaning code | 16:19 | |
*** gabys has joined #openstack-ironic | 16:19 | |
openstackgerrit | Ilya Etingof proposed openstack/sushy master: Untie `Connection` from authenticator on `.close()` https://review.openstack.org/611095 | 16:19 |
*** sthussey_ has joined #openstack-ironic | 16:20 | |
*** munimeha1 has joined #openstack-ironic | 16:24 | |
*** sthussey has joined #openstack-ironic | 16:24 | |
*** vabada has joined #openstack-ironic | 16:24 | |
*** sthussey has quit IRC | 16:24 | |
*** sthussey_ is now known as sthussey | 16:24 | |
*** gabys has quit IRC | 16:25 | |
*** rloo has joined #openstack-ironic | 16:26 | |
*** moshele has joined #openstack-ironic | 16:26 | |
*** dtantsur is now known as dtantsur|afk | 16:27 | |
dtantsur|afk | see you tomorrow | 16:27 |
TheJulia | bdodd: two choices I think. One we update the conductor cleaning logic to have a second flag "reboot in progress as part of step" (although that gets complex with already complex logic... we might need it anyone one day) or you do validation in the cache step and can fail the cleaning there. The downside of the latter idea is someone would need to manually invoke it along side setting the configuration | 16:28 |
TheJulia | goodnight dtantsur|afk | 16:28 |
TheJulia | actually | 16:29 |
TheJulia | set driver internal info 'skip_current_clean_step' to False | 16:29 |
TheJulia | it should re-call the same step | 16:29 |
TheJulia | so you could keep a driveR_internal_info flag to know if your in-progress or not | 16:30 |
TheJulia | and validate if you are post-apply, then just make sure we nuke the driver_internal_info flag you created before exiting the second call of apply_configuration | 16:31 |
bdodd | TheJulia - just to clarify - at what point should I set 'skip_current_clean_step'? | 16:31 |
TheJulia | bdodd: when you set cleaning_reboot | 16:31 |
*** rloo has quit IRC | 16:32 | |
TheJulia | apply_configuration should get called again upon the next heartbeat, and you can do validation then | 16:32 |
*** jesusaur has quit IRC | 16:32 | |
TheJulia | bdodd: so you set the two driver_internal_info flags, tell the hardware to reboot, and I guess you can just let the method exit such that we are still waiting for cleaning | 16:33 |
bdodd | So the first apply_config would doing the BIOS settings and reboot and the second would check the result, right? | 16:34 |
TheJulia | yup | 16:35 |
bdodd | TheJulia - Thanks! I think I get the idea. I'll try that out. | 16:36 |
TheJulia | the changes just need to be saved to the node object (task.node.save()) | 16:36 |
bdodd | Right | 16:36 |
TheJulia | awesome | 16:37 |
*** gabys has joined #openstack-ironic | 16:37 | |
*** jesusaur has joined #openstack-ironic | 16:37 | |
*** moshele has quit IRC | 16:38 | |
*** gabys has quit IRC | 16:43 | |
*** e0ne has quit IRC | 16:46 | |
*** gabys has joined #openstack-ironic | 16:54 | |
*** dougsz has quit IRC | 16:58 | |
*** gabys has quit IRC | 16:59 | |
*** derekh has quit IRC | 17:00 | |
*** rloo has joined #openstack-ironic | 17:06 | |
*** hamzy has quit IRC | 17:07 | |
*** hamzy has joined #openstack-ironic | 17:08 | |
*** rloo has quit IRC | 17:12 | |
*** hamzy has quit IRC | 17:12 | |
*** hamzy has joined #openstack-ironic | 17:12 | |
*** rloo has joined #openstack-ironic | 17:12 | |
*** rloo has quit IRC | 17:14 | |
*** rloo has joined #openstack-ironic | 17:14 | |
*** gabys has joined #openstack-ironic | 17:15 | |
*** rloo has quit IRC | 17:17 | |
*** rloo has joined #openstack-ironic | 17:18 | |
*** gabys has quit IRC | 17:19 | |
*** adrianc has quit IRC | 17:20 | |
*** hjensas has joined #openstack-ironic | 17:24 | |
*** trown is now known as trown|lunch | 17:28 | |
*** gabys has joined #openstack-ironic | 17:50 | |
*** gabys has quit IRC | 17:55 | |
openstackgerrit | Christopher Dearborn proposed openstack/ironic-specs master: Add firmware update spec for Dell EMC hardware https://review.openstack.org/602132 | 18:02 |
*** mgoddard has quit IRC | 18:11 | |
*** gabys has joined #openstack-ironic | 18:14 | |
*** gabys has quit IRC | 18:18 | |
TheJulia | hjensas: fyi, I'm going to tag you on a review re ipv6/boot-from-url support | 18:22 |
*** skazi has joined #openstack-ironic | 18:31 | |
*** e0ne has joined #openstack-ironic | 18:35 | |
*** moshele has joined #openstack-ironic | 18:37 | |
*** mbeierl has quit IRC | 18:38 | |
*** trown|lunch is now known as trown | 18:44 | |
*** e0ne has quit IRC | 18:48 | |
*** e0ne has joined #openstack-ironic | 18:49 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic master: Add api-ref for conductor group https://review.openstack.org/611415 | 18:52 |
jroll | people that love docs, this is for you ^ | 18:52 |
*** e0ne has quit IRC | 18:55 | |
*** mbeierl has joined #openstack-ironic | 19:05 | |
*** jesusaur has quit IRC | 19:08 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic master: Add api-ref for conductor group https://review.openstack.org/611415 | 19:08 |
*** gabys has joined #openstack-ironic | 19:10 | |
*** jesusaur has joined #openstack-ironic | 19:12 | |
*** gabys has quit IRC | 19:14 | |
*** moshele has quit IRC | 19:15 | |
TheJulia | <3 | 19:19 |
*** hamzy has quit IRC | 19:21 | |
*** hamzy has joined #openstack-ironic | 19:21 | |
*** e0ne has joined #openstack-ironic | 19:22 | |
mjturek | TheJulia: been looking through your ipxe boot interface patch. I admittedly haven't checked out the entire series so I might be missing some context, but is passing around ipxe_enabled as an arg intended as a temporary measure? Once [pxe]ipxe_enabled is removed you should be able to infer ipxe_enabled from just the task object. Or are you trying to avoid the weirdness you mention in is_ipxe_enabled? | 19:26 |
mjturek | sorry for the wall of text | 19:26 |
*** hamzy has quit IRC | 19:30 | |
*** jtomasek has quit IRC | 19:38 | |
*** e0ne has quit IRC | 19:42 | |
*** moshele has joined #openstack-ironic | 19:49 | |
TheJulia | mjturek: no worries | 19:50 |
TheJulia | it really seems dtantsur wants to avoid inferring from the task object, so passing in as an argument seems to be our cleanest delination since we also end up then doing less calls back to an is_ipxe_enabled method | 19:51 |
mjturek | okay - that's a fair reason! | 19:51 |
TheJulia | yeah, I thought about the cost of object comparisons too, and he does have a point that it is more costly | 19:52 |
TheJulia | so... *shrug* | 19:52 |
mjturek | agreed, it just seemed so tempting lol | 19:52 |
TheJulia | oh I know :) | 19:55 |
TheJulia | kind of why I did it :) | 19:55 |
*** moshele has quit IRC | 20:02 | |
*** hamzy has joined #openstack-ironic | 20:17 | |
*** gabys has joined #openstack-ironic | 20:43 | |
*** trown is now known as trown|outtypewww | 21:07 | |
*** rcernin has joined #openstack-ironic | 21:18 | |
*** olivierb has quit IRC | 21:30 | |
*** rloo has quit IRC | 21:32 | |
*** gabys has quit IRC | 21:35 | |
*** gabys has joined #openstack-ironic | 21:35 | |
*** rloo has joined #openstack-ironic | 21:38 | |
*** gabys has quit IRC | 21:40 | |
*** priteau has quit IRC | 21:50 | |
*** bnemec has quit IRC | 22:01 | |
*** bfournie has quit IRC | 22:02 | |
*** munimeha1 has quit IRC | 22:20 | |
*** Chaserjim has quit IRC | 22:52 | |
*** Chaserjim has joined #openstack-ironic | 22:53 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix IPv6 and add initial boot-from-url https://review.openstack.org/610715 | 22:57 |
*** Chaserjim has quit IRC | 22:58 | |
*** Chaserjim has joined #openstack-ironic | 22:59 | |
*** Chaserjim has quit IRC | 23:03 | |
*** rloo has quit IRC | 23:10 | |
*** gabys has joined #openstack-ironic | 23:43 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!