| *** mjturek has quit IRC | 00:05 | |
| *** Chaserjim has joined #openstack-ironic | 00:08 | |
| *** dsneddon_away is now known as dsneddon | 00:21 | |
| *** sthussey has quit IRC | 00:25 | |
| *** Chaserjim has quit IRC | 00:28 | |
| *** gabys has quit IRC | 00:43 | |
| *** gabys has joined #openstack-ironic | 00:44 | |
| *** gabys has quit IRC | 00:48 | |
| *** bfournie has joined #openstack-ironic | 01:00 | |
| *** Emine has quit IRC | 01:22 | |
| *** Emine has joined #openstack-ironic | 01:23 | |
| *** MattMan_ has quit IRC | 01:46 | |
| *** MattMan_ has joined #openstack-ironic | 01:46 | |
| *** moshele has joined #openstack-ironic | 01:50 | |
| *** moshele has quit IRC | 02:02 | |
| jiapei | Morning Ironicers | 02:03 |
|---|---|---|
| *** Emine has quit IRC | 02:23 | |
| openstackgerrit | Kaifeng Wang proposed openstack/python-ironicclient master: Fix a LOG.warning which didn't work properly https://review.openstack.org/611485 | 02:54 |
| *** rcernin has quit IRC | 03:02 | |
| *** bnemec has joined #openstack-ironic | 03:05 | |
| *** bnemec has quit IRC | 03:10 | |
| *** rcernin has joined #openstack-ironic | 03:28 | |
| openstackgerrit | Tuan Do Anh proposed openstack/ironic master: Add download link apache configuration with mod_wsgi https://review.openstack.org/611497 | 04:37 |
| *** skazi has quit IRC | 04:58 | |
| *** moshele has joined #openstack-ironic | 06:13 | |
| *** jtomasek has joined #openstack-ironic | 06:18 | |
| *** Chaserjim has joined #openstack-ironic | 06:20 | |
| *** Chaserjim has quit IRC | 06:25 | |
| *** Emine has joined #openstack-ironic | 06:37 | |
| *** adrianc has joined #openstack-ironic | 06:38 | |
| *** e0ne has joined #openstack-ironic | 06:38 | |
| *** Emine has quit IRC | 06:42 | |
| *** iurygregory has quit IRC | 06:44 | |
| *** gabys has joined #openstack-ironic | 06:49 | |
| *** gabys has quit IRC | 06:54 | |
| *** gabys has joined #openstack-ironic | 07:05 | |
| *** rcernin has quit IRC | 07:07 | |
| *** gabys has quit IRC | 07:10 | |
| *** persia has quit IRC | 07:19 | |
| *** persia has joined #openstack-ironic | 07:21 | |
| *** Chaserjim has joined #openstack-ironic | 07:23 | |
| *** gabys has joined #openstack-ironic | 07:31 | |
| *** openstackgerrit has quit IRC | 07:35 | |
| *** gabys has quit IRC | 07:36 | |
| *** iurygregory has joined #openstack-ironic | 07:38 | |
| *** openstackgerrit has joined #openstack-ironic | 07:53 | |
| openstackgerrit | Nguyen Van Trung proposed openstack/ironic master: [WIP] Support firmware upgrade for irmc driver https://review.openstack.org/599992 | 07:53 |
| *** dtantsur|afk is now known as dtantsur | 07:56 | |
| dtantsur | TheJulia: my even biggest point is that isinstance(task.driver, SomeHardwareType) undermines the driver composition and creates non-trivial links from generic code to specific implementations | 07:57 |
| dtantsur | morning ironic | 07:57 |
| *** gabys has joined #openstack-ironic | 07:58 | |
| *** e0ne has quit IRC | 08:02 | |
| *** gabys has quit IRC | 08:02 | |
| openstackgerrit | Kaifeng Wang proposed openstack/ironic-specs master: Provides detailed conductor information https://review.openstack.org/528158 | 08:07 |
| *** dougsz has joined #openstack-ironic | 08:08 | |
| *** e0ne has joined #openstack-ironic | 08:13 | |
| iurygregory | morning all =) | 08:13 |
| dtantsur | morning iurygregory | 08:13 |
| *** tssurya has joined #openstack-ironic | 08:16 | |
| *** gabys has joined #openstack-ironic | 08:17 | |
| *** olivierb has joined #openstack-ironic | 08:20 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector master: Remove deprecated authentication options for accessing ironic https://review.openstack.org/587041 | 08:21 |
| *** gabys has quit IRC | 08:22 | |
| *** jesusaur has quit IRC | 08:38 | |
| *** derekh has joined #openstack-ironic | 08:39 | |
| *** jaganathan has quit IRC | 08:47 | |
| *** gabys has joined #openstack-ironic | 09:20 | |
| *** gkadam has joined #openstack-ironic | 09:21 | |
| *** gkadam has quit IRC | 09:21 | |
| *** gabys has quit IRC | 09:24 | |
| *** jesusaur has joined #openstack-ironic | 09:31 | |
| *** adrianc has quit IRC | 09:36 | |
| *** betherly has joined #openstack-ironic | 09:43 | |
| *** priteau has joined #openstack-ironic | 09:52 | |
| hjensas | good morning iurygregory dtantsur and all. .) | 09:53 |
| dtantsur | morning hjensas | 09:59 |
| iurygregory | morning hjensas | 10:03 |
| *** iurygregory is now known as iurygregory|lunc | 10:04 | |
| *** adrianc has joined #openstack-ironic | 10:12 | |
| priteau | dtantsur: Thank you for the W+1 on my backports for CoreOS fixes! | 10:15 |
| dtantsur | sure thing | 10:15 |
| priteau | Are images available at http://tarballs.openstack.org/ironic-python-agent/coreos/ rebuilt automatically by gate jobs? | 10:17 |
| dtantsur | priteau: they are (unless the jobs are broken) | 10:18 |
| dtantsur | now, a disclaimer: we are not doing great job updating the underlying coreos to latest releases | 10:19 |
| dtantsur | we should probably put it somewhere in the docs.. | 10:19 |
| *** S4ren has joined #openstack-ironic | 10:22 | |
| *** iurygregory|lunc is now known as iurygregory | 10:28 | |
| *** Chaserjim has quit IRC | 10:31 | |
| *** gabys has joined #openstack-ironic | 10:41 | |
| *** gabys has quit IRC | 10:45 | |
| openstackgerrit | yolanda.robla proposed openstack/python-ironicclient master: Add management of automated_clean field https://review.openstack.org/586508 | 10:47 |
| *** gabys has joined #openstack-ironic | 10:55 | |
| *** Chaserjim has joined #openstack-ironic | 10:57 | |
| *** gabys has quit IRC | 11:00 | |
| *** Chaserjim has quit IRC | 11:03 | |
| openstackgerrit | Merged openstack/ironic-lib stable/queens: Check GPT table with sgdisk insread of partprobe https://review.openstack.org/608795 | 11:15 |
| *** gabys has joined #openstack-ironic | 11:24 | |
| *** gabys has quit IRC | 11:28 | |
| openstackgerrit | Merged openstack/ironic-python-agent stable/rocky: Add missing dependencies to CoreOS IPA docker image https://review.openstack.org/611377 | 11:29 |
| openstackgerrit | Merged openstack/ironic-python-agent stable/queens: Add missing dependencies to CoreOS IPA docker image https://review.openstack.org/611379 | 11:29 |
| *** gabys has joined #openstack-ironic | 11:33 | |
| *** gabys has quit IRC | 11:37 | |
| *** Chaserjim has joined #openstack-ironic | 11:37 | |
| *** Chaserjim has quit IRC | 11:42 | |
| openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Begin change over to use python3 https://review.openstack.org/588325 | 11:42 |
| *** e0ne has quit IRC | 11:50 | |
| *** gabys has joined #openstack-ironic | 11:57 | |
| *** bfournie has quit IRC | 12:00 | |
| *** gabys has quit IRC | 12:01 | |
| *** Chaserjim has joined #openstack-ironic | 12:09 | |
| *** Chaserjim has quit IRC | 12:14 | |
| *** Chaserjim has joined #openstack-ironic | 12:15 | |
| *** Chaserjim has quit IRC | 12:20 | |
| *** dnuka has joined #openstack-ironic | 12:27 | |
| *** dims has quit IRC | 12:30 | |
| *** trown|outtypewww is now known as trown | 12:30 | |
| *** dims has joined #openstack-ironic | 12:33 | |
| *** bfournie has joined #openstack-ironic | 12:33 | |
| *** jesusaur has quit IRC | 12:33 | |
| *** gkadam has joined #openstack-ironic | 12:34 | |
| *** Chaserjim has joined #openstack-ironic | 12:39 | |
| *** adrianc has quit IRC | 12:41 | |
| *** adrianc has joined #openstack-ironic | 12:42 | |
| *** Chaserjim has quit IRC | 12:44 | |
| *** Chaserjim has joined #openstack-ironic | 12:51 | |
| TheJulia | brraaaiiinnsss | 12:55 |
| *** Chaserjim has quit IRC | 12:56 | |
| *** Chaserjim has joined #openstack-ironic | 12:58 | |
| iurygregory | zombies =D | 12:59 |
| *** juhak has quit IRC | 13:02 | |
| *** Chaserjim has quit IRC | 13:03 | |
| openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Begin change over to use python3 https://review.openstack.org/588325 | 13:06 |
| *** e0ne has joined #openstack-ironic | 13:07 | |
| *** gabys has joined #openstack-ironic | 13:08 | |
| *** jrist has quit IRC | 13:11 | |
| *** juhak has joined #openstack-ironic | 13:12 | |
| *** gabys has quit IRC | 13:13 | |
| *** jrist has joined #openstack-ironic | 13:13 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix DHCPv6 support https://review.openstack.org/611600 | 13:14 |
| TheJulia | dtantsur: ^^^ that is much more along the lines of something that could be backported | 13:16 |
| TheJulia | maybe move contents slightly around, but yah | 13:17 |
| TheJulia | now to see if it actually works... | 13:17 |
| TheJulia | priteau: for the record, the images are built by a post job, so if the post job queue is really backed up it may be a few hours before new images are built and uploaded. | 13:18 |
| priteau | TheJulia: Good to know. I see new images are up now. | 13:19 |
| TheJulia | \o/ | 13:20 |
| *** mjturek has joined #openstack-ironic | 13:22 | |
| *** Chaserjim has joined #openstack-ironic | 13:23 | |
| *** munimeha1 has joined #openstack-ironic | 13:29 | |
| *** Chaserjim has quit IRC | 13:29 | |
| *** gabys has joined #openstack-ironic | 13:31 | |
| *** Chaserjim has joined #openstack-ironic | 13:31 | |
| dtantsur | morning TheJulia, thanks | 13:31 |
| *** gabys has quit IRC | 13:35 | |
| *** mjturek has quit IRC | 13:43 | |
| *** bnemec has joined #openstack-ironic | 13:43 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: wip: Add boot from http url https://review.openstack.org/610715 | 13:57 |
| *** gabys has joined #openstack-ironic | 13:59 | |
| *** gkadam has quit IRC | 13:59 | |
| *** gkadam has joined #openstack-ironic | 13:59 | |
| *** gabys has quit IRC | 14:04 | |
| bdodd | Good morning ironic | 14:10 |
| *** Chaserjim has quit IRC | 14:11 | |
| openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Begin change over to use python3 https://review.openstack.org/588325 | 14:11 |
| *** rloo has joined #openstack-ironic | 14:12 | |
| *** hamzy has quit IRC | 14:15 | |
| TheJulia | good morning bdodd | 14:20 |
| *** gabys has joined #openstack-ironic | 14:20 | |
| bdodd | TheJulia o/ | 14:21 |
| *** mjturek has joined #openstack-ironic | 14:21 | |
| *** gabys has quit IRC | 14:25 | |
| *** mjturek has quit IRC | 14:31 | |
| *** sambetts|afk is now known as sambetts | 14:31 | |
| *** gkadam_ has joined #openstack-ironic | 14:33 | |
| *** gkadam has quit IRC | 14:35 | |
| *** Chaserjim has joined #openstack-ironic | 14:36 | |
| *** mjturek_ has joined #openstack-ironic | 14:38 | |
| bdodd | TheJulia I tried out the approach we discussed yesterday. After setting 'skip_current_clean_step' to False in driver_internal_info at the end of apply_configuration(), the apply_configuration() is not getting called a second time. | 14:40 |
| *** Chaserjim has quit IRC | 14:41 | |
| bdodd | But it looks like cache_bios_settings() does get called on the next heartbeat after apply_configuration(), so I'm thinking that might be a good option (do the validation from cache_bios_settings()). | 14:42 |
| *** hamzy has joined #openstack-ironic | 14:42 | |
| *** moshele has quit IRC | 14:45 | |
| TheJulia | bdodd: odd, I would think it should be :\ | 14:47 |
| bdodd | Hmm. For the original approach, I wonder if I need to add a call to manager_utils.notify_conductor_resume_clean(task) in order to trigger the logic to get it to call apply_configuration() again (with 'skip_current_clean_step' set to False). | 14:47 |
| *** gabys has joined #openstack-ironic | 14:47 | |
| *** dnuka has quit IRC | 14:47 | |
| NobodyCam | Good Morning Ironic'ers | 14:49 |
| dtantsur | morning NobodyCam | 14:51 |
| *** Chaserjim has joined #openstack-ironic | 14:51 | |
| NobodyCam | Hey hey dtantsur Good Morning :) | 14:51 |
| *** gabys has quit IRC | 14:51 | |
| *** moshele has joined #openstack-ironic | 14:54 | |
| rpioso | Good morning, ironicers | 15:00 |
| NobodyCam | Good Morning rpioso | 15:01 |
| rpioso | TheJulia: If a developer discovers an issue/bug and proposes a change to fix it, is a StoryBoard story/bug required? | 15:01 |
| *** gabys has joined #openstack-ironic | 15:01 | |
| rpioso | NobodyCam: Hey :) | 15:01 |
| dtantsur | rpioso: ideally so | 15:02 |
| rpioso | dtantsur: Thank you | 15:02 |
| openstackgerrit | Moshe Levi proposed openstack/ironic-specs master: Add Support for Smart NIC https://review.openstack.org/582767 | 15:04 |
| *** sthussey has joined #openstack-ironic | 15:07 | |
| *** e0ne has quit IRC | 15:12 | |
| *** betherly has quit IRC | 15:13 | |
| jroll | morning everyone | 15:13 |
| TheJulia | bdodd: hmmm ?maybe? rloo knows all of that code far better than I | 15:16 |
| TheJulia | rpioso: if it needs to be backported, absolutely, if it is just a really minor thing, then no | 15:17 |
| *** e0ne has joined #openstack-ironic | 15:18 | |
| rloo | bdodd: sorry, i haven't been paying attention. i have to take off now, going to be w/o computer for rest of my day i think. umm. if the info is above/in irc wrt what you're trying to do, i'll try to take a look tonight/tomorrow to see what the issue is. | 15:19 |
| *** jesusaur has joined #openstack-ironic | 15:20 | |
| bdodd | rloo - no problem | 15:20 |
| NobodyCam | Morning jroll | 15:22 |
| jroll | hey hey NobodyCam :) | 15:22 |
| NobodyCam | :) | 15:22 |
| *** Chaserjim has quit IRC | 15:24 | |
| *** skazi has joined #openstack-ironic | 15:27 | |
| *** devananda has joined #openstack-ironic | 15:30 | |
| bdodd | TheJulia rloo - attempt to add manager_utils.notify_conductor_resume_clean(task) didn't work. Can only do that from CLEANWAIT state and the task is in CLEANING state at that point. | 15:30 |
| *** gkadam_ has quit IRC | 15:38 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Refactor API code for checking microversions https://review.openstack.org/611656 | 15:40 |
| *** moshele has quit IRC | 15:40 | |
| *** hamzy has quit IRC | 15:42 | |
| *** hamzy has joined #openstack-ironic | 15:43 | |
| *** gyee has joined #openstack-ironic | 15:43 | |
| *** tssurya has quit IRC | 15:44 | |
| dtantsur | morning jroll, rloo, bdodd | 15:47 |
| bdodd | Morning dtantsur | 15:48 |
| jroll | \o dtantsur | 15:48 |
| mbeierl | morning all o/ | 15:48 |
| *** mjturek_ has quit IRC | 15:49 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Protected nodes https://review.openstack.org/611662 | 15:52 |
| openstackgerrit | Manuel Buil proposed openstack/bifrost master: Fix bug in dnsmasq config https://review.openstack.org/611663 | 15:54 |
| *** rloo has quit IRC | 15:58 | |
| *** dtantsur is now known as dtantsur|afk | 16:00 | |
| dtantsur|afk | see you | 16:00 |
| *** e0ne has quit IRC | 16:00 | |
| TheJulia | o/ | 16:06 |
| *** olivierb has quit IRC | 16:08 | |
| rpioso | TheJulia: Thank you for the clarification. It's a minor thing, but it'll probs be backported. | 16:22 |
| *** Chaserjim has joined #openstack-ironic | 16:26 | |
| *** Chaserjim has quit IRC | 16:31 | |
| *** moshele has joined #openstack-ironic | 16:37 | |
| *** derekh has quit IRC | 16:54 | |
| *** dougsz has quit IRC | 16:59 | |
| *** Chaserjim has joined #openstack-ironic | 17:04 | |
| *** S4ren has quit IRC | 17:07 | |
| *** sambetts is now known as sambetts|afk | 17:07 | |
| *** munimeha1 has quit IRC | 17:10 | |
| *** baha has joined #openstack-ironic | 17:13 | |
| *** Chaserjim has quit IRC | 17:14 | |
| *** mjturek has joined #openstack-ironic | 17:16 | |
| *** Chaserjim has joined #openstack-ironic | 17:16 | |
| *** gabys has quit IRC | 17:24 | |
| TheJulia | rpioso: just to clarify, the story is more for tracking in that case than anything else | 17:24 |
| *** gabys has joined #openstack-ironic | 17:25 | |
| *** dsneddon has quit IRC | 17:29 | |
| *** dsneddon has joined #openstack-ironic | 17:30 | |
| *** moshele has quit IRC | 17:30 | |
| *** bfournie has quit IRC | 17:41 | |
| *** hamzy has quit IRC | 17:44 | |
| *** betherly has joined #openstack-ironic | 17:45 | |
| *** hamzy has joined #openstack-ironic | 17:45 | |
| *** betherly has quit IRC | 17:49 | |
| *** priteau has quit IRC | 17:52 | |
| *** homegrown_ has joined #openstack-ironic | 17:58 | |
| TheJulia | jroll: hypothetical question, if you were statically getting a url from an ipxe server to be... say... configuration, what default path would you have in mind. | 18:01 |
| *** Chaserjim has quit IRC | 18:01 | |
| jroll | oh my | 18:01 |
| jroll | TheJulia: generally I'd say /config, but if this is talking to ironic for config... /<node-uuid>/config? | 18:01 |
| *** moshele has joined #openstack-ironic | 18:02 | |
| jroll | what non-hypothetical thing do you have in mind? :) | 18:02 |
| TheJulia | jroll: writing an http boot interface for http specific clients | 18:03 |
| jroll | mhm | 18:04 |
| jroll | so this is ipxe config, or? | 18:04 |
| *** betherly has joined #openstack-ironic | 18:05 | |
| TheJulia | well, that is one of several conundrums | 18:05 |
| TheJulia | in theory, I could do an ipxe specific http and a non ipxe specific for grub users | 18:05 |
| TheJulia | I kind of want to lean towards ipxe, but... yeah | 18:06 |
| *** betherly has quit IRC | 18:09 | |
| *** adrianc has quit IRC | 18:21 | |
| *** betherly has joined #openstack-ironic | 18:24 | |
| *** gabys has quit IRC | 18:25 | |
| *** gabys has joined #openstack-ironic | 18:26 | |
| jroll | yeah, hrm | 18:28 |
| *** scas has quit IRC | 18:28 | |
| *** betherly has quit IRC | 18:29 | |
| *** gabys has quit IRC | 18:30 | |
| *** Chaserjim has joined #openstack-ironic | 18:32 | |
| *** baha has quit IRC | 18:35 | |
| *** mjturek has quit IRC | 18:35 | |
| *** betherly has joined #openstack-ironic | 18:44 | |
| *** betherly has quit IRC | 18:49 | |
| *** mjturek has joined #openstack-ironic | 18:53 | |
| *** baha has joined #openstack-ironic | 19:00 | |
| *** bfournie has joined #openstack-ironic | 19:04 | |
| *** hamzy has quit IRC | 19:07 | |
| *** hamzy has joined #openstack-ironic | 19:08 | |
| *** Chaserjim has quit IRC | 19:12 | |
| *** baha has quit IRC | 19:15 | |
| *** gabys has joined #openstack-ironic | 19:16 | |
| *** Chaserjim has joined #openstack-ironic | 19:20 | |
| *** dsneddon has quit IRC | 19:25 | |
| *** dsneddon has joined #openstack-ironic | 19:26 | |
| *** Chaserjim has quit IRC | 19:26 | |
| TheJulia | moshele: Question for you, do infiniband hba's support ipv6 boot from url | 19:28 |
| *** Chaserjim has joined #openstack-ironic | 19:40 | |
| *** hamzy has quit IRC | 19:41 | |
| *** S4ren has joined #openstack-ironic | 19:44 | |
| *** betherly has joined #openstack-ironic | 19:44 | |
| moshele | TheJulia: I haven't test it, but according to our user manual we support ipv6 http://www.mellanox.com/related-docs/prod_software/Mellanox_PreBoot_Drivers_User_Manual_v2.8.pdf | 19:44 |
| *** Chaserjim has quit IRC | 19:45 | |
| *** devananda has quit IRC | 19:47 | |
| *** S4ren has quit IRC | 19:48 | |
| *** betherly has quit IRC | 19:48 | |
| *** moshele has quit IRC | 19:51 | |
| *** e0ne has joined #openstack-ironic | 19:52 | |
| *** gabys has quit IRC | 19:54 | |
| *** gabys has joined #openstack-ironic | 19:54 | |
| *** gabys has quit IRC | 19:59 | |
| *** Chaserjim has joined #openstack-ironic | 20:00 | |
| *** e0ne has quit IRC | 20:05 | |
| *** gabys has joined #openstack-ironic | 20:05 | |
| *** gabys has quit IRC | 20:05 | |
| *** gabys has joined #openstack-ironic | 20:06 | |
| *** hamzy has joined #openstack-ironic | 20:10 | |
| *** gabys has quit IRC | 20:10 | |
| *** openstackgerrit has quit IRC | 20:36 | |
| *** mjturek has quit IRC | 20:38 | |
| *** pcaruana has quit IRC | 20:44 | |
| *** betherly has joined #openstack-ironic | 20:49 | |
| *** betherly has quit IRC | 20:54 | |
| *** Chaserjim has quit IRC | 20:56 | |
| *** trown is now known as trown|outtypewww | 21:13 | |
| *** bnemec is now known as bnemec-bbl | 21:20 | |
| *** gabys has joined #openstack-ironic | 21:23 | |
| *** gabys has quit IRC | 21:24 | |
| *** gabys has joined #openstack-ironic | 21:24 | |
| *** gabys has quit IRC | 21:40 | |
| *** bfournie has quit IRC | 21:41 | |
| *** gabys has joined #openstack-ironic | 21:41 | |
| *** gabys has quit IRC | 21:45 | |
| *** gabys has joined #openstack-ironic | 21:53 | |
| *** rloo has joined #openstack-ironic | 21:57 | |
| rloo | bdodd: hi, i took a quick look but i'm missing some context. I don't know what problem you're trying to solve. (and I don't know what clean steps you're using). | 22:28 |
| *** bfournie has joined #openstack-ironic | 22:28 | |
| bdodd | rloo This is for the Redfish BIOS driver and executing the apply_configuration() clean step. | 22:29 |
| bdodd | We were trying to use the internal_driver_info 'skip_current_clean_step' set to False so that the apply_configuration step would run twice | 22:30 |
| rloo | bdodd: apply_configuration() is an async step? | 22:31 |
| bdodd | And I could do the BIOS settings and reboot in the first call and then validate that the settings had been made in the. second call | 22:31 |
| bdodd | yes | 22:31 |
| bdodd | It wasn't causing the apply_configuration to be called twice | 22:32 |
| bdodd | But, I think I just figured out why | 22:32 |
| rloo | bdodd: why don't you just add a second clean step after apply_configuration(), to e.g. validate_configuration()? | 22:32 |
| bdodd | That's not part of the BIOS interface | 22:32 |
| *** rcernin has joined #openstack-ironic | 22:33 | |
| rloo | bdodd: oh, well, if you figured it out then good :D | 22:33 |
| rpioso | bdodd, rloo: Should that validate thingy be a periodic? | 22:33 |
| rloo | bdodd: well, you're allowed to add cleaning steps that pertain to particular drivers. i think you are anyway. :) | 22:34 |
| rloo | rpioso: i don't know the usecase here. but if it is sequential, it doesn't make sense to be periodic. | 22:34 |
| bdodd | The problem was that the return value from apply_configuration was getting lost due to a bug in ironic/drivers/base.py. That bug is fixed in a newer rev of the code that what I am s=testing with. | 22:35 |
| rpioso | The idrac's RAID interface has one of those to poll the result of the RAID configuration. | 22:35 |
| bdodd | periodic is going to be racy | 22:35 |
| rloo | bdodd: ok | 22:35 |
| bdodd | With the newer, fixed base.py it looks like the approach is going to work. I'm going to keep working on that. Fingers crossed. | 22:37 |
| bdodd | rloo and rpioso - thanks for looking and chiming in | 22:37 |
| rloo | bdodd: yw | 22:38 |
| rpioso | The idrac's RAID clean step returns states.CLEANWAIT. | 22:38 |
| rpioso | The periodic is always running. If it has nothing to check, it returns. | 22:38 |
| bdodd | But if the periodic doesn't happen to check in the right window, the step is no longer in cleaning state and you can't mark it as clean failed | 22:41 |
| rpioso | Otherwise, it checks. If the config successfully completed, it calls manager_utils.notify_conductor_resume_clean(). If it failed, it calls task.process_event('fail'). | 22:42 |
| rpioso | I don't understand how the step could no longer be in the cleaning state. It returns states.CLEANWAIT. | 22:42 |
| *** gabys has quit IRC | 22:46 | |
| bdodd | Well, for the BIOS interface the return value was lost due to the bug I just mentioned | 22:46 |
| *** gabys has joined #openstack-ironic | 22:46 | |
| *** Chaserjim has joined #openstack-ironic | 22:48 | |
| *** Chaserjim has quit IRC | 22:49 | |
| rpioso | Oh! I see. | 22:49 |
| rpioso | bdodd: All the best with your testing. | 22:50 |
| *** rpioso is now known as rpioso|afk | 22:50 | |
| rpioso|afk | o/ | 22:50 |
| bdodd | rpioso - thanks! | 22:50 |
| rpioso|afk | bdodd: yw | 22:51 |
| *** gabys has quit IRC | 22:51 | |
| *** betherly has joined #openstack-ironic | 22:51 | |
| *** betherly has quit IRC | 22:56 | |
| *** rloo has quit IRC | 23:09 | |
| *** betherly has joined #openstack-ironic | 23:12 | |
| *** betherly has quit IRC | 23:16 | |
| *** mjturek has joined #openstack-ironic | 23:17 | |
| *** betherly has joined #openstack-ironic | 23:32 | |
| *** betherly has quit IRC | 23:37 | |
| *** mjturek has quit IRC | 23:42 | |
| *** bnemec has joined #openstack-ironic | 23:50 | |
| *** bnemec-bbl has quit IRC | 23:52 | |
| *** gyee has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!