Wednesday, 2021-02-10

*** MentalSiege has quit IRC00:06
*** pmannidi has quit IRC00:07
*** pmannidi has joined #openstack-ironic00:13
*** gmann_afk is now known as gmann00:19
*** pmannidi_ has joined #openstack-ironic00:44
*** pmannidi has quit IRC00:45
*** pmannidi_ has quit IRC00:48
*** pmannidi has joined #openstack-ironic01:33
*** rloo has quit IRC01:46
*** rcernin has quit IRC02:31
openstackgerritBob Fournier proposed openstack/sushy master: Don't log ERROR if GET of /redfish/v1/SessionService fails  https://review.opendev.org/c/openstack/sushy/+/77476002:33
*** rcernin has joined #openstack-ironic02:40
*** pmannidi has quit IRC02:49
*** pmannidi has joined #openstack-ironic02:52
*** zzzeek has quit IRC03:56
*** zzzeek has joined #openstack-ironic03:56
*** pmannidi has quit IRC04:07
*** pmannidi has joined #openstack-ironic04:10
*** dsneddon has quit IRC04:37
*** hoonetorg has joined #openstack-ironic04:40
*** dsneddon has joined #openstack-ironic04:42
*** mkowalski has quit IRC04:46
openstackgerritJacob Anders proposed openstack/ironic master: Use OOB inspection to fetch MACs for IB inspection  https://review.opendev.org/c/openstack/ironic/+/77439104:57
*** openstackstatus has quit IRC04:58
*** openstack has joined #openstack-ironic05:00
*** ChanServ sets mode: +o openstack05:00
*** stendulker has joined #openstack-ironic05:02
*** hoonetorg has quit IRC05:05
*** pmannidi has quit IRC05:13
*** pmannidi has joined #openstack-ironic05:16
*** mkowalski has joined #openstack-ironic05:18
*** hoonetorg has joined #openstack-ironic05:19
*** stendulker has quit IRC05:22
openstackgerritvinay50muddu proposed openstack/ironic master: Add support to manage certificates in iLO  https://review.opendev.org/c/openstack/ironic/+/76057305:49
*** pmannidi has quit IRC06:19
*** pmannidi has joined #openstack-ironic06:22
*** k_mouza has joined #openstack-ironic06:22
*** k_mouza has quit IRC06:26
*** gyee has quit IRC06:54
*** tzumainn has quit IRC07:09
*** uzumaki has quit IRC07:14
*** pmannidi has quit IRC07:26
*** pmannidi has joined #openstack-ironic07:29
arne_wiebalckGood morning, ironic!07:33
openstackgerritMerged openstack/sushy master: Don't log ERROR if GET of /redfish/v1/SessionService fails  https://review.opendev.org/c/openstack/sushy/+/77476007:42
*** moshiur has joined #openstack-ironic07:47
*** rpittau|afk is now known as rpittau07:51
rpittaugood morning ironic! o/07:51
openstackgerritRiccardo Pittau proposed openstack/bifrost stable/victoria: Misplaced variable preventing fast-track after inspection  https://review.opendev.org/c/openstack/bifrost/+/77467208:14
*** pmannidi has quit IRC08:41
jandersgood morning arne_wiebalck and rpittau o/08:46
rpittauhey janders :)08:46
arne_wiebalckhey janders and rpittau o/08:46
rpittauhey arne_wiebalck :)08:48
*** pmannidi has joined #openstack-ironic08:50
*** dougsz has joined #openstack-ironic08:53
*** anuradha1904 has joined #openstack-ironic08:54
*** dougsz has quit IRC08:54
*** rcernin has quit IRC08:56
jandersI'm adding unit tests to MAC-OOB patch. Making good progress except this one: https://review.opendev.org/c/openstack/ironic/+/774391/7/ironic/tests/unit/drivers/modules/redfish/test_management.py#149509:03
jandersI was trying to follow this example: https://opendev.org/openstack/ironic/src/branch/master/ironic/tests/unit/drivers/modules/redfish/test_management.py#L1374 but clearly I'm doing something wrong09:05
jandersany hints welcome! :)09:05
janders(and the test is deliberately commented out in the change - I wanted to test the other tests in CI in the meantime)09:05
jandersmy guess is I'm setting the side_effect wrong - or perhaps the assert is off (wrong scoping - or maybe even wrong method). Little confused with all the layers :)09:07
*** lucasagomes has joined #openstack-ironic09:09
*** tosky has joined #openstack-ironic09:12
*** derekh has joined #openstack-ironic09:33
*** stendulker has joined #openstack-ironic09:45
rpittaujanders: one thing I spot is that the side effect exception doesn't the ()09:51
rpittaudoesn't need*09:51
rpittaujanders: also I don't see you calling set_summary anywhere09:52
rpittaujanders: mmmm not sure that would work anyway, summary is a property of the ethernet_interfaces, so once you have the system and the ethernet_interfaces, probably don't need a try-except there09:55
*** stendulker has quit IRC10:05
*** pmannidi has quit IRC10:07
*** pmannidi has joined #openstack-ironic10:10
*** stendulker has joined #openstack-ironic10:13
rpittaudtantsur|afk, arne_wiebalck, and everyone interested :) I'm doing some (more) reshuffling between hardware and raid_utils module, just realized that we have a bunch of text in the hardware test module that can be moved out to reduce size and just separate from the code. It should be an easy and quick change, just wanted an opinion if it's worth before moving forward10:20
arne_wiebalckrpittau: text? like comments?10:26
rpittauarne_wiebalck: text like samples output10:27
arne_wiebalckrpittau: ah, yes10:27
rpittauthe first 860 lines :)10:27
arne_wiebalcklol10:27
arne_wiebalckall for the tests!10:27
rpittauyeah10:27
arne_wiebalcksure, I am all for moving it to a better place10:28
rpittausince if we keep moving the raid related functions out from hardware we'll end up sharing some of the samples, this could be a good opportunity to put them in a separate place10:28
arne_wiebalcksounds good10:28
rpittauok10:28
*** dtantsur|afk is now known as dtantsur10:38
dtantsurmorning ironic10:38
dtantsurrpittau: makes sense to me10:38
*** dsneddon has quit IRC10:50
*** dsneddon has joined #openstack-ironic10:51
*** stendulker has quit IRC10:51
*** dougsz has joined #openstack-ironic10:57
*** dsneddon has quit IRC10:57
*** dsneddon has joined #openstack-ironic10:57
jandersrpittau thank you. So - do you think this test is a bad idea in the first place?11:25
*** k_mouza has joined #openstack-ironic11:27
*** dougsz has quit IRC11:28
*** dsneddon has quit IRC11:28
iurygregorygood morning arne_wiebalck janders rpittau dtantsur and Ironic o/11:29
*** dsneddon has joined #openstack-ironic11:29
*** ianychoi__ is now known as ianychoi11:30
jandersgood morning iurygregory o/11:36
rpittaujanders: I need to give it another look, but the entire try-except may not be needed as you're just retrieving some info already assigned to the ethernet_interface object. Does it make sense?11:41
jandersyes, thank you rpittau11:43
jandersit does indeed look like I decided to make my life more difficult writing this bit :)11:46
jandersI thought the original code had these clauses and I carried them over while breaking this part out to a separate method, but looking at master I don't see that... must have been me :)11:46
openstackgerritMerged openstack/bifrost stable/victoria: Misplaced variable preventing fast-track after inspection  https://review.opendev.org/c/openstack/bifrost/+/77467211:55
*** dougsz has joined #openstack-ironic12:07
*** dougsz has quit IRC12:10
*** anuradha1904 has quit IRC12:14
*** pmannidi has quit IRC12:15
*** pmannidi has joined #openstack-ironic12:18
openstackgerritRiccardo Pittau proposed openstack/ironic-python-agent master: Move some raid specific functions to raid_utils  https://review.opendev.org/c/openstack/ironic-python-agent/+/77485412:50
*** iurygregory has quit IRC12:51
*** anuradha1904 has joined #openstack-ironic12:55
*** rcernin has joined #openstack-ironic13:13
*** rcernin has quit IRC13:18
*** pmannidi has quit IRC13:23
*** pmannidi has joined #openstack-ironic13:27
janderssee you tomorrow Ironic o/13:27
*** paras333_ has quit IRC13:30
rpittaubye janders :)13:34
*** rloo has joined #openstack-ironic14:02
TheJuliagood morning14:08
*** ianychoi has quit IRC14:09
*** iurygregory has joined #openstack-ironic14:13
* iurygregory is back14:14
dtantsurmorning TheJulia14:19
iurygregorygood morning TheJulia =)14:20
TheJuliawb iurygregory14:24
openstackgerritJulia Kreger proposed openstack/ironic-specs master: Implement System Scoped Role Based Access Control  https://review.opendev.org/c/openstack/ironic-specs/+/76407014:24
iurygregoryty =) I was having some problems with my ISP14:25
*** pmannidi has quit IRC14:34
*** pmannidi has joined #openstack-ironic14:35
*** tzumainn has joined #openstack-ironic14:43
*** lmcgann has joined #openstack-ironic14:48
*** MentalSiege has joined #openstack-ironic15:05
*** MentalSiege has quit IRC15:12
*** MentalSiege has joined #openstack-ironic15:13
*** rcernin has joined #openstack-ironic15:14
*** rcernin has quit IRC15:18
iurygregoryTheJulia, if possible can you add https://review.opendev.org/c/openstack/openstacksdk/+/768612 to your list this week? =)15:34
TheJuliaiurygregory: I'll try for tomorrow, if that is okay15:38
*** uzumaki has joined #openstack-ironic15:38
iurygregoryTheJulia, totally fine =)15:40
*** pmannidi has quit IRC15:43
*** pmannidi has joined #openstack-ironic15:46
*** moshiur has quit IRC16:06
*** paras333_ has joined #openstack-ironic16:11
*** ianw has quit IRC16:39
*** ianw has joined #openstack-ironic16:39
TheJuliaomg, one line has been driving me crazy since yesterday afternoon16:40
iurygregoryTheJulia, want to share the line? not sure if I can help, but I can try =)16:42
TheJuliaoh, I finally figured it out16:42
TheJuliaI had set a rule to member instead of reader16:43
iurygregory\o/16:43
TheJuliaalong the way I realized I needed to flip the parameter order on the authorization check method16:43
TheJuliabecause that was wrong too16:43
iurygregorynice =D16:44
*** lucasagomes has quit IRC16:56
rpittauif anyone has a minute, ironic-inspector ready to go for train and stein https://review.opendev.org/c/openstack/ironic-inspector/+/773332 https://review.opendev.org/c/openstack/ironic-inspector/+/77309117:03
rpittaurocky is failing on python3 :/17:03
TheJuliaugh17:07
TheJuliawheeeeeeee I thought I found an elegent way in python to do a thing... then see the note "Added in python 3.9"17:08
rpittaulet's backport it17:09
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent master: Fix error message with UEFI-incompatible images  https://review.opendev.org/c/openstack/ironic-python-agent/+/77257517:09
dtantsurTheJulia: if you have a minute ^^17:09
dtantsurit's small but touches the code you've recently built17:09
TheJuliaack, let me just figure out my string headache17:10
dtantsuroh17:10
dtantsurthen ignore it, we'll figure out17:10
openstackgerritMark Goddard proposed openstack/bifrost stable/train: Use tag for ipa-builder  https://review.opendev.org/c/openstack/bifrost/+/77423717:12
mgoddardiurygregory: possible fix for the failures ^17:12
iurygregorymgoddard, hey tks!17:12
iurygregorylet's see how it goes, I was still debugging centos8 job17:12
mgoddardiurygregory: I tried installing lxml and libvirt-python in a centos 8 test VM17:13
iurygregorywe probably need to drop l-c job =)17:13
mgoddardiurygregory: fails with train UC, works without17:13
mgoddardtrue17:13
mgoddardI'll add that, just in case it works17:13
iurygregoryyeah17:14
dtantsurmgoddard: will likely also need https://review.opendev.org/c/openstack/bifrost/+/76674517:14
iurygregoryand probably move opensuse job to non-voting (not sure if the centos fix will work for it)17:14
dtantsuropensuse is currently broken on all branches17:14
mgoddardoh dear, can of worms17:15
dtantsurno, fixed on master17:15
dtantsurbut does not work on older branches17:15
dtantsuryeah17:15
iurygregoryyeah...17:15
rpittaudon't forget the pip upgrade17:15
dtantsurwhich reminds me, I wanted to formally propose to stop doing EM for Bifrost17:15
dtantsurlet me send an email17:15
TheJuliadtantsur: looking17:15
iurygregoryoh god the pip issue also D:17:16
rpittauif you want to have a look at centos8 almost passing in ussuri https://review.opendev.org/c/openstack/bifrost/+/76674217:16
rpittaustill haven't figured out the issue with pxeboot17:16
rpittaulocally, first time it doesn't work, second time it works :D17:17
iurygregory*magic*17:18
TheJuliaso thinking through this, we may not have a known efi partition id if it was a whole disk image that we deployed17:21
dtantsurs/may not/never/17:21
dtantsurIt's usually None, I think. It *definitely* is None for incompatible whole disk images.17:21
TheJuliayeah17:21
TheJuliaI think the change is good17:21
TheJuliabecause your restricting the lookup if we have the value which we may not have17:22
*** dougsz has joined #openstack-ironic17:23
TheJuliaAnd ++ on the message17:24
TheJuliait shouldn't break the re-call of the method because by that point we should have all the details and would have otherwise blown up earlier17:27
*** dougsz has quit IRC17:28
*** pmannidi has quit IRC17:30
*** pmannidi has joined #openstack-ironic17:32
openstackgerritDmitry Tantsur proposed openstack/ironic-lib master: utils.mounted: retry umount and allow retrying mount  https://review.opendev.org/c/openstack/ironic-lib/+/77490817:33
dtantsurif you're wondering about ^^ and others, I'm trying to build a reasonably stable API for deploy steps to use17:33
dtantsur* out-of-tree deploy steps first and foremost17:34
TheJuliaack17:36
openstackgerritMark Goddard proposed openstack/bifrost stable/train: Fix several CI issues (Train)  https://review.opendev.org/c/openstack/bifrost/+/77423717:37
openstackgerritMark Goddard proposed openstack/bifrost stable/train: Fix several CI issues (Train)  https://review.opendev.org/c/openstack/bifrost/+/77423717:38
* TheJulia crosses her fingers that she hasn't broken hundreds of api tests17:39
openstackgerritAija Jauntēva proposed openstack/sushy master: [WIP] Refactor TaskMonitors  https://review.opendev.org/c/openstack/sushy/+/77453217:51
openstackgerritGhanshyam proposed openstack/networking-generic-switch stable/train: Remove grenade jobs from old stable branches  https://review.opendev.org/c/openstack/networking-generic-switch/+/77333517:54
openstackgerritDmitry Tantsur proposed openstack/ironic-lib master: Add find_efi_partition, deprecate get_uefi_disk_identifier  https://review.opendev.org/c/openstack/ironic-lib/+/77491417:54
TheJuliaThat moment when your changes work too well... and you realize that you need to add a deprecated rule to fallback upon17:59
TheJulia(or at least reference one...)18:00
*** derekh has quit IRC18:00
openstackgerritAija Jauntēva proposed openstack/sushy master: [WIP] Refactor TaskMonitors  https://review.opendev.org/c/openstack/sushy/+/77453218:05
openstackgerritVerification of a change to openstack/ironic-inspector failed: Remove grenade jobs from old stable branches  https://review.opendev.org/c/openstack/ironic-inspector/+/77309118:12
rpittaugood night o/18:23
*** rpittau is now known as rpittau|afk18:23
*** k_mouza has quit IRC18:33
openstackgerritDmitry Tantsur proposed openstack/ironic-lib master: [WIP] Clean up partition functions in disk_utils  https://review.opendev.org/c/openstack/ironic-lib/+/77491418:38
*** pmannidi has quit IRC18:38
openstackgerritVerification of a change to openstack/ironic-inspector failed: Remove grenade jobs from old stable branches  https://review.opendev.org/c/openstack/ironic-inspector/+/77333218:39
*** pmannidi has joined #openstack-ironic18:43
*** dtantsur is now known as dtantsur|afk18:45
dtantsur|afko/18:45
openstackgerritDmitry Tantsur proposed openstack/ironic-lib master: [WIP] Split out a common helper for blkid  https://review.opendev.org/c/openstack/ironic-lib/+/77493118:49
openstackgerritDmitry Tantsur proposed openstack/ironic-lib master: [WIP] Split out a common helper for blkid  https://review.opendev.org/c/openstack/ironic-lib/+/77493118:53
openstackgerritDmitry Tantsur proposed openstack/ironic-lib master: Add find_efi_partition, deprecate get_uefi_disk_identifier  https://review.opendev.org/c/openstack/ironic-lib/+/77491418:55
*** rloo has quit IRC19:25
*** rloo has joined #openstack-ironic19:25
*** zzzeek has quit IRC19:26
*** zzzeek has joined #openstack-ironic19:27
*** pmannidi has quit IRC19:48
*** pmannidi has joined #openstack-ironic19:49
*** rloo has quit IRC19:51
*** rloo has joined #openstack-ironic19:51
*** zzzeek has quit IRC19:53
*** zzzeek has joined #openstack-ironic19:57
openstackgerritMerged openstack/ironic-inspector stable/stein: Remove grenade jobs from old stable branches  https://review.opendev.org/c/openstack/ironic-inspector/+/77309120:21
*** zzzeek has quit IRC20:21
*** gyee has joined #openstack-ironic20:21
*** zzzeek has joined #openstack-ironic20:22
TheJuliastevebaker: you around for call?20:32
stevebakercoming20:40
arne_wiebalckbye everyone o/20:49
*** pmannidi has quit IRC20:53
*** pmannidi has joined #openstack-ironic20:56
*** uzumaki has quit IRC21:05
*** lmcgann has quit IRC21:59
jandersgood morning Ironic o/22:02
*** pmannidi has quit IRC22:03
jandersTheJulia would you have some time to chat about https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 ?22:04
*** pmannidi has joined #openstack-ironic22:06
*** anuradha1904 has quit IRC22:35
TheJuliajanders: let me make a cup of coffee first22:35
*** zzzeek has quit IRC22:37
*** zzzeek has joined #openstack-ironic22:37
jandersTheJulia no worries, ready when you are (reading your UEFI comments in the Google Doc in the meantime)22:40
TheJuliajanders: coffee will be ready in a couple minutes, /msg me with a url22:44
TheJuliayeah, that whole thing has be very worried22:46
jandershttps://review.opendev.org/c/openstack/ironic-python-agent/+/771904/24/ironic_python_agent/hardware.py#169022:46
jandersthis is the comment I wanted to chat about to make sure I understand things correctly22:46
jandersand - firstly - thank you for your feedback regarding the change, it's been very helpful :)22:47
TheJuliaso I think we're basically on the same page22:48
TheJuliabut the back of my brain is saying the secure erase code doesn't raise exceptions if there is an incompatability, that it just returns false22:48
TheJuliabut maybe I'm out of date22:48
jandersI will check in a sec - but there is one more thing that's related that I wanted to ask you about22:49
TheJuliahttps://meet.google.com/bgg-yabg-wvi22:49
jandersok!22:49
*** zzzeek has quit IRC22:50
*** zzzeek has joined #openstack-ironic22:52
stevebakerlbragstad: hey, do you have opinions on packaging default policy files in /etc/<project>? Right now ironic packages /etc/ironic/policy.json containing yaml, which is broken. But the fix could be deleting it entirely or generating /etc/ironic/policy.yaml22:58
lbragstad^ that's what i would recommend22:59
lbragstadgenerate the defaults based on the code22:59
lbragstader - generate the template/sample based on the defaults in code22:59
stevebakerlbragstad: so a generated /etc/ironic/policy.yaml? Cool that was my first thought23:00
lbragstadyeah - exactly23:00
stevebakerbut many projects don't package any policy file so I wondered23:00
lbragstadif you need it23:00
lbragstadif you don't need to package it, because ironic runs with the defaults registered in code, by default23:01
lbragstadthen you might not need to provide one?23:01
openstackgerritSteve Baker proposed openstack/ironic master: Generate policy.yaml.sample  https://review.opendev.org/c/openstack/ironic/+/77503923:01
lbragstadif that's the case, then the operator can generate one if they want to supply their own overrides23:01
lbragstadin keystone - we don't package or release one23:02
*** zzzeek has quit IRC23:02
lbragstadwe just generate sample on-the-fly for documentation23:02
lbragstadsamples*23:02
*** zzzeek has joined #openstack-ironic23:04
stevebakerlbragstad: on the other hand, we have a legacy problem for upgrades if we stop packaging /etc/ironic/policy.* the old one will eventually become stale, we can't delete it because it *might* be customized. So if we're being friendly for package upgrades we have to package policy.yaml forever because we packaged policy.json in the past.23:12
*** pmannidi has quit IRC23:14
*** pmannidi has joined #openstack-ironic23:15
TheJuliaI *think* the pain on upgrade is going to have to be manually updating that policy as part of the upgrade process. At least that is hoped what will occur with secure rbac movement23:24
*** zzzeek has quit IRC23:27
*** zzzeek has joined #openstack-ironic23:29
*** zzzeek has quit IRC23:34
TheJulia7994 tests...23:35
*** zzzeek has joined #openstack-ironic23:36
*** tzumainn has quit IRC23:38

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!