*** zzzeek has quit IRC | 00:01 | |
*** zzzeek has joined #openstack-ironic | 00:02 | |
stevebaker | TheJulia: so you think we should stop packaging /etc/ironic/policy.{json,yaml}? We could package policy.json.sample in /usr/share/docs | 00:04 |
---|---|---|
TheJulia | I think we should stop. | 00:05 |
stevebaker | cool, I'm fine with that | 00:05 |
TheJulia | Policy in code really serves the purpose of supporting users | 00:05 |
TheJulia | and it has been in place for a long time | 00:05 |
*** paras333_ has quit IRC | 00:08 | |
*** MentalSiege has quit IRC | 00:08 | |
JayF | stevebaker: ++ to putting .sample in /usr/share/docs though, to be explicit | 00:17 |
JayF | I wish more packages did that :D | 00:17 |
*** tosky has quit IRC | 00:17 | |
JayF | although I run gentoo at home so I'm not sure you'd agree with most of what I like about package managers :P | 00:17 |
stevebaker | lbragstad, TheJulia, JayF: OK I've attempted to explain the situation in this packaging commit message https://review.rdoproject.org/r/#/c/31941/ | 00:19 |
*** pmannidi has quit IRC | 00:28 | |
*** pmannidi has joined #openstack-ironic | 00:30 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Project Scoping Node endpoint https://review.opendev.org/c/openstack/ironic/+/773924 | 00:53 |
TheJulia | stevebaker: ^^ *falls over dead* | 00:54 |
stevebaker | TheJulia: horay! | 00:56 |
openstackgerrit | Jacob Anders proposed openstack/ironic master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic/+/771905 | 01:06 |
janders | TheJulia IRT to our conversation about N+1/N-1 compatibility of the NVMe cleaning change ^ should handle new-API + old-agent scenario. I'm thinking how to handle old-API + new-agent scenario | 01:10 |
janders | TheJulia would it be right to have NVMe cleaning fall back to shred based on info.get('agent_continue_if_ata_erase_failed')? | 01:11 |
janders | (the field name might be misleading, which is not great) | 01:12 |
janders | I might have missed the bigger picture while looking at this detail - old API won't have NVMe cleaning config, so NVMe cleaning shouldn't be attempted at all, this may only matter for ATA Secure Erase fallback for version N of agent and version N-1 of the API | 01:14 |
janders | actually... given we changed the code to enable NVMe cleaning by default ( https://review.opendev.org/c/openstack/ironic-python-agent/+/771904/25/ironic_python_agent/hardware.py#1289 ) NVMe cleaning may still run with version N agent and version N-1 API | 01:18 |
janders | I feel like it may be worthwhile re-thinking the combinaton of https://review.opendev.org/c/openstack/ironic-python-agent/+/771904/25/ironic_python_agent/hardware.py#1291 and https://review.opendev.org/c/openstack/ironic/+/771905/5/ironic/conf/deploy.py#35. TheJulia do you think it would be better to 1) have NVMe cleaning 'enable itself' on IPA | 01:23 |
janders | upgrade (even if API config file is unchanged) or would we want 2) the new version of API come with NVMe cleaning enabled by default in the config, but not have IPA start NVMe-cleaning before that is in place? | 01:23 |
janders | I haven't given much thought to inter-op between N and N-1 IRT to this feature prior to our chat earlier today, so trying to retro-fit a bit of that now :) | 01:26 |
*** MentalSiege has joined #openstack-ironic | 01:54 | |
openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 01:56 |
janders | TheJulia ^ is my take on version N IPA + version N-1 API. As long as info.get('agent_continue_if_secure_erase_failed') returns None if the key doesn't exist I think this should work | 01:58 |
*** MentalSiege has quit IRC | 01:58 | |
openstackgerrit | Jacob Anders proposed openstack/ironic master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic/+/771905 | 02:06 |
*** ianychoi has joined #openstack-ironic | 02:09 | |
*** nam-est has quit IRC | 02:14 | |
*** zzzeek has quit IRC | 02:20 | |
*** zzzeek has joined #openstack-ironic | 02:21 | |
pmannidi | janders: ping | 02:35 |
pmannidi | janders: ignore here | 02:36 |
*** rloo has quit IRC | 03:01 | |
*** zzzeek has quit IRC | 03:02 | |
*** zzzeek has joined #openstack-ironic | 03:06 | |
*** MentalSiege has joined #openstack-ironic | 03:14 | |
*** gyee has quit IRC | 03:33 | |
openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 04:28 |
openstackgerrit | Jacob Anders proposed openstack/ironic master: Use OOB inspection to fetch MACs for IB inspection https://review.opendev.org/c/openstack/ironic/+/774391 | 04:42 |
openstackgerrit | Jacob Anders proposed openstack/ironic master: Use OOB inspection to fetch MACs for IB inspection https://review.opendev.org/c/openstack/ironic/+/774391 | 05:07 |
*** zzzeek has quit IRC | 05:08 | |
*** zzzeek has joined #openstack-ironic | 05:09 | |
*** MentalSiege has quit IRC | 05:56 | |
openstackgerrit | Jacob Anders proposed openstack/ironic master: Use OOB inspection to fetch MACs for IB inspection https://review.opendev.org/c/openstack/ironic/+/774391 | 07:03 |
*** moshiur has joined #openstack-ironic | 07:15 | |
arne_wiebalck | Good morning, ironic! | 07:41 |
*** rpittau|afk is now known as rpittau | 07:53 | |
rpittau | good morning ironic! o/ | 07:53 |
*** ayoung has quit IRC | 08:32 | |
*** ianychoi has quit IRC | 08:33 | |
openstackgerrit | ankit proposed openstack/ironic master: Adds config parameter kernel_append_param for iLO https://review.opendev.org/c/openstack/ironic/+/755189 | 08:35 |
*** tosky has joined #openstack-ironic | 08:36 | |
openstackgerrit | vinay50muddu proposed openstack/ironic master: [WIP] Add clean/deploy steps to manage certificates https://review.opendev.org/c/openstack/ironic/+/763791 | 08:42 |
*** ayoung has joined #openstack-ironic | 08:44 | |
*** ianychoi has joined #openstack-ironic | 08:48 | |
janders | good morning arne_wiebalck and rpittau o/ | 08:52 |
*** monica_pardhi has joined #openstack-ironic | 08:53 | |
*** moshiur has quit IRC | 08:54 | |
rpittau | hey janders :) | 08:55 |
*** lucasagomes has joined #openstack-ironic | 09:10 | |
arne_wiebalck | hey janders and rpittau o/ | 09:14 |
*** rnoriega has quit IRC | 09:32 | |
*** rnoriega has joined #openstack-ironic | 09:33 | |
*** pmannidi_ has joined #openstack-ironic | 09:37 | |
*** pmannidi has quit IRC | 09:39 | |
*** derekh has joined #openstack-ironic | 09:45 | |
openstackgerrit | Pierre Riteau proposed openstack/ironic-python-agent-builder master: Fix list formatting https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775087 | 09:47 |
*** monica_pardhi has quit IRC | 09:49 | |
*** dtantsur|afk is now known as dtantsur | 10:00 | |
dtantsur | good morning | 10:00 |
rpittau | good morning dtantsur :) | 10:01 |
janders | good morning dtantsur o/ | 10:01 |
*** monica_pardhi has joined #openstack-ironic | 10:05 | |
openstackgerrit | Mark Goddard proposed openstack/bifrost stable/train: Fix several CI issues (Train) https://review.opendev.org/c/openstack/bifrost/+/774237 | 10:09 |
openstackgerrit | Riccardo Pittau proposed openstack/bifrost stable/ussuri: Fix CI issues https://review.opendev.org/c/openstack/bifrost/+/766742 | 10:31 |
*** dougsz has joined #openstack-ironic | 10:32 | |
*** dougsz has quit IRC | 10:46 | |
*** k_mouza has joined #openstack-ironic | 10:53 | |
openstackgerrit | Pierre Riteau proposed openstack/ironic-python-agent-builder master: Fix list formatting https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775087 | 11:15 |
openstackgerrit | Merged openstack/ironic master: Generate policy.yaml.sample https://review.opendev.org/c/openstack/ironic/+/775039 | 11:26 |
*** zzzeek has quit IRC | 11:28 | |
dtantsur | I've just remembered we're supposed to do releases this week #facepalm | 11:30 |
dtantsur | where do we stand with various projects? | 11:30 |
*** zzzeek has joined #openstack-ironic | 11:30 | |
dtantsur | could I get a 2nd +2 on https://review.opendev.org/c/openstack/bifrost/+/767929 and https://review.opendev.org/c/openstack/ironic/+/773636 please? | 11:31 |
*** moshiur has joined #openstack-ironic | 11:37 | |
iurygregory | good morning Ironic! | 11:40 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Report the slowest tests after a test run https://review.opendev.org/c/openstack/ironic/+/775123 | 11:44 |
*** ociuhandu has joined #openstack-ironic | 11:46 | |
*** k_mouza has quit IRC | 11:49 | |
*** k_mouza_ has joined #openstack-ironic | 11:49 | |
dtantsur | TheJulia and others: ironic-inspector does not have any non-CI changes this sprint, any objections to skipping its intermediate release? | 11:53 |
dtantsur | Bifrost seems ready, anyone wants to request it? | 11:56 |
monica_pardhi | Zuul is failing on my below patches due to ironic-tempest job failure . | 11:57 |
monica_pardhi | https://review.opendev.org/c/openstack/ironic/+/769719 | 11:57 |
monica_pardhi | https://review.opendev.org/c/openstack/ironic/+/773874 | 11:57 |
monica_pardhi | Is anyone facing the same issue? | 11:57 |
dtantsur | POST_FAILURE is usually a transient condition | 11:58 |
dtantsur | the unit test failure is real | 11:58 |
iurygregory | dtantsur, I can do it in a few | 12:02 |
dtantsur | ++ | 12:02 |
*** k_mouza_ has quit IRC | 12:03 | |
*** k_mouza has joined #openstack-ironic | 12:03 | |
*** monica_pardhi has quit IRC | 12:08 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Prepare 16.2 and clean up release note https://review.opendev.org/c/openstack/ironic/+/775139 | 12:12 |
dtantsur | please ^^ | 12:12 |
*** tosin has joined #openstack-ironic | 12:16 | |
*** monica_pardhi has joined #openstack-ironic | 12:22 | |
*** ociuhandu has quit IRC | 12:27 | |
*** ociuhandu has joined #openstack-ironic | 12:27 | |
*** ociuhandu has quit IRC | 12:28 | |
*** ociuhandu has joined #openstack-ironic | 12:28 | |
openstackgerrit | vinay50muddu proposed openstack/ironic master: [WIP] Add clean/deploy steps to manage certificates https://review.opendev.org/c/openstack/ironic/+/763791 | 12:29 |
openstackgerrit | Merged openstack/bifrost stable/victoria: Exit on all errors in bash scripts when possible https://review.opendev.org/c/openstack/bifrost/+/774661 | 12:30 |
*** monica_pardhi has quit IRC | 12:30 | |
*** stendulker_ has joined #openstack-ironic | 12:33 | |
openstackgerrit | Yogesh proposed openstack/ironic master: Add idrac HW type IPMI interface support https://review.opendev.org/c/openstack/ironic/+/771862 | 12:33 |
*** ociuhandu has quit IRC | 12:41 | |
*** ociuhandu has joined #openstack-ironic | 12:41 | |
*** bfournie has quit IRC | 12:45 | |
*** ociuhandu has quit IRC | 12:46 | |
*** stendulker_ has quit IRC | 12:47 | |
*** ociuhandu has joined #openstack-ironic | 12:50 | |
*** mgagne has quit IRC | 12:52 | |
*** mgagne has joined #openstack-ironic | 12:53 | |
*** bfournie has joined #openstack-ironic | 12:54 | |
janders | see you tomorrow Ironic o/ | 13:00 |
iurygregory | bye janders o/ | 13:01 |
*** zzzeek has quit IRC | 13:07 | |
*** zzzeek has joined #openstack-ironic | 13:08 | |
iurygregory | dtantsur, https://review.opendev.org/c/openstack/releases/+/775150 | 13:09 |
*** zzzeek has quit IRC | 13:21 | |
dtantsur | thx | 13:23 |
iurygregory | np | 13:24 |
*** zzzeek has joined #openstack-ironic | 13:26 | |
*** ociuhandu has quit IRC | 13:40 | |
*** ociuhandu has joined #openstack-ironic | 13:41 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: Support installing ironic-lib from source https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775153 | 13:43 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: devstack: support installing ironic-lib from source in DIB IPA https://review.opendev.org/c/openstack/ironic/+/775154 | 13:45 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: devstack: support installing ironic-lib from source in DIB IPA https://review.opendev.org/c/openstack/ironic/+/775154 | 13:47 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-lib master: DNM test CI https://review.opendev.org/c/openstack/ironic-lib/+/775155 | 13:47 |
*** ociuhandu has quit IRC | 13:52 | |
*** ociuhandu has joined #openstack-ironic | 13:54 | |
*** rloo has joined #openstack-ironic | 13:57 | |
*** lmcgann has joined #openstack-ironic | 14:00 | |
*** ociuhandu has quit IRC | 14:04 | |
*** ociuhandu has joined #openstack-ironic | 14:16 | |
TheJulia | dtantsur: no objection | 14:20 |
*** ociuhandu has quit IRC | 14:20 | |
*** ociuhandu has joined #openstack-ironic | 14:22 | |
TheJulia | ajya: Will you be able to attend the one or more of the review jam's next week w/r/t https://review.opendev.org/c/openstack/ironic-specs/+/740721 | 14:23 |
ajya | TheJulia: yes, I can attend both if it does not fit into the first one | 14:23 |
openstackgerrit | Merged openstack/ironic master: Make boot_mode more consistent with other capabilities https://review.opendev.org/c/openstack/ironic/+/773636 | 14:24 |
*** ociuhandu has quit IRC | 14:37 | |
*** moshiur has quit IRC | 14:39 | |
*** ociuhandu has joined #openstack-ironic | 14:40 | |
TheJulia | ajya: typically we try to get some cross-ver between both so there is someone there who can explain context and point people in the right direction | 14:43 |
*** tzumainn has joined #openstack-ironic | 14:44 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Project Scoping Node endpoint https://review.opendev.org/c/openstack/ironic/+/773924 | 14:45 |
ajya | TheJulia: np, I'll be there | 14:46 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent master: Remove samples from the hardware test module https://review.opendev.org/c/openstack/ironic-python-agent/+/775163 | 14:46 |
*** ociuhandu has quit IRC | 14:47 | |
*** ociuhandu has joined #openstack-ironic | 14:48 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent master: [WIP] Move some raid specific functions to raid_utils https://review.opendev.org/c/openstack/ironic-python-agent/+/774854 | 14:50 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent master: [WIP] Move some raid specific functions to raid_utils https://review.opendev.org/c/openstack/ironic-python-agent/+/774854 | 14:52 |
dtantsur | morning TheJulia | 14:52 |
*** ociuhandu has quit IRC | 14:55 | |
*** ociuhandu has joined #openstack-ironic | 14:56 | |
*** zaneb has joined #openstack-ironic | 14:58 | |
* TheJulia wipes sleep from her eyes | 14:59 | |
*** MentalSiege has joined #openstack-ironic | 15:00 | |
*** MentalSiege has quit IRC | 15:00 | |
*** ociuhandu has quit IRC | 15:02 | |
*** ociuhandu has joined #openstack-ironic | 15:04 | |
*** ricolin has joined #openstack-ironic | 15:08 | |
*** MentalSiege has joined #openstack-ironic | 15:10 | |
*** MentalSiege has quit IRC | 15:15 | |
*** uzumaki has joined #openstack-ironic | 15:30 | |
*** dougsz has joined #openstack-ironic | 15:37 | |
*** ociuhandu has quit IRC | 15:39 | |
dtantsur | TheJulia: once you wipe sleep from your eyes and RBAC unit tests from your horizon, could you take a final look at https://review.opendev.org/c/openstack/ironic-python-agent/+/772575 ? | 15:43 |
*** ociuhandu has joined #openstack-ironic | 15:44 | |
TheJulia | sure | 15:45 |
-openstackstatus- NOTICE: Recent POST_FAILURE results from Zuul for builds started prior to 15:47 UTC were due to network connectivity issues reaching one of our log storage providers, and can be safely rechecked | 15:51 | |
*** ricolin has quit IRC | 15:56 | |
*** dougsz has quit IRC | 15:58 | |
*** k_mouza_ has joined #openstack-ironic | 16:03 | |
*** k_mouza has quit IRC | 16:05 | |
*** derekh has quit IRC | 16:10 | |
*** derekh has joined #openstack-ironic | 16:11 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: Support installing ironic-lib from source https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775153 | 16:20 |
*** dougsz has joined #openstack-ironic | 16:30 | |
openstackgerrit | Merged openstack/ironic-python-agent-builder master: Fix list formatting https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/775087 | 16:30 |
*** dougsz has quit IRC | 16:32 | |
*** gyee has joined #openstack-ironic | 16:37 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: Clean up a release note https://review.opendev.org/c/openstack/ironic-python-agent/+/775210 | 16:46 |
dtantsur | please check ^^ then we can release | 16:46 |
*** anuradha1904 has joined #openstack-ironic | 16:52 | |
*** ociuhandu has quit IRC | 16:54 | |
*** ociuhandu has joined #openstack-ironic | 16:55 | |
*** ricolin has joined #openstack-ironic | 16:56 | |
*** lucasagomes has quit IRC | 16:58 | |
*** ociuhandu has quit IRC | 17:01 | |
*** bdodd has quit IRC | 17:01 | |
*** ociuhandu has joined #openstack-ironic | 17:03 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-lib master: Split out a common helper for blkid https://review.opendev.org/c/openstack/ironic-lib/+/774931 | 17:05 |
*** ricolin has quit IRC | 17:06 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-lib master: Trivial: fix a type in tests https://review.opendev.org/c/openstack/ironic-lib/+/775236 | 17:07 |
*** rloo has quit IRC | 17:07 | |
*** rloo has joined #openstack-ironic | 17:08 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-lib master: Add find_efi_partition, deprecate get_uefi_disk_identifier https://review.opendev.org/c/openstack/ironic-lib/+/774914 | 17:09 |
*** ociuhandu_ has joined #openstack-ironic | 17:12 | |
*** ociuhandu has quit IRC | 17:15 | |
*** ociuhandu_ has quit IRC | 17:16 | |
*** ociuhandu has joined #openstack-ironic | 17:38 | |
*** ociuhandu has quit IRC | 17:42 | |
rpittau | good night! o/ | 17:43 |
*** rpittau is now known as rpittau|afk | 17:43 | |
*** dtantsur is now known as dtantsur|afk | 17:45 | |
dtantsur|afk | o/ | 17:45 |
tzumainn | hi! does someone here have experience with how volume target properties are set? | 17:48 |
TheJulia | tzumainn: o/ | 17:52 |
TheJulia | tzumainn: I mean... wrote the vast majority of that code, but my brain is a bit rusty | 17:53 |
tzumainn | TheJulia, hi! so we're playing with multipath with some code modifications, and we've run into a weird issue which seems to have to do with the length of the auth_username | 17:53 |
tzumainn | and I was just curious if you knew how that auth_username is set? | 17:53 |
tzumainn | TheJulia, oh, sorry, nevermind, I figured it out | 17:53 |
tzumainn | the cinder driver does it | 17:53 |
TheJulia | \o/ | 17:54 |
*** bdodd has joined #openstack-ironic | 17:54 | |
tzumainn | thanks :D | 17:54 |
*** derekh has quit IRC | 17:57 | |
*** k_mouza_ has quit IRC | 18:05 | |
openstackgerrit | Merged openstack/ironic-python-agent stable/victoria: Prevent broken partition image UEFI deploys https://review.opendev.org/c/openstack/ironic-python-agent/+/770746 | 18:21 |
openstackgerrit | Merged openstack/ironic-python-agent master: Clean up a release note https://review.opendev.org/c/openstack/ironic-python-agent/+/775210 | 18:21 |
openstackgerrit | Merged openstack/ironic-lib master: Trivial: fix a type in tests https://review.opendev.org/c/openstack/ironic-lib/+/775236 | 18:21 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Populate existing policy tests https://review.opendev.org/c/openstack/ironic/+/768136 | 18:27 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Duplicate testing for system scoped ACL testing https://review.opendev.org/c/openstack/ironic/+/770002 | 18:27 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Introduce common personas for secure RBAC https://review.opendev.org/c/openstack/ironic/+/763255 | 18:27 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP Implement "system" scoped RBAC for the node endpoint https://review.opendev.org/c/openstack/ironic/+/763257 | 18:28 |
iurygregory | ACL patch to add Backport Candidate Label to ironic projects https://review.opendev.org/c/openstack/project-config/+/775244 =) | 18:48 |
openstackgerrit | Merged openstack/ironic-lib master: Import common keystone configuration from ironic https://review.opendev.org/c/openstack/ironic-lib/+/774352 | 19:13 |
*** sshnaidm is now known as sshnaidm|afk | 19:19 | |
*** bdodd has quit IRC | 19:29 | |
arne_wiebalck | bye everyone o/ | 19:38 |
stevebaker | morning | 19:41 |
iurygregory | morning stevebaker | 19:45 |
stevebaker | iurygregory: hey | 19:45 |
iurygregory | itsn't very early for you? .-. | 19:46 |
*** tosin has quit IRC | 19:46 | |
stevebaker | not at all, 8:49am | 19:49 |
iurygregory | oh nice =) | 19:59 |
*** uzumaki has quit IRC | 20:10 | |
*** tosin has joined #openstack-ironic | 20:15 | |
*** anuradha1904 has quit IRC | 21:01 | |
openstackgerrit | Merged openstack/ironic master: Prepare 16.2 and clean up release note https://review.opendev.org/c/openstack/ironic/+/775139 | 21:04 |
openstackgerrit | Merged openstack/ironic-lib master: keystone: use os_service_type for service_type defaults https://review.opendev.org/c/openstack/ironic-lib/+/774353 | 21:09 |
*** ociuhandu has joined #openstack-ironic | 21:17 | |
*** juanoterocas has joined #openstack-ironic | 21:19 | |
*** rcernin has joined #openstack-ironic | 21:20 | |
*** uzumaki has joined #openstack-ironic | 21:23 | |
*** devtolu1__ has joined #openstack-ironic | 21:47 | |
*** juanoterocas has quit IRC | 21:50 | |
*** k_mouza has joined #openstack-ironic | 21:51 | |
*** juanoterocas has joined #openstack-ironic | 21:52 | |
*** devtolu1__ has quit IRC | 21:55 | |
*** k_mouza has quit IRC | 21:56 | |
JayF | stevebaker: TheJulia: FYI I'm fixing a minor pep issue in https://review.opendev.org/c/openstack/ironic/+/768136 hope you don't mind me hijacking a patchset to help it move alone :D | 21:59 |
JayF | **along | 21:59 |
openstackgerrit | Jay Faulkner proposed openstack/ironic master: Populate existing policy tests https://review.opendev.org/c/openstack/ironic/+/768136 | 21:59 |
stevebaker | JayF: thanks | 21:59 |
JayF | not a problem, just wanted to let you know before you were confused about someone else poking your patch lol | 22:00 |
*** lmcgann has quit IRC | 22:07 | |
*** gmann is now known as gmann_afk | 22:10 | |
*** k_mouza has joined #openstack-ironic | 22:15 | |
*** k_mouza has quit IRC | 22:22 | |
TheJulia | ugh | 22:30 |
TheJulia | I've got the entire thing re-stacked | 22:30 |
* TheJulia crosses fingers | 22:30 | |
JayF | TheJulia: does that imply I should stop my in-progress review of 768136 :P | 22:31 |
TheJulia | JayF: if should only be fairly minor | 22:31 |
TheJulia | but I'm about 60 seconds from pushing up into review | 22:31 |
JayF | I was annoyed by the prints() in the tests | 22:31 |
TheJulia | well, starting it, and hoping it completes quickly | 22:31 |
JayF | and I'm down a rabbithole | 22:31 |
TheJulia | sorry, but grep -ir the rest of the unit tests | 22:31 |
JayF | now annoyed at TestTools for not supporting test logging as a top level construct | 22:32 |
TheJulia | heh | 22:32 |
JayF | I try hard not to -1 something unless I actually know how to do it better | 22:32 |
TheJulia | wut... 3 tests fail | 22:32 |
JayF | hence the rabbitholing | 22:32 |
TheJulia | err 2 | 22:32 |
TheJulia | OH! they fail properly | 22:32 |
* TheJulia dances | 22:32 | |
TheJulia | I need to verify why but It is likely the test changes with the revised policy | 22:34 |
TheJulia | i.e. semi-expected and does what is expected now | 22:34 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Populate existing policy tests https://review.opendev.org/c/openstack/ironic/+/768136 | 22:34 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Duplicate testing for system scoped ACL testing https://review.opendev.org/c/openstack/ironic/+/770002 | 22:34 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Introduce common personas for secure RBAC https://review.opendev.org/c/openstack/ironic/+/763255 | 22:34 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement "system" scoped RBAC for the node endpoint https://review.opendev.org/c/openstack/ironic/+/763257 | 22:34 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement "system" scoped RBAC for ports https://review.opendev.org/c/openstack/ironic/+/763267 | 22:34 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for port groups https://review.opendev.org/c/openstack/ironic/+/763268 | 22:35 |
TheJulia | there it goes | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for chassis https://review.opendev.org/c/openstack/ironic/+/763269 | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for baremetal drivers https://review.opendev.org/c/openstack/ironic/+/763270 | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for node and driver passthru https://review.opendev.org/c/openstack/ironic/+/763271 | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for utility APIs https://review.opendev.org/c/openstack/ironic/+/763272 | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for volume APIs https://review.opendev.org/c/openstack/ironic/+/763273 | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for conductor APIs https://review.opendev.org/c/openstack/ironic/+/763274 | 22:35 |
JayF | TheJulia: did you have my .rst whitespace fixes locally? | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for the allocation APIs https://review.opendev.org/c/openstack/ironic/+/763275 | 22:35 |
JayF | if not you might wanna fix and repush real quick | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for the event APIs https://review.opendev.org/c/openstack/ironic/+/763276 | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Implement system scoped RBAC for the deploy templates APIs https://review.opendev.org/c/openstack/ironic/+/763277 | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: RBAC System Scope: observer -> reader https://review.opendev.org/c/openstack/ironic/+/772450 | 22:35 |
JayF | literally two lines with a trailing ' ' making pep8 angry | 22:35 |
TheJulia | JayF: no, looks like we made the exact same change | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Initial Project scoped tests https://review.opendev.org/c/openstack/ironic/+/772451 | 22:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Project Scoping Node endpoint https://review.opendev.org/c/openstack/ironic/+/773924 | 22:35 |
JayF | TheJulia: that's all I care about, is that the change is there :D | 22:35 |
TheJulia | okay, I'm going to go exercise now as much as I really wanted to go have a beer | 22:36 |
TheJulia | JayF: ++ | 22:36 |
JayF | TheJulia: I'm going to continue reviewing and put those comments on patchset 15, since I'm about 60% through | 22:36 |
JayF | but I'll look at 15->16 too, and comment if anything new is a concern | 22:36 |
TheJulia | k | 22:37 |
TheJulia | have a wonderful evening | 22:37 |
* TheJulia goes off to peddle.. and not go anywhere | 22:37 | |
*** ildikov has quit IRC | 22:40 | |
*** ildikov has joined #openstack-ironic | 22:40 | |
*** PrinzElvis has quit IRC | 22:41 | |
*** PrinzElvis has joined #openstack-ironic | 22:41 | |
*** rloo has quit IRC | 23:07 | |
*** juanoterocas has quit IRC | 23:07 | |
*** gmann_afk is now known as gmann | 23:11 | |
*** ociuhandu has quit IRC | 23:19 | |
*** tosin has quit IRC | 23:26 | |
openstackgerrit | Merged openstack/ironic-python-agent master: Fix error message with UEFI-incompatible images https://review.opendev.org/c/openstack/ironic-python-agent/+/772575 | 23:31 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!