Thursday, 2024-04-11

rpittaugood morning ironic! o/04:10
TheJuliaIt is always morning ;)04:13
TheJuliaEven when there is a game being played! https://usercontent.irccloud-cdn.com/file/dsfliZNP/1712808854.JPG04:14
JayFptg session in 15, yeah?04:46
* JayF is trying to keep awake04:46
TheJuliain 10 minutes!04:50
rpittauiurygregory: as a rule of thumb, usually anything that is voting in check is also voting in gate04:54
JayF++04:55
rpittau5 minutes to PTG session two-and-a-half! https://meetpad.opendev.org/apr2024-ptg-ironic04:56
TheJuliaGoodnight, see y'all in the morning05:44
rpittauthanks TheJulia, see you later :)05:46
rpittaubreakfast time!05:46
dtantsurJayF: could you add me to the ARM invite? I cannot promise to make 1700 UTC, but I will try.06:34
dtantsurAlso, folks, could I get some eyes on https://review.opendev.org/c/openstack/ironic/+/915415 (especially people caring about servicing)?06:43
rpittauJayF: please add me too to the ARM invite, thanks!06:48
opendevreviewDmitry Tantsur proposed openstack/ironic master: Fix get_async_step_return_state to account for servicing  https://review.opendev.org/c/openstack/ironic/+/91546908:59
dtantsuranother small but blocking issue in servicing ^^08:59
dtantsuroh lovely, our unit tests rely on the broken behaviour....11:39
iurygregorygood morning 11:41
iurygregory"expected" I would say =(11:41
iurygregoryI wasn't able to stay awake till 2am, I lost the PTG session =( 11:42
opendevreviewDmitry Tantsur proposed openstack/ironic master: Fix get_async_step_return_state to account for servicing  https://review.opendev.org/c/openstack/ironic/+/91546911:42
dtantsurokay, this does less than I'd want to, but it should fix the issue. ^^^ cc janders 11:42
iurygregoryrpittau, yeah I know, was wondering if it was wondering if it was worth having in both check and gate tbh11:43
dtantsuriurygregory, JayF, voting jobs MUST be in the gate. It's not optional.11:50
dtantsurgood catch11:51
iurygregoryin my mind we could since it was just codespell, but it's life =)11:51
dtantsurIt's basically a rule. Otherwise, you can let a change merge that breaks the CI11:52
iurygregorymakes sense11:54
opendevreviewMerged openstack/ironic master: Stop assuming service steps have priorities  https://review.opendev.org/c/openstack/ironic/+/91541512:37
opendevreviewDmitry Tantsur proposed openstack/ironic stable/2024.1: Stop assuming service steps have priorities  https://review.opendev.org/c/openstack/ironic/+/91535712:40
opendevreviewDmitry Tantsur proposed openstack/ironic stable/2023.2: Stop assuming service steps have priorities  https://review.opendev.org/c/openstack/ironic/+/91535812:40
rpittau10 minutes to PTG ! https://ptg.opendev.org/ptg.html12:51
TheJuliagood morning12:55
JayFRunning a little behind, but don't worry about waiting for me for secure boot 13:04
JayFrpittau: I see the update on PTG board, are we reconvening for networking before the top of the hour?13:36
rpittauJayF: we're on a long pause, we finished secure boot earlier than expected13:37
JayFI sorta suspected that might be the case when I saw the schedule :D 13:37
JayFI'll jump in just before top of the hr then13:37
iurygregorywe are just waiting for you JayF \o/13:38
rpittauJayF: if you want to jump in now we're just telling stories :)13:38
samcat116I can't join the ptg call unfortunately (on a train) but have some networking things to add to the current topic14:09
TheJuliasamcat116: Greetings!14:16
samcat116👋14:17
TheJuliawasamadoodle <-- newest ironic word14:18
TheJuliasamcat116: how long will you be on the train for? I suspect we could always revisit the discussion14:21
samcat116A while unfortunately :(14:25
samcat116But I think all thats in there is a good start14:25
TheJuliasamcat116: I think we're going to send a couple different mailing list posts on this subject, we're collecting action items right now14:27
TheJuliaand discussion is still ongoing14:37
SvenKieskeTheJulia: regarding the interop PTG stuff, I just dropped some - hopefully helpful - stuff in the etherpad (I guess I can't attend). maybe we can chat about this later, you can also reach me via usual channel (linkedin, mail, matrix or here)15:44
SvenKieskesorry for hijacking this channel :)15:44
JayFyou are always welcome to hijack the channel :D 15:45
SvenKieskethanks :D15:45
TheJuliaSvenKieske: would it make sense to try and setup a time? It looks like it is just Tobias and I right now.16:09
SvenKieskesure, I send you a private message16:13
JayFtc ptg started16:14
dtantsurWe're done with ironic16:14
rpittauironic PTG has ended, again thank you everyone!16:14
iurygregory\o/16:14
dkingI want to be sure to clarify, nothing in the removal of the Inspector is going to impact the use of custom collectors in IPA?16:16
dkingWe use it in an undocumented way. We let unknown nodes PXE boot, which defaults to inspection, and this allows us to run a custom collector, which in turn sets off a process that enrolls the node into Metal3 Baremetal Operator, which is what ultimately gets it into Ironic. It ends up running inspection twice.16:18
masgharMost of the collectors have been moved into ironic16:18
dtantsurdking: nothing. If you use hooks (server-side plugins), they'll need a bit of adjustments16:18
dtantsurmasghar: you're talking about hooks, dking is asking about IPA-side plugins16:18
dtantsurdking: wwwwwwwow. Maybe we should re-open the conversation about auto-discovery in Metal3... but this is going to work as before.16:19
dkingWe make heavy use of a custom Hardware Manager.16:19
dkingYeah, it's probably not the standard use case. Back when I was in OpenMetal, we used the inspect to enroll features, but since that wouldn't get it into BMO, I decided to do this crazy stuff.16:20
dtantsurUnrelated, but I'd still appreciate a review of https://review.opendev.org/c/openstack/ironic/+/915469, it's blocking many practical applications of servicing.16:20
masghardtantsur: yep, I mixed them up16:21
dtantsurdking: how do you enroll credentials btw?16:21
dkingdtantsur: If there is a chance for metal3 to do auto-discovery, please let me know.16:21
dtantsurdking: for your context, the previous discovery discussion was https://github.com/metal3-io/baremetal-operator/issues/1124, and it was closed to a large extent because of different people pulling in different directions16:22
dtantsurThe usual key problem is knowing credentials for newly enrolled nodes.16:22
dkingdtantsur: We have a backend that the new nodes hit from the custom collector. The process is still being improved, but we interface with things like the CMDB.16:22
dtantsurdking: hmm, that's a bit tough to make generic enough to include upstream16:23
dtantsurIt could be reshaped to this. Ironic enrolls the new node. BMO picks it up automatically and lets it sit in the "unmanageable" state. Your (new) controller watches for such hosts and updates them from a CMDB.16:24
dkingYeah, there's not a great solution for the creds. It can get pretty hacky. The nodes themselves generate the credentials, but I don't know of a way to get those creds into Ironic directly if it hasn't been enrolled yet. In the current process, they get piped out and eventually end up being sent to BMO.16:24
dtantsurIf you come from such an angle, it seems a feature that we could accept.16:25
dtantsurDepends also on whether you're up for some Go coding16:26
dkingI'm still a Go newbie, but I've been looking for a project to write in it.16:27
dkingI don't really know how much of our current use case is good for generic users, though. It's currently tightly coupled with CMDB, so it would have to take some thought. I might need to look through the above issue to see what people were proposing.16:28
dtantsurYeah, see my idea above for how to decouple them. Needs more thoughts of course.16:30
dkingdtantsur: Just spitballing here, but could a BMO custom collector be useful? You can't get the creds from Ironic directly, but if you set the creds on the server, you could push to some some location that is accessible to BMO. Perhaps it would involve Vault somehow?16:35
dtantsurdking: I've just written https://github.com/metal3-io/baremetal-operator/issues/1124#issuecomment-2050092410 to leave a track of our conversation16:39
dtantsurThe core of my idea is to leave the credentials completely to the downstream code. It can be your controller that takes them from the CMDB or some other place.16:40
dtantsurI really need to disconnect now, happy to continue here or on the bug tomorrow.16:41
dkingHave a good night!16:43
cidgood night \o19:56
cidBy the way, I enjoyed (maybe not the right word), the PTG session today. I hope to join more in the future.19:57
JayFo/ thanks, you're always welcome20:00
JayFNote that we need to look at rootwrap->privsec migration, I think? Or update docs to remove refernce to rootwrap21:39

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!