opendevreview | Winicius Allan Bezerra da Silva proposed openstack/ironic master: Make codespell voting https://review.opendev.org/c/openstack/ironic/+/915459 | 00:42 |
---|---|---|
rpittau | good morning ironic! o/ | 06:55 |
rpittau | JayF: re rootwrap->privsec: thanks! yeah, I had it in my notes actually but forgot to bring it up, I'll add to the meeting notes for the next week | 07:01 |
dtantsur | JayF, rpittau, we've agreed to remove any support for privilege escalation. I've done the preparation work in Ironic and IPA, now we basically need to remove run_as_root from ironic-lib. | 08:22 |
opendevreview | Merged openstack/ironic stable/2024.1: Stop assuming service steps have priorities https://review.opendev.org/c/openstack/ironic/+/915357 | 08:44 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Fix servicing clean-up https://review.opendev.org/c/openstack/ironic/+/915321 | 08:50 |
opendevreview | Merged openstack/ironic stable/2024.1: Add states.SERVICING and SERVICEWAIT to need_prepare_ramdisk https://review.opendev.org/c/openstack/ironic/+/915348 | 08:50 |
opendevreview | Merged openstack/ironic master: Remove unused DEFAULT_NEUTRON_URL constant https://review.opendev.org/c/openstack/ironic/+/915211 | 08:50 |
rpittau | dtantsur: ack, then maybe we don't need to discuss it further, I'll just take a note and see when we can tackle it | 09:00 |
rpittau | dtantsur JayF are we tracking that on launchpad? | 09:04 |
dtantsur | I'm not really, just doing it all of a sudden from time to time | 09:04 |
rpittau | ack thanks | 09:08 |
dtantsur | What do people think about using https://d2lang.com/tour/intro in the docs? I've just discovered it, and it looks super useful | 09:13 |
rpittau | Just read about it, and I had the exact same thought | 10:03 |
iurygregory | good morning Ironic | 10:06 |
opendevreview | Merged openstack/ironic master: Fix get_async_step_return_state to account for servicing https://review.opendev.org/c/openstack/ironic/+/915469 | 11:49 |
opendevreview | Dmitry Tantsur proposed openstack/ironic stable/2024.1: Fix get_async_step_return_state to account for servicing https://review.opendev.org/c/openstack/ironic/+/915526 | 11:50 |
opendevreview | Dmitry Tantsur proposed openstack/ironic stable/2023.2: Fix get_async_step_return_state to account for servicing https://review.opendev.org/c/openstack/ironic/+/915527 | 11:51 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Handle servicing failures in the Redfish BIOS interface https://review.opendev.org/c/openstack/ironic/+/915576 | 11:52 |
dtantsur | another one ^^ :) | 11:53 |
dtantsur | but we're progressing from general servicing issues to specific implementations now | 11:53 |
iurygregory | I will add to my list to look later today | 11:55 |
dtantsur | thx! | 11:55 |
rpittau | I'm afraid we'll have to disable the metalsmith cs9 legacy job in old stable branches too | 13:05 |
rpittau | although the error is different | 13:08 |
rpittau | I'll recheck once more | 13:08 |
TheJulia | dtantsur: that was quick, realistically, so good to know I at least got stuff mostly right :) | 13:11 |
dtantsur | TheJulia: yeah. We have set ourselves up for a failure by doing a lot of duplication. It's not entirely your fault, our code base is inviting to make a mistake. Wait until you see my next patch :) | 13:41 |
dtantsur | (my desire to rewrite Ironic in Rust has never been stronger than today) | 13:41 |
TheJulia | Yeah | 13:42 |
dtantsur | TheJulia: I'll let you decide as a courtesy :D Should it be service_reboot and servicing_reboot? (at least for now, until we unify this mess) | 13:45 |
TheJulia | I think folks pushed me towards the latter in review | 13:45 |
TheJulia | but likely the first | 13:45 |
dtantsur | TheJulia: spoiler: we use both at the moment. Hence my question. | 13:45 |
TheJulia | oh noes | 13:46 |
dtantsur | yeah :) | 13:46 |
dtantsur | Actually, the variant that is set is servicing_reboot (service_reboot is only read). So I may stick with it to simplify backporting the change. | 13:47 |
TheJulia | ++ | 13:47 |
iurygregory | best title for thread "ORM apocalypse mostly averted (a.k.a. SQLAlchemy 2.0 is here)" :D | 14:08 |
TheJulia | I saw that and smiled | 14:19 |
dtantsur | yeah, good job! :) | 14:36 |
opendevreview | Merged openstack/ironic master: Handle servicing failures in the Redfish BIOS interface https://review.opendev.org/c/openstack/ironic/+/915576 | 14:41 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Fix the confusion around service_reboot/servicing_reboot https://review.opendev.org/c/openstack/ironic/+/915725 | 14:41 |
dtantsur | TheJulia: a careful look is appreciated ^^^ | 14:41 |
opendevreview | Dmitry Tantsur proposed openstack/ironic stable/2024.1: Handle servicing failures in the Redfish BIOS interface https://review.opendev.org/c/openstack/ironic/+/915530 | 14:42 |
opendevreview | Dmitry Tantsur proposed openstack/ironic stable/2023.2: Handle servicing failures in the Redfish BIOS interface https://review.opendev.org/c/openstack/ironic/+/915531 | 14:43 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Fix the confusion around service_reboot/servicing_reboot https://review.opendev.org/c/openstack/ironic/+/915725 | 14:44 |
dtantsur | TheJulia: and https://review.opendev.org/c/openstack/ironic/+/915321 if you have another minute | 14:44 |
dtantsur | anyone already has a patch to make metalsmith-legacy non-voting on 2023.2? I believe it's not voting elsewhere | 14:45 |
dtantsur | Also, driver_internal_info is absolutely cursed | 14:52 |
opendevreview | Merged openstack/ironic stable/2024.1: Fix get_async_step_return_state to account for servicing https://review.opendev.org/c/openstack/ironic/+/915526 | 14:58 |
JayF | iurygregory: that post makes me hopeful that one day I can send one about an eventletpocalypse being averted | 14:59 |
rpittau | dtantsur: I was going to after the next recheck, but I'm losing hope so I can make one now before leaving for the weekend :) | 15:01 |
iurygregory | JayF, yes! | 15:02 |
opendevreview | Riccardo Pittau proposed openstack/ironic stable/2023.2: Marking metalsmith legacy job as non-voting https://review.opendev.org/c/openstack/ironic/+/915728 | 15:04 |
rpittau | dtantsur: ^ | 15:04 |
dtantsur | JayF: you've just given me one more reason to stick around :D | 15:05 |
dtantsur | rpittau: thanks! | 15:05 |
rpittau | JayF: we were just talking about eventlet downstream, but in good terms this time, I should mark the calendar :D | 15:05 |
rpittau | ok, good terms is too strong, "not bad terms" is better | 15:06 |
JayF | https://review.opendev.org/c/openstack/governance/+/902585/19#message-e4846bc676f9f760a45f8a491e4176ee5d704135 | 15:07 |
TheJulia | dtantsur: I'll look soon, trying to capture some stuff out from yesterday while also get on the same page with some folks | 15:07 |
JayF | that was outcome from discussion on it yesterday | 15:07 |
TheJulia | rpittau: .... good, and eventlet in the same sentence ?!? | 15:08 |
TheJulia | Alert the Media! | 15:08 |
rpittau | :D | 15:08 |
rpittau | bye everyone, have a great weekend! o/ | 15:17 |
dtantsur | jsonschema/validators.py:1300: DeprecationWarning: The metaschema specified by $schema was not found. Using the latest draft to validate, but this will raise an error in the future. | 15:50 |
dtantsur | How sweet! | 15:50 |
JayF | If you can toss that in a bug and label it low-hanging fruit, that is the sort of change that might be perfect for a low time commitment contributor | 15:53 |
TheJulia | dtantsur: awwwwwwwwww | 15:55 |
dtantsur | JayF: https://bugs.launchpad.net/ironic/+bug/2061160 | 15:56 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Fix the confusion around service_reboot/servicing_reboot https://review.opendev.org/c/openstack/ironic/+/915725 | 16:10 |
iurygregory | I think is just a matter to update the $schema it uses... (after testing locally) but I won't push the change :D | 16:23 |
opendevreview | Winicius Allan Bezerra da Silva proposed openstack/ironic master: Make codespell voting https://review.opendev.org/c/openstack/ironic/+/915459 | 16:56 |
*** atmark_ is now known as atmark | 17:16 | |
opendevreview | Winicius Allan Bezerra da Silva proposed openstack/ironic master: Fix spelling reported by codespell https://review.opendev.org/c/openstack/ironic/+/915457 | 17:35 |
opendevreview | Winicius Allan Bezerra da Silva proposed openstack/ironic master: Make codespell voting https://review.opendev.org/c/openstack/ironic/+/915459 | 17:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!