| janders | frickler rpittau thank you for the pointers. I can get further with those, but now hitting https://paste.opendev.org/show/b49ZKTY7i01scd8D83e1/ . I suspect it may be a local env problem and I am tempted to retry CI once https://review.opendev.org/c/openstack/bifrost/+/940527 merges, WDYT? | 04:44 |
|---|---|---|
| janders | (I am reasonably confident my changes shouldn't break Openstack module resolution, it's probably my python/tox config) | 04:45 |
| janders | (and/or another required repo I don't have sitting around) | 04:46 |
| opendevreview | Kaifeng Wang proposed openstack/ironic master: Fixes the issue of flat network provision when porgroup is configured https://review.opendev.org/c/openstack/ironic/+/934433 | 06:06 |
| *** Guest7825 is now known as diablo_rojo_phone | 06:12 | |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Remove reboot from basic baremetal ops https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/940247 | 07:06 |
| opendevreview | cid proposed openstack/ironic master: Trivial: Clean up residual `.vbmc` dir after clean https://review.opendev.org/c/openstack/ironic/+/940573 | 07:09 |
| rpittau | good morning ironic! o/ | 07:25 |
| janders | hey rpittau o/ | 07:26 |
| opendevreview | Merged openstack/ironic master: Fix hold/wait step logic in step validation https://review.opendev.org/c/openstack/ironic/+/939401 | 07:40 |
| opendevreview | Vasyl Saienko proposed openstack/ironic master: [devstack ]Use tap interfaces for VMs https://review.opendev.org/c/openstack/ironic/+/940584 | 08:14 |
| opendevreview | Kaifeng Wang proposed openstack/ironic-python-agent-builder master: Allow adjusting compression level when using lzma https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/940602 | 08:34 |
| rpittau | cardoe: hey thanks for https://review.opendev.org/c/openstack/sushy/+/940557 looks great at a glance, you got any chance to test it on real hardware? | 08:34 |
| opendevreview | Vasyl Saienko proposed openstack/networking-generic-switch master: Fix ngs_allowed_vlans validation https://review.opendev.org/c/openstack/networking-generic-switch/+/940606 | 10:53 |
| opendevreview | Vasyl Saienko proposed openstack/networking-generic-switch master: Fix ngs_allowed_vlans validation https://review.opendev.org/c/openstack/networking-generic-switch/+/940606 | 10:56 |
| *** bodgix9 is now known as bodgix | 11:05 | |
| opendevreview | Jacob Anders proposed openstack/bifrost master: Fix typo in CLI parameter spefifying config drive. https://review.opendev.org/c/openstack/bifrost/+/940507 | 11:24 |
| opendevreview | Vasyl Saienko proposed openstack/ironic master: [devstack] Allow deploy environment with porgroups https://review.opendev.org/c/openstack/ironic/+/940611 | 11:36 |
| opendevreview | Vasyl Saienko proposed openstack/ironic master: Test patch to check porgroups https://review.opendev.org/c/openstack/ironic/+/940612 | 11:36 |
| opendevreview | Elod Illes proposed openstack/ironic-python-agent unmaintained/yoga: [CI] Remove centos-8 based jobs https://review.opendev.org/c/openstack/ironic-python-agent/+/938306 | 11:49 |
| opendevreview | Jacob Anders proposed openstack/bifrost master: Update `uuid` to `id` in node_info to match module change https://review.opendev.org/c/openstack/bifrost/+/940505 | 11:56 |
| cardoe | rpittau: not yet but that’s my plan for today. It fails tests while master doesn’t which is super odd because the test is 100% wrong. So not sure why it’s passing in master which has me a bit concerned so I was going through the test. | 13:50 |
| opendevreview | Vasyl Saienko proposed openstack/ironic master: [devstack] Allow deploy environment with porgroups https://review.opendev.org/c/openstack/ironic/+/940611 | 13:55 |
| opendevreview | Vasyl Saienko proposed openstack/ironic master: Test patch to check porgroups https://review.opendev.org/c/openstack/ironic/+/940612 | 13:55 |
| opendevreview | Vasyl Saienko proposed openstack/ironic master: Test patch to check porgroups https://review.opendev.org/c/openstack/ironic/+/940612 | 13:56 |
| TheJulia | good morning | 14:09 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Support for bootable containers https://review.opendev.org/c/openstack/ironic-specs/+/933620 | 14:20 |
| opendevreview | Julia Kreger proposed openstack/ironic stable/2024.2: Fix redfish session cache on missing password https://review.opendev.org/c/openstack/ironic/+/940634 | 14:26 |
| opendevreview | Julia Kreger proposed openstack/ironic stable/2024.1: Fix redfish session cache on missing password https://review.opendev.org/c/openstack/ironic/+/940635 | 14:26 |
| opendevreview | Julia Kreger proposed openstack/ironic stable/2023.2: Fix redfish session cache on missing password https://review.opendev.org/c/openstack/ironic/+/940636 | 14:27 |
| cardoe | How do you do those backports? | 14:30 |
| TheJulia | cardoe: I just used the cherry-pick button in the gui | 14:31 |
| TheJulia | and set the target branch accordingly | 14:31 |
| cardoe | ah okay makes sense | 14:32 |
| TheJulia | it either succeeds or fails | 14:32 |
| TheJulia | if it fails, I have to do it manually with gerrit | 14:32 |
| TheJulia | out of curiosity, regarding https://review.opendev.org/c/openstack/ironic/+/940331 I guess reset() was dead code? | 14:32 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2024.2: Fix hold/wait step logic in step validation https://review.opendev.org/c/openstack/ironic/+/940637 | 14:32 |
| cardoe | Yeah it was never called. | 14:32 |
| cardoe | I didn't see anywhere we had a path to hooking up reseting the hooks that were loaded. | 14:33 |
| cardoe | I'm gonna work up something for PTG around hooks and rules. | 14:33 |
| cardoe | I think there's value in having the SIGHUP to reset / reload them. But different approach. | 14:34 |
| cardoe | If that's fair? | 14:34 |
| TheJulia | I suspect that is fair | 14:34 |
| TheJulia | I noticed, at least on the task object interfaces for drivers we don't reload them on hup which was... sort of annoying | 14:35 |
| TheJulia | I can see why though, the whole issue is if a driver fails horribly | 14:35 |
| opendevreview | Vasyl Saienko proposed openstack/ironic master: [devstack] Allow deploy environment with portgroups https://review.opendev.org/c/openstack/ironic/+/940611 | 14:37 |
| opendevreview | Vasyl Saienko proposed openstack/ironic master: Test patch to check porgroups https://review.opendev.org/c/openstack/ironic/+/940612 | 14:37 |
| rpittau | can I interest someone with a quick review to unblock bifrost CI? :) https://review.opendev.org/c/openstack/bifrost/+/940527 | 14:37 |
| TheJulia | cardoe: w/r/t https://review.opendev.org/c/openstack/ironic/+/940332 those two tests might be better off moved since they don't test the agent, but test the inspection stuff you moved | 14:38 |
| cardoe | rpittau: I can only +1 for bifrost but I gave it mine. I'll look at some other ansible-lint fixes in the future as well. | 14:39 |
| rpittau | thanks cardoe :) | 14:39 |
| cardoe | TheJulia: yeah good point. I'll do that in there. | 14:40 |
| cardoe | TheJulia: So I told JayF but once cid's rules bits go in. I was going to come back and adjust the Common class so that redfish used it as well. Essentially moved the node to INSPECTWAIT even with redfish and instead of waiting for the continue_inspection API endpoint to be hit to start the conductor task of the next part, when redfish was done it would just kick off the task. | 14:41 |
| TheJulia | rpittau: minor nit, some sort of reference to ansible would be nice :) | 14:42 |
| cardoe | I'm actually trying to write tests for it. Somehow when I moved the idrac stuff to sushy, it exposed a test issue in sushy. And now I'm like 25 yaks down the line fixing some test issues in sushy. | 14:42 |
| TheJulia | rpittau: but I'm about to approve that bifrost change | 14:42 |
| rpittau | TheJulia: oh I think I forgot to add "ansible core" before 2.19 :D | 14:44 |
| TheJulia | I was thinking more a link | 14:45 |
| rpittau | ah ok | 14:45 |
| * dtantsur takes his killjoy role | 14:50 | |
| dtantsur | cardoe: *WAIT states assume that Ironic is not doing anything with the nodes, particularly is not holding a lock | 14:50 |
| TheJulia | dtantsur: if your talking about the tv show, that was epic | 14:51 |
| dtantsur | I'm talking about me :D | 14:51 |
| dtantsur | while not critical, changing that breaks certain long-standing assumptions (e.g. that *WAIT states are interruptible) | 14:51 |
| TheJulia | Yeah, reading what cardoe wrote, in redfish the node should never touch wait... unless... somehow we downgrade and upgrade a lock, but the task would need to be interruptable at that level so it makes sense to just keep it in the active state | 14:52 |
| dtantsur | we do downgrade locks somewhere, I think, but it comes at a price: what if you cannot acquire it again? | 14:52 |
| TheJulia | yeah | 14:53 |
| TheJulia | Yeah, the code that I remember does, is like super special cased | 14:53 |
| cardoe | dtantsur: welcome back. let's talk more about inspect sometime? | 14:53 |
| cardoe | I can skip the WAIT happily. | 14:53 |
| dtantsur | Happily, need to figure out my schedule again :) | 14:54 |
| cardoe | I was just mentally planning the same flow. | 14:54 |
| cardoe | Total aside, can we pass kernel parameters on a deploy? Like the deployed image via image parameters? | 14:55 |
| TheJulia | cardoe: could you elaborate on the context of the deploy a bit more, please. | 14:55 |
| cardoe | So we're working on the trunk patches so that you can have working trunk ports. Wonderfully the netnames with the VLAN number appended are too long. So just trying to have them pass net.ifnames=0 to the kernel | 14:56 |
| dtantsur | Various kernel_append_params options maybe? | 14:57 |
| TheJulia | for the deployed os? | 14:57 |
| cardoe | yeah the deployed OS | 14:57 |
| TheJulia | we *really* try to avoid modifying the image contents and thus configuration options passed throguh | 14:57 |
| TheJulia | since that requires changing the state on disk. That being said, I can totally be convinced its a good idea | 14:58 |
| cardoe | So these Dell's the physical interface name is 14 characters and when the VLAN info is passed to cloud-init, the name is ".$VLAN" which exceeds the kernels 16 char limit | 14:58 |
| * TheJulia facepalms | 14:58 | |
| TheJulia | we've had a similar issue downstream recently | 14:58 |
| dtantsur | Something optional could take inspiration from https://docs.openstack.org/ironic-python-agent/latest/admin/hardware_managers.html#injecting-files | 14:58 |
| TheJulia | ... who decided interfaces can only be 14 chars long? | 14:58 |
| cardoe | enp196s0f0np0 is the interface name | 14:58 |
| dtantsur | absolutely cursed | 14:59 |
| TheJulia | ... | 14:59 |
| TheJulia | wow | 14:59 |
| TheJulia | yes | 14:59 |
| cardoe | oddly if you don't use VLANs it seems to rename it to a shorter version | 14:59 |
| TheJulia | yeah, super similar | 14:59 |
| cardoe | https://usercontent.irccloud-cdn.com/file/3WFAdMow/image.png | 14:59 |
| JayF | I'll note that you can use udev rules to give them different names, you don't just have to opt out of the new naming system. At least if you use those, you still get consistent names | 15:00 |
| cardoe | I'm just trying to get them to speed run this to validate this so we can submit some patches to nova before the 2025.1 cycle. | 15:00 |
| dtantsur | bonus: a udev rule can probably be inserted by the existing inject_files step | 15:00 |
| JayF | The painful part of it is I think you need a MAC address for that | 15:00 |
| JayF | Or some other kind of unique identifier for the device | 15:00 |
| JayF | But there may be a more clever way that is more generic that I don't know | 15:01 |
| rpittau | sorry to interrupt :) | 15:01 |
| rpittau | it'll be quick | 15:01 |
| rpittau | #startmeeting ironic | 15:01 |
| opendevmeet | Meeting started Mon Feb 3 15:01:23 2025 UTC and is due to finish in 60 minutes. The chair is rpittau. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'ironic' | 15:01 |
| rpittau | Hello everyone! | 15:01 |
| rpittau | Welcome to our weekly meeting! | 15:01 |
| rpittau | The meeting agenda can be found here: | 15:01 |
| rpittau | #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_February_03.2C_2025 | 15:01 |
| TheJulia | o/ | 15:01 |
| masghar | o/ | 15:01 |
| cardoe | o/ | 15:02 |
| JayF | o/ | 15:02 |
| * cid o/ on mobile | 15:03 | |
| keekz | o/ | 15:03 |
| rpittau | nice attendance today :) | 15:04 |
| rpittau | #topic Announcements/Reminders | 15:04 |
| rpittau | Standing reminder to review patches tagged ironic-week-prio and to hashtag any patches ready for review with ironic-week-prio: | 15:04 |
| rpittau | #https://tinyurl.com/ironic-weekly-prio-dash | 15:04 |
| rpittau | #link https://tinyurl.com/ironic-weekly-prio-dash | 15:04 |
| rpittau | lot of patches are on their way to be merged | 15:04 |
| rpittau | looks ok | 15:04 |
| cardoe | So speaking of patches... I want to ask | 15:05 |
| rpittau | we still have 2 specs there that need attention | 15:05 |
| rpittau | #link https://review.opendev.org/c/openstack/ironic-specs/+/933620 | 15:05 |
| rpittau | #link https://review.opendev.org/c/openstack/ironic-specs/+/938526 | 15:05 |
| rpittau | yes cardoe? | 15:05 |
| cardoe | I've got the sushy pyupgrade patch. It's got a bunch of +2's... just wondering how people feel about it. Because my next question is gonna be... how do people feel about just using Python's Black spec. | 15:06 |
| TheJulia | 933620 was revised this morning for two nits, just needs some +2 love :) | 15:06 |
| rpittau | TheJulia: cool, I'll have a look after the meetnig | 15:06 |
| cardoe | If we just take Black as it comes, we can enable auto-formatting in pre-commit (and in your editors) and not have to worry about style editing / etc and have the tools do it for us. | 15:06 |
| rpittau | is it this patch? https://review.opendev.org/c/openstack/sushy/+/934916 | 15:08 |
| cardoe | Yes. | 15:08 |
| opendevreview | Merged openstack/ironic master: doc: fix typo and slight wording order for networking https://review.opendev.org/c/openstack/ironic/+/940558 | 15:08 |
| dtantsur | I remember black was not fully pep8 compatible? | 15:08 |
| cardoe | black is pep8 compatible. | 15:08 |
| rpittau | that's also waht I remember | 15:08 |
| rpittau | ok | 15:08 |
| cardoe | pep8 is just ambiguous | 15:08 |
| dtantsur | Oh, they fixed it? Good. | 15:08 |
| dtantsur | No, no, it was something very explicitly incompatible. I just cannot remember what. | 15:09 |
| dtantsur | As in: black formatted code would fail a pep8 check. | 15:09 |
| rpittau | I have the same memory, but it was some time ago | 15:09 |
| dtantsur | yeah, they could have changed it | 15:09 |
| dtantsur | "Black is a PEP 8 compliant opinionated formatter" | 15:10 |
| dtantsur | yeah, it's a different stance from the one they had back in the days | 15:10 |
| rpittau | oh well, I don't have anything particularly against it | 15:10 |
| kubajj | o/ | 15:10 |
| TheJulia | I guess the only question is, have other projects done the same | 15:10 |
| dtantsur | I personally find some of the things these formatters do annoying, but I'll follow the pack | 15:10 |
| rpittau | TheJulia: right | 15:10 |
| TheJulia | dtantsur: samesies | 15:10 |
| dtantsur | TheJulia: openstacksdk was at least moving towards it | 15:10 |
| JayF | I don't have an opinion as to what style is used, I am plus one to using auto formatters. And as a bonus, I'm sure that black style format will likely be supported by my IDE | 15:11 |
| * dtantsur hopes it's easy to setup vim in a way that uses per-repo formatters.. | 15:11 | |
| rpittau | just a point that sometimes format style between python versions is incompatible | 15:11 |
| TheJulia | dtantsur: samesies, again :) | 15:12 |
| dtantsur | :) | 15:12 |
| dtantsur | rpittau: yeah, we'd need to be able to tell it to use the formatting compatible with the oldest supported version | 15:12 |
| rpittau | yep | 15:12 |
| dtantsur | it was a problem in the past, not sure how much of a problem it is nowadays | 15:12 |
| rpittau | do we want to give it some more time to think about it ? | 15:12 |
| cardoe | So the reason I ask is that we'd just get freebie formatting without having to fight a style checker. | 15:12 |
| cardoe | rpittau: sure thing. I just want to make it easier for everyone to contribute and collaborate and if automation can take a tedious thing off the table then it might be a plus. | 15:13 |
| JayF | Honestly, the pre-commit stuff has done a large amount of progress toward that direction | 15:13 |
| cardoe | Cause ruff can fix a lot of issues without people needing to manually fix stuff but it can only do it enabling its formatter, which only supports black right now. | 15:14 |
| cardoe | Literally the only 2 config knobs they have is line length and if you want strings to be single quote or double quote. | 15:14 |
| TheJulia | ... We should get back on track | 15:14 |
| * dtantsur is horrified by the potential diff | 15:14 | |
| rpittau | alright, let's give it some more time and we'll go back to it | 15:15 |
| cardoe | TheJulia: yes. sorry. | 15:15 |
| rpittau | next one is | 15:15 |
| cardoe | I'd say let's commit to reviewing the bootable containers and graphical console spec this week? | 15:15 |
| rpittau | 2025.1 Epoxy Release Schedule | 15:15 |
| rpittau | #link https://releases.openstack.org/epoxy/schedule.html | 15:16 |
| rpittau | 8 weeks to go! | 15:16 |
| rpittau | and this week PTL nomination period starts February 5 | 15:16 |
| rpittau | left the announcement for the next PTG | 15:17 |
| rpittau | Flamingo PTG will take place place April 7-11, 2025! | 15:17 |
| rpittau | related to the schedule: | 15:17 |
| rpittau | new bugfix branches cut is happening this week | 15:17 |
| rpittau | anything else to announce/remind ? | 15:17 |
| dtantsur | KubeCon and the PTG back-to-back, OMG | 15:18 |
| rpittau | yep.... | 15:18 |
| rpittau | we don't have planned discussion topics today | 15:19 |
| rpittau | any open topic? | 15:19 |
| JayF | Please take time to review inspector rules; it's extremely close and I'd like to close that chapter | 15:19 |
| JayF | cid and I can do a demo/group review session if it'd be helpful | 15:19 |
| masghar | JayF: thanks for the heads up, will do! | 15:20 |
| cid | ++ | 15:20 |
| JayF | Also another small announcement: Next week Satoshi will be joining GR-OSS as an MLH fellow; focusing on a hardware manager to run steps from a container. | 15:20 |
| TheJulia | Also, later in the week, I could possibly do a bootable containers demo. Thursday or Friday if anyone is interested | 15:20 |
| rpittau | JayF: is that in ironic week prio list ? | 15:20 |
| JayF | rpittau: I believe so but not 100% sure; I'll double check | 15:20 |
| rpittau | ok | 15:21 |
| cardoe | I wrote up https://etherpad.opendev.org/p/ironic-cardoe-inspect-hooks-and-rules and https://gist.github.com/cardoe/82ca7d2a33ae963dbe30f2b43ac13f64 which was my thought around using inspector hooks and rules and I'd love to get cid's feedback. I'm all for a a demo/review session. | 15:21 |
| masghar | (Definitely interested in both demos) | 15:21 |
| cardoe | TheJulia: +1 I'm in for a demo of bootable containers too | 15:21 |
| JayF | yep +1 to bootc demo | 15:21 |
| rpittau | both sound quite interesting | 15:21 |
| * dtantsur +1 to both | 15:21 | |
| rpittau | not sure if I will be around on Friday, so I vote for Thursday :D | 15:22 |
| TheJulia | Okay, should be possible | 15:22 |
| JayF | How about Thursday for both? assuming cid has availability | 15:22 |
| * JayF can set it aside overall as a review day | 15:22 | |
| TheJulia | ++ | 15:22 |
| rpittau | we can do one this week and the other next week ? | 15:23 |
| cid | cardoe, I had already taken a look, I will do well to give some feedback. | 15:23 |
| JayF | maybe just not everyone needs to go to both? | 15:23 |
| JayF | I don't wanna ask cid to wait more on inspector rules | 15:23 |
| rpittau | sure | 15:23 |
| cardoe | JayF: Can ya help me figure out why codespell doesn't seem to run on ironic-specs? https://review.opendev.org/c/openstack/ironic-specs/+/938526 I see rpittau's making review comments for spelling issues. :/ | 15:23 |
| JayF | will look cardoe | 15:24 |
| cid | I’ll be available on Thursday or Friday +++ | 15:24 |
| rpittau | alright, anything else to discuss today? | 15:24 |
| JayF | cardoe: may just need a rebase fwiw | 15:24 |
| opendevreview | Steve Baker proposed openstack/ironic-specs master: Graphical Console Support https://review.opendev.org/c/openstack/ironic-specs/+/938526 | 15:24 |
| JayF | I rebased it. | 15:24 |
| rpittau | thank you everyone! | 15:25 |
| rpittau | #endmeeting | 15:25 |
| opendevmeet | Meeting ended Mon Feb 3 15:25:14 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:25 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-02-03-15.01.html | 15:25 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-02-03-15.01.txt | 15:25 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-02-03-15.01.log.html | 15:25 |
| TheJulia | *wow* stevebaker[m] is awake stupidly early or quite late | 15:25 |
| JayF | TheJulia: that's me hitting gerrit rebase button to fix cardoe's complaint :) | 15:25 |
| TheJulia | oh, heh, yeah | 15:25 |
| TheJulia | I liked it when it told us who did it instead of the actual creator of the change set | 15:26 |
| cid | While we’re here, is this a bug or a wishlist ? https://bugs.launchpad.net/ironic/+bug/2097102 | 15:26 |
| JayF | does our API document that it's paginated? | 15:27 |
| cid | Not sure | 15:27 |
| JayF | it's documented that the limit should work; that makes me think it's a bug --> https://docs.openstack.org/api-ref/baremetal/#conductors-conductors | 15:27 |
| * JayF is surprised anyone has that many conductors | 15:28 | |
| * cid don’t know the norm, but that sounds like a lot too ;) | 15:29 | |
| JayF | Most places I've worked have had ratios of hundreds and hundreds of nodes to one conductor | 15:29 |
| JayF | I assume in this case, conductor is likely per rack or something reflective of their environment, but that's fun to do the math on anyway :P | 15:29 |
| cid | :) | 15:31 |
| cid | A bug it is | 15:31 |
| kubajj | any suggestion on how to fix the conflicting dependency for pbr in the CI for Bobcat of IPA? | 15:32 |
| TheJulia | JayF: yeah, that is a lot of bare metal nodes with that many conductors. I know orgs who have that many conductors in total... but not in a single deployment. | 15:32 |
| TheJulia | Has anyone looked into failures on the ovn + uefi job ? | 15:59 |
| TheJulia | https://zuul.opendev.org/t/openstack/builds?job_name=ironic-tempest-ovn-uefi-ipmi-pxe&project=openstack/ironic | 15:59 |
| opendevreview | Merged openstack/bifrost master: Fix ansible linters https://review.opendev.org/c/openstack/bifrost/+/940527 | 16:25 |
| opendevreview | Merged openstack/bifrost master: Fix typo in CLI parameter spefifying config drive. https://review.opendev.org/c/openstack/bifrost/+/940507 | 16:25 |
| opendevreview | Merged openstack/bifrost master: Update `uuid` to `id` in node_info to match module change https://review.opendev.org/c/openstack/bifrost/+/940505 | 16:34 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] Run metal3 integration job using UEFI boot (default) https://review.opendev.org/c/openstack/ironic/+/939694 | 16:37 |
| opendevreview | Merged openstack/ironic-python-agent master: Trivial: Fix config help text about clock syncing https://review.opendev.org/c/openstack/ironic-python-agent/+/940570 | 16:44 |
| opendevreview | Merged openstack/ironic master: move inspection hooks initialization https://review.opendev.org/c/openstack/ironic/+/940331 | 16:54 |
| rpittau | good night! o/ | 17:06 |
| cardoe | TheJulia: did Steve address your concerns in https://review.opendev.org/c/openstack/ironic/+/939504 ? | 17:18 |
| cardoe | I wanna make sure that aligns with his graphical console plans and doesn't conflict in the end. | 17:19 |
| TheJulia | cardoe: I *think* so, I'm not sure the test matches the code change though | 17:20 |
| vsaienko | hello ironic community, I would like to implement static port group testing on CI. I've added support for port group deployment https://review.opendev.org/c/openstack/ironic/+/940584/ and https://review.opendev.org/c/openstack/ironic/+/940611. And checked if deployment passing when portgroups are used https://review.opendev.org/c/openstack/ironic/+/940612. Can you please help with review of those patches and let me know in which pe | 17:20 |
| vsaienko | r-commit/periodic job it makes sense to enable portgroups. | 17:20 |
| TheJulia | We don't rely upon periodic jobs, so it would need to be part of the standing pipeline. I guess it would also help to understand why and the use case the testing seeks to validate | 17:21 |
| vsaienko | Use case is to test that we can deploy when port groups are configured, and if nova generates network data correctly with bond configuration. | 17:24 |
| vsaienko | I do not think that we have any test that checks exact network data configuration inside guest. | 17:24 |
| TheJulia | I was thinking in the changes, not in irc | 17:24 |
| TheJulia | so reviewers have increased context | 17:24 |
| TheJulia | AFAIK, we do not test the resulting metadata | 17:25 |
| vsaienko | this is next step that I would like to implement - test that will boot ubuntu/fedora and check that bond is configured according to what we've asked | 17:26 |
| TheJulia | ... then we would be testing the OS | 17:26 |
| TheJulia | I'm semi -1 to testing the OSses interpretation with our limited resources, but I can see your point in the value of it | 17:27 |
| TheJulia | Just as context, and semi-related, we've merged a removal of the post-deployed OS reboot check | 17:28 |
| TheJulia | because some distribution OSes were failing and that is outside of our exact pervue of supporting if they are changing firewalling post deploy. https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/940247 | 17:28 |
| vsaienko | we can check content of network_data that it contains required info if cirros cloudinit script does not support bond configuration | 17:33 |
| vsaienko | to make it lightweight | 17:34 |
| vsaienko | I event think that additional test is not really needed, we may add this check if node has portgroup in baremetal_server_ops. | 17:34 |
| TheJulia | it doesn't support it at all, afaik | 17:42 |
| TheJulia | it being cirros | 17:42 |
| TheJulia | That could be reasonable actually | 17:42 |
| vsaienko | ok, let me update the test and check everything together. | 17:44 |
| TheJulia | cool cool | 17:57 |
| TheJulia | Also good to see you around :) | 17:57 |
| opendevreview | Verification of a change to openstack/ironic master failed: Trivial: Remove the long deprecated `token` arg https://review.opendev.org/c/openstack/ironic/+/940567 | 18:44 |
| opendevreview | Verification of a change to openstack/ironic stable/2024.1 failed: Fix redfish session cache on missing password https://review.opendev.org/c/openstack/ironic/+/940635 | 18:45 |
| opendevreview | Merged openstack/ironic-python-agent master: Collect bus and driver for interfaces https://review.opendev.org/c/openstack/ironic-python-agent/+/940568 | 20:15 |
| opendevreview | Jay Faulkner proposed openstack/ironic-inspector master: Migrate from ironic-lib https://review.opendev.org/c/openstack/ironic-inspector/+/939407 | 21:20 |
| JayF | I think I got the grenade fixed there \o/ | 21:20 |
| JayF | fwiw if my fix works; it means inspector grenade has been broken for more than half the cycle so far (the fix is for the global venv stuff, which was implemented in grenade a while back) | 21:28 |
| JayF | not surprising given how little churn there is in that repo, but still notable | 21:28 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: devstack: respect USE_VENV in Ironic https://review.opendev.org/c/openstack/ironic/+/930776 | 21:51 |
| JayF | cardoe: it's extremely likely that grenade failure is real on that fwiw but new logs will be nice | 21:53 |
| cardoe | Yeah that's why I rebased it. Cause I know we tweaked some other parts recently so I just wanted fresh logs. | 21:53 |
| TheJulia | brrrraaaaains | 23:08 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
