opendevreview | Habeeb Babasulaiman proposed openstack/bifrost master: bug: drop --develop flag from testenv usage https://review.opendev.org/c/openstack/bifrost/+/946724 | 01:01 |
---|---|---|
opendevreview | Habeeb Babasulaiman proposed openstack/bifrost master: bug: drop baremetal introspection mention https://review.opendev.org/c/openstack/bifrost/+/946726 | 01:01 |
opendevreview | Habeeb Babasulaiman proposed openstack/bifrost master: bug: drop --develop flag from testenv usage https://review.opendev.org/c/openstack/bifrost/+/946724 | 01:06 |
opendevreview | Habeeb Babasulaiman proposed openstack/bifrost master: bug: drop baremetal introspection mention https://review.opendev.org/c/openstack/bifrost/+/946726 | 01:06 |
opendevreview | Habeeb Babasulaiman proposed openstack/bifrost master: bug: drop --develop flag from testenv usage https://review.opendev.org/c/openstack/bifrost/+/946724 | 01:11 |
opendevreview | Habeeb Babasulaiman proposed openstack/bifrost master: bug: drop baremetal introspection mention https://review.opendev.org/c/openstack/bifrost/+/946726 | 01:11 |
opendevreview | Takashi Kajinami proposed openstack/sushy-tools master: Revert "Replace license classifier" https://review.opendev.org/c/openstack/sushy-tools/+/952080 | 07:41 |
opendevreview | Takashi Kajinami proposed openstack/ironic-ui master: Revert "Replace license classifier" https://review.opendev.org/c/openstack/ironic-ui/+/952081 | 07:41 |
opendevreview | Takashi Kajinami proposed openstack/sushy master: Revert "Replace license classifier" https://review.opendev.org/c/openstack/sushy/+/952082 | 07:41 |
opendevreview | Takashi Kajinami proposed openstack/python-ironicclient master: Revert "Replace license classifier" https://review.opendev.org/c/openstack/python-ironicclient/+/952083 | 07:41 |
opendevreview | Takashi Kajinami proposed openstack/ironic-inspector master: Revert "Remove license classifier" https://review.opendev.org/c/openstack/ironic-inspector/+/952084 | 07:41 |
TheJulia | good morning | 13:01 |
opendevreview | Allain Legacy proposed openstack/ironic-specs master: Add support for standalone network configuration https://review.opendev.org/c/openstack/ironic-specs/+/952126 | 13:23 |
JayF | CID left us a present over the weekend. An eventlet wsgi removal patch in a lovely green 😂 | 13:32 |
cid | 😂 | 13:33 |
JayF | Jfyi, I'm going to have to leave at about 2:00 p.m. my time -- we're expecting to be able to take a sick Kitty home from the hospital | 13:36 |
TheJulia | good news all around! | 13:44 |
JayF | Yeah certainly was not a fun weekend | 13:50 |
JayF | https://review.opendev.org/c/openstack/ironic/+/951054 wow 3 passes in a row | 14:11 |
JayF | this is enough evidence for me to blame all CI instability on the eventlet wsgi server /s | 14:11 |
opendevreview | Abhishek Bongale proposed openstack/ironic-tempest-plugin master: Add Tempest tests for inspection rules in Ironic https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/951761 | 14:13 |
opendevreview | Stephen Finucane proposed openstack/ironic master: conf: Add '[api] response_validation' option https://review.opendev.org/c/openstack/ironic/+/945515 | 14:24 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for allocations API (versioning) https://review.opendev.org/c/openstack/ironic/+/945217 | 14:24 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for allocations API (requests) https://review.opendev.org/c/openstack/ironic/+/945218 | 14:24 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for allocations API (responses) https://review.opendev.org/c/openstack/ironic/+/928921 | 14:24 |
TheJulia | Question: has any before/after benchmarking been done? | 14:49 |
TheJulia | Specifically, to identify if the performance has drastically changed and if we need to reset exepectations? | 14:49 |
cid | No benchmarkings yet. | 14:52 |
JayF | That's going to be tough without a lab. | 14:52 |
* TheJulia wonders why we pulled the CI job which logged data on that | 14:52 | |
JayF | I guess devstack would give some insight; but really we have three running modes to benchmark in some way: integrated (cond+api+rabbit), standalone single-process, standalone json-rpc | 14:53 |
JayF | of those three, json-rpc is the most likely to have perf impacts imo | 14:53 |
JayF | Who's going to run things this morning? | 15:01 |
* JayF volunteers | 15:01 | |
JayF | #startmeeting ironic | 15:01 |
opendevmeet | Meeting started Mon Jun 9 15:01:33 2025 UTC and is due to finish in 60 minutes. The chair is JayF. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
opendevmeet | The meeting name has been set to 'ironic' | 15:01 |
JayF | Hello everyone, welcome to the Ironic meeting, we're operating under the OpenInfra Foundation CoC as usual. | 15:01 |
JayF | #note Standing reminder to review patches tagged ironic-week-prio and to hashtag any patches ready for review with ironic-week-prio: https://tinyurl.com/ironic-weekly-prio-dash | 15:01 |
alegacy | o/ | 15:02 |
JayF | #note it's R-16 -- 2025.2 Flamingo Release Schedule https://releases.openstack.org/flamingo/schedule.html | 15:02 |
cid | o/ | 15:02 |
JayF | I'm going to give a couple extra minutes for more participants to o/ :) | 15:03 |
cardoe | half o/ | 15:04 |
JayF | We've only got four folks so I'm going to run through things fairly quickly. | 15:05 |
cardoe | I'll flog the weekly prio patch list. There's a lot in there. There's a lot that have sat around for a while. If the patch is in that list you should be actively trying to get it to land otherwise it needs to get outta that list. | 15:05 |
JayF | #topic Working Group Updates: Standalone networking | 15:05 |
iurygregory | o/ | 15:05 |
JayF | #link https://etherpad.opendev.org/p/ironic-standalone-networking | 15:05 |
JayF | Any updates form the standalone networking WG? | 15:06 |
alegacy | I've posted a Spec this morning for the standalone networking work: https://review.opendev.org/c/openstack/ironic-specs/+/952126 | 15:06 |
alegacy | and an RFE https://bugs.launchpad.net/ironic/+bug/2113769 | 15:06 |
opendevreview | Abhishek Bongale proposed openstack/ironic-tempest-plugin master: Add Tempest tests for inspection rules in Ironic https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/951761 | 15:06 |
JayF | Thanks for those. I'm going to go ahead and mark the bug as spec-needed | 15:07 |
JayF | er, needs-spec :) | 15:07 |
JayF | #link https://review.opendev.org/c/openstack/ironic-specs/+/952126 | 15:08 |
JayF | #link https://bugs.launchpad.net/ironic/+bug/2113769 | 15:08 |
JayF | Thanks for that. I'll give a little bit of time if there's anything else on standalone networking. | 15:08 |
TheJulia | braaaains | 15:10 |
TheJulia | I totally blanked on the meeting | 15:10 |
JayF | #topic Working Group Updates: Eventlet Removal | 15:10 |
JayF | #link https://etherpad.opendev.org/p/ironic-eventlet-removal | 15:10 |
JayF | significant progress; we have a PoC Cheroot-as-wsgi patch up; I already reviewed it with some minor structural issues, but it's passing CI reliably | 15:11 |
TheJulia | JayF: even the numbers on a single node will give insight, json-rpc is more convenience. The API surface measurements are all about read performance from the request handling pipeline | 15:11 |
JayF | The thing that's weird to me is... when to do that test? | 15:12 |
JayF | we're still monkey patching eventlet | 15:12 |
JayF | so it's still using green threads | 15:12 |
TheJulia | Indeed | 15:12 |
JayF | there shouldn't be that much change, even if I guess there's value in validating that | 15:12 |
TheJulia | We should sporadically do it along the process, so this is structural change, we really should and again once we remove eventlet completely | 15:13 |
clif | o/ I'm online and generally available for the foreseeable future | 15:13 |
TheJulia | Greetings clif | 15:13 |
JayF | TheJulia: please leave that comment re: benchmarking on cid's change | 15:13 |
JayF | Anything else worth mentioning in eventlet removal? | 15:13 |
TheJulia | JayF: I'm looking at it from we build some building blocks to do it, a sanity check wouldn't be a bad idea | 15:13 |
TheJulia | every major step will really be a performance impacting change, either negative or positive, best for us as a project to at least have an understanding as we go | 15:14 |
TheJulia | I have no other complaints | 15:14 |
TheJulia | :) | 15:14 |
JayF | Our existing benchmark scripts all route via DBAPI code, right? | 15:15 |
JayF | do we have anything to do that in the tree already | 15:15 |
JayF | or are we talking something as simple as: populate a devstack with X nodes, Y ports, run some API queries with a timer; siwtch to new code, run some API queries with a timer? | 15:15 |
TheJulia | oh... shoot | 15:17 |
TheJulia | yeah, its all geared around request handling | 15:17 |
JayF | that should be simple enough to do some basic smoke testing | 15:17 |
JayF | cid: lets pair on that testing; I have a devstack locally which I can ensure no noisy neighbors on | 15:17 |
TheJulia | in the pipeline, so it doesn't exercise the top level of the API surface | 15:17 |
TheJulia | i.e. the wrapper | 15:18 |
JayF | yeah, so we should do more like what I said then | 15:18 |
JayF | to get a real end-to-end | 15:18 |
TheJulia | Anyway, a quick and dirty script + time counts would do the needful as well | 15:18 |
cid | JayF, count me in. | 15:18 |
JayF | Anything else on eventlet removal? | 15:18 |
TheJulia | not from me | 15:19 |
JayF | There are no Discussion Topics listed for today. I am skipping this topic. | 15:19 |
JayF | #topic Bug Deputy Updates | 15:19 |
JayF | cid was the bug deputy | 15:19 |
JayF | #note There was 1 RFE and a total of 4 newly filed bugs between the 2nd to the 9th June, 2025, plus 4 older but untriaged ones. | 15:19 |
JayF | The full list is in the agenda here https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_June_9.2C_2025 | 15:20 |
JayF | cid: is there any you'd like to call specific attention to? | 15:20 |
cid | Yeah. | 15:20 |
* cid goes to grab a link | 15:20 | |
cid | This will be the easiest, sounds more like a quesiton than a bug (?) https://bugs.launchpad.net/virtualbmc/+bug/2112627 - Why is VIRTUALBMC_CONFIG only set to virtualbmc.conf but not to the .vbmc directory? | 15:21 |
JayF | That's an extremely weird launchpad account that created that bug. I don't know the answer off the top of my head, and realistically, vbmc is an internal ironic tool | 15:22 |
JayF | I'm slightly tempted to suggest the answer is "because we didn't need it" | 15:22 |
JayF | either way, folks can look at that if they like, I'm not going to have time to | 15:24 |
JayF | Anything else around bugs cid ? | 15:24 |
cid | Two more things. A cursory view on the RFE and I need help triaging this. https://bugs.launchpad.net/sushy-tools/+bug/2112496 | 15:24 |
JayF | I can tell you that bug is good by the reporter :D | 15:25 |
JayF | Harold probably knows more about sushy-tools than both of us combined | 15:25 |
* JayF triages it as medium | 15:25 | |
cid | :D, ++ | 15:26 |
JayF | And the last thing? | 15:26 |
cid | Nothing else. | 15:27 |
JayF | Good stuff, thanks CID | 15:27 |
JayF | Who will be the bug deputy next week? | 15:27 |
cid | \o/. | 15:27 |
cardoe | can I be the patch flogger? :D | 15:27 |
JayF | did cardoe just volunteer to be a bug deputy? :) | 15:28 |
cardoe | not bugs but patches | 15:28 |
JayF | that's the only role up for volunteering, and I stop reading after "can I be" ;) | 15:28 |
cid | I can be the bug deputy. | 15:28 |
JayF | #note CID to go another week as bug deputy. | 15:29 |
JayF | No RFEs for review outside of the one that was already acknowledged to need a spec. | 15:29 |
JayF | #topic Open Discussion | 15:29 |
JayF | One thing from me: because I'm bad at math, my statement last week was off by one. This is my *next to last* Ironic meeting before being gone until August. clif and cid will be here on the GR-OSS side if you need anything from us specifically. | 15:30 |
clif | sorry I piped up in the middle of the meeting before open discussion, should've paid more attention to scrollback | 15:31 |
JayF | not a big deal, meetings are super informal | 15:31 |
JayF | clif is going to be working on dynamic networking, so please be extra kind to him since it's TBD if the code will be :D | 15:31 |
JayF | Anything else for open discussion? | 15:32 |
JayF | Alright, I'm going to call it. Thank you everyone o/ | 15:34 |
JayF | #endmeeting | 15:34 |
opendevmeet | Meeting ended Mon Jun 9 15:34:49 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:34 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-06-09-15.01.html | 15:34 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-06-09-15.01.txt | 15:34 |
opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-06-09-15.01.log.html | 15:34 |
opendevreview | Stephen Finucane proposed openstack/ironic master: conf: Add '[api] response_validation' option https://review.opendev.org/c/openstack/ironic/+/945515 | 15:39 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for allocations API (versioning) https://review.opendev.org/c/openstack/ironic/+/945217 | 15:39 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for allocations API (requests) https://review.opendev.org/c/openstack/ironic/+/945218 | 15:39 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for allocations API (responses) https://review.opendev.org/c/openstack/ironic/+/928921 | 15:39 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for bios API (versioning) https://review.opendev.org/c/openstack/ironic/+/952147 | 15:39 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for bios API (requests) https://review.opendev.org/c/openstack/ironic/+/952148 | 15:39 |
opendevreview | Stephen Finucane proposed openstack/ironic master: api: Add schema for bios API (responses) https://review.opendev.org/c/openstack/ironic/+/952149 | 15:39 |
TheJulia | cardoe: you must be careful with patch floggers. I highly recommend being mindful of the differences between "ceasing" and "continuing" when compared to "morale improving" ;) | 15:40 |
* JayF won't give up his patch-flogging secrets to cardoe | 15:42 | |
* TheJulia now feels the need to commission a conversation piece... | 15:43 | |
cardoe | So not flogging of people. Not what I meant. But more want to make sure patches are moving. | 16:54 |
cardoe | CID and I can only +1 bifrost stuff but I’ve reviewed what’s in the queue for that. | 16:54 |
TheJulia | only +1 because you can't +2? | 18:24 |
TheJulia | or, just uncertinty? | 18:25 |
cid | Yeah. We only have +1 review vote on the Bifrost project. | 18:33 |
TheJulia | ... try logging out and logging back in and see if it is there | 19:00 |
opendevreview | Abhishek Bongale proposed openstack/ironic-tempest-plugin master: Add Tempest tests for inspection rules in Ironic https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/951761 | 19:07 |
opendevreview | Jay Faulkner proposed openstack/ironic-specs master: Trait based port selection and dynamic portgroups https://review.opendev.org/c/openstack/ironic-specs/+/945642 | 19:28 |
JayF | TheJulia: I'm still perplexed about that one section in the spec. If you have availability this week that crosses over with CST; it'd be nice to have a quick chat you+me+clif to figure it out. Trying to get the spec in a mergable place. | 19:57 |
TheJulia | I'm in the middle of sprint retro and planning... and I think Grue's minions are appearing | 20:04 |
JayF | not today is better anyway | 20:04 |
TheJulia | so... tomorrow | 20:04 |
TheJulia | yeah | 20:04 |
JayF | probably later this week once clif is more read into the spec | 20:04 |
TheJulia | ++ | 20:04 |
cardoe | TheJulia: I would appreciate your feedback on https://review.opendev.org/c/openstack/neutron-specs/+/952166 | 20:27 |
cardoe | I know it's Neutron but that's what I've described a bunch to ya | 20:27 |
cardoe | I also proposed https://review.opendev.org/c/openstack/openstacksdk/+/952158 for ironic's usage. | 20:28 |
cardoe | I had previously commented on... https://opendev.org/openstack/ironic/src/commit/62bf4d76d32c2b7ae02767aefe6d032e1ed4d0e9/ironic/common/neutron.py#L1059 saying it was wrong | 20:29 |
cardoe | Cause we're looking up the subnet always and we're requiring L3 IPs for binding to work when you can have L2 only (and in fact NGS was recently patched to say it supports L2 only). | 20:30 |
opendevreview | Doug Goldstein proposed openstack/ironic master: fix port vif attach with networks with dynamic segments https://review.opendev.org/c/openstack/ironic/+/952168 | 21:04 |
opendevreview | Doug Goldstein proposed openstack/ironic master: fix port vif attach with networks with dynamic segments https://review.opendev.org/c/openstack/ironic/+/952168 | 21:10 |
TheJulia | cardoe: unit tests? | 21:23 |
cardoe | for the dynamic segment? Will do | 21:24 |
cardoe | Haven't labeled it with ironic-week-prio yet cause I didn't wanna bug folks with that until I got that part done but wanted to push my code. | 21:24 |
TheJulia | ack ack | 21:25 |
cardoe | Essentially the Cisco ACI, Arista, and Junpier drivers when implementing VNIs to VLAN all use dynamic segments. So my neutron-spec follows that pattern. And in testing things just something I noticed was dynamic segments are getting missed in that spot. | 21:32 |
cardoe | I wanna make a failing test first and then have my change fix it. If that’s fair. | 21:58 |
opendevreview | Doug Goldstein proposed openstack/ironic master: fix port vif attach with networks with dynamic segments https://review.opendev.org/c/openstack/ironic/+/952168 | 23:37 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!