iurygregory | Ironic already registered for the PTG in Oct =) | 01:01 |
---|---|---|
rpittau | good morning ironic! o/ | 07:18 |
queensly[m] | Good morning | 08:05 |
abongale | Good morning! | 08:40 |
opendevreview | Riccardo Pittau proposed openstack/bifrost master: Fix python interpreter when installing in venv https://review.opendev.org/c/openstack/bifrost/+/949518 | 09:15 |
iurygregory | welcome back rpittau o/ | 11:04 |
rpittau | thanks iurygregory :) | 11:04 |
opendevreview | Verification of a change to openstack/networking-generic-switch master failed: Store driver objects in a global dict https://review.opendev.org/c/openstack/networking-generic-switch/+/949830 | 12:06 |
opendevreview | Verification of a change to openstack/networking-generic-switch master failed: Move _is_port_supported, _is_port_bound to utils https://review.opendev.org/c/openstack/networking-generic-switch/+/949831 | 12:06 |
opendevreview | Verification of a change to openstack/networking-generic-switch master failed: Improve test coverage of NetmikoSwitch commands https://review.opendev.org/c/openstack/networking-generic-switch/+/949832 | 12:06 |
opendevreview | Verification of a change to openstack/networking-generic-switch master failed: Clean up add_subports_on_trunk, del_subports_on_trunk https://review.opendev.org/c/openstack/networking-generic-switch/+/949833 | 12:06 |
TheJulia | good morning | 12:25 |
dtantsur | morning TheJulia | 12:25 |
opendevreview | Abhishek Bongale proposed openstack/ironic master: fix: 'built_in' KeyError on invalid priority. https://review.opendev.org/c/openstack/ironic/+/952238 | 12:30 |
opendevreview | Takashi Kajinami proposed openstack/networking-baremetal master: Drop explicit dependency on python-subunit https://review.opendev.org/c/openstack/networking-baremetal/+/952242 | 12:36 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: Fix IPE Health Metrics https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/952249 | 13:09 |
cardoe | I don't understand how all those NGS tests failed. | 13:28 |
opendevreview | Merged openstack/networking-baremetal master: Drop explicit dependency on python-subunit https://review.opendev.org/c/openstack/networking-baremetal/+/952242 | 13:29 |
TheJulia | cardoe: one failed and it cascaded since they are all stacked | 13:32 |
cardoe | yeah the store driver objects but I just don't see the failure | 13:32 |
cardoe | lots of deprecated warnings | 13:32 |
TheJulia | that is ultimately another swift tempurl failure | 13:38 |
TheJulia | I've started to see this issue sporatically where Swift basically returns a 401 but I've not figured out why. Swift doesn't log anything | 13:39 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: Fix IPE Health Metrics https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/952249 | 13:40 |
dtantsur | iurygregory: wtf ^^^ does it mean that the machines are, once again, creatively redfish compatible? :) | 13:57 |
dtantsur | or is it something in Ironic? | 13:57 |
dtantsur | iurygregory: you may want to consider fixing it in Ironic either way. IPE may not be the only consumer of these values. | 13:58 |
iurygregory | dtantsur, I though it was something on IPE side not Ironic <eyes> | 14:05 |
iurygregory | but I will check things (the code on ipe was 6yrs old) so maybe things changed a lot and we didn't notice | 14:05 |
opendevreview | Abhishek Bongale proposed openstack/ironic master: fix: 'built_in' KeyError on invalid priority. https://review.opendev.org/c/openstack/ironic/+/952238 | 14:38 |
opendevreview | Abhishek Bongale proposed openstack/ironic master: fix: 'built_in' KeyError on invalid priority. https://review.opendev.org/c/openstack/ironic/+/952238 | 16:37 |
cardoe | cid: I got your openstacksdk stuff going so we can rebase the other improvements | 17:29 |
cardoe | https://review.opendev.org/c/openstack/openstacksdk/+/948552 | 17:29 |
cardoe | well stephenfin fixed the issue I just stared at it. | 17:29 |
cardoe | https://review.opendev.org/c/openstack/openstacksdk/+/945700 needs a rebase | 17:30 |
opendevreview | Merged openstack/networking-generic-switch master: Store driver objects in a global dict https://review.opendev.org/c/openstack/networking-generic-switch/+/949830 | 18:03 |
cardoe | if anyone wants an easy backport approval... https://review.opendev.org/c/openstack/ironic/+/951717 the others have passed | 18:11 |
JayF | +A | 18:15 |
opendevreview | Julia Kreger proposed openstack/ironic master: follow-up: post-review feedback fixes for network data fixes https://review.opendev.org/c/openstack/ironic/+/952296 | 18:22 |
TheJulia | cardoe: I *think* that should address and leave the door open for users which try to use id as an interface name. | 18:23 |
cid | cardoe, tks \o | 18:35 |
opendevreview | Verification of a change to openstack/ironic stable/2024.1 failed: Control port updates with update_pxe_enabled flag https://review.opendev.org/c/openstack/ironic/+/951717 | 19:38 |
clif | is there an easy to way to re-run only tests that failed with tox? | 20:12 |
JayF | tox -e$env -- path.to.unit.tests.module | 20:15 |
JayF | I find it's often not great to run *specific tests* this way, and instead I do the whole module | 20:15 |
opendevreview | Clif Houck proposed openstack/ironic master: Report provisioned state where appropiate when raising InvalidState* Exceptions https://review.opendev.org/c/openstack/ironic/+/952300 | 20:27 |
clif | just a small change to get my feet wet again | 20:28 |
clif | trying to refamiliarize myself with the codebase | 20:28 |
clif | is the merge conflicts at all useful in gerrit? it seems like its reporting a bunch of out of date changes | 20:31 |
JayF | hmm | 20:35 |
JayF | I don't see any merge conflicts in there? | 20:35 |
JayF | it looks like a fine change | 20:36 |
TheJulia | Merge conflicts are "this will conflict with" these changes, which makes sense in a google-esq use of gerrit, but long history OSS projects are bound to have still open changes which are themselves merge conflicted that it will report on | 20:50 |
TheJulia | My old kexec one comes to mind because I touched some utility files so it conflicts with like everything | 20:50 |
* TheJulia reaches EOD and wonders where the brain went | 20:51 | |
JayF | oh, the list of merge conflicting changes | 20:51 |
JayF | I see | 20:51 |
JayF | have a good one o/ | 20:51 |
opendevreview | Jay Faulkner proposed openstack/ironic master: Automated cleaning by runbook https://review.opendev.org/c/openstack/ironic/+/945259 | 21:45 |
opendevreview | Verification of a change to openstack/ironic stable/2024.1 failed: Control port updates with update_pxe_enabled flag https://review.opendev.org/c/openstack/ironic/+/951717 | 22:13 |
JayF | the only thing I ever use "merge conflicts" list for is: 1) ensuring I'm not making someone rebase a giant patch close to landing by landing like, a one-line fix or 2) seeing other, similar changes in the repo... | 22:13 |
JayF | there's more than once that I went to do some kinda fix, didn't check for prior art, wrote it, upload it.... merge conflicts with the one already written | 22:14 |
opendevreview | Merged openstack/ironic-prometheus-exporter master: Replace pkg_resources https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/951483 | 23:29 |
opendevreview | Merged openstack/ironic stable/2024.1: Control port updates with update_pxe_enabled flag https://review.opendev.org/c/openstack/ironic/+/951717 | 23:38 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!