Monday, 2025-07-21

opendevreviewClif Houck proposed openstack/ironic master: Add a new 'class' field to the Port object  https://review.opendev.org/c/openstack/ironic/+/95544701:16
opendevreviewClif Houck proposed openstack/ironic master: Add a new 'class' field to the Port object  https://review.opendev.org/c/openstack/ironic/+/95544701:49
rpittaugood morning ironic! o/06:13
queensly[m]Good morning.06:33
FreemanBoss[m]Good morning o/08:06
opendevreviewRiccardo Pittau proposed openstack/ironic-python-agent-builder master: Build ironic-python-agent DIB image with CentOS Stream 10  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/95096508:08
iurygregorygood morning ironic10:58
opendevreviewRiccardo Pittau proposed openstack/ironic-python-agent-builder master: Build ironic-python-agent DIB image with CentOS Stream 10  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/95096511:27
opendevreviewJacob Anders proposed openstack/ironic master: [WIP] Skip initial reboot to IPA when updating firmware out-of-band  https://review.opendev.org/c/openstack/ironic/+/95431111:28
opendevreviewDmitry Tantsur proposed openstack/ironic-python-agent master: Fix wrong result of filter_device in the base interface  https://review.opendev.org/c/openstack/ironic-python-agent/+/95546511:51
dtantsurmy bad folks, this needs urgent reviews ^^^11:52
dtantsurfrickler: this is your problem too ^^^11:52
opendevreviewcid proposed openstack/ironic-python-agent master: doc: How hardware managers ignore certain devices  https://review.opendev.org/c/openstack/ironic-python-agent/+/95546912:20
cidoh, dtantsur, :facepalm: ^^12:21
cidSo, I missed that subtle gap, but I think the doc update is still valid, kindly take a look when you some free cycle.12:28
guilhermesphey team! mornings! Im trying to use https://docs.openstack.org/ironic/latest/admin/cleaning.html#configuring-automated-cleaning-with-runbooks but as it is stating in the docs, we are just going to be able to use them with automated clean in flamingo? I can use it for manual cleaning in 2024.2 cc cid :P 12:32
cidguilhermesp. \o, good morning.12:34
cidIndeed, you should be able to use it for manual cleaning in the Flamingo release12:36
guilhermespmorning cid ! Automated you mean? coz i did test it with manual cleaning in 2024.2 these last days 12:38
guilhermespand if runbooks + automated clean is tested in the current main ( since i can see options in the docs to use it ) -- im willing to go for main now lol 12:41
guilhermespbecasue that fits my use case here perfectly 12:41
guilhermespwhich is running all of these clean steps on every commission/decommission of a node:12:42
guilhermesphttps://www.irccloud.com/pastebin/seKNblrP/12:42
guilhermespi could not figure how to add apply_configuration on the clean steps priority 12:42
cidSo, automated cleaning works for both automated and manual cleaning. Basically, it's runbook in an automated fashion. 12:43
cidAnd runbook works for both use cases already.12:44
guilhermesphuuuum i see... i tried to do this:12:45
guilhermesphttps://www.irccloud.com/pastebin/NDfuMM6k/12:46
guilhermespand just added the trait to the node but its just bypassing it 12:46
guilhermespthats on 2024.2 yeah12:46
cidOk, let's try to walk through it. First, this is a good place to start, https://docs.openstack.org/ironic/2025.1/admin/runbooks.html on the creation of a runbook. Any gaps you identify will make a good LP.12:47
cidBy 'bypassing' do you mean cleaning doesn't start?12:48
guilhermespyup, runbook its there in my env and works perfectly when I do: openstack baremetal node clean --runbook CUSTOM_BASELINE_BIOS 57139cfd-d347-4c71-b9d1-4ad64a5adc4f 12:49
guilhermespbut12:49
guilhermespif i move a node from manage to provide... i just see erease_express taking place which kinda of tell me that its just doing the default steps for automated clean I guess12:49
cidYup. That looks like one of the runbook's steps(?)12:51
guilhermespyeah, but why does it run all when I do it manually and just that one when doing automated? that's what was kinda of confused thinking that somehow it was like...just "bypassing it" 12:51
cidOh, so only one step (that one step, or just any one step) get's executed with automated cleaning with runbook12:54
guilhermespjust erase_devices_express12:54
guilhermespat least on the 4 tests i did 12:55
cidOk, got it. 12:55
guilhermespmoving the node from manage -> provide 12:55
guilhermespand then when i read this https://docs.openstack.org/ironic/latest/admin/cleaning.html#configuring-automated-cleaning-with-runbooks12:55
guilhermespi was like "well, i think im gonna get this just on flamingo " lol 12:55
cidWell, you're technically using flamingo only in dev mode :P.12:58
cidI will take a look at the code and see if anything is out of the ordinary. If anything also jumps out to you based on teh logs, that could help, maybe logs.12:59
cidTesting is the best way to confirm what's going going, maybe some filtering.12:59
cid... is happneing somewhere13:00
guilhermespheheheh yeah i can enable debug and get outputs when doing automated13:00
guilhermespi was just wondering if that was tested in the current main so I could bump images here on my end and see if with the current main things might work 13:01
cidI was under the impression you were already using the main branch. If that's not the case, then use the feature will only be available in the main branch and/or flamingo release.13:08
cidSo there's automated cleaning which already works, and there's manual cleaning. As of 2024.2 you can do both of those with a runbook. And in Flamingo you can automate both under the new 'automated cleaning with runbook' feature.13:08
guilhermespyeah sorry for the confusion. Im actually using 2024.2 but open to use main just to test13:10
guilhermespwhat im doing here to contribute is enabling debug and pasting my configs + node definition. I can get those shortly 13:11
cidOk great. 13:12
cidYeah. So, only runbook is available in your current 2024.2.13:14
cid Automated cleaning with runbook is not until Flamingo.13:14
cid  And yes, so far so good, these have been tested.13:14
guilhermespah ok then, so my tests here with 2024.2 wont probably do good. but yeah if those has been tested on the current main, I guess I would try bumping my ironic to main and see how it goes 13:21
fricklerdtantsur: thx, I had just gotten to the point that I could confirm that reverting https://review.opendev.org/c/openstack/ironic-python-agent/+/954024 does resolve my issue. I can test with your fix tomorrow13:26
cidguilhermesp, ++13:30
opendevreviewcid proposed openstack/ironic-python-agent master: doc: How hardware managers ignore certain devices  https://review.opendev.org/c/openstack/ironic-python-agent/+/95546913:44
opendevreviewcid proposed openstack/ironic-python-agent master: doc: How hardware managers ignore certain devices  https://review.opendev.org/c/openstack/ironic-python-agent/+/95546913:47
TheJuliagood morning13:49
dtantsurmorning TheJulia13:58
cardoemorning Ironic14:25
cardoegive someone a high five if they review and +W https://review.opendev.org/c/openstack/ironic/+/953414 cause I'm trying to rebase a patch on top and Depends-On isn't working14:26
dtantsurdone14:34
opendevreviewTakashi Kajinami proposed openstack/ironic master: Remove rootwrap  https://review.opendev.org/c/openstack/ironic/+/95340414:34
opendevreviewTakashi Kajinami proposed openstack/ironic master: Use specific util methods in vfat image creation  https://review.opendev.org/c/openstack/ironic/+/95341714:34
opendevreviewNahian Pathan proposed openstack/ironic master: Reduce API calls when collecting sensor data with redfish  https://review.opendev.org/c/openstack/ironic/+/95548414:35
opendevreviewTakashi Kajinami proposed openstack/ironic master: Remove rootwrap  https://review.opendev.org/c/openstack/ironic/+/95340414:38
opendevreviewTakashi Kajinami proposed openstack/ironic master: Use specific util methods in vfat image creation  https://review.opendev.org/c/openstack/ironic/+/95341714:38
opendevreviewMerged openstack/ironic-python-agent master: Fix wrong result of filter_device in the base interface  https://review.opendev.org/c/openstack/ironic-python-agent/+/95546514:39
opendevreviewNahian Pathan proposed openstack/ironic master: Reduce API calls when collecting sensor data with redfish  https://review.opendev.org/c/openstack/ironic/+/95548414:42
opendevreviewcid proposed openstack/ironic master: Clear `last_error` on power match/sync  https://review.opendev.org/c/openstack/ironic/+/95543214:43
opendevreviewNahian Pathan proposed openstack/ironic master: Reduce API calls when collecting sensor data with redfish  https://review.opendev.org/c/openstack/ironic/+/95548414:44
cardoeThank you :)14:49
TheJuliacid: a unit test or three on that last_error change please :)14:55
opendevreviewMerged openstack/sushy master: Optimize unit testing  https://review.opendev.org/c/openstack/sushy/+/95469114:57
cidTheJulia. Alright, let me try add some :). tks14:58
TheJuliathanks!14:58
TheJulia#startmeeting ironic15:01
opendevmeetMeeting started Mon Jul 21 15:01:47 2025 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.15:01
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:01
opendevmeetThe meeting name has been set to 'ironic'15:01
TheJuliao/15:01
rpittau#startmeeting ironic gaaaaa15:01
opendevmeetrpittau: Error: Can't start another meeting, one is in progress.  Use #endmeeting first.15:01
alegacyo/15:01
rpittauo/15:01
dtantsuro/15:02
masgharo/15:02
TheJulia#chair rpittau 15:02
opendevmeetCurrent chairs: TheJulia rpittau15:02
rpittauthanks :D15:02
* TheJulia lets rpittau chair ;)15:02
iurygregoryo/15:02
rpittauHello everyone!15:02
rpittauWelcome to our weekly meeting!15:02
cido/15:02
clifo/15:02
rpittauThe meeting agenda can be found here:15:02
rpittauhttps://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_July_21.2C_202515:02
queensly[m]o/15:02
rpittaulots of people today, good good :)15:03
rpittau#topic Announcements/Reminders15:03
rpittauStanding reminder to review patches tagged ironic-week-prio and to hashtag any patches ready for review with ironic-week-prio:15:03
rpittau#link https://tinyurl.com/ironic-weekly-prio-dash15:03
rpittauquite some patches with +2 missing +W15:03
rpittauthere's also an intruder patch from neutron :D15:04
TheJuliaI commented on the intruder ;)15:04
rpittauthanks!15:04
TheJuliaspecifically to encourage it15:04
rpittauI guess we'll most of the patches there merging soon15:05
rpittauforgot a "see" there15:05
rpittauanyhow!15:06
rpittau2025.2 Flamingo Release Schedule15:06
rpittau#link  https://releases.openstack.org/flamingo/schedule.html15:06
rpittauwe're in the second half of the dev cycle15:06
rpittauat R-1015:06
rpittaujust 10 weeks to go15:06
rpittauI'm going to propose bugfix branches this week15:07
rpittauanything else to announce/remind ?15:07
TheJuliaOkay, that will likely be the last bugfix/branch with eventlet if we're able to move futurist changes along15:07
rpittauoh yeah15:07
rpittauright15:07
rpittaugreat!15:07
rpittau(had so many issues downstream with eventlet)15:08
TheJuliawe can talk about eventlet when we get there15:08
rpittauyeah15:08
rpittaumoving on!15:08
rpittau#topic Working Group Updates15:08
rpittauany update from standalone networking?15:08
alegacyyep, making good progress here.  a few things I want to raise here today.15:09
alegacyFirst, I've got things roughed in from the API down to the switch.  Wondering if there's any interest in a short demo to validate the approach before I start cleaning things up and submitting patches15:09
TheJuliaa quick demo would be awesome15:10
TheJuliabut at your convenience obviously15:10
cardoeI had a question about some of the specs that seem to be tied in.15:10
alegacyk, i'll follow-up on this outside of meeting to find a suitable time.15:10
cardoeWe've got specs for port binding that reference the standalone work.15:10
cardoeBut there's almost two competing ones.15:11
cardoeThere's adding of a "vendor" field but no clarity on how that will be used or defined.15:11
TheJuliaI wouldn't describe them as competing15:11
TheJuliaIts entirely differnet problem spaces and use patterns15:11
opendevreviewMerged openstack/ironic-python-agent master: doc: How hardware managers ignore certain devices  https://review.opendev.org/c/openstack/ironic-python-agent/+/95546915:11
alegacyya, i didn't think there would be any overlap there15:11
TheJuliaFor example, one pattern is nova integrated, another is "operator knows what they want"15:11
TheJuliaanother is "operator is asking for baremetal and asking nova to bind ports and is explicitly using tags because they know all the secrets in between because they the operator is the user, not an end user"15:12
TheJuliaAnd yes, that is all very confusing and not obvious15:12
* TheJulia would be happy to go rev specs with clarifying text, fwiw15:13
cardoeSo along the lines of the demo. Just wanted to get more definition on use case and also consideration of failure case.15:13
alegacyuse case for the demo specifically... or use cases for this feature in general?15:13
cardoeBut maybe I'm speaking to the wrong section. 15:13
cardoeNot for the demo specifically.15:15
cardoeI derailed the convo. Not my intention back to being quiet.15:15
rpittauno worries :)15:15
alegacy:)15:15
rpittaushould we move on?15:15
alegacya couple more things from me...15:15
rpittaualegacy: please :)15:15
TheJuliaheh, cardoe your pointing out an easy to confuse area, I'll sync up with you after the meeting15:16
alegacyI've been using bifrost to do some testing.15:16
alegacybut it doesn't have any support for virtual switches that can be controlled by ngs.15:16
alegacyhas there been any discussions in the past to add OVS into the bifrost testenv mix?15:16
alegacyis that a good/bad idea to propose?15:17
TheJuliaIt seems possible, we have some of the base structure in the ironic devstack plugin. Honestly there is no real reason not to aside from just its a bit more complexity. I think when I last approached adding neutron support in bifrost I ended up with a bunch of playbooks some of which did similar things but I also ended up building a lab locally with hardware15:18
alegacyok, maybe we can discuss this a bit more outside of this meeting.  likely need a plan to CI this feature... 15:19
alegacyI'll take a look at what it would take.15:19
TheJuliait would make the most sense to do such for CI, specifically15:19
alegacyok15:20
alegacy1 more topic from me.15:20
alegacyLooking at the node transitions and the calls to add_*_network... it looks like there are states that either don't expect any network access or assume that the switch is already setup.15:20
alegacyFor instance, when the node is available it doesn't look like there are any calls to setup any network stuff.15:21
TheJuliaCorrect15:21
TheJuliait is considered detached15:21
alegacyam I reading that right?  Is network access not required/expected in that (and other) state(s).15:21
alegacyah15:21
alegacyalso, when it is first enrolled... same?  no net access required/expected?15:22
TheJuliacorrect, we don't want to leave the node attached needlessly in case it gets powered on or someone also sets up a DHCP+PXE server in a specific network (outside of our control) and tries or manages to make use of the machines15:22
TheJuliayeah, no networking generally expected.15:22
alegacyok, that explains what I have been seeing.  Thought maybe there were some missing hooks somewhere.15:23
alegacythanks15:23
TheJuliadtantsur: you might have thoughts here given.... I'm drawing a blank on what the protocol is in the bmc layer to share an ethernet port with the bmc15:23
TheJuliadtantsur: I blanked it from my mind in horror....15:23
* dtantsur reads scrollback15:23
alegacythat's it from me for standalone networking15:24
rpittauack, thanks alegacy 15:24
dtantsurattachment in available depends on fast track15:24
dtantsurbut this should be handled by Ironic already15:24
alegacyk, i'll double check and follow-up with you offline15:24
cardoeYou need some kind of "safe" state.15:25
rpittauanythign else for the standalone networking ?15:25
jrosserTheJulia: nc-si ?15:25
TheJuliajrosser: that!15:25
* TheJulia hides in terror15:25
rpittaulol15:25
cardoeBut the question for "safe" state is do you want it configured so that LLDP works so that inspection works to find the linkage?15:25
alegacyinspecting doesn't apply a network config15:26
dtantsurjrosser: oh noes15:26
alegacysorry, does15:26
TheJuliacardoe: inspection is an entirely separate state in the state machine, and also doesn't really apply networking config15:26
alegacyit does apply network config15:26
dtantsuryeah, there is inspection_network and all the business15:26
TheJuliaYeah, exactly15:27
TheJuliaSo onward to eventlet removal?15:27
rpittauyep15:27
TheJuliaSo, regarding eventlet removal, we're super close, but also have a little bit of a ways. We're in the phase of finding the things out we didn't know or expect, and overall we seem to be heading in a good direction. dtantsur has been awesome and driving forward a change in futurist which we'll end up using. The profile will be a little different but I don't think we're going to have to do much more aside put some warnings 15:28
TheJuliaabout increased memory usage15:28
* dtantsur nods15:28
TheJuliaand by usage, I mean more around allocations. I fully expect we might find some things we never expected either, but one step at a time.15:28
TheJulia(not the allocations feature, but thread launch reserved stack size, which I'm thinking of setting to the smallest available value)15:29
TheJuliaAny questions regarding eventlet removal?15:30
rpittaulooks like we're good15:31
rpittau#topic Discussions topics15:32
rpittauwe have 2 topics today15:32
rpittaufirst one from queensly[m] :)15:32
queensly[m]Hi everyone, I’m 8 weeks into the  Outreachy internship and would like to give an update on my project. I’m working on setting a bare metal host's clock remotely using Redfish.... (full message at <https://matrix.org/oftc/media/v1/media/download/Adi0_wK6ZUl3pIczSde2O0zEYgSL0rwg6DoU5WekkLulsOjibVB4GC349Js5zzCHpLBD9jl8oFfTS2fQQOWqHIZCeYdbcJbgAG1hdHJpeC5vcmcvcUhjSlpJekpDaVFIbVpIUGxKd05qY1Jy>)15:33
TheJuliaqueensly[m]: cool, how can we be of assistance?15:34
queensly[m]So far, I have done the following:... (full message at <https://matrix.org/oftc/media/v1/media/download/AWJV0NBsoIoK-tlCz01-HwjVZCVDAfWfgBH2GdpoKl0eOj5AalTRt1-SmWwwyhEvOVXYvfCkI12L6XC1DkmzZ9BCeYdbhtrQAG1hdHJpeC5vcmcvTFloUk5MT1VpSUxkV2xqU01sbmxxWlNM>)15:34
* cid I just blinked and we moved on already D. I was just about to ask, the checkpointed task approach, that's till on the table(?). I'm getting around a PoC this week. TheJulia, dtantsur. I'm effectively playing catching currently with all things eventlet as a result of doing non-eventlet removal things the past week.15:35
queensly[m]TheJulia thanks. I need reviews on my current patches. I think that would help me know what to add or remove. 15:36
dtantsurcid: I'm not sure what you're referring to (re checkpointed tasks)15:37
cidYou're doing great, queensly[m], o/15:37
TheJuliacid: I think it is something we might want to look at and consider, but I don't think that is something we need to do right now(). It does solve a lot of things later on and with some more complex flows thought15:37
dtantsurahh, remembered15:37
queensly[m]cid: Thank you15:38
dtantsurI agree with Julia, we need this, but it's not a blocker priority15:38
opendevreviewMerged openstack/ironic-tempest-plugin master: Add Tempest API tests for inspection rules  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/95176115:38
TheJuliaqueensly[m]: Yes, your doing great. I'll try to look at your ironic change later today15:38
cidOh, good thing I asked.15:38
queensly[m]Alright thank you.15:39
TheJuliacid: great you asked, but yeah, ironic works surprisingly well at the core, and oddly even better in some ways, but the big issue we've spotted is the power state sync15:39
TheJuliaAnd... it is distinctly possible we'll find *more* issues as time moves on15:39
rpittauthanks queensly[m] for your contributions :)15:39
TheJuliabut they might not be "in the next 2 months" sort of efforts15:39
TheJuliabut they might be  "oh wow, this is bad, we need to backport this thing which feels like a feature but it fixes a bug"15:40
queensly[m]rpittau: thanks :)15:40
cidTheJulia, that 'll already be a heavy lift, :)15:40
TheJuliaIndeed, but we're definitely heading into a better place overall by removing eventlet.15:41
rpittau I agree! :D15:41
queensly[m]I have the following ongoing:... (full message at <https://matrix.org/oftc/media/v1/media/download/Adh3F3hIIZ2UUE3bxIOlu2cpI4-PMPyZsf6BaqsG_dcJKYZ4D515tjJxM-aCUwE-LC44ND3epGxyAfymzIXxhaxCeYdb7TcAAG1hdHJpeC5vcmcvQ3lBVXZuQ21QSFFNcVNYWnpPcWFFekt2>)15:41
dtantsurmeanwhile, I've added https://review.opendev.org/c/openstack/futurist/+/955217 to our list, and more eyes are welcome15:41
cidKudos, TheJulia, dtantsur, just ping me if you think there's anywhere I could help out with. 15:42
cardoespeeaking of bifrost... what do we want to do with https://review.opendev.org/c/openstack/bifrost/+/946724 ? it's sitting in the weekly queue for a bit.15:42
TheJuliadtantsur: I'll spin it up after the meeting15:42
rpittaushoud lwe move on?15:43
queensly[m]I would like to thank my mentors rpittau and masghar for their support so far and also to the community. I'm happy to answer any questions or suggestions you may have.15:43
rpittau:)15:43
queensly[m]rpittau: Yeah, I'm done with my update.15:43
rpittauthanks!15:43
cidtks15:43
masgharthanks for your contributions queensly :)15:44
queensly[m]You're welcome :)15:44
rpittaunext topic is from me, it's just yet another headsup that we're going to remove support for python 3.9 soon15:45
rpittauideally after the next bugfix branches are cut15:45
rpittauwhat's missing now is just moving cs9 jobs in bifrost to non-voting15:45
TheJuliaAre we pinning the CS10 usage to specific providers?15:45
rpittaurelated to that, the ipa-builder patch to build ipa ramdisk with CS10 is now ok with CI, the jobs are pinned to el10 hardware compatible nodes https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/95096515:45
TheJuliacool cool15:46
rpittaua reminder that we're using python 3.12 in the current CS9 ipa ramdisks15:47
rpittauso migrating to CS10 is not super urgent15:48
rpittauI think that's all15:48
rpittauany questions/doubts/concerns?15:48
TheJulianone on my end15:48
rpittauok, moving on!15:49
rpittauanything for BUG updates or RFEs ?15:49
rpittaualright!15:51
rpittauany Open Discussion topics?15:51
TheJuliaI don't have anything right now15:52
rpittauthen I'm declaring the meeting over!15:52
rpittauThanks everyone!15:52
rpittau#endmeeting15:52
opendevmeetMeeting ended Mon Jul 21 15:52:47 2025 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:52
opendevmeetMinutes:        https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-07-21-15.01.html15:52
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-07-21-15.01.txt15:52
opendevmeetLog:            https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-07-21-15.01.log.html15:52
cidNothing else, zoomed out a little before bug deputy updates. There were just two bugs. 0 RFEs.15:53
cid\o/15:53
TheJuliacardoe: back to your concern from what you viewed as competing specs. Did resetting context help or is there a concern beyond base confusion?15:53
cardoenah I need to go back and look at it.15:54
cardoeI was more just thinking about the operations for standalone when I was reading the stuff on adding the vendor field.15:55
cardoeAnd thinking of the standalone case and just thinking about bad ports or ports under maintenance.15:55
cardoeand just all the operations or state checks15:55
TheJuliayou did raise a super good point, we need an "enabled" field15:56
cardoeI think dtantsur was trying to skip adding a port because he doesn't want it to ever be used. But I was thinking that an inspection rule might be easier to always disable those ports.15:58
dtantsurbtw I ended up with a more nuclear option of ignoring such ports on IPA level entirely15:59
cardoeAnd I started thinking about writing down some cases on an etherpad but that didn't seem right.15:59
TheJuliaI think it makes sense to denote the case where you know of a port, but you must administratively disable it16:03
opendevreviewMerged openstack/ironic master: Add interface name to inventory for inspection hooks  https://review.opendev.org/c/openstack/ironic/+/95341416:03
TheJuliaand by administratively disable it, I mean tell ironic to ginroe it16:03
TheJuliato ignore it16:03
iurygregorytks for the +2 dtantsur o/ https://review.opendev.org/c/openstack/ironic/+/953394 16:10
TheJuliacardoe: I guess, it does make sense to write down some cases, but at the same time I wouldn't want to discount other cases because everyone is looking issues or challenges before them through their own lens16:14
TheJuliacardoe: sort of why I was like, "okay, there is a use case disconnect" early on16:14
opendevreviewDmitry Tantsur proposed openstack/ironic master: Switch from local RPC to automated JSON RPC on localhost  https://review.opendev.org/c/openstack/ironic/+/95475516:16
clifTheJulia: "class" is a keyword in Python, which causes a bit of a headache when trying to add it as an attribute to Port objects. Any objection to changing the attribute name from 'class' to 'category' or 'classification'?16:16
clifThis is in regard to trait based port scheduling16:16
TheJuliaclif: no objection to any suggested workaround to that :)16:16
clifty16:16
dtantsurTheJulia: I think https://review.opendev.org/c/openstack/ironic/+/954755 is ready16:18
opendevreviewMerged openstack/sushy-tools master: Validate JSON content type before parsing manager PATCH requests  https://review.opendev.org/c/openstack/sushy-tools/+/95494516:20
fricklersoo ... more fun with cisco it seems ... looks like they consider it an error to try to forceoff a server that is already off. this means after a successful deploy the ironic-triggered forceoff races with the ipa-triggered shutdown and sometimes fails16:49
opendevreviewClif Houck proposed openstack/ironic master: Add a new 'category' field to the Port object  https://review.opendev.org/c/openstack/ironic/+/95544716:59
iurygregorycardoe, tks for the review, I have a doc appointment, when I'm back I`ll push a separate patch with the docs update17:13
opendevreviewVerification of a change to openstack/bifrost master failed: Updated pinned upper-constraints for Python 3.9  https://review.opendev.org/c/openstack/bifrost/+/95518117:16
TheJuliafrickler: ugh, ugh17:19
TheJuliafrickler: #patcheswelcome ? :)17:19
opendevreviewMerged openstack/ironic master: Update firmware schema to require 'created_at' and 'updated_at' fields  https://review.opendev.org/c/openstack/ironic/+/95335217:21
fricklerTheJulia: yeah, I guess so ;) working on it17:25
cardoeiurygregory: sounds good17:33
TheJuliaqueensly[m]: I noticed one minor issue17:37
TheJuliaqueensly[m]: just you'll need to update requirements.txt17:38
queensly[m] TheJulia: Thanks for the heads up. I will update the requirements.txt file to set the minimum sushy version.17:53
TheJuliafrickler: if task.node.properties['vendor'] is getting set to cisco (we would hope, but we've seen some OEMs put garbage responses in those values like some vendors just put numbers... then you can base logic on it17:55
opendevreviewDoug Goldstein proposed openstack/ironic master: allow running inspection hooks on redfish interface  https://review.opendev.org/c/openstack/ironic/+/93306618:20
opendevreviewDoug Goldstein proposed openstack/ironic master: allow running inspection hooks on redfish interface  https://review.opendev.org/c/openstack/ironic/+/93306620:52
opendevreviewDoug Goldstein proposed openstack/ironic master: fix up redfish inspection mock data  https://review.opendev.org/c/openstack/ironic/+/95553620:52
opendevreviewDoug Goldstein proposed openstack/ironic master: fix redfish processor inspection  https://review.opendev.org/c/openstack/ironic/+/95553720:52
opendevreviewcid proposed openstack/ironic master: Clear `last_error` on power match/sync  https://review.opendev.org/c/openstack/ironic/+/95543221:02
clifAnyone know if portgroup should have a `hide_fields_in_newer_versions` function? It's present for allocation, derive, node, and port, but not portgroup.21:09
clifdriver*21:09
clifand that function only appears to be tested directly for ports in unit tests21:09
opendevreviewDoug Goldstein proposed openstack/ironic master: fix redfish processor inspection  https://review.opendev.org/c/openstack/ironic/+/95553721:14
opendevreviewDoug Goldstein proposed openstack/ironic master: allow running inspection hooks on redfish interface  https://review.opendev.org/c/openstack/ironic/+/93306621:14
cardoedtantsur: I dunno how to call / use default_hooks like you want in that change so I need some feedback/help.21:18
cardoeclif: likely never been needed before?21:18
clifmaybe, but portgroup is on version 1.5 so it's undergone some revision in the past I assume?21:18
clifif I'm adding a new field/attribute to Portgroup should I go ahead and also implement a new `hide_fields_in_newer_versions` for Portgroup?21:20
opendevreviewDoug Goldstein proposed openstack/ironic master: fix redfish processor inspection  https://review.opendev.org/c/openstack/ironic/+/95553721:52
opendevreviewDoug Goldstein proposed openstack/ironic master: allow running inspection hooks on redfish interface  https://review.opendev.org/c/openstack/ironic/+/93306621:52
cardoeSure21:52
opendevreviewcid proposed openstack/ironic-python-agent master: Hard stop on image download duration threshold  https://review.opendev.org/c/openstack/ironic-python-agent/+/95424521:56
opendevreviewDoug Goldstein proposed openstack/ironic master: fix redfish processor inspection  https://review.opendev.org/c/openstack/ironic/+/95553722:43
opendevreviewDoug Goldstein proposed openstack/ironic master: allow running inspection hooks on redfish interface  https://review.opendev.org/c/openstack/ironic/+/93306622:43
TheJuliaclif: likely should be there so it is hidden as appropriate for older versions, in reality most operators don't seem to do pinned rpc upgrades23:26
cardoeI hate mock so much right now.23:40

Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!