opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: [docs] Add NIC Firmware Update to Firmware Interface Docs https://review.opendev.org/c/openstack/ironic/+/955551 | 00:01 |
---|---|---|
iurygregory | cardoe, here it goes ^ | 00:01 |
opendevreview | Merged openstack/ironic-python-agent master: Provide usable __repr__ for serializable objects https://review.opendev.org/c/openstack/ironic-python-agent/+/953454 | 01:26 |
rpittau | good morning ironic! o/ | 06:27 |
abongale | good morning o/ | 07:28 |
*** tosky_ is now known as tosky | 07:33 | |
*** jroll08 is now known as jroll0 | 07:36 | |
rpittau | would really love an approval here when someone got a minute https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/950965 :) | 08:09 |
opendevreview | Merged openstack/tenks master: Fix outdated tox minversion https://review.opendev.org/c/openstack/tenks/+/955418 | 08:21 |
opendevreview | Riccardo Pittau proposed openstack/bifrost master: Updated pinned upper-constraints for Python 3.9 https://review.opendev.org/c/openstack/bifrost/+/955181 | 08:27 |
frickler | looks like the opendev change to drop the backports repo broke ipa-b bullseye: E: Release 'bullseye-backports' for 'lshw' was not found https://zuul.opendev.org/t/openstack/build/d8af28e2e4da43ffbc315d64d8d1c90b | 08:32 |
opendevreview | Riccardo Pittau proposed openstack/bifrost master: Updated pinned upper-constraints for Python 3.9 https://review.opendev.org/c/openstack/bifrost/+/955181 | 08:35 |
rpittau | frickler: yeah, I've noticed that, any chance it can be reverted ? | 08:36 |
rpittau | even though bullseye is EOL so probably not worth keeping it | 08:36 |
rpittau | mmmm LTS eol is actually next year | 08:37 |
frickler | rpittau: I'm not sure, there was some reason to do the change, iiuc the correct fix would be to explicitly enable the backports repo in that job if it is required | 08:41 |
rpittau | frickler: oh ok, didn't know about that option | 08:42 |
rpittau | frickler: is that an option on the job config ? | 08:45 |
frickler | rpittau: I'm not sure, best ask in #opendev | 08:46 |
rpittau | ack thanks | 08:46 |
opendevreview | Merged openstack/ironic master: Redfish Firmware Interface - NIC Support https://review.opendev.org/c/openstack/ironic/+/953394 | 09:34 |
opendevreview | Merged openstack/ironic master: Remove rootwrap https://review.opendev.org/c/openstack/ironic/+/953404 | 09:34 |
opendevreview | Merged openstack/ironic master: Remove installation guide for openSUSE/SLES https://review.opendev.org/c/openstack/ironic/+/950145 | 09:34 |
dtantsur | cardoe: I hope I commented in the right place now | 09:47 |
opendevreview | Queensly Kyerewaa Acheampongmaa proposed openstack/ironic master: Add manual clean and automated verify steps to set BMC clock via Redfish Manager https://review.opendev.org/c/openstack/ironic/+/953477 | 10:39 |
opendevreview | Takashi Kajinami proposed openstack/ironic master: doc: Use dnsmasq to run tftp server https://review.opendev.org/c/openstack/ironic/+/955579 | 10:46 |
opendevreview | Takashi Kajinami proposed openstack/ironic master: Drop remaining reference to openSUSE https://review.opendev.org/c/openstack/ironic/+/955581 | 10:50 |
opendevreview | Merged openstack/ironic-python-agent-builder master: Build ironic-python-agent DIB image with CentOS Stream 10 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/950965 | 10:58 |
opendevreview | Takashi Kajinami proposed openstack/ironic master: doc: Use dnsmasq to run tftp server https://review.opendev.org/c/openstack/ironic/+/955579 | 11:32 |
opendevreview | Takashi Kajinami proposed openstack/ironic master: doc: Fix installation of grub/shim EFI images in CentOS https://review.opendev.org/c/openstack/ironic/+/955590 | 11:37 |
dtantsur | Team, looking for reviews on https://review.opendev.org/c/openstack/ironic/+/954755 to unblock the eventlet migration. | 12:11 |
opendevreview | Takashi Kajinami proposed openstack/ironic master: doc: Fix installation of grub/shim EFI images in CentOS https://review.opendev.org/c/openstack/ironic/+/955590 | 12:42 |
opendevreview | Takashi Kajinami proposed openstack/ironic master: doc: Drop explicit version for CentOS/RHEL https://review.opendev.org/c/openstack/ironic/+/955594 | 12:44 |
cardoe | dtantsur: well I'm trying to just use the same $default_hook as the regular inspector | 13:03 |
dtantsur | cardoe: is it a good idea though? the list of default hooks may end up different over time. E.g. the error hook makes little sense without a ramdisk. | 13:04 |
dtantsur | (or do we still have it as a hook?) | 13:05 |
cardoe | dtantsur: I don't understand your commit message for that change. You say "switch from local RPC to automated JSON rpc" but then all your changes are adding "local RPC" in the comments. | 13:05 |
cardoe | error is not a hook. | 13:05 |
dtantsur | I don't know how to refer to variable across groups | 13:05 |
dtantsur | Ah, so we haven't migrated it this way | 13:05 |
dtantsur | cardoe: re commit message: yeah, I was not sure how to refer to things, so it ended up with a bit of ambiguity | 13:06 |
dtantsur | basically, instead of local calls and JSON RPC, we end up with two flavours of JSON RPC | 13:06 |
TheJulia | good morning | 13:09 |
dtantsur | cardoe: ha, it looks like you can use $group_name.variable_name | 13:10 |
cardoe | okay cool. | 13:10 |
dtantsur | (I'll double-checm more) | 13:10 |
cardoe | I think they should roughly be the same baseline. | 13:10 |
dtantsur | yeah, you should be able to do $inspector.default_hooks | 13:11 |
cardoe | Because today all the default_hooks do is populate the node properties with the data that redfish hardcodes. | 13:11 |
cardoe | https://review.opendev.org/c/openstack/networking-sfc/+/955295 something that they did to ban the import of eventlet by accident by people. | 13:19 |
TheJulia | surprising that they didn't catch that in regular review processeses | 13:20 |
TheJulia | LGTM, although one suggested change to the commit message which might help cardoe's understanding | 14:38 |
cardoe | TheJulia: I brought up the baremetal agent change we've got in the neutron call today. They said they'd prioritize it. | 14:46 |
TheJulia | cardoe: oh, awesome, thanks! | 14:46 |
TheJulia | I had someone downstream thank me yesterday for going "beep boop" on the change | 14:46 |
cardoe | We've literally got monitoring with automation to delete the agent to work around it. | 14:47 |
TheJulia | Yeah, that is a sign we really need to fix it overall | 14:47 |
cardoe | The only reason we use that mechanism is just for the port status propagation. | 14:48 |
cardoe | What do we want to do about https://review.opendev.org/c/openstack/bifrost/+/946724 It's sitting in the ironic-week-prio queue for a bit. I suspect the author isn't gonna update it. | 14:48 |
TheJulia | cardoe: I think at this point we could just keep the removal and remove the addition | 14:51 |
cardoe | I'll update it if that's okay to do. | 14:51 |
cardoe | Just trying to clean up the ironic-week-prio list. | 14:52 |
TheJulia | cardoe: yeah, perfectly fine to do | 14:57 |
TheJulia | You'll need to add your own signed-off-by label as well, fwiw | 14:57 |
cardoe | okay I've just been waiting for the author to come back. | 14:58 |
cardoe | I'm trying your beep boop approach on https://review.opendev.org/c/openstack/nova-specs/+/471815 | 14:58 |
TheJulia | Just think of it as 'your the robot who goes "beep boop" to annoy the humons' | 14:59 |
TheJulia | Clearly, we need an exocomp! | 15:00 |
TheJulia | https://www.thingiverse.com/thing:4623178 | 15:01 |
opendevreview | Doug Goldstein proposed openstack/ironic master: fix up redfish inspection mock ethernet interface data https://review.opendev.org/c/openstack/ironic/+/955536 | 16:24 |
opendevreview | Doug Goldstein proposed openstack/ironic master: fix redfish processor inspection https://review.opendev.org/c/openstack/ironic/+/955537 | 16:24 |
opendevreview | Doug Goldstein proposed openstack/ironic master: allow running inspection hooks on redfish interface https://review.opendev.org/c/openstack/ironic/+/933066 | 16:25 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: DNM illustrate broken <range-in> in root device hints https://review.opendev.org/c/openstack/ironic/+/955618 | 17:23 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: DNM illustrate broken <range-in> in root device hints https://review.opendev.org/c/openstack/ironic/+/955618 | 17:26 |
dtantsur | bug filed, help welcome https://bugs.launchpad.net/ironic/+bug/2117514 | 17:26 |
cardoe | I'm fighting these damn mocks. I dunno what to do with mine. | 17:37 |
opendevreview | Clif Houck proposed openstack/ironic master: Add a new 'physical_network' field to the Portgroup object https://review.opendev.org/c/openstack/ironic/+/955625 | 19:13 |
opendevreview | Clif Houck proposed openstack/ironic master: Add a new 'physical_network' field to the Portgroup object https://review.opendev.org/c/openstack/ironic/+/955625 | 19:36 |
opendevreview | Nahian Pathan proposed openstack/sushy master: Support expanded Chassis and Storage for redfish https://review.opendev.org/c/openstack/sushy/+/955211 | 20:21 |
opendevreview | Jonathan Davies proposed openstack/ironic-python-agent master: enable_vlan_interfaces: support identifying interfaces by MAC https://review.opendev.org/c/openstack/ironic-python-agent/+/955629 | 20:41 |
opendevreview | Nahian Pathan proposed openstack/sushy master: Support expanded Chassis and Storage for redfish https://review.opendev.org/c/openstack/sushy/+/955211 | 20:57 |
opendevreview | Nahian Pathan proposed openstack/sushy master: Support expanded Chassis and Storage for redfish https://review.opendev.org/c/openstack/sushy/+/955211 | 20:58 |
opendevreview | Nahian Pathan proposed openstack/sushy master: Support expanded Chassis and Storage for redfish https://review.opendev.org/c/openstack/sushy/+/955211 | 21:02 |
opendevreview | Nahian Pathan proposed openstack/sushy master: Support expanded Chassis and Storage for redfish https://review.opendev.org/c/openstack/sushy/+/955211 | 21:33 |
opendevreview | Queensly Kyerewaa Acheampongmaa proposed openstack/ironic master: Add manual clean and automated verify steps to set BMC clock via Redfish Manager https://review.opendev.org/c/openstack/ironic/+/953477 | 21:39 |
opendevreview | Julia Kreger proposed openstack/ironic master: Replace GreenThreadPoolExecutor in conductor https://review.opendev.org/c/openstack/ironic/+/952939 | 22:28 |
opendevreview | Julia Kreger proposed openstack/ironic master: Set the backend to threading. https://review.opendev.org/c/openstack/ironic/+/953683 | 22:28 |
opendevreview | Julia Kreger proposed openstack/ironic master: Clean-up misc eventlet references https://review.opendev.org/c/openstack/ironic/+/955632 | 22:28 |
TheJulia | dtantsur: so, while I was sitting in a waiting room last week, I pondered https://review.opendev.org/c/openstack/ironic/+/955109 because it seems sort of weird. Any thoughts? I guess what I started seeing is a weird spread | 22:45 |
TheJulia | 9 threads vs 8 threads, ultimately. | 22:48 |
TheJulia | it puts the current thread to work, but that could just go to waiting and it would al be okay. | 22:58 |
opendevreview | Nahian Pathan proposed openstack/ironic master: Reduce API calls when collecting sensor data with redfish https://review.opendev.org/c/openstack/ironic/+/955484 | 23:38 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!