| JayF | iurygregory: there's no need from my perspective to chat about inspector. We've already merged changes to retire it. | 00:14 |
|---|---|---|
| *** gursahibpreetsingh is now known as hargunkaur | 00:57 | |
| iurygregory | JayF, I had this feeling, but since the topic was still in the etherpad I added,I will remove, tks! | 01:12 |
| hargunkaur | Hi everyone! đź‘‹ | 01:17 |
| hargunkaur | I’m Hargun Kaur, an Outreachy applicant interested in the “Extend Ironic node deployment history API” project. I’ve joined via WeeChat and started exploring the Ironic and Bifrost documentation. Excited to learn and contribute! | 01:17 |
| rpittau | good morning ironic! o/ | 07:04 |
| rpittau | welcome hargunkaur :) | 07:04 |
| rpittau | iurygregory: besides removing the inspector talk as mentioned by JayF , it looks good, thanks for that! | 07:06 |
| opendevreview | Merged openstack/ironic-prometheus-exporter master: [IPE] Support iDRAC driver metrics https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/954870 | 07:51 |
| opendevreview | Stephen Finucane proposed openstack/ironic stable/2025.2: api: Catch correct exception on schema validation error https://review.opendev.org/c/openstack/ironic/+/963938 | 10:17 |
| opendevreview | Stephen Finucane proposed openstack/ironic stable/2025.2: api: Allow bios values to be None https://review.opendev.org/c/openstack/ironic/+/963940 | 10:19 |
| Ayo[m] | hi everyone... (full message at <https://matrix.org/oftc/media/v1/media/download/ASf_ewJ6A0M-Fcb-VXwXNr7H-rMbw9X7FOl8QWz6RpgTPf5_3QNgKVLXcZiXjMDae7LwgLmFmHXazDQfc-E3HABCeaKmNHUAAG1hdHJpeC5vcmcvVVJqakRQWldRR1B2VHdyVXFqakVacmdY>) | 10:35 |
| FreemanBoss[m] | Ayo: what are the commands you ran,? | 10:42 |
| Ayo[m] | the initial command i ran | 10:44 |
| Ayo[m] | ./bifrost-cli testenv | 10:44 |
| Ayo[m] | then "./bifrost-cli --testenv" command that gave the error | 10:44 |
| FreemanBoss[m] | The second command won't work without the install parameter | 10:55 |
| FreemanBoss[m] | ./bifrost-cli install --testenv | 10:55 |
| Pointbr8ker | Hi everyone... My name is David and I'm an outreachy applicant. I'd really appreciate any guidance on getting started. I’m eager to explore and contribute meaningfully to the project. Looking forward to learning from the community and collaborating with you all! | 11:50 |
| iurygregory | rpittau, tks! | 11:55 |
| rpittau | Pointbr8ker: welcome! You can find all the info in the project page :) | 11:56 |
| Pointbr8ker | Thanks rpittau! | 12:06 |
| opendevreview | Mahnoor Asghar proposed openstack/ironic master: Fix cleaning example in docs that sets the BMC clock to use correct arg https://review.opendev.org/c/openstack/ironic/+/963951 | 12:19 |
| *** AB is now known as Guest28989 | 13:20 | |
| TheJulia | good morning | 13:22 |
| *** AB is now known as Guest28999 | 15:14 | |
| *** gmaan_pto is now known as gmaan | 16:00 | |
| cardoe | So looking at that patch above... if I wanted to set the clock in a runbook... I couldn't really do that cause I couldn't dynamically get the right date/time in a runbook right? | 16:08 |
| TheJulia | ... yeah, we should extend that so you can just say "set the current time of the conductor" | 16:12 |
| cardoe | Yeah that's what I want. Is that possible? | 16:35 |
| *** AB is now known as Guest29008 | 16:56 | |
| alegacy | TheJulia: looks like openstack/requirements is consulted when validating test-requirements.txt because my addition of NGS to it has caused a build failure. | 17:04 |
| alegacy | is adding NGS to the global requirements an option to consider, or is that another can of worms? | 17:05 |
| TheJulia | cardoe: dunno off hand, but seems like a reasonable thing to do. | 17:05 |
| TheJulia | alegacy: can you point me to a job log/change diff ? | 17:05 |
| alegacy | https://zuul.opendev.org/t/openstack/build/2b2069d462c24c0eb5355fc2f9e3ffca from this change: https://review.opendev.org/c/openstack/ironic/+/962493 | 17:06 |
| TheJulia | I... guess that could be reasonable to do | 17:07 |
| TheJulia | fwiw, I thought driver-reqs was skipped on that check | 17:09 |
| alegacy | I put it in both driver-requirements.txt and test-requirements.txt since it is used from unit tests... the test-requirements.txt seems to be the one that was flagged | 17:12 |
| alegacy | I could use importutils.try_import('networking-generic-switch') to get the test skipped if it is not present, but wasn't sure if that was appropriate | 17:13 |
| alegacy | I noticed that was done for some of the proliant utils | 17:13 |
| JayF | TheJulia: driver-reqs have always been subject to that check; it's why our dusty broken SNMP driver is holding back the rest of the project :( | 17:14 |
| TheJulia | ahh | 17:14 |
| TheJulia | alegacy: for soft dependencies, that is an appropriate path | 17:14 |
| alegacy | what's your definition of "soft dependency" from a unit test perspective? Having tox skip tests seems like a risk to having someone accidentally break them without realizing. | 17:16 |
| TheJulia | That is indeed the risk with that path | 17:17 |
| TheJulia | Ugh, putting it in g-r as a plugin also prevents release adoption | 17:19 |
| TheJulia | Why don’t we break n-g-s into two pieces? | 17:20 |
| TheJulia | Like a lib-genericswitch | 17:20 |
| TheJulia | And ironic/ngs separately import lib-generic switch to do their needful actions | 17:20 |
| JayF | This feels like the other side of the cycle we hit with ironic-lib and sushy of not wanting to pay the lib price. Is there any way to integrate the lib-y parts into Ironic directly so NGS takes an ironic dep rather than other way around? | 17:21 |
| TheJulia | No, we keep trying to dance to find a way to avoid the lift and we footgun ourselves on every path] | 17:21 |
| JayF | what did you mean by "prevents release adoption" | 17:21 |
| JayF | I'm still trying to sort out what you meant by that | 17:21 |
| TheJulia | So, basically, we won’t be able to do an end-of-release n-g-s version anymore, it will need to be earlier, but since it is also an ml2 plugin, it needs a late in cycle before release dependency change with neutron-lib | 17:22 |
| TheJulia | It’s the same reason we hit the breaks with ironic and dependency mapping, just a different shape | 17:23 |
| JayF | makes sense | 17:24 |
| JayF | what's the code in question? Assuming it's more than just something like object definitions we could copy around in the short term | 17:24 |
| alegacy | isn't this a problem for all libraries? | 17:24 |
| JayF | alegacy: we've been on a recent push to move away from internal libraries where possible because of the massive pain they cause when security issues happen | 17:25 |
| TheJulia | Might be easier to just talk through first, but would it be okay to make a fresh cup of coffee before starting a call? | 17:26 |
| JayF | I'm OK with a call, I'm OK with keeping it async, I'm OK with hallway tracking it in 3 days | 17:26 |
| alegacy | yes, caffeinate at will | 17:26 |
| * TheJulia goes and makes coffeeeeeeeeeee | 17:27 | |
| TheJulia | https://meet.google.com/mmv-hanj-cnc?authuser=0 | 17:34 |
| TheJulia | JayF: https://review.opendev.org/c/openstack/networking-generic-switch/+/962037 | 18:07 |
| JayF | summary from call: it isn't a bad thing to put NGS in g-r, we'll just have to exercise more discipline about hitting release deadlines (which is a good thing anyway) | 18:15 |
| TheJulia | ++++ | 18:15 |
| JayF | clif: it'd be ideal if you could make sure to get eyes on alegacy's patches in NGS and Ironic for standalone networking. Not really urgent since your reviews aren't blocking, but it'd be a good thing to get familiar with. | 18:17 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: remove hard requirement on neutron https://review.opendev.org/c/openstack/networking-generic-switch/+/963302 | 18:20 |
| TheJulia | JayF: I think that should resolve it | 18:21 |
| clif | JayF: ack | 18:21 |
| JayF | TheJulia: alegacy: https://review.opendev.org/c/openstack/networking-generic-switch/+/962037 soft +1 with a question and an ask. Just making sure I understand (and agreement to add the requested test case as a follow up) before upgrading to +2 | 18:28 |
| alegacy | JayF: thanks, will update. | 18:30 |
| *** AB is now known as Guest29010 | 18:33 | |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: tox: Enable codespell by default and limit it to relevant files https://review.opendev.org/c/openstack/networking-generic-switch/+/958154 | 18:58 |
| opendevreview | Merged openstack/ironic master: docs: add context around bmc password changes https://review.opendev.org/c/openstack/ironic/+/963441 | 19:05 |
| JayF | upgraded ^^ that review to a +2 with the assumption the test will be a followup if it's landed | 19:05 |
| alegacy | JayF: could you check out this test case "test_delete_port_with_per_port_default_vlan" ... I think it covers the case you asked about (i.e., global config + api parameter) | 19:11 |
| JayF | alegacy: I don't see an NGS config mocked in there with a default vlan set? | 19:17 |
| JayF | am I misreading something? | 19:17 |
| alegacy | Oh, I've got 2 tests named the same way in 2 different files... the one in test_netmiko_base.py does this: switch = self._make_switch_device({'ngs_port_default_vlan': '20'}) | 19:24 |
| JayF | ack sgtm | 19:26 |
| JayF | I read again and thought that might be what I missed | 19:26 |
| JayF | I don't love the decoder ring of yet-more-layered-config but that's not your fault, not anyone's fault really | 19:26 |
| JayF | clouds be complex :( | 19:26 |
| alegacy | :) | 19:38 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add a new 'category' field to the Portgroup object https://review.opendev.org/c/openstack/ironic/+/955713 | 19:57 |
| opendevreview | Verification of a change to openstack/ironic-tempest-plugin master failed: CI: Set the neutron network interface for dhcpless runs https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/962837 | 20:22 |
| opendevreview | Verification of a change to openstack/networking-generic-switch master failed: Add default vlan to driver interfaces https://review.opendev.org/c/openstack/networking-generic-switch/+/962037 | 21:39 |
| TheJulia | Hmm, that multitenancy job is not happy | 21:50 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!