| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/driver.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979935 | 00:03 |
|---|---|---|
| TheJulia | cardoe: not sure I really grok your question, but I let steve know via slack in case he doesn't see he has a message on matrix | 00:09 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/allocation.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979936 | 00:10 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/allocation.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979936 | 00:16 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/chassis.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979937 | 00:17 |
| stevebaker[m] | cardoe: conductor and novnc containers in the same pod would be recommended, yes | 00:21 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/driver.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979935 | 00:22 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/allocation.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979936 | 00:22 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/chassis.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979937 | 00:22 |
| cardoe | stevebaker[m], TheJulia: was also asking if novnc and ironic needed to be pip installed together or if it can be just novnc. | 01:01 |
| cardoe | Looking to update OpenStack Helm with the right setup. | 01:22 |
| stevebaker[m] | cardoe: the novncproxy container is running the ironic.command.novncproxy service, so it needs both ironic and novnc to be installed | 01:37 |
| cardoe | Okay. Good deal. | 01:48 |
| opendevreview | Jacob Anders proposed openstack/ironic master: cleaning: auto-detect ramdisk need from step metadata https://review.opendev.org/c/openstack/ironic/+/978844 | 05:58 |
| rpittau | good morning ironic! o/ | 07:58 |
| opendevreview | yatin proposed openstack/ironic unmaintained/2024.1: [Stable 2024.1 Only] pin ironic-tempest-plugin to last working tag https://review.opendev.org/c/openstack/ironic/+/979773 | 09:07 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Skip redundant BIOS reboot when settings already match https://review.opendev.org/c/openstack/ironic/+/979828 | 11:04 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add dynamic portgroup fields (API 1.111) https://review.opendev.org/c/openstack/ironic/+/978964 | 13:44 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add group_and_attach_ports support to TBN https://review.opendev.org/c/openstack/ironic/+/980070 | 13:44 |
| clif | JayF: That should mostly satisfy milestone 2 ^^^ | 13:45 |
| clif | I still need to update TBN docs | 13:45 |
| TheJulia | janders: w/r/t 979828, i do wonder if in pending future state if a reboot is still funcitonally needed. I just feel weird about it because basically vendors are doing the wrong thing with future state in some cases, see idrac10, and it could now mean present or future under the precedent | 13:58 |
| JayF | \o\ /o/ \o\ | 14:01 |
| * JayF reviews 980070 | 14:01 | |
| TheJulia | cid: quick revision on https://review.opendev.org/c/openstack/ironic/+/979721 please | 14:02 |
| cid | will do, tks... | 14:04 |
| cid | on it actually :-) | 14:04 |
| opendevreview | cid proposed openstack/ironic master: Check port physnet against portgroup on first add https://review.opendev.org/c/openstack/ironic/+/979721 | 14:13 |
| opendevreview | Bartosz Bezak proposed openstack/ironic stable/2025.1: Add a new configuration option, ``bootloader_by_arch`` https://review.opendev.org/c/openstack/ironic/+/980080 | 14:19 |
| JayF | bbezak: that's not going to be backportable by policy because it changes configuration behavior :( | 14:20 |
| JayF | bbezak: glad you find it useful though, good luck with ARM|RISC|??? | 14:20 |
| bbezak | :) | 14:20 |
| bbezak | I thought so | 14:20 |
| JayF | we missed it when doing the rst of the _by_arch | 14:21 |
| JayF | and only caught it when my downstream did mixed arch, so sorry about that | 14:21 |
| TheJulia | heh, jayf beat me to the comment | 14:21 |
| JayF | I feel mildly responsible :) | 14:21 |
| TheJulia | eh, its life | 14:21 |
| bbezak | I was thinking that it has closes-bug, it may be accepted ;) | 14:21 |
| bbezak | But it is fair | 14:22 |
| bbezak | Thx! | 14:22 |
| JayF | I mean, let me put it this way | 14:22 |
| bbezak | Will do it downstream | 14:22 |
| JayF | if it was like, 3 weeks post-release I could be talked into it | 14:22 |
| bbezak | sure | 14:22 |
| JayF | at this point adding a config behavior change to a 1.5 year old release is going to be a bad surprise for an operator | 14:22 |
| JayF | clif: https://review.opendev.org/c/openstack/ironic/+/980070/1#message-e7864bbc444d90ad884218539fc86fc02913a65e | 14:29 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Use shared lock for get_virtual_media conductor method https://review.opendev.org/c/openstack/ironic/+/980089 | 14:31 |
| opendevreview | Merged openstack/networking-generic-switch master: docs: address nits for 978799 https://review.opendev.org/c/openstack/networking-generic-switch/+/979761 | 14:33 |
| TheJulia | clif: was an AI agent used for that? | 14:38 |
| JayF | clif doesn't use AI tooling generally AFAIK | 14:38 |
| clif | No, why do you ask? | 14:39 |
| TheJulia | okay, fair, just surprised on the later save to see the mac address check since seems... unlikely to occur | 14:39 |
| TheJulia | At least, with where my head is at, seems unlikely, it could be off-base | 14:40 |
| clif | which mac address check | 14:41 |
| TheJulia | the exception check just past 729 on https://review.opendev.org/c/openstack/ironic/+/980070/1/ironic/drivers/modules/network/common.py | 14:42 |
| TheJulia | if the port already exists, and we're just doing a save to it, seems unlikely we're ever going to have a mac address error then | 14:42 |
| JayF | the more strongly you say that, the more likely the unlikely thing is to happen, didn't Murphy say something about that :P | 14:43 |
| TheJulia | I dunno, I have three cats and they are somehow all still alive | 14:44 |
| TheJulia | .... although the tabby looks rather upset at me at the moment. | 14:44 |
| clif | TheJulia: I think I am checking for all the exceptions that `port.save` could possibly raise | 14:44 |
| TheJulia | fair enough then | 14:44 |
| clif | whether that makes sense to do there... idk | 14:44 |
| clif | perhaps not | 14:44 |
| TheJulia | nah, nothing required then there | 14:44 |
| TheJulia | I was just looking at it going "huh" | 14:44 |
| clif | I read the method's docstring! | 14:44 |
| TheJulia | Anyway you may want to catch the name collission from the name field not being unique in that same file | 14:45 |
| clif | I swear I'm a real person behind the keyboard | 14:45 |
| TheJulia | in response to jayf's comment | 14:45 |
| TheJulia | clif: but do you have cats? | 14:45 |
| clif | I have two | 14:45 |
| TheJulia | excellent, then we have proof! | 14:45 |
| JayF | how have I worked with you this long and never seen the cats | 14:45 |
| clif | Pancake and Pumpkin | 14:45 |
| JayF | I can guess who named that pair :D | 14:46 |
| TheJulia | excellent cat names | 14:46 |
| clif | they normally stay off my desk | 14:46 |
| clif | I will address all review comments soon, ty for reviews | 14:46 |
| JayF | our only cat right now, Juno, she's gotten braver in the last two weeks. I've had to learn how to work with a cat perched on my shoulder (not that she wouldn't leave if I made her, but I mean, cat) | 14:46 |
| JayF | https://usercontent.irccloud-cdn.com/file/RZueq8Hz/cat-tax-juno.jpg | 14:48 |
| TheJulia | awww | 14:49 |
| rpittau | that's a huge cat :D | 14:50 |
| JayF | no, she's tiny | 14:50 |
| JayF | just a perspective thing | 14:50 |
| rpittau | oh! | 14:50 |
| JayF | https://usercontent.irccloud-cdn.com/file/Sl5BGZz5/irccloudcapture410740320019366536.jpg | 14:50 |
| JayF | the shoulder cling is her newest thing, my wife leaves for work, she finds me and jumps up for like 30 minutes while I do my morning work | 14:51 |
| TheJulia | Ours do that with my wife. She sits in the recliner and the cats make a circuit of about 20 minutes each | 14:52 |
| JayF | https://review.opendev.org/c/openstack/python-ironicclient/+/978336 is the top of a big stack of changes to add type annotations | 14:54 |
| JayF | I belive cid already reviewed them, and I'm going to go land them all now | 14:54 |
| TheJulia | There rae like 7-ish items in ironic-week-prio right now | 14:54 |
| JayF | if someone non-GR wants to look before I +A please speak up soon :) I'll leave the first patch un-+A'd until I get into the end | 14:54 |
| JayF | We're about to have the sync with our MLH fellow so I'm trying to land these or get feedback before that meeting :) | 14:55 |
| JayF | ah cid already -1 one patch in :) | 14:58 |
| cid | Yeah, I'm currently still walking down the list atm | 14:59 |
| TheJulia | I can still approve the first one right?!? | 15:02 |
| TheJulia | :) | 15:02 |
| JayF | please do if you approve :) | 15:02 |
| TheJulia | donezo | 15:02 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Skip redundant BIOS reboot when settings already match https://review.opendev.org/c/openstack/ironic/+/979828 | 15:04 |
| opendevreview | Konstantinos Karampogias proposed openstack/ironic master: Skip redundant BIOS reboot when settings already match https://review.opendev.org/c/openstack/ironic/+/979828 | 15:13 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/exc.py` https://review.opendev.org/c/openstack/python-ironicclient/+/978336 | 15:15 |
| opendevreview | Karan Anand proposed openstack/python-ironicclient master: Add type annotations to `ironicclient/common/utils.py` https://review.opendev.org/c/openstack/python-ironicclient/+/978337 | 15:16 |
| TheJulia | so every ironic-week-prio has at least one +2 | 15:16 |
| rpittau | \o/ | 15:21 |
| rpittau | thanks for the review on the redfish option TheJulia, I did want to put bug fix instead of feature, I didn't dare :D | 15:22 |
| TheJulia | That one is in that funny grey area | 15:23 |
| rpittau | yep | 15:23 |
| TheJulia | more so since we drop-kicked eventlet to the curb | 15:23 |
| *** alegacy_ is now known as alegacy | 15:34 | |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Fix Redfish connect timeout to prevent conductor worker exhaustion https://review.opendev.org/c/openstack/ironic/+/979872 | 15:41 |
| opendevreview | Julia Kreger proposed openstack/ironic master: fix: Remove early excessive return https://review.opendev.org/c/openstack/ironic/+/980115 | 16:02 |
| kubajj | hello Ironic, I have just noticed that local_gb and cpus inspection hooks were dropped... why? | 16:05 |
| opendevreview | Merged openstack/networking-baremetal master: Revise localnet port text https://review.opendev.org/c/openstack/networking-baremetal/+/979699 | 16:05 |
| TheJulia | Well, neither get used for scheduling so its purely informational at this point. | 16:10 |
| TheJulia | OR unless your doing partition images you might want it, but even then #notadvisedtodopartitionimages | 16:10 |
| opendevreview | Julia Kreger proposed openstack/ironic master: trivial: remove unused helper method argument https://review.opendev.org/c/openstack/ironic/+/980117 | 16:14 |
| kubajj | TheJulia: ok, that's valid - if I implement them, should I re-add them to upstream? | 16:14 |
| TheJulia | I don't see why not | 16:14 |
| opendevreview | Julia Kreger proposed openstack/ironic master: trivial: fix argument name in abstract api method https://review.opendev.org/c/openstack/ironic/+/980124 | 16:25 |
| opendevreview | Merged openstack/ironic master: Use ServiceRoot.Vendor for detect_vendor() instead of System.Manufacturer https://review.opendev.org/c/openstack/ironic/+/978439 | 16:36 |
| opendevreview | Merged openstack/ironic master: fix(redfish): correct submission of DateTime to BMC https://review.opendev.org/c/openstack/ironic/+/979722 | 16:36 |
| opendevreview | Merged openstack/networking-generic-switch master: Enable L2VNI support for Cisco NX-OS switches https://review.opendev.org/c/openstack/networking-generic-switch/+/979352 | 16:45 |
| opendevreview | Merged openstack/networking-generic-switch master: Fix KeyError in vlan_has_vni for Cisco NX-OS https://review.opendev.org/c/openstack/networking-generic-switch/+/979351 | 16:45 |
| opendevreview | Merged openstack/ironic unmaintained/2024.1: [Stable 2024.1 Only] pin ironic-tempest-plugin to last working tag https://review.opendev.org/c/openstack/ironic/+/979773 | 16:50 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Use shared lock for get_virtual_media conductor method https://review.opendev.org/c/openstack/ironic/+/980089 | 16:57 |
| dtantsur | rpittau: food for thought posted ^^ | 17:10 |
| opendevreview | Merged openstack/ironic master: Check port physnet against portgroup on first add https://review.opendev.org/c/openstack/ironic/+/979721 | 17:29 |
| JayF | cardoe: did you have anyone at Rackspace interested in helping with maintenance of openstack-exporter? | 18:52 |
| JayF | cardoe: clif, adam, and I talked about that today and we're going to push to get more maintainers, now would be a great opportunity if you wanna point someone at that upstream | 18:52 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add group_and_attach_ports support to TBN https://review.opendev.org/c/openstack/ironic/+/980070 | 19:01 |
| JayF | clif: https://review.opendev.org/c/openstack/ironic/+/980070 -1 for something that's my fault; the pep8 fix in the model needs to be in the parent /o\ | 19:07 |
| opendevreview | cid proposed openstack/ironic master: Fix wrong keys in `set_boot_mode`` https://review.opendev.org/c/openstack/ironic/+/980153 | 19:28 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add dynamic portgroup fields (API 1.111) https://review.opendev.org/c/openstack/ironic/+/978964 | 19:33 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add group_and_attach_ports support to TBN https://review.opendev.org/c/openstack/ironic/+/980070 | 19:33 |
| clif | JayF: fixed, I think | 19:34 |
| clif | still need to add a release note but after that I think I'll have responded to all comments | 19:35 |
| JayF | awesome, I'll take a look after the push w/ a release note on the tip there | 19:40 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: WIP: Move multicast helper to device_utils. https://review.opendev.org/c/openstack/networking-generic-switch/+/980158 | 20:06 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: WIP: Arista eos multicast vxlan https://review.opendev.org/c/openstack/networking-generic-switch/+/980159 | 20:06 |
| clif | JayF: I'm not sure I ever added a release note for tbn milestone 1 | 20:07 |
| clif | Should I just make a release note for it all now? | 20:07 |
| JayF | I'd check; if you didn't lets just make one that covers the whole thing. | 20:08 |
| JayF | I'd make sure to mention a use case and point to the public docs (use a fully qualified URL if you direct-link to it) | 20:08 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Support ramdisk deploy with Glance image_source https://review.opendev.org/c/openstack/ironic/+/978828 | 20:13 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add ramdisk to autodetect deploy interface https://review.opendev.org/c/openstack/ironic/+/978829 | 20:13 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Enable ramdisk autodetect by default https://review.opendev.org/c/openstack/ironic/+/978602 | 20:13 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Support ramdisk deploy with Glance image_source https://review.opendev.org/c/openstack/ironic/+/978828 | 20:34 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add ramdisk to autodetect deploy interface https://review.opendev.org/c/openstack/ironic/+/978829 | 20:34 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Enable ramdisk autodetect by default https://review.opendev.org/c/openstack/ironic/+/978602 | 20:34 |
| opendevreview | cid proposed openstack/ironic master: Fix wrong keys in `set_boot_mode` https://review.opendev.org/c/openstack/ironic/+/980153 | 20:43 |
| opendevreview | cid proposed openstack/ironic master: Remove unused variables and fix the log message https://review.opendev.org/c/openstack/ironic/+/980162 | 20:43 |
| opendevreview | cid proposed openstack/ironic master: Consistency in handling full-boot-request vendors https://review.opendev.org/c/openstack/ironic/+/980163 | 20:43 |
| opendevreview | cid proposed openstack/ironic master: Fix wrong keys in `set_boot_mode` https://review.opendev.org/c/openstack/ironic/+/980153 | 21:01 |
| opendevreview | cid proposed openstack/ironic master: Remove unused variables and fix the log message https://review.opendev.org/c/openstack/ironic/+/980162 | 21:01 |
| opendevreview | cid proposed openstack/ironic master: Consistency in handling full-boot-request vendors https://review.opendev.org/c/openstack/ironic/+/980163 | 21:01 |
| opendevreview | cid proposed openstack/ironic master: Fix wrong keys in `set_boot_mode` https://review.opendev.org/c/openstack/ironic/+/980153 | 21:03 |
| opendevreview | cid proposed openstack/ironic master: Remove unused variables and fix the log message https://review.opendev.org/c/openstack/ironic/+/980162 | 21:03 |
| opendevreview | cid proposed openstack/ironic master: Consistency in handling full-boot-request vendors https://review.opendev.org/c/openstack/ironic/+/980163 | 21:03 |
| opendevreview | Clif Houck proposed openstack/ironic master: Add group_and_attach_ports support to TBN https://review.opendev.org/c/openstack/ironic/+/980070 | 21:17 |
| clif | JayF: ^ added a releasenote | 21:18 |
| JayF | +2 and rechecked parent | 21:31 |
| TheJulia | jrosser: https://review.opendev.org/c/openstack/networking-generic-switch/+/980159 albeit just multicast instead of ingress-replication in general, if you see any issues please lmk | 21:44 |
| jrosser | TheJulia: thanks for that - I do still owe you an example config, its on the todo list | 21:49 |
| fungi | JayF: did ironic-inspector and ironic-inspector-specs retirements never get completed? i see you replaced the master branch files with a readme that says so, but they're not using the retired project gerrit acls and ironic-inspector is even still listed as an official deliverable in governance | 22:50 |
| fungi | came to my attention via https://review.opendev.org/c/openstack/project-config/+/980169 | 22:51 |
| fungi | cc dtantsur ^ | 22:51 |
| fungi | not urgent, but probably needs some additional cleanup | 22:52 |
| * fungi disappears into the night | 22:52 | |
| JayF | fungi: https://review.opendev.org/c/openstack/governance/+/963470 ? | 22:54 |
| JayF | I must have missed extra stuff, somehow? | 22:54 |
| fungi | aha! it's deprecated not retired, okay | 22:57 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add ramdisk to autodetect deploy interface https://review.opendev.org/c/openstack/ironic/+/978829 | 22:57 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Enable ramdisk autodetect by default https://review.opendev.org/c/openstack/ironic/+/978602 | 22:57 |
| fungi | so ironic-inspector-specs didn't get the retired acl set in openstack/project-config:gerrit/projects.yaml at least (i didn't look to see what else might have been missed), but also the author of 980169 is confused by the difference between retired and deprecated | 22:58 |
| JayF | ack; it's my EOD right now so I'll set a note to check into this tomorrow if someone doesn't get there before I do | 22:59 |
| fungi | separately, not necessarily your problem, but the published project deliverable pages like https://governance.openstack.org/tc/reference/projects/ironic.html could stand to indicate when a project is deprecated | 22:59 |
| fungi | JayF: yeah, my eod too. as i said not urgent | 22:59 |
| fungi | just wanted to give you a heads up before i forgot | 22:59 |
| JayF | oh, 100% I had to put the reminder into slack or else it'd fall on the floor before 7am tomorrow for sure :D | 23:00 |
| JayF | thanks for the heads up! | 23:00 |
| fungi | hah, i'm the same way ;) | 23:00 |
| JayF | I'm glad to work in a project big enough that my shotgun approach of "try to do as much good as possible" works even if sometimes it means I miss a thing or three at times :D | 23:00 |
| fungi | (well, not slack, but i keep a list to augment my aging swiss-cheese brain) | 23:00 |
| cardoe | JayF: yeah keekz who is not on. | 23:06 |
| JayF | cardoe: I think we're going to push to get someone else to maintainer level knowledge in that project over the next 6 months. I think it would be great for the community and the health of that if one of your folks could take on that same challenge | 23:09 |
| TheJulia | Inspector?! | 23:11 |
| JayF | Yeah it's only deprecated not retired because we still have supported branches of it | 23:13 |
| JayF | We don't get to fully retire it until we've done our 18-month of support as promise | 23:13 |
| TheJulia | Ahh, yeah | 23:14 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2025.2: fix(redfish): correct submission of DateTime to BMC https://review.opendev.org/c/openstack/ironic/+/980177 | 23:49 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
