| opendevreview | Doug Goldstein proposed openstack/ironic master: fix: MAC address handling was not always normalized https://review.opendev.org/c/openstack/ironic/+/980180 | 00:51 |
|---|---|---|
| opendevreview | Doug Goldstein proposed openstack/ironic master: remove dead code for normalize MAC https://review.opendev.org/c/openstack/ironic/+/980181 | 00:54 |
| cardoe | JayF: yeah I'll poke keekz (Nick). | 00:54 |
| opendevreview | Harald Jensås proposed openstack/sushy-tools master: novadriver: Detect disk format from image content https://review.opendev.org/c/openstack/sushy-tools/+/980186 | 03:16 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Dell iDRAC tasks show is_processing True when COMPLETED https://review.opendev.org/c/openstack/ironic/+/976657 | 03:36 |
| opendevreview | Merged openstack/ironic master: Add dynamic portgroup fields (API 1.111) https://review.opendev.org/c/openstack/ironic/+/978964 | 03:41 |
| opendevreview | Jacob Anders proposed openstack/ironic master: Skip redundant BIOS reboot when settings already match https://review.opendev.org/c/openstack/ironic/+/979828 | 05:37 |
| *** jroll09 is now known as jroll0 | 06:28 | |
| rpittau | good morning ironic! o/ | 07:49 |
| opendevreview | Nathan Harper proposed openstack/ironic-python-agent-builder stable/2025.1: Wait up to 30 seconds for config drive https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/980209 | 09:09 |
| opendevreview | Nathan Harper proposed openstack/ironic-python-agent-builder stable/2025.1: Wait up to 30 seconds for config drive https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/980209 | 09:11 |
| opendevreview | Syed Haseeb Ahmed proposed openstack/ironic stable/2025.2: Support pluggable API middleware via entry points https://review.opendev.org/c/openstack/ironic/+/980211 | 09:12 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Add cpus inspection hook https://review.opendev.org/c/openstack/ironic/+/980214 | 09:22 |
| kubajj | good morning rpittau, and Ironic! o/ | 09:25 |
| rpittau | hey kubajj :) | 09:28 |
| kubajj | I have noticed that the memory inspection hook sets memory_mb to be an int in the properties, whereas local_gb (from root-device hook) is set to a string. Should I change this for consistency? | 09:29 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Fix Redfish connect timeout to prevent conductor worker exhaustion https://review.opendev.org/c/openstack/ironic/+/979872 | 09:30 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Use shared lock for get_virtual_media conductor method https://review.opendev.org/c/openstack/ironic/+/980089 | 10:07 |
| janders | dtantsur cardoe I am thinking what's the best way forward with https://review.opendev.org/c/openstack/ironic/+/977569 | 10:08 |
| janders | (as well as the other two chained on top of it: https://review.opendev.org/c/openstack/ironic/+/978844 and https://review.opendev.org/c/openstack/ironic/+/979828) | 10:08 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Use shared lock for get_virtual_media conductor method https://review.opendev.org/c/openstack/ironic/+/980089 | 10:08 |
| janders | are you reasonably happy with the direction and would like to see some testing, or do we still have outstanding implementation concerns? | 10:08 |
| janders | we have someone on our side testing internally, it looks reasonably good in general but I am very much aware our downstream needs may be different | 10:09 |
| dtantsur | I still need to take a look in some break between meetings | 10:53 |
| janders | ACK+TY | 11:05 |
| opendevreview | Harald Jensås proposed openstack/sushy-tools master: novadriver: Add rescue-based virtual media support https://review.opendev.org/c/openstack/sushy-tools/+/980255 | 11:20 |
| opendevreview | Syed Haseeb Ahmed proposed openstack/ironic stable/2025.2: Support pluggable API middleware via entry points https://review.opendev.org/c/openstack/ironic/+/980211 | 11:39 |
| opendevreview | Harald Jensås proposed openstack/sushy-tools master: novadriver: Add rescue-based virtual media support https://review.opendev.org/c/openstack/sushy-tools/+/980255 | 11:58 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Dell iDRAC tasks show is_processing True when COMPLETED https://review.opendev.org/c/openstack/ironic/+/976657 | 12:20 |
| TheJulia | brraaaains | 14:00 |
| TheJulia | kubajj: hmm, good question, likely best to go to ints... | 14:41 |
| kubajj | TheJulia: ok, will do | 14:42 |
| * TheJulia makes more coffee to lead into the $NEXT meeting | 14:43 | |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Support ramdisk deploy with Glance image_source https://review.opendev.org/c/openstack/ironic/+/978828 | 16:06 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add ramdisk to autodetect deploy interface https://review.opendev.org/c/openstack/ironic/+/978829 | 16:06 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Enable ramdisk autodetect by default https://review.opendev.org/c/openstack/ironic/+/978602 | 16:06 |
| JayF | So so close! | 16:06 |
| JayF | Apparently leaving instance_info[image_source] around is a nogo, we have too much code that keys off it existing being a sentinel for direct deploy | 16:07 |
| dtantsur | yeah.... it's such a mess | 16:07 |
| JayF | Yeah, it's an especially unfortunate assumption given that I want us to make more and more of our alternate deploy interfaces available via Nova | 16:13 |
| JayF | Although at this point I think the only one left that might make sense would be anaconda | 16:14 |
| dtantsur | If deploy_utils was not so scary to touch, we would need to change all this guessing logic (incl. boot_option) to passing explicit parameters | 16:15 |
| JayF | I would be +1 to that being a PTG topic | 16:16 |
| JayF | something being scary to touch is the #1 sign that we should touch it and fix that | 16:17 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Support ramdisk deploy with Glance image_source https://review.opendev.org/c/openstack/ironic/+/978828 | 16:39 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Add ramdisk to autodetect deploy interface https://review.opendev.org/c/openstack/ironic/+/978829 | 16:39 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Enable ramdisk autodetect by default https://review.opendev.org/c/openstack/ironic/+/978602 | 16:39 |
| JayF | dtantsur: but wait; there's more! https://review.opendev.org/c/openstack/ironic/+/978828/5/ironic/drivers/modules/ramdisk.py (line 149) :( | 16:39 |
| dtantsur | a lot of sadness | 16:54 |
| JayF | Yeah, but at least given it's ramdisk driver it's less of a hassle to just pop off e.g. image_type | 16:55 |
| opendevreview | Julia Kreger proposed openstack/networking-baremetal master: fix: correct client ovs/ovn idl object creation https://review.opendev.org/c/openstack/networking-baremetal/+/980324 | 17:07 |
| TheJulia | I honestly don't think deploy_utils is that scary to touch, but it definitely has a blast radius if something is wrong | 17:16 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Correct disk-format in ramdisk boot docs https://review.opendev.org/c/openstack/ironic/+/980333 | 17:46 |
| JayF | those ramdisk changes have been tested working in the real world if folks get a chance to review them \o/ | 18:28 |
| TheJulia | cool cool | 18:54 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: Move multicast helper to device_utils. https://review.opendev.org/c/openstack/networking-generic-switch/+/980158 | 18:55 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: Arista eos multicast vxlan https://review.opendev.org/c/openstack/networking-generic-switch/+/980159 | 18:55 |
| JayF | TheJulia: fwiw I accidentally searched topic:ironic-week-prio instead of hashtag and like, a half dozen-ish of your patches popped up | 19:01 |
| TheJulia | le sigh and "DOH!" | 19:01 |
| JayF | (and one of mine from like a year ago lol) | 19:02 |
| JayF | ugh :( autodetect CI is busted and I gotta fix it for the top of my chain | 19:08 |
| JayF | we DO set enabled_deploy_interfaces but do NOT set autodetect_deploy_interfaces so adding a default blows up the job | 19:08 |
| JayF | I'm going to add a specific setting for autodetect interfaces to be set in devstack and then set it in my change | 19:09 |
| JayF | if I could get a quick review on the CI fix it'd be nice | 19:09 |
| * JayF should have it up in minutes | 19:09 | |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Set supported autodetect interfaces in devstack https://review.opendev.org/c/openstack/ironic/+/980341 | 19:12 |
| opendevreview | Harald Jensås proposed openstack/sushy-tools master: novadriver: Detect disk format from image content https://review.opendev.org/c/openstack/sushy-tools/+/980186 | 20:02 |
| cardoe | JayF: yeah that MAC function confused me too. | 20:17 |
| opendevreview | Merged openstack/ironic stable/2025.2: fix(redfish): correct submission of DateTime to BMC https://review.opendev.org/c/openstack/ironic/+/980177 | 20:22 |
| cardoe | JayF: so for the ramdisk... just wanted to ask.. container bare is correct? | 20:28 |
| cardoe | Also, did we deprecate the partition image? Maybe we treat this as the default mode? | 20:28 |
| JayF | cardoe: I don't know *2 | 20:31 |
| JayF | cardoe: it works using teh docs provided according to doug, excepting the one thing he asked me to correct | 20:32 |
| cardoe | heh. fair. | 20:32 |
| JayF | cardoe: with the caveat it was backported to caracal to test (it was clean, he assures me) | 20:32 |
| cardoe | It's very similar to my VMware Anaconda fork support. | 20:32 |
| JayF | Anaconda driver is probably the last "low hanging" deploy interface that could be added to autodetect | 20:33 |
| cardoe | Which I never got back to since we switched to packaging up their installer as a whole disk image that rewrites the disk its installed from. | 20:33 |
| cardoe | It's fruit hangs a little bit higher up than you might think. | 20:34 |
| JayF | if you say that more quietly someone might take the bait before they realize that :P | 20:34 |
| JayF | I have 0 use cases for anaconda deploy interface and won't pursue that personally, just thinking through stuff like ansible/custom-agent doesn't make sense, for instance | 20:34 |
| cardoe | There's a couple of things that make assumptions around the test setup of devstack. | 20:35 |
| cardoe | if I recall we download some stuff and it actually uses a different file than whats in glance but we happen to upload that same file to glance. | 20:35 |
| cardoe | This was back in the Sonnet 3 days and it couldn't reason its way out of that. | 20:36 |
| JayF | cardoe: https://review.opendev.org/c/openstack/ironic/+/980341 is a trivial review and will prevent the last in my chain of ramdisk cahnges from continuing to fail ci, if you got a sec | 20:36 |
| cardoe | +W'd | 20:38 |
| JayF | the ramdisk changes themselves would love a review too, I just wanted to get in front of the CI pain the last one is feeling | 20:38 |
| JayF | and that is only urgent in the sense that I want it in G :) | 20:38 |
| cardoe | Yeah I'm reviewing them now. | 20:39 |
| cardoe | since you commented on the MAC stuff... https://review.opendev.org/c/openstack/ironic/+/980180 that's actually the fix... I think I caught all the places and made the tests better. | 20:40 |
| JayF | it was open under review when I ran outta steam and took the dog for a walk | 20:40 |
| JayF | finishing the review is in queue | 20:40 |
| JayF | I almost suggested you get normalize_mac and validate_and_normalize_mac into oslo_utils.netutils but on the other hand, meh | 20:41 |
| cardoe | Not a bad idea. This close to the release I suspect that'll be tough. | 20:42 |
| JayF | Even if that was suggested, it wouldn't be blocking | 20:42 |
| JayF | it's past freeze for oslo stuff in current release | 20:42 |
| JayF | btw cardoe you might want https://review.opendev.org/c/openstack/oslo.utils/+/978997 downstream | 20:43 |
| opendevreview | Merged openstack/ironic master: Add group_and_attach_ports support to TBN https://review.opendev.org/c/openstack/ironic/+/980070 | 20:43 |
| cardoe | and here I was gonna enjoy a nice weekend at the lake and I see something like that. | 20:44 |
| JayF | with my VMT hat on, passwords in logs are considered hardening opportunities | 20:44 |
| JayF | I just thought about it when I realized it landed post-freeze so that won't hit until H | 20:45 |
| opendevreview | Merged openstack/ironic master: Dell iDRAC tasks show is_processing True when COMPLETED https://review.opendev.org/c/openstack/ironic/+/976657 | 20:57 |
| TheJulia | cardoe: w/r/t partition, I'm not sure if we officially deprecated it, but we basically said "don't use it, use whole disk images" | 21:13 |
| JayF | I will note, if you *wanted* to properly deprecate it | 21:36 |
| JayF | we'd need to add some logging and a release note and start a timer | 21:36 |
| cardoe | ah bummer | 22:13 |
| cardoe | Just was gonna say make your new thing the default behavior without the extra flag. | 22:13 |
| JayF | I am -1 to that, and commented to that effect in gerrit | 22:14 |
| JayF | I want autodetection driver support in an image to be explicitly opt-in | 22:14 |
| JayF | just to prevent an entire class of bug of "whoops these things are similarly shaped and now my deploy interface is getting swapped" | 22:15 |
| opendevreview | Merged openstack/ironic master: fix: MAC address handling was not always normalized https://review.opendev.org/c/openstack/ironic/+/980180 | 22:17 |
| opendevreview | Merged openstack/ironic master: remove dead code for normalize MAC https://review.opendev.org/c/openstack/ironic/+/980181 | 22:17 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2025.2: fix: MAC address handling was not always normalized https://review.opendev.org/c/openstack/ironic/+/980371 | 22:46 |
| opendevreview | Harald Jensås proposed openstack/networking-baremetal master: Use other_config for bridge-mapping lookup (OVN) https://review.opendev.org/c/openstack/networking-baremetal/+/980374 | 23:02 |
| opendevreview | Harald Jensås proposed openstack/networking-baremetal master: Allow hostname in l2vni_network_nodes.yaml config https://review.opendev.org/c/openstack/networking-baremetal/+/980375 | 23:02 |
| opendevreview | Clif Houck proposed openstack/ironic master: Update TBN docs for group_and_attach_ports https://review.opendev.org/c/openstack/ironic/+/980376 | 23:27 |
| opendevreview | Merged openstack/ironic master: Set supported autodetect interfaces in devstack https://review.opendev.org/c/openstack/ironic/+/980341 | 23:32 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!