| opendevreview | Merged openstack/sushy master: Add missing __init__.py https://review.opendev.org/c/openstack/sushy/+/980781 | 00:01 |
|---|---|---|
| janders | JayF dtantsur TheJulia big thanks for progressing my changes. Bloody timezones - sorry I couldn't have been more helpful in real-time. | 00:51 |
| JayF | Sleeping is your job when it's the night 😂 | 01:10 |
| JayF | Thanks for authoring them | 01:10 |
| opendevreview | Merged openstack/networking-generic-switch master: Move multicast helper to device_utils. https://review.opendev.org/c/openstack/networking-generic-switch/+/980158 | 03:16 |
| opendevreview | Merged openstack/networking-generic-switch master: Arista eos multicast vxlan https://review.opendev.org/c/openstack/networking-generic-switch/+/980159 | 04:19 |
| cardoe | dtantsur, TheJulia, JayF: I would talk about BMC credentials at the PTG. Cause it’s something we do on machine enrollment. | 05:13 |
| cardoe | So DMTF.org links to sushy right as we are about to nuke it? | 05:14 |
| TheJulia | Yup… | 05:14 |
| * TheJulia sleeps | 05:15 | |
| rpittau | good morning ironic! o/ | 07:52 |
| dtantsur | JayF: on the topic of what we discussed yesterday: I just got a clear request from an internal customer to support factory reset as a service step.. | 10:06 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Revert "Skipping UsbCd workaround on Supermicro ARS-111GL-NHR" https://review.opendev.org/c/openstack/sushy/+/981089 | 10:20 |
| dtantsur | TheJulia: https://review.opendev.org/c/openstack/ironic/+/980115 changes something invalid into something even less valid | 10:31 |
| dtantsur | now AgentInProgress is fatal during cleaning, which will cause intermittent failures | 10:32 |
| dtantsur | I really wonder if the initial version missed an 'except' block | 10:32 |
| dtantsur | rpittau: can we still hold off the release because of ^^? | 10:34 |
| dtantsur | https://opendev.org/openstack/ironic/commit/545dc2106b757e69d473c2997bbb2ac34fc131d3#diff-53903f258df599294452ac0dfaa81e02af1ad195 is where the broken version appeared, it also makes the initial intention clear | 10:36 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Do not raise in refresh_steps if the agent is busy during cleaning https://review.opendev.org/c/openstack/ironic/+/981090 | 10:45 |
| dtantsur | TheJulia, JayF, this needs to land in the final release ^^ | 10:45 |
| kubajj | dtantsur: do you want to return in the refresh_steps? - the comment said change to just raise | 10:50 |
| dtantsur | kubajj: the comment did not apply to the part, they were mangled together in the later change | 10:50 |
| kubajj | ah, I see | 10:51 |
| dtantsur | kubajj: it happened in https://opendev.org/openstack/ironic/commit/545dc2106b757e69d473c2997bbb2ac34fc131d3#diff-53903f258df599294452ac0dfaa81e02af1ad195 when the generic exception was replaced with a more specific one, but the code remained generic | 10:51 |
| rpittau | dtantsur: no problem, haven't proposed it yet | 11:13 |
| rpittau | the sable branch cut has been proposed though, but I see it has 2 -1 already | 11:37 |
| stephenfin | cardoe: I was out yesterday ☘️ but regarding your ironic.objects question: it could be prettier but this was how I tackled it in Nova https://github.com/openstack/nova/commit/c870873f7fbf0dec03a520f60423491cf9ecf64f | 12:13 |
| stephenfin | cardoe: On a related note, I also have a large rework of o.vo sitting locally that will allow us to define objects in a dataclass style rather than the current `fields` dict approach. Just need the "cleanup" patches (https://review.opendev.org/c/openstack/oslo.versionedobjects/+/979071 and on) to land first, since it's rather hefty | 12:16 |
| JayF | dtantsur: +2a | 12:25 |
| JayF | If you wanna babysit it in ci until my day actually starts 😂 | 12:26 |
| dtantsur | thx, will do! | 12:28 |
| opendevreview | Michal Nasiadka proposed openstack/bifrost master: Switch to Debian Trixie https://review.opendev.org/c/openstack/bifrost/+/979651 | 12:33 |
| opendevreview | Michal Nasiadka proposed openstack/bifrost master: Switch to Debian Trixie https://review.opendev.org/c/openstack/bifrost/+/979651 | 12:33 |
| TheJulia | dtantsur: JayF: that patch is failing pep8, its the left over exception variable | 13:22 |
| * TheJulia sighs | 13:24 | |
| opendevreview | Julia Kreger proposed openstack/ironic master: Do not raise in refresh_steps if the agent is busy during cleaning https://review.opendev.org/c/openstack/ironic/+/981090 | 13:25 |
| dtantsur | thx! | 13:25 |
| TheJulia | np | 13:27 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: api: add OpenAPI schemas for runbook controller https://review.opendev.org/c/openstack/ironic/+/981127 | 14:22 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/common/utils.py` https://review.opendev.org/c/openstack/python-ironicclient/+/978337 | 15:39 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/common/http.py` https://review.opendev.org/c/openstack/python-ironicclient/+/978917 | 15:46 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/events.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979924 | 15:53 |
| TheJulia | I added a link to our PTG etherpad, in terms of retrospetive regarding AI tool usage, we should likely summarize and direct feedback to: https://etherpad.opendev.org/p/apr2026-ptg-oif-board | 15:58 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/shard.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979925 | 16:00 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/utils.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979926 | 16:00 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/conductor.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979927 | 16:00 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/deploy_template.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979928 | 16:06 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/inspection_rule.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979929 | 16:06 |
| opendevreview | Verification of a change to openstack/ironic master failed: Do not raise in refresh_steps if the agent is busy during cleaning https://review.opendev.org/c/openstack/ironic/+/981090 | 16:07 |
| TheJulia | Rechecked htat last failure, quay download failed | 16:09 |
| JayF | fastest recheck in the west | 16:09 |
| JayF | lol | 16:09 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/runbook.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979930 | 16:09 |
| anandkaranubc | Hi everyone, as some of you may have noticed, we are working on type annotations for the Python Ironic client. We are almost 60–70% done with the production code. After this, do people think we should add type annotations to the unit tests, or should we start a new project? cc: Jay, CID | 16:09 |
| JayF | cardoe: ^ you are one of the only folks I can think of who might have an opinion | 16:09 |
| JayF | I am unsure if there is special value or not in having unit tests do type checking, I'm hoping someone has actual-knowledge on this | 16:10 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/volume_connector.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979931 | 16:17 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/volume_target.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979932 | 16:17 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/client.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979933 | 16:17 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/port.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979934 | 16:17 |
| dtantsur | is Juniper ex4400-48t working with n-g-s, does anyone know by chance? | 16:31 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/driver.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979935 | 16:34 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/allocation.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979936 | 16:36 |
| opendevreview | Merged openstack/python-ironicclient master: Add type annotations to `ironicclient/v1/chassis.py` https://review.opendev.org/c/openstack/python-ironicclient/+/979937 | 16:36 |
| opendevreview | Verification of a change to openstack/ironic master failed: Do not raise in refresh_steps if the agent is busy during cleaning https://review.opendev.org/c/openstack/ironic/+/981090 | 16:36 |
| cardoe | anandkaranubc, JayF: I think maybe for test fixtures or mocks it would be good. Because that'll help identify where our fixture or mock doesn't match the actual object interface. That's something that's bitten us before. | 16:36 |
| cardoe | I've actually submitted a handful of patches to neutron showing where neutron-lib provided object differs from the actual Mock'd thing in the neutron code base. | 16:37 |
| JayF | that's exactly the sorta info I didn't have that I wanted to know | 16:41 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: api: add OpenAPI schemas for runbook controller https://review.opendev.org/c/openstack/ironic/+/981127 | 16:50 |
| anandkaranubc | Perfect! Thanks for the feedback cardoe. test fixtures it is then! | 16:56 |
| TheJulia | dtantsur: I'd assume it should work since I think it is a Junos based device | 17:25 |
| cardoe | stephenfin: that looks awesome. | 17:50 |
| opendevreview | Merged openstack/ironic master: Do not raise in refresh_steps if the agent is busy during cleaning https://review.opendev.org/c/openstack/ironic/+/981090 | 18:46 |
| * TheJulia ponders slides | 18:54 | |
| TheJulia | okay, we can release! | 18:54 |
| TheJulia | rpittau: I pushed an update to https://review.opendev.org/c/openstack/releases/+/980969 based upon current ironic master | 20:30 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: Add Cumulus NVUE multicast BUM replication support https://review.opendev.org/c/openstack/networking-generic-switch/+/981018 | 21:39 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: Add SONiC multicast BUM configuration validation https://review.opendev.org/c/openstack/networking-generic-switch/+/981193 | 22:19 |
| cardoe | Do we need to adjust any CI tests to use branches or turn things off? | 22:46 |
| JayF | once the branch is struck, things like the tempest-plugin need the new stable added and oldest one removed (depending on slurp support timelines) | 22:53 |
| JayF | I think we need to remove e.g. metal3-integration on the stable branch itself when we get there, too | 22:53 |
| cardoe | anandkaranubc: We should also include a py.typed file in python-ironicclient since its now typed. | 23:15 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!