| opendevreview | Doug Goldstein proposed openstack/python-ironicclient master: remove dangling functional test https://review.opendev.org/c/openstack/python-ironicclient/+/981200 | 01:10 |
|---|---|---|
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient master: change typing enforcement to be more strict https://review.opendev.org/c/openstack/python-ironicclient/+/981201 | 01:10 |
| cardoe | anandkaranubc, JayF: have a look at ^ I've inverted the approach from opt in to opt out | 01:11 |
| cardoe | We still need to convert setup.cfg to pyproject.toml and then switch to using more pre-commit | 01:14 |
| TheJulia | Oh, for ironicclient, yeah… | 01:42 |
| JayF | cardoe: I don't think he's 100% done yet with module code | 03:21 |
| cardoe | I mean it passes. | 03:21 |
| JayF | If you look, we are adding files one at a time to the allow list in CI | 03:22 |
| JayF | We haven't flipped the big switch yet and won't until it's all done | 03:22 |
| cardoe | Yeah. And it’s done for everything in the ironicclient directory except the tests. | 03:22 |
| cardoe | Now someone cannot add a new file to the client without having it typed. | 03:24 |
| cardoe | I was just trying to look at what was left since you asked. | 03:24 |
| cardoe | And rather than only checking certain files it checks the whole directory and then only skips specific checks on specific files. | 03:24 |
| cardoe | Just trying to be supportive so it’s clear what’s left and that we don’t regress. | 03:29 |
| cardoe | anandkaranubc did great and got it solid. | 03:31 |
| rpittau | good morning ironic! o/ | 08:12 |
| rpittau | TheJulia: ack checking | 08:12 |
| rpittau | and yes, we can release | 08:14 |
| rpittau | I've notcied we're missing the IPA cut, I'll propose the release as we don't ave outstanding open patches | 08:14 |
| rpittau | ah nvm it's all the same patch, just missed it :D | 08:15 |
| opendevreview | Merged openstack/ironic stable/2025.2: fix: MAC address handling was not always normalized https://review.opendev.org/c/openstack/ironic/+/980371 | 09:27 |
| stephenfin | anandkaranubc: JayF: cardoe: I left some small comments on the last patch of the typing series https://review.opendev.org/c/openstack/python-ironicclient/+/979937 | 10:00 |
| stephenfin | I'll also add it to https://that.guru/blog/are-we-typed-yet/ | 10:01 |
| stephenfin | cardoe: One of my comments on touches on your tests point above. tl;dr: mypy works better if you either (a) enable incremental checking across the whole code base and then opt-in to stricter checks for the modules you've type hinted, or (b) enable strict checking across the whole code base and opt-out for modules you're not type hinting (like tests) | 10:04 |
| stephenfin | For larger code bases, I usually start with the former and work my way to the latter. For smaller code bases (e.g. oslo.i18n), it's often possible to go straight to the latter | 10:05 |
| opendevreview | cid proposed openstack/ironic stable/2025.1: Add credential handling into console path https://review.opendev.org/c/openstack/ironic/+/976510 | 10:20 |
| opendevreview | cid proposed openstack/ironic stable/2025.2: Add credential handling into console path https://review.opendev.org/c/openstack/ironic/+/976509 | 10:28 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Migrate setup configuration to pyproject.toml https://review.opendev.org/c/openstack/python-ironicclient/+/981226 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Migrate coverage configuration to pyproject https://review.opendev.org/c/openstack/python-ironicclient/+/981227 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Run mypy from tox https://review.opendev.org/c/openstack/python-ironicclient/+/981228 | 10:31 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Migrate setup configuration to pyproject.toml https://review.opendev.org/c/openstack/python-ironicclient/+/981226 | 11:40 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Migrate coverage configuration to pyproject https://review.opendev.org/c/openstack/python-ironicclient/+/981227 | 11:40 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Run mypy from tox https://review.opendev.org/c/openstack/python-ironicclient/+/981228 | 11:40 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: WIP: mypy: Enable strict mode https://review.opendev.org/c/openstack/python-ironicclient/+/981234 | 11:40 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Revert "Skipping UsbCd workaround on Supermicro ARS-111GL-NHR" https://review.opendev.org/c/openstack/sushy/+/981089 | 11:42 |
| opendevreview | Stephen Finucane proposed openstack/python-ironicclient master: Replace deprecated typing imports https://review.opendev.org/c/openstack/python-ironicclient/+/981238 | 11:59 |
| JayF | stephenfin: just FYI, we currently have an MLH fellow working on typing for the client. Please coordinate with anandkaranubc (and try not to complete his project before he can) 😂 | 12:52 |
| stephenfin | JayF: Yup, don't worry: I left quite a few review comments on his patches and have intentionally *not* done anything further on https://review.opendev.org/c/openstack/python-ironicclient/+/981234 (which was really an alternative to cardoe's patch at https://review.opendev.org/c/openstack/python-ironicclient/+/981201) | 12:54 |
| JayF | Awesome. I was hoping you had found what he had been working on and was commenting on them as well | 12:55 |
| JayF | I 100% believe that you will have some insights there that we won't and I'm glad that you took a look | 12:55 |
| stephenfin | sure did | 12:55 |
| stephenfin | On a related note, anandkaranubc: happy to help with any typing questions you might have, particularly as they relate to things like OSC and osc-lib. Assuming you plan to add hints to the osc extension as some point, you probably want to look at https://review.opendev.org/c/openstack/python-openstackclient/+/970681 and above | 12:58 |
| cardoe | stephenfin: yes and my change was to enable strict checking across the whole code base and then opt out some checks on the tests. | 13:10 |
| cardoe | Your suggestions to my change are even less strict than what I proposed. | 13:12 |
| cardoe | You suggested moving from ignoring one check on tests to an ignore across the whole code base. | 13:12 |
| cardoe | Then another check that only fails on some tests files which I only ignored on those files you suggest to ignore across all tests. | 13:13 |
| cardoe | Your -1 is also for things I didn’t touch or do. ignore_missing_imports = true is already in there and untouched by me. And the usage of pre-commit is already there. | 13:18 |
| cardoe | I also agree that type checking doesn’t work via pre-commit. prek fixes one of the issues but we don’t use that. | 13:25 |
| stephenfin | cardoe: you're referring to https://review.opendev.org/c/openstack/python-ironicclient/+/981234/1/pyproject.toml#196 I assume? | 13:27 |
| stephenfin | If so, that can definitely be more granular, as you've proposed. It's a WIP patch for a reason :) | 13:28 |
| stephenfin | If so, that can definitely be more granular, as you've proposed. It's a WIP patch for a reason :) | 13:28 |
| cardoe | Referring to https://review.opendev.org/c/openstack/python-ironicclient/+/981201 | 13:29 |
| stephenfin | Oh, no, that's significantly stricter for the main code base. I'm suggesting setting `strict = true` which enables a whole load of other options that are not currently being set https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-strict | 13:30 |
| stephenfin | Oh, no, that's significantly stricter for the main code base. I'm suggesting setting `strict = true` which enables a whole load of other options that are not currently being set https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-strict | 13:30 |
| stephenfin | (apologies for any duplicate messages: something's janky with my connectivity atm 😕) | 13:31 |
| cardoe | I did | 13:33 |
| opendevreview | Harald Jensås proposed openstack/networking-generic-switch master: Cisco NX-OS: Enable suppress-arp for VNI members https://review.opendev.org/c/openstack/networking-generic-switch/+/981262 | 13:54 |
| opendevreview | Harald Jensås proposed openstack/networking-generic-switch master: Cisco NX-OS: Enable suppress-arp for VNI members https://review.opendev.org/c/openstack/networking-generic-switch/+/981262 | 14:12 |
| opendevreview | OpenStack Release Bot proposed openstack/bifrost stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/bifrost/+/981268 | 14:20 |
| opendevreview | OpenStack Release Bot proposed openstack/bifrost stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/bifrost/+/981269 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/bifrost master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/bifrost/+/981270 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-prometheus-exporter stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/981271 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-prometheus-exporter stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/981272 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-prometheus-exporter master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/981273 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-python-agent-builder stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/981274 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-python-agent-builder stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/981275 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-python-agent-builder master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/981276 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-python-agent stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/981277 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-python-agent stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/981278 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-python-agent master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/981279 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-ui stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic-ui/+/981280 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-ui stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic-ui/+/981281 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic-ui master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic-ui/+/981282 | 14:21 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic/+/981283 | 14:23 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic/+/981284 | 14:23 |
| opendevreview | OpenStack Release Bot proposed openstack/ironic master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic/+/981285 | 14:23 |
| opendevreview | OpenStack Release Bot proposed openstack/networking-baremetal stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/networking-baremetal/+/981286 | 14:24 |
| opendevreview | OpenStack Release Bot proposed openstack/networking-baremetal stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/networking-baremetal/+/981287 | 14:24 |
| opendevreview | OpenStack Release Bot proposed openstack/networking-baremetal master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/networking-baremetal/+/981288 | 14:24 |
| opendevreview | OpenStack Release Bot proposed openstack/networking-generic-switch stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/networking-generic-switch/+/981289 | 14:24 |
| opendevreview | OpenStack Release Bot proposed openstack/networking-generic-switch stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/networking-generic-switch/+/981290 | 14:24 |
| opendevreview | OpenStack Release Bot proposed openstack/networking-generic-switch master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/networking-generic-switch/+/981291 | 14:24 |
| JayF | Release the hound^W softwares! | 14:32 |
| TheJulia | lol | 14:44 |
| kubajj | there is ironic-ui? 👀 | 14:53 |
| dtantsur | kind of. very much on life support | 14:54 |
| opendevreview | Merged openstack/networking-generic-switch master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/networking-generic-switch/+/981291 | 14:54 |
| TheJulia | claude seems to grok it though, but few seem interested in contributing to horizony things | 14:54 |
| dtantsur | even fewer get paid for that :) | 14:54 |
| TheJulia | yup | 14:55 |
| JayF | The amount I've been tempted to point Claude at the UI is a lot, but then I would violate all my own premises of having to understand a problem space before pushing code to fix it | 14:56 |
| JayF | And then the little demon on my shoulder says "it's just frontend" (The demon is a rude little bugger who doesn't respect the difficulty of work he doesn't understand) 😂 | 14:56 |
| opendevreview | Merged openstack/networking-generic-switch stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/networking-generic-switch/+/981289 | 14:57 |
| TheJulia | Who do I suggest to feed the demon cookies? | 15:02 |
| JayF | I'll feed my little kitty criminal a cookie instead. She's the closest thing to a corporeal demon in the house 😂 | 15:06 |
| JayF | I actually followed through and gave her a treat as promised https://usercontent.irccloud-cdn.com/file/tqEYB3YC/irccloudcapture2004669597734219239.jpg | 15:07 |
| TheJulia | oh, she looks like the cutest trouble! | 15:09 |
| opendevreview | Merged openstack/networking-generic-switch stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/networking-generic-switch/+/981290 | 15:13 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/981276 | 15:15 |
| opendevreview | Merged openstack/ironic-python-agent stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/981277 | 15:16 |
| JayF | TheJulia: we adopted her at about 2 years old back in December to be a companion for Aeon (😥) but her life before was 100% as an outdoor stray. She's domesticating well, but contains many more crimes than are average previous Kitty | 15:17 |
| JayF | (one benefit of such a food-motivated cat: we've already taught her "touch" and "sit") | 15:18 |
| TheJulia | nice! | 15:18 |
| opendevreview | Merged openstack/ironic-prometheus-exporter stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/981271 | 15:19 |
| opendevreview | Merged openstack/ironic-ui stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic-ui/+/981280 | 15:20 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: Add Juniper Junos multicast BUM replication support https://review.opendev.org/c/openstack/networking-generic-switch/+/981307 | 15:20 |
| opendevreview | Merged openstack/networking-baremetal stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/networking-baremetal/+/981286 | 15:21 |
| opendevreview | Merged openstack/ironic-python-agent stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/981278 | 15:22 |
| opendevreview | Merged openstack/ironic-python-agent master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/981279 | 15:22 |
| opendevreview | Merged openstack/networking-baremetal stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/networking-baremetal/+/981287 | 15:23 |
| opendevreview | Merged openstack/ironic-prometheus-exporter stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/981272 | 15:23 |
| opendevreview | Merged openstack/bifrost master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/bifrost/+/981270 | 15:24 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/981274 | 15:24 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/981275 | 15:24 |
| opendevreview | Merged openstack/ironic-prometheus-exporter master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/981273 | 15:25 |
| opendevreview | Merged openstack/networking-baremetal master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/networking-baremetal/+/981288 | 15:27 |
| opendevreview | Merged openstack/ironic master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic/+/981285 | 15:27 |
| opendevreview | Merged openstack/ironic-ui stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/ironic-ui/+/981281 | 15:28 |
| opendevreview | Merged openstack/ironic-ui master: Update master for stable/2026.1 https://review.opendev.org/c/openstack/ironic-ui/+/981282 | 15:28 |
| * TheJulia tasks the LLM with drafting new documentation structure for NGS | 15:48 | |
| dtantsur | I know some people hate the idea of AI-written docs, but honestly... lesser evil, amiright? | 15:49 |
| TheJulia | I mean, at some point, asking it to take a bunch of loosly connected docs and make it better is not a bad thing | 15:49 |
| JayF | Bluntly, the bigger issue I've had in the past with AI generated docs (openstack and elsewhere) is I've read/reviewed some that didn't look like the human read/reviewed them | 15:50 |
| JayF | as long as we are sure things are accurate and people are reviewing things, lets go for it | 15:50 |
| * dtantsur agrees | 15:50 | |
| TheJulia | Yeah, One thing I'm trying to stress is "be less pedantic" | 15:50 |
| dtantsur | I'll take "AI-written, human checked" docs over no/bad docs on any day | 15:52 |
| dtantsur | (and I know that I mostly produce bad docs myself lol) | 15:52 |
| rpittau | I put myself there too :D | 15:53 |
| victor_obi_ | Hi, I'm Victor, a prospective Outreachy contributor. I've just commented on bug #2097659 (insert into node_history table can exceed event column size) and plan to fix it using Julia's suggested truncation approach. Any guidance before I start? | 17:16 |
| TheJulia | Greetings victor_obi_, unfortunately I don't remember, but I guess a good start would be to see what the current state of the database schema definition is in ironic/db/ folder structure. | 17:28 |
| victor_obi_ | Noted, thank you. | 17:29 |
| JayF | TheJulia: we do have that docs audit that gr funded a while ago. I wonder if that could be used to prompt the AI to improve things | 17:50 |
| TheJulia | Might make sense in a wider scope, I'm just trying to dig us out of some of the impact on n-g-s that we've created as of recent | 17:58 |
| TheJulia | which was after that | 17:58 |
| JayF | I'm just thinking for executing that on ironic docs. In general. It never occurred to me until now that that would be a good start for an AI plan | 18:24 |
| TheJulia | heh | 18:29 |
| opendevreview | Victor proposed openstack/ironic master: Truncate node history event to avoid DB column overflow https://review.opendev.org/c/openstack/ironic/+/981399 | 19:15 |
| victor_obi | I just submitted my first contribution fixing bug #2097659 (node_history event column overflow): https://review.opendev.org/c/openstack/ironic/+/981399,all feedbacks are welcome | 19:23 |
| opendevreview | Luke Odom proposed openstack/ironic-python-agent master: Fix ESP relocation to RAID device using filesystem copy https://review.opendev.org/c/openstack/ironic-python-agent/+/981403 | 20:05 |
| TheJulia | victor_obi: thanks! | 20:08 |
| victor_obi | I 'm also looking at bug #2131973 (vif_attach/vif_detach should log failures to node history). Just posted on the bug page. | 20:09 |
| JayF | in that case, I'll review 981399 now | 20:11 |
| JayF | so if there's any systemmatic feedback you can incorporate | 20:11 |
| TheJulia | victor_obi: out of curiosity, are you using any ai assistive tooling? There is no wrong answer to this question, but wanted to ask to help scope my review feedback. Thanks in advance | 20:12 |
| TheJulia | "meowmeowmeowmeow" <3 | 20:14 |
| victor_obi | I use claude or gemini when I'm stuck | 20:15 |
| TheJulia | It is reminiscent of a youtuber who has a t-shirt that starts with "you are a:" and the next line which repeats is "cat cat cat cat" | 20:15 |
| JayF | victor_obi: -1 is for the comment I put on the commit message, not my meandering one about [event trimmed] | 20:15 |
| JayF | victor_obi: yeah, that means you need to add "Assisted-by: Gemini" or "Assisted-by: Claude" -- we track use of AI | 20:15 |
| victor_obi | Noted, thank you. | 20:16 |
| TheJulia | Yeah, I made a similar comment and asked for a release note | 20:21 |
| TheJulia | .... Okay, who stole my brain | 20:27 |
| TheJulia | I <3 that dreamhost patch | 20:29 |
| JayF | oh crap, that's awesome | 20:30 |
| JayF | they implemented the manual raid sync in ipa | 20:30 |
| JayF | now I just have to unearth my mdadm knowledge to review it | 20:30 |
| JayF | and it's DEEP buried these days lol | 20:30 |
| TheJulia | eh, its more on the command side of the copy I think | 20:34 |
| opendevreview | Victor proposed openstack/ironic master: Truncate node history event to avoid DB column overflow https://review.opendev.org/c/openstack/ironic/+/981399 | 20:40 |
| opendevreview | Luke Odom proposed openstack/ironic-python-agent master: Fix ESP relocation to RAID device using filesystem copy https://review.opendev.org/c/openstack/ironic-python-agent/+/981403 | 20:46 |
| Glimmr_ | Hello, not sure if I'm right here, but this is the official openstack community place, right? Would this be the best place for getting help in understanding certain parts about ironic? | 20:55 |
| victor_obi | TheJulia, JayF: Thank you for the guidance. I've added the Assisted-by tag and fixed the NOTE format. Apologies for not disclosing upfront. | 21:05 |
| TheJulia | Glimmr_: Greetings and welcome! Most likely this is the right place! | 21:05 |
| TheJulia | victor_obi: you might need to re-run "git review" because the latest uploaded change doesn't have the tag | 21:07 |
| opendevreview | Victor proposed openstack/ironic master: Truncate node history event to avoid DB column overflow https://review.opendev.org/c/openstack/ironic/+/981399 | 21:08 |
| victor_obi | TheJulia: Thanks for noticing, I've rerun git review, i had to run git stash first | 21:09 |
| TheJulia | There it is, hopefully what you had to stash was a different change ? | 21:10 |
| victor_obi | Yes | 21:12 |
| Glimmr_ | Ok, I think I got IRC to work, not sure if my last message was sent or not. | 21:39 |
| Glimmr_ | I'm trying to figure out the GT condition operator on inspection rules. I try to compare a value from the inventory (physical memory) with static value (e.g. 50 gb) but cannot get the interpolation to work. I probably either don't understand the usage or am still missing information on how to properly access an inventory value there. | 21:39 |
| Glimmr_ | I'm sorry if I sent this twice (not sure I did) and appreciate the help | 21:39 |
| opendevreview | Victor proposed openstack/ironic master: Record VIF attach/detach failures in node history https://review.opendev.org/c/openstack/ironic/+/981414 | 21:54 |
| victor_obi | Submitted a patch: https://review.opendev.org/c/openstack/ironic/+/981414 | 21:55 |
| cardoe | Glimmr_: inspection rules in ironic inspector or the inspection rules merged into Ironic proper? | 22:12 |
| cardoe | Glimmr_: I've been trying to use the ones in Ironic proper myself and have been hitting some bumps. I wrote a helper tool thats in tools/inspection_rules/tester.py that I would look at. | 22:13 |
| opendevreview | Julia Kreger proposed openstack/networking-generic-switch master: Restructure admin documentation by topic and vendor https://review.opendev.org/c/openstack/networking-generic-switch/+/981418 | 23:05 |
| Glimmr_ | cardoe: I think it's in ironic proper, not the inspector. Thanks, I will look into that helper tomorrow. | 23:09 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
