*** caphrim007 has joined #openstack-jjb | 03:54 | |
*** hashar has joined #openstack-jjb | 06:36 | |
*** electrofelix has joined #openstack-jjb | 08:40 | |
*** hashar is now known as hasharAway | 09:48 | |
*** hasharAway has quit IRC | 12:05 | |
*** caphrim007 has quit IRC | 14:47 | |
*** caphrim007 has joined #openstack-jjb | 14:48 | |
*** openstackgerrit has joined #openstack-jjb | 15:02 | |
openstackgerrit | Akshat Tandon proposed openstack/python-jenkins master: Adds support for multi-select build parameters https://review.openstack.org/517361 | 15:02 |
---|---|---|
ssbarnea | electrofelix: can you please check https://review.openstack.org/#/c/559141/ -- i want a second vote on it. | 15:07 |
zxiiro | ssbarnea: would you be comfortable taking the lead on python-jenkins and handling releases etc.. for that project? I figure since you've been doing the most work on it. | 15:14 |
ssbarnea | zxiiro: sure. i suspect i should be able to make a release on Friday or next week. The number of open CRs went very low. | 15:16 |
ssbarnea | zxiiro: the SSL hack one is really hot as it prevents me from using jjb but I am waiting for another vote on it. | 15:17 |
zxiiro | oh yeah down to 1 page | 15:17 |
zxiiro | 1 page of reviews* | 15:17 |
zxiiro | that's awesome | 15:17 |
zxiiro | I was happy when we got JJB down to just 4 pages (used to be like 10 | 15:17 |
electrofelix | approved | 15:17 |
ssbarnea | zxiiro: well, I did abandon some outdated ones, but we should continue to do the same with jjb. if review not fixed in one month, we can abandon it. better to keep the queue small. | 15:18 |
ssbarnea | electrofelix: thanks. | 15:18 |
zxiiro | ssbarnea: I kinda disagree with abandoning patches that can be saved / updated. We've seen situations where 3 year old patches eventually got resolved and merged. | 15:19 |
ssbarnea | i also observed that people started to update their CRs, i guess the fact that they observed activity did also motivate them to refresh their old CRs. | 15:19 |
zxiiro | ssbarnea: Also I usually get students to work on the convert_mapping_to_xml stuff which I usually only get a student once a year. | 15:19 |
ssbarnea | zxiiro: yep, it is a gray area. decision should always be made using common sense. | 15:20 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Include view url in logs when possible https://review.openstack.org/559307 | 15:20 |
zxiiro | yep. sometimes a reminder helps. | 15:20 |
ssbarnea | abandon does not mean lost, can be revived but yeah. one good example was the multibranch one, took almost 3 years. | 15:20 |
zxiiro | ssbarnea: I'll try to get Kien to fix the convert_mapping_to_xml patches that he and Yolanda did. I'd love to get them all in. | 15:21 |
ssbarnea | zxiiro: you just gave me an idea,... maybe I can persuade few students from the local university. | 15:21 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Replace testr with stestr https://review.openstack.org/558917 | 15:22 |
zxiiro | ssbarnea: yeah JJB's an awesome proejct for students imo. there's lots of easy work to do and can give them experience with open source. I typically prefer students who are beginner level to work on JJB compared to students who have lots of code experience (they should work on harder projects imo). | 15:23 |
zxiiro | we had a reorg this year so I'm not sure if I'll get funding for another student this summer but we'll see :) | 15:24 |
electrofelix | have we lost the jobs for python-jenkins? | 15:25 |
electrofelix | ah, never mind, UI change | 15:25 |
zxiiro | Patch Set 1: -Verified Starting gate jobs. | 15:25 |
zxiiro | on that one you just approved | 15:25 |
zxiiro | yeah have to click that Toggle CI button. | 15:26 |
electrofelix | was https://review.openstack.org/#/c/517361/3 I was looking at, I'm guessing zuul is a bit busy | 15:26 |
zxiiro | ah yeah | 15:26 |
zxiiro | I've had patches that came back verified 1 week later before. it's crazy | 15:26 |
ssbarnea | one thing that I observed zuul will not test jobs that have old base, i had to rebase few times to make it build. It does nothing, | 15:27 |
electrofelix | I suspect https://review.openstack.org/517361 will fail the pep8 test once it's ran | 15:30 |
ssbarnea | yep, where is the pypy? | 15:31 |
openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Adding pypy to bindep test profile https://review.openstack.org/560475 | 15:44 |
openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Adding pypy to bindep test profile https://review.openstack.org/560475 | 15:56 |
ssbarnea | electrofelix: zxiiro ^^ that pypy change should fix the gate. vote it on https://review.openstack.org/#/c/560475/ so we see it it passed the gate. | 15:57 |
zxiiro | ssbarnea: done | 15:58 |
*** electrofelix has quit IRC | 16:53 | |
*** hashar has joined #openstack-jjb | 17:38 | |
openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Enables use of PYTHONHTTPSVERIFY override https://review.openstack.org/559141 | 18:09 |
openstackgerrit | Merged openstack/python-jenkins master: Enables use of PYTHONHTTPSVERIFY override https://review.openstack.org/559141 | 18:39 |
*** hashar has quit IRC | 21:36 | |
openstackgerrit | Inaky Perez-Gonzalez proposed openstack-infra/jenkins-job-builder master: wrappers: fix XML node name for scrip-env's only-run-on-parent https://review.openstack.org/560684 | 23:07 |
openstackgerrit | Inaky Perez-Gonzalez proposed openstack-infra/jenkins-job-builder master: parameters/label: add missing parameters https://review.openstack.org/560685 | 23:07 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!