| openstackgerrit | Merged openstack/python-jenkins master: Adding pypy to bindep test profile https://review.openstack.org/560475 | 00:57 |
|---|---|---|
| *** openstackgerrit has quit IRC | 05:48 | |
| *** caphrim007 has quit IRC | 06:43 | |
| *** caphrim007 has joined #openstack-jjb | 06:44 | |
| *** hashar has joined #openstack-jjb | 06:51 | |
| *** electrofelix has joined #openstack-jjb | 07:24 | |
| *** openstackgerrit has joined #openstack-jjb | 09:27 | |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: avoid multiple ssl warnings on each request https://review.openstack.org/560842 | 09:27 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: avoid multiple ssl warnings on each request https://review.openstack.org/560842 | 09:43 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Improve SSL support with requests lib https://review.openstack.org/560842 | 10:26 |
| ssbarnea | electrofelix: ^^ that one would be critical before any new release. I was wondering why REQUESTS_CA_BUNDLE was working on other projects but not with python-jenkins. | 10:39 |
| ssbarnea | the python-jenkins will need further refactoring to simplify the http code in the future. our own wrapper caused this. | 10:40 |
| openstackgerrit | Akshat Tandon proposed openstack/python-jenkins master: Adds support for multi-select build parameters https://review.openstack.org/517361 | 10:43 |
| electrofelix | Presumably the issue is caused by us explicitly setting 'verify' on the request? would have thought it would be better if we can avoid needing to inspect variables used by requests and instead work out a way to allow the default behaviour to occur unless explicitly overridden, I'd like to have a dig into the requests code to see why we need to set the verify explicitly on each 'send()' call instead of only needing to set it on the session as neede | 11:01 |
| *** caphrim007 has quit IRC | 13:45 | |
| *** caphrim007 has joined #openstack-jjb | 15:38 | |
| *** caphrim007 has quit IRC | 15:42 | |
| *** caphrim007 has joined #openstack-jjb | 15:42 | |
| *** caphrim007 has quit IRC | 15:42 | |
| openstackgerrit | Andrew Mellen proposed openstack-infra/jenkins-job-builder master: Sort views list jobs https://review.openstack.org/560945 | 15:42 |
| *** caphrim007 has joined #openstack-jjb | 15:43 | |
| ssbarnea | electrofelix: yep, you pointed the same thing I was thinking about. Mainly to do this I would have to add extra code to the library in order to decide if it should perform calls with verify param or without it because there is no value that we can use that would tell requests to "use default behavior". | 16:29 |
| ssbarnea | electrofelix: if you think is important i will try to fix it now. one way or another we need to cover for the custom SSL case. | 16:30 |
| electrofelix | ssbarnea: https://github.com/requests/requests/blob/d2e1130603c67d278eb49980205a3797e9e8b4a3/requests/sessions.py#L602 suggests that if we only set self._session.verify when we need to, it should be supplied to the send request | 16:44 |
| ssbarnea | electrofelix: true, but there are some bugs, i am rewriting the code anyway. see https://github.com/requests/requests/issues/3829 | 16:51 |
| ssbarnea | clearly it can be done much better than now. | 16:52 |
| electrofelix | hmm, guess that means it has to be explicitly set, so the solution might be to add a dict args = {'verify': <value>} in the case that self._session.verify is not 'True' and use the splat operator to add it to the send() call so it only gets added when explicitly set? | 16:56 |
| electrofelix | that would ensure it forces it to False for all requests when set explicitly and otherwise defaults to relying on requests behaviour? | 16:58 |
| *** electrofelix has quit IRC | 17:06 | |
| *** hashar is now known as hasharAway | 17:11 | |
| *** frayedknot has joined #openstack-jjb | 18:17 | |
| frayedknot | Is there a way to override a build parameter that is specified in a job-template? | 18:18 |
| frayedknot | I'm referring to the parameters module | 18:18 |
| *** openstackgerrit has quit IRC | 18:19 | |
| *** openstackgerrit has joined #openstack-jjb | 18:22 | |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Improve SSL support with requests lib https://review.openstack.org/560842 | 18:22 |
| ssbarnea | zxiiro: ^^ please have a look at the SSL fix. It became a little bit ugly but this is due to bugs/undocumented behaviours in request library. | 18:25 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add support for view-templates https://review.openstack.org/395716 | 18:54 |
| *** frayedknot has quit IRC | 18:59 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Delete old managed folders when calling update subcommand with --delete-old option https://review.openstack.org/519404 | 19:08 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add helper tag to join arbitrary lists into strings https://review.openstack.org/265926 | 19:10 |
| zxiiro | ssbarnea: I'm really swamped with stuff right now. I'll try to look at it later tonight. | 19:12 |
| ssbarnea | zxiiro: perfect. | 19:13 |
| *** frayedknot has joined #openstack-jjb | 19:14 | |
| zxiiro | frayedknot: yes, you define a variable in the template. and then override that variable in the project section. | 19:15 |
| frayedknot | and then use that variable for the parameter's default value? | 19:16 |
| zxiiro | frayedknot: here's an example. https://github.com/lfit/releng-global-jjb/blob/master/jjb/lf-maven-jobs.yaml#L154-L172 | 19:16 |
| frayedknot | I'm talking about these guys: https://docs.openstack.org/infra/jenkins-job-builder/parameters.html | 19:16 |
| zxiiro | frayedknot: yep. even those guys can follow this pattern. | 19:17 |
| zxiiro | frayedknot: so if you look at my example. Things under "Job Configuration" create variables. Things in "Default Parameters" are defaults if no one configures them in their local project setting. | 19:17 |
| frayedknot | hmm...ok. I tried redefining a parameter's default in the project and it ended up just using the template's value and not the project's value | 19:17 |
| zxiiro | frayedknot: what's your template look like? | 19:18 |
| zxiiro | frayedknot: here's a minimal example: https://pastebin.com/52zpxv7V | 19:20 |
| frayedknot | zxiiro: https://pastebin.com/jU0M58Tx | 19:22 |
| zxiiro | frayedknot: so instead of default: false you need to turn default into a variable | 19:22 |
| zxiiro | frayedknot: default: '{bool-var}' | 19:22 |
| frayedknot | ahh! I get it now, that makes sense | 19:23 |
| frayedknot | thanks much | 19:23 |
| zxiiro | frayedknot: and then if you want it to have a default in the job template define 'bool-var: false' above that. | 19:23 |
| zxiiro | frayedknot: np :) | 19:23 |
| zxiiro | frayedknot: also something that might throw you off, variable priority is as follows. job-group > project > job-template > defaults | 19:24 |
| zxiiro | frayedknot: so if you're using a "defaults" file it has the absolute lowest priority so a definition in job-templates also overrides it. | 19:24 |
| zxiiro | personally I don't agree with that behaviour but apparently some folks use it. | 19:24 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: gitlab trigger: add support for different MR events https://review.openstack.org/513712 | 19:42 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add helper tag to join arbitrary lists into strings https://review.openstack.org/265926 | 19:46 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add 'existing-only' argument for update subcommand https://review.openstack.org/491621 | 19:59 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add support for jira-changelog trigger https://review.openstack.org/493336 | 20:00 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Fix default expansion in macros https://review.openstack.org/230613 | 20:04 |
| *** frayedknot has quit IRC | 20:05 | |
| *** frayedknot has joined #openstack-jjb | 20:19 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Sort views list jobs https://review.openstack.org/560945 | 20:45 |
| *** frayedknot has quit IRC | 20:51 | |
| *** openstack has joined #openstack-jjb | 21:31 | |
| *** ChanServ sets mode: +o openstack | 21:31 | |
| *** hasharAway has quit IRC | 21:33 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Add support for jira-changelog trigger https://review.openstack.org/493336 | 22:42 |
| *** caphrim007_ has joined #openstack-jjb | 23:04 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add support for jira-changelog trigger https://review.openstack.org/493336 | 23:04 |
| *** caphrim007 has quit IRC | 23:08 | |
| *** caphrim007_ has quit IRC | 23:08 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: wrappers: fix XML node name for scrip-env's only-run-on-parent https://review.openstack.org/560684 | 23:11 |
| zxiiro | ssbarnea: thanks for the awesome effort on the code reviews. much appreciated! | 23:26 |
| *** vrroger_rabbit has joined #openstack-jjb | 23:48 | |
| *** vrroger_rabbit has quit IRC | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!