*** openstackgerrit has quit IRC | 05:34 | |
*** caphrim007_ has quit IRC | 06:52 | |
*** caphrim007 has joined #openstack-jjb | 06:53 | |
*** atodorov has joined #openstack-jjb | 07:00 | |
atodorov | hi folks, I've updated to jenkins-job-builder 2.0.10 and I get for builder in bs_data.get('build-steps'): | 07:01 |
---|---|---|
atodorov | TypeError: 'NoneType' object is not iterable | 07:01 |
atodorov | can't find this reported in the bug tracker, does anyone know what's the issue ? | 07:01 |
*** riuvshyn has joined #openstack-jjb | 07:38 | |
*** hashar has joined #openstack-jjb | 07:44 | |
*** riuvshyn has quit IRC | 08:10 | |
*** electrofelix has joined #openstack-jjb | 08:15 | |
*** atodorov has quit IRC | 08:19 | |
ssbarnea[m] | nope, but you should try to create a reproductible mini jjb file | 08:43 |
*** atodorov has joined #openstack-jjb | 08:45 | |
*** atodorov has quit IRC | 08:49 | |
*** riuvshyn has joined #openstack-jjb | 10:10 | |
*** riuvshyn has quit IRC | 10:15 | |
*** openstackgerrit has joined #openstack-jjb | 10:19 | |
openstackgerrit | Merged openstack/python-jenkins master: Adopt use of pre-commit hooks https://review.openstack.org/576878 | 10:19 |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Migrate to newer PyYAML https://review.openstack.org/578754 | 10:21 |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Migrate to newer PyYAML https://review.openstack.org/578754 | 11:09 |
zxiiro | Awe he left. I know what the problem is | 12:30 |
*** atodorov has joined #openstack-jjb | 12:43 | |
atodorov | hi folks, I'm having SSL errors after upgrading to 2.0.10 and from what I can tell all local CA certs have been installed properly. Any tips on how to figure out what is wrong ? | 12:44 |
ssbarnea[m] | atodorov: make a requests.get(url) and you will see that they are not installed where requests is expecting them. | 12:47 |
zxiiro | electrofelix: ssbarnea[m] so I guess there's 2 paths forward either ssbarnea[m]'s patch https://review.openstack.org/578754 or Vicky's patch https://review.openstack.org/578372 | 13:11 |
zxiiro | personally I'm fine with either but we probably should pick one soon because Zuul testing is broken now. | 13:12 |
zxiiro | electrofelix: ssbarnea[m] referring to the pyyaml issue | 13:12 |
ssbarnea[m] | i am working now to see how to address the zuul issue with docs , as we have no req to follow openstack constraints. | 13:12 |
zxiiro | ssbarnea[m]: can we maybe take vicky's patch in the meantime as it seems like the lowest cost to us right now? | 13:13 |
ssbarnea[m] | sure, we can merge that one until we get the other working. | 13:14 |
ssbarnea[m] | better to keep master green | 13:14 |
zxiiro | exactly as we have a lot of contributions lately I don't want folks to be confused that our master's broken | 13:14 |
ssbarnea[m] | done, gave +1 W on it. | 13:15 |
electrofelix | zxiiro: how about landing the patch and work out how to expose controlling the behaviour afterwards? | 13:24 |
electrofelix | oh, that's what ssbarnea[m] suggested | 13:24 |
zxiiro | electrofelix: +1 that sounds good to me. | 13:24 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Constrain PyYAML to v3.x. https://review.openstack.org/578372 | 13:27 |
*** atodorov has left #openstack-jjb | 13:27 | |
openstackgerrit | Andreas Jaeger proposed openstack-infra/jenkins-job-builder master: Use doc/requirements.txt https://review.openstack.org/578798 | 13:28 |
*** caphrim007 has quit IRC | 13:28 | |
*** caphrim007 has joined #openstack-jjb | 13:29 | |
openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Adds wrapper for vault plugin https://review.openstack.org/577628 | 13:29 |
*** caphrim007 has quit IRC | 13:33 | |
openstackgerrit | Andreas Jaeger proposed openstack-infra/jenkins-job-builder master: Use doc/requirements.txt https://review.openstack.org/578798 | 14:53 |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Migrate to newer PyYAML https://review.openstack.org/578754 | 15:22 |
*** caphrim007 has joined #openstack-jjb | 15:23 | |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add XUnit processing plugin to builders https://review.openstack.org/468175 | 15:24 |
*** caphrim007 has quit IRC | 15:26 | |
*** caphrim007 has joined #openstack-jjb | 15:26 | |
*** caphrim007 has quit IRC | 15:27 | |
*** caphrim007 has joined #openstack-jjb | 15:27 | |
*** hashar is now known as hasharAway | 15:52 | |
*** raopajay has quit IRC | 16:26 | |
*** vickyc has quit IRC | 17:02 | |
*** electrofelix has quit IRC | 17:10 | |
ssbarnea[m] | does anyone know something about the jms-messaging in jbb? | 17:30 |
ssbarnea[m] | why the example has an additional "}" at the end of the message? | 17:31 |
zxiiro | ssbarnea[m]: looks like probably a typo? | 17:33 |
zxiiro | although if it came form an example the examlpe should be failing | 17:33 |
zxiiro | huh... odd it is coming from an example | 17:34 |
zxiiro | oh i see it's because the typo doesn't affect the example code since it's a text box | 17:35 |
zxiiro | ssbarnea[m]: yeah looks like a typo to me that we should fix | 17:35 |
ssbarnea[m] | i was curious if it was a typo or some kind of special format requirements for these messages. | 17:52 |
zxiiro | my bet is on typo | 17:57 |
zxiiro | It doesn't look like it was on purpose to me | 17:57 |
ssbarnea[m] | zxiiro: lets merge https://review.openstack.org/#/c/578754/ | 18:02 |
zxiiro | ssbarnea[m]: why the rush? I thought we were going to parameterize that option so that we can load a danger or safe yaml? | 18:03 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add XUnit processing plugin to builders https://review.openstack.org/468175 | 18:04 |
ssbarnea[m] | even in its current form is safer as there is one or two places where we use the safe loader. | 18:04 |
zxiiro | 4.1 was literally just released yesterday | 18:04 |
ssbarnea[m] | my patch does not add dangereus one everywhere. | 18:04 |
ssbarnea[m] | well, this is a good reason for delaying it. | 18:04 |
zxiiro | ssbarnea[m]: I'd like to get electrofelix's +2 for it before we go forward but I think he wants to expose controlling behaviour before we merge right? | 18:06 |
zxiiro | ssbarnea[m]: is there a feature from PyYAML 4.1 that we absolutely need right now? I personally don't a see a rush for this... | 18:06 |
ssbarnea[m] | sure, no need to rush. | 18:07 |
zxiiro | I'd rather get the right implementation first rather then bumping versions for bumping sake. | 18:07 |
zxiiro | ok cool | 18:07 |
*** ssbarnea has quit IRC | 19:50 | |
*** ssbarnea[m] is now known as ssbarnea | 19:53 | |
openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: adop pre-commit hooks https://review.openstack.org/576598 | 20:15 |
*** hasharAway has quit IRC | 21:32 | |
ssbarnea | zxiiro: please have a look at https://review.openstack.org/#/c/576598/ -- maybe you can help fixing that one failing unit test. I really don't know what is wrong with this one. | 22:43 |
*** caphrim007_ has joined #openstack-jjb | 23:04 | |
*** caphrim007_ has quit IRC | 23:05 | |
*** caphrim007_ has joined #openstack-jjb | 23:05 | |
*** caphrim007 has quit IRC | 23:07 | |
*** caphrim007_ has quit IRC | 23:09 | |
*** caphrim007 has joined #openstack-jjb | 23:11 | |
*** caphrim007 has quit IRC | 23:16 | |
*** caphrim007 has joined #openstack-jjb | 23:17 | |
*** caphrim007 has quit IRC | 23:21 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!