| *** caphrim007 has joined #openstack-jjb | 01:19 | |
| *** caphrim007 has quit IRC | 01:23 | |
| *** caphrim007 has joined #openstack-jjb | 01:25 | |
| *** caphrim007_ has joined #openstack-jjb | 01:48 | |
| *** caphrim007 has quit IRC | 01:52 | |
| kien-ha | ssbarnea: for the jms-messaging, is it just me or are there two different curly braces in there. | 03:01 |
|---|---|---|
| kien-ha | ssbarnea: It's very odd but in vim or atom, the curly braces look the same | 03:04 |
| kien-ha | ssbarnea: but when I open it with Kate, I notice the first set of curly braces are darker than the extra curly braces | 03:07 |
| kien-ha | ssbarnea: maybe it's related to your problem | 03:08 |
| ssbarnea | kien-ha: please try to run locally if you can, is unrelated to jms, is another test failing. | 08:09 |
| *** electrofelix has joined #openstack-jjb | 08:53 | |
| *** riuvshyn has joined #openstack-jjb | 09:26 | |
| *** riuvshyn has quit IRC | 09:49 | |
| *** riuvshyn has joined #openstack-jjb | 09:50 | |
| *** riuvshyn has quit IRC | 09:54 | |
| *** electrofelix has quit IRC | 11:02 | |
| *** electrofelix has joined #openstack-jjb | 11:40 | |
| *** aaprasolova has joined #openstack-jjb | 11:52 | |
| ssbarnea | electrofelix: sorry to bother, but can you please download 576598 and check what kind of weird issue prevents only one test from passing? | 12:24 |
| ssbarnea | i am bit clueless on this one and i bet is something simple | 12:24 |
| *** hashar has joined #openstack-jjb | 12:41 | |
| *** openstackgerrit has quit IRC | 12:49 | |
| zxiiro | ssbarnea: there's 2 failures, one is expecting the XML in the folders test to end but you added a trainline <BLANKLINE> The 2nd one is with the JMS plugin test in which you "fixed" the formatting but didn't update the expected test. | 12:49 |
| zxiiro | 2018-06-28 21:24:44.983360 | ubuntu-xenial | + } | 12:49 |
| zxiiro | 2018-06-28 21:24:44.983435 | ubuntu-xenial | - }</messageContent> | 12:49 |
| zxiiro | 2018-06-28 21:24:44.983482 | ubuntu-xenial | ? - | 12:49 |
| zxiiro | 2018-06-28 21:24:44.983554 | ubuntu-xenial | + </messageContent> | 12:49 |
| zxiiro | see how it was originally expecting the line "}</messageContent>" but now it appears on 2 lines as | 12:50 |
| zxiiro | } | 12:50 |
| zxiiro | </messageContent> | 12:50 |
| zxiiro | I think the folders plugin one thought the addition of the <BLANKLINE> syntax is just wrong | 12:50 |
| zxiiro | I'm confused why https://review.openstack.org/#/c/576598/2/tests/yamlparser/fixtures/folders/folders001.xml was even added? | 12:51 |
| ssbarnea | maybe i forget to update the CR as a remember having only one error that I could fix: the one with BLANKLINE in folders plugin. | 12:51 |
| ssbarnea | zxiiro: if you try to remove it you will find | 12:52 |
| ssbarnea | there is somethign really weird about folders one because it causes the generated xml file to be in different folder. | 12:52 |
| zxiiro | oh yeah if I delete that folder i see Output file under wrong path, was 'tests/yamlparser/fixtures/folders001.xml', should be 'tests/yamlparser/fixtures/folders/folders001.xml' | 12:58 |
| zxiiro | that is odd | 12:58 |
| zxiiro | I really think these patches that try to change formatting should be split to be one topic at a time since they touch so many files it get's confusing | 13:01 |
| ssbarnea | zxiiro: true, is confusing. I will try to split it to make this one smaller. | 13:02 |
| zxiiro | I really don't get what changed in this patch that would have caused the folder issue that's bizzare | 13:03 |
| zxiiro | it's not like folders001.yaml tries to include any ohter file either | 13:04 |
| zxiiro | ssbarnea: oh i figured it out | 13:08 |
| zxiiro | ssbarnea: you tried to be clever and changed fixtures/folders/folders001.xml to be a symlink to fixtures/folders001.xml | 13:09 |
| zxiiro | but JJB expects it to be a real file | 13:09 |
| ssbarnea | it was failing even before I did this. but that also means we have a bug, it would open symlinks like normal files. | 13:10 |
| zxiiro | I just reproduced on a clean master | 13:11 |
| zxiiro | all i did was added the symlink in and it broke | 13:11 |
| zxiiro | undo the symlink and build and it's fine | 13:11 |
| ssbarnea | zxiiro: but this means that we would have the same file twice in the repo. | 13:12 |
| zxiiro | guess so | 13:12 |
| zxiiro | Ok I found a combination that works if you want to use a symlink | 13:13 |
| zxiiro | ssbarnea: hold up, patch incoming | 13:14 |
| ssbarnea | super! | 13:15 |
| *** openstackgerrit has joined #openstack-jjb | 13:18 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Symlink folders001.xml to deduplicate the test xml https://review.openstack.org/579150 | 13:18 |
| zxiiro | ssbarnea: that should do it. I've also found you should not edit the other file to remove the double trailing newlines. It appears the test needs that. | 13:19 |
| zxiiro | otherwise we will get that + <BLANKLINES> thing | 13:19 |
| *** zxiiro is now known as zxiiro-pto | 13:20 | |
| ssbarnea | this explains is but also be a an issue with pre-commit hook. anyway, i will split changes. | 13:21 |
| zxiiro-pto | yeah I'm not sure why "folders" expects the double blank line. It looks like it takes the 2 XML files and concatinates them together though so maybe it uses the 2nd blank line to mark when the 2nd copy of the xml goes through or something (i'm purely guessing here so probably completely wrong) | 13:22 |
| *** hashar has quit IRC | 13:27 | |
| *** caphrim007_ has quit IRC | 13:32 | |
| *** caphrim007 has joined #openstack-jjb | 13:33 | |
| *** caphrim007 has quit IRC | 13:37 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: normalize newlines at end of file https://review.openstack.org/579187 | 15:01 |
| zxiiro-pto | ssbarnea: electrofelix any patches we want in before I cut a JJB release later today? | 15:01 |
| openstackgerrit | Subhash Pavuluri proposed openstack-infra/jenkins-job-builder master: Trim is not available for string parameters File name: https://github.com/openstack-infra/jenkins-job-builder/blob/master/jenkins_jobs/modules/parameters.py https://review.openstack.org/579190 | 15:05 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Symlink folders001.xml to deduplicate the test xml https://review.openstack.org/579150 | 15:06 |
| ssbarnea | nothing functional but i would prefer to merge the pre-commit ones before the release. | 15:06 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Revert "fix tox python3 overrides" https://review.openstack.org/576603 | 15:10 |
| zxiiro-pto | ssbarnea: I think you're Normalize file endings patch accidently reintroduced the folders001.xml change. | 15:12 |
| zxiiro-pto | gotta run, I'll be back in a few hours to checkup on patches and release 2.0.11 | 15:13 |
| ssbarnea | perfect | 15:16 |
| *** openstack has quit IRC | 15:22 | |
| *** openstack has joined #openstack-jjb | 15:26 | |
| *** ChanServ sets mode: +o openstack | 15:26 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: normalize newlines at end of file https://review.openstack.org/579187 | 15:31 |
| *** caphrim007 has joined #openstack-jjb | 15:45 | |
| *** caphrim007 has quit IRC | 15:47 | |
| *** caphrim007 has joined #openstack-jjb | 15:47 | |
| *** caphrim007 has quit IRC | 15:47 | |
| *** caphrim007 has joined #openstack-jjb | 15:48 | |
| *** aaprasol_ has joined #openstack-jjb | 15:54 | |
| *** aaprasolova has quit IRC | 15:57 | |
| *** aaprasol_ has quit IRC | 15:59 | |
| *** alphadose[m] has quit IRC | 16:17 | |
| kien-ha | ssbarnea: just left a quick comment on your normalize patch | 16:20 |
| kien-ha | ssbarnea: spotted a newline that was missed | 16:21 |
| ssbarnea | kien-ha: if is passing the tests is ok, we can always fix them in the one that adss hte pre-commit. | 16:21 |
| ssbarnea | its scope is to get rid of the spam | 16:22 |
| ssbarnea | it does not have to be 100% of it :D | 16:22 |
| kien-ha | ssbarnea: gotcha. | 16:23 |
| ssbarnea | a workfllow on https://review.openstack.org/#/c/574846/ | 16:23 |
| *** caphrim007 has quit IRC | 16:26 | |
| *** electrofelix has quit IRC | 16:29 | |
| *** alphadose[m] has joined #openstack-jjb | 17:00 | |
| *** openstack has quit IRC | 17:11 | |
| *** openstack has joined #openstack-jjb | 17:15 | |
| *** ChanServ sets mode: +o openstack | 17:15 | |
| *** caphrim007 has joined #openstack-jjb | 18:02 | |
| *** caphrim007 has quit IRC | 18:38 | |
| *** caphrim007 has joined #openstack-jjb | 18:39 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Normalize newlines at end of file https://review.openstack.org/579187 | 20:08 |
| zxiiro-pto | ssbarnea: I fixed it. I don't like to halfass my patches. I'd rather full ass my work if I'm changing something. | 20:09 |
| zxiiro-pto | ssbarnea: kien-ha either of you guys want to review the vault plugin? https://review.openstack.org/#/c/577628/8 | 20:15 |
| kien-ha | zxiiro-pto: On it | 20:17 |
| kien-ha | Oh, Sorin got it | 20:17 |
| zxiiro-pto | kien-ha: you can still review if you want it's not too late | 20:18 |
| zxiiro-pto | I will release JJB 2.0.11 once the vault plugin + normilaze patches merge | 20:19 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Adds wrapper for vault plugin https://review.openstack.org/577628 | 20:42 |
| *** caphrim007 has quit IRC | 21:12 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Normalize newlines at end of file https://review.openstack.org/579187 | 21:15 |
| zxiiro-pto | JJB 2.0.11 is released. Have a great weekend guys | 21:34 |
| ssbarnea | same to you! | 21:34 |
| *** ckonstanski has joined #openstack-jjb | 22:10 | |
| *** ckonstanski has quit IRC | 22:24 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!