| *** daab-prover has joined #openstack-jjb | 10:42 | |
| openstackgerrit | Andrew McLeod proposed openstack-infra/jenkins-job-builder master: Add functionality to use scriptPath https://review.openstack.org/589125 | 11:33 |
|---|---|---|
| *** admcleod has joined #openstack-jjb | 11:42 | |
| admcleod | hi there, just wondering if you're going to want tests for this: https://review.openstack.org/#/c/589125/ | 11:42 |
| *** daab-prover has quit IRC | 12:13 | |
| *** tanhengyeow has joined #openstack-jjb | 13:01 | |
| tanhengyeow | zxiiro: Hello Thanh Ha, are you there? | 13:12 |
| tanhengyeow | zxiiro: So far I've been mostly delving into code for providing support to Jenkins plugins. I figured I should find out more about how JJB works as a whole, from the start to the end for e.g. how it processes/recognize plugins, how it read in commands, how it process tests and much more. However, I can't seem to wrap my head around it just by looking at code here and there. Do you have any advice for me to go about doing | 13:22 |
| tanhengyeow | zxiiro: Perhaps some tasks would aid me in this. I think it is beneficial for me as it would help me to understand JJB much better such that I can review code not related to Jenkins Jobs more effectively. | 13:22 |
| *** zxiiro has quit IRC | 14:26 | |
| *** ktdreyer has quit IRC | 14:26 | |
| *** ktdreyer_ has joined #openstack-jjb | 14:26 | |
| *** zxiiro has joined #openstack-jjb | 14:37 | |
| *** daab-prover has joined #openstack-jjb | 15:17 | |
| daab-prover | Any particular reason the 'trim' option on string parameters has not been implemented? | 15:18 |
| Odd_Bloke | admcleod: I think tests would be good. | 15:27 |
| admcleod | Odd_Bloke: alright. do they need to be specific to that, or would it be acceptable to just add them to say git001 and git002 | 15:27 |
| Odd_Bloke | admcleod: I think adapting an existing test would be sufficient, it's a small change. | 15:29 |
| admcleod | Odd_Bloke: ok, thanks | 15:29 |
| Odd_Bloke | (So long as we're still testing that we default to Jenkinsfile somewhere. :) | 15:29 |
| admcleod | Odd_Bloke: i was thinking i would test one explicitly, and then in another that it defaults to Jenkinsfile | 15:29 |
| Odd_Bloke | Sounds good to me. | 15:31 |
| *** daab-prover has quit IRC | 15:45 | |
| *** ktdreyer_ is now known as ktdreyer | 16:23 | |
| *** admcleod has left #openstack-jjb | 16:37 | |
| *** tanhengyeow has quit IRC | 17:01 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!