| *** daab-prover has joined #openstack-jjb | 07:55 | |
| *** electrofelix has joined #openstack-jjb | 08:33 | |
| *** electrofelix has quit IRC | 10:18 | |
| *** electrofelix has joined #openstack-jjb | 10:26 | |
| *** r-mibu has joined #openstack-jjb | 13:42 | |
| *** daab-prover has quit IRC | 15:45 | |
| zxiiro | ssbarnea: the patch we merged in python-jenkins breaks JJB for me https://review.openstack.org/575817 | 16:03 |
|---|---|---|
| ssbarnea | zxiiro: can you provide more info so I can fix it? | 16:04 |
| Liskni_si | ssbarnea: its the same thing I told you here a few days ago | 16:04 |
| zxiiro | ssbarnea: I pasted the trace in my comment | 16:04 |
| ssbarnea | i am no longer using JJB, at least for the moment, but I will fix such a bug. | 16:04 |
| Liskni_si | or maybe it breaks in other ways too | 16:04 |
| zxiiro | EmptyResponseException: Error communicating with server[https://jenkins.opendaylight.org/sandbox/]: empty response | 16:05 |
| *** r-mibu has quit IRC | 16:06 | |
| ssbarnea | zxiiro: how can I get an account for this jenkins server? (to tesT) | 16:06 |
| zxiiro | ssbarnea: create an account here https://identity.linuxfoundation.org/ and then ping me with your username I can give you access | 16:06 |
| ssbarnea | ssbarnea -- already had one. | 16:07 |
| zxiiro | ssbarnea: alright I just added you to the sandbox list | 16:07 |
| zxiiro | ssbarnea: So you should be able to reproduce with just the "test" command pointing to that server. | 16:07 |
| ssbarnea | doing it now, i am already logged in | 16:08 |
| ssbarnea | first impressions using my account and master: i was able to list jobs, but doing get-plugins-info got me a 403 error. | 16:14 |
| ssbarnea | but doing a test and update worked (freestyle job). | 16:17 |
| zxiiro | huh really? | 16:25 |
| zxiiro | why's it broke for me. hmm... | 16:25 |
| zxiiro | ssbarnea: to be clear you're using latest master of python-jenkins right? | 16:28 |
| zxiiro | ssbarnea: not a released version since we haven't released that patch yet | 16:28 |
| ssbarnea | ahh, forgot that. doing it now. | 16:28 |
| *** electrofelix has quit IRC | 16:29 | |
| ssbarnea | ok, problem reproduced. time to write fix for it. | 16:29 |
| zxiiro | stepping out for a lunch. back in a bit. | 16:30 |
| ssbarnea | mainly this happens because code expects a body but HEAD has no body by design. | 16:41 |
| ssbarnea | now the only question is if a response object knows which verb was used in the request. | 16:42 |
| ssbarnea | clearly knows the URL, but i don't know about the verb/action. | 16:42 |
| ssbarnea | if it was post/get/option/put/.... | 16:42 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Avoid empty body failure on HEAD requests https://review.openstack.org/589547 | 16:48 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Avoid empty body failure on HEAD requests https://review.openstack.org/589547 | 16:53 |
| zxiiro | ssbarnea: thanks Looks like that works for me. | 17:51 |
| ssbarnea | i am not sure if this fixes all cases but I also wanted to minimize the potential impact so I checked only for HEAD. | 17:52 |
| ssbarnea | funny initial version of the breaking patch didn't use the jenkins_request so it was not affected buy this bug, during the review someone suggested to use that function,... :D | 17:53 |
| ssbarnea | good that we didn't release it | 17:53 |
| zxiiro | I +1 workflowed it so that it fixes our master branch when Zuul passes | 17:57 |
| Liskni_si | I didn't test it as I'm in a pub but I'm pretty sure the offline job generation case is still broken. | 18:16 |
| Liskni_si | But maybe if we used a file:// uri instead of localhost... Dunno. | 18:17 |
| zxiiro | ssbarnea: ^ any ideas for that case? | 18:25 |
| zxiiro | Liskni_si: yeah let's not release the next python-jenkins until we fix that | 18:25 |
| ssbarnea | sure | 18:25 |
| *** openstackgerrit has quit IRC | 18:49 | |
| zxiiro | hmmm seems like even if you say "ignore_cache=True" the cache object is still setup in JJB thusly requiring the cache regardless of if you want to use it or not. | 19:00 |
| Liskni_si | yeah but that's unrelated I think | 19:01 |
| Liskni_si | we've been overriding XDG_CACHE_something to be able to generate offline jobs for multiple jenkins instances in parallel | 19:02 |
| zxiiro | Liskni_si: yeah I wasn't on topic there. | 19:07 |
| zxiiro | one of my projects is trying to run multilpe jenkins-jobs processes simultaneously and are hitting cache issues. | 19:07 |
| zxiiro | Liskni_si: setthing that CACHE variable sounds brilliant though maybe I'll suggest something similar | 19:08 |
| *** openstackgerrit has joined #openstack-jjb | 19:25 | |
| openstackgerrit | Merged openstack/python-jenkins master: Avoid empty body failure on HEAD requests https://review.openstack.org/589547 | 19:25 |
| *** ckonstanski has joined #openstack-jjb | 20:10 | |
| *** ckonstanski has left #openstack-jjb | 20:24 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!