| *** openstack has joined #openstack-keystone | 00:02 | |
| jamielennox | morganfainberg, bknudson: when is the icehouse/juno split? | 00:13 |
|---|---|---|
| morganfainberg | jamielennox, when RC is cut? | 00:13 |
| morganfainberg | jamielennox, https://wiki.openstack.org/wiki/Icehouse_Release_Schedule March 27th is the RC timeframe | 00:13 |
| jamielennox | i'm tempted to do a patch for KDS that removes it completely from icehouse so that we don't end up with a non-functional kds bin in the release | 00:13 |
| jamielennox | but i don't want to stop pushing for the development now | 00:14 |
| morganfainberg | jamielennox, wait until next week. TC should discuss the repo/etc on tuesday | 00:14 |
| morganfainberg | if all is assumed "good" we will have a new repo we can push towards after that | 00:14 |
| morganfainberg | if they say no, i am not opposed to pulling KDS out and put it back in post RC | 00:15 |
| morganfainberg | but, i'll defer to dolphm_503 on that one | 00:15 |
| morganfainberg | (of course) | 00:15 |
| jamielennox | morganfainberg: ok, i saw the comment on the review for the new repo - that's definetly on the TC agenda? | 00:17 |
| jamielennox | i don't know what time that meeting is to whether i'll be around to attend | 00:17 |
| morganfainberg | jamielennox, TC meeting is in the early afternoon same day as Keystone meeting (pacific time) | 00:18 |
| morganfainberg | uhm 2100 utc i think | 00:18 |
| jamielennox | morganfainberg: might leave that one to you guys then if it's pre keystone meeting | 00:18 |
| morganfainberg | post | 00:18 |
| morganfainberg | https://wiki.openstack.org/wiki/Meetings#Technical_Committee_meeting 2000 UTC | 00:19 |
| morganfainberg | not sure what time that is for you *brain doesn't want to do TZ math* | 00:19 |
| jamielennox | i've never been able to do it mentally | 00:21 |
| jamielennox | but it's not so bad | 00:21 |
| jamielennox | (6am) | 00:21 |
| *** topol has joined #openstack-keystone | 00:22 | |
| *** gokrokve has joined #openstack-keystone | 00:34 | |
| *** gokrokve has quit IRC | 00:39 | |
| morganfainberg | jamielennox, where do you live? (city)? | 00:41 |
| jamielennox | brisbane | 00:41 |
| morganfainberg | ahh | 00:41 |
| morganfainberg | +10 UTC | 00:42 |
| *** tellesnobrega has quit IRC | 00:49 | |
| *** tellesnobrega has joined #openstack-keystone | 00:52 | |
| *** dolphm_503 is now known as dolphm | 00:52 | |
| *** ChanServ sets mode: +o dolphm | 00:52 | |
| morganfainberg | topol, i think i get to only use like 2 of your slides =/ | 01:22 |
| morganfainberg | wtf... | 01:29 |
| morganfainberg | https://github.com/openstack/keystone/blob/master/keystone/token/backends/sql.py#L130 we do a to_dict() JUST to extract the id... | 01:29 |
| morganfainberg | ... the ID is a first-order column | 01:30 |
| * morganfainberg grumbles | 01:30 | |
| morganfainberg | hehe, wonder if that really ends up being much overhead | 01:31 |
| jamielennox | morganfainberg: i've always had the impression that whoever wrote the initial sql backends disliked sqlalchemy | 01:32 |
| morganfainberg | jamielennox, thats the feeling | 01:32 |
| jamielennox | they go to pains to not used what is given | 01:32 |
| *** gokrokve has joined #openstack-keystone | 01:34 | |
| *** gokrokve has quit IRC | 01:38 | |
| *** morganfainberg is now known as morganfainberg_Z | 01:56 | |
| *** morganfainberg_Z is now known as morganfainberg | 01:57 | |
| *** gokrokve has joined #openstack-keystone | 02:34 | |
| *** gokrokve has quit IRC | 02:39 | |
| *** dolphm is now known as dolphm_503 | 02:57 | |
| *** dolphm_503 is now known as dolphm | 02:59 | |
| *** dolphm is now known as dolphm_503 | 03:14 | |
| *** dolphm_503 is now known as dolphm | 03:23 | |
| *** gokrokve has joined #openstack-keystone | 03:34 | |
| *** Kanagaraj has joined #openstack-keystone | 03:38 | |
| *** gokrokve has quit IRC | 03:39 | |
| *** dstanek has joined #openstack-keystone | 03:40 | |
| *** ChanServ sets mode: +v dstanek | 03:40 | |
| *** david_lyle_ has joined #openstack-keystone | 03:40 | |
| *** david_lyle_ is now known as david_lyle | 03:43 | |
| *** lnxnut has joined #openstack-keystone | 04:05 | |
| *** theocean154 has joined #openstack-keystone | 04:26 | |
| *** theocean154 has quit IRC | 04:51 | |
| *** theocean154 has joined #openstack-keystone | 04:51 | |
| *** chandan_kumar has joined #openstack-keystone | 05:08 | |
| *** theocean154 has quit IRC | 05:11 | |
| *** theocean154 has joined #openstack-keystone | 05:11 | |
| *** chandan_kumar has quit IRC | 05:12 | |
| *** lnxnut has quit IRC | 05:14 | |
| *** lnxnut has joined #openstack-keystone | 05:22 | |
| *** lnxnut has quit IRC | 05:26 | |
| *** stevemar has joined #openstack-keystone | 05:43 | |
| *** ChanServ sets mode: +v stevemar | 05:43 | |
| *** dolphm is now known as dolphm_503 | 05:43 | |
| *** chandan_kumar has joined #openstack-keystone | 05:55 | |
| *** lnxnut has joined #openstack-keystone | 06:05 | |
| *** lnxnut has quit IRC | 06:06 | |
| *** lnxnut has joined #openstack-keystone | 06:07 | |
| *** topol has quit IRC | 06:08 | |
| *** lnxnut has quit IRC | 06:11 | |
| *** stevemar has quit IRC | 06:37 | |
| *** theocean154 has quit IRC | 06:44 | |
| *** dolphm_503 is now known as dolphm | 06:44 | |
| *** theocean154 has joined #openstack-keystone | 06:44 | |
| *** gokrokve has joined #openstack-keystone | 06:51 | |
| *** gokrokve_ has joined #openstack-keystone | 06:52 | |
| *** dolphm is now known as dolphm_503 | 06:53 | |
| *** gokrokve has quit IRC | 06:55 | |
| *** saju_m has joined #openstack-keystone | 06:58 | |
| *** lnxnut has joined #openstack-keystone | 07:05 | |
| *** lnxnut has quit IRC | 07:06 | |
| *** lnxnut has joined #openstack-keystone | 07:06 | |
| *** lnxnut has quit IRC | 07:11 | |
| *** gokrokve_ has quit IRC | 07:12 | |
| *** theocean154 has quit IRC | 07:21 | |
| *** leseb has joined #openstack-keystone | 07:30 | |
| *** leseb has quit IRC | 07:44 | |
| *** leseb has joined #openstack-keystone | 07:45 | |
| *** YorikSar has joined #openstack-keystone | 07:45 | |
| *** leseb has quit IRC | 07:45 | |
| *** leseb has joined #openstack-keystone | 07:45 | |
| *** gokrokve has joined #openstack-keystone | 07:53 | |
| *** jamielennox is now known as jamielennox|away | 07:54 | |
| *** dstanek_afk has joined #openstack-keystone | 07:55 | |
| *** ChanServ sets mode: +v dstanek_afk | 07:55 | |
| *** marekd|away is now known as marekd | 07:58 | |
| *** YorikSar_ has joined #openstack-keystone | 07:58 | |
| *** YorikSar has quit IRC | 08:03 | |
| *** dstanek has quit IRC | 08:03 | |
| *** tellesnobrega has quit IRC | 08:03 | |
| *** morganfainberg is now known as morganfainberg_Z | 08:06 | |
| *** lnxnut has joined #openstack-keystone | 08:06 | |
| *** lnxnut has quit IRC | 08:11 | |
| *** tellesnobrega has joined #openstack-keystone | 08:12 | |
| *** Kanagaraj has quit IRC | 08:19 | |
| *** leseb has joined #openstack-keystone | 08:57 | |
| *** leseb has quit IRC | 09:01 | |
| *** lnxnut has joined #openstack-keystone | 09:05 | |
| *** leseb has joined #openstack-keystone | 09:07 | |
| *** lnxnut has quit IRC | 09:10 | |
| *** bvandenh has quit IRC | 09:37 | |
| *** huats_ is now known as huats | 09:40 | |
| *** saju_m has quit IRC | 09:46 | |
| *** saju_m has joined #openstack-keystone | 09:50 | |
| *** KanagarajM_ has joined #openstack-keystone | 09:55 | |
| *** lnxnut has joined #openstack-keystone | 10:05 | |
| *** YorikSar_ is now known as YorikSar | 10:06 | |
| *** lnxnut has quit IRC | 10:10 | |
| *** bvandenh has joined #openstack-keystone | 10:48 | |
| *** marekd has left #openstack-keystone | 11:04 | |
| *** marekd has joined #openstack-keystone | 11:04 | |
| *** saju_m has quit IRC | 11:12 | |
| *** YorikSar_ has joined #openstack-keystone | 11:13 | |
| *** zigo_ is now known as zigo | 11:14 | |
| *** YorikSar has quit IRC | 11:14 | |
| *** YorikSar_ is now known as YorikSar | 11:20 | |
| *** saju_m has joined #openstack-keystone | 11:27 | |
| *** KanagarajM__ has joined #openstack-keystone | 11:36 | |
| *** KanagarajM_ has quit IRC | 11:36 | |
| *** leseb has quit IRC | 11:43 | |
| *** saju_m has quit IRC | 12:02 | |
| *** raildo has joined #openstack-keystone | 12:08 | |
| *** leseb has joined #openstack-keystone | 12:18 | |
| *** dolphm_503 is now known as dolphm | 12:20 | |
| *** leseb_ has joined #openstack-keystone | 12:20 | |
| *** leseb has quit IRC | 12:20 | |
| *** KanagarajM__ has quit IRC | 12:31 | |
| *** dolphm is now known as dolphm_503 | 12:45 | |
| *** saju_m has joined #openstack-keystone | 12:55 | |
| *** topol has joined #openstack-keystone | 13:05 | |
| *** nkinder_ has quit IRC | 13:14 | |
| *** dolphm_503 is now known as dolphm | 13:14 | |
| *** david_lyle has quit IRC | 13:14 | |
| *** achampion has quit IRC | 13:43 | |
| *** saju_m has quit IRC | 13:43 | |
| *** saju_m has joined #openstack-keystone | 13:44 | |
| *** YorikSar_ has joined #openstack-keystone | 13:51 | |
| *** YorikSar has quit IRC | 13:52 | |
| *** YorikSar has joined #openstack-keystone | 13:52 | |
| *** YorikSar has quit IRC | 13:52 | |
| *** nkinder_ has joined #openstack-keystone | 14:03 | |
| *** saju_m has quit IRC | 14:05 | |
| *** lnxnut has joined #openstack-keystone | 14:13 | |
| *** lbragstad has quit IRC | 14:13 | |
| *** bvandenh has quit IRC | 14:15 | |
| *** YorikSar_ is now known as YorikSar | 14:20 | |
| *** topol has quit IRC | 14:26 | |
| *** bvandenh has joined #openstack-keystone | 14:29 | |
| *** browne has joined #openstack-keystone | 14:29 | |
| *** lbragstad has joined #openstack-keystone | 14:44 | |
| *** dstanek_afk is now known as dstanek | 14:44 | |
| *** gokrokve has quit IRC | 14:53 | |
| *** gokrokve has joined #openstack-keystone | 14:53 | |
| *** achampion has joined #openstack-keystone | 14:58 | |
| *** ayoung has joined #openstack-keystone | 15:11 | |
| *** rwsu has joined #openstack-keystone | 15:14 | |
| *** david_lyle_ has joined #openstack-keystone | 15:27 | |
| *** stevemar has joined #openstack-keystone | 16:01 | |
| *** ChanServ sets mode: +v stevemar | 16:01 | |
| *** marekd has quit IRC | 16:03 | |
| *** andreaf has joined #openstack-keystone | 16:04 | |
| *** dolphm is now known as dolphm_503 | 16:05 | |
| *** marekd has joined #openstack-keystone | 16:05 | |
| *** jraim_ is now known as jraim | 16:10 | |
| stevemar | lbragstad, way to delete 5490 lines of code: https://review.openstack.org/#/c/73900/ yay | 16:22 |
| *** dolphm_503 is now known as dolphm | 16:22 | |
| * lbragstad high fives stevemar | 16:23 | |
| *** huats has quit IRC | 16:23 | |
| *** huats has joined #openstack-keystone | 16:24 | |
| *** huats has joined #openstack-keystone | 16:24 | |
| lbragstad | stevemar: the oslo.messaging stuff should be almost done too.. the log_handler.py migration to oslo.messaging anyway | 16:25 |
| *** topol has joined #openstack-keystone | 16:32 | |
| *** nkinder_ has quit IRC | 16:35 | |
| *** nkinder_ has joined #openstack-keystone | 16:47 | |
| *** devlaps has joined #openstack-keystone | 16:55 | |
| *** marcoemorais has joined #openstack-keystone | 16:56 | |
| *** marcoemorais has quit IRC | 16:57 | |
| *** dolphm is now known as dolphm_503 | 16:57 | |
| *** marcoemorais has joined #openstack-keystone | 16:58 | |
| *** marcoemorais has quit IRC | 16:58 | |
| *** dolphm_503 is now known as dolphm | 16:58 | |
| *** marcoemorais has joined #openstack-keystone | 16:59 | |
| *** gyee has joined #openstack-keystone | 17:01 | |
| *** ayoung has quit IRC | 17:04 | |
| *** lbragstad has quit IRC | 17:04 | |
| *** tellesnobrega has quit IRC | 17:04 | |
| *** devlaps has quit IRC | 17:04 | |
| *** achampion has quit IRC | 17:04 | |
| *** gokrokve has quit IRC | 17:04 | |
| *** bvandenh has quit IRC | 17:04 | |
| *** lnxnut has quit IRC | 17:04 | |
| *** huats has quit IRC | 17:04 | |
| *** david_lyle_ has quit IRC | 17:04 | |
| *** dstanek has quit IRC | 17:04 | |
| *** topol has quit IRC | 17:04 | |
| *** dtroyer has quit IRC | 17:04 | |
| *** Daviey has quit IRC | 17:04 | |
| *** simo has quit IRC | 17:04 | |
| *** marcoemorais has quit IRC | 17:04 | |
| *** dolphm has quit IRC | 17:04 | |
| *** mfisch has quit IRC | 17:04 | |
| *** jraim has quit IRC | 17:04 | |
| *** koolhead17 has quit IRC | 17:04 | |
| *** chmouel has quit IRC | 17:04 | |
| *** zigo has quit IRC | 17:04 | |
| *** mhu has quit IRC | 17:04 | |
| *** lari_ has quit IRC | 17:04 | |
| *** ChanServ has quit IRC | 17:04 | |
| *** morganfainberg_Z has quit IRC | 17:04 | |
| *** raildo has quit IRC | 17:04 | |
| *** marekd has quit IRC | 17:04 | |
| *** anteaya has quit IRC | 17:04 | |
| *** jamielennox|away has quit IRC | 17:04 | |
| *** leseb_ has quit IRC | 17:04 | |
| *** amerine has quit IRC | 17:04 | |
| *** bknudson has quit IRC | 17:04 | |
| *** sudorandom has quit IRC | 17:04 | |
| *** marcoemorais has joined #openstack-keystone | 17:06 | |
| *** devlaps has joined #openstack-keystone | 17:06 | |
| *** topol has joined #openstack-keystone | 17:06 | |
| *** huats has joined #openstack-keystone | 17:06 | |
| *** marekd has joined #openstack-keystone | 17:06 | |
| *** david_lyle_ has joined #openstack-keystone | 17:06 | |
| *** achampion has joined #openstack-keystone | 17:06 | |
| *** gokrokve has joined #openstack-keystone | 17:06 | |
| *** bvandenh has joined #openstack-keystone | 17:06 | |
| *** lnxnut has joined #openstack-keystone | 17:06 | |
| *** raildo has joined #openstack-keystone | 17:06 | |
| *** dstanek has joined #openstack-keystone | 17:06 | |
| *** dolphm has joined #openstack-keystone | 17:06 | |
| *** mfisch has joined #openstack-keystone | 17:06 | |
| *** jraim has joined #openstack-keystone | 17:06 | |
| *** anteaya has joined #openstack-keystone | 17:06 | |
| *** Daviey has joined #openstack-keystone | 17:06 | |
| *** dtroyer has joined #openstack-keystone | 17:06 | |
| *** simo has joined #openstack-keystone | 17:06 | |
| *** jamielennox|away has joined #openstack-keystone | 17:06 | |
| *** koolhead17 has joined #openstack-keystone | 17:06 | |
| *** chmouel has joined #openstack-keystone | 17:06 | |
| *** zigo has joined #openstack-keystone | 17:06 | |
| *** mhu has joined #openstack-keystone | 17:06 | |
| *** morganfainberg_Z has joined #openstack-keystone | 17:06 | |
| *** dickson.freenode.net sets mode: +vovo dstanek dolphm jamielennox|away morganfainberg_Z | 17:06 | |
| *** lari_ has joined #openstack-keystone | 17:06 | |
| *** ChanServ has joined #openstack-keystone | 17:06 | |
| *** dickson.freenode.net sets mode: +vo morganfainberg_Z ChanServ | 17:06 | |
| *** leseb_ has joined #openstack-keystone | 17:06 | |
| *** amerine has joined #openstack-keystone | 17:06 | |
| *** bknudson has joined #openstack-keystone | 17:06 | |
| *** sudorandom has joined #openstack-keystone | 17:06 | |
| *** nkinder_ has quit IRC | 17:06 | |
| *** nkinder_ has joined #openstack-keystone | 17:06 | |
| *** jraim has quit IRC | 17:11 | |
| *** gokrokve has quit IRC | 17:13 | |
| *** jraim_ has joined #openstack-keystone | 17:14 | |
| *** jraim_ is now known as jraim | 17:15 | |
| *** lbragstad has joined #openstack-keystone | 17:18 | |
| *** ayoung has joined #openstack-keystone | 17:44 | |
| *** tellesnobrega has joined #openstack-keystone | 17:44 | |
| *** amerine has quit IRC | 17:48 | |
| *** amerine has joined #openstack-keystone | 17:50 | |
| *** chandan_kumar has quit IRC | 17:51 | |
| *** browne has quit IRC | 17:51 | |
| *** chandan_kumar has joined #openstack-keystone | 17:53 | |
| *** gokrokve has joined #openstack-keystone | 17:53 | |
| *** browne has joined #openstack-keystone | 18:00 | |
| *** david_lyle_ is now known as david_lyle | 18:04 | |
| *** richm has joined #openstack-keystone | 18:05 | |
| *** harlowja has joined #openstack-keystone | 18:10 | |
| richm | I've almost got _ldap_livetest.py passing at 100% | 18:18 |
| richm | I have one remaining item | 18:18 |
| richm | assignments/backends/ldap.py - RoleApi.update | 18:19 |
| richm | This does not allow updates if the given name exists | 18:19 |
| richm | Is the intention to disallow name changes? | 18:19 |
| *** morganfainberg_Z is now known as morganfainberg | 18:20 | |
| richm | ayoung: any ideas? | 18:24 |
| bknudson | 16 files changed, 5490 deletions(-) | 18:25 |
| *** leseb_ has quit IRC | 18:25 | |
| *** leseb has joined #openstack-keystone | 18:39 | |
| ayoung | richm, rings a bell. | 18:40 |
| richm | git blame is pointing at you | 18:40 |
| morganfainberg | dstanek, nice catches, text editing like the help strings is challenging when they all look the same | 18:40 |
| ayoung | richm, lunch, and then I'll get back to you | 18:41 |
| *** huats has quit IRC | 18:41 | |
| *** huats_ has joined #openstack-keystone | 18:41 | |
| *** huats_ has quit IRC | 18:41 | |
| *** huats_ has joined #openstack-keystone | 18:41 | |
| richm | ayoung: ok - thanks | 18:43 |
| *** leseb has quit IRC | 18:44 | |
| ayoung | richm, https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/ldap.py#L651 | 18:55 |
| ayoung | is that what you are talking about? | 18:55 |
| *** leseb has joined #openstack-keystone | 18:58 | |
| richm | ayoung: yes | 19:03 |
| ayoung | richm, the only thing morphable on a role is its name. That is supposed to prevent duplication, but it looks like it is just broken | 19:04 |
| ayoung | because of course old_name = self.get_by_name(role['name']) is going to return something. | 19:04 |
| ayoung | I think the right logic would be: | 19:05 |
| ayoung | if old_name['id'] != role_id: .... | 19:06 |
| ayoung | richm, but if the only thing morphable is name, then that logic should not be necessary. | 19:08 |
| richm | ok - so the only thing you should be allowed to change is the name | 19:09 |
| ayoung | richm, because the only thing that should rule out is an update where the name is unchanged...which is a no-op | 19:09 |
| morganfainberg | dstanek, fixed those two other config helpstrings | 19:09 |
| morganfainberg | dstanek, thanks | 19:09 |
| richm | ok | 19:10 |
| ayoung | richm, what test is breaking? | 19:10 |
| richm | test_configurable_allowed_role_actions | 19:11 |
| richm | test_backend_ldap.py | 19:11 |
| *** chandan_kumar has quit IRC | 19:14 | |
| ayoung | richm, OK, so that should probably be dropped out of ldap_backend | 19:15 |
| ayoung | nothing should be in ldap_backend if it can't be execized by live_ldap | 19:15 |
| ayoung | and that is not part of test_backenmd AFAICT | 19:16 |
| ayoung | richm, this line is failing? https://github.com/openstack/keystone/blob/master/keystone/tests/test_backend_ldap.py#L605 | 19:17 |
| richm | yes | 19:17 |
| ayoung | oh, wait, no that should be good | 19:17 |
| ayoung | role['name'] = 'fake2' | 19:18 |
| ayoung | so it should do a search by name for fake2 and that should not trigger a problem | 19:18 |
| richm | hmm - let me check | 19:19 |
| ayoung | richm, I am guessing that we are not properly cleaning out old data | 19:19 |
| ayoung | if role with name fake2 exists prior to this test, it will fail. But it should fail in fakeldap as well, guessing it is in the liveldap cleanup | 19:19 |
| richm | oh, wait | 19:20 |
| richm | so you should not be able to change the description in a role? | 19:20 |
| ayoung | richm, there is no description field on the object | 19:20 |
| richm | ok - there were some tests that tested setting role['description'] = '' | 19:21 |
| richm | ok - looks like they have since been removed | 19:23 |
| richm | I really should git checkout/rebase more often . . . | 19:23 |
| ayoung | heh...shouldn't be getting tripped up by those changes. When were they removed> | 19:26 |
| *** raildo has quit IRC | 19:26 | |
| *** raildo has joined #openstack-keystone | 19:28 | |
| *** nkinder_ has quit IRC | 19:29 | |
| *** nkinder_ has joined #openstack-keystone | 19:33 | |
| *** leseb has quit IRC | 19:36 | |
| *** dolphm is now known as dolphm_503 | 19:37 | |
| *** marekd is now known as marekd|away | 19:39 | |
| *** dstanek_afk has joined #openstack-keystone | 19:41 | |
| *** ChanServ sets mode: +v dstanek_afk | 19:41 | |
| *** dstanek has quit IRC | 19:43 | |
| *** dolphm_503 is now known as dolphm | 19:53 | |
| *** arash__ has joined #openstack-keystone | 19:53 | |
| *** dolphm is now known as dolphm_503 | 19:59 | |
| *** arunkant has joined #openstack-keystone | 20:01 | |
| *** dstanek_afk is now known as dstanek | 20:02 | |
| dstanek | morganfainberg: why is your patch adding back in all of the RPC options? | 20:03 |
| morganfainberg | dstanek, sec | 20:03 |
| morganfainberg | dstanek, because of a merge issue | 20:04 |
| morganfainberg | dstanek, fixing it now. though i think we have some other oddities, a bunch of those options should be attributed to oslo.messaging not RPC | 20:06 |
| morganfainberg | dstanek, *shrug* prob an issue w/ oslo.messaging | 20:06 |
| dstanek | morganfainberg: i was thinking this morning that the auto doc will add option to the sample that we don't support just because the code is in our tree | 20:07 |
| dstanek | morganfainberg: is that true? | 20:07 |
| *** dolphm_503 is now known as dolphm | 20:09 | |
| ayoung | dolphm, when are we going to switch the default policy file to the cloudsample one? Or are we not going to switch? | 20:13 |
| bknudson | dstanek: eventually the oslo.db code will be in a separate library, and we'll have to somehow support the options. | 20:14 |
| bknudson | there's probably options that we don't support already | 20:14 |
| *** dstanek_afk has joined #openstack-keystone | 20:15 | |
| *** ChanServ sets mode: +v dstanek_afk | 20:15 | |
| *** dstanek has quit IRC | 20:15 | |
| *** arash__ has quit IRC | 20:16 | |
| *** dstanek_afk is now known as dstanek | 20:16 | |
| bknudson | I like this option "fake_rabbit" | 20:16 |
| ayoung | bknudson, no...it IS the rabbit | 20:25 |
| *** gokrokve has quit IRC | 20:27 | |
| bknudson | I just hope it doesn't bite anyone's head off. | 20:27 |
| *** gokrokve has joined #openstack-keystone | 20:28 | |
| dstanek | what's the policy for those automatic global config updates? something we push through quickly or sit on for a rainy day? | 20:32 |
| *** gokrokve has quit IRC | 20:32 | |
| bknudson | we push everything through quickly | 20:32 |
| bknudson | why would we want to have a bunch of reviews sitting around? | 20:33 |
| *** leseb has joined #openstack-keystone | 20:33 | |
| dstanek | i wouldn't think you would want that | 20:34 |
| dstanek | i ask because last time i saw one of those it kept having problems because it was out of date | 20:34 |
| dstanek | seems like it fell through the cracks and i didn't know if it was on purpose or not | 20:34 |
| *** harlowja is now known as harlowja_away | 20:35 | |
| bknudson | the pep8 check is going to fail if the sample config is out of sync with the config options | 20:36 |
| dstanek | morganfainberg: did you see my comment on the auto gen doc from above? i seemed to have been booted from the room at about the time i sent it | 20:37 |
| dstanek | bknudson: that's a good point - i'll pull the changes and see if the sample is different | 20:37 |
| morganfainberg | dstanek, i did see it | 20:38 |
| bknudson | nova's pep8 fails every time we add a config option in keystoneclient | 20:38 |
| bknudson | auth_token middleware | 20:38 |
| morganfainberg | bknudson, https://review.openstack.org/#/c/75537 dstanek, | 20:39 |
| morganfainberg | there ya go, not adding old options back in | 20:39 |
| morganfainberg | bknudson, well there is a way around that, but it's not how things are done atm wrt nova | 20:40 |
| dstanek | bknudson, morganfainberg: should that global requirements job be changed to also build the sample config? | 20:42 |
| *** nachi has joined #openstack-keystone | 20:42 | |
| bknudson | dstanek: how's that going to work? the libraries can change out from under keystone and we don't know. | 20:43 |
| bknudson | global requirements typically doesn't have a ceiling. | 20:43 |
| morganfainberg | bknudson, only if you add them to the oslo.config.generator.rc | 20:44 |
| morganfainberg | bknudson, if you don't add the library there, the options can't appear | 20:44 |
| bknudson | morganfainberg: do we want to add the libraries or not add them? | 20:44 |
| morganfainberg | bknudson, the only one we have atm is oslo.messaging | 20:45 |
| morganfainberg | bknudson, i'm fine with not adding any | 20:45 |
| bknudson | so oslo.messaging can come out with a new version with a new config option and now keystone pep8 fails. | 20:45 |
| dstanek | my thought is that as oslo gets broken down into separate packages those will be updated by the job and may have different options | 20:45 |
| morganfainberg | bknudson, i think this is a project-by-project choice, but likely should be decided on by the TC | 20:45 |
| morganfainberg | bknudson, yes, that could happen. | 20:45 |
| morganfainberg | bknudson, we could remove it from the generator.rc | 20:46 |
| morganfainberg | bknudson, but like i said, likely should be a TC decision if all projects include them or not | 20:46 |
| morganfainberg | bknudson, until that occurs, it's a project-by-project choice. | 20:46 |
| bknudson | morganfainberg: do we pass a CONF to oslo.messaging, or separate options? | 20:47 |
| morganfainberg | bknudson, right now, they live in keystone.conf | 20:47 |
| morganfainberg | bknudson, but we could move it into it's own config iirc you can specify multiple config files | 20:47 |
| bknudson | morganfainberg: that's an interesting way to do it... | 20:48 |
| bknudson | then you could share the config among all the services that use that library | 20:48 |
| morganfainberg | bknudson, ++ | 20:48 |
| morganfainberg | bknudson, that the thinking | 20:48 |
| bknudson | in porting oslo.db, the library didn't accept a CONF | 20:49 |
| bknudson | so I had to pass in all the options individually | 20:49 |
| bknudson | if oslo.db adds a config option, it'll be in the sample config but won't get passed to oslo.db. | 20:49 |
| morganfainberg | bknudson, no no, keystone takes multiple config files and aggregates them, look at how we do testing | 20:50 |
| morganfainberg | bknudson, now if it's oslo-incubator stuff, nothing i can do because we do search through and find the options based on .py files | 20:50 |
| morganfainberg | bknudson, and i don't think that should change | 20:50 |
| morganfainberg | bknudson, but if it's a library, it doesn't care as long as the options are there in the CONF object, so you can read from multiple files if you want | 20:51 |
| bknudson | oslo-incubator is only going to change when we sync it, so we don't have to worry about ti changing underneath us. | 20:51 |
| morganfainberg | bknudson, ++ | 20:51 |
| morganfainberg | yrp | 20:51 |
| morganfainberg | yep* | 20:51 |
| bknudson | morganfainberg: https://review.openstack.org/#/c/75549/3/keystone/common/sql/core.py | 20:51 |
| bknudson | see line 177 | 20:52 |
| morganfainberg | bknudson, so it's a question of where we put these options. we can just say "sorry not part of keystone's config" though i think thats a bad idea. if the options change, pep8 likely should fail because we should represent the correct opitons (esp. for something like DB config) | 20:52 |
| morganfainberg | bknudson, i'm not sure what the correct answer is though :( | 20:52 |
| morganfainberg | bknudson, oh ick. | 20:52 |
| bknudson | and https://review.openstack.org/#/c/75549/3/keystone/openstack/common/db/sqlalchemy/session.py | 20:52 |
| morganfainberg | bknudson, =/ | 20:52 |
| bknudson | line 533 | 20:52 |
| morganfainberg | that is lame. | 20:53 |
| bknudson | create_engine doesn't take a conf | 20:53 |
| morganfainberg | oslo.db should have a method that extracts the conf items from CONF | 20:53 |
| morganfainberg | not expect you to explode them out to args | 20:53 |
| bknudson | I'll admit I kind of like the args for a library. | 20:54 |
| bknudson | but then we shouldn't use their config options, we'd make our own. | 20:54 |
| morganfainberg | bknudson, sure. and i wont argue that | 20:54 |
| morganfainberg | bknudson, if they use OSLO.config and provide options, they provide a way to pass conf in | 20:54 |
| morganfainberg | if they don't, we make the options and call it a day | 20:54 |
| morganfainberg | if the library uses oslo.config it's probably too openstack specific to be it's own library anyway. | 20:55 |
| morganfainberg | and by oslo.config stuff i mean oslo.<lib> | 20:56 |
| *** topol has quit IRC | 20:57 | |
| *** harlowja_away is now known as harlowja | 20:58 | |
| morganfainberg | ayoung, look at the lurking list grow | 20:58 |
| *** raildo has quit IRC | 21:02 | |
| *** dolphm is now known as dolphm_503 | 21:07 | |
| *** andreaf has quit IRC | 21:09 | |
| *** leseb has quit IRC | 21:09 | |
| *** hogepodge has joined #openstack-keystone | 21:11 | |
| *** gokrokve has joined #openstack-keystone | 21:17 | |
| *** dolphm_503 is now known as dolphm | 21:18 | |
| *** dolphm is now known as dolphm_503 | 21:25 | |
| *** dolphm_503 is now known as dolphm | 21:26 | |
| *** leseb has joined #openstack-keystone | 21:34 | |
| *** amcrn has joined #openstack-keystone | 21:41 | |
| *** devlaps has quit IRC | 22:07 | |
| *** devlaps has joined #openstack-keystone | 22:07 | |
| ayoung | morganfainberg, can I get an approval here: https://review.openstack.org/#/c/71455/ | 22:15 |
| lbragstad | dolphm: ping? qq on endpoint required parameters | 22:23 |
| dolphm | lbragstad: pong | 22:23 |
| dolphm | lbragstad: https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#endpoints-v3endpoints | 22:25 |
| lbragstad | .. so, endpoints. In the documentation it says that the 'additional required attribs' are service_id, interface, and url (https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#endpoints-v3endpoints).. bu then what about 'name' here? https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#create-endpoint-post-endpoints | 22:25 |
| lbragstad | and the code only checks service_id and interface https://github.com/openstack/keystone/blob/master/keystone/catalog/controllers.py#L243-L244 | 22:26 |
| dolphm | lbragstad: name looks like a bad copy/paste for an endpoint... i don't know why you'd name them | 22:26 |
| lbragstad | is 'name' required too? | 22:26 |
| lbragstad | ok | 22:26 |
| lbragstad | that's what I was thinking but wanted to double check | 22:26 |
| dolphm | lbragstad: propose a delete for endpoint name in that doc? | 22:26 |
| lbragstad | yeah, I can fix that | 22:27 |
| dolphm | lbragstad: names appear to be in all those examples | 22:27 |
| lbragstad | yeah... | 22:27 |
| lbragstad | and what about if we change '...' to 'required'? | 22:27 |
| dolphm | lbragstad: neither openstackclient nor keystoneclient expose --name either | 22:28 |
| dolphm | lbragstad: what's '...' ? | 22:28 |
| lbragstad | "url": "...", | 22:28 |
| lbragstad | https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#create-endpoint-post-endpoints | 22:28 |
| lbragstad | is '...' suppose to imply 'required'? | 22:28 |
| dolphm | lbragstad: ah, all of the --some-attribute-- and "..." and "key": "key" should be populated with real-looking values | 22:29 |
| *** lnxnut has quit IRC | 22:29 | |
| dolphm | lbragstad: so "url": "http://service.example.com/" would be a nice public url example | 22:29 |
| lbragstad | dolphm: I agree | 22:30 |
| lbragstad | ok, I can put that in there too | 22:30 |
| dolphm | all the http:// should also be https:// :) | 22:30 |
| dolphm | lbragstad: the "Example entity" section in the API Resources section of the doc are pretty consistent about using the same ID's throughout -- it'd be nice if that extended through the rest of the doc | 22:31 |
| dolphm | (for example, you can find "domain_id" | 22:31 |
| dolphm | ... "domain_id": "1789d1" used in a bunch of places) | 22:31 |
| lbragstad | you mean like https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#create-an-entity | 22:32 |
| dolphm | lbragstad: further down the doc, like https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#users-v3users | 22:32 |
| dolphm | lbragstad: the example at the bottom of the /v3/users section | 22:32 |
| lbragstad | ok | 22:33 |
| lbragstad | so all the --service-id--, ..., and --optional-- stuff here could be replaced with proper looking values https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#create-endpoint-post-endpoints | 22:37 |
| *** bvandenh has quit IRC | 22:47 | |
| ayoung | morganfainberg, what do I need to do to make the KVS backend for Revocation events work with the dogpile code? | 22:51 |
| ayoung | Its something trivial, right? | 22:52 |
| ayoung | https://review.openstack.org/#/c/55908/55/keystone/contrib/revoke/backends/kvs.py | 22:52 |
| *** lbragstad has quit IRC | 22:52 | |
| *** jamielennox|away is now known as jamielennox | 22:53 | |
| ayoung | bknudson, why call super for a Driver? | 22:55 |
| bknudson | ayoung: should call super for any class in case the super changes their __init__. | 22:55 |
| ayoung | bknudson, not for drivers | 22:55 |
| morganfainberg | ayoung, hmm? | 22:55 |
| ayoung | they are pure virtual | 22:56 |
| ayoung | it would be a mistake to do anythjing in __init__ | 22:56 |
| ayoung | morganfainberg, I assume I need to descend from common/kvs/something | 22:56 |
| morganfainberg | ayoung, uhm... if you look at the token kvs it's pretty straight forward | 22:57 |
| bknudson | I know what a pure virtual function is in C++ - not sure what a class is? | 22:57 |
| ayoung | morganfainberg, backing store? | 22:57 |
| morganfainberg | ayoung, i apologize i am being pulled to some internal stuff. | 22:57 |
| ayoung | morganfainberg, NP | 22:57 |
| ayoung | I'll try and havck through it | 22:57 |
| ayoung | bknudson, its an analogy....in Keystone Driver is just documentation | 22:58 |
| ayoung | we do the abc thing, even, to force people to oveload. It used to be that you'd get "no implemented" errors, but we don;'t even do that anymore. None of our drivers call super | 22:59 |
| *** nkinder_ has quit IRC | 23:00 | |
| bknudson | assignment ldap driver calls super | 23:01 |
| *** marcoemorais has quit IRC | 23:01 | |
| bknudson | most of them don't have __init__ so super __init__ is called implicitly | 23:01 |
| ayoung | ah... | 23:04 |
| ayoung | why does LDAP... | 23:04 |
| *** marcoemorais has joined #openstack-keystone | 23:04 | |
| ayoung | bknudson, so no real reason, just that it is a general coding preference? I can see both sides on this one...I'll keep it consistent, but not sure it is really what we want to be doing. | 23:05 |
| bknudson | ayoung: I think it's easier to just call it all the time rather than have to look to the superclass to figure out if it needs it or not. | 23:06 |
| bknudson | if subclasses of driver shouldn't call super init then that should be documented in the driver classes and enforced somehow. | 23:07 |
| ayoung | bknudson, yeah...and if Python actually gave some sort of Class suport we wouldn't have to reinvent it. | 23:10 |
| dstanek | does our keystone.common.sql.core.initialize_decorator exist only because sqlite doesn't limit string lengths? | 23:17 |
| bknudson | dstanek: I think it's a good idea not trying to guess the behavior of dbs when you give them unexpected data. | 23:19 |
| bknudson | I don't think the SQL standard says what to do if the data doesn't fit in the column. | 23:19 |
| dstanek | bknudson: yes and no, yes i think we should do the validation somethere, but i don't think it belongs there | 23:20 |
| dstanek | and we're not validating any other type | 23:21 |
| bknudson | dstanek: I agree... the validation should be comprehensive and in once place. | 23:21 |
| bknudson | JSONSchema or something. | 23:21 |
| bknudson | whatever other projects are doing | 23:21 |
| *** leseb has quit IRC | 23:30 | |
| *** amcrn has quit IRC | 23:35 | |
| *** dolphm is now known as dolphm_503 | 23:43 | |
| achampion | hopefully someone can point me in the right direction, is there a new means of listing extensions in the v3 api. v2.0/extensions works but v3/extensions doesn't. | 23:49 |
| jamielennox | achampion: unfortunately no | 23:56 |
| jamielennox | achampion: there was a proposal for this but the intent was that you should be able to list the resources available from a controller using links in responses | 23:56 |
| jamielennox | to my knowledge nothing happened on that front | 23:57 |
| achampion | jamielennox: so does that mean v3/extensions has been removed - it is still referreed to in documentation http://api.openstack.org/api-ref-identity.html#identity-v3-ext | 23:57 |
| jamielennox | achampion: hmm, yes that would be a bug | 23:58 |
| jamielennox | that path does not exist | 23:58 |
| *** nkinder_ has joined #openstack-keystone | 23:59 | |
| achampion | jamielennox: ok thanks | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!