*** mylu has quit IRC | 00:08 | |
*** EinstCrazy has quit IRC | 00:08 | |
*** mylu has joined #openstack-keystone | 00:12 | |
*** Navid_ has joined #openstack-keystone | 00:21 | |
*** wwwjfy has joined #openstack-keystone | 00:22 | |
*** shadower has quit IRC | 00:23 | |
*** shadower has joined #openstack-keystone | 00:23 | |
*** Kennan_Vacation2 has quit IRC | 00:25 | |
*** ngupta has quit IRC | 00:25 | |
*** ngupta has joined #openstack-keystone | 00:28 | |
*** Kennan_Vacation has joined #openstack-keystone | 00:30 | |
openstackgerrit | Merged openstack/keystoneauth: remove references to keystone CLI https://review.openstack.org/227658 | 00:32 |
---|---|---|
*** Kennan_Vacation is now known as Kennan | 00:34 | |
*** markvoelker has joined #openstack-keystone | 00:38 | |
*** hidekazu has joined #openstack-keystone | 00:40 | |
*** markvoelker has quit IRC | 00:42 | |
*** Kennan has left #openstack-keystone | 00:56 | |
*** EinstCrazy has joined #openstack-keystone | 01:00 | |
*** mylu has quit IRC | 01:01 | |
*** Navid_ has quit IRC | 01:03 | |
*** david-lyle has joined #openstack-keystone | 01:03 | |
*** lhcheng has quit IRC | 01:10 | |
*** mylu has joined #openstack-keystone | 01:11 | |
*** lhcheng has joined #openstack-keystone | 01:12 | |
*** ChanServ sets mode: +v lhcheng | 01:12 | |
*** dims_ has quit IRC | 01:28 | |
*** wwwjfy_ has joined #openstack-keystone | 01:32 | |
*** BrAsS_mO- has joined #openstack-keystone | 01:36 | |
*** dobson` has joined #openstack-keystone | 01:36 | |
*** dobson has quit IRC | 01:38 | |
*** wwwjfy has quit IRC | 01:38 | |
*** sileht has quit IRC | 01:38 | |
*** BrAsS_mOnKeY has quit IRC | 01:38 | |
*** dimsum__ has joined #openstack-keystone | 01:40 | |
*** sileht has joined #openstack-keystone | 01:40 | |
openstackgerrit | ayoung proposed openstack/keystone-specs: Implied Roles https://review.openstack.org/125704 | 01:46 |
*** akanksha_ has quit IRC | 01:48 | |
openstackgerrit | ayoung proposed openstack/keystone-specs: Implied Roles https://review.openstack.org/125704 | 01:48 |
openstackgerrit | ayoung proposed openstack/keystone-specs: Implied Roles https://review.openstack.org/125704 | 01:49 |
openstackgerrit | ayoung proposed openstack/keystone-specs: Implied Roles https://review.openstack.org/125704 | 01:50 |
*** mylu has quit IRC | 01:52 | |
*** Daisy has joined #openstack-keystone | 01:56 | |
*** ankita_wagh has joined #openstack-keystone | 01:56 | |
*** ankita_wagh has quit IRC | 02:01 | |
*** markvoelker has joined #openstack-keystone | 02:08 | |
*** markvoelker has quit IRC | 02:13 | |
*** davechen has joined #openstack-keystone | 02:13 | |
*** su_zhang has joined #openstack-keystone | 02:26 | |
*** dimsum__ has quit IRC | 02:48 | |
*** davechen has quit IRC | 02:58 | |
*** ankita_wagh has joined #openstack-keystone | 03:01 | |
*** davechen has joined #openstack-keystone | 03:02 | |
*** Ephur has quit IRC | 03:06 | |
*** dimsum__ has joined #openstack-keystone | 03:09 | |
*** davechen1 has joined #openstack-keystone | 03:10 | |
*** dims_ has joined #openstack-keystone | 03:10 | |
*** hidekazu has quit IRC | 03:11 | |
*** davechen has quit IRC | 03:13 | |
*** dimsum__ has quit IRC | 03:14 | |
*** lhcheng has quit IRC | 03:15 | |
*** roxanaghe has joined #openstack-keystone | 03:21 | |
*** Nirupama has joined #openstack-keystone | 03:22 | |
*** dimsum__ has joined #openstack-keystone | 03:25 | |
*** dimsum__ has quit IRC | 03:27 | |
*** dims_ has quit IRC | 03:28 | |
*** ngupta has quit IRC | 03:42 | |
*** wwwjfy_ has quit IRC | 03:48 | |
*** Daisy has quit IRC | 03:49 | |
*** wwwjfy_ has joined #openstack-keystone | 03:50 | |
*** roxanaghe has quit IRC | 03:55 | |
*** roxanaghe has joined #openstack-keystone | 04:07 | |
*** mylu has joined #openstack-keystone | 04:12 | |
*** mylu has quit IRC | 04:16 | |
*** roxanaghe has quit IRC | 04:26 | |
*** dimsum__ has joined #openstack-keystone | 04:27 | |
*** dimsum__ has quit IRC | 04:34 | |
*** Daisy has joined #openstack-keystone | 04:57 | |
*** wwwjfy_ has quit IRC | 04:57 | |
*** wwwjfy_ has joined #openstack-keystone | 05:23 | |
*** hrou has quit IRC | 05:24 | |
*** roxanaghe has joined #openstack-keystone | 05:31 | |
*** roxanaghe has quit IRC | 05:33 | |
*** EinstCrazy has quit IRC | 05:47 | |
*** EinstCrazy has joined #openstack-keystone | 05:48 | |
*** boris-42 has joined #openstack-keystone | 05:56 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Imported Translations from Zanata https://review.openstack.org/228119 | 06:08 |
*** mylu has joined #openstack-keystone | 06:13 | |
*** mylu has quit IRC | 06:17 | |
*** marzif has joined #openstack-keystone | 06:19 | |
*** Nirupama has quit IRC | 06:22 | |
*** ankita_wagh has quit IRC | 06:22 | |
*** Nirupama has joined #openstack-keystone | 06:22 | |
*** ParsectiX has joined #openstack-keystone | 06:27 | |
*** lhcheng has joined #openstack-keystone | 06:29 | |
*** ChanServ sets mode: +v lhcheng | 06:29 | |
*** dimsum__ has joined #openstack-keystone | 06:31 | |
*** ankita_wagh has joined #openstack-keystone | 06:33 | |
*** roxanaghe has joined #openstack-keystone | 06:34 | |
*** dimsum__ has quit IRC | 06:36 | |
*** roxanaghe has quit IRC | 06:39 | |
*** marzif has quit IRC | 06:39 | |
*** su_zhang has quit IRC | 06:46 | |
*** e0ne has joined #openstack-keystone | 06:49 | |
*** kiran-r has joined #openstack-keystone | 06:55 | |
jamielennox | i don't suppose anyone is here, but where is xmldsig coming from? what brings it in? | 06:59 |
*** e0ne has quit IRC | 06:59 | |
*** urulama has joined #openstack-keystone | 07:03 | |
*** e0ne has joined #openstack-keystone | 07:03 | |
*** e0ne has quit IRC | 07:05 | |
jamielennox | found it, it's a dependency of pysaml2 2.X but not pysaml2 3.0.0 released 2015-07-13 | 07:06 |
jamielennox | i'm surprised this isn't breaking our stable branches | 07:06 |
*** rajesht has joined #openstack-keystone | 07:07 | |
*** e0ne has joined #openstack-keystone | 07:09 | |
*** chlong has quit IRC | 07:17 | |
rajesht | hi cores, | 07:32 |
rajesht | need one more +2 before gets into merge conflict | 07:32 |
rajesht | https://review.openstack.org/#/c/226677/ | 07:32 |
rajesht | I have already addressed Tom's comment, | 07:33 |
rajesht | thanks | 07:33 |
*** lhcheng has quit IRC | 07:39 | |
*** topol has joined #openstack-keystone | 07:41 | |
*** ChanServ sets mode: +v topol | 07:41 | |
*** pnavarro has joined #openstack-keystone | 07:41 | |
*** jamielennox is now known as jamielennox|away | 07:50 | |
*** ParsectiX has quit IRC | 07:53 | |
*** e0ne has quit IRC | 07:57 | |
*** Daisy has quit IRC | 07:59 | |
*** akanksha_ has joined #openstack-keystone | 08:00 | |
*** e0ne has joined #openstack-keystone | 08:01 | |
*** ParsectiX has joined #openstack-keystone | 08:14 | |
*** marekd has joined #openstack-keystone | 08:18 | |
*** ChanServ sets mode: +v marekd | 08:19 | |
*** topol has quit IRC | 08:23 | |
*** topol has joined #openstack-keystone | 08:23 | |
*** ChanServ sets mode: +v topol | 08:23 | |
*** roxanaghe has joined #openstack-keystone | 08:23 | |
*** topol has quit IRC | 08:23 | |
*** ankita_wagh has quit IRC | 08:25 | |
*** jaosorior has joined #openstack-keystone | 08:26 | |
*** kiran-r has quit IRC | 08:26 | |
*** roxanaghe has quit IRC | 08:28 | |
*** dimsum__ has joined #openstack-keystone | 08:33 | |
*** jaosorior has quit IRC | 08:34 | |
*** jaosorior has joined #openstack-keystone | 08:38 | |
*** dimsum__ has quit IRC | 08:38 | |
*** ParsectiX has quit IRC | 08:44 | |
*** ParsectiX has joined #openstack-keystone | 08:44 | |
*** kiran-r has joined #openstack-keystone | 08:57 | |
openstackgerrit | Merged openstack/keystoneauth-saml2: Change ignore-errors to ignore_errors https://review.openstack.org/225741 | 08:58 |
*** exploreshaifali has joined #openstack-keystone | 08:59 | |
*** topol has joined #openstack-keystone | 09:05 | |
*** ChanServ sets mode: +v topol | 09:05 | |
*** topol has quit IRC | 09:10 | |
openstackgerrit | henry-nash proposed openstack/keystone-specs: Support virtual roles https://review.openstack.org/226661 | 09:13 |
openstackgerrit | henry-nash proposed openstack/keystone-specs: Support virtual roles https://review.openstack.org/226661 | 09:15 |
*** sdake has joined #openstack-keystone | 09:15 | |
*** ParsectiX has quit IRC | 09:18 | |
*** davechen1 has left #openstack-keystone | 09:29 | |
*** henrynash has quit IRC | 09:29 | |
*** e0ne has quit IRC | 09:33 | |
*** su_zhang has joined #openstack-keystone | 09:35 | |
*** dimsum__ has joined #openstack-keystone | 09:36 | |
*** e0ne has joined #openstack-keystone | 09:38 | |
*** su_zhang has quit IRC | 09:40 | |
*** dimsum__ has quit IRC | 09:45 | |
*** dimsum__ has joined #openstack-keystone | 09:51 | |
*** ParsectiX has joined #openstack-keystone | 09:54 | |
samueldmq | morning keystoners | 10:08 |
*** wwwjfy_ has quit IRC | 10:10 | |
*** roxanaghe has joined #openstack-keystone | 10:11 | |
*** exploreshaifali has quit IRC | 10:11 | |
*** mylu has joined #openstack-keystone | 10:14 | |
*** roxanaghe has quit IRC | 10:16 | |
*** mylu has quit IRC | 10:18 | |
*** kiran-r has quit IRC | 10:22 | |
*** jlvillal has quit IRC | 10:31 | |
*** jlvillal has joined #openstack-keystone | 10:31 | |
*** amakarov_away is now known as amakarov | 10:36 | |
*** e0ne has quit IRC | 10:44 | |
*** e0ne has joined #openstack-keystone | 10:49 | |
*** topol has joined #openstack-keystone | 10:54 | |
*** ChanServ sets mode: +v topol | 10:54 | |
*** e0ne has quit IRC | 10:57 | |
*** topol has quit IRC | 10:58 | |
*** wwwjfy_ has joined #openstack-keystone | 10:59 | |
*** e0ne has joined #openstack-keystone | 11:01 | |
*** doug-fish has joined #openstack-keystone | 11:10 | |
*** mylu has joined #openstack-keystone | 11:15 | |
*** pnavarro is now known as pnavarro|lunch | 11:18 | |
*** mylu has quit IRC | 11:19 | |
*** urulama has quit IRC | 11:23 | |
*** urulama has joined #openstack-keystone | 11:23 | |
*** ParsectiX has quit IRC | 11:30 | |
*** wwwjfy_ has quit IRC | 11:36 | |
*** gordc has joined #openstack-keystone | 11:37 | |
*** e0ne has quit IRC | 11:43 | |
*** chlong has joined #openstack-keystone | 11:43 | |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Rename v3_authenticate_token() to v3_create_token() https://review.openstack.org/226881 | 11:45 |
*** Nirupama has quit IRC | 11:47 | |
*** e0ne has joined #openstack-keystone | 11:47 | |
*** EinstCrazy has quit IRC | 11:49 | |
*** ParsectiX has joined #openstack-keystone | 11:50 | |
*** panbalag has joined #openstack-keystone | 11:51 | |
*** jamielennox|away is now known as jamielennox | 11:52 | |
*** raildo-afk is now known as raildo | 11:57 | |
*** nicodemos has joined #openstack-keystone | 11:57 | |
*** roxanaghe has joined #openstack-keystone | 11:59 | |
panbalag | Hi..Has anyone tested federation for keystone? Wondering which one works best (SAML/OpenID) ? http://docs.openstack.org/developer/keystone/configure_federation.html | 11:59 |
openstackgerrit | Dolph Mathews proposed openstack/keystone-specs: Unified namespaced is_admin policy https://review.openstack.org/189486 | 12:01 |
*** roxanaghe has quit IRC | 12:04 | |
*** agireud has quit IRC | 12:08 | |
*** agireud has joined #openstack-keystone | 12:10 | |
*** EinstCrazy has joined #openstack-keystone | 12:12 | |
*** iurygregory has joined #openstack-keystone | 12:15 | |
marekd | panbalag: both work correctly. | 12:24 |
marekd | panbalag: keystone doesn't handle protocol specific details, it's apache modules that do so | 12:25 |
marekd | we usually test saml more intensively here. | 12:25 |
openstackgerrit | Marek Denis proposed openstack/keystoneauth-saml2: Depend on keystoneauth https://review.openstack.org/186854 | 12:26 |
panbalag | marekd: ok. I'll start with SAML first. | 12:26 |
marekd | panbalag: sure | 12:26 |
*** jamielennox is now known as jamielennox|away | 12:33 | |
*** ParsectiX has quit IRC | 12:33 | |
*** edmondsw has joined #openstack-keystone | 12:35 | |
*** dimsum__ is now known as dims | 12:45 | |
*** markvoelker has joined #openstack-keystone | 12:46 | |
*** henrynash has joined #openstack-keystone | 12:46 | |
*** ChanServ sets mode: +v henrynash | 12:46 | |
openstackgerrit | henry-nash proposed openstack/keystone-specs: Support virtual roles https://review.openstack.org/226661 | 12:52 |
*** pauloewerton has joined #openstack-keystone | 13:00 | |
*** ParsectiX has joined #openstack-keystone | 13:01 | |
henrynash | dolphm: there’s a new version of https://review.openstack.org/#/c/227023/ - if you’re still OK with this, then maybe a +2/A…. | 13:03 |
*** diegows has joined #openstack-keystone | 13:06 | |
*** wwwjfy_ has joined #openstack-keystone | 13:07 | |
dolphm | henrynash: left in an inline comment, but +A | 13:13 |
*** dims_ has joined #openstack-keystone | 13:15 | |
*** pauloewerton has quit IRC | 13:15 | |
openstackgerrit | Merged openstack/keystone-specs: Align API spec for Liberty (3.5) with the changes that merged https://review.openstack.org/227023 | 13:16 |
samueldmq | henrynash: dolphm when were those versions released ? 3/5 vs 3.6 | 13:16 |
samueldmq | 3.5* | 13:16 |
dolphm | samueldmq: it'd be nice if the document included the dates for the recent releases, huh? | 13:17 |
*** dims has quit IRC | 13:17 | |
samueldmq | dolphm: I think so, it would't hurt | 13:17 |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Test revocation race conditions https://review.openstack.org/227995 | 13:18 |
samueldmq | dolphm: and I agree with your comment there, we really need to separate what (already?) has impact in the API (and consequently the enduser/deployer) and what doesn't | 13:18 |
*** dsirrine has joined #openstack-keystone | 13:18 | |
dolphm | lbragstad: i've now seen every single race condition test return both 404 and 200 for fernet https://review.openstack.org/#/c/227995/7/keystone/tests/unit/test_v3_os_revoke.py,unified | 13:20 |
*** pauloewerton has joined #openstack-keystone | 13:20 | |
*** hrou has joined #openstack-keystone | 13:20 | |
lbragstad | dolphm: awesome, I just dug that up to look at it. | 13:21 |
lbragstad | dolphm: what was the reason for the changes to rest.py? | 13:21 |
dolphm | lbragstad: i also added a ton of docs on friday | 13:21 |
dolphm | lbragstad: because we don't have a way to "expect" one of multiple response codes, so i hacked it in | 13:21 |
lbragstad | dolphm: gotcha | 13:21 |
*** richm has joined #openstack-keystone | 13:22 | |
dolphm | lbragstad: next step is to figure out the boundary conditions causing these races like (1.999 -> 2.000 -> 2.001) | 13:22 |
dolphm | lbragstad: and then write more specific tests with hardcoded start times | 13:22 |
*** Guest6879 is now known as zeus | 13:23 | |
*** urulama has quit IRC | 13:24 | |
*** zeus is now known as Guest15093 | 13:24 | |
*** urulama has joined #openstack-keystone | 13:24 | |
*** pnavarro|lunch is now known as pnavarro | 13:25 | |
samueldmq | dolphm: was reviewing and noticed that two sequences were identical, drafted comments and then: | 13:31 |
samueldmq | dolphm: "two of these sequences are mathematically identical. But let's not take that theory for granted!" | 13:31 |
samueldmq | dolphm: that's a trap | 13:31 |
*** dsirrine is now known as dsirrine|call | 13:31 | |
dolphm | samueldmq: a trap? | 13:31 |
samueldmq | dolphm: for reviewers I mean, because I left comments thinking they were valid .. and then you said you wanted to let them that way | 13:32 |
samueldmq | :) | 13:32 |
henrynash | dolphm: thx | 13:36 |
*** akanksha_ has quit IRC | 13:38 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:41 | |
openstackgerrit | henry-nash proposed openstack/keystone-specs: Support virtual roles https://review.openstack.org/226661 | 13:41 |
htruta | dstanek: hey are you around? | 13:42 |
htruta | dstanek: if so, any possibility of merging bug 1479452 in liberty? | 13:42 |
openstack | bug 1479452 in Keystone "Changing resource's domain_id should not be possible" [Wishlist,In progress] https://launchpad.net/bugs/1479452 - Assigned to Henrique Truta (henriquetruta) | 13:42 |
samueldmq | henrynash: hey | 13:42 |
henrynash | samuledmq: hi | 13:42 |
samueldmq | henrynash: are virtual roles == hierarchical roles + domain roles ? | 13:43 |
*** Guest15093 is now known as zeus- | 13:43 | |
*** sdake_ has joined #openstack-keystone | 13:44 | |
*** topol has joined #openstack-keystone | 13:44 | |
*** ChanServ sets mode: +v topol | 13:44 | |
*** zzzeek has joined #openstack-keystone | 13:44 | |
dolphm | lbragstad: somehow this passes http://cdn.pasteraw.com/89494noroi6npj0na4d7snggw4rw7hr .... so what are the transient cases?! grr | 13:46 |
*** Ephur has joined #openstack-keystone | 13:47 | |
*** sdake has quit IRC | 13:47 | |
dolphm | lbragstad: any ideas on how to refactor that to step through the clock without writing a million test classes? | 13:47 |
*** topol has quit IRC | 13:48 | |
*** sdake_ has quit IRC | 13:50 | |
*** clayton has quit IRC | 13:51 | |
lbragstad | dolphm: checking | 13:52 |
lbragstad | dolphm: it's the same pattern, just started at different times, right? | 13:54 |
dolphm | lbragstad: yeah, i have a refactor that is at least easier to maintain ... | 13:55 |
*** ngupta has joined #openstack-keystone | 13:56 | |
*** sdake has joined #openstack-keystone | 13:58 | |
*** clayton has joined #openstack-keystone | 13:58 | |
*** ParsectiX has quit IRC | 14:01 | |
*** topol has joined #openstack-keystone | 14:02 | |
*** ChanServ sets mode: +v topol | 14:02 | |
*** su_zhang has joined #openstack-keystone | 14:02 | |
openstackgerrit | henry-nash proposed openstack/keystone-specs: Clarify is_domain project attribute in API version 3.5 https://review.openstack.org/228469 | 14:04 |
*** stevemar has joined #openstack-keystone | 14:05 | |
*** ChanServ sets mode: +v stevemar | 14:05 | |
*** panbalag has quit IRC | 14:07 | |
*** panbalag has joined #openstack-keystone | 14:11 | |
lbragstad | dolphm: I'm looking through keystone and the only places I see us using datetime.utcnow() is in test_revoke.py, test_auth.py, and test_v3_keystoneclient.py | 14:14 |
lbragstad | everything else appears to use timeutils | 14:14 |
*** slberger has joined #openstack-keystone | 14:14 | |
dolphm | oh f | 14:14 |
dolphm | ah, nvm. i read test_revoke as contrib/revoke | 14:14 |
stevemar | dolphm: o/ | 14:15 |
stevemar | i am in your state | 14:15 |
dolphm | stevemar: again? ugh | 14:15 |
* lbragstad prepares for bbq! | 14:15 | |
stevemar | dolphm: lbragstad i doubt i have time to get to SA again :) | 14:16 |
dolphm | lbragstad: black's? :D | 14:17 |
lbragstad | stevemar: that's fine, Blacks is half way between ;) | 14:17 |
dolphm | ish | 14:20 |
*** phalmos has joined #openstack-keystone | 14:20 | |
lbragstad | dolphm: I'm stumped, everything seems to be using timeutils.utcnow(), which should be stubbed out in our tests... | 14:22 |
lbragstad | dolphm: I'm baffled where the transients are... | 14:23 |
dolphm | lbragstad: stumped by what? | 14:23 |
dolphm | lbragstad: i'm not sure what you're debugging | 14:23 |
henrynash | samueldmq: well, that depends how you define hierarcical roles…as long as you don’t mean implied roles, then ys | 14:23 |
*** topol has quit IRC | 14:23 | |
lbragstad | dolphm: Friday, I was running those tests and one would fail, then three would fail, etc... | 14:24 |
lbragstad | so they seemed to be transient | 14:24 |
samueldmq | henrynash: as virtual roles can contain virtual roles, it can define a kindof hierarchy | 14:24 |
samueldmq | henrynash: that's what I meant | 14:24 |
henrynash | samuedmq: yes | 14:25 |
lbragstad | the last time we discussed it, we thought it was because something wasn't using utcnow() from timeutils (i.e. not using the mocked time we created). | 14:25 |
openstackgerrit | ayoung proposed openstack/keystone-specs: Catalog scoped roles https://review.openstack.org/228477 | 14:26 |
*** topol has joined #openstack-keystone | 14:26 | |
*** ChanServ sets mode: +v topol | 14:26 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Add user domain info to federated fernet tokens https://review.openstack.org/213742 | 14:31 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Add user_domain_id, project_domain_id to auth context https://review.openstack.org/213792 | 14:31 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Add unit test for creating RequestContext https://review.openstack.org/228269 | 14:31 |
openstackgerrit | Brant Knudson proposed openstack/keystone: More info in RequestContext https://review.openstack.org/213595 | 14:31 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Unit tests for fernet validate_v3_token https://review.openstack.org/226557 | 14:31 |
*** e0ne has quit IRC | 14:32 | |
openstackgerrit | Merged openstack/pycadf: Include changelog/history in docs https://review.openstack.org/227585 | 14:33 |
*** e0ne has joined #openstack-keystone | 14:34 | |
*** dims has joined #openstack-keystone | 14:35 | |
*** dims_ has quit IRC | 14:35 | |
*** alextricity has quit IRC | 14:35 | |
*** jorge_munoz has joined #openstack-keystone | 14:36 | |
*** tonytan4ever has joined #openstack-keystone | 14:37 | |
*** diazjf has joined #openstack-keystone | 14:39 | |
lbragstad | dolphm: can you get those to fail? | 14:44 |
lbragstad | dolphm: nvm, it's probably because of the wildcard status | 14:45 |
dolphm | lbragstad: oh yeah, see the current patchset | 14:45 |
dolphm | lbragstad: i've gotten both responses on every test | 14:45 |
dolphm | lbragstad: i'm trying to identify the edge cases where those occur now | 14:45 |
stevemar | who wants to review release notes?! :) | 14:45 |
*** zzzeek_ has joined #openstack-keystone | 14:45 | |
*** ngupta has quit IRC | 14:47 | |
*** zzzeek has quit IRC | 14:48 | |
*** zzzeek_ is now known as zzzeek | 14:48 | |
*** jorge_munoz has quit IRC | 14:48 | |
*** iurygregory has quit IRC | 14:51 | |
* dolphm *crickets* | 14:54 | |
stevemar | dolphm: eh eh eh | 14:54 |
bknudson | stevemar: do you have a link? | 14:54 |
stevemar | bknudson: the etherpad https://etherpad.openstack.org/p/keystone-liberty-release-notes | 14:55 |
htruta | henrynash: hey | 14:55 |
*** pauloewerton has quit IRC | 14:55 | |
*** nicodemos has quit IRC | 14:55 | |
bknudson | stevemar: where's the release notes? at the bottom? | 14:55 |
*** jorge_munoz has joined #openstack-keystone | 14:56 | |
*** nicodemos has joined #openstack-keystone | 14:56 | |
*** nicodemos has quit IRC | 14:57 | |
stevemar | bknudson: yep, i was thinking we could review them a bit more real time instead of leaving remarks on etherpad | 14:58 |
*** alextricity has joined #openstack-keystone | 14:59 | |
*** tellesnobrega is now known as tellesnobrega_af | 14:59 | |
*** ngupta has joined #openstack-keystone | 15:02 | |
*** yottatsa has joined #openstack-keystone | 15:03 | |
samueldmq | henrynash: there is a paragraph in the spec that you talk about system capabilities | 15:09 |
*** jdennis1 has quit IRC | 15:09 | |
*** ayoung has joined #openstack-keystone | 15:09 | |
*** ChanServ sets mode: +v ayoung | 15:09 | |
samueldmq | henrynash: I wonder how realistic is that to get in openstack, in your opinion | 15:11 |
*** jdennis has joined #openstack-keystone | 15:12 | |
*** arunkant has quit IRC | 15:15 | |
*** tonytan4ever has quit IRC | 15:17 | |
*** thiagop has quit IRC | 15:18 | |
*** ericksonsantos has quit IRC | 15:19 | |
*** arunkant has joined #openstack-keystone | 15:21 | |
*** henrynash_ has joined #openstack-keystone | 15:21 | |
*** ChanServ sets mode: +v henrynash_ | 15:21 | |
*** yottatsa has quit IRC | 15:23 | |
*** henrynash has quit IRC | 15:23 | |
*** henrynash_ is now known as henrynash | 15:23 | |
*** urulama has quit IRC | 15:23 | |
dolphm | lbragstad: this bug is going to make me go insane | 15:24 |
lbragstad | dolphm: ++ | 15:24 |
*** urulama has joined #openstack-keystone | 15:24 | |
lbragstad | dolphm: this one is tough... | 15:24 |
dolphm | i'm now fighting a race condition between the tests and the test suite. | 15:24 |
lbragstad | dolphm: two fridays ago it made me start rethinking my life choices | 15:24 |
lbragstad | dolphm: so you get different behavior between running a single test versus the whole test suite? | 15:25 |
dolphm | lbragstad: no... because we're freezing the clock, sometimes the "admin" token being used to run the tests becomes invalid | 15:26 |
lbragstad | dolphm: weird... | 15:26 |
dolphm | lbragstad: at your desk? | 15:27 |
*** wwwjfy_ is now known as wwwjfy | 15:27 | |
*** browne has joined #openstack-keystone | 15:27 | |
lbragstad | yeah... | 15:27 |
lbragstad | dolphm: yep | 15:27 |
dolphm | lbragstad: alright, i'll swing by in 15 min or so | 15:27 |
lbragstad | dolphm: I need a coffee though | 15:27 |
stevemar | our lack of v2 tests in keystone is unsettling | 15:31 |
stevemar | we don't really have things that test the routes, afaict | 15:31 |
openstackgerrit | Tom Cocozzello proposed openstack/keystone: Deprecate httpd/keystone.py https://review.openstack.org/221975 | 15:31 |
bknudson | stevemar: we have a bunch of REST tests in test_v2_* that uses the routes -- http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/test_v2.py#n138 | 15:32 |
stevemar | bknudson: i dont see many user or tenant creates there | 15:33 |
bknudson | why would anyone use v2 to create a user or tenant? | 15:33 |
stevemar | bknudson: i was looking for straight CRUD tests | 15:34 |
stevemar | bknudson: cause everyone still does that :) | 15:34 |
bknudson | stevemar: there's tests that use the client to do the rest call: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/test_v2_keystoneclient.py#n218 | 15:35 |
stevemar | bknudson: yep, i knows | 15:35 |
stevemar | bknudson: i was looking to resolve https://bugs.launchpad.net/keystone/+bug/1485035 and creating the tests was a bit wonky | 15:36 |
openstack | Launchpad bug 1485035 in Keystone "cadf payload doesn't have initiator for v2 calls" [Medium,Triaged] - Assigned to Sam Leong (chio-fai-sam-leong) | 15:36 |
*** yottatsa has joined #openstack-keystone | 15:37 | |
stevemar | i ended up just calling the controller with a mocked up context | 15:37 |
bknudson | that's the right way to do it | 15:37 |
stevemar | \o/ | 15:37 |
stevemar | i'll put that up soonish | 15:37 |
*** roxanaghe_ has quit IRC | 15:41 | |
*** btully has quit IRC | 15:43 | |
*** dims has quit IRC | 15:46 | |
*** dims has joined #openstack-keystone | 15:46 | |
*** phalmos has quit IRC | 15:47 | |
openstackgerrit | Tony Wang proposed openstack/keystone: Show v3 endpoints in v2 endpoint list https://review.openstack.org/215870 | 15:50 |
*** doug-fish has quit IRC | 15:50 | |
*** doug-fish has joined #openstack-keystone | 15:51 | |
*** ngupta_ has joined #openstack-keystone | 15:54 | |
*** doug-fish has quit IRC | 15:55 | |
*** geoffarnold has joined #openstack-keystone | 15:56 | |
openstackgerrit | Merged openstack/keystone: Add unit tests for token_to_auth_context https://review.openstack.org/213797 | 15:57 |
*** ngupta has quit IRC | 15:57 | |
*** mylu has joined #openstack-keystone | 15:58 | |
stevemar | dstanek: new patch up ^ | 15:59 |
openstackgerrit | Merged openstack/keystone: Fix order of arguments in assertEqual https://review.openstack.org/226677 | 16:00 |
*** akanksha_ has joined #openstack-keystone | 16:02 | |
*** phalmos has joined #openstack-keystone | 16:03 | |
*** yottatsa has quit IRC | 16:04 | |
*** mylu has quit IRC | 16:10 | |
*** mylu has joined #openstack-keystone | 16:10 | |
*** su_zhang has quit IRC | 16:11 | |
*** iurygregory has joined #openstack-keystone | 16:12 | |
*** tellesnobrega_af is now known as tellesnobrega | 16:13 | |
*** mylu has quit IRC | 16:15 | |
dolphm | lbragstad: http://cdn.pasteraw.com/1q48rrzcek35s7yr834ke3uwg8i5cnd | 16:16 |
*** yottatsa has joined #openstack-keystone | 16:18 | |
*** e0ne has quit IRC | 16:22 | |
*** EinstCrazy has quit IRC | 16:23 | |
*** jdennis has quit IRC | 16:24 | |
*** jdennis has joined #openstack-keystone | 16:24 | |
*** e0ne has joined #openstack-keystone | 16:24 | |
*** topol has quit IRC | 16:26 | |
*** gyee has joined #openstack-keystone | 16:28 | |
*** ChanServ sets mode: +v gyee | 16:28 | |
*** roxanaghe has joined #openstack-keystone | 16:31 | |
*** tonytan4ever has joined #openstack-keystone | 16:32 | |
*** _cjones_ has joined #openstack-keystone | 16:32 | |
*** yottatsa has quit IRC | 16:33 | |
*** ayoung has quit IRC | 16:37 | |
*** alejandrito has joined #openstack-keystone | 16:39 | |
*** yottatsa has joined #openstack-keystone | 16:43 | |
*** yottatsa has quit IRC | 16:43 | |
bknudson | dstanek: https://bugs.launchpad.net/keystone/+bug/1500509 | 16:45 |
openstack | Launchpad bug 1500509 in Keystone "Define paste entrypoints" [Wishlist,New] | 16:45 |
*** lhcheng has joined #openstack-keystone | 16:45 | |
*** ChanServ sets mode: +v lhcheng | 16:45 | |
*** sdake_ has joined #openstack-keystone | 16:46 | |
*** yottatsa has joined #openstack-keystone | 16:48 | |
*** sdake has quit IRC | 16:49 | |
*** su_zhang has joined #openstack-keystone | 16:51 | |
*** yottatsa has quit IRC | 16:53 | |
*** ankita_wagh has joined #openstack-keystone | 17:00 | |
*** gyee has quit IRC | 17:03 | |
*** ankita_wagh has quit IRC | 17:05 | |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Materialized path mixin for hierarchical models https://review.openstack.org/198418 | 17:09 |
*** topol has joined #openstack-keystone | 17:12 | |
*** ChanServ sets mode: +v topol | 17:12 | |
*** stevemar has quit IRC | 17:13 | |
*** r-daneel has joined #openstack-keystone | 17:16 | |
*** ayoung has joined #openstack-keystone | 17:17 | |
*** ChanServ sets mode: +v ayoung | 17:17 | |
*** stevemar has joined #openstack-keystone | 17:19 | |
*** ChanServ sets mode: +v stevemar | 17:19 | |
*** gyee has joined #openstack-keystone | 17:19 | |
*** ChanServ sets mode: +v gyee | 17:19 | |
*** ankita_wagh has joined #openstack-keystone | 17:23 | |
*** browne has quit IRC | 17:23 | |
iurygregory | Hey people, just a doubt about K2K Federation, the file generated by "keystone-manage saml_idp_metadata" need to be readable by everyone (mode 664) ? | 17:29 |
stevemar | iurygregory: oh, that's probably the default that is generated | 17:37 |
dstanek | bknudson: ++ i definitely support that idea | 17:38 |
iurygregory | thanks stevemar ^^ , richm please take a look | 17:40 |
richm | iurygregory: ok, that's the default, but does it really need to be world readable? | 17:42 |
iurygregory | richm, I think in puppet we can let this file just be readable by the user who is the owner of the keystone directory | 17:46 |
richm | ok | 17:47 |
*** pnavarro has quit IRC | 17:49 | |
*** zeus- is now known as zeus | 17:51 | |
*** zeus has quit IRC | 17:51 | |
*** zeus has joined #openstack-keystone | 17:51 | |
*** geoffarnold has quit IRC | 17:52 | |
*** geoffarn_ has joined #openstack-keystone | 17:52 | |
*** doug-fish has joined #openstack-keystone | 17:52 | |
*** doug-fish has quit IRC | 17:57 | |
*** doug-fish has joined #openstack-keystone | 17:58 | |
*** ankita_w_ has joined #openstack-keystone | 17:59 | |
stevemar | ayoung: bknudson dstanek gyee lhcheng henrynash marekd make sure y'all read https://review.openstack.org/#/c/181393/ -- it's a cross-project spec that impacts keystone | 18:01 |
stevemar | bknudson: you've already taken a looksy | 18:01 |
*** doug-fish has quit IRC | 18:02 | |
ayoung | stevemar, so...yes, and we should also look at how we transition the token used when going from one service to another. Getting things out of the service catalog good, but then the client needs to know that it needs to get antoher token.... | 18:03 |
ayoung | kindof the K2K excahnge, but local | 18:03 |
*** browne has joined #openstack-keystone | 18:03 | |
*** ankita_wagh has quit IRC | 18:03 | |
ayoung | I know, I know, I always take up a notch... | 18:03 |
*** iurygregory has quit IRC | 18:04 | |
stevemar | you wouldn't be you if you didn't :) | 18:04 |
*** mylu has joined #openstack-keystone | 18:04 | |
*** gabriel-bezerra has quit IRC | 18:04 | |
ayoung | stevemar, wrote some stuff over the weekend whoich kindof applied: | 18:04 |
gyee | stevemar, thanks, SC's my favorite topic :) | 18:04 |
*** mylu has quit IRC | 18:04 | |
*** amakarov is now known as amakarov_away | 18:05 | |
ayoung | stevemar, https://review.openstack.org/#/c/228477/ was based on a suggestiong by dolphm , to deal with the "we deleted the project but we still have vms" issue...and it should solve bug 968696 | 18:05 |
openstack | bug 968696 in OpenStack Compute (nova) ""admin"-ness not properly scoped" [High,Confirmed] https://launchpad.net/bugs/968696 | 18:05 |
ayoung | I also got implied roles working...but I'm keeping that in github as I try to get the patch clean; don | 18:06 |
ayoung | 't | 18:06 |
ayoung | don't want 100 iterations on that one | 18:06 |
ayoung | but I did redo the spec for it; | 18:06 |
gyee | ayoung, I like implied roles, but why can't we call them role groups? | 18:06 |
*** doug-fish has joined #openstack-keystone | 18:06 | |
ayoung | https://review.openstack.org/#/c/125704/ | 18:06 |
gyee | they are essentially nested role groups aren't they? | 18:07 |
ayoung | gyee, because they are not groups. They are rules which build sets | 18:07 |
ayoung | gyee, its inference from rules. And, they are directed, so not really a proper group either | 18:07 |
ayoung | gyee, also, it leads in to what henrynash wanted, which is we should be able to make some roles that are only used to infer other roles, but don't end up in the token themselves | 18:08 |
ayoung | but that is follow on | 18:08 |
*** roxanaghe has quit IRC | 18:08 | |
samueldmq | ayoung: gyee: henrynash has a new spec for 'virtual roles', which is strongly related to what is being proposed | 18:08 |
samueldmq | ayoung: gyee: see https://review.openstack.org/#/c/226661/ | 18:08 |
*** doug-fis_ has joined #openstack-keystone | 18:08 | |
ayoung | samueldmq, ah, I knew he was working on it | 18:08 |
gyee | ah, let me read up | 18:08 |
ayoung | samueldmq, I think I can implement that now | 18:09 |
ayoung | samueldmq, my branch is here: https://github.com/admiyo/keystone/tree/implied_roles | 18:09 |
samueldmq | ayoung: what is in that spec ? | 18:09 |
samueldmq | ayoung: what do you have so far? | 18:09 |
ayoung | samueldmq, it coveres the implied-roles spec...link in a sec | 18:09 |
ayoung | https://review.openstack.org/#/c/125704/ | 18:10 |
gyee | looks like henrynash and ayoung needs to consolidate, I see similarities | 18:10 |
ayoung | gyee, his should build on mine | 18:10 |
*** doug-fish has quit IRC | 18:10 | |
samueldmq | ayoung: yes, I agree with gyee, and yes again, looks like his idea builds on yours, but we need to ensure things are synced from the start | 18:11 |
samueldmq | to avoid .. you know | 18:11 |
*** su_zhang has quit IRC | 18:11 | |
*** su_zhang_ has joined #openstack-keystone | 18:12 | |
samueldmq | ayoung: I am gonna abandon the old dynamic policies changes for now | 18:12 |
ayoung | samueldmq, I want to get this on the Agenda for tomorrow | 18:12 |
samueldmq | ayoung: I feel bad to see them in my gerrit page ehhe | 18:12 |
samueldmq | ayoung: ++ | 18:12 |
*** nisha_ has joined #openstack-keystone | 18:13 | |
ayoung | samueldmq, yeah, we'll loop back around. I want to discuss splitting policy first, and the n dynamic policy should be a lot less threatening | 18:13 |
ayoung | samueldmq, leave them active | 18:13 |
samueldmq | ayoung: also, we are in another approach now, looking at roles first | 18:13 |
ayoung | we want them reviewed and discusseds leading in to the summit...right now is the most important time in keystone development | 18:13 |
gyee | ayoung, I don't understand, I see the same idea between you and henrynash, except his also contains domain-owned roles | 18:13 |
ayoung | gyee, yeah, we are very close in concept | 18:14 |
*** tonytan4ever has quit IRC | 18:14 | |
ayoung | his also incorporate role namespacing, which mine does not | 18:14 |
ayoung | its really 3 separate mechanisms which build up; | 18:14 |
ayoung | inference, namespacing, virtual | 18:14 |
*** tonytan4ever has joined #openstack-keystone | 18:14 | |
gyee | yeah, there are pros and cons with namespacing | 18:15 |
*** raildo is now known as raildo-afk | 18:16 | |
*** tellesnobrega is now known as tellesnobrega_af | 18:16 | |
gyee | and I don't think we need the virtual flag either | 18:16 |
*** gabriel-bezerra has joined #openstack-keystone | 18:17 | |
nisha_ | Hello! I am Nisha, an outreachy aspirant and I want to contribute in keystone. I am beginner so, I would really appreciate if anyone could please suggest me something. | 18:17 |
*** iurygregory has joined #openstack-keystone | 18:18 | |
ayoung | nisha_, excellent. We have a weekly meeting on Tuesdays...I'd joing | 18:19 |
ayoung | nisha_, https://wiki.openstack.org/wiki/Meetings/KeystoneMeeting#Agenda_for_next_meeting | 18:19 |
gyee | nisha_, where I work I usually have a beginner start with documentation validation, tests, and code reviews | 18:19 |
*** tellesnobrega_af is now known as tellesnobrega | 18:20 | |
ayoung | nisha_, just wrote this; might not be a bad way to start; http://adam.younglogic.com/2015/09/keystone-unit-tests/ | 18:20 |
ayoung | start with devtack, make sure you can run unit tests...start looking at reviews nisha_ | 18:20 |
*** mylu has joined #openstack-keystone | 18:20 | |
*** topol has quit IRC | 18:21 | |
nisha_ | thanks a lot ayoung :D | 18:22 |
*** mestery_afk is now known as mestery | 18:22 | |
*** ankita_wagh has joined #openstack-keystone | 18:23 | |
*** gabriel-bezerra has quit IRC | 18:23 | |
*** pnavarro has joined #openstack-keystone | 18:23 | |
*** iurygregory has quit IRC | 18:24 | |
*** ankita_w_ has quit IRC | 18:26 | |
*** sdake has joined #openstack-keystone | 18:29 | |
nisha_ | ayoung, I am not able to open the second link, can you please resend me ? | 18:30 |
ayoung | http://adam.younglogic.com/2015/09/keystone-unit-tests/ that one? | 18:31 |
*** sdake_ has quit IRC | 18:31 | |
samueldmq | nisha_: heelo, I saw your pm and tried to reply earlier, but looks like someone else owned that nickname :) | 18:32 |
nisha_ | yeah, it is not opening, says connection timed out. Otherwise I will try it again later | 18:32 |
nisha_ | haha, I am so glad that people are so eager to help the newbies here :D | 18:33 |
nisha_ | thanks samueldmq | 18:33 |
*** pnavarro has quit IRC | 18:36 | |
*** tellesnobrega is now known as tellesnobrega_af | 18:37 | |
*** topol has joined #openstack-keystone | 18:44 | |
*** ChanServ sets mode: +v topol | 18:44 | |
samueldmq | ayoung: gyee this week I will work in a doc for new developers .. | 18:45 |
ayoung | samueldmq, nice | 18:45 |
samueldmq | I plan to do something guided by example | 18:45 |
*** urulama has quit IRC | 18:45 | |
dolphm | lbragstad: other than having to pass datetimes to it as strings, this seems to freeze whatever non-timeutils source of time that keystone is picking up https://github.com/spulec/freezegun | 18:46 |
samueldmq | like, let' add a new field to domain objects, how to do so ? | 18:46 |
*** urulama has joined #openstack-keystone | 18:46 | |
samueldmq | ayoung: gyee and then I go through the keystone layers, explain what we do in each one, tests, etc.. and at the end we will have the feature implemented (add an attribute to domain) | 18:46 |
*** topol has quit IRC | 18:46 | |
samueldmq | ayoung: gyee where to write tests, etc | 18:47 |
samueldmq | sounds worth it ? | 18:47 |
gyee | samueldmq, like extending developer.rst? | 18:47 |
*** topol has joined #openstack-keystone | 18:47 | |
*** ChanServ sets mode: +v topol | 18:47 | |
gyee | samueldmq, https://github.com/openstack/keystone/blob/master/doc/source/developing.rst | 18:47 |
samueldmq | gyee: yes, a new subsection there | 18:47 |
samueldmq | gyee: yes, but something to be done by the new contributor, not just definitions, and theory, but some complete change one can do | 18:49 |
samueldmq | and see how it happens to work | 18:49 |
lbragstad | dolphm: interesting, i saw that project but i haven't played with it | 18:50 |
gyee | samueldmq, hey look, there's Getting Started section missing. :) https://github.com/openstack/keystone/blob/master/doc/source/index.rst | 18:50 |
samueldmq | gyee: is that page waiting for me ? | 18:51 |
samueldmq | looks to be the case | 18:51 |
samueldmq | gyee: :) | 18:51 |
gyee | samueldmq, its calling out to you | 18:51 |
*** topol has quit IRC | 18:52 | |
*** mylu has quit IRC | 18:53 | |
*** su_zhang_ has quit IRC | 18:53 | |
*** mylu has joined #openstack-keystone | 18:53 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Enable try_except_pass Bandit test https://review.openstack.org/225738 | 18:54 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Enable subprocess_without_shell_equals_true Bandit test https://review.openstack.org/225692 | 18:54 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Enable Bandit 0.13.2 tests https://review.openstack.org/225347 | 18:54 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Enable hardcoded_bind_all_interfaces Bandit test https://review.openstack.org/225690 | 18:54 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Enable password_config_option_not_marked_secret Bandit test https://review.openstack.org/225691 | 18:54 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Update bandit blacklist_calls config https://review.openstack.org/225327 | 18:54 |
openstackgerrit | Brant Knudson proposed openstack/keystone: Update bandit blacklist_imports config https://review.openstack.org/225341 | 18:54 |
dolphm | lbragstad: PYPI/CRYPTOGRAPHY! | 18:54 |
dolphm | lbragstad: the source of fernet token creation times! | 18:54 |
samueldmq | gyee: okay, let's see what can be done there o/ | 18:54 |
*** ankita_wagh has quit IRC | 18:56 | |
*** mylu has quit IRC | 18:57 | |
lbragstad | dolphm: ? | 18:57 |
lbragstad | dolphm: how is that breaking things? | 18:57 |
dolphm | lbragstad: i don't know exactly, but it's certainly not using timeutils.utcnow() to generate fernet tokens | 18:58 |
lbragstad | dolphm: nope, it uses time.time() | 18:58 |
dolphm | lbragstad: so it could be creating tokens in the future, or in the past | 18:58 |
lbragstad | https://github.com/pyca/cryptography/blob/master/src/cryptography/fernet.py#L49 | 18:58 |
dolphm | relative to frozen time | 18:59 |
*** boris-42 has quit IRC | 18:59 | |
*** ayoung has quit IRC | 19:01 | |
*** mylu has joined #openstack-keystone | 19:04 | |
lbragstad | dolphm: that would make sense... because that's the time that we base the creation off of | 19:05 |
*** mylu has quit IRC | 19:05 | |
*** topol has joined #openstack-keystone | 19:07 | |
*** ChanServ sets mode: +v topol | 19:07 | |
dolphm | lbragstad: I GOT IT! woo | 19:09 |
lbragstad | dolphm: \o/ | 19:09 |
lbragstad | dolphm: did you stub it out? | 19:09 |
dolphm | lbragstad: now we either need to carry this new dep or re-implemnt it | 19:09 |
lbragstad | dolphm: doesn't look like it's in global reqs | 19:10 |
dolphm | i figured now | 19:12 |
dolphm | not* | 19:12 |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Test revocation race conditions https://review.openstack.org/227995 | 19:13 |
dolphm | lbragstad: if you install freezegun, the two edge cases we're aware of are the only two that fail against fernet ^ | 19:13 |
lbragstad | dolphm: and those are expected. | 19:14 |
lbragstad | with the current implementation | 19:14 |
lbragstad | of fernet and revocation | 19:14 |
morgan | Ugh time.time() really?! | 19:14 |
morgan | ... | 19:14 |
dolphm | morgan: what's wrong with time.time()? | 19:14 |
morgan | Well i guess most of the time creation doesnt matter | 19:15 |
morgan | Time.time is tz affected isnt t? | 19:15 |
morgan | It is system clock not utc | 19:15 |
* morgan may be misremembering | 19:15 | |
*** jdennis1 has joined #openstack-keystone | 19:16 | |
lbragstad | it returns a number - 1443467753.325383 | 19:16 |
dolphm | morgan: correct, so set your system clock to UTC like a sane person :) | 19:16 |
*** jdennis has quit IRC | 19:16 | |
morgan | dolphm: except we use utc explictly in revocation events | 19:16 |
morgan | Meaning we have a potential issue if system clock is set differently | 19:16 |
dolphm | actually... | 19:17 |
morgan | We may need to introduce a tzoffset value in the fernet payload ? | 19:17 |
morgan | I mean - that is easy. | 19:18 |
morgan | But it is something we need to address. | 19:18 |
dolphm | morgan: it's based on the system clock, of course, but it seems to be in UTC, not system tz | 19:19 |
morgan | And time.time() also usually wont include leap seconds | 19:19 |
morgan | Fwiw | 19:19 |
*** ankita_wagh has joined #openstack-keystone | 19:19 | |
morgan | Ah epoch is defined as utc | 19:20 |
morgan | Ok so we only have some cases where leap seconds are omitted. | 19:20 |
morgan | Meh | 19:20 |
morgan | http://stackoverflow.com/questions/11845803/is-pythons-time-time-timezone-specific | 19:20 |
morgan | Pypy may return something else as may jython, or ironpython, or stackless. But only cpython is tested for keystone | 19:22 |
bknudson | add a unit test | 19:22 |
dolphm | morgan: http://cdn.pasteraw.com/zbnkax5mc0bsplid3vcp2syi503iog | 19:22 |
morgan | dolphm: yeah | 19:23 |
dolphm | morgan: ah, the explanation makes sense | 19:23 |
morgan | Yep. :) | 19:23 |
morgan | Though i am going to hazard a guess utcnow does much the same thing | 19:24 |
morgan | Except it uses a datetime object out the other end | 19:24 |
morgan | So less ambiguity regarding "what is epoch" | 19:25 |
dolphm | this freezegun project is particularly well done | 19:26 |
dolphm | lbragstad: i doubt it would have any trouble landing in global requirements ^ | 19:27 |
lbragstad | dolphm: think we could get in it g-r? | 19:27 |
lbragstad | if it helps us with timing tests, chances are other projects could use it, too | 19:28 |
*** e0ne has quit IRC | 19:28 | |
dolphm | we could replace the implementation of frozen time in timeutils with this, but then it wouldn't be a test requirement | 19:28 |
dolphm | (it'd be implicit for everyone except timeutils) | 19:28 |
*** urulama has quit IRC | 19:29 | |
*** urulama has joined #openstack-keystone | 19:29 | |
*** e0ne has joined #openstack-keystone | 19:41 | |
*** packet has joined #openstack-keystone | 19:41 | |
*** woodster_ has joined #openstack-keystone | 19:42 | |
*** btully has joined #openstack-keystone | 19:43 | |
lbragstad | dolphm: maybe we could ask dhellmann? | 19:46 |
*** pnavarro has joined #openstack-keystone | 19:48 | |
*** ayoung has joined #openstack-keystone | 19:48 | |
*** ChanServ sets mode: +v ayoung | 19:48 | |
*** iurygregory has joined #openstack-keystone | 19:49 | |
*** su_zhang has joined #openstack-keystone | 19:50 | |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth: Add url as a deprecated alias for endpoint https://review.openstack.org/225453 | 19:50 |
*** jlvillal has quit IRC | 19:51 | |
*** tellesnobrega_af is now known as tellesnobrega | 19:51 | |
*** jlvillal has joined #openstack-keystone | 19:51 | |
*** pnavarro has quit IRC | 19:53 | |
mordred | bknudson: any suggestions on how to structure a test for that ^^ ? | 19:55 |
bknudson | mordred: is there a test already that uses the non-deprecated value? | 19:55 |
bknudson | (if not there should be... and if so it's just use that with the other name) | 19:56 |
mordred | bknudson: nope. all of the tests of that just instantiate the class with values | 19:56 |
*** gabriel-bezerra has joined #openstack-keystone | 19:57 | |
*** raildo-afk is now known as raildo | 19:57 | |
bknudson | there's a keystoneauth1.tests.unit.test_token_endpoint.AdminTokenTest.test_token_endpoint_options which fails if I change the name of endpoint to endpoint2. | 19:58 |
mordred | bknudson: nod. I can at least do something there | 19:58 |
*** su_zhang has quit IRC | 19:58 | |
bknudson | should be able to find the option and see the deprecated name. | 19:59 |
*** tonytan4ever has quit IRC | 20:01 | |
*** jsavak has joined #openstack-keystone | 20:02 | |
openstackgerrit | henry-nash proposed openstack/keystone: Add API route for list role assignments for tree https://review.openstack.org/220452 | 20:04 |
*** pnavarro has joined #openstack-keystone | 20:05 | |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth: Add url as a deprecated alias for endpoint https://review.openstack.org/225453 | 20:06 |
mordred | bknudson: how's that look? | 20:07 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth: Add url as a deprecated alias for endpoint https://review.openstack.org/225453 | 20:07 |
*** ngupta_ has quit IRC | 20:07 | |
mordred | (oops. commit message - had edited it via web before :) ) | 20:07 |
*** jsavak has quit IRC | 20:08 | |
*** jsavak has joined #openstack-keystone | 20:08 | |
stevemar | mordred: see, 3 hr meetings are good for working on patches | 20:09 |
mordred | stevemar: SO GOOD | 20:09 |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Test revocation race conditions https://review.openstack.org/227995 | 20:10 |
openstackgerrit | Dolph Mathews proposed openstack/keystone: Test revocation race conditions https://review.openstack.org/227995 | 20:13 |
*** david-lyle has quit IRC | 20:14 | |
dolphm | lbragstad: the gate job on that should pass ^^ and it includes an explanation of the bug/behavior that fernet is seeing, without really pointing fingers ;) | 20:15 |
lbragstad | dolphm: awesome, checking | 20:17 |
*** sdake_ has joined #openstack-keystone | 20:25 | |
*** su_zhang has joined #openstack-keystone | 20:27 | |
*** sdake has quit IRC | 20:28 | |
*** raildo is now known as raildo-afk | 20:29 | |
stevemar | hey, group list use printed all the groups in all the domains from the cli, that seems weird | 20:29 |
*** jdennis has joined #openstack-keystone | 20:32 | |
*** ngupta has joined #openstack-keystone | 20:33 | |
*** jdennis1 has quit IRC | 20:35 | |
*** boris-42 has joined #openstack-keystone | 20:37 | |
*** sdake_ is now known as sdake | 20:38 | |
*** pnavarro has quit IRC | 20:41 | |
*** sdake has quit IRC | 20:42 | |
*** sdake has joined #openstack-keystone | 20:43 | |
*** lhcheng has quit IRC | 20:44 | |
openstackgerrit | Henrique Truta proposed openstack/keystone: Tests for projects acting as domains https://review.openstack.org/211219 | 20:45 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Manager support for projects acting as domains https://review.openstack.org/213448 | 20:45 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Honor domain operations in project table https://review.openstack.org/143763 | 20:45 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Replicate domain info in projects table https://review.openstack.org/211170 | 20:45 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Change project name constraints https://review.openstack.org/158372 | 20:45 |
openstackgerrit | Henrique Truta proposed openstack/keystone: Add is_domain parameter to get_project_by_name https://review.openstack.org/210600 | 20:45 |
*** lhcheng has joined #openstack-keystone | 20:46 | |
*** ChanServ sets mode: +v lhcheng | 20:46 | |
*** lhcheng_ has joined #openstack-keystone | 20:47 | |
*** lhcheng has quit IRC | 20:47 | |
openstackgerrit | Merged openstack/keystone: Adds interface tests for timeutils https://review.openstack.org/226697 | 20:51 |
*** tonytan4ever has joined #openstack-keystone | 20:52 | |
*** ayoung has quit IRC | 21:01 | |
*** jsavak has quit IRC | 21:01 | |
*** jsavak has joined #openstack-keystone | 21:01 | |
*** david-lyle has joined #openstack-keystone | 21:09 | |
samueldmq | when running tox, I got : Could not find any downloads that satisfy the requirement .[ldap,memcache,mongodb] | 21:12 |
*** doug-fis_ has quit IRC | 21:13 | |
samueldmq | is that related to the need of updating pbr to understand that new requirements' format ? | 21:13 |
samueldmq | dstanek: bknudson: cc ^ | 21:13 |
*** doug-fish has joined #openstack-keystone | 21:14 | |
bknudson | samueldmq: probably... what version of pbr are you using? | 21:16 |
*** diazjf has quit IRC | 21:18 | |
*** doug-fish has quit IRC | 21:18 | |
*** hrou has quit IRC | 21:19 | |
openstackgerrit | Brant Knudson proposed openstack/keystonemiddleware: only make token invalid when it really is https://review.openstack.org/217373 | 21:20 |
samueldmq | bknudson: let me check (actually it is from an outreachy student, let me check with her) | 21:22 |
*** sigmavirus24 is now known as sigmavirus24_awa | 21:23 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 21:23 | |
*** doug-fish has joined #openstack-keystone | 21:24 | |
*** sdake_ has joined #openstack-keystone | 21:25 | |
*** jaosorior has quit IRC | 21:26 | |
*** sdake__ has joined #openstack-keystone | 21:27 | |
*** geoffarn_ has quit IRC | 21:28 | |
*** sdake has quit IRC | 21:28 | |
*** stevemar has quit IRC | 21:29 | |
*** stevemar has joined #openstack-keystone | 21:29 | |
*** ChanServ sets mode: +v stevemar | 21:29 | |
*** geoffarnold has joined #openstack-keystone | 21:30 | |
*** sdake_ has quit IRC | 21:30 | |
*** stevemar has quit IRC | 21:32 | |
*** doug-fish has quit IRC | 21:36 | |
*** jsavak has quit IRC | 21:36 | |
*** ayoung has joined #openstack-keystone | 21:39 | |
*** ChanServ sets mode: +v ayoung | 21:39 | |
*** sdake__ is now known as sdake | 21:41 | |
*** bapalm_ has quit IRC | 21:41 | |
*** bapalm has joined #openstack-keystone | 21:42 | |
*** su_zhang_ has joined #openstack-keystone | 21:44 | |
*** su_zhang has quit IRC | 21:47 | |
samueldmq | bknudson: she hadn't pbr installed | 21:48 |
samueldmq | bknudson: is it installed with setuptools ? | 21:48 |
*** henrynash has quit IRC | 21:49 | |
*** su_zhang has joined #openstack-keystone | 21:53 | |
*** topol has quit IRC | 21:56 | |
*** su_zhang_ has quit IRC | 21:56 | |
*** phalmos has quit IRC | 21:57 | |
dstanek | samueldmq: no, it's a separate library, but make sure her tox is updated too | 21:59 |
dstanek | i don't think i ever installed pbr separately | 21:59 |
*** mylu has joined #openstack-keystone | 22:00 | |
lifeless | we typically install pbr separately | 22:01 |
lifeless | so that easy-install isn't triggereed | 22:01 |
slberger | Is there any plan in the works to implement memcache deletion or marking deleted items in memcache as deleted? We are running into issues with auto resolving project ids that have been recently deleted and then recreated, with the same name. | 22:03 |
*** mylu has quit IRC | 22:03 | |
*** roxanaghe has joined #openstack-keystone | 22:04 | |
samueldmq | dstanek: lifeless yes, she installed it manually with pip, and now has pbr 1.8.0 | 22:04 |
samueldmq | she also run the command to install the dependencies indicated here http://docs.openstack.org/developer/keystone/setup.html#installing-dependencies | 22:04 |
samueldmq | I don't remember to do anything different when I need to setup a new env :/ | 22:05 |
lifeless | samueldmq: whats happening? I only saw the last little bit | 22:05 |
samueldmq | dstanek: tox 1.6.0 | 22:06 |
samueldmq | lifeless: http://paste.openstack.org/show/474523/ | 22:06 |
samueldmq | dstanek: bknudson cc ^ :) | 22:06 |
openstackgerrit | Eric Brown proposed openstack/keystone: Multiple URLs may be specified for ldap url https://review.openstack.org/228644 | 22:06 |
*** packet has quit IRC | 22:07 | |
*** lhcheng_ has quit IRC | 22:07 | |
lifeless | https://rbtcollins.wordpress.com/2015/07/12/bootstrapping-developer-environments-for-openstack/ | 22:07 |
lifeless | samueldmq: ^ | 22:07 |
*** lhcheng has joined #openstack-keystone | 22:08 | |
*** ChanServ sets mode: +v lhcheng | 22:08 | |
lifeless | samueldmq: the virtualenv's being created by tox have too-old pip in them, which is fixed by having the virtualenv package that tox imports be updated | 22:08 |
dstanek | samueldmq: why sudo? | 22:08 |
*** alejandrito has quit IRC | 22:09 | |
samueldmq | dstanek: yeah, doesnt' need to | 22:09 |
lifeless | samueldmq: it would be simple to fix tis by updating virtualenv -- as long as the system virtualenv isn't installed (because some environments have bad python paths with pip installed things using the system pip | 22:09 |
lifeless | samueldmq: (e.g. ubuntu ) | 22:10 |
lifeless | samueldmq: thus the process I recommend on my blog post | 22:10 |
samueldmq | lifeless: okay, I am going to take a look at it | 22:10 |
samueldmq | although I am very surprised tht following the docs we didn't get it to work (without using virtalenv) | 22:11 |
lifeless | samueldmq: which docs? | 22:11 |
samueldmq | lifeless: http://docs.openstack.org/developer/keystone/setup.html#installing-dependencies | 22:11 |
*** ankita_wagh has quit IRC | 22:12 | |
samueldmq | lifeless: and http://docs.openstack.org/developer/keystone/developing.html#testing | 22:12 |
lifeless | samueldmq: they don't cover tox at all | 22:12 |
lifeless | ah | 22:12 |
*** stevemar has joined #openstack-keystone | 22:12 | |
*** ChanServ sets mode: +v stevemar | 22:12 | |
lifeless | keystone should add a bindep file if it hasn't | 22:13 |
lifeless | but thats separate | 22:13 |
*** hrou has joined #openstack-keystone | 22:13 | |
lifeless | samueldmq: anyhow yes, those docs are incomplete | 22:13 |
samueldmq | lifeless: hmmm... her tox is 1.6.0, mine's 2.1.1 | 22:14 |
samueldmq | so that sounds to be the issue, yes | 22:14 |
openstackgerrit | Merged openstack/python-keystoneclient: Add shields.io version/downloads links/badges into README.rst https://review.openstack.org/227654 | 22:14 |
lifeless | I don't know what min tox version we require | 22:14 |
lifeless | is she on Ubuntu ? | 22:14 |
lifeless | samueldmq: keystone might want to link to http://docs.openstack.org/infra/manual/python.html#python-unit-tests | 22:16 |
lifeless | which is also incomplete | 22:16 |
samueldmq | lifeless: yes, ubuntu 14 | 22:16 |
lifeless | samueldmq: 14.? [there were two major releases in 14.x | 22:17 |
*** dims has quit IRC | 22:17 | |
samueldmq | lifeless: 14.04 | 22:17 |
*** stevemar has quit IRC | 22:17 | |
lifeless | hmm, I don't remember when they brought the bad pip patch in | 22:17 |
lifeless | it might be that far back | 22:18 |
*** ankita_wagh has joined #openstack-keystone | 22:18 | |
*** slberger has left #openstack-keystone | 22:20 | |
*** stevemar has joined #openstack-keystone | 22:21 | |
*** ChanServ sets mode: +v stevemar | 22:21 | |
*** stevemar_ has joined #openstack-keystone | 22:23 | |
*** ChanServ sets mode: +v stevemar_ | 22:23 | |
*** gordc has quit IRC | 22:24 | |
openstackgerrit | Merged openstack/keystonemiddleware: Add shields.io version/downloads links/badges into README.rst https://review.openstack.org/227653 | 22:24 |
openstackgerrit | Merged openstack/keystonemiddleware: auto-generate release history https://review.openstack.org/227656 | 22:25 |
*** stevemar has quit IRC | 22:25 | |
lifeless | samueldmq: https://review.openstack.org/228647 | 22:27 |
*** stevemar_ has quit IRC | 22:28 | |
*** stevemar has joined #openstack-keystone | 22:30 | |
*** ChanServ sets mode: +v stevemar | 22:30 | |
*** ayoung has quit IRC | 22:30 | |
openstackgerrit | Merged openstack/keystoneauth: Add shields.io version/downloads links/badges into README.rst https://review.openstack.org/227652 | 22:30 |
*** stevemar_ has joined #openstack-keystone | 22:31 | |
*** ChanServ sets mode: +v stevemar_ | 22:31 | |
*** tonytan4ever has quit IRC | 22:31 | |
*** su_zhang has quit IRC | 22:32 | |
samueldmq | lifeless: why do we need to remove the old packages vs just updating them ? | 22:33 |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:33 | |
samueldmq | remove/re-install | 22:33 |
lifeless | samueldmq: so they don't shadow the ones we install | 22:34 |
*** stevemar has quit IRC | 22:34 | |
lifeless | samueldmq: some versions of ubuntu have the system pythonpath before user-local | 22:35 |
lifeless | samueldmq: *and* install user-local by default with pip | 22:35 |
lifeless | samueldmq: the combination means that apt-get install python-pip + pip install virtualenv would result in using the system installed virtualenv, not the pip installed one | 22:35 |
lifeless | samueldmq: its diabolical | 22:35 |
*** stevemar_ has quit IRC | 22:36 | |
*** stevemar has joined #openstack-keystone | 22:36 | |
*** ChanServ sets mode: +v stevemar | 22:36 | |
samueldmq | lifeless: yes, it is | 22:38 |
samueldmq | omg, that's insane | 22:38 |
lifeless | samueldmq: its a combination of things that has a very poor outcome | 22:38 |
lifeless | samueldmq: IMO the right thing to do is to never use system installed tools for app development | 22:38 |
lifeless | platform tools to build the platform, dev tools to do dev | 22:38 |
*** nisha_ has quit IRC | 22:39 | |
*** su_zhang has joined #openstack-keystone | 22:39 | |
*** agireud has quit IRC | 22:39 | |
*** nisha_ has joined #openstack-keystone | 22:39 | |
samueldmq | lifeless: hence use virtualenv | 22:39 |
*** e0ne has quit IRC | 22:40 | |
*** stevemar has quit IRC | 22:41 | |
lifeless | samueldmq: right, and se my blogpost for installing virtualenv without installing the &system& one | 22:41 |
samueldmq | lifeless: nice, thanks for clarifying | 22:43 |
samueldmq | lifeless: that makes sense to me now | 22:43 |
*** nisha_ has quit IRC | 22:43 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Cleanup fernet validate_v3_token https://review.openstack.org/228652 | 22:44 |
*** urulama has quit IRC | 22:47 | |
*** urulama has joined #openstack-keystone | 22:47 | |
*** ngupta has quit IRC | 23:00 | |
*** markvoelker has quit IRC | 23:03 | |
*** ayoung has joined #openstack-keystone | 23:06 | |
*** ChanServ sets mode: +v ayoung | 23:06 | |
*** phalmos has joined #openstack-keystone | 23:10 | |
*** jamielennox|away is now known as jamielennox | 23:13 | |
*** gyee has quit IRC | 23:14 | |
*** btully has quit IRC | 23:26 | |
*** phalmos has quit IRC | 23:30 | |
*** agireud has joined #openstack-keystone | 23:41 | |
*** geoffarnold has quit IRC | 23:43 | |
*** markvoelker has joined #openstack-keystone | 23:46 | |
*** ankita_wagh has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!