| *** oomichi has joined #openstack-keystone | 00:02 | |
| *** david-lyle has joined #openstack-keystone | 00:03 | |
| *** ducttape_ has joined #openstack-keystone | 00:07 | |
| *** ducttap__ has joined #openstack-keystone | 00:10 | |
| *** ducttape_ has quit IRC | 00:10 | |
| *** ducttap__ has quit IRC | 00:15 | |
| lbragstad | eandersson: will not fix? it sounds like you still want the fix though? | 00:27 |
|---|---|---|
| *** zhurong has joined #openstack-keystone | 00:31 | |
| openstackgerrit | Jaewoo Park proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 00:32 |
| *** masber has quit IRC | 00:33 | |
| *** masber has joined #openstack-keystone | 00:33 | |
| *** bknudson has joined #openstack-keystone | 00:35 | |
| *** bknudson has quit IRC | 00:35 | |
| *** thorst has joined #openstack-keystone | 00:39 | |
| *** Shunli has joined #openstack-keystone | 00:42 | |
| eandersson | lbragstad, yea - I mean for me yaml and templated are still two different things | 00:43 |
| eandersson | yaml is a working replacement, but templated will still be broken, even if deprecated | 00:43 |
| *** thorst has quit IRC | 00:44 | |
| *** phalmos_ has quit IRC | 00:49 | |
| *** dave-mcc_ has joined #openstack-keystone | 01:00 | |
| *** thorst has joined #openstack-keystone | 01:11 | |
| *** thorst has quit IRC | 01:11 | |
| *** ducttape_ has joined #openstack-keystone | 01:15 | |
| *** tobberydberg has joined #openstack-keystone | 01:16 | |
| *** ducttape_ has quit IRC | 01:20 | |
| *** tobberydberg has quit IRC | 01:22 | |
| openstackgerrit | Tin Lam proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 01:46 |
| *** jmlowe has quit IRC | 01:49 | |
| *** zsli_ has joined #openstack-keystone | 01:53 | |
| *** Shunli has quit IRC | 01:56 | |
| *** markvoelker has quit IRC | 02:09 | |
| *** markvoelker has joined #openstack-keystone | 02:09 | |
| *** markvoelker has quit IRC | 02:14 | |
| *** ducttape_ has joined #openstack-keystone | 02:16 | |
| *** ducttape_ has quit IRC | 02:21 | |
| *** ducttap__ has joined #openstack-keystone | 02:21 | |
| *** ducttap__ has quit IRC | 02:23 | |
| *** ducttape_ has joined #openstack-keystone | 02:23 | |
| *** ducttape_ has quit IRC | 02:28 | |
| *** ducttape_ has joined #openstack-keystone | 02:33 | |
| *** dave-mcc_ has quit IRC | 02:42 | |
| *** ducttape_ has quit IRC | 02:45 | |
| *** ducttape_ has joined #openstack-keystone | 02:47 | |
| *** ducttape_ has quit IRC | 02:48 | |
| *** ducttap__ has joined #openstack-keystone | 02:48 | |
| *** ducttap__ has quit IRC | 02:49 | |
| *** ducttape_ has joined #openstack-keystone | 02:57 | |
| *** otleimat has quit IRC | 02:59 | |
| *** ducttape_ has quit IRC | 02:59 | |
| *** ducttape_ has joined #openstack-keystone | 02:59 | |
| *** ducttape_ has quit IRC | 03:04 | |
| *** r-daneel has joined #openstack-keystone | 03:05 | |
| *** ducttape_ has joined #openstack-keystone | 03:07 | |
| *** phalmos has joined #openstack-keystone | 03:09 | |
| morgan | eandersson: note that we probably can't backport the fix far (1 release at most) | 03:11 |
| *** ducttape_ has quit IRC | 03:11 | |
| *** thorst has joined #openstack-keystone | 03:12 | |
| *** thorst has quit IRC | 03:17 | |
| *** markvoelker has joined #openstack-keystone | 04:10 | |
| *** hoonetorg has joined #openstack-keystone | 04:32 | |
| *** markvoelker has quit IRC | 04:45 | |
| *** nicolasbock has joined #openstack-keystone | 04:54 | |
| *** rajalokan has joined #openstack-keystone | 04:59 | |
| *** r-daneel has quit IRC | 05:01 | |
| *** r-daneel has joined #openstack-keystone | 05:02 | |
| *** ducttape_ has joined #openstack-keystone | 05:08 | |
| *** ducttape_ has quit IRC | 05:12 | |
| *** ducttap__ has joined #openstack-keystone | 05:12 | |
| *** thorst has joined #openstack-keystone | 05:13 | |
| *** phalmos has quit IRC | 05:14 | |
| *** ducttap__ has quit IRC | 05:17 | |
| *** thorst has quit IRC | 05:18 | |
| *** tobberydberg has joined #openstack-keystone | 05:21 | |
| *** rcernin has quit IRC | 05:22 | |
| *** tobberydberg has quit IRC | 05:26 | |
| *** rcernin has joined #openstack-keystone | 05:36 | |
| *** markvoelker has joined #openstack-keystone | 05:42 | |
| *** phalmos has joined #openstack-keystone | 05:46 | |
| *** alex_xu has quit IRC | 05:48 | |
| *** alex_xu has joined #openstack-keystone | 05:49 | |
| *** alex_xu has quit IRC | 05:56 | |
| *** alex_xu has joined #openstack-keystone | 05:56 | |
| *** nicolasbock has quit IRC | 05:58 | |
| *** nicolasbock has joined #openstack-keystone | 06:00 | |
| *** markvoelker has quit IRC | 06:14 | |
| *** thorst has joined #openstack-keystone | 06:27 | |
| *** thorst has quit IRC | 06:31 | |
| *** prashkre_ has joined #openstack-keystone | 06:32 | |
| *** jhesketh has quit IRC | 06:35 | |
| *** jhesketh has joined #openstack-keystone | 06:35 | |
| *** links has joined #openstack-keystone | 06:37 | |
| *** raj_singh has quit IRC | 06:38 | |
| *** phalmos has quit IRC | 06:43 | |
| *** rcernin has quit IRC | 06:58 | |
| *** rcernin has joined #openstack-keystone | 06:58 | |
| *** markvoelker has joined #openstack-keystone | 07:11 | |
| *** ducttape_ has joined #openstack-keystone | 07:14 | |
| *** aojea has joined #openstack-keystone | 07:16 | |
| *** tesseract has joined #openstack-keystone | 07:16 | |
| *** zhurong has quit IRC | 07:18 | |
| *** ducttape_ has quit IRC | 07:18 | |
| *** bhagyashris has quit IRC | 07:18 | |
| *** tobberydberg has joined #openstack-keystone | 07:24 | |
| *** tobberydberg has quit IRC | 07:28 | |
| *** markvoelker has quit IRC | 07:45 | |
| *** zhurong has joined #openstack-keystone | 07:58 | |
| *** dims has quit IRC | 08:09 | |
| *** dims has joined #openstack-keystone | 08:11 | |
| *** ducttape_ has joined #openstack-keystone | 08:15 | |
| *** ducttape_ has quit IRC | 08:19 | |
| *** dims has quit IRC | 08:21 | |
| *** dims has joined #openstack-keystone | 08:23 | |
| *** tobberydberg has joined #openstack-keystone | 08:26 | |
| *** thorst has joined #openstack-keystone | 08:28 | |
| *** tobberydberg has quit IRC | 08:30 | |
| *** tobberydberg has joined #openstack-keystone | 08:30 | |
| *** thorst has quit IRC | 08:33 | |
| *** aselius has quit IRC | 08:35 | |
| *** markvoelker has joined #openstack-keystone | 08:42 | |
| *** tobberydberg has quit IRC | 08:55 | |
| *** tobberydberg has joined #openstack-keystone | 08:56 | |
| *** tobberydberg has quit IRC | 08:58 | |
| *** tobberydberg has joined #openstack-keystone | 08:58 | |
| *** zsli_ has quit IRC | 09:06 | |
| *** zsli_ has joined #openstack-keystone | 09:06 | |
| *** zsli__ has joined #openstack-keystone | 09:12 | |
| *** ducttape_ has joined #openstack-keystone | 09:15 | |
| *** zsli_ has quit IRC | 09:16 | |
| *** markvoelker has quit IRC | 09:16 | |
| *** ducttape_ has quit IRC | 09:20 | |
| *** tobberydberg has quit IRC | 09:35 | |
| *** tobberydberg has joined #openstack-keystone | 09:35 | |
| *** tobberydberg has quit IRC | 09:40 | |
| *** zsli__ has quit IRC | 09:44 | |
| *** rajalokan has quit IRC | 09:52 | |
| *** rajalokan has joined #openstack-keystone | 10:02 | |
| *** markvoelker has joined #openstack-keystone | 10:12 | |
| *** rajalokan has quit IRC | 10:20 | |
| *** thorst has joined #openstack-keystone | 10:29 | |
| *** thorst has quit IRC | 10:33 | |
| openstackgerrit | prashkre proposed openstack/keystone master: Filter users and groups in ldap https://review.openstack.org/485302 | 10:36 |
| *** rajalokan has joined #openstack-keystone | 10:38 | |
| *** markvoelker has quit IRC | 10:45 | |
| *** zhurong has quit IRC | 10:50 | |
| *** raildo has joined #openstack-keystone | 11:04 | |
| *** tobberydberg has joined #openstack-keystone | 11:11 | |
| *** aojea has quit IRC | 11:22 | |
| *** aojea has joined #openstack-keystone | 11:30 | |
| *** rajalokan has quit IRC | 11:32 | |
| *** aojea has quit IRC | 11:34 | |
| *** aojea has joined #openstack-keystone | 11:39 | |
| *** markvoelker has joined #openstack-keystone | 11:43 | |
| *** aojea has quit IRC | 11:43 | |
| *** aojea has joined #openstack-keystone | 11:48 | |
| *** aojea has quit IRC | 11:53 | |
| *** aojea has joined #openstack-keystone | 11:57 | |
| *** thorst has joined #openstack-keystone | 11:59 | |
| *** aojea has quit IRC | 12:01 | |
| *** thorst has joined #openstack-keystone | 12:04 | |
| *** aojea has joined #openstack-keystone | 12:06 | |
| *** aojea has quit IRC | 12:09 | |
| *** aojea has joined #openstack-keystone | 12:09 | |
| *** markvoelker has quit IRC | 12:16 | |
| *** markvoelker has joined #openstack-keystone | 12:26 | |
| *** Drankis has joined #openstack-keystone | 12:32 | |
| *** jmlowe has joined #openstack-keystone | 12:39 | |
| *** jmlowe has quit IRC | 12:40 | |
| *** dave-mccowan has joined #openstack-keystone | 12:41 | |
| *** edmondsw has joined #openstack-keystone | 12:44 | |
| *** dave-mcc_ has joined #openstack-keystone | 12:46 | |
| *** dave-mccowan has quit IRC | 12:48 | |
| *** jrist has quit IRC | 12:49 | |
| *** jrist has joined #openstack-keystone | 13:03 | |
| *** ducttape_ has joined #openstack-keystone | 13:08 | |
| knikolla | o/ | 13:08 |
| lbragstad | o/ | 13:11 |
| *** ducttape_ has quit IRC | 13:12 | |
| *** catintheroof has joined #openstack-keystone | 13:25 | |
| openstackgerrit | prashkre proposed openstack/keystone master: Filter users and groups in ldap https://review.openstack.org/485302 | 13:26 |
| *** catinthe_ has joined #openstack-keystone | 13:26 | |
| *** jmlowe has joined #openstack-keystone | 13:30 | |
| *** catintheroof has quit IRC | 13:30 | |
| *** lwanderley has joined #openstack-keystone | 13:32 | |
| *** Drankis has quit IRC | 13:33 | |
| *** bknudson has joined #openstack-keystone | 13:35 | |
| *** lucasxu has joined #openstack-keystone | 13:37 | |
| *** tobberydberg has quit IRC | 13:37 | |
| *** tobberydberg has joined #openstack-keystone | 13:38 | |
| *** tobberydberg has quit IRC | 13:42 | |
| *** links has quit IRC | 13:43 | |
| *** dansmith is now known as superdan | 13:57 | |
| *** jmlowe has quit IRC | 14:15 | |
| *** jrist has quit IRC | 14:26 | |
| *** r-daneel has quit IRC | 14:27 | |
| *** bknudson has quit IRC | 14:27 | |
| *** jmlowe has joined #openstack-keystone | 14:28 | |
| *** jrist has joined #openstack-keystone | 14:39 | |
| *** prashkre_ has quit IRC | 14:51 | |
| *** aselius has joined #openstack-keystone | 15:03 | |
| *** hoonetorg has quit IRC | 15:05 | |
| *** ducttape_ has joined #openstack-keystone | 15:10 | |
| *** rcernin has quit IRC | 15:14 | |
| *** ducttape_ has quit IRC | 15:14 | |
| *** jrist has quit IRC | 15:18 | |
| *** r-daneel has joined #openstack-keystone | 15:20 | |
| *** ducttape_ has joined #openstack-keystone | 15:24 | |
| *** lwanderley has quit IRC | 15:28 | |
| *** ducttape_ has quit IRC | 15:29 | |
| *** aojea has quit IRC | 15:30 | |
| *** aojea has joined #openstack-keystone | 15:30 | |
| *** aojea has quit IRC | 15:35 | |
| *** tobberydberg has joined #openstack-keystone | 15:42 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove policy for self-service password changes https://review.openstack.org/485818 | 15:47 |
| *** tobberydberg has quit IRC | 15:52 | |
| *** tobberydberg has joined #openstack-keystone | 15:55 | |
| *** jrist has joined #openstack-keystone | 15:57 | |
| *** jrist has quit IRC | 15:57 | |
| *** jrist has joined #openstack-keystone | 15:57 | |
| *** tobberydberg has quit IRC | 16:01 | |
| *** ducttape_ has joined #openstack-keystone | 16:25 | |
| *** ducttape_ has quit IRC | 16:30 | |
| openstackgerrit | Tin Lam proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 16:38 |
| *** r-daneel has quit IRC | 16:47 | |
| *** dave-mccowan has joined #openstack-keystone | 16:48 | |
| *** dave-mcc_ has quit IRC | 16:50 | |
| *** r-daneel has joined #openstack-keystone | 16:58 | |
| -openstackstatus- NOTICE: Restarting Gerrit for our weekly memory leak cleanup. | 17:05 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystonemiddleware master: Update comment about fetch token kwargs https://review.openstack.org/486184 | 17:10 |
| *** prashkre_ has joined #openstack-keystone | 17:14 | |
| *** prashkre has joined #openstack-keystone | 17:15 | |
| *** thorst has quit IRC | 17:17 | |
| *** thorst has joined #openstack-keystone | 17:20 | |
| *** dave-mccowan has quit IRC | 17:23 | |
| *** thorst has quit IRC | 17:24 | |
| morgan | lbragstad: ugh. i hate that v2 and v3 endpoints are effectively incompatible | 17:26 |
| *** ducttape_ has joined #openstack-keystone | 17:26 | |
| morgan | lbragstad: we did a VERY bad job of this. | 17:26 |
| lbragstad | yeah | 17:26 |
| morgan | it makes it damn near impossible to do file-system based catalogs. | 17:26 |
| *** dave-mccowan has joined #openstack-keystone | 17:26 | |
| * morgan grumbles. | 17:26 | |
| *** rhini has joined #openstack-keystone | 17:27 | |
| lbragstad | the migration between the two was kind of a pain | 17:27 |
| morgan | i know what i need to do to fix this, but the volume of data processing is painful | 17:27 |
| morgan | the filesystem catalog will actually support v2 and v3 completly | 17:27 |
| morgan | i need to make a serious pass on constructing the raw data in a better way (pre-rendered) in memory on load | 17:27 |
| morgan | but it's pretty close. | 17:28 |
| lbragstad | nice | 17:28 |
| morgan | it'll eat a chunk more memory | 17:28 |
| lbragstad | i assume that will make defining them in the file easier, too | 17:28 |
| morgan | but, it will be the most complete/correct form | 17:28 |
| morgan | well | 17:28 |
| morgan | https://www.irccloud.com/pastebin/9naG0Ok9/ | 17:28 |
| morgan | ^ that is still going to be the yaml | 17:28 |
| morgan | but the difference is v2 and v3 endpoints will be fully constructed | 17:29 |
| morgan | also the #NOTE isn't endpoint, but interface (still) | 17:29 |
| morgan | just a typo | 17:29 |
| rhini | hello, quick question :) | 17:29 |
| rhini | if we have domains do we need to use domain roles? do we lose anything by not using such roles? | 17:29 |
| morgan | lbragstad: so, what i will do is process the yaml into pre-built endpoints that just need the data run through formatter | 17:30 |
| morgan | and set | 17:30 |
| lbragstad | rhini: no - you can use normal roles one domains | 17:30 |
| lbragstad | on* | 17:30 |
| *** ducttape_ has quit IRC | 17:30 | |
| rhini | ok thank you! | 17:30 |
| lbragstad | rhini: the thing domain roles give you is that they are limited to use only within the domain they are created | 17:30 |
| lbragstad | rhini: whereas traditional roles can be used across multiple domains or projects | 17:31 |
| rhini | ahh that makes more sense now | 17:31 |
| lbragstad | morgan: that sounds sane | 17:31 |
| lbragstad | rhini: so if you had a domain that *needed* specific role assignment and you wanted to keep those isolated to that domain only | 17:31 |
| lbragstad | so that they don't accidentally get used somewhere else, you can | 17:32 |
| rhini | got it.. that is very good to know | 17:32 |
| rhini | thank you! | 17:32 |
| lbragstad | rhini: anytime | 17:33 |
| lbragstad | morgan: i'm digging into http://lists.openstack.org/pipermail/openstack-dev/2017-July/119988.html | 17:33 |
| lbragstad | morgan: do you have any context on that ^ | 17:33 |
| lbragstad | i remember seeing some bugs come through that highlighted the confusion with auth_uri, but i don't think they were pursed, yet | 17:34 |
| morgan | no context atm | 17:36 |
| lbragstad | ok - i'll keep digging | 17:36 |
| *** otleimat has joined #openstack-keystone | 17:41 | |
| *** thorst has joined #openstack-keystone | 17:45 | |
| *** tobberydberg has joined #openstack-keystone | 18:01 | |
| *** tobberydberg has quit IRC | 18:06 | |
| *** nicolasbock has quit IRC | 18:06 | |
| *** nicolasbock has joined #openstack-keystone | 18:08 | |
| *** tobberydberg has joined #openstack-keystone | 18:25 | |
| *** jrist has quit IRC | 18:29 | |
| *** rhini has quit IRC | 18:30 | |
| *** ducttape_ has joined #openstack-keystone | 18:32 | |
| *** tobberydberg has quit IRC | 18:34 | |
| *** tobberydberg has joined #openstack-keystone | 18:34 | |
| *** tobberyd_ has joined #openstack-keystone | 18:36 | |
| *** tobberyd_ has quit IRC | 18:36 | |
| *** ducttape_ has quit IRC | 18:37 | |
| -openstackstatus- NOTICE: docs.o.o is currently broken, we're investigating | 18:39 | |
| *** tobberydberg has quit IRC | 18:41 | |
| *** MasterOfBugs has joined #openstack-keystone | 18:45 | |
| *** nicolasbock has quit IRC | 18:45 | |
| openstackgerrit | Tin Lam proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 19:09 |
| *** ducttap__ has joined #openstack-keystone | 19:15 | |
| openstackgerrit | Tin Lam proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 19:22 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove policy for self-service password changes https://review.openstack.org/485818 | 19:25 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: LOG v2 token data instead of v3 https://review.openstack.org/486207 | 19:25 |
| *** prashkre has quit IRC | 19:49 | |
| *** prashkre_ has quit IRC | 19:49 | |
| *** raildo has quit IRC | 19:50 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystonemiddleware master: Blacklist keystoneauth1 3.0.0 https://review.openstack.org/486213 | 19:57 |
| openstackgerrit | Lance Bragstad proposed openstack/keystonemiddleware master: Blacklist keystoneauth1 3.0.0 https://review.openstack.org/486213 | 19:57 |
| lbragstad | cc morgan^ | 19:57 |
| *** catinthe_ has quit IRC | 19:58 | |
| *** aojea has joined #openstack-keystone | 20:01 | |
| *** dave-mccowan has quit IRC | 20:02 | |
| *** tobberydberg has joined #openstack-keystone | 20:10 | |
| *** tobberydberg has quit IRC | 20:15 | |
| *** boris-42____ has quit IRC | 20:28 | |
| *** jmlowe has quit IRC | 20:32 | |
| *** jrist has joined #openstack-keystone | 20:33 | |
| morgan | lbragstad: +2/a once it passes | 20:38 |
| morgan | or feel free to +A it when it passes | 20:38 |
| lbragstad | morgan: will do | 20:38 |
| morgan | also | 20:39 |
| morgan | that looks like it's test issues | 20:39 |
| morgan | not functional issues | 20:39 |
| morgan | ksa does a lot more work now | 20:39 |
| morgan | and requests_mock isn't mocking things out | 20:39 |
| morgan | that KSA does. | 20:39 |
| morgan | IIRC shouldn't this have been caught w/ upper constraints? | 20:40 |
| morgan | (anyway) | 20:40 |
| morgan | this looks like it is failing on 2.XX of ksa as well | 20:40 |
| morgan | ooh interesting | 20:41 |
| morgan | even with your blacklist it is failing | 20:41 |
| morgan | and has ksa 3.0.0 installed | 20:41 |
| morgan | http://logs.openstack.org/13/486213/2/check/gate-keystonemiddleware-python27-ubuntu-xenial/37411c8/console.html#_2017-07-21_20_01_58_399406 | 20:41 |
| morgan | oh i thnk i see it. | 20:44 |
| morgan | or at least one of the errors | 20:44 |
| morgan | ok | 20:48 |
| morgan | part of the issue is self.url in the ksm tests is doing something with port 5000 | 20:49 |
| morgan | and assuming data for the version is on / | 20:49 |
| morgan | so no url parts. | 20:49 |
| morgan | lbragstad: black list ksa 3.0.0 in g-r | 20:49 |
| morgan | lbragstad: it has a logic error | 20:49 |
| morgan | lbragstad: and we will need a 3.0.1 once i can figure out what needs to be fixed | 20:50 |
| morgan | dims: ^ cc (re KSA 3.0.0) | 20:50 |
| lbragstad | yeah - it looks like it's tripping over | 20:50 |
| lbragstad | https://github.com/openstack/keystonemiddleware/blob/4a72cd6c3b3139dd2b55787eff5b84741cc0a347/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py#L2413-L2416 | 20:51 |
| morgan | https://review.openstack.org/486222 | 20:52 |
| morgan | issue is the discovery logic cannot handle broken cases where url has no path/parts | 20:53 |
| morgan | this version needs to be globally blacklisted and we'll need to release a 3.0.1 next week | 20:53 |
| morgan | or so once we fix it | 20:53 |
| morgan | dims: ^ cc | 20:53 |
| morgan | lbragstad: -1 on https://review.openstack.org/#/c/486160/1 for the same reason | 20:54 |
| lbragstad | morgan: https://review.openstack.org/#/c/486223/ | 20:54 |
| lbragstad | cc dims ^ | 20:54 |
| * dims peeks | 20:55 | |
| morgan | lbragstad: i beat you by 1 review # | 20:55 |
| morgan | mine 2as 486222 | 20:55 |
| morgan | was* | 20:55 |
| morgan | does the same thing | 20:55 |
| morgan | :P | 20:55 |
| dims | please close one :) | 20:55 |
| morgan | ah but yours is more correct i think | 20:55 |
| morgan | dims: sec. | 20:55 |
| lbragstad | morgan: oh - sorry i didn't see you pushed on already | 20:56 |
| morgan | dims: use lbragstad's | 20:56 |
| morgan | i abandoned mine | 20:56 |
| morgan | 486223 | 20:56 |
| morgan | is the correct one | 20:57 |
| dims | lbragstad : need to set the u-c to what was there before | 20:57 |
| dims | lbragstad : 2.21.0 per https://review.openstack.org/#/c/485837/1/upper-constraints.txt | 20:57 |
| lbragstad | dims: on it | 20:58 |
| lbragstad | dims: updated https://review.openstack.org/#/c/486223/ | 20:59 |
| openstackgerrit | Tin Lam proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 21:00 |
| dims | lbragstad : morgan : k that's sailing through CI now | 21:03 |
| lbragstad | sweet | 21:04 |
| lbragstad | thanks dims | 21:04 |
| dims | i had this nagging feeling lbragstad :) | 21:04 |
| lbragstad | dims: :-/ | 21:04 |
| lbragstad | i did too | 21:05 |
| lbragstad | after the release I was waiting for something to crop up | 21:05 |
| dims | cool have a good weekend both of you | 21:05 |
| lbragstad | i didn't end up noticing it until after i start proposing some cleanup patches to ksm after reading http://lists.openstack.org/pipermail/openstack-dev/2017-July/119988.html | 21:06 |
| lbragstad | dims: you too | 21:06 |
| morgan | this is also why i was adamant i wanted it to be 3.0.0 | 21:06 |
| morgan | it is a TON of new features | 21:06 |
| morgan | and code | 21:06 |
| morgan | lbragstad: i'll need to poke at the code to see what cases we are not handling the discovery urls | 21:07 |
| morgan | the requests_mock stuff i'm ok with that just being an upgrade requirement for ksm's testing | 21:07 |
| morgan | and that is not a big deal | 21:07 |
| dims | makes sense morgan | 21:07 |
| morgan | but the indexerror in discovery_url stuff is a problem | 21:08 |
| morgan | since it means we are likely to break in the real world | 21:08 |
| lbragstad | right | 21:09 |
| lbragstad | i was pretty surprised to see that | 21:09 |
| morgan | yeah | 21:10 |
| morgan | if it was just requests_mock stuff, i'd roll with it and say "yep, this is what i expect" | 21:10 |
| lbragstad | all failures in AuthProtocolLoadingTests are mock related | 21:10 |
| morgan | yeh | 21:10 |
| morgan | http://logs.openstack.org/13/486213/2/check/gate-keystonemiddleware-python27-ubuntu-xenial/37411c8/console.html#_2017-07-21_20_01_57_662615 | 21:11 |
| morgan | is not | 21:11 |
| lbragstad | yeah | 21:11 |
| lbragstad | i'm going to start poking at GeneralAuthTokenMiddlewareTest | 21:11 |
| morgan | basically what is happening there is self.url ishttp://keystone-east.example.com:5000 | 21:11 |
| morgan | and urlparse means that has no path | 21:11 |
| morgan | so url_parts[-2] is an index error, as is url_parts[-1] | 21:12 |
| morgan | so... we need to handle the case that url is ... well a url | 21:12 |
| morgan | mordred: ^ cc issues with discovery | 21:13 |
| lbragstad | it's actually completely empty here | 21:13 |
| lbragstad | https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/discover.py#L937 | 21:13 |
| morgan | self.url? | 21:14 |
| morgan | or url | 21:14 |
| morgan | there is a difference | 21:14 |
| morgan | self.url was http://keystone-east.example.com:5000 | 21:14 |
| lbragstad | http://paste.openstack.org/show/616214/ | 21:14 |
| morgan | yes | 21:14 |
| lbragstad | yeah - url_parts ends up being an empty list | 21:14 |
| morgan | url_parts is empty | 21:14 |
| morgan | because http://keystone-east.example.com:5000 has no path | 21:14 |
| lbragstad | ah ha - right | 21:14 |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 21:18 |
| openstackgerrit | Tin Lam proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 21:19 |
| lbragstad | https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/discover.py#L941 is also going to fail if project_id is not None | 21:19 |
| lbragstad | in the same case | 21:19 |
| morgan | yep | 21:20 |
| morgan | ooh this is going to be icky to unwind. | 21:21 |
| lbragstad | yeah... | 21:22 |
| morgan | hm. | 21:24 |
| morgan | ok i think i can tack something in to fix it, but i can't come up with a test to prevent regression off the top of my head | 21:24 |
| *** fried_rice has joined #openstack-keystone | 21:25 | |
| fried_rice | o/ | 21:26 |
| lbragstad | fried_rice: | 21:26 |
| lbragstad | o/ | 21:26 |
| lbragstad | this is what we have so far for failures http://logs.openstack.org/84/486184/1/check/gate-keystonemiddleware-python27-ubuntu-xenial/7c079da/testr_results.html.gz | 21:26 |
| fried_rice | Saw that. What have we "discovered" so far? | 21:27 |
| lbragstad | the failures in keystonemiddleware.tests.unit.auth_token.test_auth_token_middleware.AuthProtocolLoadingTest seem unrelated to the issues with discovery | 21:27 |
| morgan | ah, so it looks like https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/discover.py#L1021-L1025 needs to handle the case where url_parts[-2] or [-1] are index error | 21:27 |
| morgan | gross | 21:27 |
| lbragstad | https://github.com/openstack/keystonemiddleware/blob/4a72cd6c3b3139dd2b55787eff5b84741cc0a347/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py#L509-L570 | 21:28 |
| fried_rice | morgan Agree, agree it's gross. | 21:28 |
| *** ducttape_ has joined #openstack-keystone | 21:28 | |
| lbragstad | ^ that's a failure that we thing is likely to happen in the wild | 21:28 |
| lbragstad | it's tripping over https://github.com/openstack/keystonemiddleware/blob/4a72cd6c3b3139dd2b55787eff5b84741cc0a347/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py#L513 | 21:28 |
| lbragstad | here - https://github.com/openstack/keystonemiddleware/blob/4a72cd6c3b3139dd2b55787eff5b84741cc0a347/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py#L560 | 21:28 |
| fried_rice | I can put that up right quick. | 21:29 |
| fried_rice | unless someone else has it. | 21:29 |
| morgan | because url_parts is [] when the url is http://keystone-east.example.com:5000 | 21:29 |
| fried_rice | yuh | 21:29 |
| lbragstad | yeah | 21:29 |
| lbragstad | v | 21:29 |
| lbragstad | https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/discover.py#L937 | 21:29 |
| morgan | fried_rice: i haven't gotten to code | 21:29 |
| morgan | fried_rice: if you can roll a fix (and test) I'm happy to quick review | 21:29 |
| morgan | so we can release 3.0.1 next week | 21:29 |
| morgan | but basically url_parts may be [], and we need to handle that case. | 21:29 |
| lbragstad | morgan: that's going to miss the deadline for pike | 21:30 |
| morgan | lbragstad: we can't release today | 21:30 |
| morgan | we will simply ask for an exception | 21:30 |
| morgan | it's a point/patch release | 21:30 |
| morgan | to fix a real bug | 21:30 |
| *** edmondsw has quit IRC | 21:30 | |
| morgan | fwiw, i also will be mostly unavailable mon->wed next week (somewhat on, but mostly offline writing code) | 21:31 |
| *** ducttap__ has quit IRC | 21:31 | |
| lbragstad | morgan: ack | 21:31 |
| morgan | so landing fix today so we can get some folks to actually test it all before a patch release | 21:31 |
| morgan | would be good | 21:31 |
| lbragstad | morgan: sounds good - i'll make a note to talk to dims next week about an exception | 21:31 |
| lbragstad | ++ | 21:31 |
| openstackgerrit | Eric Fried proposed openstack/keystoneauth master: WIP: Handle path-less URLs https://review.openstack.org/486231 | 21:33 |
| fried_rice | lbragstad morgan ^^ seem like a reasonable start? | 21:33 |
| fried_rice | I don't have the env set up to test this in keystonemiddleware - does one of y'all? | 21:33 |
| lbragstad | i do | 21:33 |
| lbragstad | i can test it | 21:33 |
| lbragstad | i was going to say that we need to add the same test that ksm failed on to ksa | 21:34 |
| fried_rice | lbragstad Yeah, was just looking into a way to do that easily. | 21:34 |
| lbragstad | i think the entry point we might want here is get_endpoint_data | 21:35 |
| lbragstad | passing 'http://keystone-east.example.com:5000' in there somehow is causing this to fail | 21:35 |
| lbragstad | so a test in keystoneauth1/tests/unit/identity/test_identity_common.py: ? | 21:36 |
| *** edmondsw has joined #openstack-keystone | 21:37 | |
| lbragstad | fried_rice: ack - that work around fixes keystonemiddleware.tests.unit.auth_token.test_auth_token_middleware.GeneralAuthTokenMiddlewareTest.test_auth_region_name | 21:37 |
| lbragstad | granted i haven't dug into the assertions of that test a whole lot, so it might not fix everything, but it does make the test pass | 21:38 |
| fried_rice | lbragstad Yeah, that bug is really not a statement of the functionality of any of the endpoint discovery - just an oversight of certain possible formats of the URL. | 21:39 |
| lbragstad | _get_discovery_url_choices is just suppose to return possible versions right/ | 21:40 |
| fried_rice | yes | 21:40 |
| lbragstad | ah | 21:41 |
| *** edmondsw has quit IRC | 21:41 | |
| fried_rice | Now what made us think that the AuthProtocolLoadingTest failure was unrelated? | 21:41 |
| morgan | fried_rice: because it's requests_mock | 21:41 |
| morgan | ksa is doing more things and we just haven't mocked the urls | 21:41 |
| morgan | in this case | 21:41 |
| lbragstad | ahhhh | 21:42 |
| morgan | this is an expected type breakage when using requests_mock | 21:42 |
| morgan | if suddenly something new is requested in a test case, it should complain | 21:42 |
| fried_rice | Not 100% sure about that - I believe we can get that result if get_endpoints isn't returning the URL we're expecting. | 21:42 |
| morgan | this change just happens to come from ksa making a new request and ksm test case hasn't mocked it | 21:42 |
| *** edmondsw has joined #openstack-keystone | 21:42 | |
| morgan | looking at the error, if it is requests_mock complaining, it is not related to the url_parts indexerror. | 21:43 |
| morgan | well not directly that is | 21:43 |
| fried_rice | Oh, yeah, that's true, not related to the IndexError - but still likely to be root caused in that same method. | 21:44 |
| fried_rice | lbragstad Did you run the whole suite against my patch? | 21:44 |
| lbragstad | fried_rice: no - just that one test, let me do that now though | 21:44 |
| fried_rice | I'll clone ksm in the meantime... | 21:44 |
| lbragstad | there are still three failures after the ksa patch | 21:46 |
| morgan | fried_rice: sure might be caused by the same method, but we can't "fix" ksa making more requests if ksa handles the forms of urls. | 21:46 |
| lbragstad | which is expected since they are all related to the mock stuff | 21:46 |
| morgan | lbragstad: all requests_mock? | 21:46 |
| lbragstad | all found in keystonemiddleware.tests.unit.auth_token.test_auth_token_middleware.AuthProtocolLoadingTests | 21:46 |
| morgan | yeah | 21:46 |
| lbragstad | morgan: yeah | 21:46 |
| morgan | then that fix looks good fried_rice | 21:46 |
| morgan | now... we need a unit test as well :P | 21:47 |
| *** edmondsw has quit IRC | 21:47 | |
| lbragstad | yeah - we should port the unit test from ksm the caught that | 21:47 |
| lbragstad | so we know version discovery works for that case | 21:47 |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 21:47 |
| fried_rice | Are we thinking the fix for the other will be in ksm itself? | 21:47 |
| morgan | fried_rice: yes | 21:48 |
| morgan | since ksm needs to mock out the new url paths. | 21:48 |
| lbragstad | fried_rice: yeah - we have to teach ksm about how ksa returns things | 21:48 |
| morgan | that are being requested | 21:48 |
| lbragstad | and then make sure we mock it | 21:48 |
| morgan | clearly ksm works fine in a real cloud, but our mocks don't know about the new requests | 21:48 |
| *** edmondsw has joined #openstack-keystone | 21:48 | |
| fried_rice | Okay. I'll get that UT ported over for https://review.openstack.org/486231 while y'all look into the ksm thing (since I'm totally new to ksm) | 21:48 |
| morgan | fried_rice: basically we have to land the 3.0.1 patch and release | 21:49 |
| morgan | then we can fix ksm | 21:49 |
| fried_rice | oh, right. | 21:49 |
| fried_rice | I'll hurry, then :) | 21:49 |
| morgan | we can't pre-emptively mock it, or our test is also wrong (we might be able to do introspection for version of ksa...but... gross?) | 21:49 |
| lbragstad | so - we'll tie the version discover of ksa to the mock implemenation in ksm | 21:49 |
| fried_rice | yeah, no, ew. | 21:49 |
| morgan | lbragstad: yeah we'll bump the min ksa | 21:50 |
| morgan | to 3.0.1 | 21:50 |
| lbragstad | yeah | 21:50 |
| morgan | and we should be good | 21:50 |
| morgan | i wonder what else will break | 21:50 |
| morgan | make sure you send a note to the -dev list that things might need adjustments if they use requests_mock and mock out keystone responses to ksa | 21:50 |
| lbragstad | good point | 21:50 |
| morgan | this might also indicate we should wait to use 3.X.X until Queens | 21:51 |
| *** lucasxu has quit IRC | 21:51 | |
| morgan | it sucks to delay the discovery bits | 21:51 |
| lbragstad | yeah - that's what i was thinking about | 21:51 |
| morgan | but, it might be late in the cycle to break other project unit tests | 21:51 |
| fried_rice | Gah, been putting off a nova bp waiting for it. | 21:51 |
| fried_rice | But can still hack around it. | 21:51 |
| fried_rice | so whatevs | 21:51 |
| morgan | (again, yay for making it 3.0.0, so we have a clear break and reverts shouldn't be needed) | 21:51 |
| morgan | fried_rice: lets hit the ML and we will release 3.0.1 next week and bump minimum if we can | 21:52 |
| morgan | if not... we can roll until queens | 21:52 |
| morgan | with 2.x | 21:52 |
| *** edmondsw has quit IRC | 21:53 | |
| *** edmondsw has joined #openstack-keystone | 21:54 | |
| fried_rice | Mm, not sure backporting one of those test cases is the right answer. Would just confuse things. Wanna try something simpler... | 21:55 |
| *** edmondsw has quit IRC | 21:59 | |
| *** edmondsw has joined #openstack-keystone | 22:00 | |
| openstackgerrit | Jaewoo Park proposed openstack/keystone master: Add database migration for project tags https://review.openstack.org/484456 | 22:04 |
| fried_rice | morgan lbragstad I gotta run for a couple hours. Will check back in - and won't be offended if one of y'all wants to put up that UT. | 22:04 |
| fried_rice | Thing is, I'm looking through existing tests, and I'm not sure how we weren't hitting this already in some of them. | 22:05 |
| fried_rice | It should be noted that I'm really new to requests_mock | 22:05 |
| *** edmondsw has quit IRC | 22:05 | |
| *** fried_rice is now known as efried_afk | 22:06 | |
| lbragstad | efried_afk: no worries - thanks for the fix | 22:07 |
| lbragstad | efried_afk: sending out a summary now | 22:07 |
| *** ducttap__ has joined #openstack-keystone | 22:08 | |
| *** edmondsw has joined #openstack-keystone | 22:08 | |
| *** edmondsw_ has joined #openstack-keystone | 22:10 | |
| *** ducttape_ has quit IRC | 22:11 | |
| *** edmondsw has quit IRC | 22:12 | |
| *** edmondsw_ has quit IRC | 22:14 | |
| lbragstad | morgan: update sent - http://lists.openstack.org/pipermail/openstack-dev/2017-July/120015.html | 22:17 |
| gagehugo | lbragstad: https://review.openstack.org/#/c/485344/ should fix the tempest test failing for project tags | 22:19 |
| lbragstad | gagehugo: http://logs.openstack.org/44/485344/1/check/gate-tempest-tox-plugin-sanity-check-ubuntu-xenial/59a592d/console.html ? | 22:20 |
| lbragstad | i was noticing a weird failure earlier too with what seemed to be an unrelated change | 22:24 |
| gagehugo | ps 1 was wrong, it didn't account for changes before project tags | 22:25 |
| *** tesseract has quit IRC | 22:25 | |
| lbragstad | ah | 22:25 |
| openstackgerrit | Nicolas Helgeson proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 22:33 |
| *** edmondsw has joined #openstack-keystone | 22:48 | |
| *** aojea has quit IRC | 22:51 | |
| *** aojea has joined #openstack-keystone | 22:52 | |
| *** edmondsw has quit IRC | 22:52 | |
| *** aojea has quit IRC | 22:56 | |
| openstackgerrit | jessegler proposed openstack/python-keystoneclient master: WIP: Add project tags to keystoneclient https://review.openstack.org/481223 | 23:10 |
| openstackgerrit | Jaewoo Park proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 23:22 |
| *** thorst has quit IRC | 23:24 | |
| *** r-daneel has quit IRC | 23:31 | |
| *** markvoelker has quit IRC | 23:39 | |
| *** catintheroof has joined #openstack-keystone | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!