| *** zhurong has joined #openstack-keystone | 00:09 | |
| *** r-daneel has joined #openstack-keystone | 00:15 | |
| *** r-daneel has quit IRC | 00:19 | |
| efried_afk | morgan lbragstad I'm back. | 00:22 |
|---|---|---|
| efried_afk | Any progress on that test case or should I take it back? | 00:22 |
| *** efried_afk is now known as efried | 00:23 | |
| *** thorst has joined #openstack-keystone | 00:24 | |
| *** thorst has quit IRC | 00:29 | |
| *** zhurong has quit IRC | 00:31 | |
| *** deep-book-gk_ has joined #openstack-keystone | 00:50 | |
| *** deep-book-gk_ has left #openstack-keystone | 00:53 | |
| *** catintheroof has quit IRC | 00:57 | |
| *** links has joined #openstack-keystone | 00:58 | |
| *** MasterOfBugs has quit IRC | 01:12 | |
| *** lucasxu has joined #openstack-keystone | 01:15 | |
| *** lucasxu has quit IRC | 01:18 | |
| *** otleimat has quit IRC | 01:31 | |
| openstackgerrit | Merged openstack/keystone master: fix assert_admin https://review.openstack.org/482359 | 01:33 |
| openstackgerrit | Merged openstack/keystone master: remove default rule https://review.openstack.org/482164 | 01:34 |
| mordred | efried, lbragstad, morgan: sorry I was away - I blame timezones and the international date line ... am I reading correctly that there are 2 issues - one is that there is a real logic error and one is that requests_mock unittests of things using ksa have issues with the new calls (that second one I can't believe we didn't think of ahead of time) | 01:38 |
| efried | mordred Correct. I'm almost done with https://review.openstack.org/#/c/486231/ to fix the first one. Basically, we never tested URLs with no path in 'em. | 01:38 |
| mordred | efried: how the heck did we manage to do that? | 01:39 |
| efried | Seems like every single test URL we ever used anywhere had a path :) | 01:39 |
| mordred | that's amazing | 01:40 |
| mordred | cause it felt like we had absurd quantities of combinations of things. oh well - clealy we didn't | 01:40 |
| *** markvoelker has joined #openstack-keystone | 01:40 | |
| efried | mordred Where are you, anyway? | 01:44 |
| mordred | efried: tokyo | 01:44 |
| efried | mordred zat where you live, or temporary? | 01:45 |
| mordred | just temporary. I live in Dallas. here for OpenStack Days Tokyo which was this week - then going to Beijing for OpenStack Days Beijing Monday/Tuesday | 01:45 |
| efried | Ah, a fellow Texan. Austin area (Taylor) here. | 01:47 |
| mordred | \o/ | 01:48 |
| openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Handle pathless URLs https://review.openstack.org/486231 | 01:52 |
| efried | mordred ^^ | 01:52 |
| efried | lbragstad morgan ^^ | 01:53 |
| *** harlowja has quit IRC | 02:00 | |
| mordred | efried: I can confirm that fixes 5 of the 8 failures in keystonemiddleware | 02:01 |
| efried | mordred Yup, the other three are the mockish ones | 02:01 |
| efried | I'm looking at that now. | 02:01 |
| mordred | efried: yah - and I'm trying to understnand why that's different | 02:01 |
| efried | Because we're not stubbing out the versionless URL | 02:02 |
| mordred | yah - but I don't konw why that behavior changed, because keystoneauth always did version discovery on itself | 02:02 |
| mordred | also - the three that are failing are somewhat pathological combinations (keystone url and auth url are different) - so it's obviously a thing that needs to be fixed, but it may not be a common scenario in other people's unit tests | 02:03 |
| efried | here's hopin | 02:04 |
| mordred | keystonemiddleware.tests.unit.auth_token.test_auth_token_middleware.AuthProtocolLoadingTests.test_plugin_loading_mixed_opts seems very odd to me | 02:05 |
| mordred | in the test, it sets: | 02:05 |
| mordred | auth_url='http://keystone.test:5000', | 02:05 |
| mordred | but the base setup has AUTH_URL = 'http://auth.url/prefix' and registers a requests_mock for it | 02:06 |
| mordred | which keystoneauth hits - but I don't understand why it's hitting that url when the test configures http://keystone.test:5000 as the auth url | 02:07 |
| mordred | the other half makes more sense - the catalog returns http://keystone.url/prefix/v2.0 as the admin_url once auth has happened | 02:07 |
| mordred | so it makes sense that the middleware would try to fetch from that | 02:07 |
| mordred | but I don't see mocks registered for http://keystone.url/prefix/v2.0 either :) | 02:08 |
| mordred | OH HOLY CRAP | 02:12 |
| mordred | efried, lbragstad, morgan: it's a GET http://keystone.url/prefix vs. GET http://keystone.url/prefix/ | 02:13 |
| efried | yurkiddinme | 02:13 |
| mordred | keystonemiddleware's mock was set up for http://keystone.url/prefix/ but with ksa3 we're doing http://keystone.url/prefix | 02:13 |
| mordred | efried: I think we should track thta down and fix it in ksa | 02:13 |
| mordred | since trailing / is meaningful in places (I thought we had tests for that tbh) | 02:14 |
| efried | in fixture/v3.py? | 02:14 |
| *** markvoelker has quit IRC | 02:14 | |
| mordred | so - the previous behavior was that http://keystone.url/prefix/v2.0 was returne form the catalog and ksa did a GET on http://keystone.url/prefix/ - so in the code where we're removing elements from the URL - we need to make sure we're appending a trailing / | 02:15 |
| mordred | (I believe this is important for nova too) | 02:15 |
| mordred | efried: so likely in that same section of code you were just hacking on | 02:15 |
| efried | mordred Was just gonna say. | 02:16 |
| efried | Sooo, feel free to add to my patch. | 02:16 |
| efried | mordred I haven't had dinner yet, and you're still pre-lunch, so I'm gonna pass the torch to you. | 02:16 |
| mordred | kk. I'll track this one down | 02:17 |
| mordred | efried: I'm going to just append a patch to the end | 02:18 |
| efried | mordred wfm | 02:18 |
| efried | mordred ăăăȘă | 02:19 |
| *** efried is now known as efried_zzz | 02:19 | |
| *** Dinesh_Bhor has quit IRC | 02:44 | |
| *** ducttap__ has quit IRC | 02:47 | |
| openstackgerrit | Samriddhi proposed openstack/keystone master: Removed token-provider doc https://review.openstack.org/483276 | 02:52 |
| *** r-daneel has joined #openstack-keystone | 03:01 | |
| *** markvoelker has joined #openstack-keystone | 03:11 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Ensure constructed urls have trailing '/'s https://review.openstack.org/486276 | 03:19 |
| mordred | efried_zzz, lbragstad, morgan: ^^ there's the other half of the coin | 03:19 |
| mordred | that fixes keystonemiddleware's tests without needing to make any changes to mocks | 03:19 |
| *** thorst has joined #openstack-keystone | 03:26 | |
| mordred | I've also double-checked that shade's requests_mock-based tests work properly with those patches applied | 03:29 |
| *** thorst has quit IRC | 03:31 | |
| *** harlowja has joined #openstack-keystone | 03:38 | |
| *** markvoelker has quit IRC | 03:44 | |
| *** prashkre_ has joined #openstack-keystone | 04:06 | |
| *** prashkre has joined #openstack-keystone | 04:06 | |
| *** harlowja has quit IRC | 04:20 | |
| *** markvoelker has joined #openstack-keystone | 04:42 | |
| *** nicolasbock has joined #openstack-keystone | 04:44 | |
| *** harlowja has joined #openstack-keystone | 04:47 | |
| morgan | mordred: i guess urls aren't going to be unicode or something silly so the + should work | 04:56 |
| morgan | s/silly/incompatible | 04:56 |
| morgan | mordred: as a follow-up we should get a unit test to specifically ensure we're catching that yeild w/ the trailing slash | 04:57 |
| morgan | mordred, efried_zzz, lbragstad: +2/+A so we are clear for release early next week (once we're sure ksm is happy, etc) | 04:58 |
| efried_zzz | morgan roger that | 04:58 |
| efried_zzz | morgan mordred lbragstad I confirm that pair of fixes makes ksm pass py27/py35 locally for me. | 05:01 |
| efried_zzz | morgan Need +2/+A on 486231 too. | 05:02 |
| efried_zzz | mordred lbragstad morgan https://review.openstack.org/#/c/486279/ (which will need a recheck) for whenever those two go through. | 05:10 |
| *** markvoelker has quit IRC | 05:14 | |
| *** zhurong has joined #openstack-keystone | 05:17 | |
| *** thorst has joined #openstack-keystone | 05:27 | |
| *** aselius has quit IRC | 05:33 | |
| *** thorst has quit IRC | 05:33 | |
| *** harlowja has quit IRC | 05:33 | |
| *** aojea has joined #openstack-keystone | 05:45 | |
| *** prashkre_ has quit IRC | 05:47 | |
| *** prashkre has quit IRC | 05:47 | |
| mordred | morgan: yes. I agree about specific unit test | 05:50 |
| mordred | morgan: the behavior itself is covered now in the tests - but that's not a dedicaed test that a developer will know to not modify while they're working on something else | 05:51 |
| *** harlowja has joined #openstack-keystone | 05:53 | |
| morgan | Exactly | 05:54 |
| *** harlowja has quit IRC | 05:56 | |
| *** markvoelker has joined #openstack-keystone | 06:12 | |
| *** aojea has quit IRC | 06:14 | |
| openstackgerrit | Tin Lam proposed openstack/python-keystoneclient master: Add project tags to keystoneclient https://review.openstack.org/481223 | 06:18 |
| *** markvoelker has quit IRC | 06:45 | |
| *** tobberydberg has joined #openstack-keystone | 06:53 | |
| *** tobberydberg has quit IRC | 06:57 | |
| *** tobberydberg has joined #openstack-keystone | 06:57 | |
| *** nicolasbock has quit IRC | 07:04 | |
| *** tobberydberg has quit IRC | 07:22 | |
| *** tobberydberg has joined #openstack-keystone | 07:22 | |
| *** tobberydberg has quit IRC | 07:27 | |
| *** thorst has joined #openstack-keystone | 07:28 | |
| *** thorst has quit IRC | 07:33 | |
| *** markvoelker has joined #openstack-keystone | 07:42 | |
| *** markvoelker has quit IRC | 08:16 | |
| *** zhurong has quit IRC | 08:57 | |
| *** zhurong has joined #openstack-keystone | 09:11 | |
| *** markvoelker has joined #openstack-keystone | 09:18 | |
| *** zhurong has quit IRC | 09:23 | |
| *** thorst has joined #openstack-keystone | 09:29 | |
| *** thorst has quit IRC | 09:35 | |
| *** markvoelker has quit IRC | 09:52 | |
| *** aojea has joined #openstack-keystone | 09:59 | |
| *** aojea has quit IRC | 10:13 | |
| *** links has quit IRC | 10:21 | |
| *** phalmos has joined #openstack-keystone | 10:48 | |
| *** markvoelker has joined #openstack-keystone | 10:49 | |
| *** aojea has joined #openstack-keystone | 11:13 | |
| *** aojea has quit IRC | 11:18 | |
| *** markvoelker has quit IRC | 11:22 | |
| *** thorst has joined #openstack-keystone | 11:30 | |
| *** thorst has quit IRC | 11:36 | |
| *** thorst has joined #openstack-keystone | 11:41 | |
| *** thorst has joined #openstack-keystone | 11:42 | |
| *** thorst has quit IRC | 11:47 | |
| *** phalmos has quit IRC | 12:55 | |
| *** aojea has joined #openstack-keystone | 13:01 | |
| *** aojea has quit IRC | 13:07 | |
| *** Drankis has joined #openstack-keystone | 13:17 | |
| *** markvoelker has joined #openstack-keystone | 13:19 | |
| *** thorst has joined #openstack-keystone | 13:49 | |
| *** thorst has quit IRC | 13:51 | |
| *** markvoelker has quit IRC | 13:51 | |
| *** thorst has joined #openstack-keystone | 13:52 | |
| *** thorst has quit IRC | 13:56 | |
| *** d0ugal has joined #openstack-keystone | 14:17 | |
| *** d0ugal has quit IRC | 14:17 | |
| *** d0ugal has joined #openstack-keystone | 14:17 | |
| *** Drankis has quit IRC | 14:19 | |
| *** lbragsta_ has joined #openstack-keystone | 14:24 | |
| *** ChanServ sets mode: +o lbragsta_ | 14:24 | |
| lbragsta_ | mordred efried_zzz good catch on the mock thing | 14:27 |
| *** lbragsta_ has quit IRC | 14:36 | |
| *** markvoelker has joined #openstack-keystone | 14:49 | |
| *** jhesketh has quit IRC | 14:52 | |
| openstackgerrit | Merged openstack/keystoneauth master: Handle pathless URLs https://review.openstack.org/486231 | 14:54 |
| *** lbragsta_ has joined #openstack-keystone | 14:54 | |
| *** ChanServ sets mode: +o lbragsta_ | 14:54 | |
| *** aojea has joined #openstack-keystone | 15:03 | |
| *** r-daneel has quit IRC | 15:05 | |
| *** iurygregory has quit IRC | 15:06 | |
| *** aojea has quit IRC | 15:09 | |
| *** aojea has joined #openstack-keystone | 15:09 | |
| openstackgerrit | Merged openstack/keystoneauth master: Ensure constructed urls have trailing '/'s https://review.openstack.org/486276 | 15:09 |
| *** iurygregory has joined #openstack-keystone | 15:12 | |
| *** aselius has joined #openstack-keystone | 15:21 | |
| *** markvoelker has quit IRC | 15:22 | |
| openstackgerrit | Tin Lam proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 15:26 |
| *** jhesketh has joined #openstack-keystone | 15:46 | |
| *** lbragsta_ has quit IRC | 15:50 | |
| *** jhesketh has quit IRC | 15:54 | |
| *** thorst has joined #openstack-keystone | 15:55 | |
| *** superdan is now known as dansmith | 15:56 | |
| *** markvoelker has joined #openstack-keystone | 16:19 | |
| openstackgerrit | Tin Lam proposed openstack/python-keystoneclient master: Add project tags to keystoneclient https://review.openstack.org/481223 | 16:34 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/486336 | 16:38 |
| *** markvoelker has quit IRC | 16:52 | |
| *** jmlowe has joined #openstack-keystone | 17:24 | |
| *** aselius has quit IRC | 17:31 | |
| *** lwanderley has joined #openstack-keystone | 17:45 | |
| *** r-daneel has joined #openstack-keystone | 17:45 | |
| *** markvoelker has joined #openstack-keystone | 17:49 | |
| *** thorst has joined #openstack-keystone | 17:56 | |
| openstackgerrit | prashkre proposed openstack/keystone master: Filter users and groups in ldap https://review.openstack.org/485302 | 17:57 |
| *** markvoelker has quit IRC | 17:59 | |
| *** markvoelker has joined #openstack-keystone | 18:00 | |
| *** thorst has quit IRC | 18:01 | |
| *** lwanderley has quit IRC | 18:16 | |
| *** lwanderley has joined #openstack-keystone | 18:18 | |
| openstackgerrit | Tin Lam proposed openstack/python-keystoneclient master: Add project tags to keystoneclient https://review.openstack.org/481223 | 18:19 |
| *** r-daneel has quit IRC | 18:19 | |
| *** markvoelker has quit IRC | 18:23 | |
| efried_zzz | lbragstad morgan mordred dims those two fixes merged - https://review.openstack.org/#/c/486279/ <== ksa 3.0.1 good to go now? | 18:26 |
| *** nicolasbock has joined #openstack-keystone | 18:26 | |
| *** aojea has quit IRC | 18:46 | |
| *** markvoelker has joined #openstack-keystone | 19:20 | |
| lbragstad | efried_zzz: yep - looks good to me | 19:27 |
| *** lwanderley has quit IRC | 19:32 | |
| *** lwanderley has joined #openstack-keystone | 19:33 | |
| *** lwanderley has quit IRC | 19:36 | |
| *** lwanderley has joined #openstack-keystone | 19:38 | |
| *** jhesketh has joined #openstack-keystone | 19:39 | |
| *** jhesketh has quit IRC | 19:44 | |
| *** lwanderley has quit IRC | 19:45 | |
| *** lwanderley has joined #openstack-keystone | 19:51 | |
| *** jhesketh has joined #openstack-keystone | 19:51 | |
| *** thorst has joined #openstack-keystone | 19:51 | |
| *** markvoelker has quit IRC | 19:54 | |
| *** lwanderley has quit IRC | 19:58 | |
| *** jhesketh has quit IRC | 19:59 | |
| *** lbragsta_ has joined #openstack-keystone | 20:08 | |
| *** ChanServ sets mode: +o lbragsta_ | 20:08 | |
| *** lwanderley has joined #openstack-keystone | 20:09 | |
| *** lwanderley has quit IRC | 20:16 | |
| *** lwanderley has joined #openstack-keystone | 20:16 | |
| *** lbragsta_ has quit IRC | 20:22 | |
| *** nicolasbock has quit IRC | 20:43 | |
| *** lwanderley has quit IRC | 20:44 | |
| *** markvoelker has joined #openstack-keystone | 20:51 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Add JSON schema validation for project tags https://review.openstack.org/484483 | 21:03 |
| *** thorst has joined #openstack-keystone | 21:22 | |
| *** markvoelker has quit IRC | 21:25 | |
| *** catintheroof has joined #openstack-keystone | 21:47 | |
| *** thorst has joined #openstack-keystone | 21:53 | |
| *** thorst has quit IRC | 21:59 | |
| *** lbragsta_ has joined #openstack-keystone | 22:25 | |
| *** ChanServ sets mode: +o lbragsta_ | 22:25 | |
| *** lbragsta_ has quit IRC | 22:26 | |
| *** lbragsta_ has joined #openstack-keystone | 22:30 | |
| *** ChanServ sets mode: +o lbragsta_ | 22:30 | |
| *** deep-book-gk_ has joined #openstack-keystone | 22:56 | |
| *** deep-book-gk_ has left #openstack-keystone | 22:57 | |
| mordred | lbragstad, efried_zzz, morgan: \o/ only a couple of days of something being broken! I think that's pretty good for such a large release | 22:59 |
| *** lbragsta_ has quit IRC | 23:00 | |
| *** aojea has joined #openstack-keystone | 23:02 | |
| *** aselius has joined #openstack-keystone | 23:17 | |
| *** phalmos has joined #openstack-keystone | 23:19 | |
| *** aojea has quit IRC | 23:21 | |
| *** markvoelker has joined #openstack-keystone | 23:21 | |
| openstackgerrit | Jaewoo Park proposed openstack/keystone master: WIP: Add project tags https://review.openstack.org/470317 | 23:23 |
| *** phalmos has quit IRC | 23:35 | |
| *** thorst has joined #openstack-keystone | 23:55 | |
| *** markvoelker has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!