| *** mrunge_ is now known as mrunge | 06:35 | |
| opendevreview | Pierre Riteau proposed openstack/kolla-ansible master: Remove deprecated secure_proxy_ssl_header option https://review.opendev.org/c/openstack/kolla-ansible/+/944032 | 12:31 |
|---|---|---|
| opendevreview | Pierre Riteau proposed openstack/kolla-ansible master: Fix path to heat config-generator.conf https://review.opendev.org/c/openstack/kolla-ansible/+/944033 | 12:42 |
| opendevreview | Pierre Riteau proposed openstack/kolla-ansible master: Remove oslo_concurrency from keystone.conf https://review.opendev.org/c/openstack/kolla-ansible/+/944034 | 12:50 |
| shermanm | in kolla-ansible, is there a recommended style for "template thing if variable is configured"? | 15:14 |
| shermanm | wondering if we have something preferred over: | 15:14 |
| shermanm | {% if some_ansible_var is defined %} | 15:14 |
| shermanm | a_conditional_line | 15:14 |
| shermanm | {% else %} | 15:14 |
| shermanm | otherwise_default_line | 15:14 |
| shermanm | {% endif %} | 15:14 |
| opendevreview | Merged openstack/kayobe stable/2024.2: CI: create ansible.cfg for pre-upgrade deployment https://review.opendev.org/c/openstack/kayobe/+/942344 | 15:31 |
| opendevreview | Merged openstack/kayobe stable/2024.1: CI: create ansible.cfg for pre-upgrade deployment https://review.opendev.org/c/openstack/kayobe/+/942345 | 15:31 |
| jovial | shermanm, I guess normally, the variable is defined in role defaults or group_vars/all.yml as kind of documentation that the variable exists, so you'd have to use `is truthy` or similar | 15:38 |
| shermanm | jovial: yeah, that's what I was thinking, but then `is truthy` breaks if you eventually set a default. some places seem to have a pair of variables for e.g. `feature_x_enabled: true` `feature_x_value: something` | 15:47 |
| jovial | I guess to extent, we have a bunch of feature flags: https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L836 which then might cause other variables to be used, but those variables don't follow that feature_x_value pattern | 15:54 |
| jovial | We don't really leave variables undefined though; they always get some sensible default | 15:56 |
| shermanm | thanks! for context, we're maintaining a decently large downstream fork of kolla-ansible and various services, and I've been looking for ways to keep it more maintainable and make it easier to upstream things | 16:03 |
| opendevreview | Merged openstack/kayobe stable/2023.2: CI: create ansible.cfg for pre-upgrade deployment https://review.opendev.org/c/openstack/kayobe/+/942346 | 16:18 |
| opendevreview | Merged openstack/kayobe stable/2024.2: Remove graphlib-backport requirement https://review.opendev.org/c/openstack/kayobe/+/943171 | 16:18 |
| opendevreview | Pierre Riteau proposed openstack/kayobe master: Remove remaining mentions of Ubuntu Jammy https://review.opendev.org/c/openstack/kayobe/+/944075 | 22:02 |
| opendevreview | Pierre Riteau proposed openstack/kayobe master: CI: Make kayobe-seed-images-rocky9-podman experimental https://review.opendev.org/c/openstack/kayobe/+/944076 | 22:07 |
| opendevreview | Pierre Riteau proposed openstack/kayobe master: Revert "CI: Make kayobe-overcloud-upgrade-slurp-rocky9 non-voting" https://review.opendev.org/c/openstack/kayobe/+/944077 | 22:12 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!