Tuesday, 2014-07-29

*** fnaval has joined #openstack-lbaas00:15
*** xgerman has quit IRC00:27
*** sbfox has joined #openstack-lbaas00:51
*** vivek-ebay has joined #openstack-lbaas01:50
*** woodster__ has quit IRC01:55
dougwigmestery: https://github.com/dougwig/a10_lbaas_driver/tree/juno-forwarding/tests-noop02:03
*** sbalukoff has quit IRC02:04
dougwigapologies for the delay, had to make a non-a10 driver version.  i was going to add haproxy, with traffic passing testing, but i still can't get a pool to create.  blogan and/or ctracey, that test shows the session persistence issue.02:04
dougwignosetests test_noop.py02:04
ctraceydougwig: thanks02:07
ctraceyman if it werent for members02:08
dougwigi'm wagering my test is broken for members, since it's never gotten that far.  :)02:09
*** fnaval has joined #openstack-lbaas02:09
ctraceypool:members is causing all kinds of gried02:14
ctraceygrief02:14
ctraceywith unit testing02:14
dougwigdidn't members require a pool in v1?02:14
ctraceyi believe they were top-level though, right?02:15
dougwigahh, i see.02:15
dougwiga trailblazer, you are.02:15
ctraceythe nesting breaks a LOT of the existing plumbing02:15
ctraceyi have all the tests except for members at this poit02:16
ctraceypoint(02:16
ctraceygrrr02:16
ctraceythat and testr sucks for telling you WTF failed02:16
ctracey"ConnectionFailed: Connection to neutron failed: Maximum attempts reached"02:16
ctraceymakes perfect sense for a unit test, no?02:16
ctracey:)02:16
dougwigany idea where that damn session persistence is getting injected?  i'm not even passing it in.02:17
dougwigcompared to the messages when an import fails (which is 10 screens of nonsense characters), that's a downright sunny error.02:17
ctraceydougwig: that is what I was fighting for 2 days02:18
ctraceyi have no looked at the session_persistence one yet02:18
ctraceybut my units pass...02:18
dougwigwhen that hits, run it in 2.6, and the import error is printed normally.02:18
ctraceysuspect something on the API side02:18
ctraceywhen i was working through that I didnt have the 26 interpretter installed02:19
ctraceynow i do02:19
ctraceyfor a while I was only getting:02:19
ctraceyhttps://www.irccloud.com/pastebin/4IDtFCMa02:20
ctraceynothing more02:20
ctraceywhich is super lovely02:20
ctraceythat an no pdb, etc02:20
dougwigstrace -f -f -s 1024, can shed some light sometimes.02:21
dougwig(prepend that before tester)02:21
ctraceyhah02:21
ctraceyi bet...though seriously...wtf?02:22
dougwigi have never met a test harness so eager to hide data, that's for sure.  :)02:22
ctraceywhat about neutronclient itself? :)02:23
ctraceyhad a new guy run 'neutron quota-delete'02:23
ctraceyguess what that does? :)02:23
ctraceywarn you? no02:23
ctraceyjust deletes the current tenant's quotas02:23
ctraceythe whole way that quotas are handled in both nova and neutron leaves a lot to be desired02:24
dougwigas barbican told us, only idiots need a warning.02:24
dougwig:)02:24
ctraceyhah02:25
ctraceynova and neutron also want tenant-id's for quotas02:25
ctraceybut will accept names02:25
ctraceycant tell you how many customers have tripped on this02:25
dougwighavana was super hit and miss for id vs name, but icehouse is pretty good about accepting names, if they're unique.02:26
ctraceyi think i will add a sanity check..."does it look like a UUID? no? bail out"02:26
ctraceyi think names are generally bad02:26
ctraceyespecially when customers are running with admin context02:26
dougwignot when i'm typing.  nothing beats "nova start s1"02:27
ctraceyoh i bet02:27
ctraceybut if you ever use something like Cloud Foundry...all bets are off02:27
dougwigif i'm using a paas, then wtf am i typing openstack commands directly?02:34
ctraceydougwig: youre not...02:46
ctraceythe issue is that things like sec groups can be specified as names...ie. default02:47
ctracey"default" can be used as a name across multiple tenancies02:47
ctraceythe first person to run as an admin will break02:48
dougwigLOL02:49
dougwigoh, i can totally see that.02:50
*** vivek-eb_ has joined #openstack-lbaas03:33
*** mestery_ has joined #openstack-lbaas03:34
*** mestery has quit IRC03:36
*** vivek-ebay has quit IRC03:37
*** vivek-eb_ has quit IRC03:38
*** mestery_ has quit IRC03:46
bloganctracey: found out the session_persistence issue, this is what the client is sending as session_persistence03:55
blogan"session_persistence ": null03:55
bloganthat space after the e is causing the issue03:56
*** mestery has joined #openstack-lbaas03:56
ctraceyblogan: thanks03:57
ctraceyvery odd as I dont do anything in that code03:58
ctraceyhttps://www.irccloud.com/pastebin/pmih0klr03:58
ctraceyand...03:58
ctraceyhttps://www.irccloud.com/pastebin/4UlRogiU03:59
*** mestery_ has joined #openstack-lbaas03:59
ctraceyi will take a look tomorrow03:59
bloganim sure its something along the lines of "if this attr name ends with an e, lets add a space at the end of it, because why not?"04:00
blogani hope its not doing that, im being sarcastic of course04:00
bloganctracey: thanks for looking into it, sorry i didn't just pool down the client code sooner04:01
bloganpool = pull04:01
*** mestery has quit IRC04:02
*** woodster__ has joined #openstack-lbaas04:03
*** fnaval has quit IRC04:05
*** fnaval_ has joined #openstack-lbaas04:07
bloganctracey: just fyi, i added session_persistence to the actual cli pool create call and got this04:08
bloganhttp://pastebin.com/rQWk0spK04:08
bloganjust more info for whenever you look into it04:08
*** fnaval_ has quit IRC04:09
*** fnaval_ has joined #openstack-lbaas04:10
*** fnaval has joined #openstack-lbaas04:11
*** mestery_ has quit IRC04:11
*** fnaval_ has quit IRC04:14
dougwigblogan: in the meantime, do you have an api client level test script we can provide for kyle?04:15
blogandougwig: ive just been using a browser rest client04:16
dougwiggot a log you can send me, and i'll script it quick?04:16
dougwigor else i can put something together in the morning.04:16
bloganwell this thing stores my saved requests in json so let me see how parseable it is04:17
bloganhell i could whip up some curl requests fairly quickly04:17
dougwigthat's all i was gonna do, too.04:18
blogani'll do that right now04:19
blogandoesn't hurt to put them up on that deployment wiki page for now04:19
dougwigok, awesome04:19
dougwigespecially not if it gets the review train moving04:19
blogani'm afraid to touch that first review, oleg gave it a +204:19
blogani can't remember if hitting the rebase button wipes it all out, im pretty sure it does04:20
dougwignow you know how i felt with the no-op review.  i overwrote so many +2's that I wanted to cry.04:20
bloganlol04:20
dougwigrebase doesn't wipe out -1's.04:20
bloganso the opposite of what i want04:20
dougwigmeaning, rebase has different behavior than a push.  no clue if +2 is in that mix.04:21
*** mestery has joined #openstack-lbaas04:21
bloganusing the debug output of the client makes the curl thing much easier04:22
bloganyeah not worth testing it out in this case04:23
bloganthe rebase i mean04:23
*** sbfox has quit IRC04:26
*** sbfox has joined #openstack-lbaas04:33
*** fnaval has quit IRC04:45
blogandougwig: when you get a chance added the "scripts" to https://wiki.openstack.org/wiki/Neutron/LBaaS/DeployWithDevstack04:45
*** HenryG is now known as HenryG_afk04:45
*** fnaval has joined #openstack-lbaas04:45
*** fnaval has quit IRC04:50
dougwigtesting now04:51
dougwigsub this for auth token insert:04:54
dougwigkeystone token-get --wrap 0 | grep ' id ' | awk '{print $4}'04:54
bloganahh04:54
dougwigone sec, folding that into the script that runs the whole matrix.04:54
bloganupdated the page04:58
dougwigctracey: your pool arg for listeners doesn't take names (which i know you hate, but goes against the rest of the cli.)05:15
dougwighang on, might just be a bad error.05:17
*** sbfox has quit IRC05:40
dougwigmestery: test script updated with client workaround.  grab those two files, enable the haproxy driver, it should create all the objects.  might need to tweak the neutron network names in local_env.05:46
dougwigblogan: pythonified;05:47
dougwighttps://www.irccloud.com/pastebin/cDIRqFz005:47
*** ctracey has quit IRC06:01
*** woodster__ has quit IRC06:05
*** ctracey has joined #openstack-lbaas06:07
*** ctracey has quit IRC06:22
*** ctracey has joined #openstack-lbaas06:29
*** evgenyf has joined #openstack-lbaas07:23
*** sbalukoff has joined #openstack-lbaas08:03
*** evgenyf has quit IRC09:24
*** evgenyf has joined #openstack-lbaas09:37
*** enikanorov_ has joined #openstack-lbaas09:45
*** enikanorov has quit IRC09:46
*** vivek-ebay has joined #openstack-lbaas10:16
*** vivek-ebay has quit IRC10:20
*** HenryG_afk is now known as HenryG10:53
*** [1]evgenyf has joined #openstack-lbaas11:10
*** evgenyf has quit IRC11:13
*** [1]evgenyf is now known as evgenyf11:13
*** woodster__ has joined #openstack-lbaas12:32
mesterydougwig: thanks sir!12:47
*** sballe has joined #openstack-lbaas12:55
*** fnaval has joined #openstack-lbaas13:18
*** vivek-ebay has joined #openstack-lbaas13:23
*** vivek-ebay has quit IRC13:31
*** fnaval has quit IRC13:57
*** fnaval has joined #openstack-lbaas13:58
*** fnaval has quit IRC14:02
*** rolledback has joined #openstack-lbaas14:07
*** rolledback has quit IRC14:13
*** rolledback has joined #openstack-lbaas14:13
*** fnaval has joined #openstack-lbaas14:20
*** rolledback has quit IRC14:46
*** mlavalle has joined #openstack-lbaas15:04
rm_worksbalukoff: what's your schedule look like today? pretty busy, or do you have some time? we've got some devs that actually have open hours this sprint and we're considering beginning some design discussions around Octavia -- and I know you guys will definitely need to be included there (and possibly already have some design drafts?)15:16
rm_workdon't need to do it NOW, just letting you know (in fact, probably we'll be distracted for the next couple of hours anyway)15:17
rm_workI believe sballe also would want to be in any discussions there15:18
rm_worknot sure who else15:18
rm_workfirst discussions might even just be figuring out *how to have our discussions* :P15:18
sballerm_work, yes please and xgerman too15:23
sballerm_work, We have a draft of a proposal. sbalukoff and I can go over it15:24
sballeI have better time tomorow. Today is wall to wall meetings.15:25
rm_workkk15:25
rm_workany chance we could get your proposal so we could at least read over it today?15:26
rm_workor would you rather go through it online15:26
sballerm_work, sure. as soon as sbalukoff is online I am assuming he can send it to you15:29
*** sbfox has joined #openstack-lbaas15:31
*** rolledback has joined #openstack-lbaas15:38
*** fnaval has quit IRC15:41
*** fnaval has joined #openstack-lbaas15:42
*** xgerman has joined #openstack-lbaas15:43
*** fnaval has quit IRC15:46
*** HenryG_ has joined #openstack-lbaas15:48
sballerm_work, blogan, dougwig What the status of the new API and Object model? is everythign merged and done?15:51
*** HenryG has quit IRC15:52
*** HenryG_ is now known as HenryG_afk15:52
*** HenryG_afk is now known as HenryG15:52
dougwigsballe: in gerrit, some rough edges, at least two of us have it creating objects successfully at this point.15:53
sballedougwig, thanks :)15:54
dougwigblogan: you got double-rebased last night.15:58
dougwigand from the look of jenkins, not in a happy way.15:59
dougwigmestery: i expect the code reviews are messed up right now, due to the dependent rebasing.15:59
*** evgenyf has quit IRC16:09
blogandougwig: i noticed :(16:11
bloganwell time to spend some time on this16:12
*** markmcclain has joined #openstack-lbaas16:15
mesteryblogan dougwig: And I was just about to try to re-setup my devstack and try things out. :)16:16
dougwigmestery: definitely WAIT.  :)16:18
dougwigunless you like pain.  i won't judge.16:18
mesterydougwig: Heh, ok, waiting16:18
dougwigwait, did i just put in effort to get a core to *not* do a review?  that's a switch.  :)16:19
*** rolledback has quit IRC16:28
blogandougwig: it was for the betterment of mestery's sanity16:29
*** rolledback has joined #openstack-lbaas16:29
dougwigahh, here comes the march of the CI emails.16:37
*** rolledback has quit IRC16:39
*** crc32 has joined #openstack-lbaas16:41
*** sbfox has quit IRC16:42
*** dlundquist has joined #openstack-lbaas16:42
*** rolledback has joined #openstack-lbaas16:43
*** crc32 has quit IRC16:50
blogandougwig: well they'll come but may as well make the nit changes while im at it so this will take longer than me just pushing up the fixes16:50
*** xgerman has quit IRC16:51
*** xgerman_ has joined #openstack-lbaas16:52
*** fnaval has joined #openstack-lbaas16:52
blogancomments without spaces after the # are all over the neutron code, but i'll still fix mine anyway16:54
*** rolledback has quit IRC16:55
*** sbfox has joined #openstack-lbaas16:57
*** dlundquist has quit IRC16:58
*** jorgem has joined #openstack-lbaas17:03
dougwigthat's technically a pep8 violation, but it might not be a hacking violation (or might have that rule ignored in neutron's tox file)17:04
*** jorgem1 has joined #openstack-lbaas17:09
*** jorgem has quit IRC17:10
*** dlundquist has joined #openstack-lbaas17:11
*** fnaval has quit IRC17:13
*** fnaval has joined #openstack-lbaas17:13
*** rolledback has joined #openstack-lbaas17:15
*** crc32 has joined #openstack-lbaas17:17
*** fnaval has quit IRC17:18
bloganmestery: things have been cleared up with the reviews17:25
bloganmestery: you're free to pound on it17:25
*** fnaval has joined #openstack-lbaas17:26
*** sbfox1 has joined #openstack-lbaas17:35
mesteryblogan: thank you sir!17:35
*** sballe has quit IRC17:36
*** sbfox has quit IRC17:37
dougwigmestery: i'd suggest waiting for jenkins to finish first.17:38
dougwigblogan: you inspired me to finally put in mail filters.17:38
mesterydougwig: ++17:39
dougwigcommit message question, if anyone knows.  for "Implements blueprint", do you use the blueprint filename after that (minus the .rst), or the name of the topic branch the bp got submitted under?17:40
blogandougwig: whatever launchpad's blueprint name is17:57
dougwigahh, three sources of truth.  nice.18:00
bloganwell thats why they say name the rst file the same name as the launchpad blueprint18:03
bloganbut the reason I say launchpad blueprint name, is because when you click on that link it goes to launchpad18:04
dlundquistblogan: I might have hit a snag on the haproxy proxy driver member subnets: it seems we need to track which ports are associated with which load balancer some how. Although I'm not seeing how the existing haproxy driver does this18:10
blogandlundquist: you mean for the member subnets?18:10
dlundquistyes18:10
dougwigwouldn't you either store the port with the member, or use the member ip+subnet to lookup the port?18:10
blogandougwig: correct on your second part18:11
blogandougwig: at least that is what is done in v1 with teh pool subnet in other drivers18:11
dougwigthe first was a future enhancement for ease, not today.18:11
bloganironically, the haproxy driver in v1 does not actually do anything with the pool subnet, so its only one arm loadbalancing18:11
dlundquistI'm wondering how we know which ports belong to the load balancer after deleting a member18:12
*** markmcclain has quit IRC18:12
dougwigserious question: why do you care?18:12
dlundquistif the name space is still present its easy find them, but if the node is rebooted we could leak ports18:12
dougwigdon't those ports belong to the nova instance, and it's an instance cleanup problem?18:13
dlundquistno, the haproxy namespace needs to plug into unique member subnet18:14
dlundquistin case there is no L3 path from the loadbalancer port to the member18:14
blogandlundquist is right18:14
dlundquistIt doesn't look like the existing HAproxy driver does this18:14
bloganit does not18:15
dougwigi thought the suggestion was to use static routes to the subnet gateway?18:15
dlundquistHow does that work if a member is on an isolated network?18:15
*** markmcclain has joined #openstack-lbaas18:16
sbalukoffdlundquist: Are you perhaps suggesting a supplemental table to keep track of this is going to be necessary (not one exposed by the API of course)?18:16
dlundquistI think it the load balancer port mappings need to be persisted in the DB somewhere18:17
*** markmcclain1 has joined #openstack-lbaas18:17
dougwigi think if the v1 driver doesn't support this, it might be out of scope for the ref driver.18:17
dougwigand isolated how?  don't all neutron subnets have a gateway you can lookup, assuming service account permissions?18:18
sbalukoffThe v1 driver is supposed to support multiple member subnets.18:18
dougwigright, via routes.  i remember this exact conversation at the meetup.18:18
dlundquistdougwig: you can create a subnet without a gateway18:18
bloganthe v1 driver is supposed to support one pool subnet18:19
dougwigso are we fixing a v1 bug, or fixing it on the sly into v2?  can we phase it as a separate commit, and not bundling it all into what we're trying to get in?18:19
bloganhowever it does not, i talked to mark about it and he was under the assumption it did but he thinks maybe it got removed18:19
blogandougwig: I've actually got some code for it but was going to bring it up on rather it should be included in this or later since v1 didn't have it working18:20
dlundquistI'm fine leaving this deficiency, but it does seem to be a deficiency in the v1 HAProxy driver18:20
*** markmcclain has quit IRC18:21
dougwigconcur that it's a bug.  i don't know, we're already at risk, the lure of slipping in fixes can be the death of a timeline.18:21
bloganyes and I'd rather not put it in18:21
bloganbecause of it adding extra things people need to look at18:21
sbalukoffAah.18:21
dlundquistsounds good18:21
bloganhowever, not many are actually looking at that code right now18:21
sbalukoffWell, I'm OK with that, too.18:22
dougwigor if you can structure it as a dependent review behind the core ref driver; i don't want to lose the work.  i also don't want it to distract or add risk.18:22
bloganoh god, antoher dependent review?18:22
dougwiglol.18:22
dougwigdon't you have a script to rollback the magic yet?18:22
bloganmo' dependent reviews, mo' problems18:22
blogani need to reply to that ML thread about this and just tell people to look at the dependent commits' hashes and if its not the same as in gerrit, something bad happened18:23
dougwigi said that in my reply.18:23
dougwigit was on the list of "how to change your stuff later."18:23
bloganoh i guess i had my dougwig filter enabled18:23
dougwigit's a common filter.18:24
bloganmore useful than the gerrit CI filter i have18:24
* dougwig pouts.18:25
dlundquistShould I file a bug against the existing v1 HAProxy driver?18:27
dlundquistShould we bubble up an unsupported configuration exception when building a load balancer with member subnet_id set?18:28
dougwigassuming that they'll just use an ip without a subnet if it's routable?18:29
dlundquistyes, if no subnet is specified it should assume the IP is reachable via the load balancers default route18:31
dougwigat the driver level, sounds reasonable.  at the plugin level, not so much.18:32
bloganwhat sounds reasonable at the driver level?18:32
dlundquistI think surfacing an error we encounter an supported configuration is better than not implementing the configuration completely18:47
*** sbfox1 has quit IRC19:03
*** sbfox has joined #openstack-lbaas19:03
*** rolledback has quit IRC19:12
*** sbfox has quit IRC19:17
blogandlundquist: are you saying if a user creates a member with subnet_id bubble up ane xception?19:32
bloganmestery: all those reviews have passed the CI's, except the last one, which was expected19:32
mesteryblogan: nice nice nice!19:33
*** openstackgerrit has quit IRC19:48
dlundquistblogan: Yes, if the user creates a member with the subnet_id set, the HAProxy driver should raise an exception since that feature is not supported by the driver.19:58
*** markmcclain1 has quit IRC19:59
*** markmcclain has joined #openstack-lbaas20:00
blogandlundquist: ah okay I see what you mean now.  I'm on the fence with that, but will do what the majority wants.  My reason for being on the fence is that it didn't work in v1 and it didn't throw that exception20:11
bloganand we intend on fixing it after all is said and done20:12
dlundquistokay, should we atleast log that were not implementing that feature20:25
*** sbfox has joined #openstack-lbaas20:43
*** clev has joined #openstack-lbaas20:47
*** banix has joined #openstack-lbaas20:50
*** sbfox has quit IRC20:54
*** rolledback has joined #openstack-lbaas20:55
banixwas asking a question from blogan on the neutron channel and he mentioned there is a lbaas channel as well :) so switching to here20:56
*** openstackgerrit has joined #openstack-lbaas20:58
dougwigbanix: the answer is that you get status of members from the haproxy driver via the stats() API.20:58
dougwigthere's a super recent ML thread about it, where someone on heat tested it out and posted an example.20:59
banixmy question was about how the status of pool members get updated by health monitors. I am wondering if it would be possible for having some kind of notification issued when the status of a pool member gets updated. I do not see the current code doing anything like that. Would that be reasonable?20:59
*** rolledback has quit IRC21:00
banixdougwig: thanks. yes i am trying to get to the next question about the notification; was wondering what you think of such a thing21:00
*** dlundquist has left #openstack-lbaas21:04
*** dlundquist has joined #openstack-lbaas21:10
*** fnaval has quit IRC21:12
*** fnaval has joined #openstack-lbaas21:13
bloganbanix: you basically want notifications sent when the state of a member changes21:14
banixblogan: yes, and here is the why if you want to know:21:15
bloganoh i know why, its very helpful for automated systems and just any operators to get notified, isntead of manually checking the API21:16
banixblogan: for consumption by Heath for scaling groups21:16
bloganHeath? you mean Heat?21:17
banixblogan: exactly but this is a more specific use case21:17
banixyeas Heat21:17
*** fnaval has quit IRC21:17
bloganah okay, making sure there wasn't another project i'm not aware of21:17
bloganso what kind of notification would Heat need and where would it need it?21:19
blogani understand Heat from a very high level, haven't dealt too much with it21:19
*** jorgem1 has quit IRC21:20
banixblogan: just to make sure I am not getting ahead of myself here, there is a proposal in that community (and there has been discussions about it for some time) for scaling group to be able to detect changes in the scaling group21:21
banixblogan: so right now the scaling group does not do the health maintenance of members as AWS does21:23
blogani haven't read those discussions, so excuse my ignorance, but out of curiousity what will happen when a member sends a notification that is down?21:23
bloganbanix: yeah and lbaas is probably further behind AWS than what the scaling group is21:25
banixblogan: can lead to starting new instances (deploying new resources)  for example21:26
bloganok thats what i figured21:26
bloganbut its more of an action a user can define21:26
banixblogan: yes21:26
bloganbanix: well lbaas is in a bit of a transition in Juno, and it will bleed over into Kilo as well21:26
banixblogan: i think this is just one piece to get to a better scaling group…21:27
banixblogan: yes, i follow the good work of the lbaas team and see the patches and the ml discussions21:27
banixblogan: i wanted to first get a sense of what you think of adding something like that …21:28
dougwigi think it'd be good to add, fwiw.21:30
bloganbanix: well i'm definitely all for it, I know it won't be bale to be done in Kilo, and I'm unsure about it in Kilo21:30
bloganbut yes it should be done21:30
banixblogan: you mean not in Juno21:30
banixblogan: maybe Kilo?21:30
bloganoh yeah sorry21:30
dougwigblogan has been non-stop coding, has a new kid, and his wife had her tonsils out.  how he's even responding at all, i don't know.21:31
bloganbanix: i would say there's a chance21:31
banixdougwig: blogan: thanks for answering my questions21:31
banixyeah with all that is going on in Neutron it has been a really busy cycle21:31
banixand we seem to have a lot more to land for the basic stuff we need in the next month or so; so i understand21:32
bloganbanix: no problem, soryr if I couldn't give you a definitive answer of if it can get into Kilo or not21:33
banixblogan: I understand. thanks for the input. so I know if we want to have a chance in Kilo we have to be very pro active and start ealy :)21:34
banixdougwig: just noticed the comment about thre new kid! so congratulations to blogan21:35
banixblogan: you must be feeling exhausted but things will get better hang in there :)21:37
bloganbanix: thanks a lot!21:37
bloganbanix: thats what everyone tells me, I haven't had an uninterrupted night's sleep in forever21:37
*** rolledback has joined #openstack-lbaas21:38
banixblogan: i know; may i ask how old your child is now?21:38
bloganbanix: oh he's 9 months now21:39
bloganbanix: so he's not exactly new, but he's still new to me21:39
bloganhe's about to start walking so thats going to be even more exhausting always having to watch him like a hawk21:40
*** sbfox has joined #openstack-lbaas21:41
banixblogan: All the best to him and your family! you will get more sleep in a few months! yes indeed; walking and crawling at that age when they essentially don’t have an idea about the dangers is really tiring for the parents; you have to be watchful all every second21:41
bloganbanix: thanks, best to you too and your family (sounds like you've got your own little one(s))21:42
banixblogan: thanks I have a son. and as i said, as they get older the connection and communication gets much stronger. Anyhow I better let you go :)21:44
banixBy the way, I have ben reviewing the lbaas code and have had some minor comments (mainly style wise and some questions). I am Mohamad Banikazemi on the review board. Thanks for responding quickly.21:45
bloganbanix: yep looking forward to it.  take care of yourself.  don't let us forget about the member notification feature you want.  I'll try to remember it too21:45
banixblogan: will do. thanks.21:45
bloganbanix: ahh okay, you caught taht one TODO: i forgot to fix21:46
bloganhopefully it was just one21:46
banixjust a nit. very very minor; i think the code is in a very good shape.21:47
bloganbanix: i may end up fixing that in the next commit just so I don't have to add another patchset to that review21:48
*** rolledback has quit IRC21:48
bloganbanix: would that work for you?21:48
banixblogan: yes of course.21:48
bloganthis chain of reviews, and chain branches has been less than ideal so the further up the chain a change happens the greater the chance something bad will happen21:49
bloganand actually now a change that happens at the bottom of the chain can somehow manifest itself into the top piece21:50
*** banix has quit IRC22:09
*** HenryG is now known as HenryG_afk22:18
*** sbfox has quit IRC22:19
*** sbfox has joined #openstack-lbaas22:20
dougwigblogan secretly loves it when you rewrite all of his commits with older code.  it makes him feel loved.22:43
*** fnaval has joined #openstack-lbaas22:46
* blogan goes into the fetal position and cries22:48
bloganthat reminds me, i want to check something22:49
*** fnaval has quit IRC23:06
*** fnaval has joined #openstack-lbaas23:07
*** fnaval has quit IRC23:11
*** dlundquist has left #openstack-lbaas23:13
*** fnaval has joined #openstack-lbaas23:15
*** banix has joined #openstack-lbaas23:23
*** banix has quit IRC23:37
*** banix has joined #openstack-lbaas23:41
*** HenryG_afk is now known as HenryG23:45
*** banix has quit IRC23:46
*** banix has joined #openstack-lbaas23:55
*** banix has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!