openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes Octavia handling of subnets without DHCP https://review.openstack.org/349215 | 00:04 |
---|---|---|
johnsom | Ok, that fixes the VIP port. Next patch will fix the member ports | 00:06 |
*** sbalukoff has joined #openstack-lbaas | 00:39 | |
*** ducttape_ has joined #openstack-lbaas | 00:47 | |
*** saju_m has quit IRC | 00:49 | |
*** ducttape_ has quit IRC | 00:52 | |
*** yamamoto has joined #openstack-lbaas | 00:56 | |
*** saju_m has joined #openstack-lbaas | 01:01 | |
openstackgerrit | Merged openstack/octavia: Updated from global requirements https://review.openstack.org/348651 | 01:06 |
*** yamamoto has quit IRC | 01:08 | |
*** ducttape_ has joined #openstack-lbaas | 01:12 | |
*** yamamoto has joined #openstack-lbaas | 01:14 | |
*** yamamoto has quit IRC | 01:14 | |
*** ducttape_ has quit IRC | 01:15 | |
*** saju_m has quit IRC | 01:23 | |
*** sanazz has joined #openstack-lbaas | 01:32 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes Octavia handling of subnets without DHCP https://review.openstack.org/349215 | 01:39 |
*** bana_k has quit IRC | 01:41 | |
johnsom | That one should be complete, marked WIP as I need to test it out live on devstack | 01:41 |
*** gongysh has joined #openstack-lbaas | 02:09 | |
*** gongysh has quit IRC | 02:14 | |
*** yamamoto has joined #openstack-lbaas | 02:15 | |
*** ducttape_ has joined #openstack-lbaas | 02:15 | |
*** ducttape_ has quit IRC | 02:20 | |
*** yamamoto has quit IRC | 02:21 | |
*** yamamoto has joined #openstack-lbaas | 02:29 | |
*** yamamoto has quit IRC | 02:34 | |
*** ducttape_ has joined #openstack-lbaas | 02:37 | |
*** gongysh has joined #openstack-lbaas | 02:37 | |
*** gongysh has quit IRC | 03:00 | |
*** ducttape_ has quit IRC | 03:01 | |
*** ducttape_ has joined #openstack-lbaas | 03:01 | |
*** ducttape_ has quit IRC | 03:08 | |
*** davidlenwell has quit IRC | 03:12 | |
*** davidlenwell has joined #openstack-lbaas | 03:23 | |
*** bana_k has joined #openstack-lbaas | 03:23 | |
*** yamamoto has joined #openstack-lbaas | 03:34 | |
*** yamamoto has quit IRC | 03:41 | |
*** davidlenwell has quit IRC | 03:42 | |
*** davidlenwell has joined #openstack-lbaas | 03:52 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes Octavia handling of subnets without DHCP https://review.openstack.org/349215 | 03:58 |
openstackgerrit | maoshuai proposed openstack/octavia: fix a misspelling https://review.openstack.org/349220 | 04:01 |
*** bana_k has quit IRC | 04:08 | |
*** ducttape_ has joined #openstack-lbaas | 04:14 | |
*** ducttape_ has quit IRC | 04:16 | |
*** sanazz has quit IRC | 04:43 | |
*** bana_k has joined #openstack-lbaas | 05:02 | |
*** Alex_Stef has joined #openstack-lbaas | 05:13 | |
*** ducttape_ has joined #openstack-lbaas | 05:16 | |
*** ducttape_ has quit IRC | 05:21 | |
*** saju_m has joined #openstack-lbaas | 05:23 | |
*** nmagnezi has joined #openstack-lbaas | 05:30 | |
*** Alex_Stef has quit IRC | 05:30 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes Octavia handling of subnets without DHCP https://review.openstack.org/349215 | 05:38 |
rm_work | johnsom: working now? O_o | 06:03 |
johnsom | Yeah, just polishing unit tests on the dhcp fix | 06:04 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes Octavia handling of subnets without DHCP https://review.openstack.org/349215 | 06:04 |
johnsom | rm_work That should be good for review now | 06:05 |
rm_work | k | 06:06 |
rm_work | might be able to get to it today | 06:06 |
rm_work | wherein today is sunday | 06:06 |
johnsom | Cool, I did pull in some of your code for IPv6 network plugs. If you rebase your IPv6 on this patch, I will rebase failover on yours and we should be godo | 06:07 |
johnsom | good | 06:07 |
rm_work | k | 06:07 |
johnsom | You covered VIPs, but didn't do networks, so I did that part. | 06:08 |
rm_work | yeah | 06:08 |
rm_work | i was figuring out what needed to be done, and planned to address it in another patch | 06:08 |
rm_work | though actually | 06:08 |
rm_work | I discovered that they were coming up as ipv4+6 | 06:08 |
rm_work | somehow | 06:08 |
rm_work | so it was actually working for ipv6+ipv4 members if i did NOTHING | 06:08 |
rm_work | was very odd | 06:08 |
johnsom | Well, shazam, the code is there.... grin | 06:09 |
rm_work | k | 06:10 |
rm_work | tonight | 06:10 |
rm_work | i'll do the rebase | 06:10 |
johnsom | rm_work BTW, if this needs fixes after tomorrow, please just do them. I will be traveling next week and will have limited time/access to do fixes. | 06:16 |
rm_work | kk | 06:16 |
rm_work | hold on maybe I can rebase now | 06:17 |
*** ducttape_ has joined #openstack-lbaas | 06:18 | |
rm_work | johnsom: can the vrrp_ip be ipv6? | 06:21 |
johnsom | Yeah, that should be fine. Probably needs testing, but *should* work | 06:21 |
rm_work | hmm ok | 06:21 |
rm_work | means i have to do a little more i think | 06:21 |
*** ducttape_ has quit IRC | 06:22 | |
johnsom | Sorry if I missed that. I saw that you had VIP covered and didn't look back at it... | 06:22 |
rm_work | so wait, we will plug the vrrp_ip AND the vip? | 06:22 |
johnsom | Yes, one interface, two IPs | 06:22 |
rm_work | k | 06:23 |
johnsom | neutron port-list shows two ports | 06:23 |
johnsom | for the Allowed Address Pairs stuff | 06:23 |
johnsom | vip moves between amps, vrrp_ip is fixed | 06:23 |
rm_work | what is the purpose of the dhcp address | 06:24 |
johnsom | Sadly I have to agree with Stephen, vrrp_ip is not the best name | 06:24 |
rm_work | we set iface {{ interface }}:0 | 06:24 |
rm_work | which is the actual VIP | 06:24 |
rm_work | what is the one before that | 06:24 |
rm_work | it is ... nothing, as far as I can tell | 06:25 |
rm_work | we just bind some other random IP? | 06:25 |
rm_work | via dhcp? | 06:25 |
rm_work | do we need that? | 06:25 |
johnsom | legacy compat is dhcp on the vrrp_ip address. vrrp_ip should have gateway set, VIP does not. | 06:25 |
johnsom | so like eth0 is the vrrp_ip with IP/gateway, eth0:0 is VIP and moves | 06:26 |
rm_work | hmm k | 06:26 |
rm_work | so can eth0 be ipv6 | 06:26 |
johnsom | Yes | 06:26 |
johnsom | Should work, should be tested | 06:26 |
rm_work | and can the vip be ipv6 but the vrrp_ip be ipv4 | 06:26 |
rm_work | or v.v. | 06:26 |
rm_work | seems so? though weird | 06:27 |
johnsom | Ummm | 06:27 |
johnsom | Yeah, not sure on that one. I think it should be one or the other because it is based off what the user gives us for the LB network info | 06:28 |
rm_work | first pass i'll try this and see what people thing | 06:28 |
johnsom | So, more I think about it, no, our code will not allow those to be split. It will either be v4 or v6 | 06:29 |
rm_work | k | 06:29 |
rm_work | i have a strategy | 06:30 |
rm_work | johnsom: can vrrp_ip be None? | 06:30 |
rm_work | looks like so | 06:31 |
rm_work | I'm going to do some tweaks | 06:31 |
johnsom | Yes, for legacy compat. It will drop back to setting it up dhcp | 06:31 |
rm_work | almost done... | 06:33 |
rm_work | ummm hey | 06:36 |
rm_work | when we plug the members | 06:36 |
rm_work | johnsom: how is it possible for ip to be None | 06:36 |
rm_work | {% if ip_address %} | 06:37 |
rm_work | AFAICT it's literally impossible | 06:37 |
johnsom | If a legacy controller is sending commands to a new amp image, it won't pass ip_address in the json | 06:37 |
rm_work | uhh | 06:38 |
rm_work | ok | 06:38 |
rm_work | but then plug.py will explode | 06:38 |
johnsom | So, default back to old behavior, do dhcp | 06:38 |
johnsom | will it? | 06:38 |
rm_work | text = template_port.render(interface=netns_interface, | 06:38 |
rm_work | ipv6=ip.version is 6, | 06:38 |
rm_work | ip_address=ip.exploded, | 06:38 |
rm_work | literally | 06:38 |
rm_work | explode | 06:38 |
rm_work | :P | 06:38 |
rm_work | oh i see | 06:38 |
rm_work | above, if fixed_ips is None | 06:38 |
rm_work | it'll render that bottom part once | 06:39 |
johnsom | Yeah, it should render the old dhcp config | 06:39 |
rm_work | uhh in that case, should we include two interfaces | 06:39 |
rm_work | ipv4 AND ipv6 | 06:39 |
rm_work | just to be good | 06:39 |
rm_work | iface {{ interface }} inet dhcp | 06:39 |
rm_work | iface {{ interface }}:0 inet6 auto | 06:39 |
johnsom | In the "old" case? hmmm | 06:40 |
johnsom | We didn't have it before | 06:40 |
rm_work | <_< | 06:40 |
rm_work | so screw 'em? :P | 06:40 |
johnsom | New code will add it because it will be a second fixed IP | 06:40 |
rm_work | yes | 06:40 |
rm_work | yeah coding for old controllers is <_< | 06:41 |
rm_work | but, does this HURT? | 06:41 |
johnsom | Hmmm, not sure I'm motivated at this hour to spin another patch for that. If they have a mis-match and want v6 they should upgrade both sides... IMHO | 06:41 |
rm_work | i mean | 06:41 |
rm_work | it's part of my patch | 06:41 |
rm_work | for ipv6 | 06:42 |
rm_work | i'm debating leaving the new line or deleting it (I already put it in) | 06:42 |
rm_work | i'll leave it for now | 06:42 |
rm_work | and see what comments i get | 06:42 |
johnsom | Ok, if it's in your patch, fix it with the rebase. I have no problem with that | 06:42 |
johnsom | The ifup doesn't block waiting for the IPv6 addr does it? | 06:43 |
johnsom | v4 dhcp will block the ifup for a while | 06:43 |
rm_work | I don't think so | 06:46 |
rm_work | hmm | 06:47 |
johnsom | It's rolling into midnight here and I've been working on this patch all afternoon. I'm going to call it an evening. I will check the history in the morning. | 06:49 |
johnsom | 良い夜/幸せな日曜日 | 06:51 |
rm_work | getting test output to line up is always fun | 07:02 |
rm_work | lol I see night there | 07:02 |
rm_work | and Sunday :P | 07:03 |
rm_work | ah | 07:03 |
rm_work | :P | 07:03 |
rm_work | おやすみ | 07:03 |
*** kobis has joined #openstack-lbaas | 07:03 | |
openstackgerrit | Adam Harwell proposed openstack/octavia: Allow IPv6 VIPs https://review.openstack.org/339826 | 07:05 |
*** yamamoto has joined #openstack-lbaas | 07:15 | |
*** yamamoto has quit IRC | 07:20 | |
*** Alex_Stef has joined #openstack-lbaas | 07:23 | |
*** bana_k has quit IRC | 07:48 | |
*** ducttape_ has joined #openstack-lbaas | 08:19 | |
*** ducttape_ has quit IRC | 08:23 | |
*** rudrajit has quit IRC | 08:34 | |
*** rudrajit has joined #openstack-lbaas | 08:35 | |
*** rudrajit has quit IRC | 08:40 | |
*** sanazz has joined #openstack-lbaas | 08:56 | |
*** sanazz has quit IRC | 09:00 | |
*** ihrachys has joined #openstack-lbaas | 09:04 | |
*** rudrajit has joined #openstack-lbaas | 09:05 | |
*** chlong has joined #openstack-lbaas | 09:05 | |
*** rudrajit has quit IRC | 09:09 | |
*** ihrachys has quit IRC | 09:17 | |
*** ihrachys has joined #openstack-lbaas | 09:18 | |
*** ducttape_ has joined #openstack-lbaas | 09:20 | |
*** ducttape_ has quit IRC | 09:24 | |
*** ihrachys has quit IRC | 09:42 | |
*** ihrachys has joined #openstack-lbaas | 09:49 | |
*** eezhova has joined #openstack-lbaas | 10:02 | |
*** ihrachys has quit IRC | 10:06 | |
*** ihrachys has joined #openstack-lbaas | 10:06 | |
*** yamamoto has joined #openstack-lbaas | 10:08 | |
*** yamamoto has quit IRC | 10:08 | |
*** yamamoto has joined #openstack-lbaas | 10:10 | |
*** yamamoto has quit IRC | 10:15 | |
*** ducttape_ has joined #openstack-lbaas | 10:20 | |
*** ducttape_ has quit IRC | 10:25 | |
*** ihrachys has quit IRC | 10:31 | |
*** ihrachys has joined #openstack-lbaas | 10:33 | |
*** yamamoto has joined #openstack-lbaas | 10:55 | |
*** yamamoto has quit IRC | 10:55 | |
*** yamamoto has joined #openstack-lbaas | 10:56 | |
*** ihrachys_ has joined #openstack-lbaas | 11:04 | |
*** ihrachys has quit IRC | 11:06 | |
*** ihrachys_ has quit IRC | 11:19 | |
*** ihrachys has joined #openstack-lbaas | 11:28 | |
*** ihrachys has quit IRC | 11:51 | |
*** ihrachys has joined #openstack-lbaas | 11:53 | |
*** ihrachys has quit IRC | 12:09 | |
*** ducttape_ has joined #openstack-lbaas | 12:11 | |
*** ihrachys has joined #openstack-lbaas | 12:21 | |
*** eezhova has quit IRC | 12:21 | |
*** ihrachys has quit IRC | 12:35 | |
*** ihrachys has joined #openstack-lbaas | 12:39 | |
*** ducttape_ has quit IRC | 13:12 | |
*** ihrachys has quit IRC | 13:18 | |
*** ihrachys has joined #openstack-lbaas | 13:27 | |
*** Alex_Stef has quit IRC | 13:57 | |
*** kobis has quit IRC | 13:57 | |
*** yamamoto has quit IRC | 13:58 | |
*** ihrachys has quit IRC | 14:04 | |
*** ducttape_ has joined #openstack-lbaas | 14:12 | |
*** ihrachys has joined #openstack-lbaas | 14:12 | |
*** ducttape_ has quit IRC | 14:17 | |
*** ihrachys_ has joined #openstack-lbaas | 14:20 | |
*** ihrachys has quit IRC | 14:23 | |
*** ihrachys_ has quit IRC | 14:38 | |
*** ihrachys has joined #openstack-lbaas | 14:41 | |
*** yamamoto has joined #openstack-lbaas | 14:59 | |
*** yamamoto has quit IRC | 15:05 | |
*** ducttape_ has joined #openstack-lbaas | 15:14 | |
*** ducttape_ has quit IRC | 15:18 | |
*** ihrachys has quit IRC | 15:20 | |
*** ihrachys has joined #openstack-lbaas | 15:30 | |
*** ihrachys has quit IRC | 15:31 | |
*** bana_k has joined #openstack-lbaas | 15:40 | |
*** ihrachys has joined #openstack-lbaas | 15:40 | |
*** ihrachys has quit IRC | 15:53 | |
*** ihrachys has joined #openstack-lbaas | 15:58 | |
*** bana_k has quit IRC | 16:09 | |
*** ihrachys_ has joined #openstack-lbaas | 16:09 | |
*** ihrachys has quit IRC | 16:09 | |
*** ducttape_ has joined #openstack-lbaas | 16:14 | |
*** ihrachys_ has quit IRC | 16:17 | |
*** eezhova has joined #openstack-lbaas | 16:18 | |
*** ducttape_ has quit IRC | 16:19 | |
*** ihrachys has joined #openstack-lbaas | 16:33 | |
*** bana_k has joined #openstack-lbaas | 16:33 | |
*** ihrachys has quit IRC | 16:41 | |
*** bana_k has quit IRC | 16:46 | |
*** ihrachys has joined #openstack-lbaas | 16:48 | |
*** ihrachys_ has joined #openstack-lbaas | 16:50 | |
*** ihrachys_ has quit IRC | 16:53 | |
*** ihrachys has quit IRC | 16:55 | |
*** eezhova has quit IRC | 17:00 | |
*** openstackgerrit has quit IRC | 17:03 | |
*** openstackgerrit has joined #openstack-lbaas | 17:04 | |
*** ducttape_ has joined #openstack-lbaas | 17:15 | |
*** ducttape_ has quit IRC | 17:20 | |
*** bana_k has joined #openstack-lbaas | 17:21 | |
*** rudrajit has joined #openstack-lbaas | 17:46 | |
*** bana_k has quit IRC | 17:50 | |
*** nmagnezi has quit IRC | 17:56 | |
*** minwang2 has joined #openstack-lbaas | 18:04 | |
*** minwang2 has quit IRC | 18:09 | |
*** minwang2 has joined #openstack-lbaas | 18:09 | |
*** minwang2 has quit IRC | 18:09 | |
*** ducttape_ has joined #openstack-lbaas | 18:16 | |
*** ducttape_ has quit IRC | 18:20 | |
*** ducttape_ has joined #openstack-lbaas | 19:17 | |
*** ducttape_ has quit IRC | 19:21 | |
*** numans has joined #openstack-lbaas | 19:34 | |
*** numans has quit IRC | 19:41 | |
*** bana_k has joined #openstack-lbaas | 20:05 | |
*** eezhova has joined #openstack-lbaas | 20:16 | |
*** ducttape_ has joined #openstack-lbaas | 20:17 | |
*** ducttape_ has quit IRC | 20:22 | |
*** bana_k has quit IRC | 20:35 | |
*** bana_k has joined #openstack-lbaas | 20:38 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes Octavia handling of subnets without DHCP https://review.openstack.org/349215 | 20:41 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes Octavia handling of subnets without DHCP https://review.openstack.org/349215 | 20:41 |
*** ducttape_ has joined #openstack-lbaas | 20:42 | |
*** rudrajit has quit IRC | 20:56 | |
*** bana_k has quit IRC | 20:58 | |
*** ducttape_ has quit IRC | 21:04 | |
*** eezhova has quit IRC | 21:20 | |
*** ducttape_ has joined #openstack-lbaas | 21:23 | |
*** ducttape_ has quit IRC | 21:34 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Allow IPv6 VIPs https://review.openstack.org/339826 | 21:42 |
johnsom | ^^ rebased | 21:42 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Allow IPv6 VIPs https://review.openstack.org/339826 | 21:50 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Fixes failover flow with namespace driver https://review.openstack.org/312270 | 22:29 |
*** ducttape_ has joined #openstack-lbaas | 22:35 | |
*** yamamoto has joined #openstack-lbaas | 22:38 | |
*** ducttape_ has quit IRC | 22:40 | |
johnsom | blogan blogan_ Knock yourself out. I don't have more cycles for a while, so contributions are welcome. Not there is a three patch deep chain here, so not sure where you want to jump in with the routes patch. | 22:42 |
*** sticker has joined #openstack-lbaas | 22:47 | |
*** rudrajit has joined #openstack-lbaas | 22:49 | |
*** fnaval has joined #openstack-lbaas | 23:07 | |
*** chlong has quit IRC | 23:34 | |
*** ducttape_ has joined #openstack-lbaas | 23:36 | |
*** ducttape_ has quit IRC | 23:41 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!