Friday, 2016-09-09

rm_workgerrit isn't letting me save comments T_T00:03
rm_workthere we go, just took 5 minutes T_T00:09
*** SumitNaiksatam has quit IRC00:12
*** BjoernT has quit IRC00:16
openstackgerritMerged openstack/octavia: Fix active-active specs tox test
openstackgerritMerged openstack/octavia: Update tox 'docs' environment to test specs
*** djbass has quit IRC00:45
*** gongysh has quit IRC00:45
openstackgerritStephen Balukoff proposed openstack/octavia: DO NOT MERGE: Testing docs gate
sbalukoffWell... that's annoying. johnsom or dougwig: It looks like this is passing the docs test in the gate where it shouldn't be:
sbalukoffDoes the docs gate job not run the 'tox -e docs' environment?00:59
johnsomUgh, yeah, I forgot about that00:59
johnsomIt doesn't00:59
sbalukoffI guess I could move the specs test into the pep8 environment.00:59
johnsomThis is why we had to change the flows generator.  The docs gate just runs sphinx00:59
sbalukoffShould we revert that patch? Or should I author a new one real quick?00:59
sbalukoffWhere are we running the flows generator?01:00
johnsomUmm, you can look at that patch, it merged just a few weeks ago.01:00
johnsomJust create a new one on master.01:01
johnsomRunning to dinner now01:01
rm_workyeah ping me when it's up, i can review tonight sbalukoff01:05
sbalukoffAah-- I see you did that by making sphinx build it.01:05
rm_workpersonally i think it's dumb that the gate doesn't just run tox01:05
sbalukoffI'm thinking this is probably better suited to run in the pep8 environment, assuming that one actuall runs tox. :P01:06
sbalukoffSince this test doesn't actually generate docs.01:06
rm_workit does01:06
sbalukoffGive me two shakes of a lamb's tail to do this...01:06
rm_workyeah probably for the best T_T01:06
rm_workwill requirements matter?01:06
rm_workdo we have a docs-requirements.txt? i forget01:07
rm_workprolly file01:07
sbalukoffI'll check it locally before I commit.01:08
sbalukoffLooks like 'tox -epep8' pulls in the doc-requirements.txt in any case, so this shouldn't be a problem.01:10
*** gongysh has joined #openstack-lbaas01:11
openstackgerritStephen Balukoff proposed openstack/octavia: Add tox 'specs' test to pep8 environment
sbalukoffI'mma update that DO NOT MERGE patch to rebase off this one ^^.01:13
openstackgerritStephen Balukoff proposed openstack/octavia: DO NOT MERGE: Testing docs gate
sbalukoffWoot! My test job failed just like it was supposed to.01:21
sbalukoffrm_work and johnsom: This should be ready for your review:
*** bana_k has quit IRC01:23
*** kevo has quit IRC01:30
*** gongysh has quit IRC01:41
*** kevo has joined #openstack-lbaas01:55
*** kevo has quit IRC01:56
*** gongysh has joined #openstack-lbaas02:01
openstackgerritMerged openstack/octavia: Update readme file
*** chlong has joined #openstack-lbaas02:26
*** amotoki has quit IRC02:49
*** armax has quit IRC03:24
openstackgerritli,chen proposed openstack/octavia: Add class 'StatsMixin'
*** amotoki has joined #openstack-lbaas03:49
*** amotoki has quit IRC04:16
*** woodster_ has quit IRC04:19
*** rm_work has quit IRC04:31
*** rm_work has joined #openstack-lbaas04:34
*** rm_work has quit IRC04:36
*** rm_work has joined #openstack-lbaas04:38
*** gcheresh has joined #openstack-lbaas05:24
*** chlong_ has joined #openstack-lbaas05:31
openstackgerritStephen Balukoff proposed openstack/octavia: Adding introduction and developer quick start docs
*** amotoki has joined #openstack-lbaas05:43
openstackgerritStephen Balukoff proposed openstack/octavia: Add L7 user guides
*** amotoki has quit IRC06:19
*** RichB has joined #openstack-lbaas06:21
*** pcaruana has joined #openstack-lbaas06:23
*** amotoki has joined #openstack-lbaas06:28
openstackgerritStephen Balukoff proposed openstack/octavia: Fixed inconsitent Loadbalancer provisioning_status
*** duvarenkov has joined #openstack-lbaas06:43
openstackgerritStephen Balukoff proposed openstack/octavia: Fixed inconsitent Loadbalancer provisioning_status
*** bana_k has joined #openstack-lbaas06:47
*** amotoki has quit IRC06:48
*** amotoki has joined #openstack-lbaas06:52
openstackgerritMerged openstack/octavia: Fix No sql_connection parameter is established
*** amotoki has quit IRC07:02
*** tesseract- has joined #openstack-lbaas07:07
openstackgerritStephen Balukoff proposed openstack/neutron-lbaas: Fix  string interpolation LOG formatted
*** jsheeren has joined #openstack-lbaas07:10
*** amotoki has joined #openstack-lbaas07:14
*** chlong has quit IRC07:19
*** chlong_ has quit IRC07:19
*** ihrachys has joined #openstack-lbaas07:20
*** bana_k has quit IRC07:40
openstackgerritStephen Balukoff proposed openstack/neutron-lbaas: DO NOT MERGE: gate test
*** cgross has quit IRC08:09
*** lmiccini_ has joined #openstack-lbaas08:09
*** lmiccini has quit IRC08:10
*** cgross has joined #openstack-lbaas08:12
sbalukoffneutron-lbaas gate appears to be unhappy.08:19
sbalukoffAah well. Time for bed, I guess!08:19
*** lmiccini_ is now known as lmiccini08:23
*** amotoki has quit IRC09:04
*** kbyrne has quit IRC09:04
*** kbyrne has joined #openstack-lbaas09:10
*** Alex_Stef has joined #openstack-lbaas09:33
ihrachysreported the bug for gate failure
openstackLaunchpad bug 1621810 in neutron "neutron-lbaas quota unit tests broken" [Critical,Confirmed]09:50
*** gcheresh has quit IRC10:01
*** Alex_Stef has quit IRC11:23
*** gongysh has quit IRC12:00
*** Frito has joined #openstack-lbaas12:13
*** RichB_ has joined #openstack-lbaas12:21
nagyzso nobody has seen this annoying bug yet with the netmask? :)12:24
*** RichB has quit IRC12:24
*** gcheresh has joined #openstack-lbaas12:50
*** woodster_ has joined #openstack-lbaas13:05
*** gongysh has joined #openstack-lbaas13:11
*** matt-borland has joined #openstack-lbaas13:15
*** BjoernT has joined #openstack-lbaas13:28
*** BjoernT is now known as Bjoern_zZzZzZzZ13:28
*** Bjoern_zZzZzZzZ is now known as BjoernT13:41
*** AlexeyAbashkin has joined #openstack-lbaas13:56
*** ddaskal has joined #openstack-lbaas14:00
*** Ibnout has joined #openstack-lbaas14:01
*** ddaskal has quit IRC14:04
*** pglass has joined #openstack-lbaas14:32
*** ddaskal has joined #openstack-lbaas14:38
*** ducttape_ has joined #openstack-lbaas14:41
openstackgerritPaul Glass proposed openstack/octavia: Stop using bandit-baseline
*** armax has joined #openstack-lbaas15:02
*** pcaruana has quit IRC15:08
*** ihrachys has quit IRC15:08
*** gongysh has quit IRC15:13
*** jsheeren has quit IRC15:26
*** amotoki has joined #openstack-lbaas15:27
*** Ibnout has quit IRC15:27
*** Ibnout has joined #openstack-lbaas15:28
johnsomnagyz Still there?15:29
*** gongysh has joined #openstack-lbaas15:30
johnsomnagyz What version of Octavia are you on?   There was a bug that was fixed in master this round.15:31
openstackLaunchpad bug 1585804 in octavia "Octavia cannot handle VIP networks larger than /24" [High,Fix released] - Assigned to Michael Johnson (johnsom)15:31
johnsomCurrent master should be good with respect to variable size netmasks15:31
johnsomIf not, open a bug so we can look into it.15:32
*** openstackgerrit has quit IRC15:49
*** tesseract- has quit IRC15:49
*** openstackgerrit has joined #openstack-lbaas15:50
*** amotoki_ has joined #openstack-lbaas16:02
*** gongysh has quit IRC16:03
*** amotoki_ has quit IRC16:03
*** amotoki has quit IRC16:05
*** lmiccini has quit IRC16:21
*** cgross has quit IRC16:22
*** bana_k has joined #openstack-lbaas16:25
*** cgross has joined #openstack-lbaas16:44
*** lmiccini has joined #openstack-lbaas16:47
*** markd_ has quit IRC16:53
openstackgerritLubosz Kosnik (diltram) proposed openstack/octavia: Backend Keystone authentication
openstackgerritLubosz Kosnik (diltram) proposed openstack/octavia: Octavia API v2 with N-LBaaS compatible endpoints
*** Frito has quit IRC17:02
*** markd_ has joined #openstack-lbaas17:05
openstackgerritLubosz Kosnik (diltram) proposed openstack/octavia: Add keystone authentication of token
*** bana_k has quit IRC17:08
*** matt-borland has quit IRC17:10
*** kevo has joined #openstack-lbaas17:16
johnsomsbalukoff When you have a second let's talk about the glance tags patch17:17
*** ddaskal has quit IRC17:20
*** bana_k has joined #openstack-lbaas17:22
sbalukoffjohnsom: Ok!17:29
johnsomHey, so I had a test for that, but then I realized it's a bit of a pointless test.17:29
johnsomglance is doing the filtering, so in our unit tests we have to mock out glance, so it's kind of like a test with mocked out glance returning nothing.17:30
johnsomThough I'm open to ideas if you see a better way17:30
*** Frito has joined #openstack-lbaas17:31
*** fnaval has joined #openstack-lbaas17:31
sbalukoffRight, so it essentially wouldn't be testing any of our own logic, eh.17:31
sbalukoffSo that'd be another one that'd be useful for a scenario test.17:31
johnsomThat is my take, but open to suggestions17:31
johnsomYep, agreed on that.  Scenario would be really good here17:31
sbalukoffI just worry this code isn't being run through the paces by anything automated. It's important enough that I'd almost like to see it enabled by default (though I understand that would actually be a bad idea to push through this late in the cycle, as it could potentially break people). Maybe we can update our devstack install to make use of it?17:35
johnsomYeah, we can do that.17:36
johnsomIt's actually pretty hard to trigger this based on my testing.17:36
johnsomYou have to allow users to upload public images and even then we seem to still pick the correct one (probably based on image order)17:37
johnsomLet me look at setting up devstack to use it17:38
sbalukoffYeah, it's kind of an obscure case. I think the bug report is valid, though-- it would be disasterous if someone were to run into this problem in the wild (because we'd be sending a whole lot of privileged information, like SSL keys to some random tenant's image)...17:38
*** fnaval has quit IRC17:43
sbalukoffI think sometime in the Ocata cycle we should make the amp_image_owner_id a required setting, to prevent hapless operators from shooting themselves in the foot with a lurking security vulnerability that might otherwise be hard to detect.17:44
johnsomYeah, that is a tough one.  I put it in the release notes as a security issue.  We could do it now if you feel strongly about it.17:46
johnsomrm_work This is the strange cache issue I am seeing now with the amphora-agent:
openstackLaunchpad bug 1621952 in octavia "devstack amphora-agent caching is failing" [Medium,New]17:47
sbalukoffjohnsom: I torn on that-- it really does depend on regular tenants being able to upload public images (which is probably a security vulnerability in and of itself), and even then by default we're probably doing the right thing... (until an operator uploads a new image that will end up being newer than some tenant's "amphora" tagged image)17:49
sbalukoffSo, I dunno. We'd be protecting operators who have made bad decisions already, and potentially breaking operators who haven't.17:50
sbalukoffI almost feel like it's above my pay-grade to decide whether this security issue is important enough for a last-minute merge of a required new config parameter, or even whether it's important enough to back-port this to previous releases.17:52
sbalukoffI'm also torn because our HACKING.rst has that "security is not an afterthough" design goal.17:55
sbalukoffAnd yes, I know that's ironic, given that our API doesn't even have authentication yet.17:55
johnsomThough diltram has made huge progress on fixing that recently17:56
sbalukoffYep! I'm excited to kick the tires of the new code there.17:56
*** eezhova has quit IRC17:58
sbalukoffSo I guess, unless someone above me says otherwise, I'd go with 1. make devstack start using this new parameter, but leave it optional in the code. 2. Early in the Ocata cycle, make it a required parameter (with corresponding release note).17:58
sbalukoffOr... unless y'all convince me it would be a good idea to make it a required parameter now.17:59
sbalukoff(Or enough of you are of that opinion. I don't think it would take much to convince me.)17:59
johnsomI lean towards easing folks into it, thus I decided to make it optional in the patch18:00
* sbalukoff nods18:00
*** fnaval has joined #openstack-lbaas18:05
*** Frito has quit IRC18:09
*** Frito has joined #openstack-lbaas18:09
openstackgerritStephen Balukoff proposed openstack/octavia: Add tox 'specs' test to pep8 environment
sbalukoffThis is just a rebase to resolve the conflict with the bandit patch (that should now be merging) ^^^18:14
openstackgerritMerged openstack/octavia: Updated from global requirements
sbalukoffSo, I see the bug opened for the neutron-lbaas gate being broken has been assigned to venkatamaheshkotha. Does anyone know who that is or if they're actually working on it?18:23
johnsomI don't and was wondering the same.18:23
sbalukoffI guess I should be asking in the neutron channel...18:23
johnsomInteresting that the global reqs merged though18:24
rm_workvenkat? i've seen him around18:24
rm_workthat was octavia18:24
sbalukoffOh, is that who that is?18:24
rm_workpretty sure18:24
johnsomYeah, right, sorry, still thinking we run the n-lbaas gates, but yeah, we don't run those unit tests18:24
sbalukoffHmmm... he's not in #openstack-neutron18:25
sbalukoffOr #openstack-infra18:26
rm_workhonestly, first to fix for a gate-breakage18:31
rm_workdon't care who has the ticket18:31
rm_worki *often* see two or three patches go up at once18:31
johnsomIt's a nice courtesy to ping the person, but if they aren't online...18:32
*** Ibnout has quit IRC18:34
*** Ibnout has joined #openstack-lbaas18:35
*** BjoernT has quit IRC18:36
*** ddaskal has joined #openstack-lbaas18:38
openstackgerritMerged openstack/octavia: Stop using bandit-baseline
*** eezhova has joined #openstack-lbaas18:59
*** gcheresh has quit IRC19:02
*** cgross has quit IRC19:22
*** lmiccini has quit IRC19:22
diltramjohnsom: when we're cutting Netwon code base?19:23
johnsomdiltram We are in feature freeze.  I expect we will cut the last week in September19:32
openstackgerritLubosz Kosnik (diltram) proposed openstack/octavia: Octavia API v2 with N-LBaaS compatible endpoints
diltramjohnsom: ok, thx19:32
diltramso I'm thinking about starting to work on policy.json on start working on API19:33
*** BjoernT has joined #openstack-lbaas19:43
*** ddaskal has quit IRC19:55
*** ducttape_ has quit IRC20:03
openstackgerritStephen Balukoff proposed openstack/neutron-lbaas: Update quota tests to register quota resources
sbalukoffThis should fix the neutron-lbaas gate ^^^20:05
*** gcheresh has joined #openstack-lbaas20:09
sbalukoff(BBIAB-- I need to go AFK for about an hour)20:10
sbalukoffAaw, dammit! My patch didn't fix it on the gate (though it did fix things locally). WTF, eh.20:19
*** eezhova has quit IRC20:22
*** lmiccini has joined #openstack-lbaas20:39
*** gcheresh has quit IRC20:39
*** cgross has joined #openstack-lbaas20:40
*** Frito has quit IRC20:49
openstackgerritStephen Balukoff proposed openstack/neutron-lbaas: Update quota tests to register quota resources
sbalukoffAuto-unregistering those quotas for tests is stupid, IMO. :P20:55
sbalukoffLet's see if the above patch fixes things.20:56
sbalukoffYay! It does! But... I think I can do this a little more DRY...21:11
openstackgerritStephen Balukoff proposed openstack/neutron-lbaas: Update quota tests to register quota resources
johnsomsbalukoff Thanks for jumping on that!21:16
sbalukoffNo problem, eh!21:17
sbalukoffOk, and now I have to get ready for a friend's wedding. Have a good weekend, y'all!21:17
*** pglass has quit IRC22:02
*** reedip has quit IRC22:38
*** reedip has joined #openstack-lbaas22:51
johnsomrm_work Are you still around to review the gate fix?
johnsomdougwig Around to do a review on Stephen's gate fix?
johnsomUgh, Friday.... grin23:00
dougwigjohnsom: aye23:00
johnsomCoo, thanks23:00
dougwigjohnsom: doesn't the neutron base class do that automatically if the config files are setup properly?23:02
rm_workyeah i'm here, but23:02
rm_workI'm not sure i understand what this is doing immediately23:02
johnsomI have no idea frankly23:02
rm_workthough, if it solves the problem...23:03
rm_workwhich it appears to23:03
johnsomSo you are saying this should be doing a fixture override instead of registering them this way in the tests?23:03
dougwignothing else is registering this way.  are the quota config files setup properly in the test?23:03
rm_worklol this is weird:
johnsomThis is kind of setup that way:
johnsomrm_work I have seen that on other patch sets too23:05
rm_workintermittent ???23:05
rm_workpermission issues?!23:05
rm_workthat's insanity23:05
*** armax has quit IRC23:20
*** BjoernT has quit IRC23:30
*** bana_k has quit IRC23:43
*** armax has joined #openstack-lbaas23:44
*** kevo has quit IRC23:49

Generated by 2.14.0 by Marius Gedminas - find it at!