| rm_work | gerrit isn't letting me save comments T_T | 00:03 |
|---|---|---|
| rm_work | there we go, just took 5 minutes T_T | 00:09 |
| *** SumitNaiksatam has quit IRC | 00:12 | |
| *** BjoernT has quit IRC | 00:16 | |
| openstackgerrit | Merged openstack/octavia: Fix active-active specs tox test https://review.openstack.org/367611 | 00:31 |
| openstackgerrit | Merged openstack/octavia: Update tox 'docs' environment to test specs https://review.openstack.org/367651 | 00:31 |
| *** djbass has quit IRC | 00:45 | |
| *** gongysh has quit IRC | 00:45 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: DO NOT MERGE: Testing docs gate https://review.openstack.org/367707 | 00:52 |
| sbalukoff | Well... that's annoying. johnsom or dougwig: It looks like this is passing the docs test in the gate where it shouldn't be: https://review.openstack.org/#/c/367707/ | 00:58 |
| sbalukoff | Does the docs gate job not run the 'tox -e docs' environment? | 00:59 |
| johnsom | Ugh, yeah, I forgot about that | 00:59 |
| johnsom | It doesn't | 00:59 |
| sbalukoff | I guess I could move the specs test into the pep8 environment. | 00:59 |
| johnsom | This is why we had to change the flows generator. The docs gate just runs sphinx | 00:59 |
| sbalukoff | Should we revert that patch? Or should I author a new one real quick? | 00:59 |
| sbalukoff | Aah! | 01:00 |
| sbalukoff | Where are we running the flows generator? | 01:00 |
| johnsom | Umm, you can look at that patch, it merged just a few weeks ago. | 01:00 |
| sbalukoff | Ok. | 01:01 |
| johnsom | Just create a new one on master. | 01:01 |
| johnsom | Running to dinner now | 01:01 |
| rm_work | yeah ping me when it's up, i can review tonight sbalukoff | 01:05 |
| sbalukoff | Aah-- I see you did that by making sphinx build it. | 01:05 |
| rm_work | personally i think it's dumb that the gate doesn't just run tox | 01:05 |
| sbalukoff | I'm thinking this is probably better suited to run in the pep8 environment, assuming that one actuall runs tox. :P | 01:06 |
| rm_work | lol | 01:06 |
| sbalukoff | Since this test doesn't actually generate docs. | 01:06 |
| rm_work | it does | 01:06 |
| sbalukoff | Ok. | 01:06 |
| sbalukoff | Give me two shakes of a lamb's tail to do this... | 01:06 |
| rm_work | yeah probably for the best T_T | 01:06 |
| rm_work | will requirements matter? | 01:06 |
| rm_work | do we have a docs-requirements.txt? i forget | 01:07 |
| rm_work | nope | 01:07 |
| rm_work | prolly file | 01:07 |
| rm_work | *fine | 01:07 |
| sbalukoff | I'll check it locally before I commit. | 01:08 |
| sbalukoff | Looks like 'tox -epep8' pulls in the doc-requirements.txt in any case, so this shouldn't be a problem. | 01:10 |
| *** gongysh has joined #openstack-lbaas | 01:11 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Add tox 'specs' test to pep8 environment https://review.openstack.org/367710 | 01:13 |
| sbalukoff | I'mma update that DO NOT MERGE patch to rebase off this one ^^. | 01:13 |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: DO NOT MERGE: Testing docs gate https://review.openstack.org/367707 | 01:14 |
| sbalukoff | Woot! My test job failed just like it was supposed to. | 01:21 |
| sbalukoff | rm_work and johnsom: This should be ready for your review: https://review.openstack.org/#/c/367710/ | 01:21 |
| *** bana_k has quit IRC | 01:23 | |
| *** kevo has quit IRC | 01:30 | |
| *** gongysh has quit IRC | 01:41 | |
| *** kevo has joined #openstack-lbaas | 01:55 | |
| *** kevo has quit IRC | 01:56 | |
| *** gongysh has joined #openstack-lbaas | 02:01 | |
| openstackgerrit | Merged openstack/octavia: Update readme file https://review.openstack.org/353270 | 02:12 |
| *** chlong has joined #openstack-lbaas | 02:26 | |
| *** amotoki has quit IRC | 02:49 | |
| *** armax has quit IRC | 03:24 | |
| openstackgerrit | li,chen proposed openstack/octavia: Add class 'StatsMixin' https://review.openstack.org/355764 | 03:28 |
| *** amotoki has joined #openstack-lbaas | 03:49 | |
| *** amotoki has quit IRC | 04:16 | |
| *** woodster_ has quit IRC | 04:19 | |
| *** rm_work has quit IRC | 04:31 | |
| *** rm_work has joined #openstack-lbaas | 04:34 | |
| *** rm_work has quit IRC | 04:36 | |
| *** rm_work has joined #openstack-lbaas | 04:38 | |
| *** gcheresh has joined #openstack-lbaas | 05:24 | |
| *** chlong_ has joined #openstack-lbaas | 05:31 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Adding introduction and developer quick start docs https://review.openstack.org/232173 | 05:32 |
| *** amotoki has joined #openstack-lbaas | 05:43 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Add L7 user guides https://review.openstack.org/360934 | 05:49 |
| *** amotoki has quit IRC | 06:19 | |
| *** RichB has joined #openstack-lbaas | 06:21 | |
| *** pcaruana has joined #openstack-lbaas | 06:23 | |
| *** amotoki has joined #openstack-lbaas | 06:28 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Fixed inconsitent Loadbalancer provisioning_status https://review.openstack.org/351106 | 06:37 |
| *** duvarenkov has joined #openstack-lbaas | 06:43 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Fixed inconsitent Loadbalancer provisioning_status https://review.openstack.org/351106 | 06:46 |
| *** bana_k has joined #openstack-lbaas | 06:47 | |
| *** amotoki has quit IRC | 06:48 | |
| *** amotoki has joined #openstack-lbaas | 06:52 | |
| openstackgerrit | Merged openstack/octavia: Fix No sql_connection parameter is established https://review.openstack.org/366913 | 06:57 |
| *** amotoki has quit IRC | 07:02 | |
| *** tesseract- has joined #openstack-lbaas | 07:07 | |
| openstackgerrit | Stephen Balukoff proposed openstack/neutron-lbaas: Fix string interpolation LOG formatted https://review.openstack.org/355510 | 07:08 |
| *** jsheeren has joined #openstack-lbaas | 07:10 | |
| *** amotoki has joined #openstack-lbaas | 07:14 | |
| *** chlong has quit IRC | 07:19 | |
| *** chlong_ has quit IRC | 07:19 | |
| *** ihrachys has joined #openstack-lbaas | 07:20 | |
| *** bana_k has quit IRC | 07:40 | |
| openstackgerrit | Stephen Balukoff proposed openstack/neutron-lbaas: DO NOT MERGE: gate test https://review.openstack.org/367792 | 07:42 |
| *** cgross has quit IRC | 08:09 | |
| *** lmiccini_ has joined #openstack-lbaas | 08:09 | |
| *** lmiccini has quit IRC | 08:10 | |
| *** cgross has joined #openstack-lbaas | 08:12 | |
| sbalukoff | neutron-lbaas gate appears to be unhappy. | 08:19 |
| sbalukoff | Aah well. Time for bed, I guess! | 08:19 |
| *** lmiccini_ is now known as lmiccini | 08:23 | |
| *** amotoki has quit IRC | 09:04 | |
| *** kbyrne has quit IRC | 09:04 | |
| *** kbyrne has joined #openstack-lbaas | 09:10 | |
| *** Alex_Stef has joined #openstack-lbaas | 09:33 | |
| ihrachys | reported the bug for gate failure https://bugs.launchpad.net/neutron/+bug/1621810 | 09:50 |
| openstack | Launchpad bug 1621810 in neutron "neutron-lbaas quota unit tests broken" [Critical,Confirmed] | 09:50 |
| *** gcheresh has quit IRC | 10:01 | |
| *** Alex_Stef has quit IRC | 11:23 | |
| *** gongysh has quit IRC | 12:00 | |
| *** Frito has joined #openstack-lbaas | 12:13 | |
| *** RichB_ has joined #openstack-lbaas | 12:21 | |
| nagyz | so nobody has seen this annoying bug yet with the netmask? :) | 12:24 |
| *** RichB has quit IRC | 12:24 | |
| *** gcheresh has joined #openstack-lbaas | 12:50 | |
| *** woodster_ has joined #openstack-lbaas | 13:05 | |
| *** gongysh has joined #openstack-lbaas | 13:11 | |
| *** matt-borland has joined #openstack-lbaas | 13:15 | |
| *** BjoernT has joined #openstack-lbaas | 13:28 | |
| *** BjoernT is now known as Bjoern_zZzZzZzZ | 13:28 | |
| *** Bjoern_zZzZzZzZ is now known as BjoernT | 13:41 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 13:56 | |
| *** ddaskal has joined #openstack-lbaas | 14:00 | |
| *** Ibnout has joined #openstack-lbaas | 14:01 | |
| *** ddaskal has quit IRC | 14:04 | |
| *** pglass has joined #openstack-lbaas | 14:32 | |
| *** ddaskal has joined #openstack-lbaas | 14:38 | |
| *** ducttape_ has joined #openstack-lbaas | 14:41 | |
| openstackgerrit | Paul Glass proposed openstack/octavia: Stop using bandit-baseline https://review.openstack.org/366997 | 14:50 |
| *** armax has joined #openstack-lbaas | 15:02 | |
| *** pcaruana has quit IRC | 15:08 | |
| *** ihrachys has quit IRC | 15:08 | |
| *** gongysh has quit IRC | 15:13 | |
| *** jsheeren has quit IRC | 15:26 | |
| *** amotoki has joined #openstack-lbaas | 15:27 | |
| *** Ibnout has quit IRC | 15:27 | |
| *** Ibnout has joined #openstack-lbaas | 15:28 | |
| johnsom | nagyz Still there? | 15:29 |
| *** gongysh has joined #openstack-lbaas | 15:30 | |
| johnsom | nagyz What version of Octavia are you on? There was a bug https://bugs.launchpad.net/octavia/+bug/1585804 that was fixed in master this round. | 15:31 |
| openstack | Launchpad bug 1585804 in octavia "Octavia cannot handle VIP networks larger than /24" [High,Fix released] - Assigned to Michael Johnson (johnsom) | 15:31 |
| johnsom | Current master should be good with respect to variable size netmasks | 15:31 |
| johnsom | If not, open a bug so we can look into it. | 15:32 |
| *** openstackgerrit has quit IRC | 15:49 | |
| *** tesseract- has quit IRC | 15:49 | |
| *** openstackgerrit has joined #openstack-lbaas | 15:50 | |
| *** amotoki_ has joined #openstack-lbaas | 16:02 | |
| *** gongysh has quit IRC | 16:03 | |
| *** amotoki_ has quit IRC | 16:03 | |
| *** amotoki has quit IRC | 16:05 | |
| *** lmiccini has quit IRC | 16:21 | |
| *** cgross has quit IRC | 16:22 | |
| *** bana_k has joined #openstack-lbaas | 16:25 | |
| *** cgross has joined #openstack-lbaas | 16:44 | |
| *** lmiccini has joined #openstack-lbaas | 16:47 | |
| *** markd_ has quit IRC | 16:53 | |
| openstackgerrit | Lubosz Kosnik (diltram) proposed openstack/octavia: Backend Keystone authentication https://review.openstack.org/364655 | 16:59 |
| openstackgerrit | Lubosz Kosnik (diltram) proposed openstack/octavia: Octavia API v2 with N-LBaaS compatible endpoints https://review.openstack.org/358158 | 16:59 |
| *** Frito has quit IRC | 17:02 | |
| *** markd_ has joined #openstack-lbaas | 17:05 | |
| openstackgerrit | Lubosz Kosnik (diltram) proposed openstack/octavia: Add keystone authentication of token https://review.openstack.org/265065 | 17:06 |
| *** bana_k has quit IRC | 17:08 | |
| *** matt-borland has quit IRC | 17:10 | |
| *** kevo has joined #openstack-lbaas | 17:16 | |
| johnsom | sbalukoff When you have a second let's talk about the glance tags patch | 17:17 |
| *** ddaskal has quit IRC | 17:20 | |
| *** bana_k has joined #openstack-lbaas | 17:22 | |
| sbalukoff | johnsom: Ok! | 17:29 |
| johnsom | Hey, so I had a test for that, but then I realized it's a bit of a pointless test. | 17:29 |
| johnsom | glance is doing the filtering, so in our unit tests we have to mock out glance, so it's kind of like a test with mocked out glance returning nothing. | 17:30 |
| johnsom | Though I'm open to ideas if you see a better way | 17:30 |
| *** Frito has joined #openstack-lbaas | 17:31 | |
| *** fnaval has joined #openstack-lbaas | 17:31 | |
| sbalukoff | Right, so it essentially wouldn't be testing any of our own logic, eh. | 17:31 |
| sbalukoff | So that'd be another one that'd be useful for a scenario test. | 17:31 |
| johnsom | That is my take, but open to suggestions | 17:31 |
| johnsom | Yep, agreed on that. Scenario would be really good here | 17:31 |
| sbalukoff | I just worry this code isn't being run through the paces by anything automated. It's important enough that I'd almost like to see it enabled by default (though I understand that would actually be a bad idea to push through this late in the cycle, as it could potentially break people). Maybe we can update our devstack install to make use of it? | 17:35 |
| johnsom | Yeah, we can do that. | 17:36 |
| johnsom | It's actually pretty hard to trigger this based on my testing. | 17:36 |
| johnsom | You have to allow users to upload public images and even then we seem to still pick the correct one (probably based on image order) | 17:37 |
| johnsom | Let me look at setting up devstack to use it | 17:38 |
| sbalukoff | Yeah, it's kind of an obscure case. I think the bug report is valid, though-- it would be disasterous if someone were to run into this problem in the wild (because we'd be sending a whole lot of privileged information, like SSL keys to some random tenant's image)... | 17:38 |
| sbalukoff | Ok. | 17:39 |
| *** fnaval has quit IRC | 17:43 | |
| sbalukoff | I think sometime in the Ocata cycle we should make the amp_image_owner_id a required setting, to prevent hapless operators from shooting themselves in the foot with a lurking security vulnerability that might otherwise be hard to detect. | 17:44 |
| johnsom | Yeah, that is a tough one. I put it in the release notes as a security issue. We could do it now if you feel strongly about it. | 17:46 |
| johnsom | rm_work This is the strange cache issue I am seeing now with the amphora-agent: https://bugs.launchpad.net/octavia/+bug/1621952 | 17:47 |
| openstack | Launchpad bug 1621952 in octavia "devstack amphora-agent caching is failing" [Medium,New] | 17:47 |
| sbalukoff | johnsom: I torn on that-- it really does depend on regular tenants being able to upload public images (which is probably a security vulnerability in and of itself), and even then by default we're probably doing the right thing... (until an operator uploads a new image that will end up being newer than some tenant's "amphora" tagged image) | 17:49 |
| sbalukoff | So, I dunno. We'd be protecting operators who have made bad decisions already, and potentially breaking operators who haven't. | 17:50 |
| sbalukoff | I almost feel like it's above my pay-grade to decide whether this security issue is important enough for a last-minute merge of a required new config parameter, or even whether it's important enough to back-port this to previous releases. | 17:52 |
| johnsom | Ha | 17:54 |
| sbalukoff | I'm also torn because our HACKING.rst has that "security is not an afterthough" design goal. | 17:55 |
| sbalukoff | And yes, I know that's ironic, given that our API doesn't even have authentication yet. | 17:55 |
| johnsom | +1000 | 17:56 |
| johnsom | Though diltram has made huge progress on fixing that recently | 17:56 |
| sbalukoff | Yep! I'm excited to kick the tires of the new code there. | 17:56 |
| *** eezhova has quit IRC | 17:58 | |
| sbalukoff | So I guess, unless someone above me says otherwise, I'd go with 1. make devstack start using this new parameter, but leave it optional in the code. 2. Early in the Ocata cycle, make it a required parameter (with corresponding release note). | 17:58 |
| sbalukoff | Or... unless y'all convince me it would be a good idea to make it a required parameter now. | 17:59 |
| sbalukoff | (Or enough of you are of that opinion. I don't think it would take much to convince me.) | 17:59 |
| johnsom | I lean towards easing folks into it, thus I decided to make it optional in the patch | 18:00 |
| * sbalukoff nods | 18:00 | |
| *** fnaval has joined #openstack-lbaas | 18:05 | |
| *** Frito has quit IRC | 18:09 | |
| *** Frito has joined #openstack-lbaas | 18:09 | |
| openstackgerrit | Stephen Balukoff proposed openstack/octavia: Add tox 'specs' test to pep8 environment https://review.openstack.org/367710 | 18:13 |
| sbalukoff | This is just a rebase to resolve the conflict with the bandit patch (that should now be merging) ^^^ | 18:14 |
| openstackgerrit | Merged openstack/octavia: Updated from global requirements https://review.openstack.org/368123 | 18:15 |
| sbalukoff | So, I see the bug opened for the neutron-lbaas gate being broken has been assigned to venkatamaheshkotha. Does anyone know who that is or if they're actually working on it? | 18:23 |
| johnsom | I don't and was wondering the same. | 18:23 |
| sbalukoff | I guess I should be asking in the neutron channel... | 18:23 |
| johnsom | Interesting that the global reqs merged though | 18:24 |
| rm_work | venkat? i've seen him around | 18:24 |
| rm_work | that was octavia | 18:24 |
| sbalukoff | Oh, is that who that is? | 18:24 |
| rm_work | pretty sure | 18:24 |
| johnsom | Yeah, right, sorry, still thinking we run the n-lbaas gates, but yeah, we don't run those unit tests | 18:24 |
| sbalukoff | Hmmm... he's not in #openstack-neutron | 18:25 |
| sbalukoff | Or #openstack-infra | 18:26 |
| rm_work | honestly, first to fix for a gate-breakage | 18:31 |
| rm_work | don't care who has the ticket | 18:31 |
| rm_work | i *often* see two or three patches go up at once | 18:31 |
| johnsom | It's a nice courtesy to ping the person, but if they aren't online... | 18:32 |
| *** Ibnout has quit IRC | 18:34 | |
| *** Ibnout has joined #openstack-lbaas | 18:35 | |
| *** BjoernT has quit IRC | 18:36 | |
| *** ddaskal has joined #openstack-lbaas | 18:38 | |
| openstackgerrit | Merged openstack/octavia: Stop using bandit-baseline https://review.openstack.org/366997 | 18:44 |
| *** eezhova has joined #openstack-lbaas | 18:59 | |
| *** gcheresh has quit IRC | 19:02 | |
| *** cgross has quit IRC | 19:22 | |
| *** lmiccini has quit IRC | 19:22 | |
| diltram | johnsom: when we're cutting Netwon code base? | 19:23 |
| johnsom | diltram We are in feature freeze. I expect we will cut the last week in September | 19:32 |
| openstackgerrit | Lubosz Kosnik (diltram) proposed openstack/octavia: Octavia API v2 with N-LBaaS compatible endpoints https://review.openstack.org/358158 | 19:32 |
| diltram | johnsom: ok, thx | 19:32 |
| diltram | so I'm thinking about starting to work on policy.json on start working on API | 19:33 |
| diltram | or* | 19:34 |
| *** BjoernT has joined #openstack-lbaas | 19:43 | |
| *** ddaskal has quit IRC | 19:55 | |
| *** ducttape_ has quit IRC | 20:03 | |
| openstackgerrit | Stephen Balukoff proposed openstack/neutron-lbaas: Update quota tests to register quota resources https://review.openstack.org/368217 | 20:05 |
| sbalukoff | This should fix the neutron-lbaas gate ^^^ | 20:05 |
| *** gcheresh has joined #openstack-lbaas | 20:09 | |
| sbalukoff | (BBIAB-- I need to go AFK for about an hour) | 20:10 |
| sbalukoff | Aaw, dammit! My patch didn't fix it on the gate (though it did fix things locally). WTF, eh. | 20:19 |
| *** eezhova has quit IRC | 20:22 | |
| *** lmiccini has joined #openstack-lbaas | 20:39 | |
| *** gcheresh has quit IRC | 20:39 | |
| rm_work | :( | 20:39 |
| *** cgross has joined #openstack-lbaas | 20:40 | |
| *** Frito has quit IRC | 20:49 | |
| openstackgerrit | Stephen Balukoff proposed openstack/neutron-lbaas: Update quota tests to register quota resources https://review.openstack.org/368217 | 20:55 |
| sbalukoff | Auto-unregistering those quotas for tests is stupid, IMO. :P | 20:55 |
| sbalukoff | Let's see if the above patch fixes things. | 20:56 |
| sbalukoff | Yay! It does! But... I think I can do this a little more DRY... | 21:11 |
| openstackgerrit | Stephen Balukoff proposed openstack/neutron-lbaas: Update quota tests to register quota resources https://review.openstack.org/368217 | 21:15 |
| johnsom | sbalukoff Thanks for jumping on that! | 21:16 |
| sbalukoff | No problem, eh! | 21:17 |
| sbalukoff | Ok, and now I have to get ready for a friend's wedding. Have a good weekend, y'all! | 21:17 |
| johnsom | Enjoy! | 21:17 |
| *** pglass has quit IRC | 22:02 | |
| *** reedip has quit IRC | 22:38 | |
| *** reedip has joined #openstack-lbaas | 22:51 | |
| johnsom | rm_work Are you still around to review the gate fix? https://review.openstack.org/#/c/368217 | 22:57 |
| johnsom | dougwig Around to do a review on Stephen's gate fix? https://review.openstack.org/#/c/368217 | 23:00 |
| johnsom | Ugh, Friday.... grin | 23:00 |
| dougwig | johnsom: aye | 23:00 |
| johnsom | Coo, thanks | 23:00 |
| dougwig | johnsom: doesn't the neutron base class do that automatically if the config files are setup properly? | 23:02 |
| rm_work | yeah i'm here, but | 23:02 |
| rm_work | I'm not sure i understand what this is doing immediately | 23:02 |
| johnsom | I have no idea frankly | 23:02 |
| rm_work | though, if it solves the problem... | 23:03 |
| rm_work | which it appears to | 23:03 |
| johnsom | So you are saying this should be doing a fixture override instead of registering them this way in the tests? | 23:03 |
| dougwig | nothing else is registering this way. are the quota config files setup properly in the test? | 23:03 |
| rm_work | lol this is weird: http://logs.openstack.org/17/368217/3/check/gate-neutron-lbaas-dsvm-functional-nv/c68bc09/console.html#_2016-09-09_21_24_33_910940 | 23:04 |
| johnsom | This is kind of setup that way: https://review.openstack.org/#/c/354011/3/neutron/tests/unit/quota/test_resource_registry.py | 23:04 |
| johnsom | rm_work I have seen that on other patch sets too | 23:05 |
| rm_work | intermittent ??? | 23:05 |
| rm_work | permission issues?! | 23:05 |
| rm_work | that's insanity | 23:05 |
| *** armax has quit IRC | 23:20 | |
| *** BjoernT has quit IRC | 23:30 | |
| *** bana_k has quit IRC | 23:43 | |
| *** armax has joined #openstack-lbaas | 23:44 | |
| *** kevo has quit IRC | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!