*** ducttape_ has quit IRC | 00:07 | |
openstackgerrit | Merged openstack/octavia master: Adds devstack plugin support for all amp base OS https://review.openstack.org/431576 | 00:29 |
---|---|---|
*** ducttape_ has joined #openstack-lbaas | 00:29 | |
*** gongysh has joined #openstack-lbaas | 00:45 | |
rm_work | xgerman: ok got my devstack to spin properly finally | 00:47 |
rm_work | xgerman: not able to repro | 00:47 |
rm_work | xgerman: but i'd love for you to try again, and if you see an issue, snag some logs from things | 00:48 |
rm_work | xgerman: re the network_id patch | 00:48 |
*** gongysh has quit IRC | 00:49 | |
rm_work | now, in default devstack the connectivity isn't there between the mgmt network and the main network | 00:51 |
rm_work | soooo | 00:51 |
rm_work | you can't easily test actual connectivity | 00:51 |
rm_work | but it'll "work" | 00:51 |
*** ducttape_ has quit IRC | 00:52 | |
*** ducttape_ has joined #openstack-lbaas | 00:53 | |
*** catintheroof has joined #openstack-lbaas | 01:04 | |
*** armax has joined #openstack-lbaas | 01:06 | |
*** Swami has quit IRC | 01:06 | |
xgerman | k | 01:13 |
*** ducttape_ has quit IRC | 01:14 | |
*** ducttape_ has joined #openstack-lbaas | 01:34 | |
*** sanfern has quit IRC | 01:36 | |
*** ducttape_ has quit IRC | 01:51 | |
*** ducttape_ has joined #openstack-lbaas | 01:52 | |
*** ducttape_ has quit IRC | 02:01 | |
*** catintheroof has quit IRC | 02:01 | |
*** ducttape_ has joined #openstack-lbaas | 02:02 | |
rm_work | johnsom: left some comments on https://review.openstack.org/#/c/433392/10 | 02:08 |
rm_work | and apparently german is waiting for you on https://review.openstack.org/#/c/437200/ | 02:09 |
rm_work | also if you get a chance to test https://review.openstack.org/#/c/429926/ we can either merge that and then get updates into the API patch, or wait to merge that until the API patch and then I can update it to include the v2 api changes | 02:09 |
rm_work | either way | 02:09 |
xgerman | had to do some accounting tonight… so will test your patch tomorrow first thing | 02:34 |
rm_work | no worries | 02:41 |
rm_work | these aren't urgent, but i would like to try to get some stuff moving | 02:42 |
rm_work | the less outstanding patches the better IMO | 02:42 |
*** ducttape_ has quit IRC | 02:46 | |
*** ducttape_ has joined #openstack-lbaas | 02:47 | |
*** ducnc has quit IRC | 02:50 | |
*** sanfern has joined #openstack-lbaas | 02:50 | |
*** ducttape_ has quit IRC | 02:52 | |
*** cody-somerville has quit IRC | 03:03 | |
*** gongysh has joined #openstack-lbaas | 03:04 | |
*** dave-mccowan has joined #openstack-lbaas | 03:06 | |
*** links has joined #openstack-lbaas | 03:08 | |
*** gongysh has quit IRC | 03:16 | |
*** cody-somerville has joined #openstack-lbaas | 03:20 | |
*** cody-somerville has quit IRC | 03:20 | |
*** cody-somerville has joined #openstack-lbaas | 03:20 | |
*** cody-somerville has quit IRC | 03:34 | |
*** fnaval has joined #openstack-lbaas | 03:38 | |
*** reedip has quit IRC | 03:41 | |
*** cody-somerville has joined #openstack-lbaas | 03:49 | |
*** cody-somerville has quit IRC | 03:49 | |
*** cody-somerville has joined #openstack-lbaas | 03:49 | |
*** rcernin has quit IRC | 03:50 | |
*** dave-mccowan has quit IRC | 04:16 | |
*** cody-somerville has quit IRC | 04:21 | |
*** cody-somerville has joined #openstack-lbaas | 04:23 | |
*** cody-somerville has quit IRC | 04:23 | |
*** cody-somerville has joined #openstack-lbaas | 04:23 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/439327 | 05:01 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements https://review.openstack.org/440075 | 05:01 |
*** ShaneDavidson has quit IRC | 05:02 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements https://review.openstack.org/440078 | 05:03 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/439327 | 05:16 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements https://review.openstack.org/440078 | 05:18 |
openstackgerrit | Ankur proposed openstack/octavia master: Introduce TESTING.rst for quick developer reference https://review.openstack.org/403938 | 05:23 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/439327 | 05:31 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements https://review.openstack.org/440078 | 05:33 |
*** armax has quit IRC | 06:14 | |
*** fnaval has quit IRC | 06:15 | |
*** ShaneDavidson has joined #openstack-lbaas | 06:46 | |
*** kobis has joined #openstack-lbaas | 07:00 | |
*** csomerville has joined #openstack-lbaas | 07:08 | |
*** cody-somerville has quit IRC | 07:12 | |
*** rcernin has joined #openstack-lbaas | 07:18 | |
*** kobis has quit IRC | 07:18 | |
*** Alex_Staf has joined #openstack-lbaas | 07:18 | |
*** tesseract has joined #openstack-lbaas | 07:18 | |
*** andrew_ has joined #openstack-lbaas | 07:21 | |
*** ShaneDavidson has quit IRC | 07:21 | |
*** andrew has joined #openstack-lbaas | 07:22 | |
andrew | To associate FIP to L4's vip , Do I have to use L3 agent (or Network Node)? | 07:23 |
*** gcheresh_ has joined #openstack-lbaas | 07:24 | |
andrew | For the provider network, is there's any way to do that? | 07:24 |
*** andrew_ has quit IRC | 07:24 | |
*** andrew has quit IRC | 07:32 | |
*** yamamoto has quit IRC | 07:38 | |
*** gongysh has joined #openstack-lbaas | 07:41 | |
*** Alex_Staf has quit IRC | 07:42 | |
*** gcheresh_ has quit IRC | 07:45 | |
*** gcheresh has joined #openstack-lbaas | 07:54 | |
*** jsheeren has joined #openstack-lbaas | 08:10 | |
*** pcaruana has joined #openstack-lbaas | 08:13 | |
*** fnaval has joined #openstack-lbaas | 08:16 | |
*** yamamoto has joined #openstack-lbaas | 08:17 | |
*** yamamoto_ has joined #openstack-lbaas | 08:17 | |
*** yamamoto_ has quit IRC | 08:20 | |
*** krypto has joined #openstack-lbaas | 08:20 | |
*** kobis has joined #openstack-lbaas | 08:20 | |
*** fnaval has quit IRC | 08:21 | |
*** yamamoto has quit IRC | 08:21 | |
*** krypto has quit IRC | 08:25 | |
korean101 | hi guys. | 08:42 |
korean101 | i have dhcp problem. | 08:42 |
korean101 | i already succeed via octavia LB | 08:43 |
korean101 | but sometimes my new instances get a dhcp IP | 08:44 |
korean101 | cloud-init-nonet waiting 120 seconds | 08:44 |
korean101 | and i tcpdump on network namespace | 08:44 |
korean101 | my new VM ARP request to amphora VM | 08:44 |
korean101 | but i have already dhcp instances | 08:45 |
korean101 | instances-->namespace | 08:45 |
*** ducnc has joined #openstack-lbaas | 08:48 | |
*** Alex_Staf has joined #openstack-lbaas | 09:08 | |
*** yamamoto has joined #openstack-lbaas | 09:17 | |
*** yamamoto has quit IRC | 09:22 | |
*** eezhova has joined #openstack-lbaas | 09:24 | |
*** belharar has joined #openstack-lbaas | 09:27 | |
*** jsheeren has quit IRC | 10:01 | |
*** jsheeren has joined #openstack-lbaas | 10:05 | |
*** yamamoto has joined #openstack-lbaas | 10:19 | |
*** yamamoto has quit IRC | 10:22 | |
*** gongysh has quit IRC | 10:27 | |
*** links has quit IRC | 10:31 | |
*** jsheeren has quit IRC | 10:39 | |
*** jsheeren has joined #openstack-lbaas | 10:39 | |
*** eezhova has quit IRC | 10:42 | |
*** sanfern has quit IRC | 10:44 | |
*** ducnc has quit IRC | 10:47 | |
*** links has joined #openstack-lbaas | 10:47 | |
*** yamamoto has joined #openstack-lbaas | 10:53 | |
*** yamamoto has quit IRC | 10:53 | |
*** sanfern has joined #openstack-lbaas | 10:54 | |
*** eezhova has joined #openstack-lbaas | 10:54 | |
*** yamamoto has joined #openstack-lbaas | 11:04 | |
*** jsheeren has quit IRC | 11:12 | |
*** jsheeren has joined #openstack-lbaas | 11:13 | |
*** sanfern has quit IRC | 11:15 | |
*** eezhova has quit IRC | 11:17 | |
*** dileepr has quit IRC | 11:19 | |
*** belharar has quit IRC | 11:37 | |
*** links has quit IRC | 11:51 | |
*** yamamoto has quit IRC | 11:58 | |
*** links has joined #openstack-lbaas | 12:04 | |
*** fnaval has joined #openstack-lbaas | 12:18 | |
*** fnaval has quit IRC | 12:22 | |
*** belharar has joined #openstack-lbaas | 12:38 | |
*** belharar has quit IRC | 12:48 | |
*** belharar has joined #openstack-lbaas | 12:56 | |
*** catintheroof has joined #openstack-lbaas | 12:56 | |
*** yamamoto has joined #openstack-lbaas | 12:59 | |
*** sanfern has joined #openstack-lbaas | 13:02 | |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - Initial Cluster Manager https://review.openstack.org/405238 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology: Initial Distributor Noop Driver https://review.openstack.org/313006 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: Active-Active Topology - Distributor open_flow back-end https://review.openstack.org/427858 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology : create distributor network flow https://review.openstack.org/409763 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: Active-Active Topology - register/uregister amphorae tasks https://review.openstack.org/409765 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: Active-Active Topology - Cluster DB Tasks https://review.openstack.org/409764 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: Active-Active Topology - LB create cluster impl https://review.openstack.org/426560 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology OVS-based Distributor Driver https://review.openstack.org/317629 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology OVS-based Distributor Backend https://review.openstack.org/320422 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - Distributor related tasks https://review.openstack.org/406951 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - controller network tasks https://review.openstack.org/323481 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - Distributor image creation https://review.openstack.org/403594 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - network driver related changes https://review.openstack.org/322494 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - distributor certificate tasks https://review.openstack.org/406952 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - distributor creation flow https://review.openstack.org/406953 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - tmp commit not for release https://review.openstack.org/429369 | 13:08 |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE Topology - create shared distributor https://review.openstack.org/406954 | 13:08 |
*** yamamoto has quit IRC | 13:09 | |
*** belharar has quit IRC | 13:11 | |
openstackgerrit | Abed Abu dbai proposed openstack/octavia master: ACTIVE-ACTIVE - tmp commit not for release https://review.openstack.org/429369 | 13:14 |
*** chlong_ has joined #openstack-lbaas | 13:40 | |
*** andrew has joined #openstack-lbaas | 13:40 | |
*** ducttape_ has joined #openstack-lbaas | 13:52 | |
*** eezhova has joined #openstack-lbaas | 13:57 | |
*** ducttape_ has quit IRC | 14:08 | |
*** links has quit IRC | 14:12 | |
*** ducttape_ has joined #openstack-lbaas | 14:57 | |
*** andrew has quit IRC | 14:58 | |
openstackgerrit | Kobi Samoray proposed openstack/octavia master: Devstack plugin: API only mode https://review.openstack.org/438240 | 15:02 |
*** fnaval has joined #openstack-lbaas | 15:12 | |
*** dave-mccowan has joined #openstack-lbaas | 15:26 | |
*** gcheresh has quit IRC | 15:45 | |
*** Alex_Staf has quit IRC | 15:45 | |
*** jsheeren has quit IRC | 15:58 | |
*** rcernin has quit IRC | 15:59 | |
diltram | johnsom: infra is weird | 16:00 |
diltram | or it's just me | 16:00 |
*** chlong_ has quit IRC | 16:01 | |
diltram | a lot of people was fighting for multi-node tests | 16:01 |
diltram | with more than two nodes | 16:01 |
*** chlong__ has joined #openstack-lbaas | 16:01 | |
diltram | and now on ML they told me that it's currently supported and why I'm even asking about is it gonna be supported in zuulv3 | 16:01 |
*** armax has joined #openstack-lbaas | 16:02 | |
johnsom | We have a multinode test gate | 16:02 |
diltram | but two node | 16:03 |
johnsom | I think the term has different meaning to different folks | 16:03 |
diltram | I asked them directly if it's gonna be possible to build 3-4 nodes or more | 16:04 |
diltram | and they told that it's already supported | 16:04 |
diltram | and some projects are using it already | 16:04 |
*** ducttape_ has quit IRC | 16:08 | |
*** ducttape_ has joined #openstack-lbaas | 16:09 | |
openstackgerrit | Kobi Samoray proposed openstack/octavia master: Recurse dictionary generation in model to_dict() https://review.openstack.org/438239 | 16:11 |
diltram | johnsom: what is going one with this patch? https://review.openstack.org/#/c/429825/ | 16:16 |
johnsom | diltram we need to merge those two. That patch just needs rebased and the parent needs fixed | 16:19 |
diltram | ok | 16:20 |
*** csomerville has quit IRC | 16:24 | |
*** csomerville has joined #openstack-lbaas | 16:31 | |
xgerman | o/ | 16:32 |
*** kobis has quit IRC | 16:33 | |
diltram | hey | 16:34 |
*** ducttape_ has quit IRC | 16:39 | |
*** eezhova has quit IRC | 16:39 | |
*** ducttape_ has joined #openstack-lbaas | 16:39 | |
johnsom | Well, the debate is back | 16:42 |
*** pcaruana has quit IRC | 16:42 | |
johnsom | people don't like "load-balancing" but prefer "load-balancer" for the service type. | 16:42 |
ankur-gupta-f1 | woot woot | 16:47 |
*** belharar has joined #openstack-lbaas | 16:48 | |
openstackgerrit | Sindhu Devale proposed openstack/neutron-lbaas master: Updating import for linux/interface opts https://review.openstack.org/352471 | 16:49 |
*** csomerville has quit IRC | 17:04 | |
*** eezhova has joined #openstack-lbaas | 17:07 | |
*** dave-mccowan has quit IRC | 17:13 | |
openstackgerrit | Sindhu Devale proposed openstack/octavia master: DB migration to add ID column to HM https://review.openstack.org/430451 | 17:17 |
*** ducttape_ has quit IRC | 17:45 | |
*** tesseract has quit IRC | 17:52 | |
*** belharar has quit IRC | 17:57 | |
*** SumitNaiksatam has joined #openstack-lbaas | 18:03 | |
*** kevo has joined #openstack-lbaas | 18:09 | |
openstackgerrit | Sindhu Devale proposed openstack/neutron-lbaas master: [Fix gate]Update test requirement https://review.openstack.org/440746 | 18:12 |
openstackgerrit | Sindhu Devale proposed openstack/neutron-lbaas master: Updating import for linux/interface opts https://review.openstack.org/352471 | 18:14 |
*** mugsie has quit IRC | 18:26 | |
*** SumitNaiksatam has quit IRC | 18:39 | |
*** ducttape_ has joined #openstack-lbaas | 18:45 | |
*** ducttape_ has quit IRC | 18:50 | |
*** SumitNaiksatam has joined #openstack-lbaas | 19:11 | |
openstackgerrit | Ankur proposed openstack/octavia master: Add v2 load balancer type and controllers https://review.openstack.org/423543 | 19:13 |
*** armax has quit IRC | 19:20 | |
*** eezhova has quit IRC | 19:24 | |
*** armax has joined #openstack-lbaas | 19:31 | |
openstackgerrit | Shashank Kumar Shankar proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Rules https://review.openstack.org/406336 | 19:31 |
*** kobis has joined #openstack-lbaas | 19:34 | |
*** mugsie has joined #openstack-lbaas | 19:35 | |
xgerman | rm-work: | 19:40 |
openstackgerrit | Ankur proposed openstack/octavia master: Add v2 load balancer type and controllers https://review.openstack.org/423543 | 19:40 |
xgerman | https://www.irccloud.com/pastebin/ZG6zb5vS/ | 19:40 |
xgerman | https://www.irccloud.com/pastebin/K3wdwg0g/ | 19:41 |
xgerman | knowing my luck I might just have some outdated glance image | 19:42 |
xgerman | so manua;;y building a new one… | 19:43 |
*** ipsecguy has joined #openstack-lbaas | 19:45 | |
*** ipsecguy_ has quit IRC | 19:47 | |
*** ShaneDavidson has joined #openstack-lbaas | 19:50 | |
xgerman | ok, that was it, old image | 19:57 |
*** armax has quit IRC | 19:58 | |
rm_work | ah cool | 20:02 |
rm_work | kk | 20:02 |
rm_work | johnsom: who is objecting to the service type? | 20:04 |
rm_work | where] | 20:04 |
johnsom | rm_work https://review.openstack.org/#/c/434999/ | 20:05 |
rm_work | I just hate the hyphen | 20:06 |
johnsom | I just hate that the community can't come to an agreement. | 20:08 |
rm_work | lol | 20:14 |
rm_work | I proposed yet another option | 20:14 |
rm_work | sorry :P | 20:14 |
rm_work | I don't actually like the sound of it better, but if we want to be consistent... <_< | 20:14 |
rm_work | because if we don't call "computing" "computer", we shouldn't call "load-balancing" "load-balancer" | 20:15 |
rm_work | "compute" / "load-balance" | 20:15 |
rm_work | to me they technically look like verb stems | 20:16 |
rm_work | Add "to" in front of them: "to compute" "to network" "to load-balance" | 20:16 |
*** ducttape_ has joined #openstack-lbaas | 20:16 | |
johnsom | I just know it's already set based on the e-mail chain in three places, project config, our code, and docs | 20:20 |
johnsom | We need to pick something and move on | 20:20 |
rm_work | well, we do control all of those | 20:20 |
rm_work | so | 20:20 |
rm_work | it's not a huge deal | 20:20 |
johnsom | It's just rework, plus project config takes a while to get reviewed and merged | 20:21 |
rm_work | yeah, but it isn't blocking anything so | 20:21 |
rm_work | i don't see it as a huge deal | 20:21 |
*** ducttape_ has quit IRC | 20:21 | |
openstackgerrit | Merged openstack/neutron-lbaas master: [Fix gate]Update test requirement https://review.openstack.org/440261 | 20:21 |
johnsom | Technically it is blocking the docs and the openstacksdk work | 20:25 |
johnsom | Maybe OSA as well | 20:25 |
xgerman | indeed I out the hyphen one in OSA | 20:28 |
rm_work | diltram: responded to your comment on https://review.openstack.org/#/c/431179/ | 20:32 |
rm_work | it is impossible to get what you want :( | 20:32 |
diltram | but what git is checking to resolv that it's a new file vs old one? | 20:36 |
diltram | there is requirement that one patch to move file then you can change it? | 20:37 |
diltram | rm_work: ^^ | 20:37 |
diltram | or just cp overrides dates on file and this is why it's showing that it's the new one? | 20:37 |
diltram | yeah, it monitors content not any timestamps | 20:41 |
rm_work | if you figure out a way | 20:41 |
rm_work | feel free to tell me and i'll do it | 20:41 |
diltram | rm_work: http://stackoverflow.com/questions/433111/how-to-make-git-mark-a-deleted-and-a-new-file-as-a-file-move/433114#433114 | 20:42 |
diltram | yeah | 20:42 |
diltram | you should make this in two separete patches | 20:43 |
rm_work | rofl | 20:43 |
rm_work | I vote: no | 20:43 |
rm_work | that's ridiculous, why would I split this up | 20:43 |
rm_work | diltram: if i don't do that, are you going to keep a -1 on it because of a git history quirk? <_< | 20:45 |
rm_work | OK, read your comment | 20:47 |
diltram | :P | 20:48 |
diltram | to keep history you should push two patches | 20:48 |
diltram | but it's just constants :P | 20:48 |
rm_work | yes >_< | 20:48 |
rm_work | all the unit test rewrites i had to do on that patch to fix stuff that was already not testing correctly made me very sad >_< | 20:50 |
rm_work | or, wait... no, that was the one before it i think | 20:50 |
rm_work | oh, nm yeah it was this one | 20:51 |
openstackgerrit | Ankur proposed openstack/octavia master: Add v2 load balancer type and controllers https://review.openstack.org/423543 | 20:56 |
johnsom | Yeah, not sure history on that consts file matters enough. If it was code that people had made a bunch of changes to I would block it, but this file... | 20:56 |
johnsom | Good catch though.... | 20:56 |
diltram | johnsom: same thoughts | 20:57 |
*** eezhova has joined #openstack-lbaas | 20:57 | |
diltram | johnsom: https://review.openstack.org/#/c/437125/ <- looking for review | 21:02 |
diltram | also | 21:02 |
diltram | https://review.openstack.org/#/c/436997/ <- this one also | 21:03 |
xgerman | I doubt if Dustin will ever contribute again: https://review.openstack.org/#/c/391204/ - so should we keep this around or abandon? | 21:04 |
xgerman | and if we keep it around who would adopt ti? | 21:04 |
dlundquist | xgerman: I will not be resuming work on that in the foreseeable future. | 21:05 |
xgerman | yeah. my thought s well | 21:06 |
xgerman | but good to see you ;-) | 21:06 |
xgerman | johnsom? | 21:06 |
openstackgerrit | Ankur proposed openstack/octavia master: Introduce TESTING.rst for quick developer reference https://review.openstack.org/403938 | 21:07 |
johnsom | Hi Dustin. I don't want to lose that patch, but agree we should wrap it in a flag we can use for the gates | 21:16 |
johnsom | Frankly, using v6 for the mgmt net is the right answer | 21:17 |
johnsom | diltram is this a patch you could finish up? | 21:18 |
diltram | I can try to take a look into it | 21:19 |
johnsom | Thanks! | 21:19 |
rm_work | diltram: replied on https://review.openstack.org/#/c/429926/15 | 21:20 |
rm_work | diltram: can you help me out more on the readability thing? | 21:20 |
johnsom | I had just started reviewing that again | 21:20 |
diltram | rm_work: meeting | 21:21 |
rm_work | k np | 21:21 |
diltram | thx ;) | 21:21 |
rm_work | responded on the cascade delete one too | 21:22 |
rm_work | whenever you're out | 21:22 |
rm_work | you seem to be in a cryptic mood today ^_^ | 21:22 |
* xgerman doesn’t like to be contradicted | 21:30 | |
johnsom | Uh-oh... Grin | 21:30 |
johnsom | The reviews are heating up eh? | 21:30 |
johnsom | diltram Yeah, what does this comment mean???? https://review.openstack.org/#/c/437200/ | 21:31 |
xgerman | should we +A: https://review.openstack.org/#/c/437200/ | 21:36 |
johnsom | I would like to give him a chance to comment | 21:36 |
xgerman | k | 21:36 |
xgerman | we can always go Neutron and have rm | 21:37 |
xgerman | _work +A later :-) | 21:37 |
johnsom | Ouch... | 21:37 |
rm_work | lol | 21:40 |
diltram | rm_work: can we divide this into smaller methods? 3 inner if's are horrible to understand and read | 21:41 |
diltram | also question was about _LI not _ | 21:41 |
rm_work | oh | 21:42 |
rm_work | _LI was pre-existing... | 21:42 |
rm_work | not sure? somewhere? wouldn't it complain in pep8 if it was unused | 21:42 |
openstackgerrit | Merged openstack/octavia master: Updated from global requirements https://review.openstack.org/440078 | 21:43 |
diltram | ok, | 21:43 |
diltram | johnsom: how does it work with this _LI and other? Only _LE was not suppose to be used? | 21:44 |
diltram | we had some patches to remove it | 21:44 |
diltram | rm_work: and what is going one with this noqa? | 21:45 |
johnsom | diltram that was switching around exception messages from error messages. exceptions went to _ and error went to _LE | 21:45 |
rm_work | diltram: which noqa | 21:46 |
diltram | johnsom: ok, thx | 21:46 |
diltram | https://review.openstack.org/#/c/429926/15/octavia/tests/functional/api/v1/base.py | 21:46 |
rm_work | OH | 21:46 |
johnsom | https://docs.openstack.org/developer/oslo.i18n/usage.html | 21:46 |
rm_work | because it isn't imported directly | 21:47 |
rm_work | err | 21:47 |
rm_work | isn't used directly | 21:47 |
rm_work | but unless we import it, the conf stuff isn't loaded | 21:47 |
rm_work | so running tests fails | 21:47 |
rm_work | so if you want to run like | 21:47 |
*** ducttape_ has joined #openstack-lbaas | 21:47 | |
rm_work | a specific unit test | 21:47 |
rm_work | you can't, unless the conf stuff is loaded | 21:47 |
rm_work | if you run ALL the tests, something magically happens to load the config stuff | 21:47 |
rm_work | so it works | 21:47 |
rm_work | but doing this allows us to run individual suites | 21:48 |
rm_work | diltram: make sense? | 21:48 |
diltram | but you should use fixture | 21:48 |
diltram | to load conf | 21:48 |
rm_work | i think it's the fixtures that FAIL because the conf isn't even set | 21:48 |
rm_work | IIRC | 21:48 |
rm_work | but i'd have to look again | 21:48 |
rm_work | like, the groups don't even exist | 21:49 |
diltram | ok | 21:49 |
rm_work | fixtures are for overriding stuff, I thought | 21:49 |
diltram | there is a bug in fixture | 21:49 |
diltram | also for using in tests | 21:49 |
rm_work | well, i need to check again to make sure | 21:49 |
diltram | if you're getting error about init smth | 21:49 |
diltram | I know what is about | 21:49 |
rm_work | let me remove that and try running some tests | 21:50 |
diltram | sure | 21:50 |
johnsom | FYI, this is actually a better page explaining the translation tags: https://docs.openstack.org/developer/oslo.i18n/guidelines.html | 21:51 |
*** ducttape_ has quit IRC | 21:52 | |
rm_work | diltram: hilariously, it's already merged | 21:54 |
rm_work | diltram: that's just a duplicate, if i rebased it wouldn't be there | 21:54 |
rm_work | (as a change) | 21:54 |
openstackgerrit | Merged openstack/octavia master: Use cryptsetup/LUKS for encrypted ramfs https://review.openstack.org/403817 | 21:55 |
rm_work | and lol, already there at an even higher level too | 21:55 |
rm_work | so that one actually isn't needed | 21:56 |
rm_work | diltram: https://gist.github.com/rm-you/707417ac9b7405ec68bce55d553089b4 | 21:56 |
diltram | what is merged? | 21:57 |
rm_work | are we using things improperly? | 21:57 |
rm_work | that line: | 21:57 |
diltram | there is problem with oslo_config fixture | 21:57 |
diltram | it's not calling init | 21:57 |
rm_work | i thnik | 21:58 |
rm_work | one sec | 21:58 |
rm_work | https://github.com/openstack/octavia/blob/master/octavia/tests/functional/db/base.py#L20 | 21:58 |
diltram | I don't remember where I was doing this | 22:01 |
diltram | https://bugs.launchpad.net/oslo.config/+bug/1645868 | 22:02 |
openstack | Launchpad bug 1645868 in oslo.config "Fixture is not executing __call__" [Low,Triaged] | 22:02 |
rm_work | ok well. | 22:03 |
rm_work | do you want me to remove it? it doesn't even matter there because the one i linked is higher level | 22:03 |
diltram | yes because it removes usability of fixture | 22:04 |
rm_work | i think fixture still overrides | 22:04 |
diltram | I need to find where we're doing this | 22:04 |
diltram | not really | 22:04 |
rm_work | i mean, it was the fixture stuff causing the error there | 22:05 |
rm_work | because the group doesn't exist | 22:05 |
rm_work | and all of the tests pass? | 22:05 |
diltram | there is a weird stuff going one because of this | 22:05 |
rm_work | so if it is breaking fixture, we have a bigger problem | 22:05 |
rm_work | which is that the tests pass regardless of the config values | 22:05 |
diltram | hahaha | 22:05 |
diltram | no it's not breaking fixture | 22:05 |
diltram | :P | 22:05 |
diltram | it's just not initialized properly | 22:05 |
rm_work | i think the simplest explanation (and how it seems to me) is that fixture still works fine | 22:05 |
*** kevo has quit IRC | 22:06 | |
diltram | and problem is that in tests if you gonna start overriding params it's not gonna work | 22:06 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add network_id to VIP to match neutron-lbaas https://review.openstack.org/429926 | 22:08 |
*** mhayden has left #openstack-lbaas | 22:08 | |
johnsom | I am pretty close to done re-reviewing ^^^ | 22:09 |
*** kobis has quit IRC | 22:09 | |
rm_work | johnsom: it was literally just a noop change | 22:09 |
rm_work | diltram: i think it does work | 22:09 |
johnsom | Yeah, no problem, just commenting | 22:09 |
rm_work | diltram: because we already do use fixture (or else we wouldn't even have run into this issue), and the fixtures seem to work | 22:09 |
rm_work | or else the tests that use them would fail | 22:10 |
rm_work | does that logic seem sound? | 22:10 |
rm_work | or did i miss something | 22:10 |
*** kobis has joined #openstack-lbaas | 22:11 | |
johnsom | Yeah, if that line broke fixtures overall, the stuff would hit the fan in our tests. We use them a bunch to override the conf | 22:12 |
diltram | it's base api so even what in nova they're doing | 22:12 |
diltram | and what I've done in other place | 22:12 |
diltram | place this import | 22:13 |
diltram | but to remove this cripy noqa | 22:13 |
diltram | do not import cfg object but use this one from this import | 22:13 |
diltram | so in line 60 | 22:14 |
diltram | use config.cfg.CONF instead of cfg.CONF | 22:14 |
diltram | because of this you will have all config options properly loaded | 22:14 |
diltram | and there will be no requirement for noqa | 22:14 |
rm_work | ok | 22:18 |
rm_work | ok | 22:20 |
rm_work | done | 22:20 |
rm_work | and also fixing your thing about the constants | 22:20 |
rm_work | by doing it in the patch before :P | 22:20 |
rm_work | i hope you are happy | 22:20 |
rm_work | since it is a two part patch anyway | 22:20 |
diltram | for me awesome :P | 22:20 |
diltram | :) | 22:20 |
rm_work | ok, testing and then i'll push up part`1 | 22:21 |
diltram | thx :) | 22:23 |
johnsom | rm_work That network_id looks ok. Just two exception paths that don't have coverage (all the others do however) | 22:35 |
johnsom | Commented | 22:35 |
*** catintheroof has quit IRC | 22:40 | |
rm_work | ok | 22:45 |
rm_work | working on another patchset for diltram right now | 22:46 |
rm_work | almost done | 22:46 |
rm_work | will resolve his issues (even the git history thing) | 22:46 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add network_id to VIP to match neutron-lbaas https://review.openstack.org/429926 | 22:46 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Allow to create vip in lb-mgmt-net https://review.openstack.org/431179 | 22:46 |
rm_work | ok, will deal with your comments now johnsom | 22:47 |
rm_work | diltram: please take a look and see if you like that better | 22:47 |
openstackgerrit | Sindhu Devale proposed openstack/octavia master: DB migration to add ID column to HM https://review.openstack.org/430451 | 22:53 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add network_id to VIP to match neutron-lbaas https://review.openstack.org/429926 | 22:58 |
rm_work | johnsom: done | 22:58 |
rm_work | johnsom / diltram: should be good to go now | 22:59 |
rm_work | the next one as well | 22:59 |
rm_work | not going to bother rebasing the next one since it's only two additional unit tests that were added in the patch below it | 22:59 |
rm_work | WTB: merging those ^_^ | 22:59 |
diltram | rm_work: looks better :) | 23:00 |
openstackgerrit | Sindhu Devale proposed openstack/octavia master: Introduce Octavia v2 API for Health Monitor https://review.openstack.org/406256 | 23:02 |
*** ducttape_ has joined #openstack-lbaas | 23:04 | |
rm_work | diltram: i am really not sure what to do on https://review.openstack.org/#/c/437200/ | 23:11 |
*** ShaneDavidson_ has joined #openstack-lbaas | 23:11 | |
rm_work | the test is there | 23:11 |
rm_work | it's just that ALL of those tests are shitty | 23:11 |
rm_work | which... is not my fault >_> | 23:11 |
*** eezhova has quit IRC | 23:12 | |
*** ShaneDavidson has quit IRC | 23:15 | |
*** yuanying_ has joined #openstack-lbaas | 23:18 | |
*** oomichi has quit IRC | 23:18 | |
*** yuanying has quit IRC | 23:20 | |
*** ShaneDavidson_ has quit IRC | 23:21 | |
*** oomichi has joined #openstack-lbaas | 23:21 | |
*** ShaneDavidson has joined #openstack-lbaas | 23:22 | |
johnsom | harlowja You were brave enough to use our name on the mailing list..... | 23:24 |
harlowja | forever brave | 23:24 |
harlowja | lol | 23:24 |
johnsom | Help me understand what part of Octavia you are talking about? We don't really use distributed locking today | 23:25 |
harlowja | ya, not distributed locking | 23:25 |
johnsom | I.e. I'm confused | 23:25 |
harlowja | liveness detection of amphora vms for example | 23:25 |
harlowja | and service discovery of the surronding topology | 23:26 |
johnsom | Ah, heartbeat | 23:26 |
harlowja | in part, yes | 23:26 |
harlowja | u could classify heartbeat and detection of the other services as the same | 23:26 |
johnsom | service discovery like how the amp finds a controller? | 23:26 |
harlowja | sure, that'd work | 23:26 |
harlowja | or where to send UDP amphora packets | 23:26 |
johnsom | Hmm | 23:26 |
harlowja | or where nova compute registers itself for the schduler | 23:27 |
harlowja | ya da :) | 23:27 |
johnsom | Yeah, people have argued we should use RR DNS. I hate relying on more services if they really aren't needed. That is my bias a bit. | 23:27 |
harlowja | ya, but typically its a built in thing :-P | 23:27 |
harlowja | and then everyone makes there own sorta same thing | 23:28 |
johnsom | How so? We don't use DNS today, the amps don't need to resolve anything | 23:28 |
harlowja | sorry, not DNS | 23:28 |
harlowja | a thing that provides service discovery primitives | 23:28 |
harlowja | (need not be DNS) | 23:28 |
harlowja | https://technologyconversations.com/2015/09/08/service-discovery-zookeeper-vs-etcd-vs-consul/ (has an overview of a few of them) | 23:29 |
johnsom | Hmm, today, we just drop a config into the amp that has it's endpoints at boot. The heartbeat does triple duty by sending up stats and status | 23:29 |
harlowja | right, static service discovery | 23:29 |
harlowja | (via config file shoved in) | 23:29 |
johnsom | Yeah, we discussed etcd and consul EARLY in the design phase | 23:29 |
johnsom | static == KISS | 23:30 |
diltram | rm_work: there is no test which can be extended? I know those flows are not tested at all using unit tests but maybe extending some functional/api? | 23:30 |
harlowja | johnsom let's assume that the community had said, KISS by using one of etcd|consul|zookeeper | 23:30 |
harlowja | then everyone could share the same tool | 23:30 |
diltram | harlowja: how does it work with multi tenant? | 23:30 |
johnsom | I think we are talking control plane here | 23:31 |
diltram | if we would have service which is per tenant? | 23:31 |
harlowja | ya, control plane (to start) | 23:31 |
diltram | ok | 23:31 |
harlowja | i mean, take what k8s does with this stuff (via etcd) | 23:31 |
johnsom | "to start", ha, taking over the world | 23:31 |
harlowja | ya, the shitty part, is another project, has this primitive, so us not, imho is a handicap | 23:32 |
diltram | so to be more containers ways we should allow for something like etcd to provide endpoints for health data | 23:32 |
harlowja | don't think of it as containers or not | 23:32 |
harlowja | anyways, bb :) | 23:32 |
rm_work | yeah diltram, that is what he has been telling me :P | 23:32 |
johnsom | He is trying to get us to drink the tooz koolaid | 23:32 |
harlowja | nooo | 23:32 |
johnsom | Grin | 23:33 |
harlowja | i'm just trying to blow your mind | 23:33 |
rm_work | because if we spin up more health monitors later, there's no way to add those to the existing amps | 23:33 |
harlowja | biab | 23:33 |
rm_work | since we don't have a way to update agent config AFAIK | 23:33 |
diltram | I know | 23:33 |
johnsom | rm_work Yeah, that was blocked by the workz restart bug | 23:33 |
rm_work | i mean, that is the basis for where this conversation started internally... | 23:33 |
rm_work | right, which is solved | 23:33 |
rm_work | i mentioned that | 23:33 |
rm_work | we COULD add an agent config update call | 23:33 |
rm_work | but i think he's hoping for something even better | 23:34 |
johnsom | Yeah, that is why I started the conversation. | 23:34 |
rm_work | internally people were pushing Consul at me | 23:34 |
johnsom | I think my biggest issue with adding something like etcd (pick whatever project is shiny today) is depending on more outside code. | 23:35 |
johnsom | I want to make sure that some dumb service crashing doesn't take out ALL of the amps. | 23:35 |
rm_work | yeah, that's fair | 23:36 |
johnsom | I.e. distributed and autonomous has it's benefits | 23:36 |
rm_work | i honestly dont know exactly where i am on this argument | 23:36 |
johnsom | To give xgerman credit, he proposed consul "back in the day" | 23:36 |
rm_work | i don't want to just argue against change because it's change though | 23:36 |
rm_work | i'd like to figure out if there's valid reasons to avoid something like that | 23:37 |
johnsom | Though I dind't like what I saw in Consul at the time | 23:37 |
rm_work | well, i have to brb | 23:37 |
rm_work | so i guess we can ALL pick this up in a bit if we want to | 23:37 |
johnsom | Hahaha you guys. | 23:37 |
rm_work | T_T | 23:37 |
diltram | harlowja: just remember | 23:38 |
johnsom | Yeah, I am open to the investigation/discussion, definitely. I'm just voicing my bias up front so you all can poke holes in it. Grin | 23:38 |
diltram | cinder is making the biggest step in this | 23:38 |
diltram | because they're implementing tooz to provide DLM | 23:38 |
diltram | so it suppose to change a lot in openstack world | 23:39 |
diltram | when core project is starting to require those kind of dependencies | 23:39 |
diltram | plus we need to remember that there is tooz | 23:40 |
diltram | but I just heard that problem is that there is small amount of same capabilities in all of this projects like etcd, zookeeper, rest | 23:41 |
diltram | so I heard that tooz is ok for master election, DLM | 23:41 |
diltram | but nothing more specialized | 23:41 |
diltram | but this is to be verified | 23:41 |
johnsom | Well, when they return you will have one of the tooz gurus to discuss with | 23:42 |
diltram | I would like to, but not today | 23:43 |
diltram | it's 6PM | 23:43 |
diltram | I'm leaving now | 23:43 |
johnsom | Ok, have a good evening | 23:43 |
diltram | thx, cu people tomorrow :) | 23:43 |
rm_work | ah, I'm out tomorrow | 23:43 |
rm_work | and probably Monday | 23:43 |
rm_work | so, see you Tuesday :P | 23:43 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/439327 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!