| *** yamamoto has quit IRC | 00:00 | |
| johnsom | Blah, so close. It looks like our Listener data model doesn't handle the sni_containers well | 00:02 |
|---|---|---|
| johnsom | It puts them in as dicts where that method expects objects | 00:03 |
| rm_work | hmm | 00:06 |
| rm_work | johnsom: wut: http://logs.openstack.org/11/492311/25/check/octavia-v2-dsvm-scenario/3bfafab/testr_results.html.gz | 00:08 |
| rm_work | did I just get unlucky and catch some neutron change right today | 00:08 |
| rm_work | T_T | 00:08 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for listeners https://review.openstack.org/492311 | 00:08 |
| rm_work | ooooh no, i actually "fixed" that function | 00:10 |
| rm_work | which breaks it for router-interface I guess | 00:10 |
| johnsom | "fixed" | 00:10 |
| *** Swami has quit IRC | 00:11 | |
| rm_work | yeahhhhhh so, yes, fixed | 00:12 |
| rm_work | https://review.openstack.org/#/c/492311/26/octavia_tempest_plugin/tests/waiters.py | 00:12 |
| rm_work | see that ^^ | 00:12 |
| rm_work | that was totally not right >_> | 00:12 |
| johnsom | UnreadableCert: Could not read X509 from PEM | 00:12 |
| johnsom | Ugh, how did this functional test ever run..... | 00:12 |
| rm_work | but now it actually gets to where it calls show_func on the router | 00:12 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for listeners https://review.openstack.org/492311 | 00:16 |
| rm_work | ah, got it | 00:16 |
| rm_work | bad call to cleanup | 00:16 |
| johnsom | The answer is before it just DB jammed and ran for the hills | 00:16 |
| rm_work | johnsom: lolwut | 00:16 |
| rm_work | i mean yes | 00:17 |
| rm_work | that whole thing is just a dumpster fire | 00:17 |
| rm_work | it needs to be ripped out and rewritten | 00:17 |
| johnsom | https://github.com/openstack/octavia/blob/master/octavia/tests/functional/api/v2/test_load_balancer.py#L2225 | 00:17 |
| rm_work | brb 15m | 00:28 |
| rm_work | hoping the scenarios will finish this time | 00:50 |
| rm_work | and then i'll post one more version that has the pep8 fix | 00:50 |
| *** yamamoto has joined #openstack-lbaas | 00:57 | |
| *** yamamoto has quit IRC | 01:03 | |
| *** bzhao__ has joined #openstack-lbaas | 01:07 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for listeners https://review.openstack.org/492311 | 01:07 |
| rm_work | johnsom: yep, listener tests are ready! pep8 fixed just pushed, but everything else passes. review when able, i'll start on pools tomorrow | 01:07 |
| rm_work | gonna go get some food while it's nice out :) | 01:07 |
| johnsom | Nice, yeah, I wanted to stop an hour ago | 01:08 |
| rm_work | mainly looking for broad stroke stuff asap like "please combine these tests" or "please split this test" or whatever | 01:08 |
| rm_work | anywho, ttyl | 01:08 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Implement provider drivers https://review.openstack.org/563795 | 01:21 |
| johnsom | ^^^ LB API with more driver and no handler... | 01:22 |
| johnsom | Tomorrow listeners | 01:23 |
| *** yamamoto has joined #openstack-lbaas | 01:59 | |
| *** yamamoto has quit IRC | 02:03 | |
| *** yamamoto has joined #openstack-lbaas | 02:05 | |
| *** yamamoto has quit IRC | 02:09 | |
| *** yamamoto has joined #openstack-lbaas | 02:20 | |
| *** sapd has quit IRC | 03:08 | |
| *** fnaval has joined #openstack-lbaas | 03:38 | |
| *** gans has joined #openstack-lbaas | 04:15 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for pools https://review.openstack.org/565640 | 04:19 |
| *** gans has quit IRC | 04:22 | |
| *** ianychoi has joined #openstack-lbaas | 04:34 | |
| *** links has joined #openstack-lbaas | 04:50 | |
| rm_work | johnsom: ummm i may be crazy, but... i think i can ... make like 90% of the test code disappear with some fancy DRY work <_< | 05:04 |
| rm_work | i might do that right after pools | 05:04 |
| johnsom | Ha, just don’t make it overly obscure such that no one can learn and expand the tests | 05:05 |
| johnsom | The whole point of LB was to make an example / learning tool | 05:05 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for pools https://review.openstack.org/565640 | 05:08 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for listeners https://review.openstack.org/492311 | 05:14 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for pools https://review.openstack.org/565640 | 05:14 |
| rm_work | johnsom: lolk | 05:14 |
| rm_work | johnsom: but it would make ADDING tests for new objects like | 05:14 |
| rm_work | a couple of lines <_< | 05:14 |
| rm_work | wow actually pool tests looking good already | 05:27 |
| rm_work | so maybe tomorrow I can get one or two more hammered out | 05:28 |
| rm_work | really, I just want to get to a *working full-traffic scenario test* | 05:29 |
| rm_work | before EOW | 05:29 |
| rm_work | because one of my sprint tasks is "get scenario tests running internally" :P | 05:30 |
| *** yboaron_ has joined #openstack-lbaas | 05:30 | |
| *** fnaval has quit IRC | 05:53 | |
| *** astafeye__ has joined #openstack-lbaas | 05:58 | |
| *** sapd has joined #openstack-lbaas | 06:16 | |
| *** yboaron has joined #openstack-lbaas | 06:22 | |
| *** yboaron_ has quit IRC | 06:25 | |
| *** annp has joined #openstack-lbaas | 06:48 | |
| *** rcernin_ has joined #openstack-lbaas | 06:50 | |
| *** astafeye__ has quit IRC | 06:51 | |
| *** rcernin has quit IRC | 06:51 | |
| *** rcernin_ has quit IRC | 07:05 | |
| *** tesseract has joined #openstack-lbaas | 07:25 | |
| openstackgerrit | Adit Sarfaty proposed openstack/neutron-lbaas master: Fix EntityInUse exception message https://review.openstack.org/565661 | 07:37 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for listeners https://review.openstack.org/492311 | 07:56 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for pools https://review.openstack.org/565640 | 07:56 |
| rm_work | found a possible test failure condition, pretty lulzy, but fixed | 07:57 |
| rm_work | http://logs.openstack.org/40/565640/3/check/octavia-v2-dsvm-noop-py35-api/1db1d2e/job-output.txt.gz#_2018-05-02_05_44_27_248937 | 07:57 |
| rm_work | in noop mode, the stuff creates so quickly that it can have a duplicate create_time for two objects, making the "default sort order" (create_time) ambiguous and making the list test sporadically fail | 07:57 |
| *** pcaruana has joined #openstack-lbaas | 08:08 | |
| *** astafeye__ has joined #openstack-lbaas | 08:08 | |
| *** salmankhan has joined #openstack-lbaas | 08:24 | |
| cgoncalves | no-op, no-go :) | 08:28 |
| *** vegarl has quit IRC | 08:43 | |
| *** salmankhan has quit IRC | 08:43 | |
| *** vegarl has joined #openstack-lbaas | 08:44 | |
| *** salmankhan has joined #openstack-lbaas | 08:55 | |
| *** devfaz has quit IRC | 09:54 | |
| *** devfaz has joined #openstack-lbaas | 09:55 | |
| *** annp has quit IRC | 10:37 | |
| *** atoth has quit IRC | 10:40 | |
| *** fnaval has joined #openstack-lbaas | 11:07 | |
| *** fnaval has quit IRC | 11:12 | |
| *** atoth has joined #openstack-lbaas | 11:33 | |
| *** fnaval has joined #openstack-lbaas | 12:07 | |
| *** fnaval has quit IRC | 12:12 | |
| *** yamamoto has quit IRC | 12:25 | |
| *** yamamoto has joined #openstack-lbaas | 12:25 | |
| *** pcaruana has quit IRC | 12:30 | |
| *** nebu_ has joined #openstack-lbaas | 12:32 | |
| *** samccann has joined #openstack-lbaas | 12:56 | |
| *** pchavva has joined #openstack-lbaas | 13:07 | |
| *** fnaval has joined #openstack-lbaas | 13:07 | |
| *** pcaruana has joined #openstack-lbaas | 13:08 | |
| *** nebu_ has quit IRC | 13:12 | |
| *** fnaval has quit IRC | 13:12 | |
| *** fnaval has joined #openstack-lbaas | 13:49 | |
| *** yamamoto has quit IRC | 13:57 | |
| *** yamamoto has joined #openstack-lbaas | 14:11 | |
| *** openstackgerrit has quit IRC | 14:34 | |
| *** links has quit IRC | 14:34 | |
| *** astafeye__ has quit IRC | 14:49 | |
| cgoncalves | has anyone ever ran octavia dashboard py{27,35} tests locally? | 14:58 |
| xgerman_ | no | 14:58 |
| cgoncalves | py27 and py35 jobs seem to be skipping tests | 14:58 |
| cgoncalves | http://logs.openstack.org/11/543211/5/check/openstack-tox-py35/71736e8/job-output.txt.gz#_2018-04-23_11_56_40_641433 | 14:58 |
| xgerman_ | <troll>skipped tests always pass</troll> | 14:59 |
| xgerman_ | ok, I would run the relevant tox | 14:59 |
| xgerman_ | johnsom: runs tests locally I think | 15:00 |
| cgoncalves | well, actually we don't have tests written lol | 15:00 |
| xgerman_ | ha, I guess we have our work cutout then. Probably ask around how other projects do UI tests — in the apst there was some selenium stuff but that has been discontinued | 15:01 |
| cgoncalves | it caught my attention because our one of our downstream CI jobs was failing | 15:05 |
| cgoncalves | dayou, are you around? :) | 15:05 |
| johnsom | cgoncalves I run the dashboard tests local. | 15:09 |
| johnsom | What tests are you looking for? | 15:09 |
| johnsom | I know dayou just reworked a bunch of the unit tests | 15:09 |
| johnsom | But we do have pretty good unit test coverage. | 15:09 |
| johnsom | The integration tests however, never ran and horizon team gave up on them, so we removed the gates for those. | 15:10 |
| cgoncalves | johnsom, where are the tests? I only find placeholders | 15:10 |
| johnsom | They are integrated into the code | 15:10 |
| johnsom | One sec | 15:10 |
| johnsom | cgoncalves So this is the (unreviewed I might add) patch for the python stuff: https://review.openstack.org/#/c/550721/ But most of our code is javascript which has in tree tests. | 15:11 |
| johnsom | cgoncalves If you look in the repo: https://github.com/openstack/octavia-dashboard/tree/master/octavia_dashboard/static/dashboard/project/lbaasv2/loadbalancers | 15:12 |
| johnsom | You will see two files for each javascript module: loadbalancers.module.js and loadbalancers.module.spec.js | 15:12 |
| johnsom | The spec file is the unit test code | 15:12 |
| johnsom | The nodejs-npm-run-test gate runs those tests | 15:13 |
| cgoncalves | ah! so dashboard tests follow a different path structure than conventional projects | 15:14 |
| johnsom | cgoncalves: http://logs.openstack.org/63/564963/1/check/nodejs-npm-run-test/e811cfb/job-output.txt.gz#_2018-04-28_02_44_34_253814 | 15:14 |
| johnsom | Yes, our dashboard is Angular and not django (python) | 15:14 |
| johnsom | So currently there is 100% unit coverage on the javascript modules | 15:15 |
| cgoncalves | johnsom, great! follow-up question is: why do we have py27, py25 jobs enabled? | 15:15 |
| johnsom | There is still some, minor code in python to bridge us into horizon | 15:15 |
| johnsom | Plus it's politically the "right thing to do" for OpenStack projects.... grin | 15:17 |
| cgoncalves | those tests are eslint and karma in tox.ini? | 15:17 |
| cgoncalves | trying to understand how to run them | 15:18 |
| johnsom | Yes, I think so. You need the npm (nodejs) stuff installed for the javascript packages, etc. | 15:18 |
| johnsom | But I have been success running them local. | 15:19 |
| *** yamamoto has quit IRC | 15:21 | |
| cgoncalves | "karma: commands succeeded" | 15:21 |
| cgoncalves | thanks! | 15:21 |
| johnsom | Np | 15:22 |
| dayou | cgoncalves, https://review.openstack.org/#/c/550721/ | 15:23 |
| cgoncalves | dayou, great work you've been doing on the dashboard! keep up | 15:28 |
| johnsom | +100 | 15:31 |
| dayou | :-P | 15:38 |
| *** tesseract has quit IRC | 16:18 | |
| *** yboaron has quit IRC | 16:19 | |
| *** atoth has quit IRC | 16:21 | |
| *** yamamoto has joined #openstack-lbaas | 16:21 | |
| *** atoth has joined #openstack-lbaas | 16:24 | |
| *** yamamoto has quit IRC | 16:27 | |
| *** yboaron has joined #openstack-lbaas | 16:34 | |
| *** salmankhan has quit IRC | 16:37 | |
| *** b_bezak has joined #openstack-lbaas | 17:07 | |
| b_bezak | Hi | 17:08 |
| johnsom | Hello | 17:08 |
| b_bezak | do you happen to know how to enable "reqadd X-Forwarded-Proto:\ https" in Octavia? | 17:08 |
| *** Swami has joined #openstack-lbaas | 17:08 | |
| b_bezak | I mean on listener level, it looks like only X-Forwarded-Port and X-Forwarded-For are supported | 17:09 |
| johnsom | b_bezak Yes, when you create or update a listener you specify the "insertion_headers" option: https://developer.openstack.org/api-ref/load-balancer/v2/index.html#create-listener and https://developer.openstack.org/api-ref/load-balancer/v2/index.html#header-insertions document these | 17:10 |
| johnsom | b_bezak Oh, I don't think X-Forwarded-Proto is supported currently | 17:10 |
| johnsom | It would need to be added. You can create a story for that here: https://storyboard.openstack.org/#!/dashboard/stories and put up a patch. It would likely not be hard to add. | 17:11 |
| b_bezak | johnsom: thank you. I'll look into it | 17:16 |
| johnsom | b_bezak Let us know if you run into questions, etc. we are here to help | 17:16 |
| b_bezak | sure | 17:19 |
| *** b_bezak has quit IRC | 17:19 | |
| *** b_bezak has joined #openstack-lbaas | 17:20 | |
| *** yamamoto has joined #openstack-lbaas | 17:23 | |
| *** b_bezak has quit IRC | 17:24 | |
| *** yamamoto has quit IRC | 17:29 | |
| rm_work | what does that do? I've never heard of X-Forwarded-Proto | 17:33 |
| rm_work | since ... it would always have to be HTTP? | 17:34 |
| rm_work | since you can't add headers to non-HTTP? | 17:34 |
| johnsom | rm_work It passes back to the backends whether the frontend connection was HTTP or HTTPS | 17:35 |
| johnsom | For TLS termination | 17:35 |
| rm_work | ah | 17:35 |
| johnsom | I have seen it used before. The use cases are... but hey | 17:36 |
| *** salmankhan has joined #openstack-lbaas | 18:12 | |
| *** salmankhan has quit IRC | 18:16 | |
| *** yboaron has quit IRC | 18:19 | |
| *** yamamoto has joined #openstack-lbaas | 18:25 | |
| *** yamamoto has quit IRC | 18:31 | |
| nmagnezi | johnsom, looks like there is no storyboard meeting this week | 19:04 |
| johnsom | Hmm, ok | 19:04 |
| *** yamamoto has joined #openstack-lbaas | 19:27 | |
| *** yamamoto has quit IRC | 19:33 | |
| -openstackstatus- NOTICE: The Gerrit service at review.openstack.org will be offline starting at 20:00 (in roughly 25 minutes) for a server move and operating system upgrade: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130118.html | 19:36 | |
| *** atoth has quit IRC | 19:48 | |
| johnsom | #startmeeting Octavia | 20:00 |
| openstack | Meeting started Wed May 2 20:00:03 2018 UTC and is due to finish in 60 minutes. The chair is johnsom. Information about MeetBot at http://wiki.debian.org/MeetBot. | 20:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 20:00 |
| *** openstack changes topic to " (Meeting topic: Octavia)" | 20:00 | |
| openstack | The meeting name has been set to 'octavia' | 20:00 |
| johnsom | Hi folks! | 20:00 |
| cgoncalves | hi | 20:00 |
| xgerman_ | o/ | 20:00 |
| johnsom | #topic Announcements | 20:01 |
| *** openstack changes topic to "Announcements (Meeting topic: Octavia)" | 20:01 | |
| johnsom | The only announcement I have this week is that we have a new TC elected: | 20:01 |
| xgerman_ | +1 | 20:01 |
| johnsom | #link https://governance.openstack.org/election/results/rocky/tc.html | 20:01 |
| johnsom | Oh, and there is now an Octavia ingress controller for Octavia | 20:02 |
| johnsom | #link https://github.com/kubernetes/cloud-provider-openstack/tree/master/pkg/ingress | 20:02 |
| johnsom | Any other announcements this week? | 20:02 |
| johnsom | #topic Brief progress reports / bugs needing review | 20:03 |
| *** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)" | 20:03 | |
| johnsom | I have been busy working on the provider driver. The Load Balancer part is now complete and up for review comments. | 20:03 |
| johnsom | #link https://review.openstack.org/#/c/563795/ | 20:03 |
| johnsom | It got a bit big due to single-call-create being part of load balancer. | 20:04 |
| rm_work | o/ | 20:04 |
| johnsom | So, I'm going to split it across a few patches (and update the commit to reflect that) | 20:04 |
| -openstackstatus- NOTICE: The Gerrit service at review.openstack.org will be offline over the next 1-2 hours for a server move and operating system upgrade: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130118.html | 20:04 | |
| *** ChanServ changes topic to "The Gerrit service at review.openstack.org will be offline over the next 1-2 hours for a server move and operating system upgrade: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130118.html" | 20:04 | |
| nmagnezi | johnsom, thank you for taking a lead on this. I will review it. | 20:05 |
| johnsom | Ha, I guess there is that announcement as well | 20:05 |
| rm_work | I have been working on the octavia tempest plugin. Two patches ready for review (although I need to address johnsom's comments) | 20:05 |
| johnsom | I think the listener one will be a good example for what needs to happen with the rest of the API. It's up next for me | 20:05 |
| johnsom | +1 on tempest plugin work | 20:05 |
| johnsom | Any updates on Rally or grenade tests? | 20:07 |
| cgoncalves | sorry, I still need to resume the grenade patch | 20:07 |
| johnsom | Ok, NP. Just curious for an update. | 20:08 |
| nmagnezi | johnsom, the rally scenario now works, i have some other internal fires to put out and then I'll iterate back to run it and report the numbers. it had a bug with the loadbalancers cleanup which is fixed now. so we are in a good shape there overall. | 20:08 |
| johnsom | Cool! | 20:08 |
| johnsom | Any other updates this week or should we move on to our next agenda topic? | 20:09 |
| nmagnezi | yeah :) it took quite a few tries but it worth the effort i think. | 20:09 |
| johnsom | #topic Discuss health monitors of type PING | 20:09 |
| *** openstack changes topic to "Discuss health monitors of type PING (Meeting topic: Octavia)" | 20:09 | |
| johnsom | #link https://review.openstack.org/#/c/528439/ | 20:09 |
| johnsom | nmagnezi This is your topic. | 20:09 |
| nmagnezi | open it ^^ while gerrit still works :) | 20:10 |
| rm_work | PING is dumb and should be burned with fire | 20:10 |
| nmagnezi | so, rm_work submitted a patch to allow operators to block it | 20:10 |
| johnsom | I can give a little background on why I added this feature. | 20:10 |
| cgoncalves | rm_work: wait for it. I think you will like it ;) | 20:10 |
| johnsom | 1. Most load balancers offer it. | 20:10 |
| rm_work | johnsom: because you want users to suffer? | 20:10 |
| nmagnezi | i commented that I understand rm_work's point, but I don't know if adding a config option is a good idea here | 20:10 |
| nmagnezi | rm_work, lol | 20:11 |
| rm_work | we're handing them a gun and pointing it at their foot for them | 20:11 |
| nmagnezi | anyhow, the discussion I think we should have is whether or not we want to deprecate and later remove this option from our API | 20:11 |
| rm_work | cgoncalves: you're right :) | 20:11 |
| johnsom | 2. I was doing some API load testing with members and wanted them online, but not getting HTTP hits to skew metrics. | 20:11 |
| rm_work | you could also just ... not use HMs in a load test... they'll also be "online" | 20:12 |
| rm_work | or use an alternate port | 20:13 |
| johnsom | Well, they would be "no monitor" | 20:13 |
| rm_work | does TCP Connect actually count for stats? | 20:13 |
| johnsom | It was basically, ping localhost so they all go online no matter what. | 20:13 |
| johnsom | So, I'm just saying there was a reason I went to the trouble to fix that (beyond the old broken docs that listed it) | 20:14 |
| rm_work | we could rename it to "DO_NOT_USE_PING" | 20:15 |
| nmagnezi | johnsom, your opinion is that we should keep ping hm as is? | 20:15 |
| johnsom | Now, I fully understand that joe-I-don't-know-jack-but-am-an-load-balancer-expert will use PING for all of the wrong reasons.... I have seen it with my own eyes. | 20:15 |
| rm_work | in *most openstack clouds* the default SG setup is to block ICMP | 20:16 |
| rm_work | though I guess I can't back that up with actual survey data | 20:16 |
| johnsom | Nice, so they instantly fail and they don't get too burned by being dumb | 20:16 |
| johnsom | grin | 20:16 |
| rm_work | so people are like "all my stuff is down, your thing is broken" | 20:16 |
| xgerman_ | I dislike most ooenstack clouds — there are some wacky clpuds out there | 20:17 |
| rm_work | lol | 20:17 |
| johnsom | My stance is, most, if not all of our load balancers support it. There was at least one use case for adding it. It's there and works (except on centos amps). Do we really need to remove it? | 20:18 |
| nmagnezi | johnsom, in your eyes, what are the right reasons for using ping hm? | 20:18 |
| * xgerman_ read about people using k8s to loadbalance since they don’t want to upgrade from Mitaka | 20:18 | |
| johnsom | Testing purposes only... Ha | 20:18 |
| nmagnezi | lol | 20:18 |
| nmagnezi | i'm not asking if we should or shouldn't remove this because of the centos amps. I'm asking this because it seem that everyone agree with rm_work's gentle statements about ping :) | 20:19 |
| * rm_work is so gentle and PC | 20:19 | |
| rm_work | tremendously gentle, everyone says so. anyone who doesn't is fake news | 20:20 |
| johnsom | #link http://andrewkandels.com/easy-icmp-health-checking-for-front-end-load-balanced-web-servers | 20:20 |
| johnsom | lol | 20:20 |
| cgoncalves | +1. unless there's a complelling use case for keeping ping, I'm for removing it | 20:20 |
| rm_work | we SHOULD probably check with some vendors | 20:20 |
| rm_work | I wish we had more participation from them | 20:20 |
| nmagnezi | the point i'm trying to make here is that if ping is something we would want to keep, i don't think we need a config option to block it. | 20:20 |
| xgerman_ | +1 | 20:21 |
| rm_work | I don't even see most of our vendor contacts in-channel anymore | 20:21 |
| nmagnezi | if we agree that it should be removed, we don't need that config option as well :) | 20:21 |
| xgerman_ | that’s why we are ding providers | 20:21 |
| rm_work | nmagnezi: yeah, this was supposed to be a compromise | 20:21 |
| rm_work | you could argue that all compromise is bad and we should just pick a direction | 20:21 |
| xgerman_ | anyhow, I think ping has value — not everybody runs HTTP or TCP | 20:21 |
| xgerman_ | we have UDP coming up | 20:22 |
| johnsom | Yeah, from what I see, all of our vendors support ICMP | 20:22 |
| rm_work | alright | 20:22 |
| rm_work | well | 20:22 |
| xgerman_ | just trying to thik through a UDP healthmonitor | 20:22 |
| johnsom | This is true, UDP is harder to check | 20:22 |
| rm_work | yes | 20:22 |
| johnsom | Maybe someone will want us to load balance ICMP.... | 20:22 |
| johnsom | grin | 20:22 |
| rm_work | but that's why there's TCP_CONNECT and alternate ports | 20:23 |
| nmagnezi | HAHA | 20:23 |
| rm_work | any reason a UDP member wouldn't allow a TCP_CONNECT HM with the monitor_port? | 20:23 |
| johnsom | Yes, if they don't have any TCP code.... | 20:23 |
| nmagnezi | rm_work, that might depend on the app you run on the members | 20:24 |
| rm_work | i mean | 20:24 |
| johnsom | Yeah, so F5, A10, radware, and netscaler all have ICMP health check options | 20:24 |
| rm_work | you would run another app | 20:24 |
| rm_work | that is a health check for the UDP app | 20:25 |
| rm_work | to make sure it is up, etc | 20:25 |
| rm_work | so combo of connectable + 200OK response == good | 20:25 |
| rm_work | I was pretty sure that was the standard for healthchecking stuff and why we added the monitor_port thing to begin with | 20:25 |
| johnsom | Well, some of this UDP stuff is for very dumb/simple devices. That was what the use case discussion was at the PTG around the need for UDP | 20:25 |
| nmagnezi | rm_work, sounds a little bit redundant. if you want to check the health of you ACTUAL app, why have another one just to answer the lb? | 20:26 |
| xgerman_ | probably not too dumb for ICMP | 20:26 |
| nmagnezi | (but you could argue the same for ICMP, but at least it checks networking.. ha) | 20:26 |
| johnsom | So, if the concern is for users mis-using ICMP, should we maybe just add a warning print to the client and dashboard? | 20:26 |
| nmagnezi | johnsom, +! | 20:26 |
| nmagnezi | johnsom, +1 | 20:26 |
| xgerman_ | +1 | 20:26 |
| rm_work | k T_T | 20:26 |
| rm_work | I am ok with this | 20:27 |
| nmagnezi | johnsom, i would add another warning to the logs as well | 20:27 |
| cgoncalves | +1, plus warning msg in server side? | 20:27 |
| rm_work | eh, logs just go to ops, and they can see it in the DB | 20:27 |
| rm_work | which is easier to check | 20:27 |
| rm_work | and they already know it's dumb | 20:27 |
| rm_work | i wouldn't bother with the server side | 20:27 |
| johnsom | Eh, not sure operators would care that much what heatlh monitors the users are setting. Does that cross the "INFO" log level????? | 20:27 |
| rm_work | its users we need to reach | 20:27 |
| nmagnezi | johnsom, a user being dump sounds like a warning to me :) | 20:28 |
| nmagnezi | dumb* | 20:28 |
| johnsom | Yeah, I just want us to draw a balance between filling up log files with noise and having actionable info in there. | 20:29 |
| *** yamamoto has joined #openstack-lbaas | 20:29 | |
| nmagnezi | well, you only print it once, when the it's created | 20:29 |
| nmagnezi | so it's not spamming the logs that bad | 20:29 |
| johnsom | Ha, I have seen projects with 250 LBs in it. Click-deploy.... | 20:30 |
| johnsom | I am ok with logging it, no higher than INFO, if you folks think it is useful | 20:30 |
| nmagnezi | fair enough. | 20:30 |
| rm_work | wait, isn't info the one that always prints? | 20:30 |
| rm_work | or, i guess that was your point | 20:31 |
| rm_work | k | 20:31 |
| johnsom | It would be some "fanatical support" to have agents call the user that just did that.... Grin | 20:31 |
| rm_work | I would set up an automated email job | 20:31 |
| nmagnezi | lol | 20:31 |
| johnsom | That was flux... | 20:32 |
| johnsom | Ha, ok, so where are we at with the config patch? | 20:32 |
| rm_work | "We noticed you just created a PING Health Monitor for LB #UUID#. We recommend you reconsider, and use a different method for the following reasons: ...." | 20:32 |
| rm_work | I mean... I would still like to be able to disable it, personally, but I grant that it should probably remain an option at large (however reluctantly) | 20:33 |
| johnsom | I can open a story to add warnings to the client and dashboard | 20:33 |
| rm_work | I can put WIP on this one or DNM or whatever, and just continue to pull it in downstream I guess <_< | 20:33 |
| rm_work | I just figured a config couldn't hurt | 20:33 |
| *** yboaron has joined #openstack-lbaas | 20:33 | |
| *** pcaruana has quit IRC | 20:34 | |
| rm_work | the way I designed it, it would explain to the user when it blocks the creation | 20:34 |
| nmagnezi | rm_work, if everyone else agree on that, I will not be the one to block it. Just wanted to raise discussion around this topic | 20:34 |
| johnsom | I am ok with empowering operators myself | 20:34 |
| *** yamamoto has quit IRC | 20:34 | |
| rm_work | can we get CentOS to 1.8? :P | 20:34 |
| rm_work | I'd have a much weaker case then | 20:35 |
| xgerman_ | \me wrong person to ask | 20:35 |
| cgoncalves | +1, still knowing nmagnezi is not a fan of adding config options like this | 20:35 |
| nmagnezi | cgoncalves and myself are working on it. it's not easy but we are doing our best :) | 20:35 |
| cgoncalves | rm_work: soon! ;) | 20:35 |
| rm_work | k | 20:35 |
| nmagnezi | rm_work, we'll keep you posted | 20:35 |
| rm_work | I mean | 20:35 |
| rm_work | if we got a more official repo | 20:35 |
| rm_work | we don't even need it in the main repo | 20:35 |
| rm_work | we could merge my patch to the amp agent element | 20:35 |
| rm_work | err, amp element | 20:35 |
| rm_work | (which I already pull in downstream) | 20:36 |
| cgoncalves | rm_work: short answer is: likely to have 1.8 in OSP14 (Rocky) | 20:36 |
| rm_work | in what way? | 20:36 |
| rm_work | CentOS amps based on CentOS8? | 20:36 |
| rm_work | Official repo for OpenStack HAProxy? | 20:36 |
| rm_work | HAProxy 1.8 backported into CentOS7? | 20:37 |
| cgoncalves | cross tag. haproxy rpm in osp repo, same rpm as from openshift/pass repo | 20:37 |
| rm_work | ok | 20:37 |
| rm_work | so we would update and merge my patch | 20:37 |
| cgoncalves | we will keep haproyz 1.5 but add 'haproxy18' package | 20:38 |
| rm_work | yeah | 20:38 |
| johnsom | #link https://storyboard.openstack.org/#!/story/2001957 | 20:38 |
| cgoncalves | rm_work: you could then delete the repo add part from your patch | 20:38 |
| rm_work | ok | 20:39 |
| rm_work | i wish i could look up that CR now >_> | 20:39 |
| rm_work | great timing on gerrit outage for us, lol | 20:39 |
| johnsom | So, I guess to close out the PING topic, vote on the open patch. (once gerrit is back) | 20:40 |
| johnsom | #topic Open Discussion | 20:41 |
| *** openstack changes topic to "Open Discussion (Meeting topic: Octavia)" | 20:41 | |
| johnsom | Any topics today? | 20:41 |
| rm_work | Multi-AZ? | 20:41 |
| rm_work | I have a patch, it is actually reasonable to review | 20:41 |
| rm_work | the question is... since it will only work if every AZ is routable on the same L2... is this reasonable to merge? | 20:42 |
| rm_work | At least one other operator was doing the same thing and even had some similar patches started | 20:42 |
| johnsom | We have a bionic gate, it is passing, but I'm not sure how giving the networking changes they made. It must have a backward compatibility feature. It's on my list to go update the amphora-agent for bionic's new networking. | 20:42 |
| johnsom | I have not looked at the AZ patch, so can't really comment at the moment | 20:43 |
| rm_work | (or if they're using an L3 networking driver) | 20:43 |
| rm_work | k, it's more about whether the concept is a -2 or not | 20:43 |
| *** yboaron has quit IRC | 20:45 | |
| johnsom | In general mutli-AZ seems great to me. However the details really get deep | 20:45 |
| rm_work | yeah | 20:47 |
| rm_work | though if you have a routable L2 for all AZs, or you use an L3 net driver... then my patch will *just work* | 20:47 |
| xgerman_ | +1 | 20:47 |
| rm_work | and the best part is that the only required config change is ... adding the additional AZs to the az config | 20:47 |
| rm_work | :) | 20:47 |
| xgerman_ | Would love nova to do something reasonable but in the interim… | 20:48 |
| johnsom | Yeah, so I think it's down to review | 20:49 |
| johnsom | Which brings me to a gentle nag.... | 20:49 |
| xgerman_ | +1 | 20:49 |
| johnsom | #link ttps://review.openstack.org/#/q/(project:openstack/octavia+OR+project:openstack/octavia-dashboard+OR+project:openstack/python-octaviaclient+OR+project:openstack/octavia-tempest-plugin)+AND+status:open+AND+NOT+label:Code-Review%253C0+AND+NOT+label:Verified%253C%253D0+AND+NOT+label:Workflow%253C0 | 20:49 |
| johnsom | Well, when gerrit is back up. | 20:50 |
| nmagnezi | johnsom, forgot an 'h' | 20:50 |
| rm_work | ono | 20:50 |
| johnsom | There are a ton of open un-reviewed patches.... | 20:50 |
| johnsom | #undo | 20:50 |
| openstack | Removing item from minutes: #link ttps://review.openstack.org/#/q/(project:openstack/octavia+OR+project:openstack/octavia-dashboard+OR+project:openstack/python-octaviaclient+OR+project:openstack/octavia-tempest-plugin)+AND+status:open+AND+NOT+label:Code-Review%253C0+AND+NOT+label:Verified%253C%253D0+AND+NOT+label:Workflow%253C0 | 20:50 |
| rm_work | so many | 20:50 |
| rm_work | I need to go review too, but | 20:50 |
| johnsom | #link https://review.openstack.org/#/q/(project:openstack/octavia+OR+project:openstack/octavia-dashboard+OR+project:openstack/python-octaviaclient+OR+project:openstack/octavia-tempest-plugin)+AND+status:open+AND+NOT+label:Code-Review%253C0+AND+NOT+label:Verified%253C%253D0+AND+NOT+label:Workflow%253C0 | 20:50 |
| rm_work | not just me :P | 20:50 |
| johnsom | Yeah, please take a few minutes and help us with reviews. | 20:51 |
| johnsom | Any other topics today? | 20:51 |
| johnsom | Ok then. Thanks everyone! | 20:52 |
| johnsom | #endmeeting | 20:52 |
| *** openstack changes topic to "Discussion of OpenStack Load Balancing (Octavia) | https://etherpad.openstack.org/p/octavia-priority-reviews" | 20:52 | |
| nmagnezi | o/ | 20:52 |
| openstack | Meeting ended Wed May 2 20:52:35 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 20:52 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2018/octavia.2018-05-02-20.00.html | 20:52 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2018/octavia.2018-05-02-20.00.txt | 20:52 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2018/octavia.2018-05-02-20.00.log.html | 20:52 |
| *** samccann has quit IRC | 21:03 | |
| *** pchavva has quit IRC | 21:14 | |
| *** yamamoto has joined #openstack-lbaas | 21:31 | |
| *** yamamoto has quit IRC | 21:37 | |
| rm_work | johnsom: the fact that you used [load_balancer] for the config section name makes me die inside | 21:51 |
| rm_work | and also test_load_balancer.py | 21:51 |
| rm_work | I think I'm going to rename all of it in this patch | 21:51 |
| rm_work | we're trying to *de-underscore* the things | 21:52 |
| rm_work | right? | 21:52 |
| johnsom | No, that config section is dictated by the tempest docs and our service type | 21:52 |
| *** bcafarel has quit IRC | 21:52 | |
| rm_work | uuuuuuugh | 21:54 |
| rm_work | why does our service type have an underscore | 21:54 |
| rm_work | i hate everyone and everything | 21:54 |
| johnsom | It is a hyphen in the service type. I put it in as without, but got out voted | 21:59 |
| *** pchavva has joined #openstack-lbaas | 22:01 | |
| *** openstackgerrit has joined #openstack-lbaas | 22:02 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for listeners https://review.openstack.org/492311 | 22:02 |
| *** openstackgerrit has quit IRC | 22:04 | |
| -openstackstatus- NOTICE: Gerrit maintenance has concluded successfully | 22:10 | |
| *** fnaval has quit IRC | 22:18 | |
| *** fnaval has joined #openstack-lbaas | 22:22 | |
| rm_work | johnsom: by whom? T_T | 22:28 |
| *** fnaval_ has joined #openstack-lbaas | 22:28 | |
| *** fnaval has quit IRC | 22:30 | |
| johnsom | A bunch of folks, Monty, etc. I even had that as a octavia meeting agenda item.... | 22:30 |
| rm_work | T_T | 22:30 |
| *** fnaval_ has quit IRC | 22:30 | |
| rm_work | how did I vote | 22:30 |
| johnsom | I don't remember | 22:31 |
| johnsom | Is what it is now.... | 22:31 |
| *** yamamoto has joined #openstack-lbaas | 22:32 | |
| *** rcernin has joined #openstack-lbaas | 22:36 | |
| *** yamamoto has quit IRC | 22:38 | |
| rm_work | I need to post a gif of my face to /r/WatchPeopleDieInside/ | 22:43 |
| johnsom | Huh, who knew that was actually a thing.... | 22:48 |
| johnsom | rm_work Are you drinking martini's now? | 22:53 |
| johnsom | You seem to have DRY on the brain | 22:53 |
| johnsom | I'm going to push back on a few of those comments | 22:53 |
| *** openstackgerrit has joined #openstack-lbaas | 22:59 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Implement provider drivers - Load Balancer https://review.openstack.org/563795 | 22:59 |
| *** fnaval has joined #openstack-lbaas | 23:01 | |
| *** redondo-mk_ has joined #openstack-lbaas | 23:09 | |
| *** beisner_ has joined #openstack-lbaas | 23:09 | |
| *** mnaser_ has joined #openstack-lbaas | 23:09 | |
| *** fnaval has quit IRC | 23:15 | |
| *** redondo-mk has quit IRC | 23:16 | |
| *** beisner has quit IRC | 23:16 | |
| *** mnaser has quit IRC | 23:16 | |
| *** sbalukoff has quit IRC | 23:16 | |
| *** redondo-mk_ is now known as redondo-mk | 23:16 | |
| *** beisner_ is now known as beisner | 23:16 | |
| *** mnaser_ is now known as mnaser | 23:16 | |
| rm_work | johnsom: i am actually finishing up on the kwargs change in the clients now | 23:19 |
| rm_work | i was working on it immediately after pushing the last patch but got distracted | 23:19 |
| rm_work | almost done | 23:19 |
| *** sbalukoff has joined #openstack-lbaas | 23:22 | |
| rm_work | johnsom: or do you mean on the provider patch? because i thought i mostly agreed with you | 23:33 |
| *** yamamoto has joined #openstack-lbaas | 23:34 | |
| *** yamamoto has quit IRC | 23:40 | |
| *** Swami has quit IRC | 23:46 | |
| johnsom | rm_work Yeah, the provider patch. | 23:50 |
| *** pchavva has quit IRC | 23:57 | |
| rm_work | I will jump through SO MANY HOOPS to keep DRY | 23:58 |
| rm_work | (also no martinis yet, just chugging cough syrup) | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!