johnsom | Well, I posted comments and an updated patch. | 00:00 |
---|---|---|
johnsom | I will not be around much tonight, parents are in town. Taking them out to dinner for an easy Mother's day gift. | 00:01 |
rm_work | kk | 00:03 |
rm_work | I mean wait till you see this... | 00:03 |
openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for listeners https://review.openstack.org/492311 | 00:10 |
rm_work | johnsom: https://review.openstack.org/#/c/492311/32/octavia_tempest_plugin/services/load_balancer/v2/loadbalancer_client.py@89 :P | 00:10 |
johnsom | rm_work Oh god | 00:11 |
rm_work | keepin' it DRY | 00:11 |
rm_work | if you won't let me use kwargs... I'll make my own | 00:11 |
johnsom | Do you get my point that it's not user friendly and harder to maintain? | 00:12 |
rm_work | I fixed it | 00:12 |
rm_work | no one needs to touch that ever | 00:12 |
rm_work | just change the args in the function | 00:12 |
johnsom | 640kb is all you will ever need | 00:12 |
rm_work | ;) | 00:13 |
rm_work | soo.... that's a +2 then? :) | 00:13 |
johnsom | Wait, that is basically the same thing I did just more cryptic.... | 00:18 |
johnsom | lol | 00:18 |
johnsom | It removes the coolness of being able to create arbitrary json to try to break things, but it's basically the same | 00:20 |
johnsom | The re-arrangement is making gerrit lose it's lunch, but... | 00:21 |
johnsom | rm_work I think you missed my build timeout comment too. | 00:23 |
rm_work | oh? where | 00:27 |
johnsom | I think we need to increase the 'build_timeout' default from 30 seconds to 60. The linstener creates require nova/neutron port actions as well as waiting for qemu to plug the port. It looks like on the Rackspace cloud that is taking too long (35s in this case). | 00:27 |
johnsom | It was in my first -1 | 00:28 |
rm_work | ah yeah | 00:28 |
rm_work | i agree | 00:28 |
johnsom | It was the one previous gate failure. I ran it to ground for you. | 00:29 |
rm_work | yeah i noticed it | 00:29 |
rm_work | i just thought maybe 30s was too short and we could talk about increasing it | 00:30 |
rm_work | but i forgot to mention it | 00:30 |
rm_work | T_T | 00:30 |
rm_work | and then forgot it entirely | 00:30 |
johnsom | Well, there is your answer | 00:30 |
rm_work | doing it | 00:30 |
rm_work | any other changes? | 00:30 |
johnsom | Reading through the comments now | 00:30 |
rm_work | k, heading to dinner, will address when I return | 00:30 |
johnsom | Ok, I will probably be gone by then. No vote/comments means it looks ok to me | 00:31 |
johnsom | Yeah, I don't think I have any more comments | 00:32 |
johnsom | Ok, nevermind, commenting on the protocols.... | 00:34 |
johnsom | Ok, maybe not, I get it | 00:35 |
*** yamamoto has joined #openstack-lbaas | 00:36 | |
*** yamamoto has quit IRC | 00:41 | |
openstackgerrit | inspurericzhang proposed openstack/octavia-dashboard master: Replace Chinese punctuation with English punctuation https://review.openstack.org/565922 | 00:49 |
*** threestrands has joined #openstack-lbaas | 01:05 | |
*** yamamoto has joined #openstack-lbaas | 01:38 | |
*** yamamoto has quit IRC | 01:44 | |
*** yamamoto has joined #openstack-lbaas | 01:50 | |
*** annp has joined #openstack-lbaas | 02:12 | |
*** ltomasbo has quit IRC | 04:31 | |
*** yboaron has joined #openstack-lbaas | 04:33 | |
*** ianychoi_ has joined #openstack-lbaas | 04:38 | |
*** ianychoi has quit IRC | 04:41 | |
*** links has joined #openstack-lbaas | 04:46 | |
openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for listeners https://review.openstack.org/492311 | 05:04 |
rm_work | ok there | 05:04 |
rm_work | and fixed the dumb find/replace fail i did | 05:05 |
openstackgerrit | ShangXiao proposed openstack/octavia-tempest-plugin master: Fix the invalid doc links https://review.openstack.org/565962 | 05:52 |
openstackgerrit | ShangXiao proposed openstack/octavia-tempest-plugin master: Fix the invalid home-page url https://review.openstack.org/565965 | 05:55 |
openstackgerrit | ShangXiao proposed openstack/octavia-tempest-plugin master: Fix the invalid home-page url https://review.openstack.org/565965 | 05:57 |
*** yboaron has quit IRC | 05:59 | |
*** astafeye__ has joined #openstack-lbaas | 06:25 | |
*** pcaruana has joined #openstack-lbaas | 06:53 | |
*** rcernin has quit IRC | 06:58 | |
*** threestrands has quit IRC | 06:58 | |
*** ianychoi_ is now known as ianychoi | 07:00 | |
*** tesseract has joined #openstack-lbaas | 07:18 | |
*** yboaron has joined #openstack-lbaas | 07:58 | |
*** salmankhan has joined #openstack-lbaas | 08:25 | |
*** links has quit IRC | 08:43 | |
*** links has joined #openstack-lbaas | 08:44 | |
*** salmankhan has quit IRC | 09:01 | |
*** salmankhan has joined #openstack-lbaas | 09:04 | |
*** bcafarel has joined #openstack-lbaas | 09:32 | |
*** bcafarel has quit IRC | 09:49 | |
*** bcafarel has joined #openstack-lbaas | 10:08 | |
*** salmankhan has quit IRC | 10:14 | |
*** salmankhan has joined #openstack-lbaas | 10:15 | |
*** yamamoto has quit IRC | 10:21 | |
*** yamamoto has joined #openstack-lbaas | 10:37 | |
*** annp has quit IRC | 10:40 | |
*** bcafarel has quit IRC | 11:15 | |
*** bcafarel has joined #openstack-lbaas | 11:16 | |
*** srihas has quit IRC | 11:28 | |
*** atoth has joined #openstack-lbaas | 11:30 | |
*** pchavva has joined #openstack-lbaas | 11:35 | |
*** srihas has joined #openstack-lbaas | 11:40 | |
*** yamamoto has quit IRC | 11:48 | |
*** yamamoto has joined #openstack-lbaas | 11:55 | |
*** yamamoto_ has joined #openstack-lbaas | 11:56 | |
*** yboaron_ has joined #openstack-lbaas | 11:56 | |
*** yamamoto_ has quit IRC | 11:57 | |
*** yboaron has quit IRC | 11:58 | |
*** yamamoto_ has joined #openstack-lbaas | 11:59 | |
*** yamamoto has quit IRC | 12:00 | |
*** yamamoto_ has quit IRC | 12:02 | |
*** yamamoto has joined #openstack-lbaas | 12:13 | |
*** yamamoto has quit IRC | 12:20 | |
*** yamamoto has joined #openstack-lbaas | 12:21 | |
*** yamamoto has quit IRC | 12:26 | |
*** salmankhan has quit IRC | 12:56 | |
*** salmankhan has joined #openstack-lbaas | 12:57 | |
*** yamamoto has joined #openstack-lbaas | 13:11 | |
*** yamamoto has quit IRC | 13:17 | |
*** yamamoto has joined #openstack-lbaas | 13:17 | |
*** samccann has joined #openstack-lbaas | 13:20 | |
*** yboaron_ has quit IRC | 13:22 | |
*** yamamoto has quit IRC | 13:22 | |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add grenade support https://review.openstack.org/549654 | 13:27 |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add grenade support https://review.openstack.org/549654 | 13:28 |
*** yboaron_ has joined #openstack-lbaas | 13:29 | |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add grenade support https://review.openstack.org/549654 | 13:38 |
*** dayou_ has joined #openstack-lbaas | 13:44 | |
*** salmankhan has quit IRC | 13:49 | |
*** salmankhan has joined #openstack-lbaas | 13:51 | |
*** yamamoto has joined #openstack-lbaas | 14:20 | |
*** dayou_ has quit IRC | 14:37 | |
*** yamamoto has quit IRC | 14:46 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 15:00 | |
*** AlexeyAbashkin has quit IRC | 15:03 | |
*** links has quit IRC | 15:06 | |
*** yboaron_ has quit IRC | 15:27 | |
mrhillsman | re octavia and kolla/kolla-ansible, is that something to discuss in kolla channel or here, specifically i ran into issues trying out the box but some manual fixes and i got it working | 15:41 |
mrhillsman | wanted to understand a bit more the state of it, have the issues been identified already, etc | 15:41 |
johnsom | mrhillsman The Kolla channel would be best. This team wasn't much involved in that. | 15:42 |
mrhillsman | ty sir | 15:42 |
*** yamamoto has joined #openstack-lbaas | 15:44 | |
*** pcaruana has quit IRC | 15:50 | |
*** yamamoto has quit IRC | 15:55 | |
*** salmankhan has quit IRC | 16:06 | |
*** tesseract has quit IRC | 16:28 | |
*** tesseract has joined #openstack-lbaas | 16:57 | |
*** tesseract has quit IRC | 17:25 | |
*** salmankhan has joined #openstack-lbaas | 17:41 | |
*** salmankhan has quit IRC | 17:46 | |
rm_work | mrhillsman: that said, we can also help a little, I do use kolla stuff for deployment some | 18:04 |
*** SumitNaiksatam has joined #openstack-lbaas | 18:08 | |
*** SumitNaiksatam has quit IRC | 18:18 | |
rm_work | johnsom: so the alternative to that locals() thing is also kinda cool | 18:54 |
rm_work | but equally obtuse | 18:54 |
rm_work | you throw this decorator above the function: | 18:54 |
rm_work | @proxy_rewrite('_update_object', {'obj_id': 'lb_id'}) | 18:54 |
rm_work | and then put the args and the docstrings in the same way, but no content | 18:55 |
rm_work | just leave the method empty :P | 18:55 |
rm_work | ah and then you write the code for that decorator actually... which is basically the locals code I wrote... so actually it's just *more* obtuse | 18:57 |
johnsom | Yeah, I +2'd the patch, so I think it's fine | 18:57 |
rm_work | k | 18:58 |
rm_work | i'm updating the pools one to match | 18:58 |
johnsom | Nice, I am working on Listener. Ran into a minor hiccup with the certs. I think I need to also pass the hrefs to the drivers. | 18:59 |
johnsom | We need it for update | 18:59 |
johnsom | I am about to go make lunch though | 19:00 |
rm_work | k | 19:05 |
*** openstackgerrit has quit IRC | 19:05 | |
*** atoth has quit IRC | 19:17 | |
*** atoth has joined #openstack-lbaas | 19:17 | |
*** sapd_ has joined #openstack-lbaas | 19:19 | |
*** yboaron_ has joined #openstack-lbaas | 19:20 | |
*** sapd has quit IRC | 19:22 | |
rm_work | johnsom: recommented on your providers | 19:33 |
johnsom | Thanks | 19:43 |
*** leitan has joined #openstack-lbaas | 19:47 | |
*** fnaval has joined #openstack-lbaas | 19:55 | |
*** leitan has quit IRC | 19:58 | |
johnsom | Commented back | 20:11 |
rm_work | k | 20:15 |
rm_work | working on pool session persistence bits | 20:16 |
rm_work | johnsom: re-re-commented | 20:20 |
rm_work | i'm going to win you over on this eventually | 20:20 |
rm_work | I am confident | 20:21 |
johnsom | Ha | 20:26 |
rm_work | we'll see if my confidence has merit | 20:29 |
rm_work | oh, only app-cookie can have a cookie name? http-cookie doesn't? weird | 20:30 |
rm_work | i guess i don't really know how those work | 20:30 |
johnsom | http-cookie is generated by the load balancer. APP-cookie is an "application" cookie, one that the application/webserver inserts but the load balancer uses | 20:36 |
rm_work | yeah k | 20:37 |
rm_work | now I know :P | 20:37 |
rm_work | about done with pools | 20:39 |
rm_work | then will start on members | 20:39 |
rm_work | your insistence on the field names in the create/update client functions literally doubles the amount of time this takes to make a new patch, lol | 20:39 |
*** openstackgerrit has joined #openstack-lbaas | 20:40 | |
openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Create api+scenario tests for pools https://review.openstack.org/565640 | 20:40 |
rm_work | xgerman_ / nmagnezi / dayou https://review.openstack.org/#/c/492311/ | 20:40 |
johnsom | Same: https://review.openstack.org/563795 | 20:45 |
johnsom | grin | 20:45 |
rm_work | you re-re-respond yet? :P | 20:46 |
johnsom | I don't respond to trolls | 20:46 |
johnsom | lol | 20:46 |
*** samccann has quit IRC | 20:56 | |
rm_work | it WILL work | 21:09 |
rm_work | and it WILL be cleaner, I swear | 21:09 |
rm_work | johnsom: ^^ | 21:29 |
johnsom | Cleaner we disagree on | 21:29 |
johnsom | I'm busy figuring out how to fix this SNI mess | 21:30 |
rm_work | k | 21:31 |
johnsom | At least fix it in a way I feel less dirty | 21:32 |
rm_work | i ... is it dirty? | 21:47 |
rm_work | did you see my most recent followup? | 21:47 |
johnsom | No | 21:47 |
johnsom | The SNI issues workaround feels dirty | 21:48 |
johnsom | Since it gets split off to another table the listener DB get comes back with no SNI. I have a solution | 21:49 |
*** yamamoto has joined #openstack-lbaas | 21:53 | |
*** yamamoto has quit IRC | 21:57 | |
*** yboaron_ has quit IRC | 22:04 | |
*** rcernin has joined #openstack-lbaas | 22:07 | |
*** pchavva has quit IRC | 22:36 | |
*** fnaval has quit IRC | 22:45 | |
*** astafeye__ has quit IRC | 22:47 | |
*** threestrands has joined #openstack-lbaas | 22:59 | |
*** fnaval has joined #openstack-lbaas | 23:15 | |
*** dmellado has quit IRC | 23:19 | |
lxkong | johnsom, rm_work hi, could you please take a look at this bug https://storyboard.openstack.org/#!/story/2001959? | 23:50 |
lxkong | does that make sense? | 23:50 |
*** dmellado has joined #openstack-lbaas | 23:51 | |
johnsom | lxkong That is an interesting one. I would break your two cases into the two tasks on the story. | 23:52 |
lxkong | johnsom: thanks, i am not sure if that's a common issue for others | 23:53 |
johnsom | lxkong I have not heard of it before. We have made a number of changes to the HM recently though. Can you include the release or commit of the Octavia you are running? | 23:53 |
lxkong | johnsom: i have rebased, the code relating to the problem didn't change | 23:54 |
johnsom | Ok, so this happens with master? | 23:54 |
lxkong | no exception catch, no sub-process monitoring | 23:54 |
lxkong | we are using pike, i have also checked master, but didn't test for msater | 23:55 |
lxkong | checked master code | 23:55 |
johnsom | Oh, ok, Pike I could see this happening, would be good to test with master HM | 23:55 |
johnsom | Yeah, ok, I can see how this can happen | 23:58 |
*** yamamoto has joined #openstack-lbaas | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!