| openstackgerrit | Michael Johnson proposed openstack/octavia master: Remove unnecessary interface configurations https://review.opendev.org/580778 | 00:02 |
|---|---|---|
| *** gthiemonge has quit IRC | 00:11 | |
| *** gthiemonge has joined #openstack-lbaas | 00:12 | |
| *** sapd1 has joined #openstack-lbaas | 00:39 | |
| johnsom | rm_work Not sure if you are around, but I looked at your AZ patches. You have them out of order and might need to break them apart more to avoid the "tips" job issue. The "tips" job is doing exactly what it is meant to do, stop you from adding octavia-lib functions that there is no code for in Octavia. | 00:41 |
| *** sapd1 has quit IRC | 01:06 | |
| gmann | haleyb: seems like resource provider name 'openstack:' causing the octavia greande job failing on py3 - https://zuul.opendev.org/t/openstack/build/b26bd7fc82d94d4cac97b5481623b629/log/logs/grenade.sh.txt.gz#30397 | 01:18 |
| *** armax has quit IRC | 01:48 | |
| *** ricolin has joined #openstack-lbaas | 01:55 | |
| *** abaindur has quit IRC | 03:14 | |
| rm_work | johnsom: hmm but if those two patches were the other way, they wouldn't work either | 03:17 |
| johnsom | You have to do the dat | 03:18 |
| johnsom | data model work in octavia first | 03:18 |
| rm_work | sorrison: ok so we can make a new two node job specifically to test the az stuff | 03:19 |
| johnsom | Ha, if you can get a two node devstack actually work | 03:19 |
| sorrison | rm_work: Yeah been looking into that a little. I think this should be a scenario test? | 03:19 |
| rm_work | johnsom: so we need to split sorrison's patch into two? | 03:19 |
| sorrison | I'll need to use the compute client to create a couple AZs first | 03:20 |
| sorrison | Interesting think is nova doesn't have a test for this really either | 03:20 |
| sorrison | *thing | 03:20 |
| rm_work | lol k. Yeah | 03:21 |
| sorrison | Also I'm wondering if we do need a 2 node one as can just have one compute AZ to test this I think | 03:22 |
| sorrison | I'm just trying to figure out exactly what I should be testing for | 03:23 |
| rm_work | I mean, I was going to do the rest | 03:24 |
| rm_work | I figured I'd create two AZs in Octavia, one for each Nova AZ, create one LB on each, and then check traffic on them both, and then check their amps and look at the compute used in nova to make sure they actually went to the right AZs | 03:25 |
| sorrison | yeah ok, however. If the nova boot command has the az passed in then it will fail if AZ doesn't exist. Also if there is a bug in octavia and the az isn't passed to the nova boot command then they could still end up where they are meant to go by chance | 03:29 |
| sorrison | There is no way to ask nova that the instance was booted with the intended AZ boot option sadly | 03:30 |
| sorrison | I was thinking about your idea too, I think it's the best way but still open for edge cases | 03:31 |
| rm_work | Right so we want to make the Nova AZs first ;) | 03:31 |
| rm_work | Yeah but we can just look up the amp vm after and see what AZ it's in | 03:32 |
| sorrison | yeah I can whip that up pretty quickly | 03:32 |
| rm_work | The tempest stuff is entirely real operations, we don't have to know what args were passed exactly, we just check the resulting objects | 03:32 |
| rm_work | I'll probably also do a test to try creating an Octavia AZ and telling it to use an invalid nova AZ and neutron network and make sure both of those things fail at the API create stage | 03:33 |
| rm_work | Could do that already ;) | 03:33 |
| sorrison | should I make the scenario test have a ipv4 and ipv6 version like the other create_lb tests? | 03:35 |
| johnsom | I don’t think ipv6 vs ipv4 matters for the AZ tests | 03:41 |
| rm_work | No | 03:45 |
| rm_work | Just copy one of the two node jobs, rename it to something about AZs | 03:46 |
| *** ataraday_ has quit IRC | 03:50 | |
| *** armax has joined #openstack-lbaas | 03:59 | |
| *** armax has quit IRC | 04:10 | |
| *** ramishra has joined #openstack-lbaas | 04:37 | |
| openstackgerrit | Sam Morrison proposed openstack/octavia-tempest-plugin master: Test the Availability Zone [Profile] admin API https://review.opendev.org/695291 | 04:53 |
| openstackgerrit | Sam Morrison proposed openstack/octavia-tempest-plugin master: Add new scenario test to create LB in specific AZ https://review.opendev.org/695349 | 04:53 |
| sorrison | rm_work: Haven't done the 2 node one yet but just wanted to get a single node one working first. Looking into 2-node one now | 04:54 |
| rm_work | k | 04:55 |
| rm_work | ahh i spy a few issues | 05:04 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Test the Availability Zone [Profile] admin API https://review.opendev.org/695291 | 05:04 |
| rm_work | maybe get closer to a pass now on the api tests | 05:04 |
| rm_work | the clients were a little borked | 05:05 |
| sorrison | ah, I just realised I completely forgot to actually create the octavia AZ and profile, had been fudging it in my local env with a pre created one | 05:09 |
| rm_work | haha | 05:10 |
| rm_work | well | 05:10 |
| rm_work | rebase, since the clients in the one you were on didn't work (I just fixed them I think) | 05:10 |
| sorrison | Looks like you have AZ expecting an ID/uuid when we use name for the AZ primary key right? | 05:16 |
| rm_work | hmmm maybe, need to check again | 06:16 |
| rm_work | i thought i fixed that | 06:16 |
| rm_work | looking | 06:17 |
| rm_work | ahhh well no | 06:17 |
| rm_work | fff ok this is an issue | 06:17 |
| rm_work | the resource name in the URL is different than the resource name in the JSON, but we expect them to be the same | 06:18 |
| rm_work | I need to split it out for this T_T | 06:18 |
| rm_work | or re-evaluate my decision to use "availability_zone_profile" instead of "availabilityzoneprofile" in the json response | 06:18 |
| *** gcheresh has joined #openstack-lbaas | 06:19 | |
| rm_work | oopsies :D | 06:22 |
| rm_work | fixed here: | 06:22 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Test the Availability Zone [Profile] admin API https://review.opendev.org/695291 | 06:22 |
| rm_work | err ok now i need to check what you were saying, got distracted and forgot | 06:23 |
| rm_work | i have one more update i guess, which is to remove "name" from the update call for AZ, since it can't be updated. otherwise I THINK it should just pass through the right thing | 06:25 |
| rm_work | "id" is really just "what goes in that space in the URL", putting the name in the "id" field in those functions will fill the right thing | 06:25 |
| rm_work | we'll see when these tests finish | 06:25 |
| rm_work | ah in some of the tests yeah it's trying to use name, will fix | 06:27 |
| *** numans has joined #openstack-lbaas | 06:28 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Test the Availability Zone [Profile] admin API https://review.opendev.org/695291 | 06:30 |
| rm_work | ok that should be ... better. going to let that one run through. | 06:30 |
| rm_work | I lied, adding a thing to stop making it run like 100 tests | 06:35 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: [WIP] Test the Availability Zone [Profile] admin API https://review.opendev.org/695291 | 06:36 |
| rm_work | there, better. 3 tests. lol | 06:37 |
| rm_work | really could have killed the py2 one as well... i will next time i make a change | 06:37 |
| *** rcernin has quit IRC | 07:12 | |
| *** abaindur has joined #openstack-lbaas | 07:22 | |
| *** pcaruana has joined #openstack-lbaas | 07:27 | |
| *** abaindur has quit IRC | 07:35 | |
| *** abaindur has joined #openstack-lbaas | 07:35 | |
| *** ccamposr__ has joined #openstack-lbaas | 07:54 | |
| *** ccamposr has quit IRC | 07:56 | |
| rm_work | ahh and i totally forgot to fix the capabilities used | 08:09 |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: [WIP] Test the Availability Zone [Profile] admin API https://review.opendev.org/695291 | 08:10 |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add tests for mixed IP networks UDP members https://review.opendev.org/668619 | 08:20 |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add UDP test scenario https://review.opendev.org/656515 | 08:20 |
| *** rpittau|afk is now known as rpittau | 08:20 | |
| *** tkajinam has quit IRC | 08:28 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 09:01 | |
| *** maciejjozefczyk has quit IRC | 09:14 | |
| *** ricolin has quit IRC | 09:22 | |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia stable/train: Fix controller worker graceful shutdown https://review.opendev.org/695374 | 09:22 |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia stable/stein: Fix controller worker graceful shutdown https://review.opendev.org/695376 | 09:25 |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia stable/rocky: Fix controller worker graceful shutdown https://review.opendev.org/695377 | 09:29 |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia stable/queens: Fix controller worker graceful shutdown https://review.opendev.org/695379 | 09:31 |
| *** abaindur has quit IRC | 09:45 | |
| *** abaindur has joined #openstack-lbaas | 09:45 | |
| *** ccamposr has joined #openstack-lbaas | 10:12 | |
| *** ccamposr__ has quit IRC | 10:14 | |
| *** ccamposr__ has joined #openstack-lbaas | 10:15 | |
| *** ccamposr has quit IRC | 10:18 | |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add tests for mixed IP networks UDP members https://review.opendev.org/668619 | 10:50 |
| *** ccamposr__ has quit IRC | 11:08 | |
| *** ccamposr__ has joined #openstack-lbaas | 11:09 | |
| *** rpittau is now known as rpittau|bbl | 11:11 | |
| *** ramishra has quit IRC | 11:38 | |
| *** ricolin has joined #openstack-lbaas | 12:27 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: [WIP] Test the Availability Zone [Profile] admin API https://review.opendev.org/695291 | 12:34 |
| rm_work | johnsom: yeah, it's a circular dependency. I checked again. can't add the thing where you claim in octavia, because adding it there requires it exists in octavia-lib. can't add it in octavia-lib without it breaking the tips job because it's missing in octavia. | 12:34 |
| rm_work | we need to temporarily disable the tips job on octavia-lib so we can merge it in and then merge the octavia side | 12:35 |
| rm_work | if you try it, just run the unit tests locally and you'll see | 12:36 |
| rm_work | i guess the alternative is to just add a skip on that test temporarily... | 12:37 |
| rm_work | that might be safer | 12:37 |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add tests for mixed IP networks UDP members https://review.opendev.org/668619 | 13:12 |
| *** rpittau|bbl is now known as rpittau | 13:12 | |
| *** armax has joined #openstack-lbaas | 13:23 | |
| rm_work | sorrison: ok, clients are good, tests are passing for the API | 13:44 |
| rm_work | gonna take this out of WIP in a sec | 13:44 |
| haleyb | gmann: so the command there, 'openstack resource provider inventory ...' looks like it's implemented in osc-placement - i didn't know we had to worry about installing that | 13:46 |
| gmann | haleyb: we are discussing in nova channel. it is parging of that command failing and pipeline broken so provider name is not what it shoule be | 13:47 |
| haleyb | gmann: ack, thanks, it didn't look like that failure was specific to my octavia patch | 13:49 |
| gmann | yeah, it is not. | 13:49 |
| gmann | somehow that commad failing on py3 on your patch only | 13:49 |
| haleyb | unicorn patch i guess | 13:50 |
| haleyb | or we're missing some requirement | 13:51 |
| *** ramishra has joined #openstack-lbaas | 14:13 | |
| johnsom | haleyb In case you aren't following the #openstack-nova thread, python-openstackclient is installed as python2 in the down (train) part of grenade, then on upgrade installed on python3 and the osc-placement package installed in python3. However, since python-openstackclient was first installed as python2, the python command file installed will still point to python2. | 14:34 |
| haleyb | johnsom: yes, i' | 14:34 |
| haleyb | i've got out the popcorn | 14:34 |
| johnsom | Nice | 14:34 |
| johnsom | It is entertaining me as I wake up | 14:35 |
| *** goldyfruit has joined #openstack-lbaas | 14:46 | |
| rm_work | johnsom: this circular dependency issue is less entertaining T_T | 14:53 |
| johnsom | rm_work Yes. If I fix your issue with an demo patch, what are you going to owe me? lol | 14:53 |
| rm_work | Just fix it on my CR if you think it's so easy :D if you try it though, you'll see what I mean | 14:54 |
| johnsom | Challenge accepted. However you will need to call me "The most excellent johnsom" for at least a week. | 14:58 |
| * johnsom notes that he was awake way too early for a meeting that ended up cancelled and has not had his coffee yet. | 14:59 | |
| *** TrevorV has joined #openstack-lbaas | 15:00 | |
| rm_work | Hey if you make it work and then give me some +2s I'll call you whatever you want :D | 15:01 |
| *** pcaruana has quit IRC | 15:02 | |
| *** pcaruana has joined #openstack-lbaas | 15:20 | |
| haleyb | gmann: don't know whether to continue in nova channel, but the recheck failed on the grenade, https://storage.bhs1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9e4/693486/4/check/octavia-grenade/9e4bdff/logs/grenade.sh.txt.gz | 15:51 |
| *** sapd1 has joined #openstack-lbaas | 16:12 | |
| haleyb | gmann: actually, look at https://bugs.launchpad.net/grenade/+bug/1805156 and related change, i was going to propose a patch to pip install osc-placement in the nova upgrade script | 16:22 |
| openstack | Launchpad bug 1805156 in grenade "In a python3 grenade run, openstack client plugins are lost after swift install" [Undecided,Fix released] - Assigned to Chris Dent (cdent) | 16:22 |
| openstackgerrit | Brian Haley proposed openstack/octavia master: Make octavia-grenade job use python3 https://review.opendev.org/693486 | 16:24 |
| *** ricolin has quit IRC | 16:39 | |
| *** sapd1 has quit IRC | 16:56 | |
| *** rpittau is now known as rpittau|afk | 17:06 | |
| *** ccamposr has joined #openstack-lbaas | 17:07 | |
| *** ccamposr__ has quit IRC | 17:11 | |
| *** goldyfruit_ has joined #openstack-lbaas | 17:14 | |
| *** goldyfruit has quit IRC | 17:17 | |
| *** AlexStaf has quit IRC | 17:20 | |
| *** gcheresh has quit IRC | 17:26 | |
| *** pcaruana has quit IRC | 17:51 | |
| *** pcaruana has joined #openstack-lbaas | 18:14 | |
| *** armax has quit IRC | 18:20 | |
| *** gmann is now known as gmann_afk | 18:38 | |
| *** pcaruana has quit IRC | 18:42 | |
| *** mloza has joined #openstack-lbaas | 18:51 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: DNM: Example intermediate patch https://review.opendev.org/695553 | 18:53 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: DNM: Example intermediate patch https://review.opendev.org/695553 | 18:54 |
| openstackgerrit | Michael Johnson proposed openstack/octavia-lib master: Add availability_zone to the LoadBalancer model https://review.opendev.org/694707 | 18:58 |
| *** armax has joined #openstack-lbaas | 19:01 | |
| *** pcaruana has joined #openstack-lbaas | 19:06 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: DNM: Example intermediate patch https://review.opendev.org/695553 | 19:25 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: DNM: Example intermediate patch https://review.opendev.org/695553 | 19:27 |
| openstackgerrit | Michael Johnson proposed openstack/octavia-lib master: Add availability_zone to the LoadBalancer model https://review.opendev.org/694707 | 19:27 |
| openstackgerrit | Michael Johnson proposed openstack/octavia-lib master: Add availability_zone to the LoadBalancer model https://review.opendev.org/694707 | 19:41 |
| *** openstackstatus has quit IRC | 19:50 | |
| *** Trevor_V has joined #openstack-lbaas | 19:50 | |
| *** TrevorV has quit IRC | 19:50 | |
| *** openstackstatus has joined #openstack-lbaas | 19:51 | |
| *** ChanServ sets mode: +v openstackstatus | 19:51 | |
| *** gmann_afk is now known as gmann | 20:45 | |
| *** spatel has joined #openstack-lbaas | 20:48 | |
| *** spatel has quit IRC | 21:00 | |
| *** openstack has joined #openstack-lbaas | 21:17 | |
| *** ChanServ sets mode: +o openstack | 21:17 | |
| *** pcaruana has quit IRC | 21:25 | |
| *** gcheresh has joined #openstack-lbaas | 21:32 | |
| *** gcheresh has quit IRC | 21:38 | |
| *** ramishra has quit IRC | 21:57 | |
| *** abaindur has quit IRC | 22:05 | |
| *** rcernin has joined #openstack-lbaas | 22:09 | |
| Trevor_V | Hey guys! Could I bother one of you to let me know if we're supposed to start deploying Octavia without the neutron lbaas plugin enabled? | 22:13 |
| johnsom | neutron-lbaas is end-of-life.... https://github.com/openstack/neutron-lbaas | 22:13 |
| johnsom | As of Pike you do not need neutron-lbaas to run Octavia | 22:14 |
| johnsom | There is also an FAQ here: https://wiki.openstack.org/wiki/Neutron/LBaaS/Deprecation | 22:14 |
| Trevor_V | Oh goody! Guess I did some dumb stuff then... lol | 22:14 |
| Trevor_V | Hmm... I'm gonna mess with some stuff, then. | 22:16 |
| Trevor_V | johnsom do I still use a service entry in the neutron conf to point to octavia? | 22:18 |
| johnsom | No | 22:18 |
| Trevor_V | There lies my bad assumption. | 22:18 |
| johnsom | There is no configuration required in neutron for LBaaS any longer | 22:18 |
| Trevor_V | johnsom thanks, much appreciated. | 22:19 |
| johnsom | NP | 22:19 |
| johnsom | rm_work Since I was wrong on the re-ordering thing you get some coveted review cycles.... | 22:31 |
| *** sapd1 has joined #openstack-lbaas | 23:09 | |
| sorrison | johnsom: So there is a circular dependency with octavia and octavia-lib? (Sorry in the office today and lost my IRC history) | 23:12 |
| johnsom | Yeah, there is in the driver utils in octavia and the data model in octavia-lib. | 23:12 |
| johnsom | I put the patches back the way they were and started reviewing. | 23:12 |
| johnsom | I thought I could get around it, but my plan didn't work. It did have the side effect of validating the code though. | 23:13 |
| johnsom | So I didn't completely waste my time. | 23:13 |
| johnsom | I'm 35 out of 69 files in the first octavia patch. It will need an update. | 23:14 |
| johnsom | I think the octavia-lib side all looked good. I have already reviewed that chain | 23:15 |
| sorrison | ok thanks | 23:33 |
| johnsom | Ok, I have made a review pass across the API patch | 23:49 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!