| *** mixos has joined #openstack-lbaas | 02:13 | |
| *** mixos has quit IRC | 02:14 | |
| *** rcernin has quit IRC | 05:40 | |
| *** rcernin has joined #openstack-lbaas | 05:41 | |
| *** rcernin has quit IRC | 05:41 | |
| *** rcernin has joined #openstack-lbaas | 05:42 | |
| *** rcernin has quit IRC | 05:42 | |
| *** rcernin has joined #openstack-lbaas | 05:47 | |
| *** armax has quit IRC | 05:53 | |
| *** rcernin has quit IRC | 06:02 | |
| *** rcernin has joined #openstack-lbaas | 06:02 | |
| *** rcernin has quit IRC | 06:05 | |
| *** rcernin has joined #openstack-lbaas | 06:05 | |
| *** gcheresh has joined #openstack-lbaas | 07:00 | |
| *** gcheresh has quit IRC | 07:09 | |
| *** gcheresh has joined #openstack-lbaas | 07:48 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 07:56 | |
| *** vishalmanchanda has joined #openstack-lbaas | 07:56 | |
| *** sapd1 has joined #openstack-lbaas | 07:57 | |
| openstackgerrit | Maciej Józefczyk proposed openstack/octavia-tempest-plugin master: Do not use requests.session in _wait_for_lb_functional() https://review.opendev.org/713826 | 07:59 |
|---|---|---|
| *** guilhermesp has quit IRC | 08:06 | |
| *** dmellado has quit IRC | 08:06 | |
| *** dmellado has joined #openstack-lbaas | 08:10 | |
| *** tkajinam has quit IRC | 08:19 | |
| *** rpittau|afk is now known as rpittau | 08:26 | |
| *** ataraday_ has joined #openstack-lbaas | 08:37 | |
| ataraday_ | cgoncalves, are you around? Octavia does not have any healthchecks for controller services(worker, hm-manager and hk), am I right? | 08:58 |
| cgoncalves | ataraday_, hi. they do not, no. | 09:14 |
| cgoncalves | the API service now has: https://review.opendev.org/#/c/711127/ | 09:15 |
| *** ccamposr has quit IRC | 09:29 | |
| *** ccamposr has joined #openstack-lbaas | 09:29 | |
| ataraday_ | cgoncalves, yes, I saw that one, and no plans for something like this either? | 09:35 |
| cgoncalves | not that I am aware of. sorrison may have | 09:41 |
| *** rcernin has quit IRC | 09:51 | |
| *** spatel has joined #openstack-lbaas | 10:59 | |
| *** spatel has quit IRC | 11:03 | |
| *** rpittau is now known as rpittau|bbl | 11:45 | |
| *** gcheresh has quit IRC | 12:30 | |
| *** sapd1 has quit IRC | 12:36 | |
| *** spatel has joined #openstack-lbaas | 12:47 | |
| *** spatel has quit IRC | 12:52 | |
| *** ataraday_ has quit IRC | 13:09 | |
| *** rpittau|bbl is now known as rpittau | 13:10 | |
| *** tkajinam has joined #openstack-lbaas | 13:22 | |
| *** gcheresh has joined #openstack-lbaas | 13:49 | |
| *** TrevorV has joined #openstack-lbaas | 14:15 | |
| johnsom | ataraday_ There have been discussions at the PTG about this, including replacing the library we just used. However, those efforts have stalled. Other than systemd monitoring, the processes are on their own to recover or remove themselves from rotation. | 14:22 |
| *** sapd1 has joined #openstack-lbaas | 14:28 | |
| *** dulek has quit IRC | 14:30 | |
| *** dulek has joined #openstack-lbaas | 14:33 | |
| *** armax has joined #openstack-lbaas | 14:43 | |
| ivve | when using dvr-snat mode, a flip created for a LB always ends up in the snat-<uuid> namespace correct? no matter if its standalone or active_passive ? | 14:52 |
| johnsom | ivve That would be a question for the #openstack-neutron channel, both FLIP and DVR are outside of the Octavia space and not required for Octavia load blancers. | 14:56 |
| ivve | cool thanks | 14:58 |
| *** KeithMnemonic has quit IRC | 15:13 | |
| *** gcheresh has quit IRC | 15:15 | |
| *** tkajinam has quit IRC | 15:30 | |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715246 | 15:33 |
| *** sapd1 has quit IRC | 15:36 | |
| *** sapd1 has joined #openstack-lbaas | 15:49 | |
| *** gcheresh has joined #openstack-lbaas | 16:13 | |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 16:41 |
| *** gcheresh has quit IRC | 16:47 | |
| *** rpittau is now known as rpittau|afk | 17:12 | |
| nmickus | johnsom I pushed up a new octavia-lib patch with the updated data models, constants and test models but it still fails most of the tests | 17:29 |
| johnsom | Ok, I can have a look and see if I can help | 17:30 |
| johnsom | nmickus So looking at the test results: https://5c1017bc1b5783925aff-bb1c7e0df0c2b154f674f44976092bb9.ssl.cf1.rackcdn.com/715263/1/check/openstack-tox-py36/97b009b/testr_results.html | 17:31 |
| johnsom | I see in the actual results tls_ciphers is included, but the reference data does not have it | 17:32 |
| nmickus | What do I need to do to fix that? | 17:33 |
| johnsom | So, it's this check failing: https://github.com/openstack/octavia-lib/blob/master/octavia_lib/tests/unit/api/drivers/test_data_models.py#L354 | 17:41 |
| johnsom | So ref_list_dict will need to be updated | 17:41 |
| johnsom | nmickus Commented | 17:49 |
| *** openstack has quit IRC | 17:49 | |
| *** openstack has joined #openstack-lbaas | 17:53 | |
| *** ChanServ sets mode: +o openstack | 17:53 | |
| nmickus | I can but sometimes it acts weird earlier today i ran the full suite and pep8 failed but when i ran pep8 by itself it passed | 18:02 |
| rm_work | uhh | 18:03 |
| rm_work | yeah that's super weird, they should be totally independent | 18:03 |
| nmickus | It was like a one time thing which was the weirdest part | 18:06 |
| nmickus | Docs is failing with `RSVG converter command 'rsvg-convert' cannot be run. Check the rsvg_converter_bin setting` which I cant seem to find in the code base | 18:17 |
| johnsom | nmickus That is a tool used by the documentation build. install librsvg2-bin | 18:27 |
| johnsom | yum/dnf/apt-get | 18:27 |
| rm_work | `brew install librsvg` for the OSX inclined | 18:34 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 18:41 |
| nmickus | I added the second patch set, it passed all tests on my machine | 18:43 |
| *** gcheresh has joined #openstack-lbaas | 19:01 | |
| *** maciejjozefczyk has quit IRC | 19:02 | |
| nmickus | johnsom I can't seem to hunt down the error causing the fail in functional-py37-tips | 19:19 |
| johnsom | looking | 19:20 |
| johnsom | nmickus I think that is our problem with the test setup. I think you can ignore that test for now | 19:23 |
| johnsom | nmickus That patch looks good, were there any other changes you wanted to make to it? | 19:25 |
| nmickus | Nope it's ready to go on my part | 19:27 |
| johnsom | Ok, I will flip that test over to non-voting. We got ourselves into a chicken-egg problem with that test that we haven't come back and addressed yet. | 19:27 |
| nmickus | alright glad we got it done | 19:28 |
| openstackgerrit | Michael Johnson proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 19:31 |
| johnsom | nmickus Can you add a release note that mentions the new parameter? | 19:32 |
| nmickus | yes | 19:32 |
| johnsom | Thanks! Other than that I think it is good to go | 19:33 |
| nmickus | do i need to pull down your patch? or can i just update mine? | 19:35 |
| johnsom | Ah, you will need to update mine, or make the same change in your local and push it up | 19:35 |
| nmickus | alright then to make sure its added to the same patch i just include the change id | 19:38 |
| johnsom | Yeah, once the change id is added, you should never remove or change it. | 19:39 |
| *** gcheresh has quit IRC | 19:50 | |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 20:33 |
| *** Trevor_V has joined #openstack-lbaas | 20:33 | |
| nmickus | johnsom rm_work Should Be ready | 20:34 |
| nmickus | octavia-lib ciphers list patch | 20:34 |
| *** TrevorV has quit IRC | 20:37 | |
| johnsom | nmickus Cool, thanks! Will have a look | 20:41 |
| johnsom | This was announced right after our weekly meeting so wasn't in the announcements but: | 20:52 |
| johnsom | It is PTL and TC election season once again: | 20:52 |
| johnsom | http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013597.html | 20:52 |
| johnsom | If you are interested, please see the above link or the openstack-discuss mailing list post for details. | 20:53 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 21:32 |
| nmickus | johnsom fixed the typos | 21:33 |
| johnsom | nmickus Yep, but deleted all of the tests.... | 21:34 |
| nmickus | I thought i removed it from git... | 21:35 |
| johnsom | You did. "git rm" removes the file from git, not the commit. | 21:36 |
| nmickus | Oh | 21:36 |
| johnsom | Just restore the version from my commit in patchset 3 | 21:38 |
| rm_work | my workflow WHENEVER i'm about to work on a patch (using your CR# as an example): | 21:42 |
| rm_work | alias gitmaster='git reset --hard HEAD && git checkout master && git branch --set-upstream-to origin/master && git reset --hard origin/master' | 21:42 |
| rm_work | gitmaster | 21:42 |
| rm_work | git review -x 715263 | 21:42 |
| rm_work | <make changes> | 21:43 |
| rm_work | git commit -a --amend | 21:43 |
| rm_work | git review | 21:43 |
| rm_work | that ^^ should basically ensure nothing can ever go wrong | 21:43 |
| rm_work | be careful with that alias though, that's a giant bomb of "where'd all my work go" if you're not paying attention and haven't pushed stuff <_< | 21:43 |
| rm_work | or at least committed it... `git reflog` is your friend if you lose work you've at least committed locally | 21:44 |
| nmickus | so is that the set of commands i should run | 21:44 |
| rm_work | lesson one: never copy/paste stuff directly from people on the internet until you read and understand it :D | 21:44 |
| rm_work | I recommend you check out the git manpages and understand fully what that alias is doing, and then you'll be in a much better place (all of those are very useful commands) | 21:45 |
| johnsom | I do it slightly differently, but the end result is the same. | 21:46 |
| nmickus | alright I'll check it out | 21:46 |
| rm_work | as far as `git review -x` that is just a shortcut for "cherry-pick the upstream CR#" | 21:46 |
| nmickus | yeah i figured that | 21:47 |
| rm_work | oh, might want to do a "git pull" after running gitmaster or some similar thing | 21:47 |
| rm_work | the whole point of that is "get me to a clean spot as though i'd just cloned the repo for the first time" | 21:48 |
| nmickus | so the alias is basically just resetting everything to master | 21:53 |
| rm_work | yep | 21:53 |
| rm_work | from whatever f'd up state you've gotten your repo into :D | 21:53 |
| rm_work | like, on some weird branch, with a bunch of random changes you don't want | 21:54 |
| johnsom | Yeah, I just clone a fresh repo. I tend to use more repos than others. | 21:54 |
| rm_work | heh | 21:54 |
| rm_work | given the frequency with which i do that, i'd need an alias to clone a new repo with an auto-incrementing number into my workspace dir, and then cd into it for me | 21:54 |
| rm_work | and i'd be in the 6 digits by now | 21:55 |
| johnsom | Oh, I have an alias too | 21:55 |
| johnsom | I have 151 right now. Getting close to time to clean out the stale ones | 21:55 |
| nmickus | is there a way to make sure i pull a specific patch set? | 21:55 |
| johnsom | You want a specifc patchset from a commit. | 21:56 |
| johnsom | I usually just use the gerrit web page. You can select the patchset, then in the download drop down it will have the commands to checkout/pull/cherry pick, etc. | 21:57 |
| johnsom | I don't remember the way to do it with git review, Adam probably knows | 21:58 |
| johnsom | or do "git review --help" | 21:58 |
| nmickus | Alright i got the patch thanks for the help I'll try not to ruin this one | 22:01 |
| johnsom | Ha, that was far from ruined. Much worse has happened | 22:02 |
| nmickus | I'm sure | 22:03 |
| nmickus | In the commit message it has the the projects.yaml file marked as modified under changes to be committed do I need to do anything about it? | 22:16 |
| nmickus | johnsom | 22:18 |
| johnsom | No, those should all be in comment lines right? | 22:19 |
| nmickus | I would assume so i just wanted to make sure | 22:19 |
| johnsom | It needs to be in the commit to restore the file deleted in a previous patchset | 22:20 |
| nmickus | alright | 22:20 |
| johnsom | If it's wrong it's just another patch. grin | 22:20 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 22:20 |
| johnsom | Ok, so two things happened on that round. | 22:22 |
| nmickus | oh boy | 22:22 |
| johnsom | the file permissions changed on the projects.yaml file, but it has the correct contents. | 22:22 |
| nmickus | ok that's not as bad | 22:23 |
| johnsom | The other is you reverted your fixes for the ordering of the changes in test_data_models.py and constants.py | 22:23 |
| sorrison | ataraday_: What kind of health checks were you thinking for other services? We just monitor these by seeing if the process is there and also we monitor queue lengths in rabbit | 22:23 |
| nmickus | ok easy fix what should the permissions be set for the projects | 22:23 |
| *** rcernin has joined #openstack-lbaas | 22:25 | |
| johnsom | nmickus Actually, the permissions look fine now. I think it was just gerrit tricking me | 22:25 |
| johnsom | Yeah, it was just patchset 4, so nevermind on the permissions. Just the order issues Brian asked for | 22:27 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 22:36 |
| nmickus | johnsom I think that's it | 22:36 |
| johnsom | nmickus Yep, looks good to me | 22:37 |
| *** tkajinam has joined #openstack-lbaas | 22:54 | |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 23:01 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 23:03 |
| nmickus | johnsom try that apparently my brain is a bit fried | 23:04 |
| nmickus | may have failed pep8 | 23:04 |
| *** Trevor_V has quit IRC | 23:05 | |
| *** rcernin has quit IRC | 23:06 | |
| *** rcernin has joined #openstack-lbaas | 23:07 | |
| *** rcernin has quit IRC | 23:07 | |
| openstackgerrit | Sam Morrison proposed openstack/octavia-dashboard master: Availability zone support https://review.opendev.org/714563 | 23:08 |
| *** rcernin has joined #openstack-lbaas | 23:08 | |
| johnsom | nmickus Yep, looks fine. | 23:15 |
| *** vishalmanchanda has quit IRC | 23:39 | |
| openstackgerrit | Luke Tollefson proposed openstack/octavia-lib master: Add TLS protocol support for listener model https://review.opendev.org/715329 | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!