| *** eandersson8 has joined #openstack-lbaas | 01:00 | |
| *** eandersson has quit IRC | 01:01 | |
| *** eandersson8 is now known as eandersson | 01:01 | |
| *** sapd1 has quit IRC | 01:22 | |
| openstackgerrit | Brian Haley proposed openstack/octavia-tempest-plugin master: Change to use memory_tracker variable https://review.opendev.org/704202 | 01:32 |
|---|---|---|
| openstackgerrit | Brian Haley proposed openstack/octavia master: Make octavia-grenade job use python3 https://review.opendev.org/693486 | 01:34 |
| openstackgerrit | Brian Haley proposed openstack/octavia stable/queens: Fix the interface filenames for Red Hat amphora images https://review.opendev.org/704664 | 01:38 |
| *** sapd1 has joined #openstack-lbaas | 01:46 | |
| *** armax has quit IRC | 02:06 | |
| *** sapd1_x has joined #openstack-lbaas | 02:39 | |
| *** psachin has joined #openstack-lbaas | 03:40 | |
| sorrison | johnsom rm_work: Think openstacksdk patch for AZs is ready now https://review.opendev.org/#/c/714345/ | 03:58 |
| *** mloza has quit IRC | 04:45 | |
| *** haleyb has quit IRC | 04:46 | |
| *** sapd1 has quit IRC | 05:04 | |
| *** sapd1_y has joined #openstack-lbaas | 05:04 | |
| *** gcheresh has joined #openstack-lbaas | 05:55 | |
| *** gcheresh has quit IRC | 06:50 | |
| *** gcheresh has joined #openstack-lbaas | 07:06 | |
| *** vishalmanchanda has joined #openstack-lbaas | 07:16 | |
| *** gcheresh has quit IRC | 07:28 | |
| *** maciejjozefczyk has joined #openstack-lbaas | 07:34 | |
| *** sapd1_y has quit IRC | 07:37 | |
| *** psachin has quit IRC | 08:04 | |
| *** tkajinam has quit IRC | 08:18 | |
| *** rpittau|afk is now known as rpittau | 08:23 | |
| *** takamatsu has joined #openstack-lbaas | 09:38 | |
| *** ccamposr__ has joined #openstack-lbaas | 09:47 | |
| *** ccamposr has quit IRC | 09:49 | |
| *** gcheresh has joined #openstack-lbaas | 10:00 | |
| *** spatel has joined #openstack-lbaas | 10:57 | |
| *** ccamposr__ has quit IRC | 10:59 | |
| *** spatel has quit IRC | 11:01 | |
| *** tkajinam has joined #openstack-lbaas | 11:04 | |
| *** rpittau is now known as rpittau|bbl | 11:32 | |
| *** yamamoto has joined #openstack-lbaas | 11:35 | |
| *** sapd1_x has quit IRC | 11:37 | |
| *** ccamposr has joined #openstack-lbaas | 11:43 | |
| *** ccamposr__ has joined #openstack-lbaas | 11:46 | |
| *** sapd1 has joined #openstack-lbaas | 11:46 | |
| *** ccamposr has quit IRC | 11:47 | |
| *** ccamposr__ has quit IRC | 11:49 | |
| *** ccamposr__ has joined #openstack-lbaas | 11:49 | |
| *** sapd1_x has joined #openstack-lbaas | 11:55 | |
| *** takamatsu has quit IRC | 11:56 | |
| *** armax has joined #openstack-lbaas | 12:23 | |
| *** yamamoto has quit IRC | 12:51 | |
| *** spatel has joined #openstack-lbaas | 13:00 | |
| *** openstackstatus has quit IRC | 13:01 | |
| *** openstack has joined #openstack-lbaas | 13:05 | |
| *** ChanServ sets mode: +o openstack | 13:05 | |
| *** yamamoto has joined #openstack-lbaas | 13:06 | |
| *** rpittau|bbl is now known as rpittau | 13:10 | |
| *** dayou has joined #openstack-lbaas | 13:14 | |
| *** rcernin has quit IRC | 13:23 | |
| *** tkajinam has quit IRC | 13:25 | |
| *** haleyb has joined #openstack-lbaas | 13:26 | |
| *** TrevorV has joined #openstack-lbaas | 13:34 | |
| *** yamamoto has quit IRC | 13:43 | |
| *** yamamoto has joined #openstack-lbaas | 13:44 | |
| *** yamamoto has quit IRC | 13:44 | |
| *** yamamoto has joined #openstack-lbaas | 13:45 | |
| *** sapd1_x has quit IRC | 13:46 | |
| *** yamamoto has quit IRC | 13:50 | |
| *** yamamoto has joined #openstack-lbaas | 13:51 | |
| *** gcheresh has quit IRC | 14:08 | |
| *** gcheresh has joined #openstack-lbaas | 14:17 | |
| *** vishalmanchanda has quit IRC | 14:32 | |
| *** yamamoto has quit IRC | 14:41 | |
| *** yamamoto has joined #openstack-lbaas | 14:41 | |
| *** sapd1_x has joined #openstack-lbaas | 14:42 | |
| *** yamamoto has quit IRC | 14:46 | |
| johnsom | sorrison +W'd | 15:14 |
| *** yamamoto has joined #openstack-lbaas | 15:20 | |
| cgoncalves | someone got yet another core badge ;) | 15:22 |
| johnsom | Oye | 15:23 |
| openstackgerrit | Merged openstack/octavia master: Fix TESTING.rst example https://review.opendev.org/708530 | 15:31 |
| rm_work | :P | 16:01 |
| *** gcheresh has quit IRC | 16:23 | |
| *** yamamoto has quit IRC | 16:43 | |
| *** maciejjozefczyk has quit IRC | 16:43 | |
| rm_work | nmickus: Hey, could you do one more run on https://review.opendev.org/#/c/715263/ just to address those last couple of minor bits? | 17:24 |
| rm_work | the file permissions and haleyb's releasenotes comments | 17:24 |
| rm_work | then I think we can probably workflow this today :) | 17:24 |
| nmickus | i was told the permissions were fine but yeah what do they need to look like | 17:25 |
| rm_work | just -x across the board | 17:25 |
| rm_work | I saw the discussion earlier, but it looks to me like it IS changing the mode... | 17:26 |
| rm_work | seems like just data_models.py, constants.py, and test_data_models.py | 17:26 |
| rm_work | plus wrapping the ``tls_ciphers`` in those double-backticks in the releasenotes | 17:27 |
| nmickus | got it just chmod -x <filename>? | 17:27 |
| rm_work | i believe so, or oga-x maybe | 17:28 |
| rm_work | not sure what the default is actually for -x | 17:28 |
| rm_work | or just looking at the file, the old mode was 644 so you could set it explicitly :D | 17:28 |
| nmickus | Yep :) | 17:29 |
| rm_work | it would also be nice if you could stack another commit on top of it, that just adds back the -tips job, and has a Depends-On for the patch on the main repo that will fix it | 17:32 |
| rm_work | (johnsom, I assume I am thinking about that right?) | 17:33 |
| johnsom | rm_work I'm not sure about the tips job, we need to think about that more, as every lib patch that add a field is going to have this problem | 17:34 |
| rm_work | yeah :/ | 17:34 |
| nmickus | Should i just leave it for now then? | 17:37 |
| johnsom | Yeah, let's just leave it disabled for now. | 17:41 |
| rm_work | i might like to at least see it non-voting | 17:41 |
| johnsom | That is fair I guess | 17:41 |
| rm_work | though it'll just be broken until the other patch merges, but at least we won't forget about it | 17:41 |
| rm_work | my biggest worry is we'll just straight up *forget* to deal with it again | 17:41 |
| rm_work | in fact you could just do it that way in this same patch | 17:42 |
| rm_work | instead of removing it | 17:42 |
| nmickus | How would one do that? | 17:43 |
| rm_work | just add a colon and then voting:false | 17:53 |
| rm_work | like: https://github.com/openstack/octavia/blob/master/zuul.d/projects.yaml#L40 | 17:54 |
| rm_work | (ignore the "irrelevant-files" line) | 17:54 |
| nmickus | Alright anything else before I git review? | 17:58 |
| rm_work | johnsom / ataraday: I think I am good with the jobboard controller landing :D | 17:58 |
| rm_work | nmickus: that should be it, if you got the perms and brian's comments | 17:58 |
| johnsom | rm_work I have not had time to look at it yet | 17:59 |
| rm_work | k | 17:59 |
| johnsom | But I am one of many voices, so.... | 17:59 |
| *** TrevorV has quit IRC | 18:01 | |
| openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add F5 Networks provider driver by SAP SE https://review.opendev.org/715498 | 18:06 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 18:09 |
| *** sapd1_x has quit IRC | 18:12 | |
| nmickus | rm_work zuul didn't like my syntax did I miss something | 18:16 |
| nmickus | http://paste.openstack.org/show/791248/ | 18:16 |
| rm_work | looking... | 18:16 |
| rm_work | yeah, bad indent | 18:16 |
| rm_work | you used a literal tab character | 18:17 |
| nmickus | need to use spaces? | 18:17 |
| rm_work | that's what the little red double-arrow mark means | 18:17 |
| rm_work | yep, spaces only | 18:17 |
| rm_work | and it's indented two spaces from the first character of the job name (not the dash) | 18:17 |
| nmickus | got it ty | 18:18 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 18:21 |
| rm_work | hmm did i give you bad advice... | 18:29 |
| rm_work | crap, voting:false may not work for templates? | 18:29 |
| nmickus | I wouldn't know | 18:29 |
| rm_work | my typical strategy here is to go ask in #opendev :D | 18:30 |
| johnsom | Right, it does not work for templates. | 18:30 |
| johnsom | That is why I deleted it. (sorry, forgot) | 18:30 |
| rm_work | lolol ok | 18:30 |
| rm_work | so is there a way around that? | 18:30 |
| rm_work | can we override it in the jobs section? | 18:30 |
| rm_work | using the template's job name? | 18:31 |
| rm_work | whatever, asking in opendev | 18:32 |
| rm_work | there you go nmickus :D asked and answered | 18:33 |
| *** ramishra has quit IRC | 18:33 | |
| rm_work | i'd try first with an override approach -- leave the template, add the jobs section and that specific job name | 18:34 |
| nmickus | same way it is in the file you sent earlier? | 18:35 |
| rm_work | yeah | 18:36 |
| rm_work | so put the template line back to normal, and then add jobs: | 18:36 |
| rm_work | and that one job name (it isn't the same as the template name) | 18:36 |
| rm_work | https://github.com/openstack/octavia/blob/master/zuul.d/jobs.yaml#L87-L89 | 18:36 |
| rm_work | I guess only functional needs to be nonvoting? | 18:37 |
| rm_work | so you'd just add `- octavia-tox-functional-py37-tips:` as voting: false | 18:37 |
| rm_work | well, let me see | 18:37 |
| rm_work | I THINK that's right | 18:38 |
| nmickus | rm_work Like this? http://paste.openstack.org/show/791249/ | 18:42 |
| rm_work | ah no, the first tips line should still be in templates | 18:42 |
| rm_work | but the second one is right (though the voting part is too indented?) | 18:43 |
| rm_work | err | 18:43 |
| rm_work | sorry, i meant rather than list the first job, just keep the template | 18:43 |
| rm_work | and treat the second job definition as an override, i believe that should work | 18:43 |
| *** spatel has quit IRC | 18:44 | |
| nmickus | so the first line under jobs needs to be readded under the template? | 18:44 |
| rm_work | well it's technically slightly different, but yes | 18:45 |
| rm_work | i think that's what I'd do | 18:45 |
| nmickus | I'm starting to get confused so does this look right? | 18:46 |
| nmickus | http://paste.openstack.org/show/791250/ | 18:46 |
| rm_work | heh | 18:46 |
| rm_work | more like http://paste.openstack.org/show/791251/ | 18:47 |
| nmickus | alright here we go agian | 18:48 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 18:49 |
| rm_work | ah whoops and i led you astray again because i didn't read | 18:51 |
| rm_work | https://github.com/openstack/octavia/blob/master/zuul.d/projects.yaml#L13-L14 | 18:51 |
| nmickus | ope | 18:51 |
| rm_work | lol | 18:51 |
| rm_work | this is what I get for trying to multitask | 18:51 |
| nmickus | add `check:` above jobs | 18:52 |
| nmickus | ? | 18:52 |
| rm_work | yeah | 18:52 |
| rm_work | and all that gets indented in one level then | 18:53 |
| rm_work | welcome to "guess&check: zuul edition" | 18:53 |
| rm_work | i'll be your host | 18:53 |
| nmickus | maybe this will be my stop | 18:56 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 18:56 |
| *** rpittau is now known as rpittau|afk | 18:57 | |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 18:58 |
| rm_work | ah the template name is `octavia-tox-tips` | 18:59 |
| rm_work | otherwise basically there :D | 18:59 |
| *** gmann is now known as gmann_lunch | 18:59 | |
| nmickus | just under jobs? | 18:59 |
| rm_work | no, the one above check, like 9 | 19:00 |
| rm_work | *line 9 | 19:00 |
| openstackgerrit | Noah Mickus proposed openstack/octavia-lib master: Adding cipher list Support for provider drivers https://review.opendev.org/715263 | 19:01 |
| rm_work | woo | 19:01 |
| rm_work | looks right, jobs running :) | 19:01 |
| nmickus | so many patches | 19:02 |
| johnsom | That happens when you are starting out. | 19:03 |
| rm_work | it might be time to drop .... combined-listeners? split-listeners? which one do we not use by default? lol | 19:06 |
| rm_work | I think I just kept the old one when we switched so it'd be clear what the change was, but it's been a while and it's a bit of maintenance overhead / duplication | 19:06 |
| rm_work | i doubt anyone actually switches it to use the non-default one | 19:06 |
| rm_work | johnsom: i had a question for YOU on https://review.opendev.org/#/c/711376/3/octavia/api/v2/types/listener.py@154 | 19:16 |
| johnsom | Don't we only use stypes.wsattr when it's one of our custom types? | 19:24 |
| rm_work | uhh, i mean, look at the other examples there | 19:25 |
| rm_work | i see String used that way along with a bunch of others | 19:25 |
| johnsom | A wsattr – This allows you to add more information about the attribute, for example if it is mandatory. | 19:27 |
| johnsom | If we aren't adding extra wrapper things, I don't think we need it. | 19:27 |
| johnsom | Like you would only use it if it was a required field | 19:28 |
| *** gmann_lunch is now known as gmann | 19:29 | |
| johnsom | Or had a default value | 19:29 |
| johnsom | So, I think the patch is correct, but some of those others might not be | 19:29 |
| johnsom | Plus, we don't use defaults there really, it's better to set the default in the controller | 19:30 |
| dawzon | I've noticed that the tls_ciphers and tls_protocols patches to octavia-lib are causing test fails in octavia-tox-functional-py37-tips, but the reference data used for the failing tests is in the main octavia repo, so is it even possible to fix that in one patch? | 19:42 |
| johnsom | dawzon That is what Noah was talking about earlier. We just disabled that job as it's a testing loop. | 19:43 |
| *** gcheresh has joined #openstack-lbaas | 20:20 | |
| *** gcheresh has quit IRC | 22:02 | |
| *** yamamoto has joined #openstack-lbaas | 22:41 | |
| *** yamamoto has quit IRC | 22:45 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!