Wednesday, 2022-09-28

*** ysandeep|out is now known as ysandeep01:45
*** ysandeep is now known as ysandeep|afk03:42
*** ysandeep|afk is now known as ysandeep05:14
*** ysandeep is now known as ysandeep|sick08:27
matfechnerwindow 115:50
gthiemonge#startmeeting Octavia16:00
opendevmeetMeeting started Wed Sep 28 16:00:20 2022 UTC and is due to finish in 60 minutes.  The chair is gthiemonge. Information about MeetBot at
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'octavia'16:00
gthiemonge#topic Announcements16:04
gthiemongeI have no announcement this week, we are good with the RC1 for Zed (this week is the deadline for final RCs)16:04
tweiningno news is good news16:05
gthiemonge#topic CI Status16:07
gthiemongeregarding the CI, we still have those tests that are randomly failing on stable branches16:08
gthiemongewe need to review/approve this backport:
gthiemonge(I'll take a look after the meeting)16:08
gthiemongejohnsom: maybe you can also review them?16:09
gthiemonge#topic Brief progress reports / bugs needing review16:12
gthiemongeI proposed a fix for a bug reported on storyboard: Octavia raises an exceptino when deleting a listener that has a deleted certificate16:13
johnsomWe should ping barbican team again on getting the register feature working for secrets.16:13
gthiemongejohnsom: what's that?16:14
johnsomSo, when we used barbican "containers" to store certs, we "registered" that it was in-use with barbican so it could not be deleted.16:14
dmendiza[m]johnsom: the API side implementation landed in Zed16:15
gthiemongeI didn't know that16:15
johnsomWhen we moved to the secrets API for the pkcs12 bundles, they hadn't yet implemented the "register" feature for secrets.16:15
dmendiza[m]johnsom: we're working on the client bits now (including Castellan)16:15
johnsomdmendiza[m] Boom, there we go16:15
johnsomSo we should add an RFE to implement that API in Octavia16:16
QGis this feature : ?16:16
johnsomDeleted certs are a problem for failover in addition to deletion.16:16
gthiemongejohnsom: right16:17
johnsomQC That is what we have implemented in Octavia for the old way of handling certs16:17
gthiemongethat's intersting16:17
QGjohnsom: the old way ? 16:17
johnsomQG Yes, the method that does not use pkcs12 files.16:18
johnsomIt still works, but is deprecated16:18
gthiemongedmendiza[m]: thanks for the update on this ;-)16:19
QGohhhh ok so creating a container with certificate; key and chain is deprecated secrets in it in favor of pkcs12 ?16:19
johnsomThat is the old way16:19
johnsomRight, containers is deprecated in favor of using secrets with pkcs1216:20
QGjohnsom: ok thanks !16:20
johnsomThe switch happened in Queens16:21
QGand why this way has been depreciated ?16:22
johnsomMany user experience issues. For one, it's a heck of a lot more barbican API calls. But also, people would mix the wrong key for the cert in the container. PKCS12 is an industry standard and helps users not make as many mistakes16:23
QGjohnsom: ohhhh ok thanks make sence  :)16:24
johnsomOr not include all of the needed intermediate certs, etc.16:24
johnsomOh, and it is compatible with Vault/castellan where containers are barbican proprietary16:26
johnsomOk, I will stop now, we can keep the meeting moving16:26
tweiningcan you do me a favor and review a one-line change for me please. I added *.orig to .gitignore so that those files cannot get added accidentally after a merge conflict (which happened to me recently)16:27
QGI anyone wanted to test the ability to create Prometheus listener16:28
gthiemongetweining: ack16:28
johnsomtweining Did you propose this on all of the Octavia repos? lib, client, etc?16:28
tweiningjohnsom: no, but I agree that I should16:29
johnsom+1 thanks!16:29
gthiemongeQG: I haven't tested it yet, but I'm going to take a look, and to the ESLint fix too16:29
QGgthiemonge: Thanks !16:29
tweining#action tweining to propose change to add *.orig to .gitignore to other octavia repos like lib, client, etc.16:29
tweiningok, I have one more item, but for the open discussion16:32
gthiemonge#topic Open Discussion16:32
tweiningthanks :)16:32
tweiningso you might have noticed that I worked on a change that adds support for pre-commit to octavia16:33
johnsomThough that might be a duplicate to an existing story16:34
gthiemongejohnsom: the old story is probably lost in storyboard16:34
tweiningit's kind of related to the one line change above. this time it's about avoiding things like trailing spaces in releasenotes yamls, which happens regularly to me16:35
gthiemongetweining: how does it work? we would have to install pre-commit to install those rules?16:35
tweiningpre-commit basically installs pre-push or pre-commit Git hooks that do some checks as configured in the yaml16:36
tweiningit is very flexible. the way my configuration works is that it does basic super-fast checks for each commit, and more complex checks only for each push16:37
tweiningand if pre-commit is not installed this does nothing16:37
johnsomDoesn't black modify the code?16:37
tweiningyes, if it is not formatted yet.16:38
tweiningabout that one I am unsure too.16:38
gthiemongebut only in your patch?16:38
tweiningyes, only changed files AFAIR16:38
tweiningif code is pep8 compliant black should not change it I think16:39
johnsomI think I would prefer to have that in tox somewhere, rather than running at push time.16:39
tweiningok, I can remove that particular check then.16:39
tweiningflake8 should be sufficient anyway for that purpose16:40
tweining(the purpose of rejecting the push operation if the code is not formatted)16:41
gthiemongedoes it take a lot of time? I already run tox -epep8 before sending a patch (it includes flake8)16:42
tweiningin theory we could make it even run tox I think.16:42
johnsomYeah, that is a fair question, are we doubling up16:42
tweiningwe could make it run tox -epep8 instead maybe, or remove it16:43
gthiemongeI'll test the flake8 hook16:43
opendevreviewMerged openstack/octavia-dashboard master: Update master for stable/zed
opendevreviewMerged openstack/octavia-dashboard master: Switch to 2023.1 Python3 unit tests and generic template name
tweiningI don't remember exactly how it works but AFAIR one has to install pre-commit's push hook explicitly or else only the pre-commit hook gets installed. but I can investigate that point.16:44
tweiningI do remember, that in another project I was working on we ran the full test suite with tox using pre-commit16:45
gthiemongetweining: ack, thanks for working on it16:46
tweiningthe other checks are super-fast however16:46
gthiemongetweining: tox in pre-commit, that might be tough :D16:46
tweiningtox -epy3,functional,pep8 seems okay to me16:47
tweiningbut only in pre-push then16:48
gthiemongeyeah I might use that16:48
oschwartTobiko also uses pre-commit hooks
oschwartSo far it was confortable16:49
tweiningyou use mypy checks? cool16:49
oschwartYeah and it runs pretty fast (1-2 seconds)16:50
tweiningbtw. for Fedora pre-commit can be installed via "dnf install pre-commit"16:51
tweiningwhen I had a look at it mypy created a lot of false positives, but I would like to try it out as well at some point16:52
gthiemongegood to know16:52
johnsomYeah, too many linters become a problem. We already get push back on using pylint16:52
tweiningand to install the hooks cd to the Git repo and execute "pre-commit install --hook-type pre-commit --hook-type pre-push"16:53
johnsomIf this will require packages on the developer systems, we should update the contributor guide.16:53
tweiningwithout the arguments it will only install the pre-commit hook16:53
tweiningjohnsom: good point. it's all optional but it makes sense to explain it in the guide at least.16:54
gthiemongeit seems that many projects use it:
gthiemongeok folks, 4min before the hour... any other topics for this meeting?16:56
oschwartCan we close this story!/story/2007429 ? Looking for some low hanging fruits to implements/fix I found it16:57
oschwartNot urgent of course, but it looks to me like we already implemented/fixed it16:57
gthiemongeoschwart: ok, I'll take a look and will mark it as invalid if it is fixed16:58
oschwartgthiemonge thanks16:58
oschwartNothing else from me16:59
gthiemongethank you folks!!17:00
opendevmeetMeeting ended Wed Sep 28 17:00:17 2022 UTC.  Information about MeetBot at . (v 0.1.4)17:00
opendevmeetMinutes (text):
opendevreviewTom Weininger proposed openstack/octavia master: test
tweiningokay, I thought for a second that "git review" might not trigger the pre-push hook, but it does.17:05
opendevreviewMerged openstack/octavia stable/yoga: Fix sporadic unit test failure
opendevreviewMerged openstack/octavia stable/xena: Fix sporadic unit test failure
opendevreviewMerged openstack/octavia stable/wallaby: Fix sporadic unit test failure
opendevreviewAnton Kurbatov proposed openstack/octavia master: Fix full graph loadbalancer creation if jobboard is disabled

Generated by 2.17.3 by Marius Gedminas - find it at!