*** akshai_ has quit IRC | 00:05 | |
*** rhagarty has joined #openstack-manila | 00:10 | |
*** rushil has quit IRC | 00:19 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-manilaclient: Updated from global requirements https://review.openstack.org/244235 | 00:23 |
---|---|---|
*** gouthamr has quit IRC | 00:42 | |
*** jasonsb_ has quit IRC | 00:42 | |
*** jasonsb has joined #openstack-manila | 00:42 | |
*** jasonsb has quit IRC | 00:47 | |
*** rushil has joined #openstack-manila | 00:48 | |
*** rushil has quit IRC | 01:01 | |
*** cknight1 has joined #openstack-manila | 01:10 | |
*** cknight has quit IRC | 01:13 | |
bswartz | csaba: pong | 01:13 |
*** leeantho has quit IRC | 01:21 | |
*** eharney has quit IRC | 01:38 | |
*** gouthamr has joined #openstack-manila | 02:01 | |
*** gouthamr_ has joined #openstack-manila | 02:02 | |
*** rushil has joined #openstack-manila | 02:03 | |
*** gouthamr has quit IRC | 02:05 | |
*** rushil has quit IRC | 02:10 | |
*** jasonsb has joined #openstack-manila | 02:20 | |
openstackgerrit | Merged openstack/manila: Refactor HP 3PAR share driver to now be HPE https://review.openstack.org/240353 | 02:29 |
*** 7JTAA216T has joined #openstack-manila | 02:30 | |
*** 7JTAA216T has quit IRC | 02:30 | |
*** 21WAACTNP has joined #openstack-manila | 02:31 | |
*** 21WAACTNP has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-manila | 03:01 | |
*** lpabon has quit IRC | 03:05 | |
*** jasonsb has quit IRC | 03:33 | |
*** gouthamr_ has quit IRC | 03:37 | |
*** akshai has joined #openstack-manila | 03:44 | |
*** haomaiwang has quit IRC | 04:01 | |
*** haomaiwang has joined #openstack-manila | 04:01 | |
*** jasonsb has joined #openstack-manila | 04:04 | |
*** akerr_ is now known as akerr_away | 04:05 | |
*** dcain has quit IRC | 04:09 | |
*** jasonsb has quit IRC | 04:09 | |
openstackgerrit | NidhiMittalHada proposed openstack/python-manilaclient: Allows type-create to return dict instead of list https://review.openstack.org/245731 | 04:23 |
*** cknight1 has quit IRC | 04:36 | |
*** jasonsb has joined #openstack-manila | 04:52 | |
*** haomaiwang has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-manila | 05:01 | |
*** akshai has quit IRC | 05:05 | |
*** mtanino has quit IRC | 05:09 | |
openstackgerrit | Merged openstack/manila: Prevent Share operations during share migration https://review.openstack.org/233052 | 05:22 |
*** deepakcs has joined #openstack-manila | 05:52 | |
*** yangyapeng has joined #openstack-manila | 05:57 | |
*** haomaiwang has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-manila | 06:01 | |
*** nidhimittalhada has joined #openstack-manila | 06:21 | |
nidhimittalhada | @vponomaryov1 | 06:22 |
nidhimittalhada | manilaclient/common/constants.py" 82 | 06:23 |
nidhimittalhada | in this file we used to keep max_api_version | 06:23 |
nidhimittalhada | i kept it this way | 06:23 |
nidhimittalhada | EXPERIMENTAL_HTTP_HEADER = 'X-OpenStack-Manila-API-Experimental' | 06:23 |
nidhimittalhada | MAX_API_VERSION = '2.7' | 06:23 |
nidhimittalhada | V1_API_VERSION = '1.0' | 06:23 |
nidhimittalhada | V1_SERVICE_TYPE = 'share' | 06:23 |
nidhimittalhada | V2_SERVICE_TYPE = 'sharev2' | 06:23 |
nidhimittalhada | but now latest version of this file doesnt contain MAX_API_VERSION at all | 06:23 |
nidhimittalhada | where can we keep this version now? | 06:23 |
*** lpetrut has joined #openstack-manila | 06:33 | |
*** nidhimittalhada has quit IRC | 06:40 | |
*** haomaiwang has quit IRC | 06:42 | |
*** nidhimittalhada has joined #openstack-manila | 06:48 | |
*** haomaiwang has joined #openstack-manila | 06:49 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-manila | 07:01 | |
*** nkrinner has joined #openstack-manila | 07:14 | |
openstackgerrit | NidhiMittalHada proposed openstack/python-manilaclient: API 'manage' can set share attr 'is_public' https://review.openstack.org/230963 | 07:16 |
*** nidhimittalhada has quit IRC | 07:35 | |
*** akerr has joined #openstack-manila | 07:40 | |
*** netapp has quit IRC | 07:42 | |
*** timcl1 has joined #openstack-manila | 07:42 | |
*** akerr_away has quit IRC | 07:43 | |
*** timcl has quit IRC | 07:43 | |
*** netapp has joined #openstack-manila | 07:48 | |
*** sgotliv_ has quit IRC | 07:56 | |
*** breitz has quit IRC | 07:58 | |
*** breitz1 has joined #openstack-manila | 07:58 | |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-manila | 08:01 | |
*** lpetrut has quit IRC | 08:07 | |
*** lpetrut has joined #openstack-manila | 08:07 | |
*** zhongjun has quit IRC | 08:07 | |
*** zhongjun has joined #openstack-manila | 08:08 | |
*** jvarlamova has joined #openstack-manila | 08:13 | |
*** mkoderer has quit IRC | 08:15 | |
*** mkoderer has joined #openstack-manila | 08:18 | |
*** lpetrut has quit IRC | 08:45 | |
*** akerr_ has joined #openstack-manila | 08:57 | |
*** timcl has joined #openstack-manila | 08:58 | |
*** timcl1 has quit IRC | 08:59 | |
*** akerr has quit IRC | 08:59 | |
*** netapp has quit IRC | 09:00 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-manila | 09:01 | |
*** netapp has joined #openstack-manila | 09:03 | |
*** sgotliv_ has joined #openstack-manila | 09:13 | |
*** akerr has joined #openstack-manila | 09:24 | |
*** akerr_ has quit IRC | 09:26 | |
*** rraja_ has quit IRC | 09:45 | |
*** lpetrut has joined #openstack-manila | 09:52 | |
*** ociuhandu has quit IRC | 10:00 | |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-manila | 10:01 | |
*** martyturner has joined #openstack-manila | 10:02 | |
*** martyturner has quit IRC | 10:06 | |
*** dzamboni has joined #openstack-manila | 10:18 | |
openstackgerrit | Silvan Kaiser proposed openstack/manila: Implements ensure_share() in Quobyte driver https://review.openstack.org/239686 | 10:24 |
*** tpsilva has joined #openstack-manila | 10:36 | |
*** eduardo_ has joined #openstack-manila | 10:42 | |
openstackgerrit | Igor Malinovskiy proposed openstack/manila: Add update_access() method to driver interface https://review.openstack.org/245126 | 10:46 |
*** deepakcs has quit IRC | 10:50 | |
*** haomaiwang has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-manila | 11:01 | |
*** yangyapeng has quit IRC | 11:13 | |
*** shinobu_ has joined #openstack-manila | 11:13 | |
openstackgerrit | Silvan Kaiser proposed openstack/manila: Add share id to Quobyte backend volume name https://review.openstack.org/241671 | 11:13 |
*** shinobu_ is now known as Guest13848 | 11:13 | |
*** Guest13848 has quit IRC | 11:14 | |
*** shinobu___ has joined #openstack-manila | 11:15 | |
*** haomaiwang has quit IRC | 11:51 | |
*** ociuhandu has joined #openstack-manila | 12:19 | |
*** ociuhandu_ has joined #openstack-manila | 12:22 | |
*** ociuhandu has quit IRC | 12:23 | |
*** ociuhandu_ is now known as ociuhandu | 12:23 | |
*** jsheeren has joined #openstack-manila | 12:29 | |
*** yangyapeng has joined #openstack-manila | 12:32 | |
*** shinobu___ has quit IRC | 12:33 | |
*** sgotliv_ has quit IRC | 12:43 | |
*** sgotliv has joined #openstack-manila | 12:51 | |
*** gouthamr has joined #openstack-manila | 12:52 | |
*** akerr has quit IRC | 12:59 | |
*** gouthamr has quit IRC | 13:31 | |
*** akerr has joined #openstack-manila | 13:34 | |
*** gouthamr has joined #openstack-manila | 13:37 | |
*** bswartz has quit IRC | 13:42 | |
gouthamr | vponomaryov: Would appreciate your input on this: https://review.openstack.org/#/c/246555/ | 13:44 |
*** tpsilva has quit IRC | 13:49 | |
*** merooney has joined #openstack-manila | 13:50 | |
*** jsheeren has quit IRC | 13:51 | |
*** absubram has joined #openstack-manila | 13:52 | |
openstackgerrit | Julia Varlamova proposed openstack/manila: Add LVM driver https://review.openstack.org/232970 | 13:52 |
*** dcain has joined #openstack-manila | 13:53 | |
*** bill_az has joined #openstack-manila | 13:53 | |
*** eharney has joined #openstack-manila | 13:53 | |
*** dcain1 has joined #openstack-manila | 13:54 | |
*** dcain has quit IRC | 13:57 | |
*** porrua has joined #openstack-manila | 13:58 | |
*** akshai has joined #openstack-manila | 14:04 | |
openstackgerrit | Silvan Kaiser proposed openstack/manila: Implements ensure_share() in Quobyte driver https://review.openstack.org/239686 | 14:09 |
*** bswartz has joined #openstack-manila | 14:09 | |
*** absubram has quit IRC | 14:27 | |
*** cknight has joined #openstack-manila | 14:29 | |
*** tpsilva has joined #openstack-manila | 14:30 | |
*** dustins has joined #openstack-manila | 14:30 | |
*** dcain has joined #openstack-manila | 14:31 | |
*** openstackgerrit has quit IRC | 14:31 | |
*** openstackgerrit has joined #openstack-manila | 14:32 | |
*** dcain1 has quit IRC | 14:33 | |
*** lpabon has joined #openstack-manila | 14:46 | |
*** dustins has quit IRC | 14:57 | |
*** dustins has joined #openstack-manila | 15:00 | |
vponomaryov | gouthamr: done | 15:04 |
*** a_ta has joined #openstack-manila | 15:04 | |
gouthamr | thanks vponomaryov | 15:08 |
*** sgotliv has quit IRC | 15:15 | |
*** adrianofr has quit IRC | 15:16 | |
vponomaryov | bswartz, cknight, markstur, toabctl: If you have time, please look at https://review.openstack.org/#/c/239689/ | 15:17 |
*** adrianofr has joined #openstack-manila | 15:18 | |
cknight | vponomaryov: OK | 15:18 |
*** rushil has joined #openstack-manila | 15:22 | |
bswartz | vponomaryov: I already looked at it | 15:22 |
gouthamr | vponomaryov: how strongly do you feel against using function names as the action names for policy checking? wsgi does its routing based on function names :) | 15:23 |
gouthamr | vponomaryov: reference: https://review.openstack.org/#/c/246555/1/manila/api/openstack/wsgi.py #1145 | 15:24 |
toabctl | vponomaryov: looks good. merging... | 15:24 |
vponomaryov | gouthamr: routing can be set up to any variant in router.py module | 15:24 |
toabctl | ah. bswartz started already the workflow :) | 15:25 |
vponomaryov | cknight, bswartz, toabctl: thanks! | 15:25 |
vponomaryov | gouthamr: absolutely any variant, wsgi just have defaults | 15:25 |
gouthamr | vponomaryov: the idea was to allow common methods that most APIs implement -> 'create', 'delete', 'update', 'get', 'action' and such.. | 15:26 |
*** rushil has quit IRC | 15:26 | |
vponomaryov | gouthamr: such double approach lead to documenting improper thing - call without args | 15:27 |
gouthamr | vponomaryov: args are implied in that case.. its the method being decorated.. | 15:27 |
vponomaryov | gouthamr: exactly call without args - decorator() | 15:28 |
gouthamr | vponomaryov: in most cases, we don't change the function names for CRUD ops.. | 15:28 |
*** sgotliv has joined #openstack-manila | 15:28 | |
vponomaryov | toabctl: why https://review.openstack.org/#/c/242960/ and https://review.openstack.org/#/c/242957/ in separate commits? | 15:36 |
vponomaryov | toabctl: maybe better to combine them? | 15:37 |
*** haomaiwang has joined #openstack-manila | 15:37 | |
toabctl | vponomaryov: one is for stable/liberty | 15:37 |
toabctl | vponomaryov: and I just followed the example given on the ML | 15:37 |
vponomaryov | toabctl: oh, right | 15:37 |
vponomaryov | didn't look at branch | 15:38 |
toabctl | vponomaryov: tbh I don't understand the process completly yet. as I said, I followed the example and iirc this should be merged before mitaka-1 | 15:38 |
*** markstur has quit IRC | 15:38 | |
vponomaryov | toabctl: but then liberty branch requires original reno support anyway | 15:39 |
vponomaryov | toabctl: same commit as for master | 15:39 |
toabctl | vponomaryov: yes. I think that needs to be backported if merged in master. | 15:39 |
vponomaryov | csaba: you have lots of commits, can you point to specific one that should be reviewed at first priority? | 15:41 |
*** xyang1 has joined #openstack-manila | 15:48 | |
*** hodos has joined #openstack-manila | 15:52 | |
*** houming-wang has joined #openstack-manila | 15:56 | |
*** dustins has quit IRC | 15:58 | |
*** dustins has joined #openstack-manila | 15:58 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: Bump UCA and RDO to Liberty GA https://review.openstack.org/241642 | 15:59 |
vponomaryov | gouthamr: https://bugs.launchpad.net/manila/+bug/1492920 | 15:59 |
openstack | Launchpad bug 1492920 in Manila " Consistency Group Support for the Generic Driver" [Undecided,New] | 15:59 |
vponomaryov | gouthamr: what do you know about this? | 16:00 |
gouthamr | vponomaryov: wrote that code.. | 16:01 |
*** haomaiwang has quit IRC | 16:01 | |
gouthamr | vponomaryov: I guess 'DocImpact' wasn't needed? | 16:01 |
*** haomaiwang has joined #openstack-manila | 16:01 | |
vponomaryov | gouthamr: no | 16:01 |
gouthamr | vponomaryov: don't understand the bug though.. it says "This bug was created here because we did not know how to map the project name "openstack/manila" to a launchpad project name." | 16:02 |
vponomaryov | gouthamr: each "DocImpact" autocreates bug for openstack-manuals project | 16:03 |
vponomaryov | gouthamr: so, I guess, they considered it is invalid for their project and it means "DocImpact" is redundant | 16:03 |
vponomaryov | gouthamr: so, I close this bug | 16:03 |
gouthamr | vponomaryov: oh. yes. sure. | 16:04 |
openstackgerrit | Clinton Knight proposed openstack/manila: Modified last sync from oslo-incubator https://review.openstack.org/247003 | 16:04 |
gouthamr | vponomaryov: https://review.openstack.org/#/c/219891/3..1//COMMIT_MSG | 16:05 |
cknight | vponomaryov, u_glide1: This is the oslo incubator sync for Manila, minus the file Igor had modified. https://review.openstack.org/#/c/247003/ | 16:05 |
cknight | vponomaryov, u_glide1: Need this so I can refactor capabilities_filter to accept lists. | 16:06 |
*** bswartz has quit IRC | 16:06 | |
cknight | vponomaryov, u_glide1: I also need to pull the unit tests for the files we got from the incubator, since we own them now. That's a separate patch. | 16:06 |
*** rushil has joined #openstack-manila | 16:08 | |
*** erlon has quit IRC | 16:08 | |
vponomaryov | gouthamr: it should have been added to dev docs , which are located in manila repo | 16:13 |
vponomaryov | gouthamr: it has nothing for DocImpact | 16:13 |
gouthamr | vponomaryov: makes sense. I can close that bug with a dev docs patch | 16:14 |
vponomaryov | cknight: when do you plan to port tests? | 16:14 |
vponomaryov | gouthamr: already set as invalid )) | 16:14 |
gouthamr | vponomaryov: alright, new bug then. | 16:14 |
*** leeantho has joined #openstack-manila | 16:15 | |
cknight | vponomaryov: soon :-) But there are more files from the incubator that just what we got in the last sync, so I figured that would be a separate effort. Doing the sync now doesn't reduce our coverage. | 16:15 |
vponomaryov | gouthamr: you can modify description in this one | 16:15 |
*** houming-wang has quit IRC | 16:15 | |
vponomaryov | gouthamr: then we change status to correct one | 16:15 |
gouthamr | vponomaryov: sure thing | 16:16 |
cknight | vponomaryov: some of the unit tests don't mirror the directory/file structure of the code, so I'm wondering if I should fix that at the same time. | 16:16 |
gouthamr | vponomaryov: thanks for the heads up. will change it. | 16:16 |
*** akerr has quit IRC | 16:16 | |
*** yangyapeng has quit IRC | 16:17 | |
*** haomaiwang has quit IRC | 16:51 | |
*** dzamboni has quit IRC | 17:13 | |
*** ociuhandu has quit IRC | 17:17 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Improve Tempest tests for consistency groups https://review.openstack.org/247052 | 17:21 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Improve Tempest tests for consistency groups https://review.openstack.org/247052 | 17:22 |
*** nkrinner has quit IRC | 17:23 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Improve Tempest tests for consistency groups https://review.openstack.org/247052 | 17:24 |
*** nkrinner has joined #openstack-manila | 17:24 | |
*** lpetrut has quit IRC | 17:25 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Improve Tempest tests for consistency groups https://review.openstack.org/247052 | 17:25 |
*** porrua has quit IRC | 17:38 | |
*** verdurin has quit IRC | 17:55 | |
*** bswartz has joined #openstack-manila | 17:56 | |
*** eduardo_ has quit IRC | 18:02 | |
*** porrua has joined #openstack-manila | 18:03 | |
*** akerr has joined #openstack-manila | 18:03 | |
*** akerr_ has joined #openstack-manila | 18:06 | |
*** akerr has quit IRC | 18:09 | |
ganso | bswartz: ping | 18:10 |
*** markstur has joined #openstack-manila | 18:13 | |
*** verdurin has joined #openstack-manila | 18:22 | |
*** ociuhandu has joined #openstack-manila | 18:24 | |
*** lpetrut has joined #openstack-manila | 18:48 | |
*** erlon has joined #openstack-manila | 18:50 | |
bswartz | ganso: pong | 18:50 |
ganso | bswartz: Hi | 18:51 |
ganso | bswartz: I am moving migration code to data copy service | 18:51 |
ganso | bswartz: now is the time that we will need network expertise | 18:52 |
ganso | bswartz: this code https://github.com/openstack/manila/blob/8247f350af7db639581c58e274e63463afe544c2/manila/share/drivers/generic.py#L218 will no longer work | 18:52 |
ganso | bswartz: because the machine copying data may not be the same running the driver anymore | 18:52 |
ganso | bswartz: for DHSS=true drivers, every share server in each share network need to be accessible by the data copy service node... currently the drivers themselves are responsible for obtaining the IP that allows such connectivity | 18:54 |
ganso | bswartz: I think we need to discuss some approaches that may be more feasible... like an admin creating a fixed neutron port that connects any share server (if such thing is possible), or if drivers create VIFs for each share server... or admin-network facing export locations... | 18:55 |
bswartz | ganso: I agree that the admin-facing network stuff is fairly urgent | 18:57 |
bswartz | ganso: is that something you're interested in tackling yourself or do you need help? | 18:58 |
bswartz | I'll work with whoever is willing to do it, and if there's no volunteers I'll designate someone | 18:58 |
ganso | bswartz: any network help is much appreciated... like whoever designed the VIFs code for the generic driver may be able to help | 18:59 |
*** rushil has quit IRC | 18:59 | |
ganso | bswartz: my favorite approach is a single dedicated neutron port for data copy service node... if that is possible | 19:00 |
ganso | bswartz: this may be something we can discuss on tomorrow's meeting | 19:00 |
ganso | bswartz: I can draw a diagram | 19:01 |
bswartz | well what I envision is pretty simply actually | 19:01 |
bswartz | at least, my vision for the driver interface in the share manager | 19:01 |
bswartz | how drivers implement it could end up being complicated, but in the general case it shouldn't be | 19:01 |
*** dcain1 has joined #openstack-manila | 19:02 | |
ganso | bswartz: what would be the general case? | 19:03 |
ganso | bswartz: I think we still prefer involving drivers as less as possible | 19:03 |
*** dcain has quit IRC | 19:06 | |
*** tpsilva has quit IRC | 19:06 | |
bswartz | ganso: so my proposal is simple | 19:08 |
bswartz | ganso: any driver that support share servers needs to ensure that it creates an additional network interface, reachable from the admin network | 19:09 |
bswartz | most likely we'll need to add a configuration parameter to allow admin to specify how drivers should obtain IP addresses and network details for that network | 19:09 |
bswartz | but it will ultimately look a lot like the existing share network code | 19:10 |
ganso | bswartz: one VIF per share server approach. That would make the current code I linked above compatible. The difference is that the service_ip would be that VIF ip, instead of the VIF that connects back to manila-share node | 19:10 |
bswartz | then, every share created by share-server drivers will need to create an additional export location, tagged as admin-only | 19:10 |
bswartz | and the migration code will use those admin export locations | 19:11 |
bswartz | we would want to make sure the admin export locations were hidden from non-admins | 19:11 |
*** rushil has joined #openstack-manila | 19:15 | |
ganso | bswartz: extra export locations may not be necessary, as they are not today | 19:17 |
bswartz | well I like the idea of the driver telling manila what is the best way to access shares for administrative purposes | 19:17 |
*** absubram has joined #openstack-manila | 19:18 | |
ganso | bswartz: a code that is able to interpret several ways a driver may tell the manager is probably more complex than a way we enforce (if it works for all vendors) | 19:19 |
ganso | bswartz: this is the main reason I haven't gone down that road | 19:19 |
ganso | bswartz: and also that we haven't had vendors input on this | 19:19 |
ganso | bswartz: so far | 19:19 |
bswartz | ganso: The goal of this change is to force standardization so it's easier from yourside | 19:20 |
bswartz | if we implement this new interface, then the migration code only has 2 paths -- share-servers and no-share-servers | 19:21 |
ganso | bswartz: that path is related to obtaining the IP the data copy service should mount, and which IP to allow access (data copy service node's). Both are already in the driver interface to be overriden | 19:23 |
openstackgerrit | Merged openstack/python-manilaclient: Updated from global requirements https://review.openstack.org/244235 | 19:28 |
openstackgerrit | Merged openstack/manila: Port admin actions extension to core API https://review.openstack.org/239689 | 19:40 |
*** rushil has quit IRC | 19:42 | |
*** rushil has joined #openstack-manila | 19:43 | |
*** vkmc is now known as vkmc-afk | 19:44 | |
*** jasonsb has quit IRC | 19:55 | |
*** lpetrut has quit IRC | 19:57 | |
*** lpetrut has joined #openstack-manila | 20:00 | |
*** cknight has quit IRC | 20:03 | |
openstackgerrit | Merged openstack/manila: Port share type extensions to core API https://review.openstack.org/239913 | 20:04 |
*** sgotliv has quit IRC | 20:12 | |
*** cknight has joined #openstack-manila | 20:15 | |
*** lpetrut has quit IRC | 20:22 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Updated from global requirements https://review.openstack.org/246095 | 20:39 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Updated from global requirements https://review.openstack.org/246095 | 20:47 |
*** verdurin has quit IRC | 20:49 | |
*** jasonsb has joined #openstack-manila | 20:50 | |
*** jasonsb has quit IRC | 20:50 | |
*** jasonsb has joined #openstack-manila | 20:51 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-manilaclient: Updated from global requirements https://review.openstack.org/247156 | 20:51 |
*** rebase has joined #openstack-manila | 20:53 | |
openstackgerrit | Clinton Knight proposed openstack/manila: Last sync to Manila from oslo-incubator https://review.openstack.org/247003 | 20:55 |
*** openstack has joined #openstack-manila | 21:04 | |
csaba | bswartz: ping | 21:06 |
bswartz | csaba: pong | 21:07 |
csaba | bswartz: hi Ben, I'm sorry if missed an official announcement on this, but has the feature proposal deadline for Mitaka been decided? | 21:08 |
bswartz | csaba: it's still 2 weeks before M-3, so I would say ~ Feb 18 most likely | 21:11 |
bswartz | however we agreed that for BIG features we need to see WIP code long before then | 21:11 |
bswartz | we just never agreed on the specifics | 21:11 |
csaba | bswartz: yeah, I remember that, that's why I'm asking | 21:12 |
bswartz | csaba: did you have any big new features in mind? | 21:12 |
openstackgerrit | Mark Sturdevant proposed openstack/manila: HPE3PAR Add support for access-level (ro,rw) https://review.openstack.org/245383 | 21:12 |
openstackgerrit | Merged openstack/manila: Added CONTRIBUTING file in .rst format https://review.openstack.org/245575 | 21:13 |
csaba | bswartz: of RH originated contributions, probably the upcoming Ceph driver can qualify as such | 21:14 |
bswartz | yes but drivers are inherently low risk | 21:14 |
bswartz | if it's a large patch we'll probably want an earlier deadline just because of the size and time to review, but if it's not a core feature I'm less worried | 21:15 |
bswartz | what RH submissions are likely to affect the Manila core in Mitaka? | 21:15 |
csaba | yeah that's why I thought it's indeed still not "big" | 21:15 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add new URLs for APIs ported from extensions https://review.openstack.org/240220 | 21:16 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [TEST] Run Tempest with v2.6 having v2.7 https://review.openstack.org/241311 | 21:16 |
*** a_ta has quit IRC | 21:17 | |
csaba | bswartz: other question: does Mitaka-{1,2} have any significance | 21:17 |
csaba | ? | 21:17 |
xyang1 | bswartz: two weeks before M-3 is deadline for new feature submission? that is the same as what we had in Liberty | 21:17 |
*** a_ta has joined #openstack-manila | 21:17 | |
*** a_ta has joined #openstack-manila | 21:17 | |
bswartz | csaba: those are just milestones that we use to target blueprints that will be ready for release early | 21:18 |
*** verdurin has joined #openstack-manila | 21:18 | |
csaba | bswartz: OK, thamks | 21:18 |
bswartz | xyang1: yes the plan keep the existing deadline and add an additional earlier deadline for big stuff | 21:18 |
bswartz | xyang1: we still haven't decided how to define "big" and how much earlier those submissions need to be | 21:18 |
bswartz | xyang1: I put it on the agenda for tomorrow though | 21:19 |
xyang1 | bswartz: ok | 21:19 |
bswartz | xyang1: do you have any ideas? | 21:19 |
xyang1 | bswartz: I thought we discussed about an earlier merge deadline for core features | 21:20 |
xyang1 | bswartz: driver is different | 21:20 |
xyang1 | bswartz: driver can get merged until M-3 | 21:20 |
bswartz | xyang1: what I wanted to to require that there's a WIP submission for core features by some earlier date, but not to necessarily change the merge deadline | 21:20 |
bswartz | because for large new features, there could be many iterations of reviews and patches | 21:21 |
xyang1 | bswartz: that is true | 21:21 |
bswartz | as long as that process starts early enough, I see no reason to force it to end before a specific date | 21:21 |
xyang1 | bswartz: we need to have a deadline for early submission then | 21:22 |
bswartz | yeah that's my thinking | 21:22 |
bswartz | maybe for patches that add more than 500 lines of new code (not counting refactors that add and delete lots of lines but it's all just moved around) that we require WIP by M-2 date | 21:23 |
bswartz | so we have 5 weeks to review instead of 2 weeks | 21:23 |
bswartz | actually 6 weeks because M-3 is that long | 21:24 |
xyang1 | bswartz: sure | 21:24 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Updated from global requirements https://review.openstack.org/246095 | 21:24 |
bswartz | although we could pick some later date that's M3 minus 4 weeks or 5 weeks | 21:24 |
xyang1 | bswartz: a big refactor could be painful to review too | 21:24 |
*** breitz1 is now known as breitz | 21:25 | |
xyang1 | bswartz: vponomaryov has complained about it:) | 21:25 |
bswartz | refactors take time to review but require nowhere near as many iterations as new core features | 21:25 |
bswartz | the concern is how many times the cycle needs to be repeated | 21:25 |
xyang1 | bswartz: I would actually suggest a big driver refactor to be submitted and reviewed as a new driver | 21:26 |
bswartz | big reviews are always painful but refactors tend to go more quickly because it's just comparing the old to the new and looking for bugs | 21:26 |
bswartz | xyang1: we don't have any special deadlines for new drivers though... | 21:26 |
xyang1 | bswartz: yes | 21:26 |
bswartz | if a reviewer wants to look at it like a new driver, then that's fine | 21:27 |
*** hodos has quit IRC | 21:27 | |
bswartz | I know some people prefer to review large refactors by just pulling the change and reviewing the whole file (without looking at the old file) | 21:27 |
bswartz | would making people submit those refactor patches earlier really save us any pain? or would it just shift it earlier? | 21:28 |
xyang1 | bswartz: do you suggest a new driver to be submitted 2weeks before M-3 | 21:28 |
bswartz | xyang1: that's what we did for Liberty, and the new drivers didn't cause problems like the new features did | 21:29 |
bswartz | I'm open to doing it differently | 21:30 |
bswartz | I just want to make sure we're solving a real problem | 21:30 |
bswartz | the big pain for me was cgroups and migration | 21:30 |
*** verdurin has quit IRC | 21:31 | |
xyang1 | bswartz: true, I don't remember if a new driver was submitted that late | 21:31 |
bswartz | glusterfs native was the last drier to come in IIRC | 21:31 |
bswartz | driver | 21:31 |
bswartz | and it was right at the deadline | 21:31 |
xyang1 | bswartz: I thought that was some driver enhancement rather than a brand new driver, I could be wrong | 21:32 |
bswartz | it sounds like redhat is trying to decide when to submit the cephfs driver -- if we don't want it on Feb 18 then we should agree on when we want to see it and let redhat know what the deadline is | 21:33 |
bswartz | xyang1: you might be right | 21:33 |
xyang1 | bswartz: ok | 21:33 |
bswartz | there were several driver enhancement patches for the glusterfs native driver though | 21:34 |
*** a_ta has quit IRC | 21:39 | |
*** a_ta has joined #openstack-manila | 21:39 | |
*** a_ta has quit IRC | 21:44 | |
*** dustins has quit IRC | 21:45 | |
*** a_ta has joined #openstack-manila | 21:46 | |
*** verdurin has joined #openstack-manila | 21:59 | |
*** bswartz has quit IRC | 22:00 | |
*** verdurin has quit IRC | 22:03 | |
*** a_ta has quit IRC | 22:16 | |
*** a_ta has joined #openstack-manila | 22:17 | |
*** a_ta_ has joined #openstack-manila | 22:18 | |
*** sgotliv has joined #openstack-manila | 22:21 | |
*** a_ta has quit IRC | 22:22 | |
*** porrua has quit IRC | 22:24 | |
*** a_ta_ has quit IRC | 22:25 | |
*** a_ta has joined #openstack-manila | 22:26 | |
*** a_ta has quit IRC | 22:27 | |
*** a_ta has joined #openstack-manila | 22:28 | |
*** jasonsb has quit IRC | 22:28 | |
*** a_ta has quit IRC | 22:30 | |
*** jasonsb has joined #openstack-manila | 22:30 | |
*** rushil has quit IRC | 22:31 | |
*** verdurin has joined #openstack-manila | 22:31 | |
*** a_ta_ has joined #openstack-manila | 22:32 | |
*** a_ta_ has quit IRC | 23:27 | |
*** a_ta has joined #openstack-manila | 23:28 | |
*** xyang1 has quit IRC | 23:28 | |
*** zhongjun has quit IRC | 23:30 | |
*** zhongjun has joined #openstack-manila | 23:31 | |
*** a_ta has quit IRC | 23:32 | |
*** cknight has quit IRC | 23:35 | |
*** dcain1 has quit IRC | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!