*** gouthamr has quit IRC | 00:05 | |
*** bswartz has joined #openstack-manila | 00:08 | |
*** rebase has quit IRC | 00:32 | |
*** zhongjun2 has joined #openstack-manila | 00:44 | |
*** zhongjun has quit IRC | 00:46 | |
*** rebase has joined #openstack-manila | 00:59 | |
*** leeantho has quit IRC | 01:15 | |
*** merooney has quit IRC | 01:16 | |
*** jasonsb has quit IRC | 01:22 | |
*** akshai has quit IRC | 01:27 | |
*** jasonsb has joined #openstack-manila | 01:53 | |
*** gouthamr has joined #openstack-manila | 01:55 | |
*** jasonsb has quit IRC | 01:56 | |
*** gouthamr_ has joined #openstack-manila | 02:15 | |
*** gouthamr has quit IRC | 02:18 | |
*** openstack has joined #openstack-manila | 02:26 | |
*** haomaiwang has joined #openstack-manila | 02:29 | |
*** absubram has quit IRC | 02:30 | |
*** haomaiwang has quit IRC | 02:38 | |
*** haomaiwa_ has joined #openstack-manila | 02:39 | |
*** akshai has quit IRC | 02:49 | |
*** rebase has quit IRC | 03:14 | |
*** gouthamr_ has quit IRC | 03:30 | |
*** rushil has joined #openstack-manila | 03:56 | |
openstackgerrit | zhongjun proposed openstack/manila: QoS support for shares https://review.openstack.org/247286 | 03:56 |
---|---|---|
*** lpabon has quit IRC | 04:03 | |
*** bill_az has quit IRC | 04:10 | |
*** rushil has quit IRC | 04:13 | |
*** jasonsb has joined #openstack-manila | 05:04 | |
*** rushil has joined #openstack-manila | 05:10 | |
*** jasonsb has quit IRC | 05:20 | |
*** houming-wang has joined #openstack-manila | 05:21 | |
*** jasonsb has joined #openstack-manila | 05:46 | |
*** jasonsb has quit IRC | 06:30 | |
*** rushil has quit IRC | 06:34 | |
*** jasonsb has joined #openstack-manila | 06:38 | |
*** jasonsb has quit IRC | 06:50 | |
*** jasonsb has joined #openstack-manila | 06:52 | |
*** dalgaaf has joined #openstack-manila | 06:56 | |
*** jasonsb has quit IRC | 06:57 | |
*** breitz has quit IRC | 07:01 | |
*** breitz has joined #openstack-manila | 07:01 | |
*** shausy has joined #openstack-manila | 07:21 | |
openstackgerrit | zhongjun proposed openstack/manila: Do not allow to modify access for public share type https://review.openstack.org/219213 | 07:33 |
openstackgerrit | zhongjun proposed openstack/manila: Do not allow to modify access for public share type https://review.openstack.org/219213 | 07:38 |
*** rushil has joined #openstack-manila | 07:46 | |
*** jvarlamova has quit IRC | 07:50 | |
*** rushil has quit IRC | 07:54 | |
openstackgerrit | zhongjun proposed openstack/manila: QoS support for shares https://review.openstack.org/247286 | 08:13 |
openstackgerrit | zhongjun proposed openstack/manila: QoS support for shares https://review.openstack.org/247286 | 08:16 |
*** lpetrut has joined #openstack-manila | 08:19 | |
*** jvarlamova has joined #openstack-manila | 08:19 | |
openstackgerrit | zhongjun proposed openstack/manila: Do not allow to modify access for public share type https://review.openstack.org/219213 | 08:36 |
*** shausy has quit IRC | 08:49 | |
zhongjun22 | ameade, bswartz: ping | 08:52 |
zhongjun22 | ameade, bswartz: After we were discussed about qos in IRC meeting, I put some description(about qos) in the doc(link: https://review.openstack.org/#/c/247286/), Could you use the doc review to register feedback, and make the qos feature go on. | 08:53 |
*** deepakcs has joined #openstack-manila | 08:53 | |
*** shausy has joined #openstack-manila | 08:55 | |
*** shausy has quit IRC | 08:57 | |
*** haomaiwa_ has quit IRC | 08:57 | |
*** haomaiwang has joined #openstack-manila | 08:59 | |
*** lgreg has quit IRC | 08:59 | |
*** lgreg has joined #openstack-manila | 09:00 | |
*** shausy has joined #openstack-manila | 09:00 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-manila | 09:01 | |
*** lpetrut has quit IRC | 09:18 | |
*** abhi has quit IRC | 09:49 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Improve Tempest tests for consistency groups https://review.openstack.org/247052 | 09:51 |
*** haomaiwang has quit IRC | 10:01 | |
*** houming-wang has quit IRC | 10:01 | |
*** openstackgerrit has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-manila | 10:01 | |
*** openstackgerrit has joined #openstack-manila | 10:01 | |
*** abhi has joined #openstack-manila | 10:11 | |
*** openstack has joined #openstack-manila | 10:19 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: Acceptance: use common bits from puppet-openstack-integration https://review.openstack.org/247401 | 10:28 |
*** lpetrut has joined #openstack-manila | 10:41 | |
*** tpsilva has joined #openstack-manila | 10:59 | |
*** haomaiwang has quit IRC | 11:01 | |
*** logan2 has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-manila | 11:01 | |
*** logan2 has joined #openstack-manila | 11:01 | |
*** ekarlso has quit IRC | 11:05 | |
*** ociuhandu has quit IRC | 11:17 | |
*** ociuhandu has joined #openstack-manila | 11:25 | |
*** eduardo_ has joined #openstack-manila | 11:26 | |
*** ociuhandu has quit IRC | 11:26 | |
*** ekarlso has joined #openstack-manila | 11:30 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Improve Tempest tests for consistency groups https://review.openstack.org/247052 | 11:30 |
openstackgerrit | Silvan Kaiser proposed openstack/manila: Implements ensure_share() in Quobyte driver https://review.openstack.org/239686 | 11:41 |
openstackgerrit | Silvan Kaiser proposed openstack/manila: Add share id to Quobyte backend volume name https://review.openstack.org/241671 | 11:43 |
openstackgerrit | zhongjun proposed openstack/manila: QoS support for shares https://review.openstack.org/247286 | 11:46 |
*** deepakcs has quit IRC | 11:50 | |
*** haomaiwang has quit IRC | 12:01 | |
*** haomaiwang has joined #openstack-manila | 12:01 | |
*** martyturner has joined #openstack-manila | 12:07 | |
*** ociuhandu has joined #openstack-manila | 12:12 | |
*** vkmc-afk is now known as vkmc | 12:22 | |
*** vkmc is now known as vkmc-afk | 12:26 | |
*** vkmc-afk is now known as vkmc | 12:27 | |
*** martyturner has quit IRC | 12:34 | |
ganso | bswartz: ping | 12:36 |
*** houming-wang has joined #openstack-manila | 12:54 | |
*** akerr_away is now known as akerr_ | 12:55 | |
*** akerr_ has quit IRC | 12:55 | |
*** haomaiwang has quit IRC | 13:01 | |
*** shausy has quit IRC | 13:01 | |
*** haomaiwang has joined #openstack-manila | 13:01 | |
*** gouthamr has joined #openstack-manila | 13:11 | |
gouthamr | kaisers: ping | 13:18 |
*** vkmc is now known as vkmc-afk | 13:21 | |
*** openstackstatus has joined #openstack-manila | 13:34 | |
*** ChanServ sets mode: +v openstackstatus | 13:34 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Improve Tempest tests for consistency groups https://review.openstack.org/247052 | 13:34 |
*** zhongjun2 has joined #openstack-manila | 13:37 | |
*** akerr has joined #openstack-manila | 13:38 | |
*** zhongjun22 has quit IRC | 13:40 | |
bswartz | ganso: I'll be in the office soon, ping me when I'm back online | 13:44 |
*** bswartz has quit IRC | 13:44 | |
*** haomaiwang has quit IRC | 13:45 | |
*** porrua has joined #openstack-manila | 13:48 | |
*** eharney has quit IRC | 13:54 | |
*** xyang1 has joined #openstack-manila | 13:54 | |
kaisers | gouthamr: hi! | 13:58 |
kaisers | nidhimittalhada: Hi! Sry but i saw your msg too late! | 13:59 |
kaisers | gouthamr: I'll be afk in a min but back on later for the manila meeting... | 14:00 |
*** akshai has joined #openstack-manila | 14:06 | |
*** dustins has joined #openstack-manila | 14:07 | |
*** timcl has quit IRC | 14:13 | |
*** haomaiwang has joined #openstack-manila | 14:15 | |
*** bswartz has joined #openstack-manila | 14:18 | |
*** merooney has joined #openstack-manila | 14:21 | |
openstackgerrit | John Spray proposed openstack/manila: share: add access_key to instance mapping https://review.openstack.org/247540 | 14:24 |
*** haomai___ has joined #openstack-manila | 14:31 | |
*** haomaiwang has quit IRC | 14:34 | |
*** cknight has joined #openstack-manila | 14:34 | |
*** houming-wang has quit IRC | 14:44 | |
*** markstur_ has joined #openstack-manila | 14:45 | |
*** houming-wang has joined #openstack-manila | 14:46 | |
*** sghatty_ has quit IRC | 14:47 | |
*** vkmc-afk is now known as vkmc | 14:50 | |
*** juzuluag has joined #openstack-manila | 14:51 | |
*** houming-wang has quit IRC | 14:56 | |
*** juzuluag has quit IRC | 14:56 | |
*** houming-wang has joined #openstack-manila | 14:59 | |
*** breitz has quit IRC | 15:00 | |
*** haomai___ has quit IRC | 15:01 | |
ganso | bswartz: just got back | 15:01 |
vponomaryov | markstur: weekly meeting? | 15:01 |
*** haomaiwang has joined #openstack-manila | 15:01 | |
ganso | bswartz: was going to ask if there is a better host for images, google drive is blocked in china | 15:01 |
*** a_ta has joined #openstack-manila | 15:03 | |
*** timcl has joined #openstack-manila | 15:04 | |
*** jasonsb has joined #openstack-manila | 15:04 | |
*** breitz has joined #openstack-manila | 15:04 | |
*** sghatty_ has joined #openstack-manila | 15:06 | |
*** sgotliv has quit IRC | 15:09 | |
*** eharney has joined #openstack-manila | 15:13 | |
*** dustins has quit IRC | 15:13 | |
*** breitz has quit IRC | 15:15 | |
*** sgotliv has joined #openstack-manila | 15:16 | |
*** Zhongjun has joined #openstack-manila | 15:19 | |
*** haomaiwang has quit IRC | 15:21 | |
*** vkmc has quit IRC | 15:24 | |
*** rushil has joined #openstack-manila | 15:25 | |
*** houming-wang has quit IRC | 15:28 | |
*** rushil has quit IRC | 15:30 | |
*** vkmc has joined #openstack-manila | 15:33 | |
*** alyson_ has joined #openstack-manila | 15:33 | |
*** marcusvrn_ has joined #openstack-manila | 15:33 | |
*** JoseMello has joined #openstack-manila | 15:38 | |
*** ayma has joined #openstack-manila | 15:43 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Updated from global requirements https://review.openstack.org/246095 | 15:46 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui: Updated from global requirements https://review.openstack.org/247607 | 15:46 |
*** nkrinner has quit IRC | 15:46 | |
*** nkrinner has joined #openstack-manila | 15:47 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-manilaclient: Updated from global requirements https://review.openstack.org/247156 | 15:52 |
*** houming-wang has joined #openstack-manila | 15:54 | |
*** leeantho has joined #openstack-manila | 16:00 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-manilaclient: Updated from global requirements https://review.openstack.org/247156 | 16:01 |
bswartz | over here guys | 16:01 |
* ganso moves over | 16:01 | |
*** zhongjun22 has joined #openstack-manila | 16:01 | |
gouthamr | ganso: you have the stage | 16:02 |
bswartz | vponomaryov xyang1 gouthamr cknight ganso markstur_ jayxu | 16:02 |
xyang1 | hi | 16:02 |
*** casusbelli has joined #openstack-manila | 16:02 | |
ganso | we were still discussing deadlines | 16:02 |
bswartz | I think the deadline discussion pretty much wrapped up | 16:03 |
ganso | ok | 16:03 |
bswartz | I didn't hear any opposition | 16:03 |
ganso | so... #link https://drive.google.com/file/d/0B30HPZmaePCHMlAzcjJlYm5rRTA/view?usp=sharing | 16:03 |
bswartz | I will compose an ML post describing what we agreed to | 16:03 |
bswartz | (or what I think we agreed to) | 16:03 |
ganso | that are 4 images in that link | 16:03 |
ganso | that represents connecting Data Copy Service Node to Share servers in DHSS = True mode | 16:04 |
ganso | the first one is the problem | 16:04 |
bswartz | ganso: the image is super tiny | 16:04 |
ganso | the other 3 below are my suggestions | 16:04 |
ganso | bswartz: sorry, can you download and zoom in? | 16:04 |
bswartz | there we go | 16:04 |
bswartz | yes downloading works | 16:04 |
bswartz | okay 1 sec while I read this image | 16:05 |
vponomaryov | ganso: you have 50 inches monitor? )) | 16:05 |
ganso | vponomaryov: lol no | 16:05 |
ganso | my first suggestion is having a network for the data copy node that interconnects all share server networks | 16:06 |
ganso | so there would only need to be one connection between the data copy service node to that network | 16:06 |
ganso | my 2nd suggestion is for each share server, during setup_server method, drivers would create an additional VIF | 16:07 |
bswartz | ganso: I'm not sure I agree with the first picture | 16:07 |
bswartz | it may be accurate for the generic driver, but not all share-server drivers look like that | 16:07 |
ganso | bswartz: yes... I am modeled it based on generic driver | 16:08 |
*** casusbelli has quit IRC | 16:08 | |
ganso | bswartz: I *modeled | 16:08 |
bswartz | ganso: in parcular the presence of the "routers" in the picture is contrary to recommended practice | 16:08 |
vponomaryov | agree, other drivers use API for talking to backend, not CLI | 16:08 |
bswartz | and the VIF connection for management is also unusual | 16:09 |
bswartz | but if we ignore those details and focus on differences between 1 and 2-4 | 16:09 |
ganso | the generic driver uses a VIF to connect the manila-share node to the share server in order to issue SSH commands | 16:09 |
ganso | bswartz: yes, precisely | 16:09 |
bswartz | then I think 4 comes closest to what I have been thinking about | 16:09 |
vponomaryov | ganso: better to design it exactly not based on generic driver | 16:10 |
ganso | the most important thing is for the data copy service node to mount the share that is exported for VMs | 16:10 |
ganso | I always believed what the generic driver does was the best practice | 16:11 |
ganso | because it attemps to segregate networks and access | 16:11 |
bswartz | ganso: do you have any pros/cons for these different approaches? | 16:11 |
vponomaryov | ganso: it is too different compared to all other | 16:11 |
ganso | the main concern here what I am not familiar with the answer, is that anything related to VIF relies on Neutron node | 16:11 |
bswartz | the generic driver matches the model used by other share-server drivers, but due to limitations in nova and neutron it has to do some awkward things | 16:11 |
vponomaryov | variant 4 looks the best | 16:12 |
bswartz | I think that 3 simply won't work for real hardware | 16:12 |
ganso | like, I suspect that for creating a VIF in the data copy service node, the service would need to be running in the neutron node | 16:12 |
bswartz | and 2 seems like a more complicated approach to get the same effect as 4 | 16:13 |
ganso | if someone can confirm that, then we can forget about pictures 2 and 3 | 16:13 |
bswartz | the reason I like 4 is that there are other benefits | 16:13 |
bswartz | for example the nova-share-attach stuff redhat is proposing will need something like 4 to attach shares on share-server drivers to guests through the hypervisor | 16:13 |
ganso | bswartz: agreed, the main benefit of 4 is that the admin may want to mount shares to perform maintenance... creating a VM just for that is more hassle | 16:14 |
bswartz | vponomaryov: can we make the generic driver do 4? | 16:14 |
vponomaryov | bswartz: yes, also, there were some plans in Neutron to provide admin net | 16:14 |
vponomaryov | bswartz: remember such disscussion logn time ago? | 16:15 |
bswartz | so to go a little deeper into the proposed implementation | 16:15 |
vponomaryov | bswartz: with one note - admin net for neutron, not nova network | 16:15 |
ganso | bswartz: I did not realize you needed admin network for that use case you mentioned | 16:15 |
bswartz | the way I think this needs to work is that when creating a share server, the share server requests a number of IP addresses from the manager for guest network access, and I think it will need to now also request a number of IP addresses from the manager for admin network access | 16:15 |
ganso | vponomaryov: we agreed to deprecate nova network | 16:16 |
ganso | bswartz: share servers with 2 IPs, right? | 16:16 |
ganso | bswartz: for each share server | 16:16 |
bswartz | the administrator will need to setup a network plugin using one of the existing plugins to represent the "admin" network | 16:16 |
bswartz | because something will need to control provisioning of IPs on the admin network | 16:17 |
bswartz | I think the standalone of neutron-single-network plugin could both be used for that function | 16:17 |
ganso | bswartz: yes, that was another point I was going to get into... this setup has to be automatic... DHSS = true drivers should not need administrator intervention | 16:17 |
bswartz | standalone or neutron-single-network plugin | 16:17 |
bswartz | well the administrator is going to have to establish a pool of IPs for use by share servers on the admin network | 16:18 |
bswartz | that should ideally be a one-time step at the beginning | 16:18 |
ganso | bswartz: if it is a one-time only configuration, seems ok | 16:18 |
bswartz | okay so the manager will have 2 network plugins for every driver with share-servers | 16:19 |
bswartz | one network plugin for guest networks and 1 network plugin for the admin network (which will always be flat) | 16:19 |
ganso | bswartz: are you sure it can always be flat? | 16:20 |
bswartz | and the driver will need to request IPs from both | 16:20 |
bswartz | ganso: the admin network is flat by definition | 16:20 |
ganso | bswartz: AFAIK, Suse cloud setup uses vlan for admin network | 16:20 |
bswartz | if you segment your admin network then things can't talk to eachother | 16:20 |
bswartz | how many vlans does it use? | 16:21 |
ganso | bswartz: I am not 100% sure | 16:21 |
ganso | bswartz: just a few, tagged VLAN | 16:21 |
bswartz | if it just uses 1 vlan, then it's still flat | 16:21 |
vponomaryov | summon toabctl | 16:21 |
ganso | bswartz: yes, all admin nodes are in the same VLAN | 16:21 |
toabctl | vponomaryov: ? | 16:21 |
bswartz | if people are using multiple vlans for the admin network, then I agree with have a challenge | 16:21 |
bswartz | we* have a challenge | 16:22 |
vponomaryov | toabctl: does Suse use vlans for admin net? | 16:22 |
vponomaryov | toabctl; 10 comments above | 16:22 |
*** zhongjun22 has quit IRC | 16:22 | |
* ganso hear crickets | 16:24 | |
bswartz | patience... | 16:24 |
bswartz | toabctl might not know | 16:24 |
toabctl | bswartz: just reading the backlog. | 16:25 |
vponomaryov | "what a huge requests have you guys" said DataBase and hang out forever )) | 16:25 |
ganso | vponomaryov: lol | 16:26 |
toabctl | so afaik we support VLANs for the admin network | 16:27 |
bswartz | toabctl: a single VLAN or multiple? | 16:27 |
toabctl | but not sure if multiple vlans are supported. I need to check that | 16:27 |
toabctl | bswartz: ^^ | 16:27 |
bswartz | toabctl: and if multiple, then how do you talk between them? | 16:27 |
bswartz | ok | 16:27 |
*** houming-wang has quit IRC | 16:27 | |
ganso | I am booting my Suse right now lol | 16:27 |
*** houming-wang has joined #openstack-manila | 16:29 | |
toabctl | bswartz: so seems that in the config file you can set a single vlan | 16:29 |
toabctl | I'll ask somebody | 16:30 |
*** houming-wang has left #openstack-manila | 16:30 | |
bswartz | ganso: well we need to ensure that the mechanism for giving network resources to share servers on the admin network is flexible enough to support how people actually configure their admin networks | 16:31 |
*** markstur_ has quit IRC | 16:31 | |
ganso | if the admin network is using VLANs, and the driver needs a neutron plugin, that can be either VLAN or FLAT, can't that be configurable? | 16:31 |
bswartz | ganso: it's a question of what needs to be provided in addition to the IP, netmask, gateway | 16:31 |
bswartz | if we need a segmentation type and segmentation ID then that's something we need to take into account | 16:32 |
bswartz | I think a manila network plugin can provide all of those things | 16:32 |
*** houming has joined #openstack-manila | 16:32 | |
ganso | AFAIK, the plugin will create a network with the given parameters, create a network and attach it to a router, right? | 16:33 |
bswartz | even the flat network plugins can provide those things, right vponomaryov? | 16:33 |
bswartz | if you use the single-neutron-network plugin, it can return a segmentation type and ID if the neutron network has those | 16:33 |
toabctl | so I double checked and the admin net must be native (no vlans) | 16:33 |
bswartz | toabctl: good to know | 16:34 |
ganso | toabctl: great! | 16:34 |
ganso | ok so we decided on picture 4, right? maybe I need to work on a design following that approach decision, like what drivers will need to do and what plugins will be available | 16:35 |
bswartz | ganso: yes | 16:35 |
bswartz | ganso: we just need to make the manager read another config variable when it has a share-network driver | 16:36 |
bswartz | and the manager needs a bunch of code to handle the admin network | 16:36 |
*** houming has quit IRC | 16:37 | |
ganso | hummmmmm | 16:37 |
bswartz | much of that code would be similar to the existing network handling code | 16:38 |
bswartz | when creating a share server, the driver requests IPs, and the manager provides them | 16:38 |
bswartz | but we need to keep the "tenant" IPs and the "admin" IPs separate | 16:38 |
ganso | but driver responsibilities will be only setting a flag and receiving an IP, and using that IP to export the share in that network as well, right? | 16:41 |
ganso | flag = config variable | 16:41 |
bswartz | so the flag that matters is DHSS=true | 16:44 |
bswartz | all drivers with that flag will need to return the number of admin IPs they need per share server, and the manager should provide those IPs similar to how it provides tenant facing IPs | 16:44 |
bswartz | the driver will be expected to know the difference between tenant and admin IPs ,and when creating export locations to tag the admin export locations as admin only (using export location metadata) | 16:45 |
ganso | bswartz: we are agreeing that it will be standard as well... like a minimum requirement? it will affect all existing drivers that implement DHSS = true | 16:46 |
ganso | bswartz: nice way of using export location metadata :) | 16:46 |
bswartz | yes this will need to become a required feature asap | 16:47 |
bswartz | because migration cannot work without it | 16:47 |
ganso | bswartz: yes | 16:47 |
*** nkrinner has quit IRC | 16:50 | |
*** a_ta has quit IRC | 16:51 | |
*** a_ta has joined #openstack-manila | 16:51 | |
*** a_ta has quit IRC | 16:56 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Refactor authorize() method in wsgi.py https://review.openstack.org/246555 | 16:56 |
gouthamr | vponomaryov: Thanks for your comments. Pushed this back up ^^ .. Would love to get this fix in asap to avoid the churn with newer APIs that would want to use it.. | 17:03 |
*** a_ta has joined #openstack-manila | 17:03 | |
vponomaryov | bswartz: neutron network plugin will provide such info. StandAlone network plugin does have "segmentation ID", but not "network type" | 17:10 |
bswartz | vponomaryov: I mean segmentation type (i.e. vlan, vxlan, etc.) | 17:11 |
vponomaryov | bswartz: right | 17:12 |
vponomaryov | bswartz: so, if this one is required, then StandAlone network plugin should be updated | 17:13 |
vponomaryov | bswartz: update is really small | 17:14 |
bswartz | you mean standalone network plugin doesn't currently provide segmentation type? | 17:15 |
bswartz | that seems like a bug | 17:15 |
vponomaryov | yes | 17:16 |
vponomaryov | it doesn't and it is bug | 17:16 |
bswartz | k | 17:16 |
vponomaryov | I can fix it right now | 17:16 |
vponomaryov | bswartz: https://bugs.launchpad.net/manila/+bug/1517987 | 17:18 |
openstack | Launchpad bug 1517987 in Manila "standalone network plugin does not allow to setup network type" [Undecided,New] | 17:18 |
*** akshai has quit IRC | 17:28 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add support of 'network_type' to standalone network plugin https://review.openstack.org/247698 | 17:35 |
vponomaryov | bswartz: ^ | 17:35 |
*** adrianofr has quit IRC | 17:36 | |
bswartz | vponomaryov: I like "segmentation_type" more than network_type | 17:37 |
vponomaryov | bswartz: it is part of share_network model | 17:37 |
vponomaryov | bswartz: also, Neutron uses "network_type" | 17:37 |
vponomaryov | bswartz: liberty-backport-potential? | 17:38 |
bswartz | yes we could backport this | 17:38 |
bswartz | after proper testing | 17:38 |
vponomaryov | bswartz: each conf opt has default value as None | 17:39 |
bswartz | so what gets set today? is it none when the driver sees it? | 17:41 |
vponomaryov | bswartz: in which case? | 17:42 |
bswartz | vponomaryov: also we need validation of the input -- so someone can not set network type to "blahblah" | 17:42 |
bswartz | perhaps negative test too | 17:43 |
vponomaryov | bswartz: it is up to the driver | 17:43 |
bswartz | drivers are expected to validate the option? | 17:43 |
bswartz | that will probably result in duplicate validation code | 17:43 |
vponomaryov | bswartz: I mean each driver can support any netwrok type and any can be setup | 17:44 |
bswartz | seems better to validate it in one place | 17:44 |
bswartz | I know some drivers may support a subset of the valid options, but completely invalid choices should be rejected in a central place | 17:44 |
*** dustins has joined #openstack-manila | 17:45 | |
ganso | bswartz +1 | 17:45 |
vponomaryov | bswartz: https://github.com/openstack/manila/blob/4c265c4f/manila/share/manager.py#L1289 | 17:45 |
vponomaryov | bswartz: so, it is ok already | 17:45 |
*** dustins has quit IRC | 17:46 | |
bswartz | this won't reject invalid network types, it will only reject invalid segmentation ids, assuming the network type is in [None, 'flat', 'vlan', 'vxlan', 'gre'] | 17:47 |
bswartz | a network type of "blahblah" will pass this check regardless of the segmentation id | 17:47 |
*** Zhongjun has quit IRC | 17:47 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add support of 'network_type' to standalone network plugin https://review.openstack.org/247698 | 17:48 |
vponomaryov | bswartz: so, you propose to add check into plugin itself? | 17:49 |
bswartz | yes | 17:49 |
vponomaryov | bswartz: because in case of neutron it is autodiscovered | 17:49 |
bswartz | neutron does its own sanity checking on the values | 17:49 |
bswartz | it's safer to trust what neutron tells us | 17:49 |
bswartz | users could easily put garbage in manila conf file though | 17:49 |
bswartz | if we don't check it in the manila plugin, the error will depend on the driver's own checks | 17:50 |
vponomaryov | bswartz: agree, will add validation | 17:50 |
vponomaryov | bswartz: revert back name of the bug - https://bugs.launchpad.net/manila/+bug/1517987 ? | 17:51 |
openstack | Launchpad bug 1517987 in Manila "Standalone network plugin does not allow to set segmentation type" [High,In progress] - Assigned to Valeriy Ponomaryov (vponomaryov) | 17:51 |
bswartz | sure the bug name doesn't matter so much | 17:52 |
bswartz | I didn't realize "network_type" was already hardcoded in so many places | 17:52 |
*** gouthamr has quit IRC | 17:54 | |
*** breitz has joined #openstack-manila | 17:58 | |
*** sghatty_ has quit IRC | 18:01 | |
*** eduardo_ has quit IRC | 18:02 | |
*** dustins has joined #openstack-manila | 18:05 | |
*** dustins has quit IRC | 18:10 | |
*** lpetrut has quit IRC | 18:18 | |
*** a_ta has quit IRC | 18:19 | |
*** a_ta has joined #openstack-manila | 18:19 | |
*** dcain has joined #openstack-manila | 18:22 | |
*** a_ta has quit IRC | 18:24 | |
*** akshai has joined #openstack-manila | 18:27 | |
*** gouthamr has joined #openstack-manila | 18:27 | |
akshai | rhefner: you around? | 18:28 |
rhefner | akshai: what's up? | 18:29 |
akshai | rhefner: hope you're well. i have this packstack install issue. Execution of '/usr/bin/nova network-create novanetwork --fixed-range-v4 192.168.32.0/22' returned 1: ERROR (CommandError): You must provide a username or user id via --os-username, --os-user-id, env[OS_USERNAME] or env[OS_USER_ID] | 18:31 |
akshai | rhefner: note that it is looking for a username. The username or userid must be specified for the command to execute. But, shouldn't packstack should do this for me?? we get the keystonerc file only after packstack finishes install. | 18:32 |
gouthamr | akshai: this looks like an rdo question, not manila related. | 18:32 |
*** sghatty_ has joined #openstack-manila | 18:33 | |
akshai | rhefner: we can switch over to #rdo? | 18:33 |
rhefner | akshai: ack | 18:34 |
*** ociuhandu has quit IRC | 18:34 | |
*** dustins has joined #openstack-manila | 18:36 | |
*** dustins has quit IRC | 18:38 | |
*** dustins has joined #openstack-manila | 18:42 | |
*** david-lyle has quit IRC | 18:48 | |
*** lpetrut has joined #openstack-manila | 19:04 | |
*** dustins has quit IRC | 19:09 | |
*** JoseMello has quit IRC | 19:14 | |
*** jasonsb has quit IRC | 19:22 | |
*** a_ta has joined #openstack-manila | 19:23 | |
*** akshai has quit IRC | 19:26 | |
*** ociuhandu has joined #openstack-manila | 19:32 | |
*** akshai has joined #openstack-manila | 19:34 | |
*** alyson_ has quit IRC | 19:37 | |
*** david-lyle has joined #openstack-manila | 19:43 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: [WIP] Share Replication API and Scheduler Support https://review.openstack.org/238572 | 19:44 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add functional tests for Manila share replication https://review.openstack.org/244843 | 19:44 |
*** openstackgerrit has quit IRC | 19:46 | |
*** openstackgerrit has joined #openstack-manila | 19:47 | |
*** lpetrut has quit IRC | 19:52 | |
*** timcl1 has joined #openstack-manila | 19:59 | |
*** timcl has quit IRC | 20:00 | |
*** rushil has joined #openstack-manila | 20:11 | |
*** rebase has joined #openstack-manila | 20:29 | |
*** timcl1 has quit IRC | 20:30 | |
*** rebase has quit IRC | 20:31 | |
*** timcl has joined #openstack-manila | 20:32 | |
*** tpsilva has quit IRC | 20:51 | |
*** ayma1 has joined #openstack-manila | 20:53 | |
*** ayma has quit IRC | 20:55 | |
*** timcl has quit IRC | 21:04 | |
*** timcl has joined #openstack-manila | 21:05 | |
*** merooney has quit IRC | 21:09 | |
*** timcl has quit IRC | 21:13 | |
*** abhi has quit IRC | 21:13 | |
*** timcl has joined #openstack-manila | 21:13 | |
*** a_ta has quit IRC | 21:15 | |
*** rhagarty has quit IRC | 21:15 | |
*** a_ta has joined #openstack-manila | 21:16 | |
*** rhagarty has joined #openstack-manila | 21:17 | |
*** a_ta has quit IRC | 21:17 | |
*** a_ta has joined #openstack-manila | 21:17 | |
*** zhongjun2 has quit IRC | 21:17 | |
*** zhongjun has joined #openstack-manila | 21:18 | |
*** a_ta has quit IRC | 21:29 | |
*** a_ta has joined #openstack-manila | 21:30 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Share Replication API and Scheduler Support https://review.openstack.org/238572 | 21:30 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add functional tests for Manila share replication https://review.openstack.org/244843 | 21:30 |
*** a_ta_ has joined #openstack-manila | 21:32 | |
*** rhagarty has quit IRC | 21:34 | |
*** a_ta has quit IRC | 21:34 | |
*** zhongjun has quit IRC | 21:36 | |
*** rhagarty has joined #openstack-manila | 21:36 | |
*** zhongjun has joined #openstack-manila | 21:37 | |
*** sgotliv has quit IRC | 21:39 | |
*** jasonsb has joined #openstack-manila | 21:40 | |
*** jasonsb has quit IRC | 21:45 | |
*** akerr has quit IRC | 21:46 | |
*** rushil has quit IRC | 21:57 | |
*** lpetrut has joined #openstack-manila | 21:58 | |
*** bswartz has quit IRC | 22:02 | |
*** a_ta_ has quit IRC | 22:02 | |
*** a_ta has joined #openstack-manila | 22:03 | |
*** a_ta has quit IRC | 22:08 | |
*** a_ta has joined #openstack-manila | 22:10 | |
*** a_ta has quit IRC | 22:11 | |
*** a_ta has joined #openstack-manila | 22:12 | |
*** eharney has quit IRC | 22:15 | |
*** porrua has quit IRC | 22:15 | |
*** a_ta_ has joined #openstack-manila | 22:17 | |
*** a_ta has quit IRC | 22:17 | |
*** ganso has quit IRC | 22:18 | |
*** zhongjun2 has joined #openstack-manila | 22:20 | |
*** a_ta_ has quit IRC | 22:20 | |
*** zhongjun has quit IRC | 22:21 | |
*** dcain has quit IRC | 22:26 | |
*** abhi has joined #openstack-manila | 22:27 | |
*** lpetrut has quit IRC | 22:28 | |
*** a_ta has joined #openstack-manila | 22:29 | |
*** gouthamr has quit IRC | 22:45 | |
*** pgbridge has joined #openstack-manila | 22:54 | |
*** erlon has quit IRC | 22:59 | |
*** breitz has quit IRC | 22:59 | |
*** a_ta has quit IRC | 23:04 | |
*** a_ta has joined #openstack-manila | 23:05 | |
*** a_ta has quit IRC | 23:10 | |
*** logan2 has quit IRC | 23:10 | |
*** logan2 has joined #openstack-manila | 23:10 | |
*** toabctl has quit IRC | 23:11 | |
*** toabctl has joined #openstack-manila | 23:13 | |
*** rhagarty_ has joined #openstack-manila | 23:18 | |
*** rhagarty has quit IRC | 23:20 | |
csaba | cknight: ping | 23:22 |
cknight | csaba: pong | 23:22 |
csaba | cknight: I answered your question in https://review.openstack.org/229830, pls ping me back if the input is OK with you in light of that or you have a better idea. | 23:25 |
cknight | csaba: thanks, will do | 23:26 |
*** darrenc is now known as darrenc_afk | 23:33 | |
*** ayma1 has quit IRC | 23:34 | |
*** leeantho has quit IRC | 23:34 | |
*** cknight has quit IRC | 23:34 | |
*** leeantho has joined #openstack-manila | 23:35 | |
*** darrenc_afk is now known as darrenc | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!