| folasadef | carloss: I'm working on #45 share_accesses index. Just here to claim it. Please assign to me once you get the chance | 00:24 |
|---|---|---|
| JoyceAnnieGeorge[m] | Hi, my name is Joyce. I am an Outreachy applicant interested in working on the Manila JSON Schema validation project. Can I pick any issue from [here](https://tree.taiga.io/project/gouthampacha-manila-jsonschema-openapi/kanban), and start working on it? Not sure whether I can assign the task to myself or have it assigned by the mentors. carloss gouthamr | 01:36 |
| opendevreview | Folasade Falodun proposed openstack/manila master: Add query schemas for share accesses index https://review.opendev.org/c/openstack/manila/+/1010549 | 02:14 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Remove Wallaby-era deprecated policy rules https://review.opendev.org/c/openstack/manila/+/1010559 | 04:34 |
| opendevreview | Sv Akhil Sai proposed openstack/manila master: Fix NetApp REST driver-assisted volume move Map the ZAPI cutover action wait to REST movement.state cutover_wait, translate cutover_wait and success to the phases the migration workflow already expects, and send cutover and aborted for complete and cancel. Closes-Bug: #2170541 https://review.opendev.org/c/openstack/manila/+/1010198 | 04:47 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Stop parsing WSGI server argv in api entrypoint https://review.opendev.org/c/openstack/manila/+/997161 | 04:59 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add gunicorn test job for manila-api https://review.opendev.org/c/openstack/manila-tempest-plugin/+/1010587 | 05:00 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Remove eventlet dependency https://review.opendev.org/c/openstack/manila/+/997152 | 05:10 |
| OlamideOjo[m] | Hey carloss gouthamr , I’ll be working on adding json schema for share_snapshot.manage | 05:20 |
| denver_baraka | Hi Benita and Joyce, Welcome ! | 06:17 |
| *** ubuntu is now known as Guest2732 | 06:38 | |
| *** Guest2732 is now known as rafaycode | 06:38 | |
| *** rafaycode is now known as rafaycodes | 06:38 | |
| *** ubuntu_ is now known as rafaycodes | 07:15 | |
| rafaycodes | Hi @gouthamr, @carloss, I’m Rafia, an Outreachy applicant for the Manila JSON Schema validation project.My setup is done: Gerrit account and SSH key work, git-review is configured on my Manila clone, and tox -e pep8 and a unit test both pass locally.The project page lists tests under manila/tests/unit/api/v2/, but I found them at manila/tests/api/v2/. Is that the right place for new tests?Could you point me to an endpoint in manila/api/v2 | 07:20 |
| rafaycodes | / that’s free for a first patch? also as a new contributor i need assistence what is the next for me to do to start contribution | 07:20 |
| rafaycodes | The link to the laundpad.net on which the issues are tagged is not working in my area so is there alternative plateform where i can check them out like github etc . | 07:22 |
| hnin-wutt-yi | carloss: Hi carloss, could you please share the link to the Taiga board where the "share network reset status" task is tracked? | 07:30 |
| *** hninwuttyi is now known as hnin-wutt-yi | 07:56 | |
| saurabh[m] | hi gouthamr carloss i am saurabh, joining the manila json schema validation project through outreachy, i have got the development enviroment up on my Ubuntu and i am currently working through the test setup as i will be following the project description and looking at the existing API validation paths, If there is a particular controller or validation path you would suggest me starting with i will begin there....😃 | 08:02 |
| saurabh[m] | * hi gouthamr carloss i am saurabh, joining the manila json schema validation project through outreachy, i have got the development enviroment up on my Ubuntu and the py3 test suite is now passing cleanly, now i will be following the project description and looking at the existing API validation paths, If there is a particular controller or validation path you would suggest me starting with i will begin there....😃 | 08:07 |
| saurabh[m] | * hi gouthamr carloss i am saurabh, joining the manila json schema validation project through outreachy, i have got the development enviroment up on my Ubuntu and the py3 test suite is now passing cleanly, now i will be following the project description and looking at the existing API validation paths, If there is a particular controller or validation path you would suggest me starting with i will begin there...😃 | 08:07 |
| opendevreview | Prudhvi proposed openstack/manila master: Change to raise a patch and trigger NetApp-internal CI https://review.opendev.org/c/openstack/manila/+/1007581 | 09:22 |
| AyeshaAkram[m] | Hi gouthamr carloss | 10:11 |
| AyeshaAkram[m] | #1981626 this bug on https://bugs.launchpad.net/manila/+bugs?field.tag=low-hanging-fruit is unassigned. Would it be okay for me to take this task as my first contribution, or would you recommend starting with a different one? | 10:11 |
| AyeshaAkram[m] | <OlamideOjo[m]> "> <@ayesha_akram:matrix.org..." <- Hi | 10:24 |
| AyeshaAkram[m] | #1981626 this bug on https://bugs.launchpad.net/manila/+bugs?field.tag=low-hanging-fruit is unassigned. Would it be okay for me to take this task as my first contribution? | 10:24 |
| OlamideOjo[m] | It seems a fix has been proposed already | 10:29 |
| OlamideOjo[m] | OlamideOjo[m]: Hello carloss also while debugging this issues, i saw in `manila/api/openstack/wsgi.py` where the comment says that whenever an endpoint has version, the api_version decorator must be the outermost decorator for it to work so I switched the decorator placements thereby placing the api_version decorator above the validation decorator and after doing so, I saw my logs going from 1 failure test to all the tests | 10:35 |
| OlamideOjo[m] | failing (about 27) it frightened me and I had to run to my mentors haha. | 10:35 |
| tessyjames | Hi everyone! I'm Theresa, and I'm participating in the contribution period for the December 2026 Outreachy internship round. I'm interested in the Manila project on implementing JSON Schema Validation in OpenStack Manila REST APIs. I've been getting familiar with the codebase and looking forward to contributing and learning from the community. gouthamr and carloss, I'm glad to be here and look forward to learning from your guidance. | 10:37 |
| tessyjames | Nice to meet you all! | 10:37 |
| OlamideOjo[m] | tessyjames: It’s nice to meet you Theresa and it’s a pleasure having you here | 10:41 |
| tessyjames | Thanks so much OlamideOjo[m]. It's nice to here. Look forward to learning from you. | 10:42 |
| IsongLeonard[m] | Hello everyone, I am Leonard, and I’m excited to join this community as an outreachy applicant. I’m looking forward to learning from everyone, contributing to the project, and collaborating with the community. I’m happy to be here and look forward to getting started. | 10:45 |
| comfortoyewole[m] | IsongLeonard[m]: You're welcome Isong | 10:47 |
| comfortoyewole[m] | s/Isong/Leonard/ | 10:48 |
| IsongLeonard[m] | <comfortoyewole[m]> "You're welcome Isong" <- Thank you Comfort | 10:59 |
| *** hninwuttyi is now known as hnin-wutt-yi | 11:15 | |
| hnin-wutt-yi | Namrata: Have you created share_networks.py? | 11:30 |
| opendevreview | Ragini Sharma proposed openstack/manila master: Add JSON schema validation for snapshot deny_access https://review.opendev.org/c/openstack/manila/+/1010652 | 11:40 |
| RaginiSharma[m] | opendevreview: Hi carloss and gouthamr , I added the json-schema for deny access snapshot , I tested them with tox and created my patch, Please review it..:) | 11:42 |
| Namrata | yes hnin-wutt-yi i have my patch is also up - i created the schema folder that was missing - 1010523: Add JSON schema validation for share network delete | https://review.opendev.org/c/openstack/manila/+/1010523 - this is tha patch link - i just added my schema which was delete | 11:43 |
| Namrata | s/-// | 11:43 |
| RaginiSharma[m] | carloss: i want to take up "quota_sets.show" and work on it could you please assign this to me | 11:56 |
| * carloss logs in for the day and starts reading scrollback | 11:58 | |
| carloss | OlamideOjo[m]: on the schemas failing: what does the schema look like? | 11:59 |
| carloss | JoshuaBamson[m]: I'd reiterate what Goutham mentioned - if there's no mention to it here in the channel and you don't see a patch posted to gerrit, please go for it. As for microversioned schemas, we have some examples on how to do that in the code base, but yes, behavior should be preserved | 12:00 |
| Namrata | hnin-wutt-yi u don't have to make a new file again u can build on mine directly with git review -d 1010523 then add your reset-status schema below delete_response_body and upload. That way we won’t have two files fighting over the same name. carloss gouthamr do u think this could be appropriate? | 12:00 |
| carloss | AyeshaAkram[m]: please go for the task in case there are no takers and no code submitted for it yet | 12:01 |
| carloss | folasadef: #45 sounds good :) | 12:02 |
| carloss | JoyceAnnieGeorge[m]: yes, please feel free to pick up items that don't have implementation or claims for it yet | 12:03 |
| OlamideOjo[m] | carloss:... (full message at <https://matrix.org/oftc/media/v1/media/download/AZxG8Yp-kAHN89Jgxx6XjNhAMzkueJzQWJrrJwsVtNnh3AVTdX6O90Z05bKrh153vyYJ_ZBUKZNh_j_lhr9pqjFCehh4smFwAG1hdHJpeC5vcmcvd2x4cnpNUmdFdlZEYkhtV3NvQndTY1RL>) | 12:03 |
| opendevreview | Ragini Sharma proposed openstack/manila master: Add JSON schema validation for snapshot deny_access - Add request and response body schemas for the snapshot - deny_access API and update the unit tests accordingly. https://review.opendev.org/c/openstack/manila/+/1010652 | 12:03 |
| AyeshaAkram[m] | carloss: is this task 45? | 12:03 |
| hnin-wutt-yi | carloss: Could you suggest should I create new file like Narmata did, this is my first time of contribution could you guide me to do my task which is reset_status API? | 12:04 |
| carloss | OlamideOjo[m]: I think share snapshot manage is already taken by Maria Isabel - another intern we have | 12:04 |
| OlamideOjo[m] | carloss: okay carlos | 12:05 |
| carloss | > Is that the right place for new tests?Could you point me to an endpoint in manila/api/v2 | 12:05 |
| carloss | rafaycodes the correct place is manila/tests/api/v2 - I think the /unit was a typo from when we first implemented it | 12:05 |
| carloss | AyeshaAkram[m]: welcome :) sounds good | 12:05 |
| carloss | welcome tessyjames :) | 12:06 |
| carloss | or welcome everyone | 12:06 |
| carloss | AyeshaAkram[m]: yes, the one you referred to earlier | 12:06 |
| comfortoyewole[m] | carloss: I was assigned this api related bug in the previous contribution phase... (full message at <https://matrix.org/oftc/media/v1/media/download/Afq7Jpa-LXx_qa_Z3C22BuU-PK2MCYBAyqIlPHi94RxLokZO34tStrBQJ8vie1Kw5S09K5YPC2Vo-yACfnYZ6JpCehh4-MsAAG1hdHJpeC5vcmcvaUtyRFViR1RqZ2tSQ0NZT0NOZU1nYXdG>) | 12:08 |
| carloss | > hnin-wutt-yi u don't have to make a new file again u can build on mine directly with git review -d 1010523 then add your reset-status schema below delete_response_body and upload. That way we won’t have two files fighting over the same name. carloss gouthamr do u think this could be appropriate? | 12:10 |
| carloss | hnin-wutt-yi Namrata there are two ways to work on this: 1. it should be okay each of you to create the files and then fix the merge conflict later or 2. one of you checks out to the change that has already been proposed and then build on top of it with another commit... For both there's still a big chance you'll need to sort out merge conflicts | 12:10 |
| OlamideOjo[m] | carloss: Hey Carlos is this referring to me? | 12:11 |
| carloss | OlamideOjo[m]: nope, message above was mostly on the share networks situation | 12:11 |
| carloss | getting to you in a bit | 12:11 |
| carloss | it requires more time for me to analyze | 12:11 |
| OlamideOjo[m] | yes yes I understand, ill be on standby | 12:12 |
| carloss | comfortoyewole[m]: we didn't manage to review it in time for the feature freeze. the change you rebased is a great addition to the project but it bumps the api microversion | 12:12 |
| carloss | but yes, it's still something the team plans on working on | 12:12 |
| Namrata | carloss: ok, my change (1010523) is already up, so Hnin is welcome to build on it with git review -d 1010523 or create her own copy whichever she prefers. I’ll rebase if mine ends up merging second. | 12:12 |
| hnin-wutt-yi | carloss Namrata: thank you for the guidance. I will follow create my own change since this is my first contribution. | 12:12 |
| hnin-wutt-yi | I will study Namrata’s change and the existing reset_status examples, then upload my patch. | 12:12 |
| Namrata | hnin-wutt-yi: sounds great Hnin good luck :) | 12:16 |
| hnin-wutt-yi | Namrata: Thanks for your kindness | 12:17 |
| comfortoyewole[m] | carloss: carloss: Okay, thanks for the clarification. | 12:19 |
| comfortoyewole[m] | If it's okay by you, I'm still very interested in working on it until it gets reviewed. I'd love to finish what I started already. | 12:19 |
| comfortoyewole[m] | Leye Sam might likely need to be assigned a different task then. | 12:19 |
| tessyjames | carloss: Hi Carlos, I'd like to pick up Manila bug https://bugs.launchpad.net/manila/+bug/2037285 regarding NetApp VLAN creation with an optional target broadcast domain. noticed it was assigned to Gireesh in December 2025, but I haven't found an implementation so far. Since you mentioned that we can pick up issues without an implementation, I wanted to confirm whether this one is still being actively worked on or if I can take it up and | 12:30 |
| tessyjames | if so, can it be reassigned to me. Thanks! | 12:30 |
| AyeshaAkram[m] | I wanted to clarify one thing before I start working on a bug. Should I look for tasks in the Taiga board or choose a bug from the Manila Launchpad bug tracker? I just want to make sure I'm looking in the right place. | 12:39 |
| OlamideOjo[m] | <AyeshaAkram[m]> " I wanted to clarify one thing..." <- > <@ayesha_akram:matrix.org> I wanted to clarify one thing before I start working on a bug. Should I look for tasks in the Taiga board or choose a bug from the Manila Launchpad bug tracker? I just want to make sure I'm looking in the right place. | 12:44 |
| OlamideOjo[m] | > | 12:44 |
| OlamideOjo[m] | You can pick issues from both | 12:44 |
| AyeshaAkram[m] | Hi! carloss I noticed that this Bug #1981626 isn’t currently assigned to anyone. I’m interested in working on it. Could it be assigned to me, please? 😊 | 12:50 |
| carloss | OlamideOjo[m]: so the tests will need to change a bit... the old way we did the validation for the body will change as a result of introducing the new schemas | 12:50 |
| carloss | https://review.opendev.org/c/openstack/manila/+/959171 would be a good direction to follow | 12:50 |
| carloss | we dealt with something similar on this change | 12:50 |
| carloss | tessyjames: that issue should be fine and it comes with additional problems: 1. lack of hardware to test it and 2. needs some oversight from NetApp engineers - would you be comfortable picking up some json schemas? | 12:51 |
| carloss | AyeshaAkram[m]: if you don't see something on launchpad, yes, please feel free to pick up json schemas | 12:52 |
| carloss | the bug you linked though has a fix proposed: https://review.opendev.org/c/openstack/manila/+/858356 | 12:53 |
| carloss | maybe we can look at the feedback and continue its implementation? | 12:53 |
| carloss | that would also be a good way to contribute | 12:53 |
| kimaiyoo | Hi everyone, i'm Naomi. I'm an Outreachy applicant also looking at the JSON Schema validation project for Manila. I'm currently getting my local Ubuntu environment and Gerrit workflow set up. Looking forward to contributing and learning from you all. | 12:53 |
| carloss | welcome | 12:54 |
| carloss | :) | 12:54 |
| tessyjames | carloss: Thanks, Carlos! I'd be happy to work on the JSON Schema validation effort. Would you recommend a particular endpoint or controller where schema validation is still missing, or should I audit manila/api/v2/ and select an endpoint that hasn't already been picked up by another contributor? | 13:02 |
| carloss | tessyjames: working on available un-implemented validations is fine | 13:08 |
| RaginiSharma[m] | <RaginiSharma[m]> "carloss: i want to take up "..." <- Hello carloss , can i take up this , I am seeing its unassigned so . Shell i work on it | 13:10 |
| tessyjames | carloss: Thanks! | 13:10 |
| tkajinam | gouthamr carloss, hi. I've seen that there are some recent on-going works to add native openstacksdk for manila resources. Is there any plan/aim to drop manilaclient at some point after all the required features are added to sdk ? | 13:14 |
| carloss | tkajinam: hey there. yes, we do plan on that | 13:14 |
| tkajinam | the context behind the question is that in that case we should plan replacing manilaclient in heat by sdk | 13:15 |
| carloss | we're migrating stuff to openstacksdk and python-openstackclient | 13:15 |
| carloss | to leverage the performance and the benefits of being in-tree | 13:15 |
| tkajinam | ok | 13:15 |
| tkajinam | carloss, do you have any specific timeline for retirement in your mind ? | 13:16 |
| tkajinam | due to resource limitations I don't expect we can complete or even start that replacement in quite short time and I'd like to make sure that the client binding may not go away before the migration is done. | 13:18 |
| tkajinam | I'm fine with removing the manila cli but the retiring the whole manilaclient is a different story, as you can imagine | 13:19 |
| carloss | tkajinam: no specific timelines at the moment, but I honestly don't see we completing that migration in a cycle or two for example | 13:21 |
| carloss | thanks for bringing this up | 13:22 |
| carloss | we understand sunseting manilaclient has bigger impact, so we won't be too radical with it and try doing it with enough notice | 13:22 |
| carloss | I think of it as the same as we did with openstackclient: we reached feature parity in Zed, we kept the deprecation warning for a while and after some years we actually removed | 13:23 |
| tkajinam | carloss, thanks. because I saw the team made a good process so I was worried about the time coming too soon :-P | 13:23 |
| carloss | tkajinam: sorry, let me make myself more clear on this because I got confused while answering: we do plan on making progress on openstacksdk, yes, the thing I said that is untrue is that we're using it for openstackclient right now... we ourselves are still using manilaclient, so that makes us dependent on it as well | 13:28 |
| carloss | RaginiSharma[m]: yes, please go for it | 13:28 |
| tkajinam | ah ok | 13:29 |
| OlamideOjo[m] | carloss: Ack, will get it done | 13:36 |
| RaginiSharma[m] | We have team meeting today right | 13:41 |
| carloss | RaginiSharma[m]: we do have PTG, yes... it will start in ~18 minutes | 13:42 |
| RaginiSharma[m] | Ok thank you | 13:43 |
| OlamideOjo[m] | carloss: Just to be sure the weekly Manila IRC meeting won’t hold because the ptg cuts across it right? | 13:44 |
| carloss | yes, that is correct | 13:44 |
| RaginiSharma[m] | OlamideOjo[m]: Oh ok | 13:45 |
| OlamideOjo[m] | carloss: Thank you(: | 13:45 |
| folasadef | gouthamr: carloss Hi! While working on my patch, I noticed a small bug in manila/api/schemas/share_snapshots.py around lines 90, 105, and 115. Each .update() that should add parameters to one newer version adds them to all versions. So, every microversion has the same schema, and the version-specific design does nothing. I might be wrong?! is someone working on this? I can take it as my next contribution? | 13:45 |
| * folasadef uploaded an image: (13KiB) < https://matrix.org/oftc/media/v1/media/download/AfbD_fJP2B-u2PNja0WPJ2Fzu2EI7_1zOzln6zwEmiPqfmpncZ3eYsjKnxw-JT-dWZGWRKF1azr_-GT8p60PAyhCehh-kBgAAG1hdHJpeC5vcmcvckFaUEVsZWJjSHpobVVLWlhVbU5ERWVV > | 13:45 | |
| * folasadef uploaded an image: (29KiB) < https://matrix.org/oftc/media/v1/media/download/ARmITf5pfQ_Fzs_VlA7Qnf7JfF6h_yfvw6bCy7pZKc1LQ2Sf_WoawLVu5Hq015dyf_u99PLlWapED3uONKZHFQpCehh-kzbwAG1hdHJpeC5vcmcvRHVJTnVJZmRiZ0hZVHlGTmhlWkphcEZx > | 13:46 | |
| ghufran | hello | 13:47 |
| folasadef | Hi Ghufran, welcome | 13:48 |
| tessyjames | carloss: Hi Carlos, I’m considering working on `ShareNetworkSubnetController` for the JSON Schema validation project and wanted to clarify the expected scope before I start. My proposed approach is to begin with the `create()` endpoint, add the relevant JSON Schemas and tests, and submit the change for review before proceeding to the other endpoints. However, since the schema audit checks at the controller level, I’m concerned t | 14:17 |
| tessyjames | hat without `@validation.validated`, the audit wouldn’t check the controller, so passing the endpoint’s unit tests alone wouldn’t guarantee that the migration meets the project’s schema-validation requirements. Would it be acceptable to migrate and submit one endpoint at a time, or would you prefer that I migrate all relevant endpoints locally, add `@validation.validated`, run the complete schema audit, and submit the con | 14:17 |
| tessyjames | troller migration as a single review? If incremental review is acceptable, how would you recommend coordinating the subsequent changes while the first patch is still under review, so I can continue making progress without creating conflicting or unnecessarily dependent patches? I’d appreciate your guidance so I can approach the work in line with the project’s expectations. Thanks! | 14:17 |
| Namrata | Hi carloss gouthamr @everybody I would like to work on Add JSONSchema validation: shares.create_metadata() [v2.0+] i saw it was unassigned and it looked like card 8 Set / Update and Delete Share Metadata is not touching create metadata so i think there should be no overlap, didn't found anything on gerrit either. If anyone else is currently working on it please lmk | 15:01 |
| opendevreview | Adeola Adesina proposed openstack/manila master: Add global_request_id to Nova, Cinder, and Neutron https://review.opendev.org/c/openstack/manila/+/1010705 | 15:11 |
| AyeshaAkram[m] | Hi! carloss I’ve been exploring the available Manila tasks and came across the Taiga issue **“Add JSONSchema validation: quota_sets.show() [v1.0-2.6, v2.7+]”**. It looks like a potential task I could work on, but it currently has no description or assignee, so I’m not sure about its exact scope. | 15:59 |
| AyeshaAkram[m] | Would it be okay for me to pick up this task? If so, could you please assign it to me or guide me on where to start? Alternatively, if there’s another unassigned bug or JSON Schema task that would be a better starting point, I’d really appreciate your recommendation. | 15:59 |
| AyeshaAkram[m] | I’m eager to get started, understand the project’s conventions, and make a meaningful contribution. | 15:59 |
| RaginiSharma[m] | Ayesha Akram: I was working on it, But you can take up this one. I have'nt created patch yet. for this please explore manila/api/v2/quota_sets.py, here you can find it, and go ahead | 16:07 |
| tessyjames | carloss: Hi Carlos! I have been seeing some issue regarding the JSON Validation not included on the bug tracker. You asked me ealier if I could like to contribute to it and I said yes. I want to know if there's a separate task board for it other that https://bugs.launchpad.net/manila. If so, can I get a link to it so I can start my contribution. Thanks! | 16:07 |
| AyeshaAkram[m] | RaginiSharma[m]: Sure. Thank you! | 16:08 |
| RaginiSharma[m] | Hey carloss , I want to work on quota_sets.detail(), As its unassigned, can i claim it , Please assign it to me | 16:16 |
| tessyjames | AyeshaAkram[m] and RaginiSharma[m]: Please is there any specific board where this tasks are listed because they are not on the bug tracker. Is so, can you guys please share the link. carloss already asked if I want to work on the JSON Validation and it's not on launchpad. Thanks. | 16:18 |
| RaginiSharma[m] | U cab refer taiga | 16:22 |
| RaginiSharma[m] | * U can refer taiga | 16:22 |
| RaginiSharma[m] | * You can refer taiga | 16:22 |
| tessyjames | RaginiSharma[m]: Could you please share the link to the taiga board? | 16:27 |
| OlamideOjo[m] | tessyjames: here it is: | 16:29 |
| OlamideOjo[m] | https://tree.taiga.io/project/gouthampacha-manila-jsonschema-openapi/kanban | 16:29 |
| tessyjames | OlamideOjo[m]: Thanks so much! | 16:30 |
| OlamideOjo[m] | <adeolaadesina[m]> "How can I assign a task to..." <- claiming it here is sufficient. you cant assign yourself a task | 16:31 |
| OlamideOjo[m] | tessyjames: you're welcome | 16:31 |
| tessyjames | OlamideOjo[m]: I can claim a task here and that's automatically assigned to me? I can move it to progress? | 16:32 |
| OlamideOjo[m] | No, You would first tell the mentors you want to work on this particular task and then if it hasn't already been assigned, it would be assigned to you then you can make progress | 16:34 |
| AyeshaAkram[m] | <RaginiSharma[m]> "Ayesha Akram: I was working on..." <- Well the details about the bug is not mentioned here and can you please tell me how i can assign it to myself now? | 16:40 |
| RaginiSharma[m] | AyeshaAkram[m]: Yeahh , you have to ask mentors to assign it you | 16:41 |
| AyeshaAkram[m] | carloss: gouthamr Can you please assign me this task | 16:43 |
| n_kimaiyo | Hi carloss, gouthamr. I have been reviewing quota_sets.py. Could I claim task #43 quota_sets.delete() for my first patch as I see it's still unassigned? | 16:53 |
| JoyceAnnieGeorge[m] | carloss: Can I start working on share_networks.update()? Not sure whether anyone else is working on it. | 17:15 |
| carloss | folasadef: is it breaking other existing tests? | 18:04 |
| carloss | tessyjames I think adding validation.validated at the time we complete all the schema validations should be okay | 18:05 |
| carloss | sorry everyone, busy PTG days, hard to keep up with this chat | 18:07 |
| carloss | JoyceAnnieGeorge[m]: please go for it | 18:09 |
| carloss | RaginiSharma[m]: done, assigned quota sets detail to you | 18:14 |
| gouthamr | AyeshaAkram[m]: regarding #1981626, go ahead and submit a fix, we'll assign it to you | 18:18 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add JSON Schema validation for shares.manage() [v2.7] https://review.opendev.org/c/openstack/manila/+/1010730 | 18:20 |
| gouthamr | OlamideOjo[m]: hey there, regarding the api version needing to be the outermost decorator, can you push up your change so we can see the failures. i see _some_ cases where the rule is violated. What did you find? | 18:23 |
| gouthamr | welcome new folks: https://etherpad.opendev.org/p/r.f30f6f0995fc5b11b6b1a09186798725 | 18:27 |
| gouthamr | please note, we're having a busy week of meetings, so reviews are invariably delayed. We'll however make time and look; please keep reviewing each others' patches while you're here - and thank you for contributing! | 18:27 |
| gouthamr | /me will set this into the channel topic | 18:27 |
| OlamideOjo[m] | gouthamr: Hey gouthamr , its a coincidence as you texted i pushed the change. I found out that the request body was being passed positionally instead of as a keyword argument So i made the neccesary changes from my test failure logs | 18:29 |
| gouthamr | tkajinam: adding to what carloss said - its a good idea to start with the sdk replacement in heat, and let us know if you find any gaps.. we sure have some tech/debt gaps - but i haven't looked at the gaps in the last cycle or so :( the sunset date for manilaclient's SDK is TBD - we haven't marked it deprecated.. so like you folks mentioned, it'd be in the order of years rather than requiring a fire drill right away | 18:30 |
| gouthamr | tkajinam: our immediate plan is to move all the openstack CLI commands from the manilaclient package to OSC... and while we're doing that we're not migrating the sdk usage ourselves | 18:31 |
| gouthamr | manila-ui also uses the manilaclient sdk, and we've not started any migration there either... so definitely no rush, but, if you were planning for a tech debt item to tackle in heat, it is a good direction :) | 18:32 |
| gouthamr | tessyjames: merge conflicts with ongoing work is certainly a blocker, but, don't worry about it for now. Just try your best to submit your change, and we'll figure out how merge conflicts get resolved as we review | 18:38 |
| gouthamr | tessyjames: i'd still keep changes small and testable - you don't need to work on an entire resource at once | 18:38 |
| OlamideOjo[m] | Unknowing to me, i claimed the share snapshot manage not knowing it was assigned to Maria Isabel(an oversight), because i noticed its changes were a bit more than just schema validation(like share.manage) So Maria Isabel I want to ask if you're still working on it if not i could get down to it? | 18:39 |
| gouthamr | Namrata: go for it - like i mentioned before, we're not assigning taiga cards proactively. Please check the review queue before you start, at worse you're duplicating work and we'll only ever merge one of the changes. But, you're learning in the process and showing us your skills... | 18:40 |
| gouthamr | OlamideOjo[m]: Maria isn't on the channel right now, you can comment on her gerrit change if you plan to help her with it or ask questions | 18:42 |
| OlamideOjo[m] | gouthamr: okay thank you very much for the guide | 18:46 |
| opendevreview | Merged openstack/puppet-manila master: Deprecate support for [oslo_policy] enforce_scope https://review.opendev.org/c/openstack/puppet-manila/+/997083 | 18:46 |
| OlamideOjo[m] | gouthamr: Do you mind pointing me in the direction of her gerrit change? | 18:47 |
| OlamideOjo[m] | i cant seem to find it gouthamr | 18:47 |
| *** ChanServ changes topic to "OpenStack Shared File System Service | Documentation: https://docs.openstack.org/manila/latest/ | Meetings: https://wiki.openstack.org/wiki/Manila/Meetings | Channel History: https://meetings.opendev.org/irclogs/%23openstack-manila/ | Indri Project Teams Gathering (Oct 12-16) is ongoing (https://ptg.opendev.org/ptg.html); Outreachy applicants look here: " | 18:47 | |
| gouthamr | OlamideOjo[m]: oh you mean you found the card on Taiga assigned to Maria? | 18:48 |
| OlamideOjo[m] | gouthamr: No haha, it was carloss that mentioned it was assigned to her | 18:49 |
| gouthamr | i see, i've only been skimming scrollback | 18:50 |
| OlamideOjo[m] | gouthamr: gouthamr: its currently not assigned on taiga tho | 18:50 |
| OlamideOjo[m] | gouthamr: I can understand, a lot of workload | 18:51 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: api: enforce API version decorator order https://review.opendev.org/c/openstack/manila/+/1010754 | 19:14 |
| folasadef | carloss: No, the current copy.copy doesn’t break any existing tests, which is probably why it went unnoticed. | 19:41 |
| gouthamr | folasadef: thanks, that's a good gap to close then; please file a bug and probably add some tests while you're at it! | 19:42 |
| folasadef | gouthamr: Sweet. i'll report it on launchpad | 19:47 |
| OlamideOjo[m] | hello carloss gouthamr , is | 20:32 |
| OlamideOjo[m] | Add JSONSchema validation: shares.delete_metadata() [v2.0+] claimed cause id like to? | 20:32 |
| carloss | hey OlamideOjo[m] I believe it's not taken yet... if you don't see a patch or a claim for it on the channel yet, please go for it | 20:55 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api: Add schemas for share_groups https://review.opendev.org/c/openstack/manila/+/1010069 | 20:58 |
| OlamideOjo[m] | carloss: okay thank you | 20:58 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api: Add schemas for share_replicas https://review.opendev.org/c/openstack/manila/+/1010072 | 20:58 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api: Add schemas for share_types https://review.opendev.org/c/openstack/manila/+/1010074 | 20:58 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api: Add schemas for share_group_snapshots https://review.opendev.org/c/openstack/manila/+/1010070 | 20:59 |
| gouthamr | folks, a reminder about the contributor and maintainer surveys for Hibiscus; if you were a contributor/maintainer .. please fill this out: | 21:59 |
| gouthamr | maintainer survey: https://openinfrafoundation.formstack.com/forms/openstack_maintainer_experience_survey | 21:59 |
| gouthamr | contributor survey: https://openinfrafoundation.formstack.com/forms/openstack_contributor_experience_survey | 21:59 |
| gouthamr | OlamideOjo[m]: you brought this issue to my attention: https://review.opendev.org/c/openstack/manila/+/1010754 | 22:01 |
| gouthamr | thanks! | 22:01 |
| AyeshaAkram[m] | Hi! I've started investigating the `Add JSONSchema validation: quota_sets.show()` task.... (full message at <https://matrix.org/oftc/media/v1/media/download/AZ1KTGEgK7GmBF66T-5pXr_6OCnfW-AItd_jCMLLsZOsH-8qLByz0b5HbZMqG5DgRsDr4CamOgiHm-8JQEVryC1Cehib6_bQAG1hdHJpeC5vcmcvSWdMcHZtSEVCa0ZxcGRqRnFPeWNCb01o>) | 22:19 |
| AyeshaAkram[m] | * Hi! carloss gouthamr I've started investigating the `Add JSONSchema validation: quota_sets.show()` task.... (full message at <https://matrix.org/oftc/media/v1/media/download/AWzyEkmYQJACNLZD7EhO9TwV8XMQx59tAHtxn6QgHK598w9xOUDkIT64ni0ua0dZvhTqgKeA93qe-k8H9RVRntpCehib-PJwAG1hdHJpeC5vcmcvV0twSWpnUUJ6cHdwWGlVRGlxZUpEWXpY>) | 22:19 |
| opendevreview | Faiqa Iqbal proposed openstack/manila master: Add schema validation for update snapshot API https://review.opendev.org/c/openstack/manila/+/1010786 | 22:58 |
| faiqa | gouthamr, carloss: I pushed my patch for Update snapshot: https://review.opendev.org/c/openstack/manila/+/1010786. | 23:05 |
| faiqa | I added a schema for the request body and the decorator on update. I kept unknown keys allowed because an existing test needs that, and I allowed null because the old code accepted it. | 23:08 |
| gouthamr | faiqa: thanks, if it's a unit test that's sending up mocked/bogus types it can be fixed alongside the change | 23:12 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!