| tessyjames | OlamideOjo[m]: Thanks | 00:41 |
|---|---|---|
| saurabh[m] | honestly i feel like we should stop using ai just for communication 🙏🏻 just type what u think and figure things out on your own and we will actually get to know how people think... | 01:58 |
| saurabh[m] | <AyeshaAkram[m]> "Hi! I've started investigating..." <- > <@ayesha_akram:matrix.org> Hi! carloss gouthamr I've started investigating the `Add JSONSchema validation: quota_sets.show()` task.... (full message at <https://matrix.org/oftc/media/v1/media/download/AQt0ev6Xrn2oCl4_7ELGtQDwns9o0G0PxHb3ts6PncCe9KwBQlDj_5On32UwZ6GZocPZ90D7Y4OBiCR8YKcvfFlCehiot36gAG1hdHJpeC5vcmcvcnJxV2ZKS2lpZElvV3JlU3NtUUNsSktE>) | 02:02 |
| opendevreview | Hnin Wutt Yi proposed openstack/manila master: Add JSON schema validation for share network reset_status https://review.opendev.org/c/openstack/manila/+/1010791 | 02:12 |
| hninwuttyi | carloss: Hi Carlos! I have submitted my patch for share network reset_status JSON schema validation at https://review.opendev.org/c/openstack/manila/+/1010791. I've added you as a reviewer. Please review it whenever you have time. Thank you | 02:23 |
| delightubah[m] | Hello everyone, I’m Delight (delightubah), an Outreachy applicant for the Manila JSON Schema validation project. My background is Python, Linux, and DevOps. I’m reading through the merged schemas and the open json-schema-validation patches to learn the patterns, and I’ll start reviewing while I finish my dev setup. gouthamr carloss, glad to be here! | 03:37 |
| *** ChanServ changes topic to "OpenStack Shared File System Service | Documentation: https://docs.openstack.org/manila/latest/ | Channel History: https://meetings.opendev.org/irclogs/%23openstack-manila/ | Indri Project Teams Gathering (Oct 12-16) is ongoing (https://ptg.opendev.org/ptg.html); Outreachy applicants look here: https://etherpad.opendev.org/p/r.f30f6f0995fc5b11b6b1a09186798725" | 04:19 | |
| denver_baraka | hi Delight, Welcome ! | 04:27 |
| delightubah[m] | Thanks denver_baraka. I appreciate the warm welcome | 04:45 |
| *** hninwuttyi is now known as hnin-wutt-yi | 06:27 | |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Maintain driver dependencies https://review.opendev.org/c/openstack/manila/+/997487 | 06:59 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Remove unused test dependencies https://review.opendev.org/c/openstack/manila/+/1010822 | 07:01 |
| OlamideOjo[m] | gouthamr: Hello carloss, sorry im just seeing this, was an oversight. I would check this out | 07:05 |
| delightubah[m] | gouthamr carloss: I noticed that ShareController.detail doesn’t drop "with_count" below 2.42 the way index does (index drops it at manila/api/v2/shares.py line 1597; detail, starting at line 1613, has no such check), though the API reference lists 2.42 for both. Is that intentional? | 07:28 |
| opendevreview | Joyce Annie George proposed openstack/manila master: Add JSON schema validation for update-share-network https://review.opendev.org/c/openstack/manila/+/1010825 | 07:31 |
| JoyceAnnieGeorge[m] | opendevreview: carloss: gouthamr Can you please review the changes for https://tree.taiga.io/project/gouthampacha-manila-jsonschema-openapi/us/51?kanban-status=9611454 | 07:42 |
| JoyceAnnieGeorge[m] | ? | 07:42 |
| JoyceAnnieGeorge[m] | carloss: gouthamr I would like to start working on [share_networks.details](https://tree.taiga.io/project/gouthampacha-manila-jsonschema-openapi/us/50?kanban-status=9611452). Can you please assign the ticket to me? | 07:49 |
| JoshuaBamson[m] | Hi gouthamr and carloss ,... (full message at <https://matrix.org/oftc/media/v1/media/download/ATj6BfKLS-FKCGjgXSAioSOjkRhy4gWFnbHEvKon05dMoytg3VY9kOvie9UTFTx5KbNp5TbR-vjDMNlJ1CgbO-1CehjCHL_AAG1hdHJpeC5vcmcvTGxFd2dpSEtlTmV3TEZxcW1LdEtWRW1Z>) | 09:26 |
| JoshuaBamson[m] | s/Taiga//, s/quota_sets/quota\_sets/, s/quota_sets/quota\_sets/ | 09:32 |
| delightubah[m] | * Hello everyone, I’m Delight (delightubah), an Outreachy applicant for the Manila JSON Schema validation project. My background is Python, Linux, and DevOps. I’m reading through the merged schemas and the open json-schema-validation patches to learn the patterns, and I’ll start reviewing while I finish my dev setup. [gouthamr](https://matrix.to/#/@_oftc_gouthamr:matrix.org) | 09:38 |
| delightubah[m] | [carloss](https://matrix.to/#/@_oftc_gouthamr:matrix.org), glad to be here! | 09:38 |
| delightubah[m] | * setup. gouthamr [carloss, * carloss](https://matrix.to/#/@_oftc_carloss:matrix.org), glad | 09:40 |
| delightubah[m] | * [gouthamr](https://matrix.to/#/@_oftc_gouthamr:matrix.org) [carloss](https://matrix.to/#/@_oftc_carloss:matrix.org): I noticed that ShareController.detail doesn’t drop "with_count" below 2.42 the way index does (index drops it at manila/api/v2/shares.py line 1597; detail, starting at line 1613, has no such check), though the API reference lists 2.42 for both. Is that intentional? | 09:41 |
| opendevreview | Siddharth Kumar proposed openstack/manila master: Dell PowerScale: Deny default share access https://review.opendev.org/c/openstack/manila/+/1009153 | 09:43 |
| folasadef | <JoshuaBamson[m]> "Hi gouthamr and carloss ,..." <- Joshua Bamson: Hi Joshua, if the task says In Progress, check if someone dropped a comment. I bet someone is already working on the In progress ones. Look for a task under the NEW section on taiga | 10:00 |
| delightubah[m] | <JoshuaBamson[m]> "Hi gouthamr and carloss ,..." <- Yeah, I think 2 days ago, [lizzykate](https://matrix.to/#/@_oftc_lizzykate:matrix.org) already asked for #41. To avoid facing same scenario again, you may want to look for a different task | 10:03 |
| delightubah[m] | s/[lizzykate](https://matrix.to/#/@/@/, s/)// | 10:04 |
| delightubah[m] | s/https://matrix.to/#/@/@/ | 10:04 |
| delightubah[m] | * Yeah, I think 2 days ago, [lizzykate](https://matrix.to/#/@_oftc_lizzykate:matrix.org) already asked for #41. To avoid facing same scenario again, you may want to look for a different task | 10:05 |
| opendevreview | Naomi Jepkorir proposed openstack/manila master: Add JSON schema validation for quota_sets.delete() https://review.opendev.org/c/openstack/manila/+/1010848 | 10:08 |
| AyeshaAkram[m] | <JoshuaBamson[m]> "Hi gouthamr and carloss ,..." <- task #39 is assigned to me. I am working on it | 10:39 |
| folasadef | * a comment on the task page or here. I | 10:51 |
| tessyjames | carloss: Hi Carlos. I am picking up task #81. Can you please assign it to me. I am working on it. Thanks | 10:57 |
| AyeshaAkram[m] | Hi carloss for task 39,i want to know the validation should apply on request or the response or both? i am looking in the implementation and the existing code | 11:01 |
| OlamideOjo[m] | hello carloss gouthamr While going through Add JSONSchema validation: shares.delete_metadata() [v2.0+]”, I noticed that the endpoint currently accepts any query parameters. So should we keep the schema empty (`{}`), or are there any specific query parameter restrictions we should add for this endpoint? | 11:12 |
| AyeshaAkram[m] | * Hi carloss for task 39 quota_sets.show(),i want to know the validation should apply on request or the response or both? i am looking in the implementation and the existing validate decorators in other controller. i see that request validates check the query parameters and response validation checks the structure of body so I am unsure do we have to look for both? | 11:13 |
| carloss | JoyceAnnieGeorge[m]: done, assigned share networks detail to you | 11:49 |
| carloss | JoshuaBamson[m]: #41 is available, assigning it to you | 11:50 |
| carloss | welcom delightubah[m] :) | 11:50 |
| carloss | just realized there was another mention to #41 | 11:51 |
| carloss | tessyjames: ack | 11:52 |
| carloss | thank you for picking it up | 11:52 |
| carloss | AyeshaAkram[m]: for #39 I think we're looking for both request and response validations | 11:52 |
| tessyjames | carloss: Hi Carlos, thanks! Meanwhile, for the ShareTransferController.delete(), I noticed that the method currently returns HTTP 200 OK instead of 204 No Content. Existing delete methods like manila/api/v2/messages.py (MessagesController.delete()) and manila/api/v2/resource_locks.py (ResourceLocksController.delete()) return HTTP 204 No Content. Would it be appropriate to update ShareTransferController.delete() to return HTTP 204 as well, | 12:00 |
| tessyjames | or should preserve the existing HTTP 200 response for backward compatibility? Although further check shows that delete() is only available for v2.77+. I wanted to check before making a change to the endpoint's response status. Thanks! | 12:00 |
| carloss | tessyjames: good question - I think at the moment if we change that will mean we'll need to bump the api microversion | 12:01 |
| carloss | tessyjames: wait a bit... | 12:02 |
| carloss | where did you see the 204 response? | 12:02 |
| tessyjames | carloss: Okay | 12:02 |
| tessyjames | for message.py and resource_lock.py delete methods. They return 204 No Content for status | 12:04 |
| carloss | ah, ack | 12:04 |
| carloss | good catch | 12:04 |
| carloss | i think we missed that through the share transfer reviews | 12:05 |
| carloss | can you please file a launchpad bug for it? | 12:05 |
| OlamideOjo[m] | <OlamideOjo[m]> "hello carloss gouthamr While..." <- Hello carloss , could you please check this out for me? | 12:06 |
| tessyjames | carloss: Will do. Thanks. | 12:09 |
| delightubah[m] | [carloss](https://matrix.to/#/@_oftc_carloss:matrix.org) [gouthamr](https://matrix.to/#/@_oftc_gouthamr:matrix.org): change 956053 (shares list schema) has been idle since March, and I left a review on it today. Would it be okay if I picked it up, addressed the review comments, and added tests, crediting Jonathan as co-author? | 12:12 |
| carloss | delightubah[m]: sure, I think in that case you'd need to add the co-authored-by in the commit message referencing you :) | 12:23 |
| carloss | > hello carloss gouthamr While going through Add JSONSchema validation: shares.delete_metadata() [v2.0+]”, I noticed that the endpoint currently accepts any query parameters. So should we keep the schema empty (`{}`), or are there any specific query parameter restrictions we should add for this endpoint? | 12:24 |
| carloss | OlamideOjo[m] I'd go for what is defined here: https://docs.openstack.org/api-ref/shared-file-system/#delete-share-metadata-item | 12:24 |
| carloss | yes, it can take an empty value | 12:24 |
| carloss | but it can also take other types of values | 12:25 |
| delightubah[m] | carloss: Thanks [carloss](https://matrix.to/#/@_oftc_carloss:matrix.org) 🙏 | 12:25 |
| delightubah[m] | * Thanks carloss I appreciate 🙏 | 12:39 |
| delightubah[m] | * Thanks carloss | 12:39 |
| delightubah[m] | I appreciate 🙏 | 12:39 |
| carloss | np | 12:39 |
| OlamideOjo[m] | carloss: Alright, noted with thanks | 12:46 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/manila master: [cephfs] Support specifying user key cipher. https://review.opendev.org/c/openstack/manila/+/1010881 | 13:27 |
| JoshuaBamson[m] | carloss: thank you | 13:33 |
| hong-p[m] | carloss: hi!, this patch really simple fix about doc, please take a look. https://review.opendev.org/c/openstack/manila/+/1006359 | 13:39 |
| opendevreview | Folasade Falodun proposed openstack/manila master: Fix shallow copy bug in share snapshots schema https://review.opendev.org/c/openstack/manila/+/1010888 | 13:40 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Make paramiko optional actually https://review.opendev.org/c/openstack/manila/+/1010889 | 13:41 |
| opendevreview | Naomi Jepkorir proposed openstack/manila master: Add JSON schema validation for quota_sets.delete() https://review.opendev.org/c/openstack/manila/+/1010848 | 13:45 |
| folasadef | carloss: I claimed task #45 before tessyjames. And i already submitted a patch for it. Please could you assign it to me instead. cheers | 13:52 |
| carloss | folasadef: sorry I missed that, thanks for the call out | 13:54 |
| Victor_Ezealuma | Greetings everyone, My name is Victor Ezealuma, an applicant for the Outreachy OpenStack Manila project on implementing JSON Schema validation in REST APIs. My background is in IT Infrastructure and support and I'm currently learning more about Python and Linux. I see a lot of discussions is already going on, I hope to find my feet around as well as work collaboratively with everyone. | 13:55 |
| carloss | I don't think the way we're assigning things is working really well to avoid conflicts - I'll try something different | 13:55 |
| folasadef | carloss: No worries. Thank you! | 13:55 |
| folasadef | carloss: cool. It will be nice if we can assign ourselves to only new tasks | 13:59 |
| delightubah[m] | carloss: Whatever you propose, we're all learning | 14:00 |
| folasadef | I'm now claiming #44. Please assign me here too. cheers carloss | 14:02 |
| delightubah[m] | Victor_Ezealuma: A warm welcome Victor, get yourself acquainted with things and get your fingers busy, | 14:02 |
| folasadef | Oh sorry. I'll pick another one | 14:04 |
| RaginiSharma[m] | Hey carloss i was going through the api reference documentation for manila project and found that "https://docs.openstack.org/api-ref/shared-file-systems" this link to doc is broken. | 14:09 |
| RaginiSharma[m] | resulting 404. I think we need to fix that | 14:09 |
| * RaginiSharma[m] uploaded an image: (63KiB) < https://matrix.org/oftc/media/v1/media/download/AcGXygWi1CTX4L0tsGfU-MRfmbgbAE882yQqr8tgzyzM1XqfAU5r3S-p47ABn8782L8uG7_SyGnebyWJzeDZceVCehjSUUkQAG1hdHJpeC5vcmcvZ0RBU01mV3lKdmpyZlNEaVljc3hJZEFo > | 14:09 | |
| folasadef | carloss: Please assign me to task #46 too. I'll start working on it | 14:10 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Make paramiko optional actually https://review.opendev.org/c/openstack/manila/+/1010889 | 14:51 |
| Victor_Ezealuma | @carloss and @gouthamr, I would like to claim "Update Snapshot" | 14:56 |
| opendevreview | Theresa James proposed openstack/manila master: Validate share transfer delete response https://review.opendev.org/c/openstack/manila/+/1010906 | 15:08 |
| RaginiSharma[m] | <RaginiSharma[m]> "Hey carloss i was going through..." <- carloss and gouthamr : i found the correct link address :"https://docs.openstack.org/api-ref/shared-file-system/", the above broken link was added in doc site:"https://docs.openstack.org/manila/queens/user/API.html", we just need to change the link from https://docs.openstack.org/api-ref/shared-file-systems to https://docs.openstack.org/api-ref/shared-file-system" | 15:39 |
| RaginiSharma[m] | its manila doc related changes. | 15:39 |
| FiyinPeter[m] | <adeolaadesina[m]> "https://tree.taiga.io/project/..." <- Hi, Adeola. I missed this altogether. I have working on this prior to your message. I am, however, happy to collaborate. | 15:48 |
| FiyinPeter[m] | * I have been working on | 15:49 |
| FiyinPeter[m] | I think Element supports private messages. Or, I could send you the gerrit review and cc you. | 15:54 |
| FiyinPeter[m] | adeolaadesina[m]: This works | 15:55 |
| sidra_khan | Hi everyone, I'm Sidra Khan, an Outreachy applicant from Pakistan! I have recently completed my Masters with experience developing backend REST APIs, and I'm really excited to contribute to the JSON Schema Validation project. gouthamr carloss: I am currently getting my local environment and tox tests set up. Looking forward to working with you both and I'll keep you posted on my progress! | 16:04 |
| RaginiSharma[m] | Hi Sidra welcome! | 16:17 |
| opendevreview | Fiyin Peter proposed openstack/manila master: Add JSON Schema for share access show response https://review.opendev.org/c/openstack/manila/+/1010977 | 16:46 |
| JoyceAnnieGeorge[m] | <JoyceAnnieGeorge[m]> "carloss: gouthamr Can you please..." <- carloss gouthamr : There is a netapp CI failure. I didn't fully understand the reason for the failure. As far as I understand, it's not caused by my changes. Can you please look into it? | 17:21 |
| opendevreview | Theresa James proposed openstack/manila master: Validate share transfer delete response https://review.opendev.org/c/openstack/manila/+/1010906 | 17:30 |
| carloss | JoyceAnnieGeorge[m]: I'd look into the logs - not sure if they are related to your change. The NetApp CI is testing Manila against a NetApp storage array. If it's unrelated to your change, you can ignore it | 17:38 |
| opendevreview | Fiyin Peter proposed openstack/manila master: Unmanage Snapshot https://review.opendev.org/c/openstack/manila/+/1010515 | 17:41 |
| opendevreview | Fiyin Peter proposed openstack/manila master: Add JSON Schema validation for snapshot unmanage https://review.opendev.org/c/openstack/manila/+/1010515 | 17:46 |
| opendevreview | Merged openstack/manila master: [doc] Dell PowerScale: Add extend share to supported operations https://review.opendev.org/c/openstack/manila/+/1006359 | 17:46 |
| FiyinPeter[m] | Hi carloss. I had submitted a patch on a previously unclaimed task #44 only now, it's been assigned to someone else. | 17:49 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add JSONSchema validation: shares.delete_metadata() [v2.0] currently the shares.delete_metadata endpoint accepts any query parameter so the schema was left empty. https://review.opendev.org/c/openstack/manila/+/1010990 | 17:51 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add JSONSchema validation: shares.delete_metadata() [v2.0] https://review.opendev.org/c/openstack/manila/+/1010990 | 17:52 |
| FiyinPeter[m] | I'll like to work on #105. If, it is unclaimed thus far #105 | 17:57 |
| FiyinPeter[m] | https://tree.taiga.io/project/gouthampacha-manila-jsonschema-openapi/us/105?kanban-status=9611452 | 17:57 |
| OlamideOjo[m] | id like to claim #104 | 18:00 |
| OlamideOjo[m] | Add JSONSchema validation: shares.update_metadata_item() [v2.0+] | 18:00 |
| tessyjames_ | carloss: I would like to claim #7 Add JSONSchema validation: share_transfer.detail() [v2.77+] | 18:03 |
| tessyjames | carloss: I would like to claim #7 Add JSONSchema validation: share_transfer.detail() [v2.77+]. Reiterating from my previous claim with tessyjames_ | 18:08 |
| carloss | FiyinPeter[m]: done | 18:32 |
| carloss | OlamideOjo[m]: done | 18:32 |
| carloss | tessyjames done | 18:32 |
| OlamideOjo[m] | T for thanks | 18:33 |
| opendevreview | Ubah Delight Godson Okechukwu proposed openstack/manila master: api: Add schemas for shares list https://review.opendev.org/c/openstack/manila/+/956053 | 18:40 |
| tessyjames | guothamr: Hi Goutham! I have also pushed #81 Add JSONSchema validation: share_transfer.delete() [v2.77+] for review. Kindly move from New in Taiga. I already claimed it earlier before working on it. | 18:49 |
| tessyjames | gouthamr: Hi Goutham! I have also pushed #81 Add JSONSchema validation: share_transfer.delete() [v2.77+] for review. Kindly move from New in Taiga. I already claimed it earlier before working on it. | 18:50 |
| benita | carloss: hello, it's Benita again (benitadev on Gerrit). I have my environment set up, tox -e pep8 passes on my machine, and my Gerrit account and git-review are working. I've started auditing manila/api/v2 to see which endpoints still do manual validation instead of using the schema decorators. Could you point me to a starter task that isn't claimed yet, or tell me which controllers you'd like me to look at first? I'll keep my questions here i | 20:55 |
| carloss | benita: hey, please feel free to go for https://tree.taiga.io/project/gouthampacha-manila-jsonschema-openapi/us/69?kanban-status=9611452 | 21:17 |
| hashaam | carloss gouthamr: I've added @validation.request_body_schema to share_groups, share_group_snapshots, share_replicas and share_types. They're failing unit tests - for share_groups, 35 tests in test_share_groups.py fail because the existing negative tests (like test_share_group_create_invalid_body) expect the controller's inline validation errors, but schema validation now catches them first. What's the preferred approach - should I update t | 23:26 |
| hashaam | Also carloss: I'd like to claim #39 (quota_sets.show) and #40 (quota_sets.detail) please | 23:29 |
| opendevreview | Comfort Oyewole proposed openstack/manila master: Validate share update requests using JSON Schema https://review.opendev.org/c/openstack/manila/+/1010191 | 23:37 |
| opendevreview | Comfort Oyewole proposed openstack/manila master: Validate share delete requests using JSON Schema https://review.opendev.org/c/openstack/manila/+/1010219 | 23:52 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!