| *** amitgandhi has quit IRC | 00:01 | |
| *** amitgandhi has joined #openstack-marconi | 00:01 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: Adds drivers for marconi proxy storage https://review.openstack.org/46375 | 00:16 |
|---|---|---|
| *** whenry has quit IRC | 00:17 | |
| *** whenry has joined #openstack-marconi | 00:20 | |
| *** zzs has joined #openstack-marconi | 00:20 | |
| *** zzs has left #openstack-marconi | 00:24 | |
| *** whenry has quit IRC | 00:30 | |
| *** whenry has joined #openstack-marconi | 00:34 | |
| *** nosnos has joined #openstack-marconi | 00:40 | |
| *** whenry has quit IRC | 00:49 | |
| *** whenry has joined #openstack-marconi | 00:54 | |
| *** oz_akan_ has joined #openstack-marconi | 00:55 | |
| *** cthulhup has joined #openstack-marconi | 01:07 | |
| *** cthulhup has quit IRC | 01:12 | |
| *** amitgandhi has quit IRC | 01:23 | |
| *** whenry has quit IRC | 01:27 | |
| *** oz_akan_ has quit IRC | 02:52 | |
| *** oz_akan_ has joined #openstack-marconi | 02:53 | |
| *** oz_akan_ has quit IRC | 02:57 | |
| *** gordonsim has quit IRC | 03:36 | |
| *** oz_akan_ has joined #openstack-marconi | 03:53 | |
| *** oz_akan_ has quit IRC | 04:01 | |
| *** cthulhup has joined #openstack-marconi | 05:38 | |
| *** cthulhup has quit IRC | 05:43 | |
| *** cthulhup has joined #openstack-marconi | 06:32 | |
| *** cthulhup has quit IRC | 06:36 | |
| *** cthulhup has joined #openstack-marconi | 06:57 | |
| *** cthulhup has quit IRC | 07:02 | |
| *** gordonsim has joined #openstack-marconi | 07:49 | |
| *** cthulhup has joined #openstack-marconi | 07:51 | |
| *** cthulhup has quit IRC | 07:55 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Authentication API + Keystone backend https://review.openstack.org/47334 | 08:17 |
| *** flaper87|afk is now known as flaper87 | 08:17 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Authentication API + Keystone backend https://review.openstack.org/47334 | 08:25 |
| *** flaper87 is now known as flaper87|afk | 08:50 | |
| *** oz_akan_ has joined #openstack-marconi | 11:11 | |
| *** oz_akan_ has quit IRC | 11:16 | |
| *** nosnos has quit IRC | 11:38 | |
| *** tedross has joined #openstack-marconi | 11:38 | |
| *** nosnos has joined #openstack-marconi | 11:39 | |
| *** nosnos has quit IRC | 11:43 | |
| *** cppcabrera has joined #openstack-marconi | 12:18 | |
| cppcabrera | Morning! :) | 12:18 |
| *** oz_akan_ has joined #openstack-marconi | 12:57 | |
| *** amitgandhi has joined #openstack-marconi | 12:59 | |
| *** amitgandhi has quit IRC | 12:59 | |
| *** amitgandhi has joined #openstack-marconi | 12:59 | |
| *** ekarlso has quit IRC | 13:06 | |
| *** oz_akan_ has quit IRC | 13:08 | |
| *** oz_akan_ has joined #openstack-marconi | 13:08 | |
| *** ayoung is now known as AdamTheRed | 13:09 | |
| *** AdamTheRed is now known as AyoungTheRed | 13:10 | |
| *** malini_afk is now known as malini | 13:39 | |
| *** jergerber has joined #openstack-marconi | 13:39 | |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: Added transport layer request class https://review.openstack.org/47369 | 13:43 |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: Added validate() method. https://review.openstack.org/47370 | 13:43 |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: Implemented basic validation https://review.openstack.org/47371 | 13:43 |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: minor fix https://review.openstack.org/47372 | 13:43 |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: improved doc string https://review.openstack.org/47373 | 13:43 |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: better name for request spec class https://review.openstack.org/47374 | 13:43 |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: improved doc string https://review.openstack.org/47375 | 13:43 |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: improved validation results https://review.openstack.org/47376 | 13:43 |
| al-maisan | oops .. I didn't realise each commit would be a separate review :-P | 13:45 |
| al-maisan | mea culpa | 13:45 |
| cppcabrera | lol | 13:49 |
| cppcabrera | no worries, al-maisan | 13:49 |
| cppcabrera | I made the same mistake when I started working on marconi a few months ago. :P | 13:49 |
| al-maisan | sorry again! | 13:49 |
| al-maisan | Oh well -- I can take down the reviews, merge them locally and submit a single change set | 13:50 |
| al-maisan | if that helps | 13:50 |
| cppcabrera | yup - that's what I had to do: git rebase -i master. It's a very different workflow than working with github, where rebasing is discouraged. | 13:50 |
| al-maisan | OK, so let me do that .. "Abandon change" button it is then, I guesss | 13:53 |
| cppcabrera | al-maisan: That's correct - "Abandon Change" eliminates a patch from consideration in the Gerrit system. :) | 13:55 |
| ametts | al-maisan: Of course, there's a flip side as well -- you don't want to commit massive changes with multiple "themes", either. I guess the ideal is a reasonable set of easily-reviewable changes that all have the same intent. | 13:55 |
| al-maisan | ametts: sure, the entire branch is only 90 lines of code though | 13:57 |
| al-maisan | I am a big fan of small changes :) | 13:57 |
| ametts | Oh. :) Sounds like you need to write more python-marconiclient code! | 13:58 |
| al-maisan | he-he :) | 13:58 |
| malini | cppcabrera: while we are talking reviews, are you planning to break this up https://review.openstack.org/#/c/46375 ? | 14:00 |
| malini | (I don't mind as is, but would wait to review - if you plan to break it up) | 14:01 |
| cppcabrera | malini: I plan to break it up. I'm working out a few resource/ bugs atm, but I think I can turn that into 4 or 5 smaller patches. | 14:05 |
| malini | ok..I'll look at the tests after you are done with them :) | 14:06 |
| *** amitgandhi1 has joined #openstack-marconi | 14:15 | |
| *** amitgandhi has quit IRC | 14:15 | |
| *** megan_w has quit IRC | 14:17 | |
| *** pquerna has quit IRC | 14:17 | |
| *** kgriffs_afk has quit IRC | 14:17 | |
| *** malini has quit IRC | 14:17 | |
| *** pquerna has joined #openstack-marconi | 14:18 | |
| *** pquerna has joined #openstack-marconi | 14:18 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: Adds drivers for marconi proxy storage https://review.openstack.org/46375 | 14:19 |
| *** ekarlso has joined #openstack-marconi | 14:20 | |
| cppcabrera | ^^ still breaking that into smaller patches | 14:22 |
| *** malini has joined #openstack-marconi | 14:23 | |
| *** kgriffs has joined #openstack-marconi | 14:28 | |
| *** ChanServ sets mode: +o kgriffs | 14:28 | |
| *** megan_w has joined #openstack-marconi | 14:29 | |
| kgriffs | o/ | 14:31 |
| kgriffs | good morning/afternoon! | 14:31 |
| cppcabrera | kgriffs: o/ | 14:31 |
| cppcabrera | I'm trying to break this proxy storage patch up in such a way that the theme/context is preserved. | 14:38 |
| cppcabrera | It's tricky, since I've changed a lot in one go. | 14:39 |
| cppcabrera | The easiest approach I can think of is to have 3 patches: 1) base interface changes, 2) utils/helpers/resources changes + memory driver + storage tests, 3) mongo storage driver | 14:40 |
| kgriffs | at this point, it may be best to just have 2 patches instead of 3 | 14:53 |
| kgriffs | bigger patch, but retains context for the reviewer and avoids getting into a big dep chain again | 14:54 |
| cppcabrera | +1 kgriffs | 14:54 |
| cppcabrera | 1) memory driver + fixes, 2) mongo driver | 14:54 |
| cppcabrera | 1) including tests, as well | 14:55 |
| openstackgerrit | Malini Kamalambal proposed a change to openstack/marconi: Help Bleeding Eyes https://review.openstack.org/47394 | 14:58 |
| malini | I just went ahead & renamed the ddt tests, since it is bothering all of us & we dont know when we'll have monty's fix for testscenarios | 14:59 |
| cppcabrera | lol, I love the patchset name. | 15:00 |
| cppcabrera | malini: :D | 15:00 |
| kgriffs | LOL | 15:01 |
| kgriffs | thanks! | 15:01 |
| *** cthulhup has joined #openstack-marconi | 15:04 | |
| malini | np :) | 15:05 |
| *** cthulhup has quit IRC | 15:07 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: memory storage driver + tests + fixes https://review.openstack.org/47399 | 15:16 |
| cppcabrera | kgriffs, malini: ^^ memory storage driver patch ready for review. Includes test implementation. | 15:18 |
| malini | thanks cppcabrera..checking it out | 15:19 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mongodb storage driver https://review.openstack.org/47402 | 15:20 |
| cppcabrera | ...and that's a split patch! | 15:20 |
| cppcabrera | Now to deprecate the old one. :P | 15:21 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mongodb storage driver https://review.openstack.org/47402 | 15:24 |
| cppcabrera | I'm going to move forward with adding oslo.cache now off of the mongo driver patch. | 15:26 |
| kgriffs | kk | 15:29 |
| *** malini1 has joined #openstack-marconi | 15:32 | |
| cppcabrera | malini: thaaaaank yooouuu. :D | 15:32 |
| cppcabrera | The test output looks beautiful now. | 15:32 |
| * cppcabrera just saw the Jenkins report | 15:33 | |
| *** malini1 has quit IRC | 15:33 | |
| *** malini1 has joined #openstack-marconi | 15:33 | |
| cppcabrera | +2 - approved | 15:33 |
| malini1 | cppcabrera: Thank You..That was easy :D | 15:33 |
| cppcabrera | we now also have a working example of how to change ddt test names when native strings are involved. :) | 15:35 |
| *** malini has quit IRC | 15:35 | |
| cppcabrera | might be worthwhile to break that off into test/helpers as some point, or ddtutils.annotated | 15:35 |
| openstackgerrit | A change was merged to openstack/marconi: Help Bleeding Eyes https://review.openstack.org/47394 | 15:35 |
| *** malini1 has quit IRC | 15:36 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: memory storage driver + tests + fixes https://review.openstack.org/47399 | 15:36 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mongodb storage driver https://review.openstack.org/47402 | 15:36 |
| *** malini1 has joined #openstack-marconi | 15:36 | |
| cppcabrera | if isinstance(input, six.text_type) -> wrap with mystring, | 15:36 |
| cppcabrera | that sort of thing. | 15:36 |
| cppcabrera | rebased ^^ | 15:37 |
| * kgriffs is running tox with malini's patch | 15:38 | |
| * kgriffs eyes are feeling much better now | 15:38 | |
| malini1 | kgriffs: :D | 15:38 |
| * kgriffs cancels blood transfusion appointment | 15:38 | |
| cppcabrera | lol | 15:38 |
| kgriffs | fyi, PTL elections start tomorrow - https://wiki.openstack.org/wiki/PTL_Elections_Fall_2013 | 15:47 |
| kgriffs | we made the list! | 15:47 |
| cppcabrera | woot! | 15:48 |
| cppcabrera | JIT, kgriffs | 15:48 |
| cppcabrera | Seems whoever wants to be PTL for marconi needs to send an email out to openstack-dev@lists.openstack.org | 15:49 |
| amitgandhi1 | =D | 15:49 |
| cppcabrera | *to be recognized as PTL | 15:49 |
| kgriffs | yes, starting tomorrow | 15:49 |
| cppcabrera | I'm considering restructuring marconi-proxy so that it is as easy to use as marconi-queues. namely, restructuring the transport details to mirror marconi-queues. I'm putting this on my todo list, since the current structure won't block upcoming efforts and it's lower priority. (kgriffs) | 15:58 |
| kgriffs | hmm, ok | 16:13 |
| kgriffs | we can discuss later | 16:13 |
| cppcabrera | thanks! | 16:17 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: WIP: support multiple databases in mongo driver https://review.openstack.org/45952 | 16:27 |
| zyuan | kgriffs: mmh3 missing from openstack requirements | 16:30 |
| zyuan | i can drop pylru (i don't think it helps that much) | 16:31 |
| zyuan | but.. we won't change the hash function in the future | 16:31 |
| kgriffs | zyuan: let's have malini and oz_akan_ benchmark with and without LRU to see if it makes a difference | 16:36 |
| kgriffs | malini: ^^^ | 16:36 |
| malini1 | sure..we'll need oz_akan_ to deploy the latest to test. he is out for lunch now.will chk after he is back | 16:37 |
| cppcabrera | kgriffs, zyuan: how about using zlib.crc32 or zlib.adler32 instead of mmh3? We'd need to test the distribution of queues to databases when using these two functions, but they might work. They're also snappy like mmh3 (slightlty faster, according to timeit). | 16:44 |
| cppcabrera | crc32 :: bytes -> int, adler32 :: bytes -> int (based on testing in Python 3) | 16:44 |
| zyuan | kgriffs: the thing is not LRU... it's mmh3, we need the dependency | 16:46 |
| zyuan | cppcabrera: i don't like to use checksum functions as hash functions | 16:47 |
| zyuan | checksum < non-crypto hash < crypto hash | 16:47 |
| zyuan | the problem with checksum is, its result bits may not be normal distributed | 16:51 |
| zyuan | may be, not may not -_- | 16:51 |
| zyuan | while hash function is often uniform distributed | 16:51 |
| zyuan | so each node has equal chance to be picked up | 16:52 |
| zyuan | but i have no confidence for checksum function to give such a behavior | 16:52 |
| zyuan | cppcabrera: ^^ | 16:52 |
| cppcabrera | that was my concern, zyuan. I wondered how well distributed the zlib checksums would be. | 16:53 |
| cppcabrera | If we fallback on md5, it'd look something like ```int(hashlib.md5(b"a.a").hexdigest(), 16)``` and is ~8x slower than mmh3/zlib.checksums | 16:54 |
| zyuan | cppcabrera: md5 is no-go. it's no longer ctypto and slow than all other non-cryto functions | 16:56 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: WIP: support multiple databases in mongo driver https://review.openstack.org/45952 | 17:03 |
| zyuan | finally passes unit tests... | 17:03 |
| cppcabrera | the proxy has an amusing vulnerability at the moment. If an operator specifies the proxy itself as the only member of a partition, it will enter an infinite redirect loop. | 17:08 |
| zyuan | ... | 17:10 |
| zyuan | it's not | 17:10 |
| zyuan | bottom type, expected behavior | 17:10 |
| cppcabrera | good point | 17:10 |
| cppcabrera | now that I've gotten stevedore working to fetch me the correct driver, continuing~ | 17:12 |
| zyuan | ........................... | 17:12 |
| zyuan | transport -> mongo test cleanup is a little bit messy | 17:13 |
| oz_akan_ | kgriffs: it makes a difference with and without LRU | 17:14 |
| zyuan | oz_akan_: ok. then, dependency | 17:15 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: WIP: support multiple databases in mongo driver https://review.openstack.org/45952 | 17:15 |
| oz_akan_ | time it takes to calculate the hash is longer than time it takes to read from cache | 17:15 |
| kgriffs | oic | 17:27 |
| kgriffs | makes sense | 17:35 |
| kgriffs | btw, anyone tried mmh3 on pypy? | 17:35 |
| cppcabrera | kgriffs: I did, just now. | 17:39 |
| cppcabrera | It's... rather slow. | 17:40 |
| cppcabrera | t('mmh3.hash("a.a")', 'import mmh3') -> 5.434128046035767 | 17:40 |
| cppcabrera | That's seconds. | 17:40 |
| cppcabrera | t('mmh3.hash("a.a")', 'import mmh3') -> 0.2470294129998365 [python 3.3.2] | 17:41 |
| kgriffs | d00d, you need ipython | 17:41 |
| kgriffs | %timeit FTW! | 17:41 |
| cppcabrera | So... about ~22x slower on pypy for some reason. | 17:41 |
| cppcabrera | lol | 17:41 |
| cppcabrera | I didn't know about %timeit. Hmm... | 17:42 |
| cppcabrera | I did know about ipython. | 17:42 |
| cppcabrera | Learned something new today. :P | 17:42 |
| Alex_Gaynor | Is mmh a c extension? | 17:42 |
| kgriffs | i think so | 17:43 |
| kgriffs | that could be why | 17:43 |
| kgriffs | gotta get some cffi love | 17:43 |
| Alex_Gaynor | +1! | 17:43 |
| * kgriffs adds to my list of hackday projects | 17:43 | |
| kgriffs | oz_akan: 216 ns for mmh3 on my box | 17:44 |
| kgriffs | LRU is slower than that iirc | 17:44 |
| kgriffs | let me try a longer string | 17:44 |
| kgriffs | confirmed - LRU lookup is over 1 us | 17:45 |
| kgriffs | while mmh3 for a uuid string is ~200 ns | 17:46 |
| kgriffs | seems like pylru is not necessary? | 17:46 |
| cppcabrera | in pypy, pylru makes a huge difference. | 17:47 |
| cppcabrera | I've got it at 63ns reads, 68ns writes | 17:47 |
| kgriffs | well, yeah, it would make a big diff | 17:49 |
| kgriffs | but i have it on good authority that mmh3 will be optimized for pypy in the near future | 17:49 |
| kgriffs | ;) | 17:49 |
| cppcabrera | lol | 17:50 |
| cppcabrera | awesome, kgriffs. :P | 17:50 |
| kgriffs | Alex_Gaynor: https://review.openstack.org/#/c/46757/ | 17:55 |
| *** reed has joined #openstack-marconi | 18:01 | |
| malini1 | cppcabrera: did you intend the prints to be here https://review.openstack.org/#/c/47399/2/tests/unit/proxy/storage/base.py (eg. line 116) | 18:01 |
| cppcabrera | probably not, malini. (goes to double check) | 18:03 |
| cppcabrera | haha, I left those in from debugging! | 18:03 |
| cppcabrera | Good catch, malini. I'll fix that up. :) | 18:04 |
| malini1 | there are 3 of them..I'll add those in the review comments, so you dont have to hunt | 18:04 |
| kgriffs | alejandro: mtg | 18:09 |
| kgriffs | cppcabrera: mtg | 18:10 |
| amitgandhi1 | kgriffs: wrong channel =P | 18:10 |
| amitgandhi1 | oops | 18:10 |
| amitgandhi1 | my bad | 18:10 |
| *** amitgandhi1 is now known as amitgandhi | 18:10 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: memory storage driver + tests + fixes https://review.openstack.org/47399 | 18:12 |
| *** cthulhup has joined #openstack-marconi | 18:13 | |
| cppcabrera | malini: found them, thanks. Patch above removes them. ^^ | 18:13 |
| cppcabrera | :) | 18:13 |
| *** cthulhup has quit IRC | 18:17 | |
| malini1 | cppcabrera: why do you have the test classes here with just setup & teardown - https://review.openstack.org/#/c/47399/3/tests/unit/proxy/storage/test_impl_memory.py ? | 18:23 |
| cppcabrera | To force the memory driver to be loaded and run the tests on that, malini. | 18:24 |
| cppcabrera | There's no memory-specific tests at the moment, but being able to run the memory tests in isolation is great for tracking interface-level bugs. | 18:25 |
| malini1 | thanks cppcabrera | 18:28 |
| cppcabrera | malini: thank you! | 18:28 |
| *** malini1 has quit IRC | 18:41 | |
| *** malini1 has joined #openstack-marconi | 18:42 | |
| *** malini3 has joined #openstack-marconi | 18:45 | |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: Added transport layer request spec class https://review.openstack.org/47443 | 18:47 |
| *** malini1 has quit IRC | 18:48 | |
| oz_akan_ | is there a new dependency added recently? I can't install code from new repo properly | 19:06 |
| oz_akan_ | malini3: ^^ you may know | 19:06 |
| oz_akan_ | cppcabrera: you may too | 19:07 |
| cppcabrera | hmm... | 19:08 |
| cppcabrera | python-redis was added not too long ago. | 19:08 |
| cppcabrera | also, pbr and d1to2 were upgraded, IIRC | 19:08 |
| oz_akan_ | "No module named transport.wsgi" | 19:08 |
| oz_akan_ | does this error make sense? | 19:09 |
| kgriffs | usually means syntax error | 19:09 |
| kgriffs | stevedore errors are rather cryptic | 19:09 |
| cppcabrera | solved | 19:12 |
| cppcabrera | "from marconi.transport.wsgi..." -> "from marconi.queues.transport.wsgi..." | 19:12 |
| cppcabrera | I walked over to oz_akan_'s desk because stevedore errors are always cryptic. :P | 19:12 |
| oz_akan_ | cppcabrera: thanks | 19:13 |
| kgriffs | stupid timeutils bug is blocking me | 19:18 |
| kgriffs | for some reason, if you do a time.sleep(10) then timeutils.advance_time doesn't work correctly. sleeping for a short time has no affect. | 19:18 |
| kgriffs | WAT?! | 19:19 |
| kgriffs | found it since an earlier test sleeps in my patch | 19:19 |
| cppcabrera | hmm... | 19:20 |
| kgriffs | let me see if it is py26 specific | 19:21 |
| kgriffs | may be a quirk with datatime | 19:21 |
| kgriffs | datetime | 19:21 |
| kgriffs | hmm, seems to be bug in this: calendar.timegm(utcnow().timetuple()) | 19:33 |
| kgriffs | stepping in | 19:33 |
| oz_akan_ | have we started to print version like "2013.2" ? | 19:33 |
| kgriffs | yes | 19:34 |
| oz_akan_ | what is 2? | 19:34 |
| kgriffs | was added by monty | 19:34 |
| kgriffs | i believe it corresponds to havana | 19:34 |
| kgriffs | icehouse will be 2014.1 if my assumption is correct | 19:34 |
| oz_akan_ | how I could see with git version it is? | 19:34 |
| kgriffs | git log −1 ? | 19:35 |
| *** malini3 has quit IRC | 19:35 | |
| oz_akan_ | I was checking by version agains git refision number to be sure installed instance is from correct code | 19:35 |
| oz_akan_ | I need something that marconi would report | 19:35 |
| oz_akan_ | sometimes it imports wrong version etc.. | 19:35 |
| kgriffs | oh | 19:35 |
| kgriffs | hmmm | 19:35 |
| oz_akan_ | to be sure all servers are running the same code version | 19:36 |
| kgriffs | maybe prb injects it somewhere | 19:36 |
| kgriffs | pbr | 19:36 |
| * kgriffs is looking | 19:36 | |
| oz_akan_ | I changed test env to use staging auth | 19:42 |
| kgriffs | reading this | 19:42 |
| kgriffs | https://wiki.openstack.org/wiki/Branch_Model | 19:42 |
| *** gordonsim has quit IRC | 19:45 | |
| kgriffs | oz_akan: maybe you can get it from ChangeLog ? | 19:50 |
| oz_akan_ | kgriffs: I need to get it from the module that I import so I can be sure that I am on the right version | 19:52 |
| oz_akan_ | it would even be great, if there was an endpoint for that | 19:52 |
| kgriffs | oh, in your app.py or whatever? | 19:53 |
| kgriffs | i mean, what is importing marconi? | 19:54 |
| oz_akan_ | from marconi.queues.transport.wsgi import app | 19:56 |
| oz_akan_ | I do python, import marconi, print marconi.__version__ | 19:56 |
| oz_akan_ | that would be enough to be sure I am on the correct version as it used to show git version there | 19:56 |
| kgriffs | that print marconi.__version__ is a salt script? | 19:58 |
| kgriffs | so, you are basically testing whether import is pulling in the correct version | 19:59 |
| kgriffs | hmm | 19:59 |
| kgriffs | oz_akan: is the abbreviated hash good? | 20:10 |
| kgriffs | I suppose it probably is | 20:10 |
| openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: chore: Expose commit hash in version module https://review.openstack.org/47459 | 20:16 |
| kgriffs | Found the bug | 20:32 |
| kgriffs | cppcabrera: notice anything odd about this? | 20:34 |
| kgriffs | http://paste.openstack.org/show/47283/ | 20:34 |
| cppcabrera | hmmm | 20:40 |
| * cppcabrera checks | 20:40 | |
| *** whenry has joined #openstack-marconi | 20:41 | |
| cppcabrera | is it the argument instance bug, kgriffs? | 20:41 |
| cppcabrera | Sure seems like it'd be safer to pass None as the default arg, then set the desired target to datetime.datetime.utcnow() if target is None | 20:41 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mongodb storage driver https://review.openstack.org/47402 | 20:42 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mongodb storage driver https://review.openstack.org/47402 | 20:43 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: memory storage driver + tests + fixes https://review.openstack.org/47399 | 20:44 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mongodb storage driver https://review.openstack.org/47402 | 20:44 |
| cppcabrera | I'm going to submit the caching patch, then head on home. | 20:46 |
| cppcabrera | I managed to get stevedore, oslo.config, oslo.cache, and refactoring to play nice enough together to get it runnable. :P | 20:47 |
| kgriffs | cppcabrera: yep | 20:47 |
| kgriffs | you win a pop-tart | 20:47 |
| cppcabrera | woot | 20:47 |
| kgriffs | the problem is, the default arg is evaluated at import time! | 20:47 |
| cppcabrera | Now to make a sweet log message out of these 14 commits | 20:47 |
| cppcabrera | kgriffs: sweet - seems I'm up to date on my pythono gotchas. | 20:48 |
| cppcabrera | *python | 20:48 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: WIP: support multiple databases in mongo driver https://review.openstack.org/45952 | 20:49 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: WIP: support multiple databases in mongo driver https://review.openstack.org/45952 | 20:51 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: adds oslo.cache, config support, & stevedore https://review.openstack.org/47475 | 20:53 |
| cppcabrera | There's the hierarchical caching patch, kgriffs, zyuan. | 20:54 |
| cppcabrera | I'll fix up the proxy transport unit tests with the next patch. I think refactoring to mirror marconi queues transport is a great next step. | 20:56 |
| *** malini2 has joined #openstack-marconi | 20:57 | |
| cppcabrera | that'll let me encapsulate all the config logic in a marconi.proxy.bootstrap, move all the routes-handling to marconi.proxy.transport.wsgi.driver, and canonicalize the unit tests. | 20:57 |
| cppcabrera | it might even make sense to have a separate config file for marconi-proxy | 20:57 |
| zyuan | cppcabrera: & kgriffs can you start reviewing https://review.openstack.org/#/c/45952/ ? | 21:02 |
| zyuan | the things left is refactoring, but this won't affect the control flows that much | 21:03 |
| cppcabrera | I'll check it out tomorrow, zyuan. :) | 21:07 |
| cppcabrera | goodnight, guys~ | 21:07 |
| *** cppcabrera has quit IRC | 21:09 | |
| *** oz_akan_ has quit IRC | 21:18 | |
| openstackgerrit | Brian Curtin proposed a change to openstack/python-marconiclient: Remove mox from test-requirements.txt https://review.openstack.org/47486 | 21:53 |
| *** tedross has quit IRC | 22:12 | |
| *** malini2 has quit IRC | 22:13 | |
| *** amitgandhi has quit IRC | 22:13 | |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(multidb): support multiple databases in mongo https://review.openstack.org/45952 | 22:25 |
| *** oz_akan_ has joined #openstack-marconi | 22:29 | |
| openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: perf(mongodb): Combine project and queue message fields https://review.openstack.org/47259 | 22:30 |
| openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: fix(mongodb): Marker generation creates a bottleneck under heavy load https://review.openstack.org/47272 | 22:30 |
| *** oz_akan_ has quit IRC | 22:34 | |
| *** jergerber has quit IRC | 22:48 | |
| *** amitgandhi has joined #openstack-marconi | 23:39 | |
| *** kgriffs is now known as kgriffs_afk | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!