| *** notmyname_ has joined #openstack-marconi | 00:19 | |
| *** ekarlso has quit IRC | 00:23 | |
| *** notmyname has quit IRC | 00:23 | |
| *** wirehead_ has quit IRC | 00:23 | |
| *** notmyname_ is now known as notmyname | 00:24 | |
| *** ekarlso has joined #openstack-marconi | 00:29 | |
| *** jdprax has joined #openstack-marconi | 00:53 | |
| jdprax | ? | 00:54 |
|---|---|---|
| *** jdprax has quit IRC | 00:54 | |
| *** wirehead_ has joined #openstack-marconi | 02:17 | |
| *** flaper87|afk is now known as flaper87 | 07:32 | |
| *** ykaplan has joined #openstack-marconi | 07:41 | |
| *** gordonsim has joined #openstack-marconi | 08:18 | |
| *** key3 has quit IRC | 09:13 | |
| *** ykaplan has quit IRC | 10:05 | |
| al-maisan | Good afternoon! | 10:50 |
| flaper87 | al-maisan: goooooood afternoon | 11:07 |
| al-maisan | flaper87: hello there! How are things? | 11:08 |
| al-maisan | We have sunshine in CH :) | 11:09 |
| flaper87 | al-maisan: all good, we've got a half-cloudy day :D | 11:09 |
| flaper87 | meaning, the clouds are right above me, all other places are sunny | 11:10 |
| flaper87 | :D | 11:10 |
| al-maisan | he-he :) | 11:12 |
| al-maisan | real clouds or "clouds"? | 11:12 |
| flaper87 | nah, real clouds. It was cloudy yesterday and it still is today. Weather forecast says temperatures will be high this week, though. | 11:13 |
| al-maisan | so, how do we progress this week? I'll spend some time and look at various queuing APIs and the client discussion etherpad | 11:17 |
| flaper87 | al-maisan: I suggest you to take a look to Proton | 11:18 |
| al-maisan | Is this the right etherpad: https://etherpad.openstack.org/marconi-client ? | 11:18 |
| flaper87 | al-maisan: http://qpid.apache.org/proton/ | 11:18 |
| al-maisan | OK, will do. | 11:18 |
| flaper87 | al-maisan: https://etherpad.openstack.org/marconi-client-api | 11:18 |
| flaper87 | I'll review patches in a bit | 11:18 |
| al-maisan | thanks!! | 11:18 |
| flaper87 | I've been covering some internal things today | 11:18 |
| al-maisan | sure .. same here :-P | 11:19 |
| * al-maisan checks for a proton package on Fedora | 11:19 | |
| al-maisan | hmm .. python-qpid-proton looks promising :) | 11:20 |
| *** ykaplan has joined #openstack-marconi | 11:29 | |
| *** oz_akan_ has joined #openstack-marconi | 11:41 | |
| *** oz_akan_ has quit IRC | 11:43 | |
| *** oz_akan_ has joined #openstack-marconi | 11:44 | |
| *** tedross has joined #openstack-marconi | 11:59 | |
| *** oz_akan_ has quit IRC | 12:00 | |
| *** cppcabrera has joined #openstack-marconi | 12:04 | |
| cppcabrera | Good morning! :D | 12:05 |
| flaper87 | cppcabrera: good morning | 12:07 |
| flaper87 | how was your weekend? | 12:07 |
| flaper87 | al-maisan: reviewed your patch, I added some comments | 12:08 |
| flaper87 | al-maisan: you may want to take a look here as well: https://github.com/openstack/python-marconiclient/blob/master/HACKING.rst | 12:08 |
| cppcabrera | flaper87: My weekend was awesome. Lots of relaxing, lots of time with my wife, and I caught up on most of my bookmark'd article/video backlog. :D | 12:09 |
| cppcabrera | How was yours? | 12:09 |
| flaper87 | pretty good as well, spent some time with my family and coding. :D | 12:10 |
| cppcabrera | sweet. :) | 12:11 |
| cppcabrera | I read the live blog from CUFP 2013. The keynote was an especially good read. (#link: http://www.syslog.cl.cam.ac.uk/2013/09/22/liveblogging-cufp-2013/) | 12:12 |
| al-maisan | flaper87: thanks for the review! | 12:17 |
| * flaper87 bookmarks that link | 12:19 | |
| flaper87 | al-maisan: np, I'll wait for your new PS to rebase mine | 12:20 |
| *** jraim has joined #openstack-marconi | 12:28 | |
| *** oz_akan_ has joined #openstack-marconi | 12:57 | |
| *** oz_akan_ has quit IRC | 12:58 | |
| *** oz_akan_ has joined #openstack-marconi | 12:59 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mirror structure of marconi queues + bootstrap https://review.openstack.org/47642 | 13:01 |
| *** mpanetta has joined #openstack-marconi | 13:02 | |
| cppcabrera | I'm going to write out a spec for marconi proxy. It's developed enough at this point that it has: storage interface, cache interface, transport interface, and a well-defined API. | 13:02 |
| flaper87 | cppcabrera: +1 | 13:07 |
| cppcabrera | I think it also might make reviewing the thing a little easier. :P | 13:08 |
| *** rustlebee is now known as russellb | 13:08 | |
| flaper87 | hehe, indeed | 13:09 |
| cppcabrera | I realized while thinking about it during the weekend that reviewing this series of patches must be especially annoying, since decisions made in early patches are deprecated/fixed by the time a new patch rolls out, so reading it in sequential order is misleading. | 13:09 |
| flaper87 | I'm reviewing your patch now | 13:09 |
| cppcabrera | for example, the patch that brings in oslo.cache uses static configuration (the code must be modified to swap out backends), but that's fixed by the latest patch where -proxy:transport mirrors -queues:transport. | 13:10 |
| cppcabrera | thanks, flaper87! :) | 13:10 |
| mpanetta | Someone has been having fun with marconi lately I see :) | 13:12 |
| ekarlso | oslo.cache is what ? | 13:13 |
| cppcabrera | ekarlso: oslo.cache is a caching interface supporting multiple backends. flaper87 is the primary author and can tell you all the things about it. :) | 13:14 |
| cppcabrera | It's quite handy. | 13:14 |
| flaper87 | ekarlso: under development cache abstraction for oslo https://review.openstack.org/#/c/32544/ | 13:14 |
| cppcabrera | mpanetta: haha, I'm always having fun with marconi. :D | 13:15 |
| ekarlso | ok, so not a sep library ? | 13:15 |
| cppcabrera | my understanding is that it is a separate library/module - flaper87, is that correct? | 13:16 |
| flaper87 | yeah, that's kinda corret. So, it'll stay in oslo-incubator as a separate package for a bit and then I'll pull it out into its own repo | 13:18 |
| *** ykaplan has quit IRC | 13:18 | |
| *** ykaplan has joined #openstack-marconi | 13:18 | |
| *** amitgandhi has joined #openstack-marconi | 13:23 | |
| flaper87 | cppcabrera: why is it that you need to define a resource for ClaimCreate and one for Claims ? | 13:30 |
| cppcabrera | Because they forward to different endpoints, flaper87. :) | 13:31 |
| cppcabrera | ClaimCreate handles /v1/queues/{queue}/claims | 13:32 |
| cppcabrera | Claim handles /v1/queues/{queue}/claims/{claim_id} | 13:32 |
| flaper87 | cppcabrera: aaaahhh, good point! It wasn't obvious to me at first glance | 13:32 |
| flaper87 | thanks | 13:32 |
| cppcabrera | np! | 13:32 |
| mpanetta | Ohh has claiming messages been changed a bit? | 13:33 |
| *** malini_afk is now known as malini | 13:33 | |
| cppcabrera | nah, mpanetta. | 13:33 |
| flaper87 | mpanetta: what did you want to change about it? | 13:33 |
| cppcabrera | it's the same it's been for at least a month. :) | 13:33 |
| flaper87 | :D | 13:33 |
| mpanetta | Ah ok. Last time I actually played with this was before it was moved from the staging git repo. | 13:34 |
| cppcabrera | flaper87: The marconi-proxy spec is born! #link https://wiki.openstack.org/wiki/Marconi/specs/proxy/v1 | 13:34 |
| cppcabrera | At least the endpoints summary portion of that spec is filled out. | 13:34 |
| mpanetta | I don't remember the claimcreate api. But I may not have seen it :) | 13:34 |
| cppcabrera | mpanetta: I wouldn't be able to identify it as claimcreate, usually. I'm more used to seeing it as `POST /v1/queues/{queue}/claims`. :P | 13:36 |
| flaper87 | al-maisan: btw, do you think you can get those fixes done by the end of the day? Kinda need them :D | 13:36 |
| mpanetta | Ah, yes. | 13:36 |
| flaper87 | no preasures, though. Just hurry up but, you know, no hurries. Just finish that very quickly but hey, I don't want to stress you | 13:36 |
| flaper87 | al-maisan: ^ | 13:36 |
| mpanetta | lol | 13:37 |
| flaper87 | :D | 13:37 |
| flaper87 | cppcabrera: +1 for the spec | 13:37 |
| flaper87 | you know, soemthing I love about the way we're developing marconi is that nothing gets released without being documented | 13:38 |
| flaper87 | I want to keep it that way | 13:38 |
| flaper87 | cppcabrera: you've been very helpful at documenting / reviewing things. Big thanks to you! | 13:38 |
| cppcabrera | I'm just happy to make things a little easier for everyone. Keeping all the details in mind if *hard*. I need to refresh on the proxy every morning to see what it's supposed to do. :D | 13:41 |
| cppcabrera | Keeping a doc like that around helps me, too. ;) | 13:41 |
| cppcabrera | **...is *hard*... | 13:41 |
| flaper87 | I wonder we'll be able to sue marconiclient for request forwarding in marconi-proxy. We can implement very nice tricks there. Like, pick the fastest transport enabled and forward the request there | 13:45 |
| flaper87 | I wonder whether* | 13:45 |
| flaper87 | /sue/use/ | 13:45 |
| flaper87 | poor marconiclient, it's already being sued | 13:45 |
| * mpanetta sues marconi for not proxying his request. | 13:45 | |
| flaper87 | :D | 13:46 |
| mpanetta | :P | 13:46 |
| flaper87 | the idea is to avoid duplicating code in the proxy + reuse connections and whatever improvements can be made there that are also useful for end-users | 13:46 |
| cppcabrera | lol | 13:48 |
| cppcabrera | I wonder as well how much of marconiclient we can reuse. | 13:49 |
| cppcabrera | I have to say, though, that the forwarding mixin you proposed early on flaper87 helped clean up the implementation of the proxy **a lot**. I'm very grateful for that suggestion. :D | 13:49 |
| cppcabrera | Also, zyuan has been working on this (https://github.com/racker/falcon/pull/184) that might clean things up even further in the proxy. | 13:49 |
| *** ametts has joined #openstack-marconi | 13:50 | |
| flaper87 | cppcabrera: glad it helped :D | 13:50 |
| flaper87 | cppcabrera: that looks very useful | 13:50 |
| flaper87 | cppcabrera: reviewed | 13:59 |
| flaper87 | cppcabrera: https://review.openstack.org/#/c/47399/ | 13:59 |
| cppcabrera | lots and lots of comments (starts reading) | 14:00 |
| cppcabrera | thanks, flaper87! | 14:00 |
| flaper87 | :D | 14:01 |
| *** whenry has quit IRC | 14:26 | |
| cppcabrera | flaper87: responded to review. :) | 14:26 |
| * flaper87 reading | 14:28 | |
| flaper87 | cppcabrera: awesome, I agree with the planned approach since this patch and the enxt one are pretty big | 14:30 |
| flaper87 | cppcabrera: thanks for working on that | 14:30 |
| flaper87 | I don't think we'll need to defer any other fix after this 2 patches land | 14:30 |
| flaper87 | we'll be able to focus on a per-patch review + fixes | 14:31 |
| cppcabrera | +1 - things are getting more solid with the proxy with each passing day. | 14:31 |
| flaper87 | +2'd | 14:31 |
| flaper87 | both | 14:31 |
| flaper87 | I'd like to get those 2 in before reviewing the next set of patches | 14:32 |
| flaper87 | gosh, I haven't written 1 line of code today | 14:32 |
| cppcabrera | works for me, flaper87. :) | 14:32 |
| cppcabrera | Thanks for understanding! | 14:32 |
| cppcabrera | I'll have the -proxy spec finished by the end of the day today. It's a good draft at this point, since I've had a bit of experience implementing this thing to go with all the discussions we had awhile ago. | 14:33 |
| cppcabrera | It'll also help with the review of the remaining 2 patches. | 14:33 |
| cppcabrera | lol, no code yet? Are meetings holding you up, flaper87? :P | 14:33 |
| flaper87 | ah yeah, + internal stuff + reviews. | 14:34 |
| *** kgriffs_afk is now known as kgriffs | 14:36 | |
| cppcabrera | busy mondays~ | 14:37 |
| cppcabrera | kgriffs: o/ | 14:37 |
| kgriffs | 0/ | 14:42 |
| flaper87 | kgriffs: yo, Happy monday :) | 14:43 |
| kgriffs | :P | 14:44 |
| kgriffs | http://garfieldh8smondays.tumblr.com/ | 14:46 |
| flaper87 | LOOL | 14:47 |
| cppcabrera | lol kgriffs | 14:48 |
| kgriffs | :p | 14:48 |
| kgriffs | The only thing that saved this day for me was a hot toaster strudel. I have another one in my backpack just in case things get *really* bad today. | 14:48 |
| cppcabrera | "Boy, I wish I had a fifty pound pan of lasagna" - that made me realize I'm quite hungry. >.> | 14:49 |
| * kgriffs is so glad we have a toaster at work | 14:49 | |
| cppcabrera | mmm, strudel... | 14:49 |
| ametts | kgriffs, flaper87: Looks like one of our two Summit sessions got approved | 14:50 |
| flaper87 | ametts: YEEEESS!! | 14:50 |
| flaper87 | ametts: don't you read twitter????? :D | 14:50 |
| flaper87 | ametts: that's definitely AWESOME | 14:50 |
| cppcabrera | lol | 14:50 |
| flaper87 | we've got to rock in that session | 14:51 |
| * ametts goes and looks | 14:51 | |
| cppcabrera | I'm very happy about this session approval. | 14:51 |
| * cppcabrera saw it yesterday | 14:51 | |
| cppcabrera | Let me know if you guys need any help putting together content for the presentations | 14:51 |
| * amitgandhi wonders how ametts misses twitter - was sure its his home page | 14:51 | |
| kgriffs | strudel muß sein | 14:52 |
| ametts | amitgancdi, flaper87: Twitter comes up every time I launch a new browser page, and I wrote a little python thing that gives me one twitter post as a system notification every few minutes. I also see my most recent twitter on my phone. | 14:54 |
| ametts | The catch is that I never go back and read history if I'm not there to notice something when it comes in. | 14:55 |
| ametts | I'm only "in the moment". :D | 14:55 |
| flaper87 | HAHAHAH, realtime or nothing | 14:55 |
| cppcabrera | I check mine in the morning and at lunch, and probably once more at the end of the day. :P | 14:55 |
| ametts | flaper87: Yeah, I'm backlogged on work, backlogged on email, and backlogged on projects around the house. I don't need to be backlogged on Twitter as well. | 14:56 |
| ametts | (this is also why I've never had a TiVo) | 14:56 |
| ametts | I never want to be backed up on "things I have to watch". | 14:56 |
| ametts | Although I do have a "things to read list that's a mile long" -- I'm addicted to OReilly "Deals of the Day" | 14:57 |
| cppcabrera | heh, that's what bookmarks are for, ametts! ;) | 14:57 |
| * cppcabrera has a lengthy To Watch bookmarks list | 14:57 | |
| cppcabrera | Oohh, O'Reilly Deal of the Day... | 14:57 |
| cppcabrera | Those get me, too. | 14:57 |
| cppcabrera | I've ended up buying almost all the books from their catalogue that I want, at this point. :P | 14:57 |
| flaper87 | hahahahhaha, cppcabrera your bookmarks seem expensive | 14:59 |
| cppcabrera | lol | 14:59 |
| cppcabrera | they cost more in time than in $$$ | 14:59 |
| cppcabrera | I finally got around to watching "Escaping the Ivory Tower: The Haskell Journey" and "The Most Important Minute of Your Life" this weekend. I highly recommend both talks! | 15:00 |
| cppcabrera | #link http://yow.eventer.com/events/1004/talks/1054 | 15:01 |
| cppcabrera | #link http://yow.eventer.com/yow-2012-1012/the-most-important-minute-of-your-life-by-mike-lee-1259 | 15:01 |
| flaper87 | cppcabrera: man, pocketed both of them | 15:06 |
| flaper87 | thanks :) | 15:06 |
| cppcabrera | np. I've usually got links in the pursuit of knowledge, and I'm happy to share! :D | 15:07 |
| kgriffs | has anybody followed up with the openstack/requirements team to find out whether we can still get something like mmh3 in since it only affects Marconi? | 15:16 |
| *** reed has joined #openstack-marconi | 15:18 | |
| flaper87 | kgriffs: not me, let me ping -infra guys | 15:18 |
| kgriffs | groovy, thanks. The multi-db patch needs some kind of hashing lib. I am looking at XX as well | 15:19 |
| cppcabrera | kgriffs: I haven't followed up, either. | 15:21 |
| cppcabrera | I'll do so after this round of fixes to the latest proxy patch. | 15:21 |
| cppcabrera | (almost done with some local patching) | 15:21 |
| kgriffs | at first glance, i think mmh3 will be easier to update to support cffi | 15:22 |
| kgriffs | FWIW | 15:22 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mirror structure of marconi queues + bootstrap https://review.openstack.org/47642 | 15:45 |
| kgriffs | mtg in 15 | 15:48 |
| flaper87 | mmh, damnit, not sure I'll be able to stick around the whole meeting | 15:48 |
| cppcabrera | I'll be there. | 15:49 |
| kgriffs | flaper87: ok, let's audit the API first thing then | 15:50 |
| ametts | Great. Now I have "I'll be there" from the Jackson Five stuck in my head.... | 15:50 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mirror structure of marconi queues + bootstrap https://review.openstack.org/47642 | 15:51 |
| cppcabrera | "Is this really what you meant to do? Type 'yes' to confirm: yeees" -> #fail :P | 15:51 |
| cppcabrera | lol ametts | 15:51 |
| amitgandhi | meeting? | 16:04 |
| cppcabrera | kgriffs: ^^ | 16:05 |
| *** ykaplan has quit IRC | 16:09 | |
| flaper87 | mmh, I think kgriffs dissapeared :D | 16:09 |
| flaper87 | I got to go guys, I'm sorry. It's the second meeting I miss in a row. Won't happen next week | 16:09 |
| cppcabrera | flaper87: take care! ping me later and I'll update you on any parts you'd like to ask about. :) | 16:10 |
| flaper87 | cppcabrera: awesome, thanks man! ttyl | 16:11 |
| *** flaper87 is now known as flaper87|afk | 16:11 | |
| *** cthulhup_ has joined #openstack-marconi | 16:16 | |
| al-maisan | flaper87|afk: yes, should be done tonight | 16:23 |
| *** reed has quit IRC | 16:37 | |
| *** reed has joined #openstack-marconi | 16:38 | |
| *** reed has quit IRC | 16:41 | |
| *** reed has joined #openstack-marconi | 16:42 | |
| *** hub_cap has joined #openstack-marconi | 16:50 | |
| kgriffs | so... | 17:06 |
| kgriffs | binascii.crc32 is pretty fast | 17:07 |
| kgriffs | not as fast as mmh3, but close | 17:07 |
| *** aababilov has joined #openstack-marconi | 17:07 | |
| aababilov | hi! | 17:07 |
| hub_cap | double hi! | 17:08 |
| hub_cap | we come bearing questions | 17:08 |
| cppcabrera | hey! | 17:08 |
| cppcabrera | aababilov: It's been awhile. :D | 17:08 |
| hub_cap | so im looking to integrate aababilov's apiclient code | 17:08 |
| cppcabrera | I've had your email sitting in my inbox for a bit regarding the apiclient code. | 17:08 |
| cppcabrera | My apologies for not responding sooner. :x | 17:09 |
| aababilov | I am a volunteer, so, I write the code when I have free time :) | 17:09 |
| hub_cap | so lets chat about it! | 17:09 |
| kgriffs | zyuan, cppcabrera: http://paste.openstack.org/show/47386/ | 17:09 |
| kgriffs | bbl (lunch) | 17:09 |
| malini | cppcabrera: do you limit access on who can create partitions ? We dont want every user to be able to create a partition | 17:10 |
| cppcabrera | yes, let's. So, re: the apiclient patch and why it was reverted awhile ago. | 17:10 |
| * hub_cap listens | 17:10 | |
| kgriffs | I am hopeful that binascii.crc32 should be fine and we don't need pylru | 17:10 |
| cppcabrera | malini: it's up to rbac to limit access to admin users only | 17:10 |
| kgriffs | it would be great if someone could benchmark that | 17:10 |
| hub_cap | cppcabrera: fwiw, im looking to add it to troveclient | 17:10 |
| kgriffs | bbl | 17:10 |
| aababilov | what;s "bbl"? | 17:11 |
| hub_cap | be back later | 17:11 |
| aababilov | thanks! | 17:11 |
| *** kgriffs is now known as kgriffs_afk | 17:11 | |
| cppcabrera | the patch was reverted because we needed to make faster progress on the implementation of our client and there were issues with it that we did not/could not address at the time. | 17:11 |
| cppcabrera | There was a list of those issues maintained at some point | 17:12 |
| cppcabrera | I lost that link. >.> | 17:12 |
| aababilov | but marconiclient is almost empty now | 17:12 |
| aababilov | it does not send HTTP requests at all | 17:12 |
| cppcabrera | yup - though we have several patches sitting in our review queue | 17:12 |
| aababilov | why haven't you added me as a reviewer? | 17:13 |
| aababilov | maybe I could help to adopt them | 17:13 |
| cppcabrera | I was still new to OS dev at the time - that was my bad. | 17:13 |
| aababilov | you know, that was quite disappointing to see my code removed :( | 17:14 |
| hub_cap | aababilov: ill help readd in trove :P | 17:14 |
| cppcabrera | aababilov: I'd be interested in taking a second look at the apiclient code at this time, now that I'm more familiar with both OS and the marconi project | 17:15 |
| * al-maisan starts fixing the branch with the transport layer request spec | 17:16 | |
| cppcabrera | I'll also add you in to pending patches as a reviewer | 17:16 |
| hub_cap | again fwiw, i like the code... im just sad that the auth stuff doesnt exist anywhere | 17:16 |
| cppcabrera | *pending marconiclient patches | 17:16 |
| cppcabrera | hub_cap: we've got this going for auth atm: https://review.openstack.org/#/c/47334/ | 17:16 |
| hub_cap | cppcabrera: so that looks VERY similar to what i need | 17:17 |
| hub_cap | how come this isint 1) in keystoneclient or 2) in oslo like the apiclient stuff? | 17:17 |
| cppcabrera | flaper87|afk would be able to answer that much better than I. | 17:18 |
| hub_cap | heh lucky guy | 17:18 |
| cppcabrera | haha | 17:18 |
| cppcabrera | he's at meetings for a good part of the day, from what I've heard. :P | 17:18 |
| cppcabrera | My best guess at why that patch isn't part of oslo just yet is that it's being tested here to see if this'll work | 17:19 |
| cppcabrera | (oslo-incubator) | 17:19 |
| cppcabrera | that's me guessing - I gave 0 design input on that particular patch. :) | 17:19 |
| aababilov | auth plugins are not in oslo just because Adam Young asked me to put them into keystoneclient | 17:20 |
| aababilov | then he asked me to put the whole apiclient into keystoneclient | 17:20 |
| aababilov | and finally Jamie Lennox started writing an alternative auth plugin implementation that is still on review | 17:21 |
| cppcabrera | lots of auth plugin impls going on in parallel! | 17:21 |
| cppcabrera | I wasn't aware. | 17:21 |
| aababilov | do you know how to influent keystoneclient maintainers? ;) | 17:21 |
| cppcabrera | haha, I have no sway in keystone land. I've spoken with ayoung once or twice and that's the extent of my involvement with keystone. :) | 17:22 |
| malini | aababilov: chocolates work in most situations ;) | 17:22 |
| cppcabrera | malini: +1 | 17:22 |
| cppcabrera | poptarts work **really** well with the marconi team | 17:23 |
| aababilov | when I will work in Zurich, I will send him chocolate :) | 17:23 |
| hub_cap | aababilov: i can help | 17:23 |
| hub_cap | i know peoples | 17:23 |
| hub_cap | do you have reviews or do we need to jump into keystone chat room and start talking w/ them? | 17:23 |
| aababilov | I have an abandoned review: https://review.openstack.org/#/c/42164/ | 17:24 |
| cppcabrera | aababilov: It's good hearing from you again. I'm going to go grab lunch and then return shortly. | 17:25 |
| aababilov | I relied on Jamie and suspended my work on it | 17:25 |
| aababilov | jamie is jamielennox on irc | 17:25 |
| aababilov | he is in Australia | 17:25 |
| aababilov | UTC+11 | 17:26 |
| aababilov | it's night there :) | 17:26 |
| hub_cap | yes it is! | 17:27 |
| hub_cap | we might have to wait till late afternoon UTC-8 time | 17:27 |
| hub_cap | whichi will be night time for you aababilov ;) | 17:27 |
| aababilov | I usually write jamie about 08:00 UTC+3 (my morning) | 17:27 |
| aababilov | I can try to catch him tomorrow | 17:28 |
| hub_cap | aababilov: let me do this... let me get all the info i can from people today | 17:28 |
| hub_cap | and i will send out to the ML and try to get consensus | 17:28 |
| hub_cap | so i can keep making progress | 17:28 |
| hub_cap | mordred wants me to finish this and he has offered review / smacking people help | 17:28 |
| aababilov | here are jamie's commits: https://review.openstack.org/#/q/status:open+project:openstack/python-keystoneclient+branch:master+topic:bp/auth-plugins,n,z | 17:30 |
| hub_cap | ugh these are 2+wks old | 17:32 |
| aababilov | that's why I begin to worry | 17:32 |
| hub_cap | yes ill bring it up on the mailing list. i need to make progress and i dont have 2 more wks to wait | 17:32 |
| aababilov | ok! I will wait for mail tomorrow and I will go have a rest today | 17:35 |
| aababilov | see you! | 17:35 |
| *** aababilov has left #openstack-marconi | 17:35 | |
| *** kgriffs_afk is now known as kgriffs | 17:41 | |
| *** kgriffs is now known as kgriffs_afk | 17:55 | |
| *** ayoung is now known as ayoung-vrooom | 18:05 | |
| openstackgerrit | Muharem Hrnjadovic proposed a change to openstack/python-marconiclient: This adds a transport layer request spec class https://review.openstack.org/47892 | 18:07 |
| al-maisan | flaper87|afk: please see ^ | 18:07 |
| cppcabrera | al-maisan: I read your patchset for the third time now to get a feel for how this will work. | 18:27 |
| cppcabrera | My understanding is that this will be coupled with some form of httpclient to issue the actual requests and will serve as the low level layer for all transport implementations. | 18:27 |
| cppcabrera | For example, building 'client.queues' on top of 'Request.list_queues'. | 18:28 |
| cppcabrera | where client.queues() -> lists queues from API using a Python generator | 18:28 |
| cppcabrera | And the Request portion provides a lot of the validation machinery. | 18:28 |
| cppcabrera | Am I understanding the purpose of your patchset correctly? | 18:28 |
| * cppcabrera wants to review this patch with understanding of what it's trying to solve | 18:29 | |
| al-maisan | cppcabrera: yes, the request spec captures what needs done and is passed to the transport layer which turns it into an actual (http, zmq, etc.) request | 18:35 |
| al-maisan | it's a bit of an API toward the transport layer | 18:36 |
| al-maisan | wrt the validation: it's supposed to be specific to a Marconi API version | 18:36 |
| cppcabrera | makes sense that the validation would be version specific. I can also see another layer of validation being added that would be transport-specific, but that's down the line. This spec aspect is a first line of defense, perse. | 18:37 |
| al-maisan | going forward we might have version specific code like here: https://github.com/openstack/python-cinderclient/tree/master/cinderclient | 18:38 |
| cppcabrera | ooohh, link | 18:38 |
| cppcabrera | Thanks for sharing! | 18:38 |
| cppcabrera | I'll give your patchset a review after I check out that link | 18:38 |
| al-maisan | and 'api.py' will then probably live underneath a 'v1' directory | 18:38 |
| al-maisan | sure | 18:38 |
| cppcabrera | By the end of the day, really. :) | 18:38 |
| al-maisan | take your time | 18:38 |
| al-maisan | thanks for looking at it! | 18:38 |
| cppcabrera | np. Thanks for helping marconiclient grow! :D | 18:40 |
| *** oz_akan_ has quit IRC | 18:43 | |
| *** oz_akan_ has joined #openstack-marconi | 18:44 | |
| *** kgriffs_afk is now known as kgriffs | 18:46 | |
| *** oz_akan_ has quit IRC | 18:48 | |
| *** cthulhup_ has quit IRC | 18:49 | |
| *** oz_akan_ has joined #openstack-marconi | 18:55 | |
| al-maisan | not at all sure whether flaper87|afk will be happy ;-) let's see what he says.. | 18:59 |
| * al-maisan signs off | 18:59 | |
| hub_cap | cppcabrera: hey just to make sure, the apiclient stuff didnt get removed cuz it was broken, right? | 19:37 |
| hub_cap | as in, buggy... | 19:37 |
| cppcabrera | that's correct, hub_cap. We didn't find bugs in the run-time, though we didn't test. We had design concerns. | 19:39 |
| hub_cap | ok thx cppcabrera. ill let the design concerns leak into oslo :) | 19:39 |
| kgriffs | cppcabrera: got a minute? | 19:42 |
| kgriffs | I thought I would just comment on these patches as I go through them rather than do it in gerrit, since i guess you are just making notes and will update in the next batch of patches... | 19:43 |
| cppcabrera | +1 kgriffs | 19:44 |
| *** malini is now known as malini_afk | 19:44 | |
| kgriffs | ok | 19:44 |
| kgriffs | first up: | 19:44 |
| kgriffs | https://review.openstack.org/#/c/47399/5/marconi/proxy/resources/catalogue.py | 19:45 |
| kgriffs | will these results need to be pageable? | 19:45 |
| cppcabrera | I'm not sure. One project could have many queues, and it might be useful for an admin to be able to paginate over the results rather than having them all dumped in a single shot. | 19:46 |
| kgriffs | is there a doc somewhere showing the API design? | 19:47 |
| cppcabrera | If pagination is more than a nice-to-have, this'll bring markers + limits into the discussion | 19:47 |
| cppcabrera | yes | 19:47 |
| cppcabrera | #link https://wiki.openstack.org/wiki/Marconi/specs/proxy/v1 (proxy API spec) | 19:47 |
| cppcabrera | This page is not yet linked to by anything because it;ll likely evolve after a review of the proxy itself. | 19:48 |
| *** ayoung-vrooom is now known as ayoung | 19:50 | |
| * kgriffs is looking | 19:52 | |
| kgriffs | "Paging is not supported at this time." | 19:52 |
| kgriffs | ok, so I think you should start a list of "planned enhancements" or something | 19:52 |
| kgriffs | paging is definitely something you will want since a single project can have thousands of queues | 19:52 |
| cppcabrera | +1 | 19:52 |
| cppcabrera | I may just tack this list onto the marconi-proxy-issues etherpad for now | 19:53 |
| kgriffs | generally speaking, we should take some time over the next few team mtgs to review this admin API | 19:53 |
| cppcabrera | I'd appreciate that! | 19:54 |
| cppcabrera | It's been fun crafting an API, but nothing beats team input for making it even better | 19:54 |
| kgriffs | yep, it's always good to seek feedback early, often | 19:55 |
| kgriffs | (added to next week's agenda) | 19:55 |
| cppcabrera | awesome | 19:56 |
| cppcabrera | quick side note - I need to add a context manager to timeutils to handle time overrides | 19:57 |
| cppcabrera | just noticed this while fixing an age bug in marconi queues storage | 19:57 |
| kgriffs | https://review.openstack.org/#/c/47399/5/marconi/proxy/resources/metadata.py | 19:58 |
| cppcabrera | metadata - that's got the worst hack of the system, IMO | 19:58 |
| kgriffs | so, weren't we going to query partitions and merge the listings, so you didn't have to dupe data in the catalog? | 19:59 |
| cppcabrera | that's a planned enhancement, kgriffs. It's also a pretty high priority one, so I can start working on that one tomorrow | 20:00 |
| kgriffs | ok, just checking | 20:00 |
| cppcabrera | that enhancement eliminates the metadata hack, for one. :D | 20:00 |
| kgriffs | right | 20:00 |
| kgriffs | https://review.openstack.org/#/c/47402/7/marconi/proxy/storage/mongodb/catalogue.py | 20:07 |
| kgriffs | that docstring at the top has "Name" and "Host" capitalized? | 20:07 |
| kgriffs | actually, looks like other caps snuck in there as well | 20:08 |
| kgriffs | cppcabrera: ^^^ | 20:08 |
| cppcabrera | hmm... | 20:09 |
| cppcabrera | those caps are intentional | 20:09 |
| cppcabrera | I'm attempting to connet the rationale of the one-letter key to the word | 20:09 |
| cppcabrera | associations. :) | 20:10 |
| kgriffs | hmmm | 20:13 |
| kgriffs | maybe a slightly different syntax would make it more clear | 20:13 |
| kgriffs | e.g. | 20:13 |
| kgriffs | 'p': [p]roject name :: str | 20:13 |
| kgriffs | TBH, i don't think it is worth worrying about. People are smart. They will figure it out | 20:14 |
| kgriffs | the underscores just look strange to me, I guess | 20:14 |
| * kgriffs is picking nits | 20:14 | |
| cppcabrera | it's cool. I'll take all the ideas. | 20:14 |
| cppcabrera | I'm actually pretty fond of the [p] syntax, so I'll keep that in mind for the future. | 20:15 |
| cppcabrera | P was the first thing that came to mind. | 20:15 |
| kgriffs | L51 | 20:15 |
| kgriffs | aren't you basically taking everything except '_id' here? | 20:15 |
| cppcabrera | yes. | 20:17 |
| cppcabrera | Is that overspecifying things? | 20:18 |
| cppcabrera | I think I got a bit zealous with fields while writing this. :P | 20:18 |
| openstackgerrit | A change was merged to openstack/marconi: proxy: memory storage driver + tests + fixes https://review.openstack.org/47399 | 20:20 |
| kgriffs | what do you think about only specifying {'_id': 0} | 20:20 |
| kgriffs | same goes for L66 | 20:23 |
| cppcabrera | I think it's a great idea - keeps the impl. flexible | 20:23 |
| cppcabrera | In case schema changes | 20:23 |
| kgriffs | ok | 20:24 |
| kgriffs | noted? | 20:24 |
| cppcabrera | yup | 20:25 |
| kgriffs | ok, moving on... | 20:25 |
| kgriffs | L94: multi is False by default iirc | 20:27 |
| kgriffs | "The default value for multi is currentlyFalse, but this might eventually change to True" | 20:28 |
| kgriffs | ah, gtk | 20:28 |
| kgriffs | let's keep that in there. | 20:28 |
| cppcabrera | cool. I had to read pymongo docs a lot. | 20:29 |
| cppcabrera | I essentially learned my mongo off of this proxy dev. | 20:29 |
| kgriffs | cppcabrera: https://review.openstack.org/#/c/47402/7/marconi/proxy/storage/mongodb/driver.py | 20:42 |
| kgriffs | L48 | 20:42 |
| kgriffs | the name is a a little awkward... | 20:42 |
| kgriffs | how about "PartitioningController" | 20:43 |
| kgriffs | or just "PartitionController" | 20:43 |
| * kgriffs picking more nits | 20:43 | |
| cppcabrera | lol | 20:43 |
| kgriffs | https://review.openstack.org/#/c/47402/7/marconi/proxy/storage/mongodb/partitions.py | 20:44 |
| kgriffs | L 46 | 20:44 |
| kgriffs | L47 | 20:44 |
| kgriffs | I mean | 20:44 |
| kgriffs | there again, you should only need '_id': 0 | 20:44 |
| kgriffs | noted? | 20:46 |
| cppcabrera | I'm inclined to stick with PartitionsController since it handles many. :x | 20:46 |
| cppcabrera | Yes, the '_id' fields problem is globally noted. | 20:46 |
| kgriffs | ok | 20:46 |
| kgriffs | moving on | 20:46 |
| cppcabrera | I'll come around and fix the fields issue in a single patch targeting just that. | 20:46 |
| cppcabrera | It's rather prevalent. | 20:46 |
| kgriffs | kk | 20:47 |
| kgriffs | FWIW, I think "normalize" may not be the best name for that function, but I know it is used elsewhere already, so until we change it globally this is ok | 20:48 |
| kgriffs | any other patches you want me to ninjapprove? | 20:49 |
| cppcabrera | The associated unit test patches that zyuan has been working on. | 20:49 |
| cppcabrera | I think I have them listed in the issues pad... | 20:50 |
| * cppcabrera checks | 20:50 | |
| cppcabrera | yup, they're there | 20:50 |
| cppcabrera | https://etherpad.openstack.org/marconi-proxy-issues | 20:50 |
| cppcabrera | Thanks for looking through this, kgriffs! | 20:50 |
| kgriffs | yw | 20:50 |
| * kgriffs doesn't want to miss his flight | 20:51 | |
| cppcabrera | lol | 20:52 |
| kgriffs | https://review.openstack.org/#/c/47628/1/marconi/proxy/resources/health.py | 20:54 |
| kgriffs | marconi service returns 204 | 20:54 |
| kgriffs | why the change to 200 here? | 20:54 |
| kgriffs | zyuan: ^^^ | 20:54 |
| kgriffs | also, it needs on_head | 20:54 |
| cppcabrera | noted re: on_head | 20:56 |
| cppcabrera | Many resources are missing this. | 20:57 |
| kgriffs | well, health needs on_head since LB's like to use it | 20:57 |
| openstackgerrit | A change was merged to openstack/marconi: proxy: mongodb storage driver https://review.openstack.org/47402 | 20:58 |
| kgriffs | what's the story on this? | 20:59 |
| kgriffs | https://review.openstack.org/#/c/47628/1/marconi/proxy/utils/helpers.py | 20:59 |
| cppcabrera | I haven't looked too thoroughly into that, but zyuan mentioned headers... | 21:02 |
| cppcabrera | I may be able to find the falcon comments | 21:02 |
| cppcabrera | This: https://github.com/racker/falcon/issues/185 | 21:02 |
| cppcabrera | kgriffs: ^^ | 21:02 |
| kgriffs | ah | 21:03 |
| cppcabrera | I'm not sure if capitalize is necessary, but that's the story. | 21:03 |
| kgriffs | so there are two issues at play | 21:03 |
| kgriffs | one is that one in falcon | 21:03 |
| kgriffs | when you set header and want to override an earlier one | 21:03 |
| kgriffs | there is a nuance there with WSGI and/or HTTP that is on the tip of my tongue... | 21:04 |
| *** malini_afk is now known as malini | 21:04 | |
| cppcabrera | HTTP allows duplicate headers, WSGI does not, IIRC | 21:05 |
| cppcabrera | I'm heading out for the night. Let me know if you find any more issues, kgriffs! I'll fix them up tomorrow. So far, the majority of the issues have been on the easy side to handle. ;) | 21:07 |
| * cppcabrera hopes he hasn't jinxed it | 21:07 | |
| cppcabrera | :P | 21:07 |
| cppcabrera | Good night~ | 21:07 |
| *** cppcabrera has left #openstack-marconi | 21:08 | |
| *** oz_akan_ has quit IRC | 21:11 | |
| *** iampims has joined #openstack-marconi | 21:11 | |
| *** oz_akan_ has joined #openstack-marconi | 21:12 | |
| *** oz_akan_ has quit IRC | 21:16 | |
| *** gordonsim has quit IRC | 21:48 | |
| *** amitgandhi has quit IRC | 21:56 | |
| *** amitgandhi has joined #openstack-marconi | 21:56 | |
| *** hub_cap has left #openstack-marconi | 21:58 | |
| *** oz_akan_ has joined #openstack-marconi | 22:22 | |
| *** amitgandhi has quit IRC | 22:22 | |
| *** mpanetta has quit IRC | 22:23 | |
| *** tedross has quit IRC | 22:26 | |
| *** oz_akan_ has quit IRC | 22:28 | |
| *** openstack has joined #openstack-marconi | 22:31 | |
| *** cthulhup has joined #openstack-marconi | 22:50 | |
| *** cthulhup has quit IRC | 22:54 | |
| openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: fix(mongodb): Marker generation creates a bottleneck under heavy load https://review.openstack.org/47272 | 23:12 |
| *** kgriffs is now known as kgriffs_afk | 23:15 | |
| *** malini is now known as malini_afk | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!