| *** acabrera has joined #openstack-marconi | 00:14 | |
| *** acabrera has left #openstack-marconi | 00:15 | |
| *** nosnos has joined #openstack-marconi | 00:16 | |
| *** kgriffs is now known as kgriffs_afk | 00:20 | |
| *** reed has quit IRC | 00:24 | |
| *** acabrera has joined #openstack-marconi | 00:26 | |
| *** ayoung has quit IRC | 00:27 | |
| *** acabrera has left #openstack-marconi | 00:27 | |
| *** oz_akan_ has joined #openstack-marconi | 00:35 | |
| *** malini is now known as malini_afk | 00:43 | |
| *** tedross has joined #openstack-marconi | 01:26 | |
| *** oz_akan_ has quit IRC | 01:49 | |
| *** oz_akan_ has joined #openstack-marconi | 01:49 | |
| *** oz_akan_ has quit IRC | 01:51 | |
| *** oz_akan_ has joined #openstack-marconi | 01:51 | |
| *** tedross has quit IRC | 01:58 | |
| *** oz_akan_ has quit IRC | 02:25 | |
| *** oz_akan_ has joined #openstack-marconi | 02:26 | |
| *** oz_akan_ has quit IRC | 02:30 | |
| *** oz_akan_ has joined #openstack-marconi | 03:36 | |
| *** nosnos has quit IRC | 03:40 | |
| *** nosnos has joined #openstack-marconi | 03:41 | |
| *** oz_akan_ has quit IRC | 03:42 | |
| *** nosnos has quit IRC | 03:42 | |
| *** nosnos has joined #openstack-marconi | 03:44 | |
| *** kgriffs_afk is now known as kgriffs | 03:48 | |
| *** reed has joined #openstack-marconi | 03:58 | |
| *** kgriffs is now known as kgriffs_afk | 04:01 | |
| *** reed has quit IRC | 05:07 | |
| *** flaper87|afk is now known as flaper87 | 07:30 | |
| *** ykaplan has joined #openstack-marconi | 07:51 | |
| *** gordonsim has joined #openstack-marconi | 08:00 | |
| openstackgerrit | A change was merged to openstack/marconi: fix(mongodb): Remove $or clause used to claim messages https://review.openstack.org/47590 | 08:42 |
|---|---|---|
| *** ykaplan has quit IRC | 10:59 | |
| *** oz_akan_ has joined #openstack-marconi | 11:20 | |
| *** ykaplan has joined #openstack-marconi | 11:27 | |
| *** oz_akan_ has quit IRC | 11:38 | |
| *** ykaplan has quit IRC | 11:40 | |
| *** ykaplan has joined #openstack-marconi | 11:44 | |
| flaper87 | here it comes! | 11:59 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Restructure client code https://review.openstack.org/48223 | 11:59 |
| flaper87 | there it is | 11:59 |
| flaper87 | :) | 11:59 |
| flaper87 | Clien tests take 0.00s each! w000t | 12:00 |
| flaper87 | :D | 12:00 |
| *** tedross has joined #openstack-marconi | 12:12 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Add common http class https://review.openstack.org/48236 | 12:38 |
| *** acabrera has joined #openstack-marconi | 12:40 | |
| *** acabrera is now known as alcabrera | 12:41 | |
| alcabrera | Morning! :) | 12:41 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Add common http class https://review.openstack.org/48236 | 12:45 |
| flaper87 | alcabrera: yo yo | 12:45 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Restructure client code https://review.openstack.org/48223 | 12:45 |
| *** oz_akan_ has joined #openstack-marconi | 12:49 | |
| *** oz_akan_ has quit IRC | 12:52 | |
| *** oz_akan_ has joined #openstack-marconi | 12:52 | |
| alcabrera | flaper87: Those 2 patches have been reviewed - +2 on both of them. | 12:53 |
| alcabrera | I'm going to look at the rest of the review queue now. :D | 12:53 |
| flaper87 | alcabrera: AWESOME! Thanks! | 12:54 |
| flaper87 | btw, I replied to one of your comments in one of my patches :D | 12:54 |
| alcabrera | Moving the unit tests - yeah, I saw that one! I agree with you entirely. I reviewed so much yesterday I lost track of what was doing what. :P | 12:55 |
| flaper87 | No worries at all. :) | 12:56 |
| *** ykaplan has quit IRC | 12:57 | |
| alcabrera | flaper87: I'll be filing that proxy bug once I go through reviews. | 12:57 |
| alcabrera | A bug to address all the standing design issues - there's a few left yet. :) | 12:58 |
| alcabrera | Though I did file the bug for eliminating the global config. | 12:58 |
| flaper87 | alcabrera: yeah, saw that bug, thanks! I actually picked it :P | 13:01 |
| flaper87 | alcabrera: if they are not so many, a bug for each pending issue would be awesome. That would help to get folks to contribute on those | 13:01 |
| alcabrera | flaper87: +1 | 13:02 |
| alcabrera | flaper87: ah, what do you think of adding :type: and :rtype: to docstrings? | 13:02 |
| alcabrera | I noticed sphinx has this feature yesterday. | 13:02 |
| flaper87 | alcabrera: +1 lets enforce that in reviews | 13:03 |
| alcabrera | sweet. I started doing it rather adhoc-style, e.g., `:param hosts: [text] - a list of URLs`, but that was before I realized the type could be specified in a special way. | 13:04 |
| flaper87 | btw, a gentle reminder, I think there are some patches that were submitted before the structure refactor, pls, double check that those patches don't add things following the old structure | 13:04 |
| flaper87 | I did it but you know, just in case | 13:04 |
| flaper87 | I mean, if you happen to review one of those patches | 13:05 |
| alcabrera | flaper87: I'll keep an eye out for patches that might violate the restructuring. | 13:05 |
| flaper87 | alcabrera: danke! | 13:07 |
| *** ayoung has joined #openstack-marconi | 13:10 | |
| *** mpanetta has joined #openstack-marconi | 13:12 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: adds oslo.cache, config support, & stevedore https://review.openstack.org/47475 | 13:16 |
| flaper87 | who's this d00d? ^ | 13:18 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix(proxy): forward marconi headers https://review.openstack.org/47628 | 13:18 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mirror structure of marconi queues + bootstrap https://review.openstack.org/47642 | 13:18 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: test(proxy): fix proxy-transport tests https://review.openstack.org/47612 | 13:18 |
| alcabrera | all the rebasing~ | 13:19 |
| *** oz_akan_ has quit IRC | 13:24 | |
| *** oz_akan_ has joined #openstack-marconi | 13:24 | |
| *** kgriffs_afk is now known as kgriffs | 13:25 | |
| kgriffs | at the airport | 13:25 |
| mpanetta | kgriffs: On your way here? | 13:25 |
| kgriffs | online thanks to the nation's largest wifi network: NETGEAR | 13:26 |
| mpanetta | Which airport? | 13:26 |
| flaper87 | kgriffs: have a safe flight | 13:26 |
| kgriffs | austin | 13:26 |
| mpanetta | Ah cool | 13:26 |
| mpanetta | Watch the weather on your way. | 13:26 |
| kgriffs | kk | 13:26 |
| kgriffs | i've got about 45 min before I have to board | 13:26 |
| mpanetta | Cool | 13:27 |
| mpanetta | I'm about to attempt to cherry pick this patch. | 13:27 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: proxy: mirror structure of marconi queues + bootstrap https://review.openstack.org/47642 | 13:28 |
| flaper87 | kgriffs: then review.openstack.org is waiting for you :D | 13:29 |
| alcabrera | kgriffs: o/ | 13:29 |
| mpanetta | Or maybe not. | 13:33 |
| *** jcru has joined #openstack-marconi | 13:37 | |
| kgriffs | flaper87: :D | 13:37 |
| alcabrera | kgriffs: here's some amusing pre-flight reading: https://twitter.com/HackerNewsOnion | 13:40 |
| alcabrera | I happened upon that this morning and found some very amusing bits of technical wordplay. :P | 13:40 |
| * alcabrera has now reviewed all marconi-related patches. | 13:41 | |
| alcabrera | Now for some bug reports | 13:41 |
| alcabrera | py3k is now a voting gate for marconiclient. | 13:42 |
| kgriffs | LOL | 13:43 |
| kgriffs | "MongoDB adds a "PLEASE" keyword for inserts, boosting chance that data is stored to above 75%." | 13:43 |
| kgriffs | it's FUD, but still funny | 13:43 |
| alcabrera | kgriffs: That's what I'm talking about, haha. | 13:43 |
| kgriffs | (mongodb has had good persistence for quite a while now) | 13:43 |
| * kgriffs follows | 13:44 | |
| alcabrera | 'A load balancer walks into a shareholder meeting. CEO says "Nope, no proxies allowed."' | 13:44 |
| kgriffs | ooooh | 13:44 |
| kgriffs | https://twitter.com/TechCrunchOnion | 13:44 |
| alcabrera | hmmmm ^ | 13:45 |
| * kgriffs things the real TechCrunch is evil | 13:45 | |
| alcabrera | "BREAKING – Dropbox and Box agree to merger, new company to be called DropboxBox" | 13:45 |
| alcabrera | lol | 13:45 |
| kgriffs | while we are on a tangent, you guys folllow @wwwtxt ? | 13:45 |
| flaper87 | kgriffs: https://review.openstack.org/#/c/47334/ pleeeasseeeee | 13:45 |
| flaper87 | :D | 13:46 |
| kgriffs | it's pretty darn awesome | 13:46 |
| alcabrera | kgriffs: not yet - I'll check it out. :D | 13:46 |
| flaper87 | mmh, dunno any wwwtxt | 13:46 |
| kgriffs | flaper87: not now, I'm busy wasting time on the internetz! | 13:46 |
| kgriffs | It's some guys thesis - he tweets old text from the intertubes that is eerily relevant to current events. | 13:47 |
| flaper87 | kgriffs: LOOOL | 13:47 |
| alcabrera | The Apple-related ones are quite - well, it reflects the state of things pretty well. :P | 13:47 |
| kgriffs | flaper87: can you just add a NOTE there: https://review.openstack.org/#/c/47334/6/tests/auth/test_base.py | 13:48 |
| kgriffs | then I will +2 | 13:48 |
| kgriffs | also, moving it outside the try block may help reduce confusion | 13:48 |
| kgriffs | (I am assuming you don't expect L30 to fail) | 13:48 |
| flaper87 | kgriffs: you're right, lemme do that | 13:49 |
| flaper87 | don't jump on that plain yet | 13:49 |
| kgriffs | re breaking the dep between those patches, TBH, I'm not convinced it is worth the trouble making them independent right now. Some of the lines overlap and whichever merges first will cause some extra rebasing work with the other | 13:49 |
| kgriffs | re benchmarking them, if we benchmark just the marker gen/counter patch | 13:50 |
| kgriffs | then benchmark the same with p+q added on top, we should be able to extrapolate over the relative performance gain/loss between the two | 13:50 |
| kgriffs | I think the the marker patch needs to go in regardless so we can get rid of marconi-gc | 13:51 |
| kgriffs | so, it is about to become the new baseline anyway | 13:51 |
| flaper87 | sounds like a plan to me! My main concern is the benchmark results we saw, I wanted to let the q+p patch land first instead of keeping it around waiting for the marker patch to land | 13:52 |
| flaper87 | I like the marker patch, TBH | 13:52 |
| kgriffs | btw - i was considering doing the p+q treatment on the queues collection as well, since that is now used to lookup/increment the counter when posting messages | 13:52 |
| kgriffs | flaper87: I am about to address your last comment, and if there is nothing else, the marker patch is good to go, nicht? | 13:52 |
| alcabrera | kgriffs: I'm +1 on the marker patch. Even if there's a slight drop in perf, I think the new approach is easier to reason about. | 13:52 |
| flaper87 | +1 for me | 13:53 |
| kgriffs | there isn't a drop in perf | 13:53 |
| flaper87 | from me | 13:53 |
| alcabrera | kgriffs: yeah, unify the storage layer across the p+q treatment. It's likely relevant to all the other storage drivers (future and current), as well. | 13:54 |
| kgriffs | and the test doesn't account for GC time which should be significantly improved, as well as retries on marker collision | 13:54 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Authentication API + NoAuth backend https://review.openstack.org/47334 | 13:54 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Add keystone backend https://review.openstack.org/48041 | 13:54 |
| alcabrera | It also helps a lot that we reached consensus on the whole delimiter thing - "project/queue" | 13:54 |
| kgriffs | flaper87: thoughts on p+q in queues collection? | 13:54 |
| flaper87 | kgriffs: alcabrera guys, could you re+2 those 2 patches? | 13:54 |
| flaper87 | kgriffs: +1 | 13:55 |
| flaper87 | that will also keep some consistency between both resources | 13:55 |
| kgriffs | yes, just as soon as gerrit +1s it. ;) | 13:55 |
| flaper87 | I already gave it some nutella, he'll +1 it | 13:56 |
| flaper87 | :D | 13:56 |
| flaper87 | ok, gerrit +1'd the first | 13:56 |
| alcabrera | flaper87: +2'd | 13:56 |
| flaper87 | alcabrera: danke | 13:56 |
| flaper87 | :) | 13:56 |
| alcabrera | I double-checked the py3 details in the process, to make sure those stayed healthy. :P | 13:56 |
| flaper87 | and the second one! | 13:57 |
| * alcabrera cringes whenever he sees print statements | 13:57 | |
| flaper87 | alcabrera: Py3K is now voting :D | 13:57 |
| alcabrera | flaper87: I saw the email! :) | 13:57 |
| flaper87 | meaning, we can now trust jenkins +1 on Py3k support | 13:57 |
| flaper87 | w000t | 13:57 |
| alcabrera | flaper87: as long as our test coverage stays decent, of course | 13:58 |
| alcabrera | :D | 13:58 |
| alcabrera | (which it will) | 13:58 |
| openstackgerrit | A change was merged to openstack/python-marconiclient: Authentication API + NoAuth backend https://review.openstack.org/47334 | 13:58 |
| flaper87 | alcabrera: LOOOOOOOOOOOOL | 13:58 |
| flaper87 | kgriffs: the second one got +1 | 13:58 |
| kgriffs | question | 13:58 |
| kgriffs | https://review.openstack.org/#/c/48041/5/marconiclient/auth/keystone.py | 13:58 |
| flaper87 | shoot | 13:58 |
| kgriffs | just thinking ahead, eventually there won't be a 1:1 mapping between project ID and auth token, as in a single token will be authorized for multiple project IDs. We will need a way then to set X-Project-ID in the client. That will also require updating keystone middleware to stop clobbering X-Project-ID and instead verify it with belongsTo, but something to keep in mind for later. | 14:00 |
| flaper87 | knock knock, still there? | 14:00 |
| flaper87 | HOLY MOLY! | 14:00 |
| flaper87 | that's a quesiton | 14:00 |
| * flaper87 sits and reads | 14:01 | |
| alcabrera | lol | 14:01 |
| * alcabrera notes that this is not a question | 14:01 | |
| alcabrera | kgriffs: good point, though. | 14:01 |
| flaper87 | alcabrera: LOL, just noted that! | 14:01 |
| *** yassine has joined #openstack-marconi | 14:02 | |
| flaper87 | kgriffs: yeah, so, that code already adds a way to set the token either through CLI params or config options | 14:03 |
| kgriffs | ok, so we can just follow that pattern to allow setting other auth headers | 14:03 |
| flaper87 | if the token is manually set, it won't try to get one *unless* the request returns a 401 | 14:03 |
| kgriffs | (eventually) | 14:03 |
| flaper87 | and just then it'll retry to get a new one (if the user wants so) | 14:03 |
| kgriffs | (e.g., X-Project-ID) | 14:03 |
| flaper87 | kgriffs: yeah! | 14:03 |
| kgriffs | cool beans | 14:03 |
| flaper87 | X-Project-ID is something the Transport instance will take care of | 14:04 |
| flaper87 | but yes, you're right | 14:04 |
| kgriffs | kk | 14:04 |
| flaper87 | just trying to share what I have in mind | 14:04 |
| flaper87 | :D | 14:04 |
| kgriffs | gotta board soon | 14:05 |
| kgriffs | quick question | 14:05 |
| kgriffs | https://review.openstack.org/#/c/48041/5/tests/auth/test_keystone.py | 14:05 |
| kgriffs | L69 | 14:05 |
| kgriffs | how does that end up setting test-token? | 14:05 |
| flaper87 | kgriffs: yup | 14:05 |
| flaper87 | the header, that's what I meant to test there | 14:05 |
| kgriffs | the mock in the other test sets it | 14:05 |
| kgriffs | but no mock in test_with_token? | 14:06 |
| flaper87 | kgriffs: yup because the first test mocks a keystone call | 14:06 |
| flaper87 | the second one gets the token from configs | 14:06 |
| flaper87 | L67 | 14:06 |
| kgriffs | oh, duh | 14:06 |
| kgriffs | thanks | 14:06 |
| kgriffs | I'm rushing since I gotta go | 14:06 |
| flaper87 | thank you! | 14:06 |
| alcabrera | kgriffs: enjoy the flight. :) | 14:06 |
| flaper87 | no worries | 14:06 |
| flaper87 | have a safe flight, after you +2 that patch | 14:07 |
| flaper87 | :D | 14:07 |
| alcabrera | lol | 14:07 |
| alcabrera | That is the duty of a core reviewer - +2, -2; all other things are secondary. | 14:07 |
| flaper87 | yeah! | 14:08 |
| *** nosnos has quit IRC | 14:08 | |
| kgriffs | all ur patch are belong to me | 14:10 |
| openstackgerrit | A change was merged to openstack/python-marconiclient: Add keystone backend https://review.openstack.org/48041 | 14:10 |
| alcabrera | woot | 14:11 |
| flaper87 | w0000000000t | 14:11 |
| flaper87 | kgriffs: thanks d000000d :D | 14:11 |
| flaper87 | alcabrera: btw, didn't know hoist :D | 14:12 |
| *** malini_afk is now known as malini | 14:13 | |
| kgriffs | yw | 14:14 |
| kgriffs | boarding any minute now | 14:14 |
| kgriffs | can't…stop…must…keep…hacking | 14:14 |
| alcabrera | lol | 14:14 |
| alcabrera | flaper87: I'd seen it around in the marconi code, mostly __init__.py's. I had to verify that it was a word (google: define hoist) just before I responded. :) | 14:15 |
| malini | alcabrera: I am all fuming now with my cake story this morning & I see ur comment 'my tasty {0} cake'.format('chocolate')' | 14:19 |
| malini | any example today should not involve cake :D | 14:19 |
| alcabrera | malini: hahaha | 14:20 |
| alcabrera | malini: After reading your email, I had cake on my mind | 14:20 |
| alcabrera | very relevant | 14:20 |
| malini | :D | 14:20 |
| flaper87 | cake? Chocolate cake? cake? | 14:21 |
| flaper87 | can I have some? | 14:21 |
| flaper87 | :D | 14:21 |
| malini | flaper87: its a chocolate cake & I waited for 40 loooong minutes waiting for the guy to finish it up! | 14:22 |
| malini | wish I cud send u some.. | 14:22 |
| malini | u have a 3D printer? ;) | 14:22 |
| flaper87 | malini: not sure if the taste would be the same, I'm pretty sure the consistency will, though | 14:22 |
| malini | http://www.nytimes.com/2013/09/22/opinion/sunday/dinner-is-printed.html?pagewanted=all | 14:24 |
| malini | alcabrera: w.r.t ur review comments, did you mean to have all the asserts in an internal function? | 14:25 |
| alcabrera | flaper87: on more than one occasion while going grocery shopping, I have though, "Man, if only I had Flavio's address! I'd totally send him a box of poptarts!". :D | 14:25 |
| malini | do they have poptarts in italy? | 14:26 |
| alcabrera | malini: for the tests test_get_stats_queue_no_claimed and test_get_stats_queue_one_claimed, yes. | 14:26 |
| *** ametts has quit IRC | 14:26 | |
| *** kgriffs is now known as kgriffs_afk | 14:26 | |
| malini | alcabrera: I am a lil wary abt that, since that will make it less obvious in the test about wht we are verifying | 14:27 |
| malini | especially since it is just a bunch of asserts | 14:28 |
| alcabrera | malini: If you could move the common parts of those two tests into probably three functions, that'd be ideal. Something like: _test_stats_match_expected(self, xclaimedcount=1, xfreecount=..., xtotal=...) | 14:28 |
| flaper87 | alcabrera: I can give you my address :D | 14:28 |
| flaper87 | wait, isn't it in google already? | 14:28 |
| flaper87 | I'm surprissed google bike hasn't come yet | 14:29 |
| alcabrera | malini: check out https://github.com/openstack/marconi/blob/master/tests/unit/proxy/storage/base.py#L57 (what do you think of this approach?) | 14:30 |
| malini | alcabrera: I would rather make it a new assert in the base class..Again I am not convinced abt moving it away from the tests, since we wont use it any other tests. | 14:30 |
| malini | https://github.com/openstack/marconi/blob/master/tests/unit/proxy/storage/base.py#L57 looks like a great candidate for a new assert in the base class ;) | 14:31 |
| alcabrera | flaper87: yeah, send it to me in /msg or an email. I'll send something your way sometime. :) | 14:31 |
| alcabrera | malini: hehe, it may be the case. I thought it was pretty specific to the storage:partitions unit since it targets just the structure of that, but I think I see what you mean! | 14:32 |
| malini | alcabrera: like this https://github.com/openstack/marconi/blob/master/marconi/tests/functional/base.py#L76 | 14:32 |
| malini | (it feels weird typing aLcabrera) | 14:32 |
| alcabrera | malini: Something like an a general @abstractmethod: test_check_structure or something like that. | 14:32 |
| alcabrera | malini: changed my name last night - acabrera was taken and I was tired of being cppcabrera, haha | 14:33 |
| alcabrera | malini: ahh, I see. The only problem I have with something like assertIsSubset in the general case is that there's the danger of matching up values incorrectly. I can see it working for headers alright, but for more mixed fields, I like having the option of matching them up by argument name, like here: https://github.com/openstack/marconi/blob/master/tests/unit/proxy/storage/base.py#L97 | 14:39 |
| malini | alcabrera: I can make those named arguments. | 14:43 |
| alcabrera | malini: for the assertIsSubset? | 14:47 |
| * alcabrera got confused :( | 14:47 | |
| malini | alcabrera: yes.. | 14:47 |
| alcabrera | malini: I don't think assertIsSubset needs changes - it's *really* good at doing set comparisons. | 14:51 |
| alcabrera | But bringing it back to the original point - the stats test patch (which is awesome!), I'm okay with merging the patch as is. | 14:52 |
| alcabrera | err, +2-ing, anyway. :P | 14:53 |
| malini | dont +2 yet | 14:54 |
| malini | I am fixing some stuff :D | 14:54 |
| alcabrera | malini: alright, let me know. :) | 14:55 |
| alcabrera | malini: when you're done, could you place a note in the review comments regarding what you fixed? | 14:55 |
| malini | alcabrera: sure | 14:56 |
| *** cthulhup has joined #openstack-marconi | 14:57 | |
| *** amitgandhi has joined #openstack-marconi | 14:58 | |
| *** cthulhup has quit IRC | 15:00 | |
| *** cthulhup has joined #openstack-marconi | 15:01 | |
| *** fvollero has joined #openstack-marconi | 15:02 | |
| flaper87 | fvollero: yo, welcome! | 15:03 |
| fvollero | flaper87: yo thanks bro :) | 15:03 |
| flaper87 | guys, I'd like to introduce fvollero to you! He's a guy I found sitting outside my door begging me to do something reall really really cool!!! I invited him to join | 15:04 |
| alcabrera | fvollero: heeey! Welcome! | 15:04 |
| fvollero | flaper87: Lol, funny as hell... :) | 15:04 |
| * alcabrera notes that cool things do happen here | 15:04 | |
| fvollero | alcabrera: Thanks a bunch man! | 15:04 |
| malini | hello fvollero!!! | 15:04 |
| fvollero | malini: hello :) | 15:04 |
| flaper87 | jokes apart, fvollero is a fellow red hatter and he'll contribute as much as his time permits to Marconi | 15:05 |
| * flaper87 gets LP bugs url | 15:05 | |
| flaper87 | muahahhahaha muahahha | 15:05 |
| alcabrera | lol | 15:05 |
| fvollero | meh :) | 15:06 |
| malini | blasphemy!! flaper87 thinks doing cool stuff in marconi is a joke!!!!! | 15:06 |
| malini | Glad to have you here fvollero ! | 15:06 |
| fvollero | flaper87: i'll try, as much is in my power... to not choke you or poison the sweets you desire so much | 15:06 |
| fvollero | malini: let's wait to see some of my code before saying that :) | 15:06 |
| flaper87 | malini: I never said that :( I said in my open-mic that Marconi is the coolest channel / team / project EVER! | 15:07 |
| flaper87 | :D | 15:07 |
| flaper87 | fvollero: https://bugs.launchpad.net/marconi/+bug/1228249 there you go! | 15:08 |
| flaper87 | that should give you some context about Marconi :) | 15:09 |
| flaper87 | please, don't hesitate to ask anything! | 15:09 |
| malini | flaper87: just kidding :) | 15:09 |
| flaper87 | malini: you gotta give me a piece of that cake now! | 15:10 |
| flaper87 | and don't play the 3D printer card!!! | 15:10 |
| malini | :D | 15:10 |
| malini | I am sure ametts will let me expense the ticket to italy | 15:11 |
| fvollero | :) | 15:11 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix: age presented as negative https://review.openstack.org/48277 | 15:11 |
| alcabrera | speaking of bugs ^^ | 15:11 |
| flaper87 | I moved a file in one of my recently approved commits that I now want to move back.... DON'T HATE MY SCHIZOPHRENIA | 15:13 |
| alcabrera | flaper87: lol | 15:15 |
| alcabrera | flaper87, malini: Could I get a review on the pending 'negative age' patch? | 15:15 |
| flaper87 | alcabrera: Yes sir, right away | 15:15 |
| malini | alcabrera: am already on it | 15:16 |
| alcabrera | awesome! | 15:16 |
| flaper87 | alcabrera: reviewed | 15:18 |
| flaper87 | you left a print in the test | 15:18 |
| flaper87 | I'm ok with removing that other code in this patch, I don't think this patch will be reverted, ever. | 15:18 |
| alcabrera | heh, those print()s. | 15:18 |
| alcabrera | fixing~ | 15:18 |
| alcabrera | flaper87: cool | 15:18 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix: age presented as negative https://review.openstack.org/48277 | 15:19 |
| alcabrera | print removed ^^ | 15:19 |
| flaper87 | alcabrera: awesome, LGTM. Lets wait for Jenkins to bless it | 15:19 |
| malini | alcabrera: I added a couple of comments in the first patch set | 15:20 |
| alcabrera | malini: thanks! | 15:20 |
| alcabrera | malini: yeah, I agree with your 'incr/wait' comment. I'd add that as a separate patch, though. | 15:21 |
| alcabrera | Thankfully, the mongodb driver does age calculations based off of utcnow, so that'd be an easy test to write. | 15:22 |
| malini | we might also want to do the same test in claims | 15:22 |
| alcabrera | unfortunately, the sqlite driver doesn't use utcnow... :/ | 15:22 |
| flaper87 | yeah | 15:22 |
| flaper87 | I'd prefer not sleeping the test, TBH | 15:22 |
| alcabrera | flaper87: I'm with you. | 15:23 |
| malini | flaper87: why ? | 15:23 |
| flaper87 | malini: because it makes tests slow | 15:23 |
| flaper87 | and we're just at the very beggining of Marconi's development | 15:23 |
| malini | do you have an alternate approach in such scenarios? | 15:24 |
| flaper87 | there'll be tons of new tests and I'd prefer to mock things instead of sleeping | 15:24 |
| fvollero | alcabrera: yeah, meanwhile in the real world, people write code :) | 15:24 |
| flaper87 | malini: I guess patching utcnow works for mongodb's driver | 15:24 |
| alcabrera | flaper87: patching utcnow definitely works. I enjoyed seeing the -10 age when I first set out to fix this bug. :) | 15:25 |
| alcabrera | flaper87: for mongodb, that is. | 15:26 |
| malini | flaper87: works for me | 15:26 |
| flaper87 | TBH, in this very specific case, I'm not sure that test is actually worth it. I mean, it's all a `now - utils.blah_blah` calc after all. | 15:26 |
| flaper87 | but hey, we managed to invert those 2 so... | 15:26 |
| flaper87 | :D | 15:26 |
| malini | I am very skeptic of 'this will never break' :d | 15:27 |
| malini | The last time I said 'it'll never happen in prod' - that was the first bug we got from support :D | 15:27 |
| flaper87 | ahhahahahahha | 15:27 |
| alcabrera | heh. :P | 15:28 |
| alcabrera | malini: thankfully, this test does exercise marconi's production grade driver correctly. | 15:28 |
| alcabrera | **storage driver | 15:28 |
| alcabrera | the sleep isn't necessary to trigger the age calculation | 15:28 |
| malini | malini: I am good with what we have, except adding the test for claim age too | 15:32 |
| *** whenry has joined #openstack-marconi | 15:32 | |
| flaper87 | malini: you talking to yourself? | 15:33 |
| malini | :D | 15:33 |
| malini | I missed my medication today ;) | 15:33 |
| flaper87 | flaper87: I'm good with what we have.... flaper87 nooo we're not, you shouldn't be doing that... flaper87 yes, I'll and I'm doing so | 15:34 |
| flaper87 | we should write a book out of what we talk in this channel | 15:34 |
| malini | :D..you can read minds , just like I do!! | 15:34 |
| flaper87 | :D | 15:34 |
| flaper87 | seriously, it's like a mix of techy insanity with real world examples | 15:35 |
| alcabrera | malini: oooohhh, I'm so glad I decided to test the claim deal | 15:37 |
| alcabrera | malini: claims *also* have the bug | 15:37 |
| alcabrera | now fixing | 15:37 |
| alcabrera | (negative age on claims) | 15:37 |
| malini | heheee..I can think up bugs..I have the POWER!! | 15:37 |
| alcabrera | malini: :D :D :D | 15:37 |
| alcabrera | "MismatchError: -1 is not < -10 | 15:37 |
| alcabrera | " | 15:37 |
| flaper87 | malini: you know what? I'll give you my piece of cake, you deserve it! | 15:39 |
| malini | yayyy!! | 15:39 |
| alcabrera | now to run pep8 and... | 15:39 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix: age presented as negative https://review.openstack.org/48277 | 15:40 |
| alcabrera | malini, flaper87: ^^ | 15:41 |
| alcabrera | There ya go - squeaky clean marconi-queues. | 15:41 |
| alcabrera | not as tasty as cake - but it'll do. :P | 15:41 |
| *** reed has joined #openstack-marconi | 15:42 | |
| malini | I think I am finally getting over the cake paranoia..I am no longer repulsed by cake | 15:43 |
| alcabrera | brb | 15:49 |
| alcabrera | back - desk lunch, woot! | 15:51 |
| *** ykaplan has joined #openstack-marconi | 15:53 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Add a base transport class https://review.openstack.org/48287 | 15:53 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Restructure client code https://review.openstack.org/48223 | 15:53 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Add a base transport class https://review.openstack.org/48287 | 15:54 |
| alcabrera | flaper87: what changed in 48223 (restrcuture)? | 15:54 |
| flaper87 | alcabrera: I moved transport/request back | 15:55 |
| flaper87 | alcabrera: I moved transport/request.py back | 15:55 |
| alcabrera | oh, *that*. :P | 15:55 |
| flaper87 | :D | 15:55 |
| flaper87 | technically, I didn't touched it at all :D (at least git doesn't show that anymore) | 15:55 |
| alcabrera | lol | 15:55 |
| alcabrera | I can see that now. | 15:55 |
| * alcabrera counts the number of changed files | 15:56 | |
| flaper87 | ah fuck, I completely forgot to run tests for the last one | 15:56 |
| flaper87 | SOOO ASHAMED | 15:56 |
| flaper87 | (facepalm) | 15:56 |
| alcabrera | jenkins will know. >:) | 15:56 |
| alcabrera | Time to write those proxy bug reports~ | 15:57 |
| alcabrera | Then, I need to tackle that admin API deal (before I address technical debt). D: | 15:57 |
| fvollero | naive question, where i get the code ? :D | 16:01 |
| alcabrera | fvollero: https://github.com/openstack/marconi/ | 16:01 |
| alcabrera | also | 16:01 |
| alcabrera | https://github.com/openstack/python-marconiclient/ | 16:01 |
| alcabrera | the first is server-side, the other is client-side. :) | 16:01 |
| *** yassine has quit IRC | 16:07 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Add a base transport class https://review.openstack.org/48287 | 16:08 |
| openstackgerrit | Malini Kamalambal proposed a change to openstack/marconi: Add Tests for Queue Stats https://review.openstack.org/48012 | 16:13 |
| *** whenry has quit IRC | 16:21 | |
| alcabrera | flaper87: marconi proxy bugs - http://bit.ly/18ZEpIE | 16:21 |
| alcabrera | I catalogued the most pending ones. | 16:22 |
| flaper87 | alcabrera: man, you rock! | 16:22 |
| flaper87 | thanks for that! | 16:22 |
| alcabrera | :) | 16:22 |
| alcabrera | s/pending/pressing | 16:22 |
| * alcabrera mixes idioms all the time | 16:22 | |
| *** amitgandhi has quit IRC | 16:38 | |
| *** ykaplan has quit IRC | 17:16 | |
| alcabrera | flaper87: I've figured out how to create separate config files now - I'm getting to understand oslo.config a little more each day! | 17:19 |
| alcabrera | I'm looking at having: ~/.marconi/[marconi, proxy].conf | 17:20 |
| alcabrera | perhaps that marconi.conf should be queues.conf...? | 17:20 |
| flaper87 | alcabrera: I'd prefer marconi-(queues|proxy|notifications).conf | 17:21 |
| alcabrera | even though they would be created in the .marconi directory? | 17:21 |
| alcabrera | adding the extra marconi- seems redundant, or am I missing something? :x | 17:22 |
| alcabrera | flaper87: ^ | 17:22 |
| flaper87 | well, our default folder is /etc/marconi or .marconi but, users can put those files wherever they want | 17:22 |
| alcabrera | hmmm | 17:22 |
| alcabrera | I see. | 17:22 |
| alcabrera | ~/ and /etc/ are on the default search path, after all | 17:23 |
| flaper87 | yeah | 17:23 |
| alcabrera | alright, +1 to marconi-X for X in {queues, notifications, proxy} | 17:23 |
| alcabrera | flaper87: I'm also agreeing with you more over time that the common.config needs to be eliminated - I had to add the prog parameter to it to get this scheme working. :P | 17:25 |
| flaper87 | alcabrera: yeah, it also hides some nice methods in ConfigOpts (like find_config_file) | 17:26 |
| flaper87 | so, either we completely proxy ConfigOpts or we eliminate common.config | 17:26 |
| flaper87 | and I prefer the later | 17:26 |
| alcabrera | I prefer the latter, as well (atm). It seems like too much trouble to hide the interface behind something slightly friendly. Seems it'd be more effective to make the changes in oslo.config (2.0+) if the interface could benefit from being nicer. | 17:29 |
| alcabrera | (**slightly more friendly | 17:30 |
| alcabrera | flaper87: while on the subject of configs - for oslo.cache, I feel like having the config section named [oslo_cache] *and* having the cache_* prefix to the options is too redundant. Thoughts on simplifying to backend, prefix vs. cache_backend, cache_prefix? | 17:31 |
| *** cthulhup has quit IRC | 17:34 | |
| flaper87 | alcabrera: ah yeah!! | 17:35 |
| flaper87 | that sounds kinda redundant to me too | 17:35 |
| flaper87 | mmh, also, the cache_prefix should actually be namespace | 17:36 |
| alcabrera | +1 | 17:36 |
| flaper87 | and cache_backend could be default_backend | 17:36 |
| alcabrera | Want me to submit this as a bug report? :D | 17:36 |
| alcabrera | flaper87: I'm not sure about default_backend... seems like the choice of backend would be immutable after the application using oslo.cache has launched. | 17:37 |
| flaper87 | alcabrera: add a comment here : https://review.openstack.org/#/c/32544/15 | 17:38 |
| flaper87 | :D | 17:38 |
| flaper87 | alcabrera: it is not immutable, in theory you could call get_cache as many times as you want | 17:38 |
| alcabrera | ahhh | 17:39 |
| alcabrera | that's true | 17:39 |
| alcabrera | default_backend works for me, in that case. | 17:40 |
| *** amitgandhi has joined #openstack-marconi | 17:47 | |
| malini | alcabrera: will proxy authenticate with a regular x-auth-token, or is there a super user thing? | 18:09 |
| alcabrera | malini: regular x-auth-token | 18:10 |
| alcabrera | malini: the admin portion of the API is meant to be kept in a place that is not accessible by public users | 18:11 |
| malini | cool.. | 18:11 |
| malini | q2. why don't we have an update partition? | 18:11 |
| alcabrera | malini: heh - I didn't think to add it. >.> | 18:12 |
| alcabrera | malini: which is actually a pretty big oversite | 18:12 |
| alcabrera | *oversight | 18:12 |
| malini | yeah..we might want to add a new host to the partition , remove one etc | 18:12 |
| alcabrera | +1 | 18:12 |
| alcabrera | Could you create a bug for that? | 18:12 |
| malini | sure | 18:12 |
| alcabrera | I've been prefixing all proxy-related bug titles with [proxy] | 18:13 |
| alcabrera | that way, they're easy to find | 18:13 |
| alcabrera | GET,PUT /v1/partitions/{partition}/hosts and GET,PUT /v1/partitions/{partition}/weight should be a thing | 18:16 |
| alcabrera | those are missing admin routes, IMO. ^ | 18:16 |
| malini | alcabrera: https://bugs.launchpad.net/marconi/+bug/1230841 | 18:20 |
| alcabrera | malini: gracias! | 18:26 |
| malini | alcabrera: de nada | 18:27 |
| malini | alcabrera: Since weight corresponds to probability, the sum for all partitions should always be 100, rt? | 18:32 |
| alcabrera | malini: no - weight is actually summed up to form a spectrum. | 18:35 |
| alcabrera | So if we have a total weight of 500 between all partitions, and partition B has a weight of 50, it's chance of being chosen is 50/500 | 18:35 |
| alcabrera | *its | 18:35 |
| malini | aah ..ok | 18:35 |
| malini | it's a lil conter-intuitive. like with the response here https://wiki.openstack.org/wiki/Marconi/specs/proxy/v1#List_Partitions , its hard to understand how often a partition will be used | 18:37 |
| alcabrera | malini: it takes a little more to get to the answer than if probabilities were used, I agree there. In that example, "wat3" would be chosen (25 / (256 + 500 + 25)) times. | 18:41 |
| alcabrera | err, not times, with a probability of that. :P | 18:41 |
| *** gordonsim has quit IRC | 18:41 | |
| alcabrera | the benefit to usig a weighted system is that we can have more than 100 partitions. With probabilities, we're capped at 100 (if we stuck with integral probabilities) since 1 * 100 = 100% | 18:42 |
| alcabrera | The best reference to seeing the weighted algorithm in depth is: https://review.openstack.org/#/c/47475/4/marconi/proxy/utils/partition.py | 18:42 |
| malini | taht is right..or else with adding anew partition, you'll have to update all the old | 18:48 |
| malini | I take my 100 probability back :) | 18:49 |
| alcabrera | :) | 18:51 |
| *** reed has quit IRC | 19:22 | |
| *** amitgandhi has quit IRC | 19:43 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: separate config for queues and proxy https://review.openstack.org/48333 | 19:44 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix(proxy): forward marconi headers https://review.openstack.org/47628 | 19:44 |
| *** malini is now known as malini_afk | 20:00 | |
| *** amitgandhi has joined #openstack-marconi | 20:04 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: separate config for queues and proxy https://review.openstack.org/48333 | 20:08 |
| alcabrera | flaper87: Here's that patch that separates out configs in a by-project fashion. | 20:11 |
| alcabrera | :D | 20:11 |
| flaper87 | alcabrera: awesome, I'll take a look at it! | 20:12 |
| flaper87 | Thanks for the hard work on the proxy code | 20:12 |
| alcabrera | flaper87: np - it continues to be fun. :) | 20:19 |
| alcabrera | flaper87: it may involve a touch of rebasing, but I plan to come back to the mirroring patch and to handle as much technical debt as possible there. | 20:20 |
| alcabrera | (given I need to finish the public/admin proxy API split first) | 20:20 |
| *** flaper87 is now known as flaper87|afk | 21:03 | |
| *** alcabrera has quit IRC | 21:04 | |
| *** flaper87|afk is now known as flaper87 | 21:13 | |
| *** oz_akan_ has quit IRC | 21:22 | |
| *** malini_afk is now known as malini | 21:26 | |
| *** malini is now known as malini_afk | 21:39 | |
| *** malini_afk is now known as malini | 21:47 | |
| *** amitgandhi has quit IRC | 21:54 | |
| *** mpanetta has quit IRC | 22:14 | |
| *** jcru has quit IRC | 22:20 | |
| *** tedross has quit IRC | 22:31 | |
| *** oz_akan_ has joined #openstack-marconi | 22:33 | |
| *** oz_akan_ has quit IRC | 22:38 | |
| *** reed has joined #openstack-marconi | 23:16 | |
| *** flaper87 is now known as flaper87|afk | 23:33 | |
| *** malini is now known as malini_afk | 23:37 | |
| *** malini_afk is now known as malini | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!