*** malini_afk is now known as malini | 00:25 | |
*** zyuan_ has quit IRC | 00:27 | |
*** nosnos has joined #openstack-marconi | 00:34 | |
*** oz_akan_ has joined #openstack-marconi | 01:37 | |
*** amitgandhi has quit IRC | 02:08 | |
*** amitgandhi has joined #openstack-marconi | 02:09 | |
*** amitgandhi has quit IRC | 02:13 | |
*** malini is now known as malini_afk | 02:13 | |
*** vkmc has quit IRC | 02:20 | |
*** oz_akan_ has quit IRC | 02:32 | |
*** amitgandhi has joined #openstack-marconi | 03:09 | |
*** amitgandhi has quit IRC | 03:13 | |
*** amitgandhi has joined #openstack-marconi | 03:19 | |
*** ayoung has quit IRC | 03:20 | |
*** amitgandhi has quit IRC | 03:23 | |
*** fifieldt_ has joined #openstack-marconi | 03:25 | |
*** cpallares has left #openstack-marconi | 03:57 | |
*** amitgandhi has joined #openstack-marconi | 04:09 | |
*** amitgandhi has joined #openstack-marconi | 04:10 | |
*** amitgandhi has quit IRC | 04:15 | |
*** openstackgerrit has quit IRC | 04:36 | |
*** openstackgerrit has joined #openstack-marconi | 04:37 | |
*** reed has quit IRC | 05:02 | |
*** amitgandhi has joined #openstack-marconi | 05:11 | |
*** amitgandhi has quit IRC | 05:15 | |
*** amitgandhi has joined #openstack-marconi | 05:21 | |
*** amitgandhi has quit IRC | 05:25 | |
*** amitgandhi has joined #openstack-marconi | 06:11 | |
*** amitgandhi has joined #openstack-marconi | 06:12 | |
*** amitgandhi has quit IRC | 06:16 | |
*** ametts has quit IRC | 06:28 | |
*** ametts has joined #openstack-marconi | 06:31 | |
*** amitgandhi has joined #openstack-marconi | 07:12 | |
*** amitgandhi has quit IRC | 07:16 | |
*** EmilienM has quit IRC | 07:22 | |
*** EmilienM has joined #openstack-marconi | 07:25 | |
*** amitgandhi has joined #openstack-marconi | 08:12 | |
*** nosnos_ has joined #openstack-marconi | 08:29 | |
*** nosnos has quit IRC | 08:30 | |
*** flaper87|afk is now known as flaper87 | 08:34 | |
*** nosnos has joined #openstack-marconi | 09:02 | |
*** nosnos_ has quit IRC | 09:03 | |
*** amitgandhi has joined #openstack-marconi | 09:13 | |
*** amitgandhi has quit IRC | 09:17 | |
*** amitgandhi has joined #openstack-marconi | 09:23 | |
*** amitgandhi has quit IRC | 09:28 | |
*** yassine has joined #openstack-marconi | 09:43 | |
*** amitgandhi has joined #openstack-marconi | 10:14 | |
*** amitgandhi has quit IRC | 10:14 | |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Implement queue's API methods https://review.openstack.org/50638 | 10:28 |
---|---|---|
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Bootstrap Messages support https://review.openstack.org/52389 | 10:28 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Add list of required fields to the API definition https://review.openstack.org/51850 | 10:28 |
*** nosnos has quit IRC | 10:31 | |
*** nosnos has joined #openstack-marconi | 10:32 | |
*** nosnos has quit IRC | 10:36 | |
*** fifieldt_ has quit IRC | 10:52 | |
*** amitgandhi has joined #openstack-marconi | 11:15 | |
*** amitgandhi has quit IRC | 11:20 | |
*** tedross has joined #openstack-marconi | 11:23 | |
*** amitgandhi has joined #openstack-marconi | 11:25 | |
flaper87 | al-maisan: ping | 11:27 |
*** amitgandhi has quit IRC | 11:29 | |
*** flaper87 is now known as flaper87|afk | 11:30 | |
*** jcru has joined #openstack-marconi | 13:08 | |
*** yassine has quit IRC | 13:11 | |
*** oz_akan_ has joined #openstack-marconi | 13:11 | |
*** yassine has joined #openstack-marconi | 13:24 | |
*** yassine has quit IRC | 13:25 | |
*** yassine has joined #openstack-marconi | 13:26 | |
*** alcabrera has joined #openstack-marconi | 13:36 | |
alcabrera | Good morning! | 13:37 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: integrate shard storage with transport https://review.openstack.org/50998 | 13:38 |
*** malini_afk is now known as malini | 13:42 | |
*** mpanetta has joined #openstack-marconi | 13:44 | |
*** flaper87|afk is now known as flaper87 | 13:50 | |
flaper87 | alcabrera: GOOOOOD MORNING! | 13:51 |
alcabrera | flaper87: Hey! :D | 13:55 |
alcabrera | I was just making breakfast. | 13:55 |
flaper87 | alcabrera: enjoy your breakfast :D | 13:56 |
flaper87 | I just got to the office, we've PyMilano today | 13:56 |
flaper87 | :) | 13:56 |
alcabrera | ooohh | 13:56 |
flaper87 | and we'll discussing monkey patching | 13:57 |
alcabrera | Sounds like an exciting day. :) | 13:57 |
flaper87 | yeah, I just wish I didn't have so many things to do today :( | 13:57 |
flaper87 | I mean, this whole summit thing is consuming a lot of time | 13:57 |
flaper87 | and Friday is holiday here, which means my week will be shorter | 13:58 |
flaper87 | I think I'm the only one that complains because of holidays | 13:58 |
flaper87 | damnit! What's wrong with me! | 13:58 |
alcabrera | lol | 13:58 |
alcabrera | I was rather silly about holidays last year. | 13:58 |
alcabrera | I remember working right through Thanksgiving and such. | 13:59 |
alcabrera | Maybe Christmas, too. | 13:59 |
alcabrera | I worked way too much last year. | 13:59 |
alcabrera | I'm totally taking off Halloween this week. | 13:59 |
flaper87 | that's the right thing to do, I mean, taking some time off | 14:01 |
flaper87 | I keep saying it but, you know! | 14:01 |
*** kgriffs_afk is now known as kgriffs | 14:01 | |
*** amitgandhi has joined #openstack-marconi | 14:03 | |
openstackgerrit | Malini Kamalambal proposed a change to openstack/marconi: Add Tests for non-existing resources https://review.openstack.org/53691 | 14:04 |
malini | Good Morning!! | 14:04 |
alcabrera | malini: morning. :) | 14:04 |
*** ayoung has joined #openstack-marconi | 14:04 | |
*** ayoung has quit IRC | 14:05 | |
malini | flaper87: thanks for reviewing https://review.openstack.org/#/c/53691/..But I had to update the tests following our 404 vs 204 discussion on y'days meeting..I just submitted the updated patch | 14:05 |
*** acabrera has joined #openstack-marconi | 14:06 | |
flaper87 | malini: ah see, I was a bit confused while reviewing it, TBH! | 14:06 |
flaper87 | malini: let me take a look, right a way! | 14:06 |
flaper87 | malini: and good morning :) | 14:07 |
malini | I totally forgot abt updating the patch after our discussion :-$ | 14:07 |
flaper87 | malini: mmh, do we have unit tests for that patch? | 14:07 |
malini | hmm..this is a test patch | 14:07 |
flaper87 | erm, I mean, for the same functionality | 14:08 |
flaper87 | :) | 14:08 |
malini | iirc alcabrera talked abt adding some unit tests.. | 14:08 |
malini | dont know if he added it. | 14:08 |
flaper87 | malini: it'd be really cool to have them within the same patch, in case he hasn't added them yet! | 14:08 |
malini | one of these days I'll get my hands wet on the unit tests | 14:08 |
malini | sounds like this might be the day :D | 14:09 |
acabrera | I'm not sure if we have such unit tests. :P | 14:09 |
acabrera | I'll need to look around. | 14:09 |
acabrera | lemme see... | 14:09 |
malini | aahh..u r acabrera today.. | 14:09 |
*** alcabrera has quit IRC | 14:09 | |
acabrera | Yup - because VPN kicked me off. -_- | 14:09 |
acabrera | tehre we go | 14:09 |
acabrera | Now I can reclaim my name. | 14:09 |
*** acabrera is now known as alcabrera | 14:10 | |
alcabrera | All better. | 14:10 |
zyuan | alcabrera: https://review.openstack.org/#/c/54206/ do you mind me change logging in shards to use old style formatting? | 14:12 |
flaper87 | zyuan: we're moving everything to the new formatting :/ | 14:13 |
flaper87 | or at least, that's the plan | 14:13 |
flaper87 | :D | 14:13 |
flaper87 | zyuan: btw, +1 for that patch! | 14:14 |
flaper87 | thanks for working on that! | 14:14 |
zyuan | i've found how logging support new .format() yet | 14:14 |
alcabrera | hmm... | 14:15 |
malini | I see a post messae to missing queue https://github.com/openstack/marconi/blob/master/tests/unit/queues/transport/wsgi/test_messages.py#L183 | 14:15 |
alcabrera | I don't expect logging to have a means externally to support .format | 14:15 |
zyuan | me too... | 14:15 |
alcabrera | I'm a little surprised about its %s-style feature. | 14:15 |
zyuan | designed for lazy logging | 14:16 |
alcabrera | zyuan: I don't mind changing over to that style, given that it gives us lazy logging. | 14:16 |
zyuan | ok, i think i found how to make .format() work | 14:16 |
flaper87 | oh interesting issue | 14:17 |
alcabrera | malini: thanks for looking around. :) | 14:17 |
flaper87 | didn't know that! | 14:17 |
flaper87 | zyuan: looking forward to see how that works | 14:17 |
alcabrera | malini: we would benefit from unit tests that exercised GET on not_exists/messages and not_exists/claims. | 14:18 |
malini | alcabrera: I just added tht now :D | 14:18 |
malini | I am looking around for other stuff tht is worth going in there | 14:18 |
alcabrera | malini: awesome! | 14:20 |
alcabrera | flaper87: could I get you to look into this one? https://review.openstack.org/#/c/50815/ (mongodb shard storage) :D | 14:21 |
flaper87 | alcabrera: looking | 14:21 |
flaper87 | alcabrera: Partially-Closes: 1241686 (missing the #) | 14:22 |
alcabrera | Oops | 14:23 |
flaper87 | I think that's the reason there's no link there | 14:23 |
flaper87 | :/ | 14:23 |
flaper87 | don't change it | 14:23 |
flaper87 | is not necessary | 14:23 |
alcabrera | kk | 14:23 |
flaper87 | I just wanted to mention it | 14:23 |
alcabrera | I've been forgetting the # a lot lately. :P | 14:23 |
flaper87 | alcabrera: what did it do to you? | 14:23 |
alcabrera | No link~ | 14:24 |
alcabrera | I think it might not even trigger the 'Bug closing hook' thing without the #. :/ | 14:24 |
zyuan | .sethmm, no. logging module only supports old style, because there is only one style can be used in config file, like "%(asctime)s - %(name)s". the style in hard coded, logging/__init__.py line 467 | 14:28 |
zyuan | i will go change the shards part | 14:28 |
alcabrera | zyuan: thanks! | 14:28 |
*** jergerber has joined #openstack-marconi | 14:29 | |
alcabrera | kgriffs: thanks for the reviews! I'll fix up that catalogue driver with the latest feedback. :) | 14:33 |
kgriffs | kk | 14:36 |
*** ayoung has joined #openstack-marconi | 14:40 | |
flaper87 | kgriffs: I addressed your comments in the client patch :) | 14:41 |
*** cpallares has joined #openstack-marconi | 14:43 | |
cpallares | flaper87: hello! | 14:45 |
kgriffs | gtk: "- Issue #18427: str.replace could crash the interpreter with huge strings." | 14:50 |
kgriffs | http://hg.python.org/cpython/raw-file/9750acbf7c40/Misc/NEWS | 14:50 |
kgriffs | there is one example why it is important to validate input... | 14:50 |
kgriffs | I'm not sure about the exact nature (*how* it crashes) | 14:51 |
kgriffs | could be benign, but the point is, bugs like that happen | 14:51 |
*** fvollero has joined #openstack-marconi | 14:53 | |
fvollero | :) | 14:53 |
fvollero | flaper87: kgriffs : alcabrera : goooooood morninnnnng! | 14:53 |
alcabrera | fvollero: hey hey! | 14:54 |
alcabrera | How go things? :D | 14:55 |
alcabrera | kgriffs: very gtk | 14:55 |
fvollero | alcabrera: y0 y0 :) | 14:56 |
*** oz_akan_ has quit IRC | 14:57 | |
kgriffs | o/ | 14:57 |
fvollero | alcabrera: normal, if god will, I can go again and do some good @ marconi (client/server/whatever) | 14:57 |
*** oz_akan_ has joined #openstack-marconi | 14:57 | |
alcabrera | fvollero: sweet! How is the elasticsearch back end coming along? ;) | 14:58 |
*** vkmc has joined #openstack-marconi | 14:58 | |
fvollero | alcabrera: i'm gonna start from scratch :D | 15:00 |
*** openstackgerrit has quit IRC | 15:00 | |
*** openstackgerrit has joined #openstack-marconi | 15:01 | |
openstackgerrit | Malini Kamalambal proposed a change to openstack/marconi: Add Tests for non-existing resources https://review.openstack.org/53691 | 15:03 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: add catalogue storage driver for queues https://review.openstack.org/52160 | 15:04 |
alcabrera | kgriffs: feedback addressed for ^^ | 15:04 |
alcabrera | fvollero: how come? I might have to do the same with my redis backend driver, admittedly. :P | 15:04 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(logging): format msg when log level met https://review.openstack.org/54206 | 15:05 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(logging): format msg when log level met https://review.openstack.org/54206 | 15:05 |
zyuan | ... | 15:05 |
*** ayoung has quit IRC | 15:05 | |
alcabrera | lots of patches. | 15:05 |
alcabrera | today's a patchy day. | 15:05 |
zyuan | patchy lol | 15:05 |
alcabrera | kgriffs, flaper87: are we going to triage BPs come 1600 UTC? Or was it 1700 UTC? :) | 15:06 |
alcabrera | I'm going to go review *all the patches* now. | 15:07 |
zyuan | :) | 15:08 |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Cleaned drivers in proxy and queues config files Closes Bug: 1231669 https://review.openstack.org/54351 | 15:10 |
flaper87 | alcabrera: 16 UTC | 15:10 |
* flaper87 is back! | 15:11 | |
flaper87 | I just did a puzzle (a real one)! :D | 15:11 |
flaper87 | fvollero: I got everything from Emanuela! | 15:11 |
flaper87 | THANKS! | 15:11 |
alcabrera | flaper87: welcome back! | 15:11 |
flaper87 | cpallares: around? | 15:11 |
cpallares | flaper87: yep! | 15:12 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(logging): format msg when log level met https://review.openstack.org/54206 | 15:12 |
alcabrera | flaper87: reviewing your client patches first. :) | 15:12 |
flaper87 | alcabrera: I'm reviewing your patch :D | 15:13 |
flaper87 | I got distracted by some red & white m&ms | 15:13 |
flaper87 | :D | 15:13 |
flaper87 | and then I thought about doing the puzzle that was right next to them | 15:14 |
flaper87 | :D | 15:14 |
flaper87 | cpallares: awesome, did my suggestion work ? | 15:14 |
cpallares | flaper87: I think they did | 15:14 |
alcabrera | flaper87: mmmm, m&ms... | 15:16 |
cpallares | flaper87: They did work, but I was looking at the files and some of them look different... I forgot to pull the latest updates. | 15:18 |
* cpallares shakes head | 15:18 | |
flaper87 | cpallares: hehee | 15:19 |
cpallares | hi alcabrera :) | 15:19 |
flaper87 | cpallares: btw, you need to squash those commits | 15:19 |
cpallares | idk how to squash commits | 15:19 |
flaper87 | cpallares: otherwise it won't be possible to merge them since it still depends on the previous commits | 15:19 |
cpallares | flaper87: so.... it means merge them, right? | 15:19 |
flaper87 | cpallares: you've 2 options and both require rebasing | 15:19 |
flaper87 | cpallares: yeah! | 15:19 |
flaper87 | it's not difficult | 15:19 |
flaper87 | so, commit everything | 15:20 |
alcabrera | cpallares: hey! :) | 15:20 |
flaper87 | wait, before telling you how to squash them, let me tell you how to amend a commit | 15:20 |
flaper87 | unless you already know that | 15:20 |
flaper87 | cpallares: ^ | 15:20 |
*** ayoung has joined #openstack-marconi | 15:20 | |
cpallares | flaper87: I'm not sure so please do. | 15:20 |
flaper87 | alcabrera: the ones I just ate had 'Red Hat' written ontop :D | 15:20 |
flaper87 | cpallares: so, to amend a commit you just need: "git ci --amend" | 15:21 |
flaper87 | erm | 15:21 |
flaper87 | 'git commit --amend' | 15:21 |
fvollero | flaper87: glad to hear that | 15:21 |
flaper87 | sorry, I'm so used to my aliases | 15:21 |
alcabrera | flaper87: all client patches reviewed. Almost all +2'd, except for a typo in the queues one. :P | 15:21 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(logging): format msg when log level met https://review.openstack.org/54206 | 15:21 |
flaper87 | alcabrera: damn, why that one? WHY? | 15:21 |
flaper87 | :D | 15:21 |
alcabrera | ;) | 15:22 |
flaper87 | fvollero: I owe you one, buddy! | 15:22 |
fvollero | alcabrera: better to start fresh, in this way there are less probabilities that something get screwed :) | 15:22 |
fvollero | flaper87: yep! :P | 15:22 |
flaper87 | cpallares: that will amend the existing commit, which basically means, it'll re-use the last commit for your new changes | 15:23 |
alcabrera | fvollero: good point, and it's esp. easy to do when it's still being experimentally developed. :D | 15:23 |
fvollero | alcabrera: exactly :) | 15:23 |
cpallares | flaper87: ooooooh okay, yes, I did not know that. | 15:23 |
flaper87 | cpallares: :) | 15:23 |
flaper87 | cpallares: if you already submitted something for review, and you're addressing the comments in the review, then you need to amend your commit and run git review again | 15:24 |
alcabrera | cpallares: amending commits is wonderful, and having awesome commit messages helps everyone keep track of why we changed things. :D | 15:24 |
flaper87 | it'll add a new patch set to the existing review instead of creating a new one | 15:24 |
flaper87 | cpallares: re commit messages, you may want to read this: https://wiki.openstack.org/wiki/GitCommitMessages | 15:24 |
flaper87 | alcabrera: https://review.openstack.org/#/c/50815/13/marconi/queues/storage/sharding.py | 15:25 |
flaper87 | alcabrera: isn't admin_mode already registered by the transport? | 15:26 |
alcabrera | hmmm | 15:26 |
alcabrera | that looks like an oops | 15:26 |
flaper87 | :) | 15:26 |
alcabrera | flaper87: ahh, I see what I did. | 15:26 |
alcabrera | I remember this from yesterday. | 15:26 |
alcabrera | kgriffs asked the same question. | 15:26 |
flaper87 | brb | 15:26 |
alcabrera | It was an oops that I fix in the patch after. :P | 15:26 |
alcabrera | flaper87: https://review.openstack.org/#/c/50998/12/marconi/queues/storage/sharding.py (fixed here) | 15:27 |
zyuan | https://review.openstack.org/#/c/54206/ | 15:33 |
flaper87 | BACK | 15:35 |
flaper87 | ops | 15:35 |
flaper87 | back | 15:35 |
alcabrera | flaper87: more puzzles and m&ms? :D | 15:35 |
flaper87 | alcabrera: just m&ms and ordering pizza for tonight's meetup | 15:35 |
flaper87 | :D | 15:35 |
alcabrera | w00t | 15:35 |
flaper87 | sooo, glad to know that's already fixed in the next patch. I'm happy with letting it land as-is since that code doesn't break marconi | 15:35 |
alcabrera | cool, cool | 15:36 |
kgriffs | what do you think about this design? good? bad? ugly? | 15:36 |
kgriffs | http://goo.gl/owZtqa | 15:36 |
flaper87 | kgriffs: MAN, I love it! | 15:37 |
flaper87 | :D | 15:37 |
alcabrera | lessee... | 15:37 |
openstackgerrit | Malini Kamalambal proposed a change to openstack/marconi: Add Tests for non-existing resources https://review.openstack.org/53691 | 15:37 |
kgriffs | that's an actual schematic (albeit doctored) from Marconi's 1896 radio receiver | 15:37 |
alcabrera | hehehe | 15:37 |
mpanetta | kgriffs: SWEET | 15:37 |
zyuan | veeery cool | 15:37 |
alcabrera | nice! | 15:37 |
alcabrera | simple, sweet, marconi | 15:38 |
malini | kgriffs: tht is cool! | 15:38 |
kgriffs | excellent | 15:39 |
zyuan | kgriffs: review https://review.openstack.org/#/c/54206/ | 15:39 |
kgriffs | I am having a real graphics guy spruce up the artwork for printing | 15:39 |
kgriffs | zyuan: looking | 15:39 |
flaper87 | alcabrera: +2 | 15:40 |
alcabrera | w0000t | 15:40 |
flaper87 | alcabrera: btw, I added some comments there that I'd like us to revisit | 15:40 |
flaper87 | they weren't worth a -1 | 15:40 |
alcabrera | flaper87: just saw them pop up in my email. | 15:41 |
alcabrera | thanks! | 15:41 |
alcabrera | I wonder if I've already addressed the AdminControllerBase thing yet...? | 15:42 |
openstackgerrit | A change was merged to openstack/marconi: feat: shards mongodb driver + tests https://review.openstack.org/50815 | 15:42 |
alcabrera | all that's left before sharding work can continue is (https://review.openstack.org/#/c/50998/) and (https://review.openstack.org/#/c/52160/). Getting close! | 15:43 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Implement queue's API methods https://review.openstack.org/50638 | 15:43 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Bootstrap Messages support https://review.openstack.org/52389 | 15:43 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Add list of required fields to the API definition https://review.openstack.org/51850 | 15:43 |
flaper87 | alcabrera: kgriffs ^^^^^^^ | 15:43 |
flaper87 | pls | 15:43 |
flaper87 | :D | 15:43 |
kgriffs | :D | 15:43 |
flaper87 | alcabrera: no idea, re Admin! I'll get to the next shard patch in a bit! | 15:43 |
alcabrera | oooohh, rebased patches. :D | 15:43 |
flaper87 | alcabrera: those are all brand new | 15:43 |
flaper87 | alcabrera: kididng | 15:43 |
flaper87 | :D | 15:43 |
flaper87 | kidding | 15:43 |
alcabrera | lol | 15:43 |
* kgriffs eats rebased patches for breakfast | 15:43 | |
alcabrera | kgriffs: that *can't* be good for you. :P | 15:44 |
flaper87 | alcabrera: but it is for us | 15:44 |
flaper87 | :D | 15:44 |
flaper87 | alcabrera: so, SHHH!!! | 15:44 |
openstackgerrit | A change was merged to openstack/marconi: feat(logging): format msg when log level met https://review.openstack.org/54206 | 15:44 |
zyuan | malini: ping | 15:44 |
* alcabrera tastes a rebased patch - grimaces. | 15:44 | |
* flaper87 watches kgriffs review rebased patches instead of having a real breakfast! | 15:44 | |
kgriffs | alcabrera: https://review.openstack.org/#/c/52160/7/marconi/queues/storage/mongodb/catalogue.py | 15:45 |
kgriffs | you are right, I must have been looking at it cross-eyed. :p | 15:45 |
flaper87 | alcabrera: puzzle: https://twitter.com/flaper87/status/395208060136083456/photo/1 | 15:46 |
kgriffs | alcabrera: re https://review.openstack.org/#/c/52160/7/marconi/queues/storage/mongodb/utils.py | 15:46 |
kgriffs | I don't mind globals so much when they are simple constants | 15:46 |
kgriffs | and you access them using the module name | 15:46 |
alcabrera | kgriffs: I'm with you on that. I forgot they existed when I wrote that function, heh. ;) | 15:47 |
alcabrera | I think I've spent too much free time playing with Haskell. :P | 15:47 |
alcabrera | flaper87: +2'd 50638 (client queues) | 15:48 |
kgriffs | alcabrera: one more thought | 15:49 |
kgriffs | nevermind | 15:49 |
kgriffs | just realized my thought was invalid | 15:49 |
flaper87 | LOL | 15:49 |
* kgriffs whistles nonchalantly | 15:49 | |
alcabrera | :D | 15:49 |
kgriffs | bad branch prediction | 15:49 |
alcabrera | lessee... puzzle... | 15:50 |
* kgriffs wonders if anyone gets CPU jokes | 15:50 | |
alcabrera | You've stalled your pipeline, kgriffs | 15:50 |
* flaper87 does! :D | 15:50 | |
mpanetta | haha | 15:50 |
* kgriffs is so glad he isn't alone in the world with his nerdy-a** jokes | 15:50 | |
kgriffs | alcabrera: https://review.openstack.org/#/c/52160 | 15:50 |
zyuan | :) | 15:50 |
openstackgerrit | Malini Kamalambal proposed a change to openstack/marconi: Add Tests for non-existing resources https://review.openstack.org/53691 | 15:50 |
kgriffs | so, is that ready to rock? | 15:51 |
mpanetta | Nerdy jokes ++ | 15:51 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(mongo): starts to use aggregation for stats https://review.openstack.org/50969 | 15:51 |
zyuan | jsut a rebase | 15:51 |
alcabrera | kgriffs: yup, should be all ready. | 15:51 |
alcabrera | Even has 20% more tests than last go around. ;) | 15:51 |
kgriffs | waaaait a minute | 15:52 |
flaper87 | LOL | 15:52 |
kgriffs | didn't you have 3 patches pending? | 15:52 |
mpanetta | Someone blew the patch stack! | 15:52 |
mpanetta | :P | 15:52 |
alcabrera | kgriffs: one was merged a moment ago - mongodb impl. for admin API shard registry. :P | 15:53 |
* mpanetta is in a silly mood | 15:53 | |
kgriffs | mpanetta: nevermind that. I'm just hacking into the team core. | 15:53 |
* kgriffs goes back to smashing the stack | 15:53 | |
mpanetta | The team isn't multi core? Wow, time to upgrade. :P | 15:53 |
alcabrera | (mdb) bt => No stack trace. | 15:53 |
kgriffs | gdb marconi core | 15:55 |
kgriffs | alcabrera: HECK JUST FROZE OVER | 15:55 |
kgriffs | A SHARDING PATCH WAS MERGED | 15:55 |
kgriffs | w00t! | 15:56 |
alcabrera | :D | 15:56 |
alcabrera | (2 to go - then **achievement unlocked**) | 15:56 |
kgriffs | 1up | 15:56 |
kgriffs | it's been a long road...gettin' from there to here. | 15:57 |
flaper87 | LOOOL | 15:58 |
kgriffs | https://www.youtube.com/watch?v=-vNqIGiTkIU&t=22 | 15:58 |
alcabrera | :P | 15:58 |
flaper87 | hahahahha | 15:59 |
mpanetta | kgriffs++ | 16:00 |
mpanetta | Don't make me decrement you bro. | 16:00 |
kgriffs | lol | 16:00 |
alcabrera | mpanetta: lol, nice | 16:00 |
* flaper87 drops something here: https://wiki.openstack.org/wiki/Marconi/specs/api/next | 16:01 | |
kgriffs | ah, it is 1600 UTC after all | 16:01 |
kgriffs | mpanetta: do you prefer this instead? https://www.youtube.com/watch?v=p5kcBxL7-qI | 16:01 |
kgriffs | ok, lets spend a few minutes talking about api stuff | 16:02 |
alcabrera | kgriffs: TNG was my favorite. :D | 16:03 |
kgriffs | mine too | 16:03 |
kgriffs | #startmeeeting | 16:03 |
kgriffs | #startmeeting | 16:03 |
openstack | kgriffs: Error: A meeting name is required, e.g., '#startmeeting Marketing Committee' | 16:03 |
kgriffs | #startmeeting marconi-api | 16:03 |
openstack | Meeting started Tue Oct 29 16:03:43 2013 UTC and is due to finish in 60 minutes. The chair is kgriffs. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:03 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:03 |
openstack | The meeting name has been set to 'marconi_api' | 16:03 |
kgriffs | #link https://wiki.openstack.org/wiki/Marconi/specs/api/next | 16:04 |
mpanetta | kgriffs: Much better | 16:04 |
kgriffs | #topic Auto-generate client UUID if not given | 16:04 |
kgriffs | we discussed this briefly yesterday | 16:05 |
*** reed has joined #openstack-marconi | 16:05 | |
kgriffs | I propose giving this a thumbs-down | 16:05 |
kgriffs | BUT | 16:05 |
kgriffs | I could be convinced otherwise, if only because other projects don't require it. | 16:06 |
*** ayoung has quit IRC | 16:06 | |
kgriffs | on the other hand, other projects don't have the echo cancellation thing | 16:06 |
kgriffs | which breaks if you auto-generate, so that may cause confusion from users anyway | 16:06 |
kgriffs | flaper87: thoughts? | 16:06 |
flaper87 | sorry, I was writing an email :D | 16:07 |
flaper87 | back | 16:07 |
* flaper87 is a slow email writer | 16:07 | |
flaper87 | -1 for auto-generated UUIDs | 16:07 |
flaper87 | let me give my reasoning | 16:07 |
* alcabrera listens | 16:07 | |
flaper87 | 1) Just 'some' endpoints will use that | 16:08 |
flaper87 | 2) I expect users to use marconi with the client library | 16:08 |
flaper87 | 3) If users are using marconi with CURL then I don't think it'll be hard for them to add an uuid to the call | 16:08 |
flaper87 | 4) I'm +1 for consistency in the API, as much as possible! | 16:08 |
flaper87 | that's it | 16:08 |
kgriffs | makes sense | 16:09 |
alcabrera | works for me. | 16:09 |
kgriffs | I would just add to #1 that we want people to be able to mix and match messaging patterns without having to worry about when UUID matters | 16:10 |
*** ayoung has joined #openstack-marconi | 16:10 | |
flaper87 | kgriffs: +1 | 16:11 |
kgriffs | #info strike out auto-generate client UUID | 16:11 |
kgriffs | #topic Clearly define whether client ID is required for every request, and enforce it in the implementation | 16:11 |
kgriffs | currently we do not clearly define it in the spec, and it is only enforced in a few places | 16:11 |
alcabrera | Ah, I thought we were enforcing it every where... hmm... | 16:12 |
kgriffs | I would like to propose always requiring it so that it can be logged and used for analytics | 16:12 |
flaper87 | kgriffs: +1 | 16:12 |
alcabrera | Yeah, I'm +1 here. | 16:12 |
flaper87 | btw, besides openstackgerrit, is anyone writing this down? | 16:12 |
kgriffs | re logging, we will need a way to "bind" params to the logger, so it gets included in every subsequent log line. Can oslo.logging do that? | 16:12 |
flaper87 | I can do it if you guys want | 16:12 |
kgriffs | flaper87: I am making notes on the wiki page | 16:13 |
flaper87 | kgriffs: you rock, I haven't told you that enough! | 16:13 |
alcabrera | :) | 16:13 |
kgriffs | flaper87: we all rock in our own ways. :D | 16:14 |
kgriffs | for example, you are great at community building | 16:14 |
kgriffs | aaaanyway | 16:14 |
* flaper87 is great at eating m&ms | 16:14 | |
alcabrera | cpallares: thanks for clearing out the duplicated patches from the review queue! Greatly appreciated. :) | 16:14 |
* kgriffs suddenly has a craving for chocolate | 16:14 | |
mpanetta | kgriffs: The stuff you got me is almost gone, soo good, thank you again! | 16:15 |
cpallares | alcabrera: Just glad to help out :D | 16:15 |
kgriffs | #info Always require client id, and log the id in every log line for tracing, analytics, support, etc. | 16:16 |
kgriffs | #topic Consider allowing opaque string for client ID rather than UUID (will need to understand what else people want to use?) | 16:16 |
kgriffs | so... I'm not sure on this one | 16:16 |
zyuan | kgriffs: the door is closed | 16:17 |
kgriffs | like flaper87 said, it isn't *that* hard to generate one | 16:17 |
kgriffs | and saying it has to be uuid makes validation easier, and reduces confusion IMO | 16:17 |
kgriffs | any objections to striking this? | 16:17 |
* flaper87 listens to the silence | 16:18 | |
kgriffs | #info keep UUID requirement for Client-ID | 16:18 |
kgriffs | #topic Remove deprecated "partial results" semantics from message posting | 16:18 |
zyuan | +0.99 | 16:18 |
kgriffs | I added this one, since it is not longer possible to get partial results from the mongo driver | 16:19 |
flaper87 | you can get partial claims | 16:19 |
kgriffs | the only reason to keep it is if we expect other backends to need it | 16:19 |
kgriffs | flaper87: true, this proposal is just when posting messages | 16:19 |
flaper87 | as for now, I'm not sure about other backends needing it! | 16:19 |
flaper87 | kgriffs: ah ok, sorry! I missed that | 16:19 |
zyuan | i would suggest try optional fields for "other backends" | 16:19 |
kgriffs | mmm. makes me think of extensions | 16:20 |
kgriffs | ok, so get rid of the notion of a "partial" message post? Any objections? | 16:20 |
flaper87 | kgriffs: would it make sense to investigate other storage technologies? | 16:20 |
flaper87 | before taking a final decision | 16:21 |
flaper87 | mmh, actually | 16:21 |
flaper87 | I think the right quesiton here is: Do we want to allow this? | 16:21 |
kgriffs | yeah | 16:21 |
kgriffs | I guess that is what I was getting at as well | 16:22 |
kgriffs | it does complicate clients | 16:22 |
flaper87 | I'm leaning towards removing partial message posting completely | 16:22 |
alcabrera | hmm... | 16:22 |
alcabrera | I like the concept of all-or-nothing here. | 16:23 |
kgriffs | alcabrera: do you think you will have any trouble implementing that with Redis, for example? | 16:23 |
flaper87 | it's different for claims, because one can re-claim stuff | 16:23 |
kgriffs | SQL db's will have no problem, obviously | 16:23 |
flaper87 | but for messages there's too much to be aware off | 16:23 |
alcabrera | it shouldn't be any problem with Redis. IIRC, posting all the messages is a single communication with Redis. | 16:24 |
flaper87 | btw, what are we returning if the max_retries is reached in mongodb's backend? | 16:24 |
kgriffs | and redis will not ack on partial success? | 16:24 |
kgriffs | flaper87: probably 503 | 16:24 |
flaper87 | ok! | 16:25 |
alcabrera | kgriffs: turns out I'm doing one communication per message, so... it's not atomic with Redis, either. :P | 16:25 |
kgriffs | #topic Include Client ID in claim data | 16:25 |
flaper87 | cool, so, voting | 16:25 |
flaper87 | erm, I mean, we all agreed | 16:26 |
alcabrera | kgriffs: no partial ACK | 16:26 |
flaper87 | :D | 16:26 |
kgriffs | alcabrera: oic. You would need to batch them, then | 16:26 |
alcabrera | yup | 16:26 |
kgriffs | so, client ID in claim data | 16:26 |
kgriffs | if we do that, then we can include claim info when listing messages | 16:26 |
kgriffs | someone mentioned that would be nice for auditing and stuff | 16:27 |
kgriffs | cons are extra storage space | 16:27 |
flaper87 | mmh, agreed, however, the claim does not belong to that specific client | 16:27 |
flaper87 | it was created by that client, though | 16:27 |
kgriffs | yes, true | 16:27 |
flaper87 | any client holding that same claim id can still consume the claim | 16:27 |
kgriffs | "created_by" | 16:27 |
flaper87 | kk | 16:27 |
zyuan | listing? | 16:28 |
kgriffs | uuid is how many bytes, zyuan? | 16:28 |
zyuan | is that helpful? | 16:28 |
flaper87 | 34 ? | 16:28 |
alcabrera | 36 | 16:28 |
flaper87 | damnit! | 16:28 |
kgriffs | zyuan: someone thought it would be | 16:28 |
flaper87 | :D | 16:28 |
alcabrera | len(str(uuid.uuid4())) => 36 | 16:28 |
zyuan | 16 | 16:28 |
zyuan | an 128 bit integer | 16:29 |
kgriffs | in bson it is 16, right? | 16:29 |
zyuan | anywhere | 16:29 |
alcabrera | ahh, uuid as int | 16:29 |
kgriffs | so, 16 bytes extra per claimed message. seems reasonable. | 16:29 |
zyuan | waitwaitwait | 16:29 |
alcabrera | uuid.uuid1().int - gtk | 16:29 |
zyuan | in message, it's hex form | 16:30 |
zyuan | ~36 | 16:30 |
kgriffs | (plus a little overhead for the field name) | 16:30 |
kgriffs | zyuan: only when serialized, right? | 16:30 |
zyuan | 16 in storage | 16:30 |
kgriffs | i mean, in mongo we just stick it in the claim doc | 16:30 |
flaper87 | right | 16:30 |
zyuan | ~36 in JSON | 16:30 |
kgriffs | ok | 16:30 |
kgriffs | seems like space wouldn't be a big deal | 16:30 |
alcabrera | also gtk - uuid.UUID(uuid_as_str).int works | 16:31 |
flaper87 | and it is 32 | 16:31 |
flaper87 | (whithout - ) | 16:31 |
flaper87 | without | 16:31 |
flaper87 | which is what we're using, IIRC | 16:31 |
kgriffs | ok, let's tentatively plan this for v1.1 | 16:32 |
flaper87 | +1 | 16:32 |
alcabrera | +1 | 16:32 |
flaper87 | alcabrera: str(uuid) adds -, uuid.hex gives you the real hex repr | 16:32 |
zyuan | we use str with - | 16:32 |
zyuan | we accept hex only as well | 16:33 |
flaper87 | zyuan: kk, thanks for the hint! | 16:33 |
kgriffs | two more things i'd like to try and triage today | 16:33 |
kgriffs | #topic List claims for a given queue | 16:34 |
kgriffs | user request | 16:34 |
kgriffs | not sure how useful it is | 16:34 |
zyuan | 0 interests | 16:34 |
flaper87 | 0 interest | 16:34 |
flaper87 | -1 from me! | 16:34 |
zyuan | this is how the conversation wents | 16:34 |
flaper87 | that may work as an admin endpoint or something | 16:34 |
flaper87 | but I don't think it'll be of any help for real messaging systems | 16:35 |
alcabrera | sounds useful in the context of /stats - # active claims on a given queue. | 16:35 |
flaper87 | also, that will make it difficult to support all kind of storage | 16:35 |
kgriffs | alcabrera: +1 | 16:35 |
alcabrera | so... +1 as an admin endpoint | 16:35 |
alcabrera | -1 as a user endpoint | 16:35 |
kgriffs | i think a user could find it useful | 16:35 |
kgriffs | maybe use it for autoscaling or something | 16:36 |
kgriffs | (the count) | 16:36 |
kgriffs | (not the list) | 16:36 |
zyuan | too much, too trikey | 16:36 |
flaper87 | I agree with zyuan here! | 16:36 |
mpanetta | Sounds like a way to introduce a race... | 16:36 |
kgriffs | yes, the stat would be difficult to do and make fast | 16:36 |
kgriffs | knowing claimed vs free should be sufficient | 16:37 |
flaper87 | I'd rather use N queues or N messages for autoscalling - or a ratio of those 2. | 16:37 |
kgriffs | TBH, I think this request came from someone who just wanted to make sure their claim succeeded | 16:37 |
alcabrera | +1 - message # sounds like it'd the core load metric | 16:37 |
zyuan | if you get it from claim, then it *is* successed... | 16:38 |
kgriffs | ok, so strike this one? | 16:38 |
zyuan | .rej | 16:38 |
flaper87 | reject! | 16:38 |
alcabrera | reject~ | 16:39 |
kgriffs | #info do not implement listing claims per queue | 16:41 |
kgriffs | #info existing stats should suffice for scaling metrics | 16:41 |
kgriffs | #topic Automatically create queues the first time a message is posted to it | 16:41 |
kgriffs | last one | 16:41 |
kgriffs | (last topic) | 16:41 |
kgriffs | flaper87: this one was your suggestion, right? | 16:41 |
flaper87 | kgriffs: correct! | 16:42 |
mpanetta | Ooo | 16:42 |
zyuan | hmm | 16:42 |
flaper87 | I think this one could be expanded a bit, TBH! | 16:42 |
zyuan | i think we are going to have control panel to create queue | 16:43 |
alcabrera | hmmm | 16:43 |
zyuan | now we are going to see queues created by typos in the panel | 16:43 |
flaper87 | I mean, depending on the storage backend, we may want to stop treating queues as resources | 16:43 |
flaper87 | but that's up to the storage | 16:43 |
zyuan | i know | 16:43 |
alcabrera | so pros - one less call to post a message (-PUT queue), and cons: a typo creates a queue. | 16:44 |
flaper87 | I just wanted to mention some of the things that are possible | 16:44 |
flaper87 | alcabrera: not sure about the type creates a queue | 16:44 |
zyuan | and... it can actually decrease 204 vs 404 complains | 16:44 |
zyuan | hehe | 16:44 |
flaper87 | I mean, not sure what you mean | 16:44 |
flaper87 | :D | 16:44 |
zyuan | so, if queue is nolonger regarded as a resource | 16:45 |
zyuan | it's just fine if we don;t return 404 if it's not there | 16:45 |
zyuan | it's just an attribute of message | 16:45 |
alcabrera | To clarify on that con - | 16:45 |
flaper87 | but, mmh, we won't be able to have metadata for that queue | 16:46 |
flaper87 | mmh | 16:46 |
alcabrera | If someone develops an application where they have workers reading from queues/feed, and they have producers that POST to queues/feeed/messages... :x | 16:46 |
flaper87 | if we don't treat it as resource, I mean | 16:46 |
flaper87 | btw, this is v2 material! | 16:46 |
flaper87 | just want to make that point clear! | 16:46 |
zyuan | yea. i can't quickly think of how this is being implemented, but i suspect that it has some value | 16:47 |
kgriffs | #info lazy queues would be for v2 if we do it, not v1.1 | 16:47 |
alcabrera | +1 for v2 feature | 16:48 |
zyuan | lgtm | 16:48 |
flaper87 | the value I see in this is the lazyness of the API, it would work mostly as mongodb collections do! | 16:48 |
alcabrera | I'm rather in favor of it | 16:48 |
flaper87 | plus other things, obviously | 16:48 |
flaper87 | but that's the one in terms of API semantic | 16:48 |
alcabrera | ooohh, idea for dealing with that whole typo issue... :D | 16:48 |
flaper87 | haha | 16:49 |
alcabrera | So, what if... | 16:49 |
alcabrera | We had a query flag | 16:49 |
alcabrera | That by derfault allowed lazy creation | 16:49 |
alcabrera | But if users preferred the checking behavior (maybe for debug dev?) | 16:49 |
alcabrera | That they could set to True | 16:49 |
flaper87 | alcabrera: that could work! | 16:49 |
alcabrera | E.g. | 16:49 |
alcabrera | strict=False | 16:49 |
alcabrera | something like that | 16:49 |
flaper87 | however, I'd let the client and API discovery take care of that | 16:49 |
flaper87 | :D | 16:50 |
flaper87 | the API discovery should be ready before this work start | 16:50 |
alcabrera | +1 | 16:50 |
kgriffs | #info mitigate typos with a sticy/lazy flag on the operation | 16:50 |
flaper87 | and the client should fully support v1 | 16:50 |
kgriffs | s/sticy/strict | 16:50 |
flaper87 | which would make it easier to migrate it to v2 | 16:50 |
flaper87 | I hope | 16:50 |
* flaper87 hopes | 16:51 | |
flaper87 | everybody hopes | 16:51 |
alcabrera | agreed | 16:51 |
kgriffs | ok | 16:52 |
kgriffs | that's all folks! | 16:52 |
kgriffs | #endmeeting | 16:52 |
openstack | Meeting ended Tue Oct 29 16:52:12 2013 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:52 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/marconi_api/2013/marconi_api.2013-10-29-16.03.html | 16:52 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/marconi_api/2013/marconi_api.2013-10-29-16.03.txt | 16:52 |
openstack | Log: http://eavesdrop.openstack.org/meetings/marconi_api/2013/marconi_api.2013-10-29-16.03.log.html | 16:52 |
alcabrera | w00t | 16:52 |
kgriffs | I will add the minutes to the wiki | 16:52 |
* flaper87 just saw Bugs Bunny face! | 16:52 | |
flaper87 | thanks! | 16:52 |
flaper87 | glad we did this meeting! | 16:52 |
zyuan | \O/ | 16:53 |
alcabrera | with a daily meeting, we'll yet triage all the BPs and accumulate notes for rationale. | 16:53 |
zyuan | not all, there are HTTP ones | 16:54 |
zyuan | maybe tomorrow | 16:54 |
alcabrera | zyuan: there's also these: https://blueprints.launchpad.net/marconi | 16:54 |
kgriffs | https://wiki.openstack.org/wiki/Marconi/specs/api/next | 16:54 |
alcabrera | :D | 16:54 |
kgriffs | i want to let that stew for a bit before creating bps | 16:54 |
zyuan | i mean this https://wiki.openstack.org/wiki/Marconi/specs/api/next | 16:54 |
kgriffs | in fact, maybe even just wait until after the design session | 16:55 |
kgriffs | alcabrera: yes, we also need to triage blueprints and bugs after we get through the API things | 16:55 |
alcabrera | +1 | 16:56 |
flaper87 | http://www.youtube.com/watch?v=1coLC-MUCJc&feature=youtu.be | 16:56 |
flaper87 | brb | 16:56 |
alcabrera | flaper87: how do you feel about tackling another sharding patch today? :) | 16:56 |
alcabrera | flaper87: oooohh, Tulip/asyncio video, HMMMM | 16:57 |
alcabrera | bookmark'd | 16:57 |
kgriffs | flaper87: https://review.openstack.org/#/c/52160/ | 16:59 |
kgriffs | :D | 16:59 |
kgriffs | :D | 16:59 |
kgriffs | :D | 16:59 |
*** tedross has quit IRC | 17:00 | |
cpallares | alcabrera: how do I remove those items from the commit? (also I'm not sure how they got there in the first place) | 17:01 |
alcabrera | cpallares: hmmm... | 17:01 |
alcabrera | for 'marconi/queues/transport/wsgi/shards.py' and 'tests/unit/queues/transport/wsgi/test_shards.py', you can do 'git rm file' | 17:03 |
alcabrera | I believe that should take care of that. | 17:03 |
alcabrera | Then for... | 17:03 |
alcabrera | 'marconi/common/transport/wsgi/utils.py' | 17:03 |
alcabrera | it might be enough to do something like 'git mv marconi/common/transport/wsgi/utils.py marconi/proxy/transport/utils.py' | 17:04 |
alcabrera | *'git rm <file>' | 17:04 |
alcabrera | brb | 17:09 |
*** alcabrera is now known as alcabrera|afk | 17:10 | |
*** yassine has quit IRC | 17:13 | |
*** amitgandhi has quit IRC | 17:17 | |
*** amitgandhi has joined #openstack-marconi | 17:18 | |
*** tedross has joined #openstack-marconi | 17:18 | |
*** mpanetta is now known as mpanetta_lunch | 17:22 | |
*** flaper87 is now known as flaper87|afk | 17:22 | |
mpanetta_lunch | Hey guys, one enhancement, you may want top log any condition that would cause a 500 error... | 17:22 |
*** amitgandhi has quit IRC | 17:23 | |
kgriffs | mpanetta_lunch: can u create a bug? https://bugs.launchpad.net/marconi/+filebug | 17:26 |
*** amitgandhi has joined #openstack-marconi | 17:30 | |
kgriffs | amitgandhi: ^^^ | 17:42 |
kgriffs | if you guys aren't seeing 500's logged, feel free to create a bug report | 17:42 |
amitgandhi | ? | 17:43 |
amitgandhi | i may be missing the discussion | 17:43 |
kgriffs | check the other channel | 17:43 |
*** alcabrera|afk is now known as alcabrera | 17:52 | |
mpanetta_lunch | kgriffs: Yep | 17:56 |
*** ayoung has quit IRC | 17:56 | |
*** ayoung has joined #openstack-marconi | 17:57 | |
*** mpanetta_lunch is now known as mpanetta | 18:00 | |
mpanetta | kgriffs: bug created | 18:01 |
alcabrera | mpanetta: thanks! | 18:01 |
mpanetta | alcabrera: No problem | 18:03 |
ametts | alcabrera: You live on #cloudqueues? | 18:03 |
mpanetta | kgriffs: it won't let me set priority :P | 18:05 |
mpanetta | I would like to make it high... | 18:05 |
mpanetta | it is impacting debugging issues seen in LA. | 18:05 |
*** kgriffs is now known as kgriffs_afk | 18:08 | |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 18:28 |
*** tedross has quit IRC | 18:32 | |
*** kgriffs_afk is now known as kgriffs | 18:33 | |
mpanetta | welcome back | 18:36 |
mpanetta | You are a wanted man | 18:36 |
mpanetta | kgriffs: ^^ | 18:36 |
ametts | Time for one or more of these: http://3.bp.blogspot.com/-I9Jlv9oUd8I/TxyTGzDhvoI/AAAAAAAAANw/8ArcsgFoIi0/s400/the_greatest_american_hero-show.jpg | 18:46 |
kgriffs | LOL | 18:46 |
zyuan | ...... | 18:47 |
mpanetta | Oh man I used to watch that show as a kid ametts | 18:50 |
*** tedross has joined #openstack-marconi | 18:56 | |
*** tedross has quit IRC | 19:10 | |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 19:17 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: add catalogue storage driver for queues https://review.openstack.org/52160 | 19:18 |
vkmc | Go cpallares \o/ | 19:18 |
* alcabrera hopes that Jenkins will approve of cpallares efforts | 19:19 | |
alcabrera | :D | 19:19 |
* cpallares agrees with alcabrera, c'mon Jenkins | 19:20 | |
vkmc | cpallares, Do you know about zuul? http://status.openstack.org/zuul/ | 19:22 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: integrate shard storage with transport https://review.openstack.org/50998 | 19:23 |
cpallares | vkcm: no, what is it? | 19:23 |
cpallares | vkmc: oooo graphs | 19:23 |
vkmc | You can check how is your patch doing with the tests... live! :) | 19:23 |
vkmc | So you start celebrating (or flipping tables...) earlier | 19:24 |
cpallares | vkmc: haha | 19:25 |
alcabrera | vkmc: hahaha, tables have been flipped for the sake of jenkins in the past. :P | 19:25 |
alcabrera | cpallares: do you know about how to run the checks (pep8, unit tests) locally? :) | 19:25 |
zyuan | cpallares: do you need my help? | 19:25 |
zyuan | i can fetch the patch down, fix it, send | 19:25 |
cpallares | alcabreara: no, how do i do that? | 19:27 |
zyuan | tox | 19:27 |
alcabrera | cpallares: you can run 'tox -e pep8' to do style checks, 'tox -e py27' to run unit tests. | 19:27 |
alcabrera | If you have mongodb installed locally, as well, you can run a more complete unit test suite by issuing 'MARCONI_TEST_MONGODB=1 tox -e py27' | 19:28 |
alcabrera | where that'll run through the full storage suite using mongodb in addition to sqlite. | 19:28 |
zyuan | that only works for `sh`-like shells | 19:28 |
zyuan | use `env VAR=1 cmd` | 19:28 |
cpallares | what is pep8? Is py27, python 2.7? | 19:30 |
alcabrera | cpallares: pep8 is both a style standard for python (http://www.python.org/dev/peps/pep-0008/) and a style checking tool (https://pypi.python.org/pypi/flake8 - pyflakes + pep8 checker). | 19:31 |
alcabrera | py27 is python 2.7 - yes. :) | 19:31 |
kgriffs | alcabrera: oooh, you rebased those? | 19:32 |
alcabrera | kgriffs: yup! Conflicts resolved and all. | 19:32 |
kgriffs | cherry picking works w/o conflicts now | 19:32 |
kgriffs | thanks! | 19:32 |
alcabrera | np. :D | 19:33 |
cpallares | oh and then the py33 is the newest one? | 19:33 |
alcabrera | cpallares: yup! The only downside is that py33 will always fail, because a few of our dependencies don'yt support python 3.3 yet. :( | 19:34 |
zyuan | yes, but it's not required to pass (and it does not pass, but mostly not our fault) | 19:34 |
alcabrera | which is fine by jenkins. | 19:34 |
alcabrera | since we have that gate set in non-voting mode (jenkins won't -1 you for failing py33 tests) | 19:34 |
alcabrera | there's also tox -e pypy, which runs against the latest pypy release (if you have it installed and on your path as pypy). | 19:35 |
*** amitgandhi has quit IRC | 19:36 | |
zyuan | kgriffs: https://bugs.launchpad.net/marconi/+bug/1239834 what is the problem? | 19:36 |
alcabrera | kgriffs: thanks for the +2s! | 19:36 |
*** malini is now known as malini_afk | 19:39 | |
kgriffs | alcabrera: I'm seeing all the shard tests fail | 19:56 |
kgriffs | connection error | 19:56 |
kgriffs | any ideas? | 19:56 |
kgriffs | I'm about to go spelunking | 19:56 |
openstackgerrit | Chad Lung proposed a change to openstack/python-marconiclient: Updated the readme to have valid links https://review.openstack.org/54406 | 19:57 |
*** amitgandhi has joined #openstack-marconi | 19:58 | |
alcabrera | kgriffs: hmm... weird. | 19:58 |
kgriffs | ok, that's just odd. running just tests.unit.queues.transport.wsgi.test_shards:ShardsMongoDBTests is OK | 19:59 |
*** amit has joined #openstack-marconi | 19:59 | |
*** amit is now known as Guest62118 | 19:59 | |
kgriffs | but running tests.unit.queues.transport.wsgi causes the thing to show up | 20:00 |
kgriffs | "connection reset by peer" | 20:00 |
kgriffs | must be the mongo connection | 20:00 |
kgriffs | hmmm | 20:00 |
*** vkmc has quit IRC | 20:00 | |
*** Guest62118 has quit IRC | 20:00 | |
*** vkmc has joined #openstack-marconi | 20:00 | |
*** vkmc has quit IRC | 20:00 | |
*** vkmc has joined #openstack-marconi | 20:00 | |
alcabrera | I haven't run into that error before. | 20:00 |
alcabrera | However, I did notice that test_lookup (sharding test, I think?) fails if you only run a subset of the unit test suite. | 20:01 |
openstackgerrit | Chad Lung proposed a change to openstack/python-marconiclient: Updated the readme to have valid links https://review.openstack.org/54406 | 20:02 |
*** amitgandhi has quit IRC | 20:03 | |
*** amitgandhi has joined #openstack-marconi | 20:04 | |
kgriffs | yeah, looks like a mongod connection error. I unset MARCONI_TEST_MONGODB for now | 20:12 |
alcabrera | I'm also working on making the | 20:22 |
alcabrera | unit test suite for sharding more thorough | 20:22 |
alcabrera | It'll probably be inheriting from the storage base, just ensuring that the sharding.DataDriver is used. | 20:23 |
alcabrera | (and initializes the shard catalogue appropriately) | 20:23 |
alcabrera | sometimes I look at our unit test suite, and I think, "The way we've put this together is pretty crazy/awesome!" | 20:23 |
kgriffs | rock on | 20:29 |
alcabrera | I'm out for the day. | 20:30 |
alcabrera | More sharding tomorrow~ | 20:30 |
alcabrera | take care, guys. :) | 20:30 |
*** alcabrera has quit IRC | 20:31 | |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 20:34 |
kgriffs | fwiw, I'm working on adding cache support to the sharding driver | 20:36 |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 20:40 |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 20:45 |
mpanetta | kgriffs: Do you know what marconi will do if it can't talk to the backend DB during a queue operation? | 20:47 |
kgriffs | should return 503 | 20:48 |
mpanetta | Ok | 20:48 |
*** malini_afk is now known as malini | 20:55 | |
malini | mpanetta: ping | 20:55 |
mpanetta | I'm here | 20:56 |
malini | Just saw ur mail.. | 20:56 |
malini | the tests are in the same repo as marconi code | 20:56 |
mpanetta | Oh? | 20:57 |
mpanetta | Ok | 20:57 |
mpanetta | Checking it out now | 20:58 |
malini | Do you see my private chat? | 20:59 |
mpanetta | malini: zyuan wanted me to put in more info in my bug | 20:59 |
mpanetta | But I am not quite sure what to put | 20:59 |
mpanetta | Let me send you a link | 20:59 |
malini | hmm..we cant put in more info becaues we dont know yet why the reqs are not showing up in the logs :( | 21:00 |
mpanetta | That is what I was thinking | 21:00 |
mpanetta | Here is my bug, with comments: https://bugs.launchpad.net/marconi/+bug/1245987 | 21:00 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: Sync with global requirements https://review.openstack.org/54415 | 21:02 |
*** reed has quit IRC | 21:07 | |
*** jergerber has quit IRC | 21:07 | |
*** flaper87|afk has quit IRC | 21:07 | |
*** westmaas has quit IRC | 21:07 | |
*** cpallares has quit IRC | 21:08 | |
mpanetta | malini: Since you are working with both me and zyuan can you also comment on that bug please? | 21:12 |
malini | sure..I am just starring at it right now figuring out what to comment :D | 21:13 |
zyuan | mpanetta: i looked and commentted | 21:13 |
mpanetta | zyuan: Ok. Ill take a look in a sec | 21:13 |
ametts | malini: Do you have a quick way to make a whole bunch of queue creation calls in IAD (see the email thread in the Queues list) | 21:13 |
malini | ametts: sure..I can run a small tsung test | 21:14 |
zyuan | mpanetta: starts gunicorn on a terminal, shown me the messy stuff left on the terminal (those did not go to log) | 21:14 |
malini | ametts: create & delete queus | 21:14 |
*** jergerber has joined #openstack-marconi | 21:14 | |
*** flaper87|afk has joined #openstack-marconi | 21:14 | |
*** westmaas has joined #openstack-marconi | 21:14 | |
*** hobana.freenode.net sets mode: +o flaper87|afk | 21:14 | |
ametts | Sure, that'd work. Just wondering if we have a bad node or something. | 21:14 |
*** ayoung has quit IRC | 21:14 | |
mpanetta | zyuan: Unfortunately I can't do that on our servers :( | 21:15 |
mpanetta | If I break away from how prod does things I have no way to know if we are breaking things because we are doing it special or if something else is broken. | 21:15 |
*** reed has joined #openstack-marconi | 21:16 | |
zyuan | mpanetta: how the server is started? | 21:17 |
zyuan | mpanetta: server should has its backup logging other than marconi logging | 21:18 |
zyuan | otherwise, you just lose crash information | 21:18 |
mpanetta | The instance never crashes | 21:18 |
mpanetta | We are using uwsgi | 21:19 |
zyuan | the "backup logging" can be terminal, or see uwsgi's manual | 21:19 |
zyuan | uwsgi is a container | 21:19 |
zyuan | it restartes marconi app when it crashes | 21:19 |
mpanetta | Yeah it is logging to greylog at the moment. | 21:19 |
zyuan | then get that log to me | 21:19 |
mpanetta | Yeah, I have not seen any restart messages either :( | 21:19 |
mpanetta | Um, will have to talk to oz about that | 21:19 |
zyuan | otherwise, i have nothing to look at... | 21:20 |
mpanetta | I know :( | 21:20 |
mpanetta | That is the problem, I don't think we have anything to show you | 21:20 |
mpanetta | Ican show you the client side errors | 21:20 |
mpanetta | But I can't find any log entries that match the errors on the client in time. | 21:21 |
zyuan | just a 500 without traceback... | 21:21 |
mpanetta | Not even a 500 | 21:21 |
zyuan | ? | 21:21 |
mpanetta | The 500 only gets logged on the client side | 21:21 |
zyuan | yea, i mean the client error | 21:21 |
mpanetta | Oh | 21:21 |
mpanetta | Malini has that | 21:21 |
mpanetta | I will in a few mins | 21:21 |
mpanetta | After I get her test set up on my system | 21:21 |
*** ayoung has joined #openstack-marconi | 21:22 | |
malini | ametts: just sent the IAD results..It looks ok | 21:25 |
ametts | Great -- thanks! | 21:26 |
ametts | Am I reading this right -- you created and deleted 17 queues? | 21:27 |
ametts | malini^ | 21:27 |
malini | yes | 21:27 |
ametts | Queue creation is pretty lightweight, isn't it? What if we created and destroyed 1,000 queues? | 21:28 |
ametts | queues and messages are all just database entries. | 21:28 |
mpanetta | zyuan: | 21:31 |
mpanetta | https://gist.github.com/anonymous/4941115aafbfe168cccb | 21:31 |
zyuan | thanks | 21:31 |
mpanetta | No problem :) | 21:33 |
mpanetta | zyuan: I should be thanking you :) | 21:35 |
zyuan | hmm, not yet... | 21:36 |
mpanetta | haha ok | 21:36 |
*** amitgandhi has quit IRC | 21:43 | |
*** amitgandhi has joined #openstack-marconi | 21:44 | |
*** amitgandhi has quit IRC | 21:48 | |
mpanetta | zyuan: ping | 22:14 |
*** malini is now known as malini_afk | 22:26 | |
*** oz_akan_ has quit IRC | 22:29 | |
mpanetta | kgriffs: I have a surprise for you | 22:34 |
mpanetta | kgriffs: the verify_sha function you wrote uses the tag instead of the commit sha, if there is a tag... | 22:36 |
mpanetta | Just FYI | 22:36 |
mpanetta | I would consider this a feature BTW :) | 22:36 |
mpanetta | It also converts - to . apparently | 22:37 |
*** mpanetta has quit IRC | 22:41 | |
openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: chore: Pass cache into drivers https://review.openstack.org/54445 | 22:51 |
openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: feat: integrate shard storage with transport https://review.openstack.org/50998 | 22:51 |
*** jcru has quit IRC | 22:52 | |
*** fifieldt has joined #openstack-marconi | 23:28 | |
*** jergerber has quit IRC | 23:31 | |
*** kgriffs is now known as kgriffs_afk | 23:32 | |
*** oz_akan_ has joined #openstack-marconi | 23:40 | |
*** oz_akan_ has quit IRC | 23:44 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!