*** oz_akan_ has quit IRC | 00:01 | |
*** amitgandhi has quit IRC | 00:01 | |
*** flwang has quit IRC | 00:02 | |
*** oz_akan_ has joined #openstack-marconi | 00:17 | |
*** flwang has joined #openstack-marconi | 00:17 | |
*** oz_akan_ has quit IRC | 00:21 | |
*** rongze has joined #openstack-marconi | 00:42 | |
*** rongze has quit IRC | 00:46 | |
*** amitgandhi has joined #openstack-marconi | 00:57 | |
*** amitgandhi has quit IRC | 01:02 | |
*** rongze has joined #openstack-marconi | 01:15 | |
*** oz_akan_ has joined #openstack-marconi | 01:18 | |
*** oz_akan_ has quit IRC | 01:22 | |
*** rongze has quit IRC | 01:34 | |
*** oz_akan_ has joined #openstack-marconi | 01:47 | |
*** rongze has joined #openstack-marconi | 01:49 | |
*** fifieldt has joined #openstack-marconi | 01:54 | |
*** amitgandhi has joined #openstack-marconi | 01:58 | |
*** flwang has quit IRC | 02:02 | |
*** amitgandhi has quit IRC | 02:02 | |
*** fifieldt has quit IRC | 02:15 | |
*** amitgandhi has joined #openstack-marconi | 03:08 | |
*** amitgandhi has quit IRC | 03:13 | |
*** oz_akan_ has quit IRC | 03:41 | |
*** amitgandhi has joined #openstack-marconi | 03:58 | |
*** amitgandhi has quit IRC | 04:03 | |
*** oz_akan_ has joined #openstack-marconi | 04:12 | |
*** oz_akan__ has joined #openstack-marconi | 04:14 | |
*** oz_akan_ has quit IRC | 04:17 | |
*** oz_akan__ has quit IRC | 04:18 | |
*** rongze has quit IRC | 04:47 | |
*** rongze has joined #openstack-marconi | 04:48 | |
*** flwang has joined #openstack-marconi | 04:48 | |
*** rongze has quit IRC | 04:52 | |
*** oz_akan_ has joined #openstack-marconi | 05:04 | |
*** amitgandhi has joined #openstack-marconi | 05:09 | |
*** amitgandhi has quit IRC | 05:13 | |
*** rongze has joined #openstack-marconi | 05:18 | |
*** rongze has quit IRC | 05:20 | |
*** rongze_ has joined #openstack-marconi | 05:20 | |
*** rongze_ has quit IRC | 05:25 | |
*** chandankumar has joined #openstack-marconi | 05:48 | |
*** amitgandhi has joined #openstack-marconi | 05:59 | |
*** oz_akan_ has quit IRC | 06:03 | |
*** amitgandhi has quit IRC | 06:03 | |
*** rongze has joined #openstack-marconi | 06:18 | |
*** balajiiyer has quit IRC | 06:19 | |
*** rongze has quit IRC | 06:23 | |
*** rongze has joined #openstack-marconi | 06:28 | |
*** balajiiyer1 has joined #openstack-marconi | 06:50 | |
*** balajiiyer1 has quit IRC | 06:54 | |
*** amitgandhi has joined #openstack-marconi | 07:00 | |
*** amitgandhi has quit IRC | 07:04 | |
*** oz_akan_ has joined #openstack-marconi | 07:14 | |
*** oz_akan_ has quit IRC | 07:18 | |
*** rongze has quit IRC | 07:45 | |
*** balajiiyer1 has joined #openstack-marconi | 07:51 | |
*** rongze has joined #openstack-marconi | 07:51 | |
*** balajiiyer1 has quit IRC | 07:55 | |
*** amitgandhi has joined #openstack-marconi | 08:00 | |
*** amitgandhi has quit IRC | 08:05 | |
*** ykaplan has joined #openstack-marconi | 08:21 | |
*** balajiiyer1 has joined #openstack-marconi | 08:51 | |
*** balajiiyer1 has quit IRC | 08:56 | |
*** amitgandhi has joined #openstack-marconi | 09:01 | |
*** amitgandhi has quit IRC | 09:05 | |
*** amitgandhi has joined #openstack-marconi | 09:11 | |
*** amitgandhi has quit IRC | 09:15 | |
*** balajiiyer1 has joined #openstack-marconi | 09:52 | |
*** balajiiyer1 has quit IRC | 09:57 | |
*** amitgandhi has joined #openstack-marconi | 10:02 | |
*** amitgandhi has quit IRC | 10:06 | |
*** flwang has quit IRC | 10:11 | |
*** rongze_ has joined #openstack-marconi | 10:43 | |
*** haomaiwang has joined #openstack-marconi | 10:44 | |
*** haomaiwa_ has quit IRC | 10:46 | |
*** rongze has quit IRC | 10:46 | |
*** rongze_ has quit IRC | 10:48 | |
*** balajiiyer1 has joined #openstack-marconi | 10:53 | |
*** balajiiyer1 has quit IRC | 10:57 | |
*** amitgandhi has joined #openstack-marconi | 11:02 | |
*** amitgandhi has quit IRC | 11:06 | |
*** amitgandhi has joined #openstack-marconi | 11:12 | |
*** rongze has joined #openstack-marconi | 11:14 | |
*** flwang has joined #openstack-marconi | 11:16 | |
*** amitgandhi has quit IRC | 11:16 | |
*** rongze_ has joined #openstack-marconi | 11:18 | |
*** rongze has quit IRC | 11:19 | |
*** rongze_ has quit IRC | 11:22 | |
*** balajiiyer1 has joined #openstack-marconi | 11:54 | |
*** balajiiyer1 has quit IRC | 11:58 | |
*** rongze has joined #openstack-marconi | 12:02 | |
*** amitgandhi has joined #openstack-marconi | 12:03 | |
*** amitgandhi has quit IRC | 12:07 | |
*** rongze has quit IRC | 12:36 | |
*** rongze has joined #openstack-marconi | 12:37 | |
*** rongze has quit IRC | 12:42 | |
*** balajiiyer1 has joined #openstack-marconi | 12:54 | |
*** balajiiyer1 has quit IRC | 12:59 | |
*** rongze has joined #openstack-marconi | 13:03 | |
*** amitgandhi has joined #openstack-marconi | 13:03 | |
*** tedross has joined #openstack-marconi | 13:07 | |
*** amitgandhi has quit IRC | 13:08 | |
*** amitgandhi has joined #openstack-marconi | 13:13 | |
*** amitgandhi has quit IRC | 13:18 | |
*** ayoung has joined #openstack-marconi | 13:24 | |
*** jcru has joined #openstack-marconi | 13:46 | |
*** balajiiyer1 has joined #openstack-marconi | 13:47 | |
*** oz_akan_ has joined #openstack-marconi | 13:52 | |
*** balajiiyer1 has quit IRC | 14:01 | |
*** amitgandhi has joined #openstack-marconi | 14:04 | |
*** amitgandhi has quit IRC | 14:08 | |
*** cpallares has joined #openstack-marconi | 14:23 | |
*** oz_akan_ has quit IRC | 14:23 | |
*** oz_akan_ has joined #openstack-marconi | 14:24 | |
*** malini_afk is now known as malini | 14:34 | |
*** ykaplan has quit IRC | 14:38 | |
*** balajiiyer has joined #openstack-marconi | 14:39 | |
*** amitgandhi has joined #openstack-marconi | 14:41 | |
*** amitgandhi has quit IRC | 14:43 | |
*** balajiiyer has quit IRC | 14:46 | |
*** balajiiyer has joined #openstack-marconi | 14:46 | |
*** alcabrera has joined #openstack-marconi | 14:50 | |
alcabrera | Good morning! :) | 14:51 |
---|---|---|
*** amitgandhi has joined #openstack-marconi | 14:52 | |
*** amitgandhi has quit IRC | 14:52 | |
*** amitgandhi has joined #openstack-marconi | 14:53 | |
*** ykaplan has joined #openstack-marconi | 14:55 | |
cpallares | hello alcabrera! | 15:03 |
alcabrera | cpallares: hey! Happy new year! How are you? :D | 15:05 |
cpallares | alcabrera: happy new year :D | 15:06 |
cpallares | I'm doing good today, how about you? How was your new years? | 15:06 |
alcabrera | It was relaxing. I watched British comedy (QI) with my wife and house mate while we looked back on 2013. | 15:07 |
*** ametts has joined #openstack-marconi | 15:10 | |
cpallares | alcabrera: that sounds pleasant :) was the movie good? | 15:15 |
cpallares | I've never heard of it. | 15:15 |
alcabrera | cpallares: It's actually a trivia show. :D | 15:17 |
alcabrera | They put together 4 comedians along with Stephen Fry and they talk about little known but Quite Interesting facts. :) | 15:17 |
alcabrera | http://en.wikipedia.org/wiki/QI | 15:18 |
cpallares | alcabrera: ooooooh yeees I think I've seen a video of it. | 15:19 |
cpallares | alcabrera: this one https://www.youtube.com/watch?v=LjBnF0xqpfc | 15:19 |
alcabrera | cpallares: yup! That's the show. :D | 15:20 |
* cpallares was amazed at the hydrophobic sand | 15:21 | |
cpallares | alcabrera: I thought it was just a regular talk show. I think I'll start watching it now. | 15:22 |
cpallares | lol I thought Stephen Fry was a guest | 15:23 |
alcabrera | turns out he's the host! Allen Davis also appears on every show. Their interactions are a fun mainstay of the show. It makes for great dinner media. :) | 15:24 |
*** rongze has quit IRC | 15:34 | |
*** kgriffs_afk is now known as kgriffs | 15:42 | |
*** rongze has joined #openstack-marconi | 15:44 | |
malini | thanks alcabrera for the tempest review..You are faster than jenkins :) | 15:50 |
alcabrera | malini: :) | 15:53 |
alcabrera | Looked good to me - let's see what Jenkins thinks! | 15:53 |
malini | I hope Jenkins thinks like you ;) | 15:54 |
*** jergerber has joined #openstack-marconi | 16:23 | |
*** whenry has joined #openstack-marconi | 16:25 | |
*** ykaplan has quit IRC | 16:28 | |
*** wirehead_1 is now known as wirehead_ | 16:41 | |
*** rongze has quit IRC | 16:48 | |
*** rongze has joined #openstack-marconi | 16:49 | |
cpallares | kgriffs, if you're not too busy can you check this one? https://review.openstack.org/#/c/59508/ | 17:07 |
kgriffs | cpallares: I'll try to get to it today, but I'm working on a different project and may not get back around to marconi until tomorrow | 17:07 |
kgriffs | sorry for the wait! | 17:08 |
* kgriffs wishes he could clone himself sometimes | 17:08 | |
cpallares | no worries, kgriffs! And thanks | 17:10 |
*** rongze has quit IRC | 17:17 | |
*** rongze has joined #openstack-marconi | 17:18 | |
*** rongze has quit IRC | 17:18 | |
*** rongze has joined #openstack-marconi | 17:19 | |
*** rwsu has joined #openstack-marconi | 17:27 | |
*** alcabrera is now known as alcabrera|afk | 17:32 | |
*** rongze has quit IRC | 17:45 | |
*** rongze has joined #openstack-marconi | 17:47 | |
*** rossk has joined #openstack-marconi | 17:55 | |
*** alcabrera|afk is now known as alcabrera | 17:59 | |
*** rongze has quit IRC | 18:09 | |
*** amitgandhi has quit IRC | 18:36 | |
*** chandankumar has quit IRC | 18:38 | |
*** rongze has joined #openstack-marconi | 18:40 | |
*** amitgandhi has joined #openstack-marconi | 18:43 | |
*** amitgandhi has quit IRC | 18:44 | |
*** amitgandhi has joined #openstack-marconi | 18:44 | |
*** rongze has quit IRC | 18:45 | |
*** amit has joined #openstack-marconi | 18:49 | |
*** amit is now known as Guest84309 | 18:49 | |
*** ametts has quit IRC | 18:50 | |
*** amitgandhi has quit IRC | 18:52 | |
*** reed has joined #openstack-marconi | 18:56 | |
cpallares | hey alcabrera, I had forgotten about this lonely bug https://bugs.launchpad.net/marconi/+bug/1246373 | 19:00 |
* alcabrera checks | 19:00 | |
cpallares | alcabrera: but looking at it now, I'm not sure exactly what I'm supposed to do | 19:00 |
cpallares | the @property = lazy.property? | 19:00 |
cpallares | or did it change? | 19:00 |
cpallares | *lazy_property | 19:01 |
alcabrera | I'm trying to remember what this one was about. It's one of those times I wish I left myself more notes to understand what I was saying. :P | 19:01 |
cpallares | lol! " wish I left myself more notes to understand what I was saying" = the life of a developer :P | 19:03 |
alcabrera | cpallares: I think I see what I was saying when I wrote this up. | 19:03 |
alcabrera | hahaha, yup. | 19:03 |
*** rongze has joined #openstack-marconi | 19:03 | |
alcabrera | it's not about lazy.property | 19:03 |
*** ametts has joined #openstack-marconi | 19:04 | |
alcabrera | It's because there's no need to access a separate logical DB when working with the catalogue/sharding. Instead of having shards_database and catalogue_database, it made sense to expose a 'database' property. | 19:04 |
alcabrera | I partitioned it out early on out of habit when writing up that section, so now this refactoring bug ticket exists. :) | 19:04 |
alcabrera | s/writing/implementing | 19:05 |
cpallares | alcabrera: i'm not sure I understand :( | 19:07 |
alcabrera | hmmm | 19:07 |
alcabrera | I'm trying to understand the "why" of this ticket better myself. :/ | 19:07 |
cpallares | alcabrera: they should share the same database? | 19:08 |
alcabrera | cpallares: yup! I see more of the "why" now, reading the code. | 19:09 |
alcabrera | When I speak of logical DBs here, mongo has this notion of creating namespaces in a physical DB - that namespace is the logical component. | 19:09 |
alcabrera | Looking in marconi.queues.storage.mongodb.driver | 19:09 |
cpallares | https://github.com/openstack/marconi/blob/master/marconi/queues/storage/mongodb/driver.py#L128-L131 | 19:10 |
alcabrera | I see that the sharding map is stored in <logical_DB>_shards and the catalogue is stored in <logical_DB>_catalogue. | 19:10 |
alcabrera | cpallares: yes, there! Thanks! :) | 19:10 |
alcabrera | So since the entries stored in the database don't overlap (catalogue uses keys 'p_q', 's', shards uses keys ['n', 'o', 'u', 'w']) - | 19:11 |
alcabrera | they can be kept in the same logical DB | 19:11 |
cpallares | so the refactoring is to take off the + | 19:12 |
alcabrera | therefore, removing [shards_database, catalogue_database] for a single method, [database] | 19:12 |
alcabrera | cpallares: yup, or just exposing a single method - database | 19:12 |
alcabrera | either way works for me | 19:12 |
cpallares | alcabrera: aah okay and the code that uses it? | 19:12 |
cpallares | erm... or calls it, right? | 19:13 |
*** rongze has quit IRC | 19:13 | |
alcabrera | cpallares: if you take the 'remove the +' approach, you won't need to change code any where else. If you use the single method approach, yeah - you'll need to fix affected code. | 19:13 |
alcabrera | yup | 19:13 |
cpallares | alcabrera: which way do you think is better? | 19:13 |
cpallares | I think using one databate method would be cleaner. | 19:14 |
alcabrera | That's my thought, too. | 19:14 |
cpallares | alcabrera: okay then I'll do that, thank you :) | 19:14 |
alcabrera | Thanks! I'm curious to see how much would be affected. :) | 19:15 |
alcabrera | Note - if you take that approach, you'll need to modify marconi.queues.storage.base first. | 19:15 |
alcabrera | that'd be the abstract base for all of these storage drivers. | 19:15 |
cpallares | so make this https://github.com/openstack/marconi/blob/master/marconi/queues/storage/base.py#L111-L119 into one single one, right? | 19:16 |
alcabrera | yup! | 19:16 |
cpallares | alcabrera: what would be a good name for both of them? | 19:17 |
alcabrera | cpallares: oops, my eyes deceived me. >.> | 19:20 |
alcabrera | Actually, there's no need to modify ControllerDriverBase | 19:20 |
alcabrera | Since we're concerned about catalogue_database and shards_database, which aren't mentioned there. | 19:20 |
cpallares | alcabrera: haha yeah I was looking for the database part | 19:21 |
alcabrera | cpallares: I've also noticed that the sqlite driver uses the single method approach. That makes me feel even better about recommending using 'database' for the ControlDriver in mongodb. :) | 19:25 |
cpallares | ah that's good :) | 19:29 |
*** oz_akan_ has quit IRC | 19:34 | |
*** oz_akan_ has joined #openstack-marconi | 19:40 | |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Change shards & catalogue db into single property https://review.openstack.org/64719 | 20:13 |
alcabrera | cpallares: +2 - thanks for the quick patch! | 20:15 |
*** malini is now known as malini_afk | 20:50 | |
*** rongze has joined #openstack-marconi | 21:12 | |
*** rongze has quit IRC | 21:17 | |
alcabrera | Have a goodnight, everyone. :) | 21:22 |
*** alcabrera has quit IRC | 21:22 | |
*** tedross has quit IRC | 21:53 | |
*** cpallares has quit IRC | 22:09 | |
*** rongze has joined #openstack-marconi | 22:12 | |
*** sebasmagri has quit IRC | 22:13 | |
*** balajiiyer has quit IRC | 22:14 | |
*** sebasmagri has joined #openstack-marconi | 22:15 | |
*** rongze has quit IRC | 22:17 | |
*** Alex_Gaynor has quit IRC | 22:20 | |
*** Alex_Gaynor has joined #openstack-marconi | 22:25 | |
*** rwsu has quit IRC | 22:33 | |
*** Alex_Gaynor has quit IRC | 22:36 | |
*** rwsu has joined #openstack-marconi | 22:40 | |
*** Alex_Gaynor has joined #openstack-marconi | 22:41 | |
openstackgerrit | Alex Gaynor proposed a change to openstack/python-marconiclient: Expose the stats attribute on a queue. https://review.openstack.org/63005 | 22:43 |
*** jcru has quit IRC | 22:47 | |
*** rwsu has quit IRC | 22:59 | |
*** oz_akan_ has quit IRC | 23:04 | |
*** rwsu has joined #openstack-marconi | 23:12 | |
*** rongze has joined #openstack-marconi | 23:13 | |
*** rongze has quit IRC | 23:18 | |
*** Guest84309 has quit IRC | 23:25 | |
*** cpallares has joined #openstack-marconi | 23:33 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!